- 06 Aug, 2020 40 commits
-
-
nancylingwang authored
BUG=1083331 Change-Id: I91aa539a469d25dc283305def73287fdd34c114c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308624 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#795448}
-
Randy Rossi authored
Focus should only be set if the child tree is found. Otherwise, leave the focus set by the super method alone. This was causing the reader to lose focus on cast and webviews embedded in the display assistant's main tree. Bug: NONE Test: display assistant with youtube/weather app/page Change-Id: If82855ada00fa679806987e8f78332799d0e7015 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339497Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Commit-Queue: Randy Rossi <rmrossi@chromium.org> Cr-Commit-Position: refs/heads/master@{#795447}
-
Liquan (Max) Gu authored
Before: * PRImpl keeps the observer NativeObserverForTest as a local member, but the observer is set inconveniently with ComponentPaymentRequestDelegate. After: * PRImpl references the observer from ComponentPaymentRequestDelegate directly, no longer keeping it as PRImpl's own member. ComponentPaymentRequestDelegate does not need to help with setting the observer any more. Bug: 1102522 Change-Id: I2d35e498452441fbc696f12f76dcbd0e69eb31c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340227Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#795446}
-
Xi Han authored
enabled. Without the check, it will trigger InstantStart code path and shows the overview list layout. A crash would happen since the overview list layout is null. Bug: 1110791 Change-Id: If8dfd07118effe71a001286fcf9cb0e7279c8f31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336306 Commit-Queue: Xi Han <hanxi@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#795445}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7a171cca0ca4..34949e35f006 2020-08-06 robertphillips@google.com Pull ShapeData into its own header file and rename to GrSmallPathShapeData If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC herb@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: herb@google.com Change-Id: I76913bc8661bc4effe28893bb10500b7376bb5eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341108Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#795444}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/5d9552ef6987..76488e6d8e63 2020-08-06 fmayer@google.com Merge "Do not download t2t for --print-config." 2020-08-06 primiano@google.com Merge "Client Library: retry connections if traced is not running" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I4fef4144b8cf7ef1e960932a15ecc851c91fb3d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341104Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I9bc0a13644ebc38a0f825389d6cd9db0ce7d4440 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341109Reviewed-by:
-
Oleg Davydov authored
Event-based reporting is a way to gather more feedback from managed profiles by sending data about status of force-installed extensions. This CL adds extension type (browser extension, chrome app, theme etc) to the reports. Bug: b:161368099 Change-Id: Ia463a5df1287174b62212783872cde5adb915665 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329633 Commit-Queue: Oleg Davydov <burunduk@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#795441}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3a560b36ad16..de2a1c51379f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC fernandex@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: fernandex@google.com Change-Id: I42c50fbd7238ee1fc0c998dbc7652aa30ea053ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341024Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#795440}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/dcb6f8084e45..5d9552ef6987 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Iac957a29c4b38391f9146e23391c42a78845b9f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340638Reviewed-by:
-
Victor Hugo Vianna Silva authored
If the password of the primary signed-in account is stored locally (i.e. in the profile store), the bubble that offers moving it into the account should not be shown, since storing the password for an account within that same account doesn't make sense. Moving other Google account passwords is still valid. Bug: 1110894 Change-Id: I2be5b30ecb121e5db91e3ff33b98cba51af6430b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339980 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#795438}
-
Renato Silva authored
Remove the submit button on the pin pad shown on the login/lock screen. Change LoginPinView construction to only show the submit button on the pinpad when the |on_submit| callback is valid. Verified locally that it removes the memory leak LoginPinView from: https://crbug.com/1099306#c1 Bug: 1075994, 1101326, 1099306 Change-Id: Ib7de615c9f5c6faec168e1205e44a981f739f9a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339524 Commit-Queue: Renato Silva <rrsilva@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Auto-Submit: Renato Silva <rrsilva@google.com> Cr-Commit-Position: refs/heads/master@{#795437}
-
Kateryna Prokopenko authored
Addressing post-commit comments to CL: https://chromium-review.googlesource.com/c/chromium/src/+/2289841 Bug: chromium:1082628 Change-Id: I22ae9d66d9940f95a8faea654418e8aa9859e2b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2338796Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Kateryna Prokopenko <kprokopenko@google.com> Cr-Commit-Position: refs/heads/master@{#795436}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/4d2e095852b7..20d9bb09b493 2020-08-06 aerotwist@chromium.org Update copy paths to be absolute If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1113321 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I4c5baa1ca75bb95da7b65208ce6dd48c28f54dde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341103Reviewed-by:
-
Matt Jones authored
This patch moves the responsibility of tracking which tints are used in a frame to the ResourceManager. When a tinted resource is requested the ResourceManager tracks it instead of the TabListSceneLayer. When a frame is finalized, the CompositorView passes a signal to the ResourceManager to clear out any tinted resources that were not used in that frame. Bug: 1111772 Change-Id: I6f71aca94f1f05d413a4b3d0e83c39f11c4b7594 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2334992Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#795434}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/351fdfe7..ae523ca9 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I7105310cd287bfe864986b17a1a6351ede5fb838 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340183Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#795433}
-
Viktor Semeniuk authored
This change adds new entry point from Password Breach dialog to Passwords screen. Password Check will automatically start when page is opened. Mock: https://docs.google.com/presentation/d/1B_Cr6KlWXtjfG7pA1xk5r9vDNtszICNfN3KqH-T30Q0/edit#slide=id.g853bc68e3a_3_598 Bug: 1075494, 1113170 Change-Id: I5693b53c05078961df83f519d3a0175240f8db97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320170 Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#795432}
-
Mariam Ali authored
A feature and flag is added to control the menu item for creating an incognito desktop shortcut on Windows. Bug: 1113162 Change-Id: I76e77e018434f4116e09ae8199e7a16a648872c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2338775 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#795431}
-
Jonathan Mengedoht authored
Bug: 1086141 Change-Id: Ied9a69a6cb27e0f6c966075d6cfe2c07f4f45c57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287471 Commit-Queue: Jonathan Mengedoht <mengedoht@google.com> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
-
Anders Hartvoll Ruud authored
This function can return the static Variable instance, which is in the process of being removed. This CL moves the offense of potentially accessing the Variable instance to several call-sites, but we have to start somewhere. Each offending call-site is marked with the relevant crbug to make them easy to find in the future. Note that in CSSParserContext::ReportLayoutAnimationsViolationIfNeeded I added a check for kVariable variable instead, since the map of affected CSS properties does not contain the static Variable instance anyway. Bug: 980160 Change-Id: Id506f3c6de34414eb8ddc142f82d3723b1f0a7b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339519 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#795429}
-
Jérôme Lebel authored
Using the new methods from ChromeIdentityServiceImpl: bool HandleSessionOpenURLContexts(UIScene* scene, NSSet*) void ApplicationDidDiscardSceneSessions(NSSet*) * crrev.com/c/2316308 API declarations * crrev.com/i/3182384 Implementing APIs => crrev.com/c/2317321 Switching code to use the new APIs Fixed: 1103833 Change-Id: I97514ea2c05ea3405e83567a5377c4b92673976d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317321 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
-
Dominik Röttsches authored
Sheriffs, in case of failures in virtual/text-antialias/mac-system-ui-weight.html on WebKit Mac10.13 (retina), please disable the test on Mac10.13 - for more details, see https://bugs.chromium.org/p/chromium/issues/detail?id=1104846 https://chromium.googlesource.com/external/github.com/harfbuzz/harfbuzz.git/+log/e3af529e511c..cdb7d2b9bc0d $ git log e3af529e5..cdb7d2b9b --date=short --no-merges --format='%ad %ae %s' 2020-08-02 ebrahim [docs] Update README.python.md with meson 2020-08-02 ebrahim [docs] Adopt CONFIG.md with meson 2020-08-02 ebrahim [docs] Remove packagers related part 2020-08-02 ebrahim [ci] Disable Travis CI 2020-08-02 ebrahim [meson] limit check-libstdc++ check to 0.55 2020-07-30 ebrahim [meson] Add darwin versions to library() 2020-07-31 grieger [ENOMEM] check vector status in cmap subsetting. 2020-07-31 grieger [ENOMEM] in GSUB ChainContext subsetting check maps for allocation errors. 2020-07-31 grieger [ENOMEM] Check result of vector resize in CBDT subsetting. 2020-07-31 ebrahim [ci] don't install rustc on linux-ci 2020-07-31 ebrahim [cff] Check for scalars array resize result 2020-07-30 grieger [ENOMEM] popragate packed/packed_map errors to the serializer. Will disable further modifications based on a bad state. 2020-07-30 grieger [ENOMEM] unchecked resize in CFF2. 2020-07-30 grieger [ENOMEM] Fix several instances of not checking resize in CFF. 2020-07-30 grieger [ENOMEM] check for unset current in serializer->length(). 2020-07-30 ebrahim Copy parts of README.md to README 2020-07-30 ebrahim [meson] minor, use null_dep one more place 2020-07-30 ebrahim Remove cmake build files 2020-06-18 ebrahim Add comparison against ttf-parser 2020-07-30 ebrahim [docs] Update TESTING.md with meson 2020-07-29 grieger [ENOMEM] fix memory leak if allocation fails during pop_pack(). 2020-07-29 grieger [ENOMEM] make serializer modification operations no-ops if it's in an error state. 2020-07-30 ebrahim [icu] Remove support for versions older than 49 2020-07-30 ebrahim [icu] Remove useless HB_UNUSED tags 2020-07-30 ebrahim [icu] Remove support of ICU versions before 42 2020-07-29 grieger [ENOMEM] Fix failure to check calloc return. Fixes https://oss-fuzz.com/testcase-detail/6246465148813312. 2020-07-29 grieger [ENOMEM] check resize() return. Fixes https://oss-fuzz.com/testcase-detail/5641892164009984. 2020-07-29 ebrahim [docs] Use untouched result of rsvg-convert for HarfBuzz.svg render 2020-07-29 ebrahim [ci] Install meson's master 2020-07-29 ebrahim minor spacing tweak 2020-07-29 ebrahim minor spacing tweak 2020-07-29 ebrahim minor spacing tweak 2020-07-29 ebrahim [ENOMEM] Fix buffer's content check logic 2020-07-14 ebrahim [fuzz] Implement failing allocator 2020-07-29 ebrahim [glib] Default to glib's script type handling 2020-07-28 grieger [subset] bail out of subsetting if plan allocation fails. 2020-07-27 ebrahim [tests] minor 2020-07-27 ebrahim [tests] Use TTFont of fonttools to avoid temp files 2020-07-26 hamidrezabayat76 Use fonttools's python package instead of cli 2020-07-25 ebrahim [ci] meson-gcc-mingw to crossbuild-win32 2020-07-25 ebrahim [releasing] unbreak the build 2020-07-25 ebrahim [releasing] Use release buildtype 2020-07-25 ebrahim 2.7.0 2020-07-23 razrfalcon Remove unused code from the Khmer shaper. 2020-07-22 ebrahim [meson] Rename 'gtk_doc' option to 'docs' 2020-07-22 ebrahim [ci] Don't run cov-analyze 2020-07-22 ebrahim minor 2020-07-22 ebrahim [fuzz] increase shape fuzzer timeout 2020-07-20 boboniboni [tests] fix PGO build testing 2020-07-20 ebrahim [ci] disable clang nightly installation (...) 2020-06-10 ebrahim [meson] Implement disabled state for cairo/freetype/icu 2020-06-09 nirbheek meson: Export symbols for a DLL when not building statically 2020-06-08 khaledhosny [coretext] Properly check for macOS 10.10 2020-06-06 ebrahim [meson] Remove with_libstdcxx build option 2020-06-05 behdad s/blacklist/blocklist/g 2020-06-05 ebrahim [meson] Add -Bsymbolic-functions 2020-06-02 ebrahim [meson] Make gobject and introspection features automatic 2020-06-05 ebrahim minor, improve the need for graphite comment 2020-06-03 reiter.christoph [meson] Only pass required dependencies to everything 2020-06-04 ebrahim [style] Hide behind HB_EXPERIMENTAL_API compile flag 2020-04-21 ebrahim [style] Adopt with meson 2020-02-08 ebrahim [style] give ptem value when asked for opsz 2019-08-04 ebrahim [style] New experimental API, hb_style_get_value 2020-06-04 ebrahim [meson] fix with_libstdcxx effect 2020-06-04 ebrahim [meson] Update subset tests list from autotools 2020-06-04 ebrahim [ci] fix meson-gcc-mingw bot 2020-06-04 ebrahim [ci] check workability of meson based dist 2020-06-04 ebrahim [ci] Deploy only when there is something to push 2020-06-04 ebrahim [meson] Fix gen-hb-version.py run 2020-06-04 ebrahim [meson] Remove amalgam build option 2020-06-04 ebrahim [ci] Move docs deployment from autotools to meson 2020-06-03 ebrahim [meson] fix gen script input 2020-06-03 ebrahim Use output names in update-unicode-tables.make 2020-06-03 ebrahim 2.6.7 2020-06-02 ebrahim Move unicode tables update script to its own make file 2020-06-02 ebrahim minor, fix hb-version.h generation for out-of-tree builds 2020-06-02 ebrahim minor fixes on src gen scripts 2020-06-01 ebrahim Build win32 artifacts using meson 2020-05-31 ebrahim [tests/aots] move the update script to update.py 2020-05-31 ebrahim [tests/test-rendering-tests] run git pull on correct dir 2020-05-31 ebrahim minor, fix extra dist list 2020-05-31 ebrahim [test/text-rendering-tests] Adopt the update script with meson 2020-05-31 ebrahim [test/text-rendering-tests] Update from upstream 2020-05-31 ebrahim [tests] Port text-rendering-tests update script to python 2020-05-30 ebrahim [meson] Categorize tests using `suite: [...]` 2020-05-30 ebrahim [ci] fix alpine build issue 2020-05-29 ebrahim [tests] Port check scripts to python 2020-05-29 ebrahim [meson] reflect chosen linker update 2020-05-29 ebrahim [meson] minor, find run-tests.py only once 2020-02-18 qxliu [subset] GDEF AttachList subsetting support 2020-05-29 ebrahim minor on python scripts 2020-05-29 ebrahim minor, use py3's open(encoding=) 2020-05-28 ebrahim minor, enable printing to stderr in run-tests.py 2020-05-28 ebrahim minor, use sys.exit print shorthand 2020-05-28 ebrahim minor, move scripts manuals to __doc__ 2020-05-20 qxliu [subset] ChainContext subsetting fix: add lookup index remapping 2020-03-30 simon More strictly follow noun/verb/identifier format for GPOS/GSUB lookups 2020-03-30 simon Reformat kerx/morx instrumentation to 'verb noun identifier' 2020-03-30 simon Add table index to lookup messages 2020-03-30 simon Instrument entering GSUB/GPOS tables Created with: roll-dep src/third_party/harfbuzz-ng/src R=bashi@chromium.org,behdad@chromium.org,bungeman@chromium.org,drott@chromium.org,eae@chromium.org,jshin@chromium.org Change-Id: Ic57afe4b7785219f6c0405fc83c8e90270c26b34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339461Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#795427}
-
Tymofii Chudakov authored
Redesigning the content settings pages with radio buttons and new strings, behind this flag. Bug: 1113642 Change-Id: I882f91eca5e353453335838ee7a26188eaa4d780 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316162 Commit-Queue: Tymofii Chudakov <tchudakov@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Sean Harrison <harrisonsean@chromium.org> Cr-Commit-Position: refs/heads/master@{#795426}
-
Alex Ilin authored
This CL updates ProfileAttributesEntry::GetAvatarIcon() to return a colored person outline icon for users with placeholder (=default) avatars. Bug: 1100835 Change-Id: I49c19e4af24da82e48161b4b2d609ede69b3eead Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287314 Commit-Queue: Alex Ilin <alexilin@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Auto-Submit: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#795425}
-
Mugdha Lakhani authored
PrerenderManager was componentized here: https://chromium-review.googlesource.com/c/chromium/src/+/2332194 but two files in chrome/bowser got left behind due to a rebase. This simply deletes these files that aren't being used anymore. Bug: 1096088 Change-Id: I7488220900c3bdda89b9bbcf4758c24ef9625ee1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339554 Auto-Submit: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#795424}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/dcb6f8084e45..5d9552ef6987 2020-08-06 treehugger-gerrit@google.com Merge "Add no-op heapprofd client." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ie141928dbe83340b5a2c73d52fb456fc1ad08eb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340477Reviewed-by:
-
Anders Hartvoll Ruud authored
Previously, a StyleRuleScrollTimeline would produce a ScrollTimeline directly. This CL introduces CSSScrollTimelineOptions as an intermediate between the two. On its own, this is not terribly useful, but it will become useful in the future when we implement support for dynamically changing @scroll-timeline rules. We'd create *two* CSSScrollTimelineOptions instances: one from the updated @scroll-timeline rule, and one from the current ScrollTimeline of the running animation. Given those two CSSScrollTimelineOptions instances, we can then compare them for equality, and either do nothing if they are equal, or create and set a new ScrollTimeline if they are not. Bug: 1074052 Change-Id: Ic3c26beda1dc297a4f8e6c168fa3750f8a0c040b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332599 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#795422}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d3b495fd53af..4d2e095852b7 2020-08-06 sadym@chromium.org e2e tests for Idle Emulation 2020-08-06 jacktfranklin@chromium.org Component bridges: support interface inheritance 2020-08-06 wolfi@chromium.org Update CDP 2020-08-06 sigurds@chromium.org Revert "Eliminate initial timeout in waitForFunction" 2020-08-06 szuend@chromium.org [unittest] Add 'Settings' helper to set up settings storage 2020-08-06 szuend@chromium.org [issues] Re-introduce issues tab toolbar and third-party checkbox 2020-08-06 sigurds@chromium.org Remove reload banner in the issues tab If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1072335,chromium:1080589,chromium:1090802,chromium:1107766,chromium:1112692 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I5f202edaed6a2089d8c1ce27a2fee231ad2b1943 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340478Reviewed-by:
-
Anastasiia N authored
In "Add account" flow "Next" button is currently displayed by Gaia, inside the webview, but "Back" button is displayed by us. Since "GaiaActionButtons" feature in OOBE is enabled by default, we will display native action buttons in "Add account" (Chrome OS only) and "Add EDU account" flows too. Add "gaia-action-buttons" component and use "setPrimaryActionLabel", "setSecondaryActionLabel" etc. events to show navigation buttons. Bug: 1031534 Change-Id: Ibe89fe719362e17fe32e194e5913d733e3f4995b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279817Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Anastasiia N <anastasiian@chromium.org> Cr-Commit-Position: refs/heads/master@{#795420}
-
Viktor Semeniuk authored
This change adds sorting of compromised credentials and unit tests to the mediator. Bug: 1075494 Change-Id: I81d17eb1c80a4310be95c658c58fbcd17e4f8d83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339475 Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Reviewed-by:
-
Yoshifumi Inoue authored
This patch changes |MaxSizeFromMinSize::ComputeFromMinSize()| to avoid checking equality when line width calculation is saturated. Note: This CL is similar to the CL[1] which dose same thing in |NGLineBreaker|. [1] http://crrev.com/c/Make NGLineBreaker::ComputeLineLocation() to avoid DCHECK() when line width calculation saturated Bug: 1112560 Change-Id: I1e1cc1135412cebfc2e2c3cf635dc08fe19578a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340843 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
Emanuel Ziegler authored
Use V8's event-based metric collection to provide a recorder for UKM events for Wasm. Design doc: https://docs.google.com/document/d/1vCZQCh4B05isqwJOwTPv7WqcnVp4KJITMgsHSBg35ZI/ UKM collection review: https://docs.google.com/document/d/1Lkop99UNkA754knShPin9uP9kZJExwPXRy1jdj5IZjQ/ Bug: chromium:1101749 Bug: chromium:1092417 R=ulan@chromium.org R=haraken@chromium.org R=rkaplow@chromium.org Change-Id: I48f8c272ba4a3305145710fb3068bf3d5c4273be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288561 Commit-Queue: Emanuel Ziegler <ecmziegler@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#795417}
-
Koji Ishii authored
This patch: * Adds more DCHECKs where we're not operating post-layout fragments. * They actually hit in tests, this patch fixes: - NGPhysicalBoxFragment::ScrollableOverflowFromChildren - NGPhysicalContainerFragment::AddScrollableOverflowForInlineChild Bug: 965639 Change-Id: Ia2d5eeb7b78b2d2a3d8aa3d162fe6a6cca2a461f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339699Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#795416}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/bedac4f06b5c..b3545b42a10a 2020-08-06 timvp@google.com Get storage buffers/images from ProgramExecutable 2020-08-06 syoussefi@chromium.org Vulkan: Fix ImageHelper's move constructor If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: geofflang@google.com Test: Test: SimpleStateChangeTestES31.InvalidateThenStorageWriteThenBlendPpoTest: Test: VertexAttributeTestES31.UsePpoComputeShaderToUpdateVertexBuffer Change-Id: Iaa1f7699d1535ef36aba9409c6259e759d59ee0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340933Reviewed-by:
-
Pâris MEULEMAN authored
Follow up on [1] adding the same-origin version of the test. I.e. the first document of the popup is same-origin instead of cross-origin. 1: https://chromium-review.googlesource.com/c/chromium/src/+/2332260 Change-Id: I30a187b2c6a943abe44c5e3cff4e95ea36f5fccd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2338874 Commit-Queue: Pâris Meuleman <pmeuleman@chromium.org> Auto-Submit: Pâris Meuleman <pmeuleman@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#795414}
-
Ioana Pandele authored
This CL adds - the ability to start/stop the check - check status update - compromised credentials change message to the UI - saved passwords fetched call for the UI (this is used by safety check) The list of compromised credentials as well as check progress updates will be added in the next CLs. Bug: 1102025, 1092444 Change-Id: I3ad9af201d2158f956479a76b9ca8c184a05d397 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333845 Commit-Queue: Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f7f6b8b6f018..3a560b36ad16 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC fernandex@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: fernandex@google.com Change-Id: I415a16c1742858293cd4dccebb7a02d1f04c8e61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340574Reviewed-by:
-
Xida Chen authored
This reverts commit d6905eb4. Reason for revert： Per offline discussion with sadrul@ and flackr@, will limit this change to universal tracker. Original change's description: > Change to report the throughput metrics every 1 seconds > > After compared with interval of reporting the throughput metrics every > 1 second and 5 seconds, we found out that 1 second is closer to the real > data, so we decide to change to the interval to 1 second. > > Bug: 1040634 > Change-Id: I94527a45ffe390fc6d44a2430f52dcb2346d6cbe > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332978 > Reviewed-by: Xida Chen <xidachen@chromium.org> > Reviewed-by: Robert Flack <flackr@chromium.org> > Commit-Queue: Lan Wei <lanwei@chromium.org> > Cr-Commit-Position: refs/heads/master@{#795132} TBR=flackr@chromium.org,lanwei@chromium.org,xidachen@chromium.org Change-Id: Ic6ed30890891a59b02fff03cf9d80189a8b14a59 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1040634 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340983Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#795411}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4f52dde7..351fdfe7 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I8cb6b17de69c96b44145019992c01073d2b55966 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340982Reviewed-by:
-
Mohamed Amir Yosef authored
This CL checks body_container_ for nullness. body_container_ could be null if there are only footer items. Bug: 1113255,1108181 Change-Id: I9ed145c1d18baf8b13deab8c44cc510b3bb781eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339479 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
-
