- 29 May, 2020 40 commits
-
-
Chromium WPT Sync authored
Using wpt-import in Chromium 2a89e8bb. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=smcgruer No-Export: true Change-Id: I914fa38c6e51c607872619bf072148a1b3ac8ccc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220587Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#773160}
-
Nektarios Paisios authored
Anchor and focus offsets in accessibility selection may refer to children that are ignored but are included in the accessibility tree. We need to translate between ignored and unignored offsets at the platform boundary both when setting as well as when retrieving the selection. AX-Relnotes: Reading the current selection as well as setting the selection using Jaws and NVDA no longer reads the wrong selection or fails to set the selection. R=dmazzoni@chromium.org, aleventhal@chromium.org Bug: 1082814 Change-Id: I4530f3079eaa282d6db9778f7d6af221345841f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2205400 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#773159}
-
Victor Hugo Vianna Silva authored
This property had the wrong naming convention in the idl file. So when it was used in crrev.com/c/2219503, passwords_section started to consider every password had the same frontend id and tried to merge entries that were not really duplicates, causing the assertions in MultiStorePasswordUiEntry to fail and no password to be displayed in chrome://settings/passwords. TBR=stevenjb@chromium.org Bug: 1049141 Change-Id: Ic76b1f3ad574e02bec11c78bfe4a0425c911163f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218318Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#773158}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/b41baa411329..828485852b9c 2020-05-29 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 9e718f962f87 to 471c120ac92a (1 revision) 2020-05-29 angle-autoroll@skia-public.iam.gserviceaccount.com Roll glslang from e00d27c6d65b to d39b8afc47a1 (2 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ynovikov@google.com Change-Id: Ieee4a8ea073f7a6b0262e6ddcce819e97840e0a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222315Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#773157}
-
Nina Satragno authored
Disable the following flaky tests: * compositing/video/video-reflection.html * compositing/reflections/load-video-in-reflection.html TBR=schenney@chromium.org Bug: 1084637, 1083362 Change-Id: Ic12cee8fb21917bcc76681399f59a24068dc0cf3 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222520Reviewed-by:
Nina Satragno <nsatragno@chromium.org> Commit-Queue: Nina Satragno <nsatragno@chromium.org> Cr-Commit-Position: refs/heads/master@{#773156}
-
Ioana Pandele authored
Record the save UI dismissal reason after saving was re-enabled for the origin of the submitted form. Bug: 1044930 Change-Id: I10520f7f78ecc0392136ff805dda7ac96e393f23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209074 Commit-Queue: Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#773155}
-
Nigel Tao authored
I left this part out from the previous crrev.com/c/2212192 Bug: 1070409 Change-Id: I1abd821327aeb743bf9b5008a0b7f52233c0286a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222055Reviewed-by:
-
Mike Klein authored
The gamut named "SkNamedGamut::kDCIP3" is really the slightly different Display P3 gamut. This is a no-op refactor; the matrices are bitwise identical in Skia. Bug: skia:9792 Change-Id: I4405206337b919453d9cb58a09d9331f54591305 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216159Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Mike Klein <mtklein@google.com> Cr-Commit-Position: refs/heads/master@{#773153}
-
Annie Sullivan authored
Currently failing on Win7 only, but not possible to debug on CQ (or locally due to no office access). Disabled on Windows as a result. Bug: 943668 Change-Id: I1800b8afcb9a08353edd74921e94d0a4358ea35d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220487Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Annie Sullivan <sullivan@chromium.org> Cr-Commit-Position: refs/heads/master@{#773152}
-
Rohit Rao authored
The OS-provided MD5 functions in CommonCrypto.h are marked as deprecated starting in iOS 13. Avoid deprecation warnings by switching to the versions in //base/hash. (The //ios uses of MD5 do not require cryptographic security.) BUG=1086653 Change-Id: I15e6800f3c2587002eb4d6f1b52a998d5e14a254 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218470Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#773151}
-
Antonio Gomes authored
... instead of WebMediaStreamSource. Some trailing blink:: namespace declarations are also removed. This is part of the effort to reduce the needless use of public Blink APIs (wrappers) within renderer/modules. BUG=704136 R=guidou@chromium.org Change-Id: I2b175ec0ba57a8ccb452b55c2e412ecf7668fe88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218703 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#773150}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/259d8f40..1c3d8533 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ib199d57047fdc80e33ee8a1147a774bd9fe40ca3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222278Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#773149}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c67b36213f48..ae7ec62515ed 2020-05-29 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go Deps 2020-05-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 6a184fe947ed to 33004b09f180 (8 revisions) 2020-05-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from f752954c to a775f5d2 (485 revisions) 2020-05-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 9e718f962f87 to 471c120ac92a (1 revision) 2020-05-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll dawn from a3636ed8883d to 295a4177aebc (4 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC westont@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1075876,chromium:811661 Tbr: westont@google.com Test: Test: Test: TH presubmit Change-Id: I9a6ac0c4aa323cf90825bdd9b1d039b4f2edad7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222318Reviewed-by:
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I414cfeba6c9cf89f38dd4c368c3f133286108574 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220747Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#773147}
-
David Munro authored
Flake portal confirms that it's still failing plenty (only on the CQ, not locally :'( ) so re-disable. TBR because disabling flaky tests. Test: CQ, Run browser tests locally. Bug: chromium:1082027 Tbr: khorimoto@chromium.org,nverne@chromium.org Change-Id: I571d38cb60728ab1650a099edd142e768be5d1ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217841Reviewed-by:
David Munro <davidmunro@google.com> Commit-Queue: David Munro <davidmunro@google.com> Cr-Commit-Position: refs/heads/master@{#773146}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/364d64319c41..08d002d6c916 2020-05-29 szuend@chromium.org [typescript] TypeScript-ify color_picker/ContrastDetails.js 2020-05-29 szuend@chromium.org [typescript] TypeScript-ify color_picker/ContrastOverlay.js 2020-05-29 szuend@chromium.org [typescript] TypeScript-ify color_picker/ContrastInfo.js If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia8549a02eecba6ab9085a5e42b2de074659f3a88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222316Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/f026592a6611..b940a7d97b27 2020-05-29 eshr@google.com [Adaptation] Add const to Can* methods in VideoSourceRestrictor If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I12513a685c9481a6a90a64ee23f55432871ab409 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222317Reviewed-by:
-
David Tseng authored
This change makes the test robust to changes in when and where the heading for the test app appears R=rsorokin@chromium.org chromium-review.googlesource.com/2123310 Bug: 1085004,1083186 Test: run the test with the pending changes Change-Id: I9e6a85dd321bde4d39e3ecb3525866820ff1a8e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219175Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Jacques Newman <janewman@microsoft.com> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#773143}
-
Javier Ernesto Flores Robles authored
This moves the account validator to the extension files, as this is not going to be shared anymore. Bug: 1066803 Change-Id: Iae0d77117b236b109d6fb5ec125cb47a4e0f77f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218075 Auto-Submit: Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#773142}
-
Johann authored
LocalFrame is guaranteed to not be null. Add an extra layer enforcing this by passing references. Bug: 850619 Change-Id: I5a0c4d1f22dfb04bd8066af58d9f61fdc6149c83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217912 Commit-Queue: Johann Koenig <johannkoenig@google.com> Reviewed-by:
Nate Chapin <japhet@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#773141}
-
Nigel Tao authored
Bug: 1070409 Change-Id: I6eb0a4789232b48e66f45e7f81c96c12f718f413 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212231Reviewed-by:
Satoru Takabayashi <satorux@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#773140}
-
Saurabh Nijhara authored
Bug: 1064271 Change-Id: I731e7b85cafaefb9b71a1cffba177fce99a30a2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2181388 Commit-Queue: Saurabh Nijhara <snijhara@google.com> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
-
Matthias Körber authored
A recent change caused a regression in the filling of credit card numbers when a second wrongly detected credit card number field was detected in a form before the actual credit card number field. Change-Id: Ic3b95e5177ce3a8adbd82f51cd9e4a6c444e89b4 Bug: 1086991 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219947Reviewed-by:
Matthias Körber <koerber@google.com> Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#773138}
-
Rohit Rao authored
These APIs were deprecated starting in iOS 13, but the replacements are not available on iOS 12. This CL uses compile guards to call the new APIs when compiling with a min_deployment_target of 13.0+, or the old APIs otherwise. BUG=1086653 Change-Id: I0d784f8e41b56088669a0429685eb5f0cbef001e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220278Reviewed-by:
-
Denis Kuznetsov authored
Bug: 1073095 Change-Id: I0f54e981ad14d6d446f39e0cf2fd01a703027b83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218120Reviewed-by:
-
Avi Drissman authored
When putting passwords onto the clipboard, tag them as confidential. Bug: 1067542, 1084244, 1071828 Change-Id: I9de97ba615fc6496366af9af65a0c6f186a03945 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216329Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
-
Colin Blundell authored
This CL changes WebLayer's intent launching logic to match that of CCT in the specific case of an http(s) URL with a non-default external handler. In this case CCT overrides ExternalNavigationHandler's default behavior of showing the intent picker to instead keep the navigation in the app. It is desired that WebLayer precisely match CCT here. The implementation is adapted from that in //chrome's CustomTabDelegateFactory. A couple notes: - Unlike //chrome, in //weblayer the check for whether the app has a default handler does not bother to exclude the embedder of WebLayer. The reason is that WebLayer is not embedded in apps that handle incoming intents. - The special-casing of the intent being for the client of CCT at [1] has no analogue in WebLayer (again, because WebLayer is not embedded in apps that handle incoming intents). Thus, there is no such corresponding check in WebLayer. To test: - Install the booking.com app on your device - Search for "hotel booking paris" in Google on WebLayer Shell - Click on the ad for booking.com that should result at the top - Observe that the booking.com app is launched - Via Android Settings, configure the booking.com's handling of support URLs to be "ask every time" - Repeat the above search in WebLayer Shell and observe that the navigation to booking.com stays in WebLayer Shell [1] https://source.chromium.org/chromium/chromium/src/+/master:chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabDelegateFactory.java;l=119?q=CustomTabDelegateFactory&ss=chromium&originalUrl=https:%2F%2Fcs.chromium.org%2F Bug: 1085405 Change-Id: I2bec60967c5c2ef1638a927a33f7e21ba93ae58a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219494 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#773134}
-
Olga Sharonova authored
This reverts commit 002510a0. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=1087807 Bug: 1087807, 623268 Original change's description: > Fix the http/tests/devtools/inspect-iframe-from-different-domain.js test > > This test wants to verify devtools inspect works with an iframe in > another domain. It was putting the iframe in another site, which causes > it to become detached from the local root in site isolation. Instead, > put both the main frame and iframe into the example.test domain, with > the iframe in a subdomain. > > This test was originally added for webkit bug 31587 which is found at > https://bugs.webkit.org/show_bug.cgi?id=31587. > > It said: > > If you try to inspect elements located inside an IFRAME that was > > loaded from a different domain, not satisfying the same origin > > policy, Web Inpector in recent WebKit nightly builds cannot show > > style information. Works in Safari 4.0.4. > > R=yangguo@chromium.org > > Bug: 623268 > Change-Id: I842bf835e49ee79e60e423fd36a5d3cedb8a8cfa > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218765 > Commit-Queue: danakj <danakj@chromium.org> > Reviewed-by: Andrey Kosyakov <caseq@chromium.org> > Cr-Commit-Position: refs/heads/master@{#772743} TBR=danakj@chromium.org,caseq@chromium.org,yangguo@chromium.org Change-Id: I0555399e579bf5a1976e53b0fa419d9aa04a6c2b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 623268 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218025Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#773133}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/980e0c16b911..f026592a6611 2020-05-29 landrey@webrtc.org Add HEVC codec name. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Icf16ab3136bd34b04becfe69fafc155292cc02a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220824Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/7b165971aa48..364d64319c41 2020-05-29 janscheffler@chromium.org Clear cookie preview when deleting cookies If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I3b500ce7ece34f14ee69bb85226864779a276425 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220822Reviewed-by:
-
Etienne Bergeron authored
This CL is adding a unittest that ensures GetTextDirection(...) and GetDisplayTextDirection(...) are invalidated when changing the directionality mode. R=msw@chromium.org Bug: 1025561 Change-Id: Ieb6f6c0bca2803614a89a48a3e0b3d906a790e71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220071 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#773130}
-
Mirko Bonadei authored
WebRTC doesn't use gclient_args.gni, this CL adds the possibility to override the value of "checkout_google_benchmark" with another override method (//build_overrides/build.gni). Bug: None Change-Id: If6e6cd9b9cbeb82d96e7c5b578347884e0c84607 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218024Reviewed-by:
Markus Handell <handellm@google.com> Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#773129}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Id8d4b78c27e58f127a2bbc4484992c0e7c0a4125 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222118Reviewed-by:
-
Ehimare Okoyomon authored
Refactored the page info v2 sections for these components into their own controllers. More functionality for subpages will be added later. Bug: 1077766 Change-Id: I91e74844f8743a3774d6b7f0fb37308b9bf50f0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213580 Commit-Queue: Ehimare Okoyomon <eokoyomon@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#773127}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/48a6bcf4f11e..15a98af79295 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC olka@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: olka@google.com Change-Id: I305b3bc08b517ff5b7c1f3e4fe0f0ee5ae26717a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220821Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#773126}
-
James Cook authored
The sync consent screen is skipped for non-branded (e.g. developer) builds. We need to do this check after the check for non-GAIA and public accounts, otherwise we try to enable sync for account types that don't have an IdentityManager primary account. This fixes DCHECK failures on account_id in Active Directory and device local account tests. This CL also adds an explicit sync consent screen test for Active Directory accounts, because it took me a while to figure out why unrelated AD tests were failing in sync consent code. Bug: 1060289 Change-Id: Ief0b78ae6869349993b4427226af625591d827f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211181 Auto-Submit: James Cook <jamescook@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Iecbfab03f5bf9594c65b6fbf55194d8660f8abf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222117Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a869b729..259d8f40 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I016bcf5e56fbc3d4be728995ae4729fd81d4c8d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218395Reviewed-by:
-
Etienne Bergeron authored
This CL replace the fixed size vector used to store the text style by a std::array which is by default fixed size. The goal is to statically ensures the size of the vector. R=pkasting@chromium.org Bug: 1025561 Change-Id: I773897545adb34680cf62ece1594f03617d2e262 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220074 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#773122}
-
Mark Brand authored
Adds mojo/tools/fuzzers/mojom.gni which has a template rule that wraps most of the build-file mechanics necessary to build fuzzer targets using MojoLPM, and adds pipe date size limits to the MojoLPM data pipe implementations to prevent fuzzers from OOMing so easily. In order to make the mojolpm_fuzzer_target work, it needs to fix handling for testonly in a couple of places: - adding testonly propagation to protoc_convert. - adding testonly to seed_corpus copy rule. Bug: 1076336 Change-Id: Ib6b2efbe533151e28c3ef26593ac0dc322725770 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2172079 Commit-Queue: Mark Brand <markbrand@google.com> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Jonathan Metzman <metzman@chromium.org> Cr-Commit-Position: refs/heads/master@{#773121}
-
