- 20 Jun, 2018 40 commits
-
-
Ryan Tseng authored
Bug: 840631 TBR: tandrii Change-Id: Ie3794a3c74b9643a10596d106ffc12c31f7e599f Reviewed-on: https://chromium-review.googlesource.com/1108552 Commit-Queue: Ryan Tseng <hinoka@chromium.org> Reviewed-by:
Ryan Tseng <hinoka@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Cr-Commit-Position: refs/heads/master@{#569031}
-
Patrick Monette authored
The feature is currently active at 10% on stable and it's time to make it the default. Bug: 717696 Change-Id: I7b6c3e162c6d475408b201a6c1417c89762f6b32 Reviewed-on: https://chromium-review.googlesource.com/1106484Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#569030}
-
Raphael Kubo da Costa authored
Commit fc5fe708 ("FrameSinkVideoCapture clean-up: Remove unused APIs, style fixes") added the noexcept marker to FrameSinkVideoCapture's ConsumptionState inner class. This breaks the GCC build due to the fact that its members' types do not have noexcept themselves: ../../content/browser/media/capture/frame_sink_video_capture_device.cc: At global scope: ../../content/browser/media/capture/frame_sink_video_capture_device.cc:372:1: error: function ‘content::FrameSinkVideoCaptureDevice::ConsumptionState::ConsumptionState(content::FrameSinkVideoCaptureDevice::ConsumptionState&&)’ defaulted on its redeclaration with an exception-specification that differs from the implicit exception-specification ‘’ FrameSinkVideoCaptureDevice::ConsumptionState::ConsumptionState( clang is fine because we pass -fno-exceptions and it disables the same error there, while GCC continues to raise it (bug 843143 and its corresponding CL have a longer discussion on this issue). In this case, mark CursorRendererUndoer as well as mojo's ubiquitous InterfacePtr with noexcept to fix the build. Bug: 754872, 819294, 843143 Change-Id: I78714fda26d21e0979aed4fe26d543463dff9631 Reviewed-on: https://chromium-review.googlesource.com/1107918Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Raphael Kubo da Costa (CET) <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#569029}
-
Majid Valipour authored
Paging scroll operations should take scroll-padding into account [1]. So we use the snapport rect to calculate the page step instead of the visible rect. Other minor change: - VisibleScrollSnapportRect now takes into account scrollbar inclusion. This was needed since in at least one paging operation we needed to include scrollbars. [1] https://drafts.csswg.org/css-scroll-snap/#scroll-padding Bug: 842165 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I3112a94a984b438bc66fc2664b8288ec95a1d725 Reviewed-on: https://chromium-review.googlesource.com/1105520Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#569028}
-
Matt Menke authored
It flakily reaches a point of execution where extensions try to do a host resolution using the RequestContext, which isn't set up when the network service is enabled. TBR=jam@chromium.org Bug: 854762 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I5883a5620b953ca40fd582d39b96ea29f4f988e9 Reviewed-on: https://chromium-review.googlesource.com/1108737Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#569027}
-
Khushal authored
GpuImageDecodeCache supports decoding directly to the desired scale, if supported by the image decoder, but the functionality was commented out in PaintImage. Enable it. Follow up changes should add the use of this API to the software cache. R=ericrk@chromium.org Bug: 558070,773799 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Iea69e200b9b0bc1b1c60231c7c15cef5c6a2f674 Reviewed-on: https://chromium-review.googlesource.com/1102025 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#569026}
-
Olivier Robin authored
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I437b8139b4c25e350e81d92cacc9575cac4763cf Reviewed-on: https://chromium-review.googlesource.com/1104173Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#569025}
-
Eugene But authored
No major issues were found during manual testing. Safe to ship in M69. Bug: 725241 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I753c20d6525547958140d6407e8bd71d4f8ef0f7 Reviewed-on: https://chromium-review.googlesource.com/1086111Reviewed-by:
Danyao Wang <danyao@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#569024}
-
Ben Wagner authored
Skia is moving the include/ports/SkFontMgr.h file to include/core/SkFontMgr.h as part of a general clean up. The old header still exists as a forwarding header, but users need to be updated to use the new header location so that the forwarding header can be removed. TBR=sky@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I7c644f1acc3826714e0cf1a29be44fe4669f259d Reviewed-on: https://chromium-review.googlesource.com/1108084 Commit-Queue: Ben Wagner <bungeman@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#569023}
-
Fabio Tirelo authored
Bug: 847980 Change-Id: I3000a303d016d68dc86a21211399bc24c204a8a0 Reviewed-on: https://chromium-review.googlesource.com/1080689 Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#569022}
-
Scott Violet authored
This makes the utility process create AshService for --OopAsh. AshService will get the logic to create Shell for OopAsh. BUG=854336 TEST=none Change-Id: I266cd93b848fa6e3a8d95de2a0c3410aa6ac8d38 Reviewed-on: https://chromium-review.googlesource.com/1108507Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#569021}
-
Zhongyi Shi authored
This test verifies that QuicStreamFactory broadcasts connection migration signal to all the sessions and multiple sessions migrate to new network afterwards. Bug: 818259, 843299 Change-Id: I9ade5015b9eb992bf83d23132c5aa0bfeb3563a6 Reviewed-on: https://chromium-review.googlesource.com/1108516 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#569020}
-
Tarun Bansal authored
Add few DCHECKs, and update enum values. Change-Id: Idb9a6ea39ed5a4799a3e9a24703b6d485914ccd8 Bug: 854666 Reviewed-on: https://chromium-review.googlesource.com/1105188 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#569019}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/e5c614fbaf79..a58d69e90b91 git log e5c614fbaf79..a58d69e90b91 --date=short --no-merges --format='%ad %ae %s' 2018-06-20 fjhenigman@chromium.org Revert "GLES1: Point rasterization (partial implementation)" Created with: gclient setdep -r src/third_party/angle@a58d69e90b91 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: If70df816dffc37b638ca16707848327442c55220 Reviewed-on: https://chromium-review.googlesource.com/1108301Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#569018}
-
Boris Sazonov authored
This CL contains first chunk of changes to adapt Settings for UnifiedConsent. It adds "Account" section and "Sync and Google services" entry to the main settings screen. It also changes the summary text of SignInPreference. All changes in this CL are gated by UNIFIED_CONSENT feature flag. "Sync and Google services" preferences will be populated by subsequent CLs. Bug: 814728 Change-Id: I7662459ef98277e556c1754700d250c8d406e6a8 Reviewed-on: https://chromium-review.googlesource.com/1108214Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#569017}
-
Kevin Schoedel authored
Test: manual; unit test TBD Bug: b/73383411 Change-Id: I5b5a65ad85695bcd4d126081f3ce472215e33996 Reviewed-on: https://chromium-review.googlesource.com/1102893Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Commit-Queue: Kevin Schoedel <kpschoedel@chromium.org> Cr-Commit-Position: refs/heads/master@{#569016}
-
Sebastien Marchand authored
Change-Id: Ia760f35e73729b513f8b149b196aef803a7d93bd Reviewed-on: https://chromium-review.googlesource.com/1107303Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#569015}
-
Maria Khomenko authored
We see users turning this on for themselves mistakenly assuming it's a performance optimization. Bug: 854686 Change-Id: Ib3450527509c90711cda952746045c99c6f9738d Reviewed-on: https://chromium-review.googlesource.com/1108441 Commit-Queue: Siddhartha S <ssid@chromium.org> Reviewed-by:
Siddhartha S <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#569014}
-
Bret Sepulveda authored
The top chrome height increases when Refresh is enabled, so the insets into the browser window to click on the web content were incorrect. Bug: 846410, 853990 Change-Id: I2f274632ca752d583a8fd0ac21721039c3cc8c1b Reviewed-on: https://chromium-review.googlesource.com/1107272 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#569013}
-
Tomasz Śniatowski authored
As a side effect of the tracing cleanups in https://crrev.com/c/1015647, setting a custom startup trace file via --trace-startup-file stopped working on Android. Fix by not hardcoding the call to generate a path, so the switch is checked first. Bug: 828993 Change-Id: Ifcfd0dc2ea41b09af0c409ba5d406eda5d920b8b Reviewed-on: https://chromium-review.googlesource.com/1097326Reviewed-by:
Ehsan Chiniforooshan <chiniforooshan@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Tomasz Śniatowski <tsniatowski@vewd.com> Cr-Commit-Position: refs/heads/master@{#569012}
-
Maksim Ivanov authored
Add passing of GAIA ID from the login screen JS code to the C++ handler, in addition to passing the user e-mail. This will allow to build AccountId instance for the user in question in a more reliable way. This CL should bring no change of behavior - logic for the passwordless ("challenge-response") logins is yet to be implemented. BUG=chromium:826417 TEST=existing tests (no change of behavior is introduced) Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I64a29ba845543644626fb972129c0b6376c3de2b Reviewed-on: https://chromium-review.googlesource.com/1107059Reviewed-by:Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#569011}
-
Bret Sepulveda authored
There is a DCHECK that triggers in cc::Layer when running the test. This patch disables the tests temporarily so the feature can be turned on by default. We will follow up before launch. Bug: 853990 Change-Id: I6033d49b11ab341079152ca876d198fc7cdfd84a Reviewed-on: https://chromium-review.googlesource.com/1105503 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#569010}
-
Francois Doray authored
When a PENDING_DISCARD TabLifecycleUnit is focused, its state is transitioned to PENDING_FREEZE, to indicate that the renderer is processing a freeze request, but that no discard should happen when it's done. With this CL, we also stop the freeze timer to ensure that FinishDiscard() isn't called when the renderer tells the browser that the freeze request has been processed. Bug: 854720 Change-Id: Iea98644ea1e9b056eb05bbf5ae6da870c324064c Reviewed-on: https://chromium-review.googlesource.com/1108376Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#569009}
-
Scott Little authored
This CL makes Blink record histograms to measure how often LazyLoad decides to immediately load a cross-origin iframe instead of deferring it, or if the iframe is deferred, how often that iframe is later loaded or seen by the user. This will help with tuning the distance-from-viewport threshold for determining how far down the page a lazy loaded frame should start loading. Since different distance-from-viewport thresholds will be used for different effective connection types, separate counts for these histograms are recorded for different effective connection types. Bug: 854040 Change-Id: Ied135413bb16770aeb22a304c312b8cc01df88b4 Reviewed-on: https://chromium-review.googlesource.com/1105606Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Scott Little <sclittle@chromium.org> Cr-Commit-Position: refs/heads/master@{#569008}
-
David Grogan authored
This reverts commit e2cac39f. Reason for revert: https://crbug.com/854785 (CrSettingsSiteEntryTest.All failing on chromium.mac/Mac10.13 Tests (dbg)) TypeError: this.$.menu.getIfExists is not a function at HTMLElement.getOverflowMenu_ (chrome://settings/site_settings/site_entry.js:115:65) at Context.<anonymous> (file:///b/s/w/ir/chrome/test/data/webui/settings/site_entry_tests.js:136:25) ", source: file:///b/s/w/ir/chrome/test/data/webui/mocha_adapter.js (48) Original change's description: > Settings: Content settings can now be reset for a group of origins in All Sites. > > Add a three-dot / overflow menu to groups of origins in All Sites. This overflow > menu allows the entire list of origins to have all their content settings reset > in one go. This will be preceded with a confirmation dialog. > > Manual test - With #enable-site-settings turned on, change a content setting via > Page Info > Site settings on both https://permission.site and > http://permission.site. Navigate to chrome://settings/content/all and see that > both sites are listed under 'permission.site'. Verify there is an overflow menu > on this entry and that inside the overflow menu, there is a 'Reset permissions' > option. Clicking this should bring up a reset permission dialog and confirming > the dialog should remove this entry from All Sites. > > Bug: 835712, 717468 > Cq-Include-Trybots: luci.chromium.try:closure_compilation > Change-Id: I777f759c26bf0fe7f8da086fa887969897cf9833 > Reviewed-on: https://chromium-review.googlesource.com/1098577 > Commit-Queue: Patti <patricialor@chromium.org> > Reviewed-by: Dave Schuyler <dschuyler@chromium.org> > Cr-Commit-Position: refs/heads/master@{#568742} TBR=dschuyler@chromium.org,patricialor@chromium.org Change-Id: I227ad85a38a66a6f571dab6aabfdfb5211580280 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 835712, 717468, 854785 Cq-Include-Trybots: luci.chromium.try:closure_compilation Reviewed-on: https://chromium-review.googlesource.com/1108777Reviewed-by:
David Grogan <dgrogan@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#569007}
-
Patrick Monette authored
Also keep track of the status of the ModuleListFilter initialization, which will be used later to display the state of the third-party blocking subsystem to the user. Bug: 847544 Change-Id: I354253ec05012f50fa4418ef1c69113844c3c2ac Reviewed-on: https://chromium-review.googlesource.com/1097626 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#569006}
-
Daniele Castagna authored
Change-Id: I4c6ddc1466ff8736272591cf05236f3bb939b6fc Reviewed-on: https://chromium-review.googlesource.com/1108521Reviewed-by:
David Reveman <reveman@chromium.org> Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#569005}
-
Matt Menke authored
This will cause histogram will be collected both when the network service is enabled, and when it's not. Also update LayeredNetworkDelegate::OnCompletedInternal to pass in the net_error. Bug: 853211 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I8294b26b9cbe031cdb54adf7fc752c6717605b95 Reviewed-on: https://chromium-review.googlesource.com/1108083Reviewed-by:
Scott Little <sclittle@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#569004}
-
Zhenyao Mo authored
BUG=852537 TEST=buildbots R=piman@chromium.org,kbr@chromium.org,capn@chromium.org,sugoi@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I14021e5ecf9f0716974a99f14c2c154299eac310 Reviewed-on: https://chromium-review.googlesource.com/1107254 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#569003}
-
Pete Williamson authored
Change-Id: Icff88d725da277ed2ab5e893b7730c9bf147c999 Reviewed-on: https://chromium-review.googlesource.com/1108501Reviewed-by:
Yafei Duan <romax@chromium.org> Commit-Queue: Peter Williamson <petewil@chromium.org> Cr-Commit-Position: refs/heads/master@{#569002}
-
John Chen authored
This reverts commit c902850a. Reason for revert: Broke --whitelisted-ips switch on Linux, Windows, and ChromeOS. Original change's description: > [ChromeDriver] Listen on both IPv4 & IPv6 > > On hosts that support both IPv4 and IPv6, ChromeDriver now listens on > both protocols. > > Bug: chromedriver:779 > Change-Id: I4a115cc0ca5cf0396acdad8d4c1a72f169120368 > Reviewed-on: https://chromium-review.googlesource.com/1080448 > Reviewed-by: Caleb Rouleau <crouleau@chromium.org> > Reviewed-by: Jonathon Kereliuk <kereliuk@chromium.org> > Commit-Queue: John Chen <johnchen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#564984} TBR=crouleau@chromium.org,johnchen@chromium.org,kereliuk@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromedriver:779 Change-Id: Ib6349e2ce43430fb842705ad0390d2905bc928e9 Reviewed-on: https://chromium-review.googlesource.com/1108597Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#569001}
-
Daniel Nicoara authored
Defines the expected values and the valid range of the values. Bug: None Test: None Change-Id: I32de9b7dca313f34f157f83e1558425f75b7c60f Reviewed-on: https://chromium-review.googlesource.com/1099680Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#569000}
-
Dave Schuyler authored
This CL adds a default (or fallback) icon for Answers in Suggest that don't have a specific icon. Bug: 838733 Change-Id: I723d64e29f8222e873345c6e04d90e1b26cb1631 Reviewed-on: https://chromium-review.googlesource.com/1108514Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#568999}
-
Mike Gilbert authored
Chromium may optionally be built against libxml installed on the system. The system libxml commonly has XML catalog support enabled. Disable it by calling xmlCatalogSetDefaults(XML_CATA_ALLOW_NONE). Bug: https://bugs.gentoo.org/653078 Change-Id: I069f6dcecf81168f9d31eb0efe2519197ec8e779 Reviewed-on: https://chromium-review.googlesource.com/1103710Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#568998}
-
sebsg authored
Bug: 852361 Change-Id: I3be88e3563060aa6a586c99bf1e5a501605ea71d Reviewed-on: https://chromium-review.googlesource.com/1107281Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#568997}
-
Nicolas Ouellet-payeur authored
These were languages that we can detect with CLD3 (and offer translations for), but wouldn't appear in the Chrome Settings page, and therefore couldn't be removed from the Accept-Language list. The list of missing languages was obtained by calculating the set difference of `kLanguageNames` (from task_context_params.cc) and `kAcceptLanguageList` (from l10n_util.cc): https://paste.googleplex.com/6446173711761408 (apologies for external contributors who can't visit the link) Languages that end in '-Latn' (e.g. 'zh-Latn') are not supported by Translate and were not added to `kAcceptLanguageList`. Bug: 807317 Change-Id: I83386fb5cb7ecbb3aae04aa1d1ca87ad0f0df34c Reviewed-on: https://chromium-review.googlesource.com/1107878Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Jungshik Shin <jshin@chromium.org> Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#568996}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/29f54a30992a..c4424eb6803d git log 29f54a30992a..c4424eb6803d --date=short --no-merges --format='%ad %ae %s' 2018-06-20 dgarrett@chromium.org Revert "gclient: Stop using implicit git_cache_dir." 2018-06-20 derat@chromium.org cbuildbot: Add run_tast.sh to SSP archive. Created with: gclient setdep -r src/third_party/chromite@c4424eb6803d The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:853391,chromium:none TBR=chrome-os-gardeners@chromium.org Change-Id: Ia0e4155e215863c744afd84a0b2326306a2d0941 Reviewed-on: https://chromium-review.googlesource.com/1108222Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#568995}
-
Reid Kleckner authored
ASan on Windows changes the exit code to 1, which base categorizes as the process being killed. R=dgozman@chromium.org BUG=845011 Change-Id: I42149965f2904a2a8349a00f4a2dd70351d2eee1 Reviewed-on: https://chromium-review.googlesource.com/1108448Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Reid Kleckner <rnk@chromium.org> Cr-Commit-Position: refs/heads/master@{#568994}
-
Zhongyi Shi authored
This test verifies that session attempts connection migration when path degrading is detected. If there's no alternate network, session stays on the original network (not marked as going away), and has connection to cache the path degrading signal. Session can finish serving requests on the original network. Bug: 818259, 843299 Change-Id: Iab29e9a253d08b933191dc0f6dfb6b461e3e3e3e Reviewed-on: https://chromium-review.googlesource.com/1108489 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#568993}
-
Jordy Greenblatt authored
Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I4184a56c5321790e03b095b50aed42584703676c Reviewed-on: https://chromium-review.googlesource.com/1106609Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Jordy Greenblatt <jordynass@chromium.org> Cr-Commit-Position: refs/heads/master@{#568992}
-