- 30 May, 2018 40 commits
-
-
Chromium WPT Sync authored
Using wpt-import in Chromium d637b5fa. With Chromium commits locally applied on WPT: 6534acd9 "[css-grid] Baseline alignment inside the tracks sizing algorithm" e8832df8 "webrtc wpt: remove test_state_change_event" d637b5fa "Support groupId in MediaDevices.getUserMedia() for audio tracks" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/18939 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: worker-dev@chromium.org: external/wpt/workers TBR=robertma No-Export: true Change-Id: I2f6fb9d8f79e9cac37e957884a432ec582d28ac1 Reviewed-on: https://chromium-review.googlesource.com/1079807 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#563021}
-
Peter Collingbourne authored
For the moment, this is the configuration that we plan to deploy in official builds. Bug: 821860 Change-Id: I70ff3df79988a741676b52a18a0d6c3fe4f2438e Reviewed-on: https://chromium-review.googlesource.com/1053230Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Peter Collingbourne <pcc@chromium.org> Cr-Commit-Position: refs/heads/master@{#563020}
-
Leonard Grey authored
This is set up for animated action dragging. If an action is in the process of being dragged from the main bar to the overflow or vice versa, it allows the original bar to keep track of what's being dragged despite not having an active drag session. Bug: 826865 Change-Id: Id86dc6c2475ada376abe37fe7169b5f9d4d42e52 Reviewed-on: https://chromium-review.googlesource.com/1079287 Commit-Queue: Leonard Grey <lgrey@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#563019}
-
Samuel Huang authored
Previously the Diff() registers symbol size change by testing delta size, and not delta PSS. This prevents spurious output from alias addition / removal without actual binary change. However, this check does not account of changes where alias change from merging / splitting binaries that have the same number of bytes, e.g., as seen in http://crbug.com/847284 . The result is confusing Diff() output where total delta PSS do not add up to actual byte changes. This CL makes Diff() also test delta PSS as a condition for symbol size change. This fixes Diff() PSS accounting, but can also make the output more noisy, since spurious outputs from alias addition / removal are also counted. Change-Id: I2d3b3949214dd0399a33e4154203a34cb52ac7f6 Reviewed-on: https://chromium-review.googlesource.com/1079804Reviewed-by:
Samuel Huang <huangs@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#563018}
-
Justin Novosad authored
This change makes Canvas2DLayerBridge use the instance of CanvasResourceProvider that is stored in CanvasResourceHost. This moves the code towards having a single location for the resource provider for all use cases. BUG=788439 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ib2fbda6d2853da6ca8f35325380a1674bde0ff5d Reviewed-on: https://chromium-review.googlesource.com/1079192 Commit-Queue: Justin Novosad <junov@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#563017}
-
Varun Khaneja authored
- Uses the the Archive API to iterative over the files contained inside the downloaded .rar file. - Identify if the .rar file contains any executables. - Identify if the .rar file contains any archives. This information isn't currently used to populate the CSBRR ping sent to Safe Browsing. That's work for a follow-up CL. All this is behind the flag: InspectDownloadedRarFiles Note: This CL sends a fd/handle to the unrar library since code running inside the sandbox can't open/create files. Change-Id: Ie5d30040f51f59854d4a041652d171d704f4df78 Bug: 750327 Reviewed-on: https://chromium-review.googlesource.com/947664 Commit-Queue: Varun Khaneja <vakh@chromium.org> Reviewed-by:
Nathan Parker <nparker@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Luke Z <lpz@chromium.org> Cr-Commit-Position: refs/heads/master@{#563016}
-
Ryan Tseng authored
Bug: 731409, 808299, 731408, 731456, 731452, 731450, 731433, 731432 TBR: tandrii Change-Id: I3d970131eae60be82786bdb4f35af006c378abf9 Reviewed-on: https://chromium-review.googlesource.com/1079756Reviewed-by:
Ryan Tseng <hinoka@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Ryan Tseng <hinoka@chromium.org> Cr-Commit-Position: refs/heads/master@{#563015}
-
Wez authored
Bug: 847032 Change-Id: I09cb5743bcd6b7493329f6a578522362e1da32db Reviewed-on: https://chromium-review.googlesource.com/1074505Reviewed-by:
Taiju Tsuiki <tzik@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#563014}
-
Christopher Grant authored
BUG=847950 R=mthiesse Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: I4a6068bdea5b8b9836373876c6dde567e4714b00 Reviewed-on: https://chromium-review.googlesource.com/1079706Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#563013}
-
Thomas Anderson authored
This reverts commit a45859e2. Reason for revert: Causing build failure on Linux Builder (dbg): https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Builder%20%28dbg%29/125172 Original change's description: > VR: Separate gesture recognition from VrController > > Bug: 847271 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr > Change-Id: I56edc54dcb24fd387944dc1dd937a66348ade484 > Reviewed-on: https://chromium-review.googlesource.com/1077053 > Reviewed-by: Amirhossein Simjour <asimjour@chromium.org> > Commit-Queue: Aldo Culquicondor <acondor@chromium.org> > Cr-Commit-Position: refs/heads/master@{#563009} TBR=asimjour@chromium.org,acondor@chromium.org Change-Id: I1e22c9a964352ce63895fcaad902ed8413e03609 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 847271 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Reviewed-on: https://chromium-review.googlesource.com/1079988Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#563012}
-
Ryan Tseng authored
Bug: 840631 Change-Id: Ia36f0e81191c18d17c6d08af333b2058fc6158f8 Reviewed-on: https://chromium-review.googlesource.com/1079824Reviewed-by:
-
Amy Qiu authored
Move tough_canvas_cases into rendering folder and refactor page classes to inherit from RenderingStory. Bug: 760553 Change-Id: I5cc1a745360968757569b1868be2fb3ddca7222c Reviewed-on: https://chromium-review.googlesource.com/1078934 Commit-Queue: Amy Qiu <amyqiu@google.com> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#563010}
-
Aldo Culquicondor authored
Bug: 847271 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: I56edc54dcb24fd387944dc1dd937a66348ade484 Reviewed-on: https://chromium-review.googlesource.com/1077053Reviewed-by:
Amirhossein Simjour <asimjour@chromium.org> Commit-Queue: Aldo Culquicondor <acondor@chromium.org> Cr-Commit-Position: refs/heads/master@{#563009}
-
Christopher Cameron authored
It is not possible to know ahead of time whether or not a WebContentsView will be embedded in an NSView or a views::View, even when MacViewsBrowser is enabled (content_shell, for instance, uses the NSView display path). Lazily determine if a WebContentsView is to display via its parent views::View's compositor. When attaching to a views::View for the first time, clear all content that is being displayed in the NSView (because it will occlude the views::View) and disable displaying through Cocoa for the lifetime of the WebContentsView. When all code that expects to display through Cocoa is updated or deleted, this lazy determination may be removed. Bug: 840173 Change-Id: I36c7054ba7c71e6fe94e496e677a9a9be4fb790a Reviewed-on: https://chromium-review.googlesource.com/1075563Reviewed-by:
Sidney San Martín <sdy@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#563008}
-
Robert Ma authored
Sometimes CQ+2 can fail even when CQ+1 succeeds (e.g. last-minute merge conflicts). This CL catches this failure properly. Bug: 817025 Change-Id: Ic6679a7b4797132abd3ecae348644d6e14f73c7c Reviewed-on: https://chromium-review.googlesource.com/1079889Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#563007}
-
Alexei Filippov authored
In CPU profile samples delta for the first sample is an offset from startTime. BUG=847887 Change-Id: I200eae40770b521545c831f0e6e1ffa311cb7a85 Reviewed-on: https://chromium-review.googlesource.com/1079432Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#563006}
-
Nate Fischer authored
No change to production logic, just fixes a mistake with tracing. I made a copy-paste error when adding TraceEvents for onSafeBrowsingHit(). This makes sure we end the correct TraceEvent by using the correct string. Test: N/A Change-Id: I7cb58f6ef474d0c38d88093d2e7aca2d66f0e8a0 Reviewed-on: https://chromium-review.googlesource.com/1079888Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#563005}
-
Patrick Noland authored
Bug: 847119 Change-Id: I5d7210b131304bf09a431d26aaf64ceae0e10a23 Reviewed-on: https://chromium-review.googlesource.com/1077427Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#563004}
-
Jun Choi authored
The current BlueZ adapter implementation for BLE advertisement does not unregister advertisements when BluetoothAdapter scoped referenece pointer is destructed. This cause BluetoothAdapter::advertisements_ queue to increase indeterminately as BluetoothAdapter is a Chrome wide singleton object. Manually unregister any ongoing advertisement once CableDiscovery is destructed. Bug: 846535 Change-Id: If7782132f99e580bfa5f6e9a0da2a116375e6b7c Reviewed-on: https://chromium-review.googlesource.com/1072929 Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#563003}
-
Eugene But authored
The implementation of this method is folded into BVC. Bug: 620489 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ia28f15d5b2ba55c4d661e2b0a200c143e2a4f296 Reviewed-on: https://chromium-review.googlesource.com/1073916 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#563002}
-
Yutaka Hirano authored
With this change, WebRequest API for WebSocket works when the network service is enabled. This CL introduces WebRequestProxyingWebSocket, a proxy which dispatches WebRequest API events to extensions. This CL modifies websocket.mojom as following: - OnFinishOpeningHandshake is always dispatched. When the renderer doesn't have an access to raw cookies access, it drops cookie related information from the headers. - socket_address and http_version is added to WebSocketHandshakeResponse. This change lacks OnAuthRequired support. Bug: 721400 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Ic564518a820e4f010548263863e523062da7345e Reviewed-on: https://chromium-review.googlesource.com/1068592Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#563001}
-
Manuel Rego Casasnovas authored
Text from the spec (https://drafts.csswg.org/css-contain/#containment-paint): "... if the element is an internal table element other than 'display: table-cell', ... paint containment has no effect." The patch disables "contain: paint" for internal table elements except table cells. BUG=843329 TEST=external/wpt/css/css-contain/contain-paint-014.html TEST=external/wpt/css/css-contain/contain-paint-015.html TEST=external/wpt/css/css-contain/contain-paint-016.html TEST=external/wpt/css/css-contain/contain-paint-017.html TEST=external/wpt/css/css-contain/contain-paint-018.html TEST=external/wpt/css/css-contain/contain-paint-019.html Change-Id: I975950ab72fe5cc5aa106fa5fdafd37c64dd6d85 Reviewed-on: https://chromium-review.googlesource.com/1078868Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#563000}
-
mrefaat authored
These tests have been failing for more than a week now. LoadURL doesn't finish on device on some tests. Bug: 847948 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I151a3a2d031b4311d17c5c148c635a92e5a1f232 Reviewed-on: https://chromium-review.googlesource.com/1079630 Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#562999}
-
Varun Khaneja authored
See: crrev.com/c/1038141/4/third_party/unrar/src/unpack50frag.cpp#52 Bug: 750327 Change-Id: Ib7bc8fea73f8ca860bb87490fd046f20c55ca8f7 Reviewed-on: https://chromium-review.googlesource.com/1077187 Commit-Queue: Varun Khaneja <vakh@chromium.org> Reviewed-by:
-
Daniel Bratell authored
In some jumbo build configurations the linker needs gfx::PrintTo(gfx::Size const&, ...) referenced from obj/gpu/libtest_support.a testing::internal::UniversalPrinter<gfx::Size>::Print( gfx::Size const&, ...) This reference might be in dead code that would otherwise (in non-jumbo builds) have been stripped earlier, but since the reference apparently is there it's best to have the dependency as well. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I6fe98a5427e5bc30625773bfa73d5b248b34f30a Reviewed-on: https://chromium-review.googlesource.com/1005340Reviewed-by:Victor Miura <vmiura@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#562997}
-
John Chen authored
ImplicitWaitTest.testShouldImplicitlyWaitForASingleElement is no longer failing on Android. Re-enabling the test. TBR=kereliuk@chromium.org Bug: chromedriver:998 Change-Id: I4a3b20065625cc7d17b044b873527a537237b0fd Reviewed-on: https://chromium-review.googlesource.com/1079894Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#562996}
-
Christopher Grant authored
This allows the common (mostly UI) VR code to compile as a component during component builds. This speeds the build, but is also a stepping stone to investigating VR's external symbol dependencies. BUG= Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: I7f1f8b2bd88c436b542389e60d3c07c8e7388310 Reviewed-on: https://chromium-review.googlesource.com/1077075 Commit-Queue: Christopher Grant <cjgrant@chromium.org> Reviewed-by:
-
Ella Ge authored
This reverts commit 5af8e7eb. Reason for revert: <INSERT REASONING HERE> Original change's description: > Revert "Reland "Check page exist after dispatch dragstart"" > > This reverts commit 67834de4. > > Reason for revert: Causing failures on WebKit Linux Trusty Leak (https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20Leak/19550) > > Original change's description: > > Reland "Check page exist after dispatch dragstart" > > > > This is a reland of 2c03b1bd > > > > The CL was reverted because of failures on the leak bot. > > However the leak is not cause by the test or the patch. > > Add the exception for the test for further investigation. > > > > Original change's description: > > > Check page exist after dispatch dragstart > > > > > > frame_->GetPage() may be null. need to check before use GetDragState > > > This CL reorder the some checks in MouseEventManager::TryStartDrag > > > to make sure GetPage is valid before start drag. > > > > > > Bug: 843502 > > > Change-Id: Ifdf5b20d7132ca4b089c9a5b7652ebbd41370c33 > > > Reviewed-on: https://chromium-review.googlesource.com/1064878 > > > Commit-Queue: Ella Ge <eirage@chromium.org> > > > Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org> > > > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#561262} > > > > Bug: 843502 > > Change-Id: I093da085a84eecf2937d522b762b2feeeb1d7947 > > Reviewed-on: https://chromium-review.googlesource.com/1079247 > > Commit-Queue: Ella Ge <eirage@chromium.org> > > Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org> > > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#562953} > > TBR=dcheng@chromium.org,nzolghadr@chromium.org,eirage@chromium.org > > Change-Id: I5546c2b3469ecbf1ad40cc47ab8437075073abd5 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 843502 > Reviewed-on: https://chromium-review.googlesource.com/1079968 > Reviewed-by: Adithya Srinivasan <adithyas@chromium.org> > Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> > Cr-Commit-Position: refs/heads/master@{#562991} TBR=dcheng@chromium.org,nzolghadr@chromium.org,adithyas@chromium.org,eirage@chromium.org Change-Id: I39f2b3b871370c18aa2da4aa6ae6f6c5d6db61d6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 843502 Reviewed-on: https://chromium-review.googlesource.com/1079987Reviewed-by:
Ella Ge <eirage@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#562994}
-
Wei-Yin Chen (陳威尹) authored
The in-memory bitmap cache can be reused elsewhere. Bug: None Change-Id: I71f593da22afe7eebb98c43d3f93240acf97d237 Reviewed-on: https://chromium-review.googlesource.com/1068126 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#562993}
-
Xiaohan Wang authored
Clang-format only. No functionality or code change. TBR=jrummell@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I7fada73aca62544a47e41401c3812768f3db4f7a Reviewed-on: https://chromium-review.googlesource.com/1077623 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#562992}
-
Adithya Srinivasan authored
This reverts commit 67834de4. Reason for revert: Causing failures on WebKit Linux Trusty Leak (https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20Leak/19550) Original change's description: > Reland "Check page exist after dispatch dragstart" > > This is a reland of 2c03b1bd > > The CL was reverted because of failures on the leak bot. > However the leak is not cause by the test or the patch. > Add the exception for the test for further investigation. > > Original change's description: > > Check page exist after dispatch dragstart > > > > frame_->GetPage() may be null. need to check before use GetDragState > > This CL reorder the some checks in MouseEventManager::TryStartDrag > > to make sure GetPage is valid before start drag. > > > > Bug: 843502 > > Change-Id: Ifdf5b20d7132ca4b089c9a5b7652ebbd41370c33 > > Reviewed-on: https://chromium-review.googlesource.com/1064878 > > Commit-Queue: Ella Ge <eirage@chromium.org> > > Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org> > > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#561262} > > Bug: 843502 > Change-Id: I093da085a84eecf2937d522b762b2feeeb1d7947 > Reviewed-on: https://chromium-review.googlesource.com/1079247 > Commit-Queue: Ella Ge <eirage@chromium.org> > Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#562953} TBR=dcheng@chromium.org,nzolghadr@chromium.org,eirage@chromium.org Change-Id: I5546c2b3469ecbf1ad40cc47ab8437075073abd5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 843502 Reviewed-on: https://chromium-review.googlesource.com/1079968Reviewed-by:
Adithya Srinivasan <adithyas@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#562991}
-
Reza.Zakerinasab authored
HTMLCanvaElement::convertToBlob() is a new promise-based toBlob API that allows to specify the color space and the pixel format of the target blob. Bug: 840372,847436 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I77c8b98ada3a5f9fbef38ad1b86d9ef15fdea570 Reviewed-on: https://chromium-review.googlesource.com/1048169 Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org> Reviewed-by:
Justin Novosad <junov@chromium.org> Reviewed-by:
Mohammad Reza Zakerinasab <zakerinasab@chromium.org> Cr-Commit-Position: refs/heads/master@{#562990}
-
Adithya Srinivasan authored
This reverts commit bad54cc3. Reason for revert: Causing layout test failures on Mac10.11: https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Mac10.11%20%28dbg%29/16416 Original change's description: > [Media Controls] Update loading animation > > This CL updates the media controls loading animation to match the new > mocks. > > Bug: 839093 > Change-Id: I5b46fb2c52a9421292ecbdb07db2b35958514b1b > Reviewed-on: https://chromium-review.googlesource.com/1077650 > Reviewed-by: Becca Hughes <beccahughes@chromium.org> > Commit-Queue: Tommy Steimel <steimel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#562897} TBR=mlamouri@chromium.org,beccahughes@chromium.org,steimel@chromium.org Change-Id: Ife4efead7e6619180494429b31056793a0ccd871 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 839093 Reviewed-on: https://chromium-review.googlesource.com/1079967Reviewed-by:
-
Sergey Volk authored
We should have all potentially supported codecs in the GetCastEmeSupportedCodecs list. Currently we are missing Vorbis, Opus and FLAC in there. EME checks IsSupportedMediaFormat first, which will perform platform-specific codec checks via MediaClient::IsSupported* APIs, before getting here. So codecs that are not actually supported on a given platform will be filtered out by MediaClient, but we should still have them here for platforms that do support them. Bug: none Change-Id: Icc5a572c042dca0dda93daaca63761e92b9f0eec Reviewed-on: https://chromium-review.googlesource.com/1079315Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Sergey Volk <servolk@chromium.org> Cr-Commit-Position: refs/heads/master@{#562988}
-
Vaclav Brozek authored
This CL adds the first use of std::make_reverse_iterator, inside the password_manager component at a place where it shortens an awkwardly long for-loop header. It also adds std::make_reverse_iterator to the allowed C++14 features. Bug: 845426 Change-Id: Ief6983c167b3c85a7d52a25555e8157d4d0f0a1c Reviewed-on: https://chromium-review.googlesource.com/1078758Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#562987}
-
chrome://discardsFadi Meawad authored
The frozen states and the discarded states are mutually exclusive. The CL merges the 2 booleans into one "state" column instead, and tracks the transition states as well. Instead of creating an new mojo enum for the lifecycle state in discards.mojom, I have moved the existing enum to to become a mojo enum that can be used in both locations and avoid conversion. Bug: chromium:804976 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I32cf0e3f24fc921270533046351f57079be20d5a Reviewed-on: https://chromium-review.googlesource.com/1054183Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Fadi Meawad <fmeawad@chromium.org> Cr-Commit-Position: refs/heads/master@{#562986}
-
Dominik Röttsches authored
Also update roll-freetype.sh script to be compatible with sed on macOS. https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/9e345c911714..d45d4b97e6a0 $ git log 9e345c911..d45d4b97e --date=short --no-merges --format='%ad %ae %s' 2018-05-30 prince.cherusker Beautify a3cfed5e87232c933bdc64f43e8ebebcfd18b41b. 2018-05-30 prince.cherusker Fix pointer underflow. 2018-05-30 wl Various minor color fixes. 2018-05-25 ramakrishnan.nikhil [docmaker] Fix missing `Defined in (...)' under Windows/Cygwin. 2018-05-24 apodtele [smooth] Formalize Harmony LCD rendering. 2018-05-22 wl Oops! 2018-05-22 wl [truetype] Reject elements of composites with invalid glyph indices. 2018-05-22 wl * src/truetype/ttgload.c (TT_Load_Simple_Glyph): Trace # of points. 2018-05-20 wl * include/freetype/ftcolor.h: New file. 2018-05-20 apodtele Autoformatting. 2018-05-18 apodtele * include/freetype/internal/ftcalc.h (FT_MSB): Verified `_MSC_VER'. 2018-05-18 wl * include/freetype/internal/ftcalc.h (FT_MSB): Use `_MSC_VER' value. 2018-05-18 wl Minor comment fixes. 2018-05-17 wl s/inline/__inline/ for MSVC. 2018-05-16 wl Add function `FT_Get_GlyphLayers' to access `COLR' table data. 2018-05-15 apodtele [base] Fix mono bitmap presetting (#53896). 2018-05-15 wl [psaux] Fix compiler warning (#53915). 2018-05-15 wl [sfnt] Fix memory leak in handling `COLR' data. 2018-05-15 wl Grammar fixes. 2018-05-15 wl [sfnt] If `COLR' is present, don't assume that all glyphs use it. 2018-05-14 wl * src/base/ftobjs.c (FT_Load_Glyph): Fix signature of `pixel_modes'. 2018-05-14 wl Provide dummy functions if `TT_CONFIG_OPTION_SFNT_NAMES' is not set. 2018-05-13 wl Typo. 2018-05-13 wl * src/base/ftobjs.c (FT_Load_Glyph): Improve tracing. 2018-05-13 shaozhang [sfnt] Preliminary support of coloured layer outlines. 2018-05-12 arkady.shapkin Use MS VC++'s _BitScanReverse to calculate MSB (patch #9636). 2018-05-11 parthwazurkar [pcf]Documentation Typo. Created with: roll-dep src/third_party/freetype/src R=bungeman@chromium.org,drott@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_msan_rel_ng PDFium-Issue: pdfium:1099 Change-Id: Ibc333c67c51472020c916f947ab73ef4ec8e83ba Reviewed-on: https://chromium-review.googlesource.com/1078942Reviewed-by:
Ben Wagner <bungeman@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#562985}
-
Ned Nguyen authored
Change-Id: Iaaeff35e5910aa2f313e60590365769c80e94ac2 Reviewed-on: https://chromium-review.googlesource.com/1077648Reviewed-by:
Emily Hanley <eyaich@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#562984}
-
Adithya Srinivasan authored
Test is flaky on trybots. Bug: 847959 Change-Id: I460e0098c824323286ec23daf5ee373369d8da67 No-Try: true Tbr: mathp@chromium.org, rouslan@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1079826Reviewed-by:
-
Daniel Murphy authored
Bug: 846046 Change-Id: Ibb7a8fc2d617f6d77ca148f86857a655ae9d4dc1 Reviewed-on: https://chromium-review.googlesource.com/1077193Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#562982}
-
