- 14 Sep, 2018 40 commits
-
-
Chris Harrelson authored
This improves BGPT testing to take into account layer position updates due to PAC, and also reduces GraphicsLayer size a little bit. It exposes gfx::PointF directly to some code in core, but that is ok because we already decided that gfx types are ok in core and this is just for SPv1 compositing. Bug: 883949 Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I6c0423aa66e94c24e96331381e6523ba1fb574b6 Reviewed-on: https://chromium-review.googlesource.com/1227301Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#591514}
-
Daniel Cheng authored
This reverts commit 27986c7c. Reason for revert: r590596 should have fixed this in a more robust way. Original change's description: > Speculative fix for additional History DocumentLoader crashes. > > There is no guarantee that the DocumentLoader is always attached [1], > so let's introduce null checks in StateInternal and setScrollRestoration. > > [1] The DocumentLoader may be detached while FrameLoader::PrepareForCommit. > > BUG=879477, 872672 > > Change-Id: I048ad8ff3787fcead262c19fcdb485e9e5a5e3bf > Reviewed-on: https://chromium-review.googlesource.com/1200075 > Commit-Queue: Charlie Reis <creis@chromium.org> > Reviewed-by: Nate Chapin <japhet@chromium.org> > Cr-Commit-Position: refs/heads/master@{#588227} TBR=creis@chromium.org,japhet@chromium.org,kouhei@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 879477, 872672 Change-Id: I1dd77d355f42269b70bb53ce19dcb3e1ecb0f15e Reviewed-on: https://chromium-review.googlesource.com/1227392Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#591513}
-
Dana Fried authored
Bug: 866513 Change-Id: I92abdf6f00cb59ef3c7193a3543a41a2fe4b4b6b Reviewed-on: https://chromium-review.googlesource.com/1227364Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#591512}
-
Robert Ogden authored
This DCHECK is especially annoying when testing on localhost when the server is not HTTPS. This changes the DCHECK to be a lot simpler. Open to other ideas to the same effect but the only alternative seems to be DCHECKing the finch param which doesn't seem better or worse. Bug: 864635 Change-Id: Icf7b12991acd2c6bab2cd13c4a40ff4bef1dcee1 Reviewed-on: https://chromium-review.googlesource.com/1227353Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#591511}
-
Dan Sanders authored
This CL completes plumbing a path for creating a MojoVideoDecoder via a render thread, and uses it to construct an RTCVideoDecoderAdapter if --enable-features=RTCVideoDecoderAdapter,MojoVideoDecoder is configured. Bug: 857111 Change-Id: Ia40b571c07cb7070150ec7c3d35320e051eb75ca Reviewed-on: https://chromium-review.googlesource.com/1226430Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#591510}
-
Alex Moshchuk authored
This only checked for the kContentShellAlwaysFork switch, which seems to be unused. Bug: 883549 Change-Id: Ib9e5e9df79caaa0e2d6cda8457b84cf4d391064c Reviewed-on: https://chromium-review.googlesource.com/1226462Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#591509}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/4230d4847fdc..62114aae8550 git log 4230d4847fdc..62114aae8550 --date=short --no-merges --format='%ad %ae %s' 2018-09-14 courtneygo@google.com glBufferSubData: Exit early if size is zero Created with: gclient setdep -r src/third_party/angle@62114aae8550 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: I5fc59ba1aeefeb44b62f149eaebbd400b84b80da Reviewed-on: https://chromium-review.googlesource.com/1227371Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#591508}
-
Ian Kilpatrick authored
This patch does a few things: 1) Introduces the concept of a "ReplacedPercentageResolutionSize". This is needed as replaced descandants of table cells have a different percentage resolution size than normal descendants. 2) This adds a bunch of special cases for how percentage resolution sizes are handled for table cells. 3) Adds the "scrollable" children of table cell quirk. This is during the "measure" phase, scrollable children contribute nothing to the size of the cell. 4) Adds the "box-sizing: border-box" table cell quirk. That is percentage children, during the layout phase, are sized as if they have box-sizing: border-box on them. It was easier to perform all these changes as a single monolithic patch to ensure correct behaviour. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I881a21662bfdf6b4ab7a0f62df6970143008ebca Reviewed-on: https://chromium-review.googlesource.com/1207890 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
David Grogan <dgrogan@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#591507}
-
Parastoo Geranmayeh authored
Part of the profile validation pipeline: Previously, we were only doing profile data validation on client side. Now we have two sources of validation: client and server. We need both. (The functions of the autofill profile are renamed accordingly.) Change-Id: Id930c667cacb512858fda4dd78268174d754159a Reviewed-on: https://chromium-review.googlesource.com/1205098 Commit-Queue: Parastoo Geranmayeh <parastoog@google.com> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#591506}
-
Min Qin authored
This serves as a base class for us to send UI updates for both download and offline items Bug: 881499 Change-Id: I54e50191764f9796250be02c7461cb96b9fa85a6 Reviewed-on: https://chromium-review.googlesource.com/1226456 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#591505}
-
Chris Palmer authored
Bug: None TBR: rsesek,kinuko,kouhei Change-Id: I2dda1e9ed0bcdf822a3d310a1654fded31eb8038 Reviewed-on: https://chromium-review.googlesource.com/1227355Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Chris Palmer <palmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#591504}
-
Gang Wu authored
Implement error handling in content storage, and change callback in java to lambda. Bug: 884230 Change-Id: I0dd9999dc221e7fb4d030d2b8f56d16482b04985 Reviewed-on: https://chromium-review.googlesource.com/1226079Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#591503}
-
Justin DeWitt authored
It was getting a bit cluttered in ExploreSitesBridge, so this creates an ExploreSitesBridgeExperimental that contains all the code required for the "experiment" version (that is still in use behind a flag.) Bug: None Change-Id: Ie5575d1960ef7016a08f7b4eff56327fa15ce1d7 Reviewed-on: https://chromium-review.googlesource.com/1227216 Commit-Queue: Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Cathy Li <chili@chromium.org> Cr-Commit-Position: refs/heads/master@{#591502}
-
Alexei Filippov authored
During thread exits TLS clears its storage vector. If after that a memory is allocated/deallocated profiler hooks gets triggered and access the TLS which makes it reallocate the storage vector that is then never deallocated. The patch makes profiler do not rely on base::ThreadLocalStorage and use the OS primitives directly. BUG=881352,803276 Change-Id: I8493768e57e4121c9ce38d09c77f8d38b04941b3 Reviewed-on: https://chromium-review.googlesource.com/1225280Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#591501}
-
Wenzhao Zang authored
Because views login hasn't implemented the code path to transition between web-ui OOBE to views-login directly, the web-ui public session pod is shown one-time only right after the enrollment completes. So for this bug, we should implement the web-ui and views versions separately. Bug: 882692 Change-Id: Ia3945b2dbfdb3a2e38db4d59c74248a29004bf37 Reviewed-on: https://chromium-review.googlesource.com/1226256Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#591500}
-
Fady Samuel authored
In a prior CL, GraphicsPipeline Metrics were added to AsyncLayerTreeFrameSink but the browser process does not use that when OOP-D is off. This CL adds those metrics to DirectLayerTreeFrameSink in order to allow us to do comparisons in Finch trial. Bug: 881262 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I8d3a7c41603d1b84e8d72ef530189b7864361c40 Reviewed-on: https://chromium-review.googlesource.com/1227141Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#591499}
-
Kenneth Russell authored
Up to version 7.14.1.1210, per customer report of poor behavior. Bug: 879098 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I29f5b3b501d2ff17572bcab1d490d4c308f398f3 Reviewed-on: https://chromium-review.googlesource.com/1218445 Commit-Queue: Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#591498}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/41562c7c..7a02a8fc Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic79b20ecf2943d3f2f64aa99630f0bb98b9bcdb4 Reviewed-on: https://chromium-review.googlesource.com/1227308Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#591497}
-
John Chen authored
Update parsing of proxy settings in session capabilities, for W3C compliance. Changes include: * Handle noProxy containing a list of strings. * Handle socksProxy and socksVersion. * Return kInvalidArgument for errors. Bug: chromedriver:2537 Change-Id: I545291b8249e147f75babee5dfe72137bfc4cdca Reviewed-on: https://chromium-review.googlesource.com/1226096Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#591496}
-
Justin DeWitt authored
This is implemented by adding a GetCatalogTask that has a few jobs: * Return the current catalog * Update the current catalog if there is one in the DB and it's the first time the catalog was requested since Chrome started. Also removes the "usable_on_ntp" boolean column from the sql store as it doesn't have a clear use in the design doc. Bug: 867488 Change-Id: I17ff725633f13e57a542e7e48fcf974a1ae1a3d1 Reviewed-on: https://chromium-review.googlesource.com/1226193 Commit-Queue: Justin DeWitt <dewittj@chromium.org> Reviewed-by:
-
Evan Stade authored
Some strings are only used by //chrome and can be moved to //chrome/app string targets. Some are used by //chrome and //ash and are moved to //chromeos/chromeos_strings.grd Bug: 756095 Change-Id: If7b3b89486035d36505f6d133b35593d10570f20 Reviewed-on: https://chromium-review.googlesource.com/1213585Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#591494}
-
Caleb Rouleau authored
It is currently set to 10 minutes, which means that test suites will time out first so we don't get a chance to provide a useful error message. It also makes reproing issues difficult because you need to wait for 10 minutes for them. Note that because of various retries, this could amount to 60 seconds of total time because of 2 ChromeDriver retries * 3 higher level retries. Bug: b/115528744 Change-Id: I15753fd5ac27e5d5ec36aa4f81a1a80133f4d6ff Reviewed-on: https://chromium-review.googlesource.com/1227307Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#591493}
-
Min Qin authored
TBR=dtrainor@chromium.org BUG=884280 Change-Id: Idb8b32c3f7418017bd0f6f7bae1e89f14cd2a060 Reviewed-on: https://chromium-review.googlesource.com/1225898Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#591492}
-
Joey Arhar authored
Bug: 877519 Change-Id: I738d6f7f871413e2df493bc7918538be441464e0 Reviewed-on: https://chromium-review.googlesource.com/1219990 Commit-Queue: Joey Arhar <jarhar@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#591491}
-
Khushal authored
In the case where the image cache is used with a color type other than N32, the software cache performs the original decode in the target color type followed by a scale operation. While the GPU cache always decodes to N32, scales it and then performs the color type conversion. Switch the GPU cache to have the same behaviour as software cache. R=ericrk@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I0199eefbc19b6038e2439d53946af0608afd498c Reviewed-on: https://chromium-review.googlesource.com/1223337Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#591490}
-
James Cook authored
The test has been disabled for 5 years. Bug: 316334 Change-Id: I34e4e0ebb407220cec9294a513b164f18e2af135 Reviewed-on: https://chromium-review.googlesource.com/1226160Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#591489}
-
Sky Malice authored
Bug: 866126 Change-Id: Ib6af1a8ae3e21354bef52257447dc9c2268aea8a Reviewed-on: https://chromium-review.googlesource.com/1222875 Commit-Queue: Sky Malice <skym@chromium.org> Reviewed-by:
Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#591488}
-
Ryan Hansberry authored
R=khorimoto@chromium.org Bug: 884323 Change-Id: I86ee823ac4d22f72792baf2494b504b53aa680c2 Reviewed-on: https://chromium-review.googlesource.com/1227225 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#591487}
-
Raymond Toy authored
As noted in the comments in that file, it is essentially the same as https://github.com/WebKit/webkit/blob/master/LayoutTests/webaudio/gain.html which was moved from there to WPT as gain.html. This test is now basically redundant and adds no additional coverage. Bug: 883167 Change-Id: Ie50111e263790025c615b64ad8f5e06428ae3177 Reviewed-on: https://chromium-review.googlesource.com/1221477Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#591486}
-
W. James MacLean authored
Re-enabling this test just long enough to collect logs from a couple of flakey runs of the test. TBR=kenrb@chromium.org Bug: 882458 Change-Id: Icb727a91a0b4178cf4cf18a162d218c78f47371f Reviewed-on: https://chromium-review.googlesource.com/1227306Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#591485}
-
Stephen Martinis authored
This reverts commit 9fc367df. Reason for revert: Broke bot Original change's description: > Linux ARM: Use swarming mixins > > This change is deliberately small (only changing one builder) to make > sure the feature is working correctly. > > Bug: 880973 > Change-Id: If9ffea3eadc461a994cd7dcc409b9b8206871024 > Reviewed-on: https://chromium-review.googlesource.com/1222165 > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Commit-Queue: Stephen Martinis <martiniss@chromium.org> > Cr-Commit-Position: refs/heads/master@{#591241} TBR=dpranke@chromium.org,kbr@chromium.org,martiniss@chromium.org,bpastene@chromium.org,jbudorick@chromium.org Change-Id: I0aca3b5b53c5f74f0af8f5fc287051cc4457cdd2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 880973 Reviewed-on: https://chromium-review.googlesource.com/1227394Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#591484}
-
Stefan Zager authored
Previously, IOv2 layout tests would enable IOv2 in script via: if (window.internals && internals.runtimeFlags) { internals.runtimeFlags.intersectionObserverV2Enabled true; } There are two problems with this approach: 1. By the time the above code runs, it may be too late: the prototype for the IntersectionObserverEntry javascript type may already have been created *without* the isVisible attribute. This was causing flaky test failures, because the exact timing of when the prototype is created may vary between runs. 2. Because the layout test runner re-uses content_shell processes for multiple tests, the side effects from turning on the feature flag affect tests that later use the same renderer process (see bug). This CL also adds DisableIntersectionObserverV2ThrottleForTesting, which eliminates the need to add a bunch of 100ms timers to the tests. Slow tests are bad. Finally, this CL reorders the handshake for cross-origin tests that rely on postMessage, to ensure that both the embedding frame and the child frame are properly initialized before starting the test procedure. BUG=882280,883676 R=chrishtr@chromium.org,foolip@chromium.org Change-Id: I18e62c2cf099bf74ef4afc43f46a794c7a322582 Reviewed-on: https://chromium-review.googlesource.com/1220044 Commit-Queue: Stefan Zager <szager@chromium.org> Reviewed-by:Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#591483}
-
Ryan Tseng authored
So that builder pools can be merged in bots.cfg Bug: 868213 Change-Id: Iea69b964ad411c15ee5c79fb67af7dff61792449 Reviewed-on: https://chromium-review.googlesource.com/1227146Reviewed-by:
Jao-ke Chin-Lee <jchinlee@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Ryan Tseng <hinoka@chromium.org> Cr-Commit-Position: refs/heads/master@{#591482}
-
Johann authored
Fork the arm builds so we can enable vp9 profile 2 (high bit depth) on chromeos devices without affecting other arm devices. BUG=chromium:875773 Change-Id: I23a9c2875a8585e2fd4e45ecc2a0e8b3ab317585 Reviewed-on: https://chromium-review.googlesource.com/1227217Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Johann Koenig <johannkoenig@google.com> Cr-Commit-Position: refs/heads/master@{#591481}
-
Sky Malice authored
Bug: 866125 Change-Id: I8f4da0990340d71342076f2d3ee5565267ad37f2 Reviewed-on: https://chromium-review.googlesource.com/1222683 Commit-Queue: Sky Malice <skym@chromium.org> Reviewed-by:
-
Lukasz Anforowicz authored
|window.opener| in main frame can point at a subframe (if the subframe called before |window.open('', '<name of the main frame>')|. If both frames are at about:blank, this can lead to an infinite loop in ScriptContext::GetEffectiveDocumentURL. Bug: 883526 Change-Id: I49b93b0bd068b1d0f2ea0241d0ede32ec6d6c689 Reviewed-on: https://chromium-review.googlesource.com/1222877 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by: -
Mike Wasserman authored
Touch selection editing handles use window targeting insets. (to let users more easily tap text above the visible handle) Adjust targeting of the handle's client root window in Mus. (otherwise events target the server's invisible root window) Bug: 872891 Test: KSV (Ctrl-Alt-/) touch edit handles don't block tapping text. Change-Id: I6d8614257dc4927a1562bc02c2eefef1f8ff2faa Reviewed-on: https://chromium-review.googlesource.com/1226877Reviewed-by:
-
Jian Li authored
This reverts commit d91dacc0. Reason for revert: Failed base_unittests Run on OS: 'Ubuntu-14.04' SequenceBoundTest.MultiplyDerivedDestructionWorksLeftSuper SequenceBoundTest.MoveAssignmentFromDerivedClass SequenceBoundTest.MoveConstructionFromSameClass SequenceBoundTest.MoveAssignmentFromSameClass SequenceBoundTest.PostBeforeConstruction SequenceBoundTest.MoveConstructionFromDerivedClass SequenceBoundTest.MultiplyDerivedPostToLeftBaseClass SequenceBoundTest.ConstructThenPostThenReset SequenceBoundTest.MoveAssignmentFromDerivedClassDestroysOldObject SequenceBoundTest.MultiplyDerivedDestructionWorksRightSuper SequenceBoundTest.MultiplyDerivedPostToRightBaseClass https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20CFI/10148 Original change's description: > SequenceBound<T> for classes with affinity to a sequence. > > SequenceBound<T> allows for easy creation, posting, and destruction > objects of type T on a designated Sequence. It does not expose the > underlying pointer to T, so it's hard to accidentally pass them around > in callbacks that are then run on the wrong thread. > > A SequenceBound<> may be created anywhere, passed (moved) between > threads, etc., safely. Destruction of the SequenceBound schedules > destruction of the underlying instance of T on the appropriate thread. > > Not implemented here (but prototyped elsewhere) are weak pointers > to these objects that may be passed and used between threads safely; > utility functions to generate thread-hopping callbacks; support for > strong shared ownership semantics. > > Tests: sequence_bound_unittest.cc > > Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > Change-Id: I3bbf7e975884fce8e18f3bb15a0d211ead58a619 > Reviewed-on: https://chromium-review.googlesource.com/875241 > Commit-Queue: Frank Liberato <liberato@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Taiju Tsuiki <tzik@chromium.org> > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#591429} TBR=dcheng@chromium.org,dalecurtis@chromium.org,liberato@chromium.org,tzik@chromium.org Change-Id: I122ffbe8eb1670e7a252392fb7c28652672d1bc7 No-Presubmit: true No-Tree-Checks: true No-Try: true Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1227356Reviewed-by:
Jian Li <jianli@chromium.org> Commit-Queue: Jian Li <jianli@chromium.org> Cr-Commit-Position: refs/heads/master@{#591477}
-
Christian Biesinger authored
Use =default in some places where we can, to avoid hand-writing move constructors and move assignment operators. Also adds a move constructor to NG{Unp,P}ositionedFloat and adds a missed std::move call. R=eae@chromium.org,ikilpatrick@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I8c3c850d495b455a9a6dddff0b62f3dcf1927c64 Reviewed-on: https://chromium-review.googlesource.com/1226008Reviewed-by:Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#591476}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/776a411b5267..a7914d3a8e3b git log 776a411b5267..a7914d3a8e3b --date=short --no-merges --format='%ad %ae %s' 2018-09-14 michaelludwig@google.com Implement textured gradients 2018-09-14 csmartdalton@google.com ccpr: Remove the dangling pointer from GrCCDrawPathsOp 2018-09-14 robertphillips@google.com Harden SerializedImageFilter fuzzer against filter creation failure 2018-09-14 robertphillips@google.com Preserve fLastMoveToIndex in SkPath::transform 2018-09-14 caryclark@skia.org fix error reporting for doc examples 2018-09-14 michaelludwig@google.com Implement dual interval gradients Created with: gclient setdep -r src/third_party/skia@a7914d3a8e3b The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=caryclark@chromium.org Change-Id: I7d0ec294f34b7e529cc1623651a44312662caf88 Reviewed-on: https://chromium-review.googlesource.com/1226387Reviewed-by:
-
