- 16 Dec, 2020 40 commits
-
-
Nancy Wang authored
This reverts commit 93ae228e. Reason for revert: <INSERT REASONING HERE> This CL relands CL:2586647, which is reverted because breaks the test: PluginVmFilesTest.LaunchPluginVmApp The reason is |mock_window| is accessed after free, because after the end of the test, when launcher_item_controller is destroyed, |mock_window| is accessed. Modify the test case, to set the controller, so that |mock_window| can be removed from |launcher_item_controller|'s windows list. Modify AppWindowBase, to check whether widget_ is null in GetNativeWindow to avoid crash, because widget_ is null in the test case. So CL:2586647 can be relanded again. Change-Id: I50cb7b138bda0e588ad97b62297a855df48c0239 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592077Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#837660}
-
Xida Chen authored
This CL converts the ErrorCallback in the mtp_device_async_delegate.h to a base::RepeatingCallback. We use a RepeatingCallback instead of OnceCallback because in the MTPDeviceDelegateImplLinux::CopyFileFromLocal this callback is used twice. Bug: 1152278 Change-Id: I002dceb79ebf017c138b1d0aaf5d85d8d161be83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593477Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#837659}
-
Stephen McGruer authored
Also moved previously generally disabled tests to only be disabled on ChromeOS because they only appear to be flaky there according to crbug.com/1157649 TBR=oshima@chromium.org Bug: 1157649 Change-Id: Ia9dec49edcea6fc5f0e47f0fc74f30699adf1270 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595830Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#837658}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/54174aefa84c..6bf9e131d05a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I7eb33ff5561022ba9ff48ff207654bb3ea983d60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595508Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#837657}
-
Mila Green authored
Here is the new state: $ launchctl list | grep GoogleUpdater - 0 com.google.GoogleUpdater.update - 0 com.google.GoogleUpdater.wake.89.0.4357.0 - 0 com.google.GoogleUpdater.update-internal.89.0.4357.0 $ launchctl list com.google.GoogleUpdater.update { "LimitLoadToSessionType" = "Aqua"; "MachServices" = { "com.google.GoogleUpdater.update.mach" = mach-port-object; }; "Label" = "com.google.GoogleUpdater.update"; "OnDemand" = true; "LastExitStatus" = 0; "Program" = "/Users/milagreen/Library/Google/GoogleUpdater/89.0.4357.0/GoogleUpdater.app/Contents/MacOS/GoogleUpdater"; "ProgramArguments" = ( "/Users/milagreen/Library/Google/GoogleUpdater/89.0.4357.0/GoogleUpdater.app/Contents/MacOS/GoogleUpdater"; "--server"; "--service=update"; "--enable-logging"; "--vmodule=*/updater/*=2"; ); }; $ launchctl list com.google.GoogleUpdater.update-internal.89.0.4357.0 { "LimitLoadToSessionType" = "Aqua"; "MachServices" = { "com.google.GoogleUpdater.update-internal.89.0.4357.0.mach" = mach-port-object; }; "Label" = "com.google.GoogleUpdater.update-internal.89.0.4357.0"; "OnDemand" = true; "LastExitStatus" = 0; "Program" = "/Users/milagreen/Library/Google/GoogleUpdater/89.0.4357.0/GoogleUpdater.app/Contents/MacOS/GoogleUpdater"; "ProgramArguments" = ( "/Users/milagreen/Library/Google/GoogleUpdater/89.0.4357.0/GoogleUpdater.app/Contents/MacOS/GoogleUpdater"; "--server"; "--service=update-internal"; "--enable-logging"; "--vmodule=*/updater/*=2"; ); }; Bug: 1143718 Change-Id: I66289cebf8d35acc63cbbc9c5e3d46d7da283df1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594118Reviewed-by:Sorin Jianu <sorin@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Mila Green <milagreen@chromium.org> Cr-Commit-Position: refs/heads/master@{#837656}
-
Sigurd Schneider authored
Transfering SABs via postMessage will be prohibited soon. This CL adds an inspector issue if such an attempt is made so as to provide a warning for this breaking change to users. The warning is only filed once per execution context to not impair performance during the transition period (getting the source position and sending the issue to the front-end has quite some overhead). Once the transfer is forbidden (postMessage throws on SABs then), the warning will be filed on every attempt. Bug: chromium:1138945 Change-Id: I6c0596afa2276118a3e6e6de1a1410fa76e9aaa7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593087Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#837655}
-
Angela Yoeurng authored
Bug: 1129612 Change-Id: I12d09d4699505b26df91058a9bbf74f3cb2f0e54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590507Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Auto-Submit: Angela Yoeurng <yoangela@chromium.org> Cr-Commit-Position: refs/heads/master@{#837654}
-
David Bokan authored
This CL converts two calls to base::Bind into base::BindOnce in hid_api.cc This requires converting: - HidDeviceManager::GetApiDevices - DevicePermissionsPrompt::AskForHidDevices To using a OnceCallback. Both methods can store the callback but always clear it after the only invocation site so we're guaranteed this only runs once. Bug: 1152268 Change-Id: I07a9f50c5eb57b987de220408e8d7f9249bed8b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593563Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#837653}
-
David Bokan authored
This callback is only ever invoked synchronously or put into a BindOnce and invoked from there. Hence, it cannot be called multiple times. Bug: 1152268 Change-Id: Ib7012cf922ab8de546f712bbda36e448c63005d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593876 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
-
Guillaume Jenkins authored
If browser sign-in is disabled by the BrowserSignin policy, skip the sign-in flow in the FRE. Bug: 1155745 Change-Id: Id106f212ef4d5942a31f0437820a1d4510a7ff06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582725 Commit-Queue: Guillaume Jenkins <gujen@google.com> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#837651}
-
David Bokan authored
This CL converts the success callback parameters to the: - BluetoothApiSocket::Accept - BluetoothApiSocket::Receive In both cases, the callback is passed to an equivalent method of the BluetoothSocket class which already takes a OnceCallback. Bug: 1152268 Change-Id: I22bfc954e48fdf2b9a4e9dd15e32b562d117e4c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594012 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
-
ckitagawa authored
This CL attempts to fix a bug where calling WebContents::DecrementCapturerCount in the callback passed to PaintPreviewClient can result in reloading a crashed render frame. This is problematic and crashes if it occurs inside RenderFrameDeleted and PaintPreviewClient::OnFinished is invoked. By posting the callback it should be invoked after RenderFrameDeleted cleanup is done resulting in DecrementCapturerCount no longer being called inside RenderFrameDeleted. Bug: 1146573 Change-Id: Iccb612d89135e058d8fc06de018e7c95cd91657a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595247 Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#837649}
-
arthursonzogni authored
It exists one RenderWidgetHostObserver deleting itself without calling RemoveObserver(this) on its RenderWidgetHost. All the observers are immune to this error, because they are using base::ScopedObserver. All except RenderWidgetHostVisibilityTracker. This class looks error free, but it doesn't hurt to make it use base::ScopedObserver as well, just in case. Bug: 1153966 Change-Id: I6160da2853d94cf647cfa55d79100ec6f52bd42b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594772 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#837648}
-
Tomasz Wiszkowski authored
This change ensures proper reset of the AutocompleteControllerAndroid when the Java counterpart is destroyed. The change warrants no subsequent calls to be made to destroyed object. Bug: 1158332 Change-Id: I0d6d014dd3dab79751254edaf7a26faae97fa56c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593824 Commit-Queue: Tomasz Wiszkowski <ender@google.com> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#837647}
-
Koji Ishii authored
Also removes |NGPaintFragment::PositionForPoint*| that are cross-calling |NGPaintFragment| functions in |NGInlineCursor|, and changes a few other callers to |NGPaintFragment| functions. Bug: 1154531 Change-Id: I41e35b04faa0e6ff0daebced0bb78d6600ab9962 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592850 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Auto-Submit: Koji Ishii <kojii@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#837646}
-
Morten Stenshorne authored
Mostly about legacy block fragmentation. Change-Id: I7d2f24d12a8c07ae87618afa6eb9977336a02464 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595167Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d5b38571d31e..67e12286df04 2020-12-16 sokcevic@google.com Add validation after downloading cache from GS If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1159123 Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I938835ea3dd851cf5dde8fe301b6bb701c2e78d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595848Reviewed-by:
-
Mario Sanchez Prada authored
These tests were disabled due to flakiness introduced by some recent migrations from legacy IPC to mojo that landed past week, which I think should be fixed by crrev.com/c/2587045, which has been just merged. Let's re-enable them now to double-check if the fix actually worked as expected, keeping an eye in case they are still flaky after this. Bug: 1157263, 1157241, 1157239, 1157319 Change-Id: I2b1daffebbb157eca5f8cce3f7692dbfabe75bf8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593367 Auto-Submit: Mario Sanchez Prada <mario@igalia.com> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#837643}
-
Austin Sullivan authored
On write failure, the QuotaManagerProxy calls NotifyWriteFailed to surface this failure to quota. On filesystems which don't support quota, no check is currently made that the manager exists before NotifyWriteFailed is called. Bug: N/A Change-Id: Iae14483fb9c395576102c82c3a5fa60fac9f1343 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593745 Auto-Submit: Austin Sullivan <asully@chromium.org> Commit-Queue: Austin Sullivan <asully@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#837642}
-
Fabio Rocha authored
Previously, ProtocolHandlerRegistry supported only single-protocol operations (e.g. add a handler to the registry and register with the OS in a single function). For the web app handler use case, repeatedly calling single-protocol functions for multiple app handlers is a problem because multiple OS registrations will result in multiple UACs being presented to the user. This CL lays the groundwork for upcoming changes to introduce batching to the ProtocolHandlerRegistry which allows for a single OS registration operation and single UAC. SetDefaults() is added to support registering multiple default web app handlers at a time. A single-protocol SetDefault() is also left in place for use in existing call sites. RemoveHandlers() is added to support removing multiple default web handlers and registering their replacement default handlers in batch operations. A single-protocol RemoveHandler() is left in place for use in existing call sites. Since this is just a refactor there should be no observable difference in behavior with this code. CL 2573383 will build on this code and add more test cases for the case of multiple registration. Bug: 1019239 Change-Id: I4488815d39fcce164a9c7054cbcc34d473d806ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573319Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Fabio Rocha <fabio.rocha@microsoft.com> Cr-Commit-Position: refs/heads/master@{#837641}
-
Anqing Zhao authored
In the Kiosk session, users have no way to check whether force-installed extensions specified by the admins are loaded successfully. So we need to provide a warning explicitly to the users when these extensions might not work as expected. Two main cases have to be covered. - The force-installed extensions are not ready within the time limit. (2 minutes) - The policy value of ExtensionInstallForcelist is invalid. Bug: 1153440 Change-Id: Ia7f278af5f9b63dd2b5d9fc18cd100ef044c50e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584780 Commit-Queue: Anqing Zhao <anqing@chromium.org> Reviewed-by:
Anatoliy Potapchuk <apotapchuk@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#837640}
-
Alex Turner authored
The content/ public API explicitly forbids use of the const identifier on interfaces to avoid assumptions about the implementation. For this reason, const identifiers on pointers to a content class prevent the use of any of its methods. We thus remove the const identifier from some RenderFrameHost pointers to allow for a future change to ContentSubresourceFilterThrottleManager ::IsFrameTaggedAsAd(). The future change (crrev.com/c/2561207) will require invocation of a RenderFrameHost method using the currently const pointer. Bug: 1151500 Change-Id: Ie6ada00f211f3f04db35cb88331d2c8599b5dfaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593693 Commit-Queue: Alex Turner <alexmt@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#837639}
-
David Bokan authored
This CL converts two functions to use BindOnce: - BluetoothSocketSendFunction - BluetoothSocketDisconnectFunction In both cases, the callback is passed to a method on |socket_| which already takes a OnceCallback so this is a safe change. The Send function requires a bit of extra work due to the error callback but this is also obviously a OnceCallback. Bug: 1152268 Change-Id: Ieb457c3d86f63732f33f851ac1f659e35af9a44c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592249 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
-
Lukasz Anforowicz authored
Since destruction of RenderFrameHostManager may lead to arbitrary callbacks (some of which may try to access FrameTreeNode that owns the RFHM), we need to ensure that RFHM is destructed before any other FTN fields. Fixed: 1157988 Change-Id: Ie8c69ad74f95a7e3880ccbaf506641c3dc4fdb46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593520 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#837637}
-
Eugene Zemtsov authored
Change-Id: I14416ee945a9b8c7b321dd006904dd598fca99eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595009 Auto-Submit: Eugene Zemtsov <eugene@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#837636}
-
David Bokan authored
The cases converted in this CL are already being passed to functions taking a OnceCallback/OnceClosure so are an easy conversion. Bug: 1152268 Change-Id: If0d5157941c1ec9950537b2f5e315d76012a6a24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592189Reviewed-by:
-
Rune Lillesveen authored
ComputedStyle from PseudoStyleForElement may be null if there are no matching rules. It shouldn't really happen here, but the code for updating paint layers on style recalc is computing style for children, which is potentially problematic and should be avoided. Updated FIXME to reflect that. Bug: 1150472 Change-Id: Iba6af725d50093113a1a5a18ac9ac95cb249fe59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594909 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#837634}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/a885fded8b30..cfecd6b3e2e9 2020-12-16 vapier@chromium.org service: drop six import 2020-12-15 chrome-bot@chromium.org Update config settings by config-updater. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: I7678054a622b2b4365a93dd0d6fa2d65eab7759c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594465Reviewed-by:
-
Yi Gu authored
Bug: 1152282 Change-Id: I651b8b392057fbb302380df401a39a7fd21c3942 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595448Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#837632}
-
Al Muthanna Athamina authored
This CL was created automatically with tools/perf/update_wpr script R=johnchen@chromium.org Bug: chromium:1158374 Change-Id: I236e17b0d8629f3a523f53ff190c7ae946bc84d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2588914 Commit-Queue: Almothana Athamneh <almuthanna@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Tamer Tas <tmrts@chromium.org> Auto-Submit: Almothana Athamneh <almuthanna@chromium.org> Cr-Commit-Position: refs/heads/master@{#837631}
-
Sam Maier authored
This also requires us to fix the one failing location. Bug: 1029038 Change-Id: I85591b3c0d435d5ef9e725a8d27167aa266af3a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593837Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Auto-Submit: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#837630}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/68cf42e8f227..9e5d60a44d42 2020-12-16 tvanderlippe@chromium.org [module.json extensions] Accessibility 2020-12-16 janscheffler@chromium.org [Recorder] Clean up generated code 2020-12-16 jacktfranklin@chromium.org [DataGrid]: test to ensure resize persists as data is added If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1134103,chromium:1153102,chromium:1154575 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia263ce20a338f513027a3e0da0ce6ced6ddff7a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595208Reviewed-by:
-
Mehran Mahmoudi authored
Bug: 1159243 Change-Id: Id6d31775e8962d2e8d08b98f0c724f9f9688bf2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595449Reviewed-by:
Fred Mello <fredmello@chromium.org> Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#837628}
-
Xianzhu Wang authored
We should ignore layout shift if the object was ineligible for layout shift tracking during the previous paint invalidation. Add LayoutObject::ShouldSkipNextLayoutShiftTracking() and set it during paint invalidation if the object is ineligible for layout shift tracking. In the next paint invalidation, if the flag is true, skip layout shift tracking and reset the flag. This also applies to content-visibility:auto for which we cleared LayoutBox's previous size to prevent layout shift tracking for the next cycle. The new flag is basically equivalent to the old method, but also covers more cases, e.g. the old method would fail if the object had visual overflow because PreviousPhysicalVisualOverflowRect() was not based on PreviousSize() and empty. Bug: 1152869 Change-Id: I000489dd8093dab8d2ab3605ad4ce3bd39fd11b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2591367Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#837627}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/df1712b41e9f..6bf9e131d05a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I3937c3b919cd6ee04c0e2a3d33c25bb6930df258 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595227Reviewed-by:
-
Leonard Grey authored
Bug: 1152274 Change-Id: I99302b180a5b71e89738598b8746e66bda34eba5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593869 Commit-Queue: Leonard Grey <lgrey@chromium.org> Reviewed-by:
-
Ian Wells authored
Bug: 1152187 Change-Id: Ibd26b985f98dc5b5ea60dff4f48d53fc7c806fb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593157 Commit-Queue: Dan H <harringtond@chromium.org> Auto-Submit: Ian Wells <iwells@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#837624}
-
Leonard Grey authored
Also changes a few one-off binds in DevToolsFileHelper Bug: 1152274 Change-Id: Ibed34dd02d8a28c0d47b66951c04fd04e9a83393 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593751Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#837623}
-
Frédéric Wang authored
After [1], blink::network_utils::IsOriginSecure is strictly equivalent to network::IsUrlPotentiallyTrustworthy. This CL removes IsOriginSecure, performs corresponding replacements and optionally adjusts DEPS files. Some conditions webauth_request_security_checker.cc and mixed_content_navigation_throttle.cc are also simplified, because checks are already included in network::IsUrlPotentiallyTrustworthy. There is no behavior changes, although uses of IsOrigin vs IsUrl may need to be reviewed in follow-up CLs [2]. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2563683/1 [2] https://bugs.chromium.org/p/chromium/issues/detail?id=1158302 Bug: 1153336 Change-Id: Ibd1828c14d92c33291095174dbeb466259cc4530 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563883Reviewed-by:
Cait Phillips <caitkp@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Frédéric Wang <fwang@igalia.com> Cr-Commit-Position: refs/heads/master@{#837622}
-
Jan Wilken Dörrie authored
TBR=karandeepb Bug: 1159418 Change-Id: I6974cc4a21b1bd89a3fd7124ec33e5f7812b26c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595367Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#837621}
-
