GitLab

Half of requested cleanup following text scaling issues with Windows
Text Zoom accessibility feature.

Removes calls to GetNonClientMetrics() sprinkled around the code, as
well as most uses of the Windows LOGFONT struct outside of
platform_font_win and its callbacks.

The remainder of the cleanup will be in a followup CL, which will
consolidate all of the fiddly scaling and other uses of LOGFONT into
platform_font_win.

Bug: 888788
Change-Id: Iff47d2037b6a70210bd1eb0f24ab2f0430c59f86
Reviewed-on: https://chromium-review.googlesource.com/1246824Reviewed-by: Robert Liao <robliao@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Dana Fried <dfried@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594889}

This reverts commit 1ef23c93.

Reason for revert: 
Caused several styling breakages across WebUI surfaces, see https://bugs.chromium.org/p/chromium/issues/detail?id=890030

Original change's description:
> Make :host account for its own pseudo-class specificity.
> 
> Otherwise `:host div` is equally specific to `div`, which seems undesirable and
> doesn't match any spec.
> 
> Bug: 857415
> Change-Id: I0a012ada134acb022dab85c3912b33ac5d0bd1dd
> Reviewed-on: https://chromium-review.googlesource.com/1238445
> Commit-Queue: Emilio Cobos Álvarez <emilio@chromium.org>
> Reviewed-by: Rune Lillesveen <futhark@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#594745}

TBR=emilio@chromium.org,futhark@chromium.org,andruud@chromium.org

Change-Id: I98ce78a982a1d71356f18ec60a01e9616d5f9eec
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 857415
Reviewed-on: https://chromium-review.googlesource.com/1250054Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594888}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/cf257cec18f0..95d4c855637a


git log cf257cec18f0..95d4c855637a --date=short --no-merges --format='%ad %ae %s'
2018-09-27 enne@chromium.org Add skia reviews to my_activity


Created with:
  gclient setdep -r src/third_party/depot_tools@95d4c855637a

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: I95dabb93c078fb1fdba002e293586353e38773cf
Reviewed-on: https://chromium-review.googlesource.com/1249514Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#594887}

The flaky lower-case font matching ("ahem") has been fixed in
https://crrev.com/c/1249385 , so we can unskip this test now.

Bug: 724392
Change-Id: I2a005fe055684aa9e8662a0324a6f7ad84935a1a
Reviewed-on: https://chromium-review.googlesource.com/1249276Reviewed-by: Erik Chen <erikchen@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594886}

We ancitipate future changes where certain bridges will lack the support
for client tag hashes. Hence, let's accomodate that in the bridge
interface and update the processor to honor the new contract.

Bug: 870624,881289
Change-Id: Ic871d7a9fd7cf9c9a989624e1691409aed400e39
Reviewed-on: https://chromium-review.googlesource.com/1249023
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Florian Uunk <feuunk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594885}

Bug: 867518

R: jialiul
Change-Id: Ie6cd84e046f00f384c966e8dd6182cee41541c80
Reviewed-on: https://chromium-review.googlesource.com/1249817Reviewed-by: Jialiu Lin <jialiul@chromium.org>
Commit-Queue: Varun Khaneja <vakh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594884}

Change-Id: I9f0b101c57bcba075149a876e9d74e6fca721788
Reviewed-on: https://chromium-review.googlesource.com/1235374Reviewed-by: Sergey Poromov <poromov@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: Aga Wronska <agawronska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594883}

This cl calls new API in sound level input value provider.

Bug: b/115800133
Test: manual
Change-Id: I375b3421c6f3d34d5f0d512a99a335420d9586af
Reviewed-on: https://chromium-review.googlesource.com/1250086Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594882}

BUG=800033

Change-Id: Ia139fc7abbefea00e3b6a806a02b367f81a5337f
Reviewed-on: https://chromium-review.googlesource.com/1249073Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594881}

+ NewTabPageTest#testRender_FocusFakeBox
+ NewTabPageTest#testRender_ArticleSectionHeader

Bug: 888129, 888997
Change-Id: Ic7d66bf90c1fe0a42c22224a5a889a04e6ffb7d1
Reviewed-on: https://chromium-review.googlesource.com/1249129Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Becky Zhou <huayinz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594880}

Before this patch, a misconfigured wait_for_dom action with an empty
selector would trigger a DCHECK in the web_controller.

This patch fails a wait_for_dom action early when there is no selector.

After the patch, we will stop a misconfigured script alreday in the wait
for dom action.

R=rouslan@chromium.org

Bug: 806868
Change-Id: I13d7498cd08e3239777d00946e2bf6176a9680d4
Reviewed-on: https://chromium-review.googlesource.com/1249028
Commit-Queue: Mathias Carlen <mcarlen@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594879}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/3ca11d72..c0b96b43

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I77d6f27c228587381e0213b8d9a904c70eb53413
Reviewed-on: https://chromium-review.googlesource.com/1249804Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#594878}

This CL adds utilities to DnsQuery to allow the parsing of a DNS
query in the wire format if it is a valid query with a single question.
A new constructor of DnsResponder is also added to generate DNS
responses in the wire format with multiple resource record as answers.
Name compression in multiple answers are not yet implemented in this CL.

Combined with the existing utilities in //net/dns/, we now have a full
set of capabilities to parse and generate DNS/mDNS queries and response.

Bug: 878465
Change-Id: Ifeae0d17243df037af7a3ea0bffb1079018ea714
Reviewed-on: https://chromium-review.googlesource.com/1203320
Commit-Queue: Qingsi Wang <qingsi@google.com>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Eric Orth <ericorth@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594877}

Adds a memcpy (unfortunately) to allow content::VideoEncodeAccelerator
to pass VideoFrame data to a HW encoder. Commit 4a74fb0f
had migrated the VIZ screen capturer to use the new read-only shmem API;
but, unfortunately, the VEA framework for HW video encode still
expects/requires the use of the legacy shmem API.

Also added a little extra logic to more-gracefully halt encoding once a
fatal error occurs. This issue was revealed while diagnosing the above
problem, and is being fixed here since it is related.

TBR=pthatcher@chromium.org

Bug: 888153, 888829
Change-Id: I7e37c024f4c8b2648769b98040e3d28597b199fc
Reviewed-on: https://chromium-review.googlesource.com/1242396Reviewed-by: Yuri Wiitala <miu@chromium.org>
Commit-Queue: Yuri Wiitala <miu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594876}

When IME runs remotely there is a callback that is used to signal
if the event was handled. This callback is passed around number places.
InputMethodChromeOS injects its own callback that does some processing.
InputMethodBase was running the callback immediately, not passing it through.
This meant some processing was happening that should have been conditional
based on the response from the remote client.

BUG=888740
TEST=none

Change-Id: I51804626cf5bce3bec9690ef33b75d94229228a4
Reviewed-on: https://chromium-review.googlesource.com/1243671
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594875}

ios12-beta-simulator.json
ios12-sdk-device.json
ios12-sdk-simulator.json
ios12-sdk-xcode-clang.json

xcode10.1 (10o23u)

Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Id0dac987f4f4c6cda6e1ff4149dd612be5c65bea
Reviewed-on: https://chromium-review.googlesource.com/1249397
Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594874}

These two metrics are used to estimate the time cost of notification image
file deletion, which provides insight about whether the image folder is
corrupted or not.

Bug: 888276
Change-Id: I65eee40cae08007ef6dba056b3698436f0d563e7
Reviewed-on: https://chromium-review.googlesource.com/1246783Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Xi Cheng <chengx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594873}

This CL is adding the support for the stack sampling profiler to the GPU
main thread. The |tracing_sampler_profiler| is an adaptor that forward
stack sample as trace events. These events are collected by slow-reports.

This code is only running when the trace category "cpu_sampler" is
activated and should not affect performance otherwise.

R=piman@chromium.org, ssid@chromium.org

Bug: 888580
Change-Id: Ie703d965c1d158581da6fac1ac0f6ea2157ed6f1
Reviewed-on: https://chromium-review.googlesource.com/1249534Reviewed-by: Siddhartha S <ssid@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594872}

This reverts commit ab21d472.

Reason for revert: Broke
 - Print preview 'esc' behavior when dialog is open
 - Settings add-language-dialog ctrl+f behavior

Original change's description:
> Don't propagate keydown events when dialog is open
> 
> We shouldn't propagate keydown events so that it can
> behave modally.
> 
> Bug: 883221
> Cq-Include-Trybots: luci.chromium.try:closure_compilation
> Change-Id: I4aa5257b4bf6c417123d659ba911cb01641a4cc7
> Reviewed-on: https://chromium-review.googlesource.com/1230493
> Reviewed-by: Scott Chen <scottchen@chromium.org>
> Commit-Queue: Sang Woo Ko <sangwoo108@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#593619}

TBR=calamity@chromium.org,scottchen@chromium.org,sangwoo108@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 883221
Change-Id: I8f044d3e62ffce565a0761327b6aa877d1463224
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Reviewed-on: https://chromium-review.googlesource.com/1249809Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594871}

Bug: 739532,875525
Change-Id: I4bf43b572eb7a9417f373b414ef101d1d580ef4b
Reviewed-on: https://chromium-review.googlesource.com/1249840Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594870}

Bug: 887392
Change-Id: I5de7b4d218cd31fe637d52d94f9ba888b88a4c1d
Reviewed-on: https://chromium-review.googlesource.com/1249446
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594869}

The fast paths handles cases that source is the parent of destination
or visa versa.

This simplifies client code of GeometryMapper in PaintLayerClipper
and can get the similar performance.

Bug: 875991
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I4d3a465d3e40f453b389ca51b9e23918db3b95fb
Reviewed-on: https://chromium-review.googlesource.com/1236555
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594868}

https://chromium.googlesource.com/catapult.git/+log/7a4e890f252c..8e0212945b13


git log 7a4e890f252c..8e0212945b13 --date=short --no-merges --format='%ad %ae %s'
2018-09-27 mattm@chromium.org netlog_viewer: appengine files and deployment instructions


Created with:
  gclient setdep -r src/third_party/catapult@8e0212945b13

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:888816
TBR=sullivan@chromium.org

Change-Id: If30b1d87f4dc1ab7ffae61bc1e609fc6275ff0d1
Reviewed-on: https://chromium-review.googlesource.com/1249513Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#594867}

Previously ContainingBlockFor(Fixed|Absolute)Position was used to get
the clip state of the container of fixed|absolute descendants. However,
if the container is not a LayoutBlock, the mentioned functions will
return the containing LayoutBlock which may not be a layer thus may not
have LocalBorderBoxProperties to get the clip state.

Now use ContainerFor(Fixed|Absolute)Position instead, and add test.

Bug: 889734
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I6a1c95f81259a566791b40867b666b5c9852066a
Reviewed-on: https://chromium-review.googlesource.com/1249827
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594866}

The hypothesis here is that the test outcome is, strictly speaking,
non-deterministic, because a server with an eventual consistency model
cannot guarantee how exactly a conflict will be resolved (although it
will guarantee that clients converge). In this model, the last commit
will win.

We fix the previously existing test by making sure which of the two
clients commits first to the server. This is achieved by mimic-ing an
offline state (or poor connectivity compared to the other client).

In order to verify the hypothesis, we add a second test that enables
strong consistency model on the server (implemented as part of this
patch), and hence relies on that mechanism to expect a deterministic
outcome without having to put clients offline.

Bug: 810408
Change-Id: I2fa3fd8c941674344030a76e76f7855131c1908e
Reviewed-on: https://chromium-review.googlesource.com/1249482
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Tim Schumann <tschumann@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594865}

1. addResultToOutput
2. addResultTableToOutput
3. createAutocompleteResultTableHeader,
4. addParagraph

instead of

1. createAutocompleteResultTableHeader
2. addParagraph
3. addResultToOutput
4. addResultTableToOutput).

Change-Id: I3fa7553993fe2256a5c1efb0f3b69bffaa56aa49
Reviewed-on: https://chromium-review.googlesource.com/1249830
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594864}

The download guid in DownloadInfo.java is not plumbed from OfflineItem.
This will cause DownloadItem.getId() or DownloadInfo.getDownloadGuid()
to return null.

Bug: 889369
Change-Id: I73fc66e16d2fa3b6e7a0e8d02dff9655f259f7d1
Reviewed-on: https://chromium-review.googlesource.com/1249835Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594863}

A recent improvement to the APK wrapper scripts queries the target APK
for its native ABI, so it can ignore devices that don't match.
Unfortunately this broke bundle installation, since we can't yet run the
same ABI query on a bundle.

BUG=887964

Change-Id: I52c18a39ebb5b2714731826e2797e1fc18ab0a0e
Reviewed-on: https://chromium-review.googlesource.com/1249901Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Commit-Queue: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594862}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b15eae0a955c..1814174dbc2e


Created with:
  gclient setdep -r src-internal@1814174dbc2e

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: Id5243bda5bfbfebd2001d000e198135a7123243f
Reviewed-on: https://chromium-review.googlesource.com/1249512Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#594861}

CurrentBigUserView() could be null if
- there are no users on the device yet
- enterprise policy disables showing the logged in users

Bug: 889580
Change-Id: If7eea97b84697dfc2ced137741489a41f7520993
Reviewed-on: https://chromium-review.googlesource.com/1249815Reviewed-by: Quan Nguyen <qnnguyen@chromium.org>
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594860}

https://skia.googlesource.com/skia.git/+log/dbdd151b1cb9..656cefe65d62


git log dbdd151b1cb9..656cefe65d62 --date=short --no-merges --format='%ad %ae %s'
2018-09-27 dmazzoni@chromium.org Add initial support for generating tagged PDFs.
2018-09-27 halcanary@google.com SkPDF: Fix skia:8397, reduce RAM use, stop copying ClipStacks.
2018-09-27 herb@google.com Move ARGB fallback helper into Painter
2018-09-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skia/third_party/skcms 1c1d5560df11..dfd5b3a4a61f (1 commits)
2018-09-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skia/third_party/skcms 0eb21d4ecadd..1c1d5560df11 (1 commits)
2018-09-27 bsalomon@google.com Call XInitThreads in sk_app startup
2018-09-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 40a6005e7a14..8c5ca8d1a7ea (5 commits)


Created with:
  gclient setdep -r src/third_party/skia@656cefe65d62

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
TBR=bsalomon@chromium.org

Change-Id: I36d5984c7dd08d6394e7906be1ca0ee513133686
Reviewed-on: https://chromium-review.googlesource.com/1249511Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#594859}

Removes the except on HTTPS verbage ahead of the launch of HTTPS Server
Previews.

Bug: 889696
Change-Id: I42aae90651b1924f21cef46fccbf2acf06aa063f
Reviewed-on: https://chromium-review.googlesource.com/1249981Reviewed-by: Doug Arnett <dougarnett@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594858}

Adds the same string as the Infobar would show according to the UI
mocks.

Also cleans up PageInfoController a bit from my last adventure there.

Bug: 888029
Change-Id: Iba1bae14ba05ecd912431463db73ec7a72ebb7f5
Reviewed-on: https://chromium-review.googlesource.com/1246782Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Doug Arnett <dougarnett@chromium.org>
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594857}

This CL is adding the GPU events to the whitelist.

We do not accept any args yet, since some of them may contains PII and
are not yet useful to investigate GPU issues. We will update the
|kGPUAllowedArgs| array when needed. For now, let assume no args.

R=oysteine@chromium.org

Bug: 888580
Change-Id: Ia23ba1c0e2ed6a49328416678062074ffab472a6
Reviewed-on: https://chromium-review.googlesource.com/1249914Reviewed-by: oysteine <oysteine@chromium.org>
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594856}

The spec says the channelCount should be 2 not 1 for an AnalyserNode.

Remove the test expectations too since we pass the tests now.

Bug: 889640, 888870
Change-Id: I814fc31d0e15c371f9ae74dd8e3ce2fb0a906197
Reviewed-on: https://chromium-review.googlesource.com/1247241Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594855}

Bug: 836238
Change-Id: I4714f80e7a0796327bce606f89ce1f889752f39f
Reviewed-on: https://chromium-review.googlesource.com/1249396Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594854}

For Chromecast, Content Shell, and non-monochrome Clank/Webview:

The Crashpad handler is a standalone executable, packaged like a
loadable module and named libcrashpad_handler.so in order to not be
ignored by Android's APK installer.

For Monochrome:

The Crashpad handler is linked into libmonochrome.so. At crash-time
/system/bin/app_process{32,64} is exec-ed, running CrashpadMain.java
which loads libmonochrome.so and runs the native HandlerMain().

This strategy is not used for non-monochrome APKs (i.e. pre-N) because
on L, Android's loader is not yet capable of loading native libraries
from the APK. This is normally performed by the Chromium linker which
can't be used by CrashpadMain.java because /system/bin/app_process
doesn't initialize the process like a normal Android application
(specifically, no ContextImpl has been created, so any calls to e.g.
appContext.getApplicationInfo() will segfault).

Binary-Size: MonochromePublic.apk increases in size by 100 KB.
ChromeModernPublic.apk increases in size by 203KB (587 KB
increase in install size because libcrashpad_handler.so is extracted
from the APK). Possible mitigations for this increase are TODO:

For J, K: We could link the handler directly into libchrome.so and let
that be our handler executable. This would de-dup portions of libbase
that are currently linked into both libchrome.so and
libcrashpad_handler.so.

For L, M: It might be possible to get the chromium linker (or Bionic's
linker on M) to dlopen libchrome.so from the APK for a trampoline
libcrashpad_handler.so to de-dup libbase.

Bug: crashpad:30
Change-Id: If5b3752f26455e5c7aef3278b4bd2076ef1b7b65
Reviewed-on: https://chromium-review.googlesource.com/1150774Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Commit-Queue: Joshua Peraza <jperaza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594853}

Bug: 885274
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Iead2e9e13997d6d12987c4a40e02876d55108523
Reviewed-on: https://chromium-review.googlesource.com/1244596
Commit-Queue: Danyao Wang <danyao@chromium.org>
Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594852}

The feature "use invalid data" for possible type uploads should
always be on, meaning that the client will send up votes regardless
of the validity states. This is because we are uploading the validity
states of each possible type, and we can evaluate the relevance of
invalid data on the server side.

Also, the validity of UNKNOWN types should be set to UNVALIDATED for
the consistency.

Change-Id: Ia7234a128b04b975f6fb1bfd4d4dc131547530a8
Reviewed-on: https://chromium-review.googlesource.com/1249907Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Commit-Queue: Parastoo Geranmayeh <parastoog@google.com>
Cr-Commit-Position: refs/heads/master@{#594851}

BUG=860827

Change-Id: I403f2b4ada07242cc035ebb12ec1d1f6145ac42d
Reviewed-on: https://chromium-review.googlesource.com/1249838Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594850}