- 25 Jun, 2019 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/7c5922e23347..ce76d1e960eb git log 7c5922e23347..ce76d1e960eb --date=short --no-merges --format='%ad %ae %s' 2019-06-25 mikewu@google.com chromeos_config: Only enable vm_suite VM test in kumo board Created with: gclient setdep -r src/third_party/chromite@ce76d1e960eb The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: I5f1c67eb8ac1485e8e53a7838ad254f3b57352c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674965Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#671947}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/304e5101f382..8db999ee35ff git log 304e5101f382..8db999ee35ff --date=short --no-merges --format='%ad %ae %s' 2019-06-25 dberris@chromium.org PinpointScheduler: Add a required index Created with: gclient setdep -r src/third_party/catapult@8db999ee35ff The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:977488 TBR=sadrul@google.com Change-Id: I43ab761f8da54a92be2773233604030bbc2f6fbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674966Reviewed-by:
-
Matt Menke authored
The only two consumers currently just pass in a key created using the default contructor. I'll hook up reasonable values to PreconnectManager in followup CLs. Bug: 966896 Change-Id: Ic4c69dea4a97795e41d6dcd90b85b531eadbbf1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670529 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Shivani Sharma <shivanisha@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#671945}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/81bf941106ba..c0cc2343f646 Created with: gclient setdep -r src-internal@c0cc2343f646 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=tzik@google.com,dbeam@google.com,huanzhong@google.com Change-Id: Ia76a86a2af0a065ae91a51fba34aaa73b22135a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674680Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#671944}
-
Daniel McArdle authored
Currently, when a request is canceled, any pending client certificate dialogs will stick around until they are dismissed. Because the UI object that owns the dialogs is not directly owned by SSLClientAuthHandler, destructors will not implicitly convey the message that the request has been cancelled. This CL plumbs a callback between SSLClientAuthHandler and UI code, enabling SSLClientAuthHandler to delete orphaned dialogs. Bug: 946742 Change-Id: I09072452f712a8ed443349270e2571ca1c3b71f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1588969Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Sean Topping <seantopping@chromium.org> Reviewed-by:
Dana Fried <dfried@chromium.org> Reviewed-by:
Johannes Henkel <johannes@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Dan McArdle <dmcardle@chromium.org> Cr-Commit-Position: refs/heads/master@{#671943}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/2cfafaf4aa25..8812b932c914 git log 2cfafaf4aa25..8812b932c914 --date=short --no-merges --format='%ad %ae %s' 2019-06-25 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@8812b932c914 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: If1ccbf62b91943736c3d5b04bfb1d676c42441a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674772Reviewed-by:
-
Liquan(Max) Gu authored
Currently, we are using flags (is_reporting_lcp_) to stop the largest-text-paint pipeline in TextPaintTimingDetector. However, the flag is hard to maintain and is error-prone. To fix this issue, we introduce a wrapper for the largest-text-paint part of code. Once we stop largest-text-paint, we set the wrapper instance to null. This way, any data structure and functions of this pipeline would no longer be accessible. In this patch, we also remove the timer. The removal is included in this patch because it's part of the largest-text-paint pipeline. Although the removal is a relatively separate part, we suggest including it here because making it two steps would complicate the middle state. The removal of timer has several benefits: 1) can avoid the complicated control logic of timer. 2) can make the metric result more precise, because we move the result update from the 1s-timer callback to the swap-time assignment callback. Bug:977181,977926,977952 Change-Id: I01821517ee9a01c70ad65dd901b0f3d687bbb1de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672113 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#671941}
-
Chinglin Yu authored
This CL adds support of stopping a perf session in PerfOutputCall before the profiler duration elapses. This also changes make PerfOutputCall to move the profiler output in the callback so that the user class doesn't need to hold hold the PerfOuptutCall instance alive when using the profiler output. Bug: 904785 Test: locally build. Change-Id: I7ea63962c234a9c6b55d8948e3b98fa496b3784c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637024 Commit-Queue: Chinglin Yu <chinglinyu@chromium.org> Reviewed-by:
Gabriel Marin <gmx@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#671940}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=benmason@chromium.org Change-Id: I6092eb8d8e581a356d958705758886fc37a2239e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672238Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#671939}
-
Esmael El-Moslimany authored
Replaces 'tap' event with 'click' for gaia-button's. Bug: 967793 Change-Id: Ifee53c66243357b5f2bcb2a17ea40a402f9d483e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658650Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#671938}
-
Koji Ishii authored
This patch adds DCHECKs to check consistency between NGPhysicalFragment and LayoutObject in construction, when read from cache, and when NGPaintFragment is constructed. These DCHECKs should catch when we have old fragments after LayoutObject was changed, such as r671460 (crrev.com/c/1670146). Change-Id: I65cb1d9080ca79d6ce904fd544500ab6d5909207 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669916Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#671937}
-
Liquan(Max) Gu authored
Currently, we dump the trace event on browser shutdown. This posed a challenge for Telemetry because Telemetry cannot retrieve the event after the tracing connection is shutdown. As a replacement, we dump the trace event whenever LCP-handler get updated. This way, Telemetry will see all the history candidates and the invalidation of them. Specifically, we use two events: 1. "NavStartToLargestContentfulPaint::Candidate::AllFrames::UKM" 2. "NavStartToLargestContentfulPaint::Invalidate::AllFrames::UKM" Telemetry needs to sort these events by the trace timestamp. And use the last one as the final result. Note that the LCP firing time is different from the trace timestamp. We store it in: event.args.data.durationInMilliseconds for the candidate event (1). This CL also adds the frame-type to the trace event. The frame-type indicates whether the content is from mainframe or subframe. Bug:967788 Change-Id: If9a75f6ce1f1c93af139557fdb199b096580a774 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1671027Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#671936}
-
Matthew Webb authored
Adds the non-preview authenticatorBioEnrollment command and a related test, which is not at all comprehensive. The functionality should be the same, so the unit test does not need to be comprehensive. This may change in the future. Bug: 974046 Change-Id: Ie0bf030c63ad7633d8ba94a84374e6977da07962 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1665555Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Commit-Queue: Matthew Webb <noviv@google.com> Cr-Commit-Position: refs/heads/master@{#671935}
-
Dominick Ng authored
The WebAPK icon hasher makes a no-CORS fetch request for the primary and badge icons for creating WebAPKs. Before this CL, the request was made without setting a request_initiator on the fetch request. When the requested image is protected by Cross-Origin-Resource-Policy: same-site, the lack of initiator causes the fetch to fail and WebAPK creation fails as a result. This CL fixed the issue by setting the initiator to the origin of the requested start URL for the WebAPK. A test is added to ensure correct behaviour. BUG=977829 Change-Id: I308a21667b42e9f4c46806deda261fbebfeb46a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673671 Commit-Queue: Dominick Ng <dominickn@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#671934}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/50710e758168..d1fb2c5fcaa3 git log 50710e758168..d1fb2c5fcaa3 --date=short --no-merges --format='%ad %ae %s' 2019-06-24 asweintraub@google.com Fix overloaded operators in bigint. 2019-06-24 asweintraub@google.com Fix assignment operator return values in agg. Created with: gclient setdep -r src/third_party/pdfium@d1fb2c5fcaa3 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=pdfium-deps-rolls@chromium.org Change-Id: I6d24bb032c33f8856f012f99b9f709ce0238232f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1671903Reviewed-by:
-
Takashi Sakamoto authored
This reverts commit ee95bc44. Reason for revert: suspect causing unit_tests failure on Linux MSAN Tests: https://ci.chromium.org/p/chromium/builders/ci/Linux%20MSan%20Tests/17649 PageInfoBubbleViewTest.ChangingFlashSettingForSiteIsRemembered PageInfoBubbleViewTest.EnsureCloseCallback PageInfoBubbleViewTest.NotificationPermissionRevokeUkm PageInfoBubbleViewTest.OpenPageInfoBubbleAfterNavigationStart PageInfoBubbleViewTest.SetPermissionInfo PageInfoBubbleViewTest.SetPermissionInfoForUsbGuard PageInfoBubbleViewTest.SetPermissionInfoWithPolicyUsbDevices PageInfoBubbleViewTest.SetPermissionInfoWithUsbDevice PageInfoBubbleViewTest.SetPermissionInfoWithUserAndPolicyUsbDevices PageInfoBubbleViewTest.UpdatingSiteDataRetainsLayout https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8909718923797040064/+/steps/unit_tests/0/logs/Deterministic_failure:_PageInfoBubbleViewTest.ChangingFlashSettingForSiteIsRemembered__status_CRASH_/0 [ RUN ] PageInfoBubbleViewTest.ChangingFlashSettingForSiteIsRemembered ==9056==WARNING: MemorySanitizer: use-of-uninitialized-value #0 0x561baaab15ec in PageInfoUI::GetSecurityDescription(PageInfoUI::IdentityInfo const&) const ./../../chrome/browser/ui/page_info/page_info_ui.cc:250:3 #1 0x561bab6a1548 in PageInfoBubbleView::SetIdentityInfo(PageInfoUI::IdentityInfo const&) ./../../chrome/browser/ui/views/page_info/page_info_bubble_view.cc:802:7 #2 0x561baaaab3bb in PageInfo::PresentSiteIdentity() ./../../chrome/browser/ui/page_info/page_info.cc:969:8 #3 0x561baaaa0a21 in PageInfo::PageInfo(PageInfoUI*, Profile*, TabSpecificContentSettings*, content::WebContents*, GURL const&, security_state::SecurityLevel, security_state::VisibleSecurityState const&) ./../../chrome/browser/ui/page_info/page_info.cc:344:3 #4 0x561bab69b6dd in PageInfoBubbleView::PageInfoBubbleView(views::View*, gfx::Rect const&, aura::Window*, Profile*, content::WebContents*, GURL const&, security_state::SecurityLevel, security_state::VisibleSecurityState const&, base::OnceCallback<void (views::Widget::ClosedReason, bool)>) ./../../chrome/browser/ui/views/page_info/page_info_bubble_view.cc:576:24 ... Original change's description: > PageInfo: decouple safe browsing and TLS statii. > > Previously, the Page Info bubble maintained a single variable to > identify all reasons that a page might have a non-standard status. This > lead to the display logic making assumptions about, for instance, the > validity of a certificate when the page was flagged by Safe Browsing. > > This CL separates out the Safe Browsing status from the site identity > status so that the page info bubble can inform the user that the site's > certificate is invalid, even if it's also flagged by Safe Browsing. > > Bug: 869925 > Change-Id: I34107225b4206c8f32771ccd75e9367668d0a72b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662537 > Reviewed-by: Mustafa Emre Acer <meacer@chromium.org> > Reviewed-by: Bret Sepulveda <bsep@chromium.org> > Auto-Submit: Joe DeBlasio <jdeblasio@chromium.org> > Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> > Cr-Commit-Position: refs/heads/master@{#671847} TBR=meacer@chromium.org,bsep@chromium.org,jdeblasio@chromium.org Change-Id: I8be652952e7276bcc9266124693352e467159cc4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 869925 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673985Reviewed-by:
Takashi Sakamoto <tasak@google.com> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#671932}
-
Julie Jeongeun Kim authored
This CL is a part of moving access token management to OAuth2AccessTokenManager. It moves InvalidateAccessToken() to OAuth2AccessTokenManager and cleans up InvalidateAccessTokenForClient() since it's not used. Bug: 967598 Change-Id: I9fff699899249eae1d65d2ebfe68778fe21ead75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670141 Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#671931}
-
Michael Crouse authored
This change requires host to have a minimum engagement score to be considered a top host returned by the TopHostProvider. This prevents hosts that the user is unlikely to navigate to from having hints fetched for them. It also adds an extra layer of protection from disclosing a user's history after enabling DataSaver and HintsFetcher for the first time. Bug: 932707 Change-Id: I38eec3a71c23b5fcbb4aa712aff5e337637f52d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673859 Commit-Queue: Michael Crouse <mcrouse@chromium.org> Auto-Submit: Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#671930}
-
Yutaka Hirano authored
Bug: 946700 Change-Id: I97ba94980823b27b40f4cf924835d2b8247e7d0e No-Try: True Tbr: caseq@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675004Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#671929}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/f2482cb05590..7c5922e23347 git log f2482cb05590..7c5922e23347 --date=short --no-merges --format='%ad %ae %s' 2019-06-25 eashanbhatt@google.com vm_unittest: Add VM Image Path unit tests. Created with: gclient setdep -r src/third_party/chromite@7c5922e23347 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: Ic27b0b370a803273115632f05782cb3efbfc4ca5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674601Reviewed-by:
-
Peter Kasting authored
This requires adding the missing 1x resource (2x was already present). Bug: none Change-Id: I0487f5cecc706e205d90734f6554db82b1c0d5ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674750 Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#671927}
-
Eric Roman authored
The parsing of --net-log-capture-mode had previously been extracted to //net to facilitate sharing between NS (Network Service) and non-NS code paths, however is now exclusively used by NS. Bug: 934009 Change-Id: I5d18354fb5eac727f2aaf61e91785f6e3bcab462 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674635Reviewed-by:
Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Auto-Submit: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#671926}
-
rajendrant authored
Record loading attribute usage of lazy and eager for iframes and img elements. Bug: 883463 Change-Id: Idd7d43efa5f43ef11338083de0fec0d1ae768c03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673603 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by:
-
Dan Beam authored
CFI bots and some Windows/ChromeOS try jobs. R=jbudorick@chromium.org TBR=tapted@chromium.org BUG=978272 Change-Id: I8012213fc915b8e8aef7457d8c25ecd6fab7bd48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674711 Commit-Queue: Dan Beam <dbeam@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#671924}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/754e19056745..81bf941106ba Created with: gclient setdep -r src-internal@81bf941106ba The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome BUG=chromium:891734,chromium:790426 TBR=tzik@google.com,dbeam@google.com,huanzhong@google.com Change-Id: I22d8c4d1ac15dd109ad67963bfec0ec17894dde6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674676Reviewed-by:
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I193733c93814c999f030d09ec788d0e427ecca2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674904Reviewed-by:
-
Hwanseung Lee authored
Use enum class instead of enum for BoxLayout::Orientation enum class is more type safety. Bug: 940736 Change-Id: Ib4a0bdb834fdd47ffd6c02e70cac27e36823a824 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614649Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com> Cr-Commit-Position: refs/heads/master@{#671921}
-
Dan Beam authored
This reverts commit a5646d5a. Reason for revert: Crashes 5 tests on Win 7 Tests x64 (1): https://ci.chromium.org/p/chromium/builders/ci/Win%207%20Tests%20x64%20%281%29/55573 Original change's description: > Remove NOTIFICATION_FULLSCREEN_CHANGED > > Replace with an observer interface on FullscreenController. > > Bug: 268984 > Change-Id: I1af2056e870af56b2f436a3aa8c6a54ed0ff44fb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666148 > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Evan Stade <estade@chromium.org> > Cr-Commit-Position: refs/heads/master@{#671901} TBR=sky@chromium.org,estade@chromium.org Change-Id: I793c04325fa1e4e9e6fb07256e01ff81c22e3b0d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 268984 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672139Reviewed-by:
Dan Beam <dbeam@chromium.org> Commit-Queue: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#671920}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/73c4a7c3567a..2cfafaf4aa25 git log 73c4a7c3567a..2cfafaf4aa25 --date=short --no-merges --format='%ad %ae %s' 2019-06-25 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-06-24 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@2cfafaf4aa25 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Idc017cfecb7ec6fe4e3acec91f1aa3570dad5b9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674675Reviewed-by:
-
John Lee authored
This CL also removes unused #promo-description CSS. Bug: 973674 Change-Id: I983058cc19a8276fb36a2c124cfee5c7eca96bd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674593Reviewed-by:
Esmael El-Moslimany <aee@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#671918}
-
Kevin Strohbehn authored
Bug: 931909 Change-Id: I8353dbd4c78949c74ab2c33a1f6ae753a0100e47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674499Reviewed-by:
-
Istiaque Ahmed authored
This CL exposes ServiceWorkerContextProxy to ContentRendererClient's DidInitializeServiceWorkerContextOnWorkerThread, so that extensions/ can query the state of AllowWindowInteraction() through it via ServiceWorkerGlobalScope. This allows Service Worker based extensions to call extension APIs that require user interaction to be present, in onnotificationclick handler. This CL adds test for this feature. Bug: 977629 Change-Id: I28df9ee0724dbc76f5525d9111416e9180ad3d5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673253 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#671916}
-
Cliff Smolinsky authored
The native Windows tooltip doesn't support dark theme and it has some accessibility issues with the text scaling settings. By using the aura tooltips we can solve both of these problems together. This change completely enables Windows to use TooltipAura, behind a Feature flag. Included in this change is an increase to the maximum width of tooltips from 400px to 800px in order to better match the native tooltip and avoid some of the early truncation issues described by https://bugs.chromium.org/p/chromium/issues/detail?id=292738 (which ChromeOS currently suffers from). On Windows transparency will not be allowed because it doesn't meet accessibility requirements. This change also adds a border when transparency is not allowed. Bug: 971686 Change-Id: I8c644d4e73510fcead9021c930924b09af4c80a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1650466Reviewed-by:
-
Evan Stade authored
Two consumers: - PluginStatusPrefSetter - was unused, so it's deleted. - ChromePluginServiceFilter - the action taken when receiving the notification can be moved to the notification's source, i.e. PluginPrefs. Note that the enable status can only change for the pdf viewer plugin, so it wasn't a very aptly-named notification (at this point in history). Bug: 268984 Change-Id: I1aebd7d90f8e70c3031d7e7911bb1388c8e88c8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1671849Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Auto-Submit: Evan Stade <estade@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#671914}
-
Luciano Pacheco authored
Change the background color when the file is selected and is the lead (currently focused) to be blue, instead of gray. Claire approves! :-) Bug: 968478 Change-Id: I5dc33104a7fe37abaddb5817c58f83a1c796f383 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672612 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#671913}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/dd3ef1e78819..eb66fe4e15e8 git log dd3ef1e78819..eb66fe4e15e8 --date=short --no-merges --format='%ad %ae %s' 2019-06-24 tiborg@chromium.org Move uses-sdk to GN. Created with: gclient setdep -r src/third_party/angle@eb66fe4e15e8 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:891996 TBR=syoussefi@google.com Change-Id: I4c1f10da53d9d95150a9f1e520bcfb3601796951 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674625Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d32b1ad1..d3a6eb96 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I54a7278b9b884c0d1ae84e06efe82cacf5dc23f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672801Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#671911}
-
Hao Zhang authored
4 digit specialization of cc-exp, use that specialization. Change-Id: I910a30d9bfd617cd22959e1c1eeb9a3b0f702fae Bug: 971402 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1410084 Commit-Queue: Hao Zhang <hozhng@google.com> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Reviewed-by:
Eric Noyau <noyau@chromium.org> Cr-Commit-Position: refs/heads/master@{#671910}
-
Dan Beam authored
TBR=xiaohuic@chromium.org BUG=978267 Change-Id: Iad449bb6308db01ef8bf3e38a1c6364ae0f44732 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674749Reviewed-by:
-
Vlad Tsyrklevich authored
Use WaitForMultiprocessTestChildExit() instead of base::Process::WaitForExitWithTimeout() to wait for multiprocess test child processes to complete. It's identical to WaitForExitWithTimeout() on macOS/Windows/Linux but also works on Android. (Android tests don't fork so they use a special process monitoring mechanism.) Bug: 973167 Change-Id: I3c3f10a155d4ea9058404ae7474cfacdcf2ed402 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1668335 Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Commit-Queue: Vitaly Buka <vitalybuka@chromium.org> Reviewed-by:
Vitaly Buka <vitalybuka@chromium.org> Cr-Commit-Position: refs/heads/master@{#671908}
-
