GitLab

BUG=370412
TEST=
1. open virtual keyboard in google.com
2. virtual keyboard window should have the default shadow

Review URL: https://codereview.chromium.org/280273002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269915 0039d316-1c4b-4281-b951-d872f2087c98

Make command buffer generator infer GL array element type from the GL
prototype. Before, it was written in the function info specification.

This would simplify the usage if PUT functions that have two pointer
types would ever be supported.

BUG=344330

Review URL: https://codereview.chromium.org/272953002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269914 0039d316-1c4b-4281-b951-d872f2087c98

So that https://codereview.chromium.org/284663003 can be CQ'd.

TBR=iannucci@chromium.org
BUG=372451

Review URL: https://codereview.chromium.org/281673002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269913 0039d316-1c4b-4281-b951-d872f2087c98

This provides non-const didLoadingProgress() implementations for WebMediaPlayer subclasses in Chromium so that the interface can switch to being non-const. It also removes the const specifier from DidLoadingProgress() implementations (Pipeline and DemuxerHost) and the mutable specifier for their associated properties.

This is the first of three changes; the second is
https://codereview.chromium.org/272223004.

BUG=360251

Review URL: https://codereview.chromium.org/275303002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269910 0039d316-1c4b-4281-b951-d872f2087c98

TBR=sky@chromium.org
BUG=372585

Review URL: https://codereview.chromium.org/276563003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269909 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium:369679
BUG=chromium:368815
TEST=Tested manually on daisy

Review URL: https://codereview.chromium.org/278433005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269908 0039d316-1c4b-4281-b951-d872f2087c98

Also implements TestURLFetcher::SaveResponseToTemporaryFile(),
and explicitly allows ScopedIO in TestURLFetcher, as it doesn't support
asynchronous IO by design.

Note to tree sheriffs: this CL can break tests using FakeURLFetcherFactory.

BUG=366614
TEST=none

Review URL: https://codereview.chromium.org/253833006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269907 0039d316-1c4b-4281-b951-d872f2087c98

For now we disable most baseline policy unittests under *SAN, until
we make the policy work with them.

BUG=372445
TBR=earthdok

Review URL: https://codereview.chromium.org/283643002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269905 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true

Review URL: https://codereview.chromium.org/275223003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269904 0039d316-1c4b-4281-b951-d872f2087c98

The case of a non-existing image file should be treated as an ordinary error case, just as a garbled JPEG image would be.

Update comment for UserImageLoader::Start() accordingly.

(The current behaviour breaks out/Debug/chrome (no parameters) compiled with chromeos=1.)

BUG=371295

Review URL: https://codereview.chromium.org/264483004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269903 0039d316-1c4b-4281-b951-d872f2087c98

Major regression in chrome-si/initializers. Reverting for now to fix.

> linux_aura: Compile ash into chrome.
> 
> Running chrome with the "--open-ash" parameter will create an ash
> desktop window. Ash on Linux has some problems, but at least we're now
> compiling the code into the binary.
> 
> TODO: The applist isn't positioned correctly, and some details of the
> system tray aren't correct.
> 
> BUG=300084, 303862
> R=sky@chromium.org
> 
> Review URL: https://codereview.chromium.org/25108005

TBR=erg@chromium.org

Review URL: https://codereview.chromium.org/276773004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269902 0039d316-1c4b-4281-b951-d872f2087c98

In order to avoid passing around ownership of SQS, expose default ctor,
and remove all function that returns scoped_ptr of SQS, meaning Create
and Copy function. Alternative of Copy function is CopyFrom function
that is called on raw pointer.

This follows 265823015 and 271703003.

BUG=344962
TEST=cc_unittests

Review URL: https://codereview.chromium.org/271683004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269901 0039d316-1c4b-4281-b951-d872f2087c98

Without this, the net-internals prerendering tests fail when a cancel
that creates a PrerenderContents is replaced with one that does not.

BUG=372471

Review URL: https://codereview.chromium.org/286433002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269900 0039d316-1c4b-4281-b951-d872f2087c98

Uses VariationsSeedSimulator to simulate incoming
variation seeds and log the results of simulation
in histograms, as well as the amount of time taken.

Makes VariationsService take a MetricsStateManager
parameter for creating the entropy provider.

BUG=281474,315807

Review URL: https://codereview.chromium.org/238443008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269899 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Make ContentViewRenderView::CompositeToBitmap not CompositeAndReadback. (https://codereview.chromium.org/270933002/)

Reason for revert:
This is possibly breaking android telemetry pixel tests as per https://code.google.com/p/chromium/issues/detail?id=372562

Original issue's description:
> Make ContentViewRenderView::CompositeToBitmap not CompositeAndReadback.
> 
> The CompositeAndReadback is going away, and this method is thought to
> be unused. Make the method just fail and return false.
> 
> R=aelias, tedchoc@chromium.org
> BUG=371592
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269448

TBR=aelias@chromium.org,tedchoc@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=371592

Review URL: https://codereview.chromium.org/286513002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269894 0039d316-1c4b-4281-b951-d872f2087c98

Aura uses the locations of some ending events which weren't
being assigned locations in the TDGF. To use the unified GR
on Aura, we need these locations to be assigned correctly.

We use the location of the first pointer down when the gesture was
created a the location of the gestures created by the TDGF.

BUG=371875
TEST=TouchDispositionGestureFilterTest.*

Review URL: https://codereview.chromium.org/277373002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269893 0039d316-1c4b-4281-b951-d872f2087c98

Running chrome with the "--open-ash" parameter will create an ash
desktop window. Ash on Linux has some problems, but at least we're now
compiling the code into the binary.

TODO: The applist isn't positioned correctly, and some details of the
system tray aren't correct.

BUG=300084, 303862
R=sky@chromium.org

Review URL: https://codereview.chromium.org/25108005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269892 0039d316-1c4b-4281-b951-d872f2087c98

After https://codereview.chromium.org/252643004, SpellingServiceClient doesn't
need the command line switch related headers. So we can remove these.

Review URL: https://codereview.chromium.org/275373004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269891 0039d316-1c4b-4281-b951-d872f2087c98

BUG=372486
NOTRY=true
NOTREECHECKS=true

Review URL: https://codereview.chromium.org/287503003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269890 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true
BUG=none

Review URL: https://codereview.chromium.org/283603002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269888 0039d316-1c4b-4281-b951-d872f2087c98

This change lays the groundwork for fetching STHs from CT logs and
using them for proof inclusion validation.
This change contains:
* A SignedTreeHead struct representing a signed tree head.
* CTLogResponseParser - a class to parse the STH returned by the log in
  JSON format and fill in SignedTreeHead.
* An encoding function to create the binary blob over which the signature
  in the STH applies.
* Addition to the CTLogVerifier class to validate and store provided STHs,
  which uses the encoding function mentioned above.

BUG=

Review URL: https://codereview.chromium.org/230713002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269887 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
R=davidben@chromium.org

Review URL: https://codereview.chromium.org/271543005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269886 0039d316-1c4b-4281-b951-d872f2087c98

This test is currently broken, as it doesn't really reset the initial
conditions each run.

NOTE TO PERF SHERIFFS
---------------------

This is very likely to regress all of the
tile_manager_raster_tile_iterator tests. This is expected, as the test
currently doesn't do anything useful. This is a correctness fix for
that test.

R=reveman, enne

Review URL: https://codereview.chromium.org/283463003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269885 0039d316-1c4b-4281-b951-d872f2087c98

Change was introduced in https://codereview.chromium.org/235933004/

BUG=366175
R=ananta,cpu

Review URL: https://codereview.chromium.org/274793002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269884 0039d316-1c4b-4281-b951-d872f2087c98

This is another attempt to merge the R*Tree bounding boxes CL, after the first
one got kicked back by ASAN/LSAN bots. The leak has been repaired.

BUG=353867

Review URL: https://codereview.chromium.org/275183002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269883 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%284%29/builds/26267/steps/browser_tests/logs/stdio

BUG=372564
TBR=kaznacheev

Review URL: https://codereview.chromium.org/280743002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269882 0039d316-1c4b-4281-b951-d872f2087c98

This adds a build step after generated_resources.h is generated. This step
parses generated_resources.h, extracting all the IDS_* names, index pairs and
produces a mapping from a hash of each name to its index.

This is the first step to implement a mechanism to allow us to override UI
strings with server provided strings from the variations_service.

Design doc for this feature: https://docs.google.com/a/google.com/document/d/1UCQCZzF0Ox9dyD3R66_Fn1RYfckF9BTVjM0o5u4YaWg/edit?usp=sharing

BUG=370033

Review URL: https://codereview.chromium.org/246123007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269880 0039d316-1c4b-4281-b951-d872f2087c98

This broke again - http://build.chromium.org/p/chromium.mac/buildstatus?builder=Mac%2010.7%20Tests%20%28dbg%29%281%29&number=23472

> Only commit cookie changes in prerenders after a prerender is shown
> Will create a PrerenderCookieStore for each prerender, retaining all cookie
> operations of a prerender until the prerender is shown to the user.
> Forces prerenders to be in a new render process by themselves for this to work.
> BUG=371003
> 
> This is a resubmission of https://codereview.chromium.org/233353003, which had
> to be reverted due to build breaks. See LGTM's there.
> 
> Review URL: https://codereview.chromium.org/278403003

TBR=tburkard@chromium.org

Review URL: https://codereview.chromium.org/280383002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269879 0039d316-1c4b-4281-b951-d872f2087c98

Likely cause to ASAN issues in http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20Tests%20%28sandboxed%29/builds/1616/steps/browser_tests/logs/stdio

> Pepper: Fix crash on allocation failure.
> 
> GetPNaClResourceInfo() currently performs a 1 megabyte allocation. Though any
> memory allocation can fail, this one is more likely due to its size.
> 
> This change mitigates this problem in two ways. If memory allocation fails, we
> report an error and return early instead of using memory.
> 
> Additionally, this change checks the size of the file before performing a
> memory allocation. This should lead to smaller allocations and more successful
> plugin loads.
> 
> BUG=370965
> 
> Review URL: https://codereview.chromium.org/274673002

TBR=teravest@chromium.org

Review URL: https://codereview.chromium.org/279323002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269876 0039d316-1c4b-4281-b951-d872f2087c98

These codes were modifying command parameters along with command path, which resulted in
page filtering failures for telemetry blink tests.

BUG=371215
NOTRY=true

Review URL: https://codereview.chromium.org/280343002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269875 0039d316-1c4b-4281-b951-d872f2087c98

I really wanted this in some debugging I was doing.

R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/280273004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269873 0039d316-1c4b-4281-b951-d872f2087c98

BUG=372423
R=noamsml@chromium.org

Review URL: https://codereview.chromium.org/286483002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269872 0039d316-1c4b-4281-b951-d872f2087c98

BUG=359598

Review URL: https://codereview.chromium.org/261403003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269871 0039d316-1c4b-4281-b951-d872f2087c98

This only works on linux, so the script still errors out on non-linux platforms.

R=sbc@chromium.org
BUG=369189

Review URL: https://codereview.chromium.org/262753005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269869 0039d316-1c4b-4281-b951-d872f2087c98

CapturePixels has a special branch for printing code, but
CapturePixelsAsync before this patch doesn't.  Because WebKitTestRunner
calls the async version in compositing mode, printing tests fail if it
doesn't also handle this case.

The stateful canvas() accessor that the paintPagesWithBoundaries
modifies is a bit of a code smell that previously existed, but it can't
be easily cleaned up until the CapturePixels function gets removed.

BUG=361729

Review URL: https://codereview.chromium.org/274253002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269867 0039d316-1c4b-4281-b951-d872f2087c98

They are a better option since server-side wait is supported by default.
It also avoids the broken EGL_KHR_fence_sync implementation
on Qualcomm drivers.

BUG=371530,278606,341867
R=piman@chromium.org, reveman@chromium.org

Review URL: https://codereview.chromium.org/285523002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269863 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true

Review URL: https://codereview.chromium.org/284603002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269862 0039d316-1c4b-4281-b951-d872f2087c98

TBR=bruening@chromium.org
BUG=NONE

Review URL: https://codereview.chromium.org/274373004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269859 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269858 0039d316-1c4b-4281-b951-d872f2087c98

BUG=372143

Review URL: https://codereview.chromium.org/282573002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269857 0039d316-1c4b-4281-b951-d872f2087c98