- 14 May, 2019 40 commits
-
-
Devlin Cronin authored
Opaque origins (such as about:blank and data: URLs) inherit the security and privileges of their creator origins, which are tracked in precursor tuples. ScriptContext::GetEffectiveDocumentURL() attempts to determine the precursor origin of an opaque URL today by traversing the creation chain and looking for the first non-about:blank opener or parent. However, this is not always strictly correct for all opaque origins; for instance, the precursor tuple of a data: frame may not be that of its immediate parent in the case of nested iframes. Update ScriptContext::GetEffectiveDocumentURL() to use Origin::GetTupleOrPrecursorTupleIfOpaque(), which correctly tracks this. Note that we still have to do the opener/parent traversal case because content script matching needs to have the full URL (including path), and not just the scheme, host, and port tuple. To balance these, we simply return the document URL (which is potentially opaque) in the case of a mismatch between opener/parent traversal and the precursor tuple. This should be an exceptionally rare case in practice. Updating this method to use the precursor tuple is a prerequisite for adding support for data:-URL content script injection. Bug: 55084 Change-Id: I8f7d17b999f909cc32091b8fff06bd53a2370db7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601663 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#659599}
-
dpapad authored
No longer used anywhere and not needed. Bug: 961063 Change-Id: I699773db478aac13495a63166edbbe774f3115f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1607128Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#659598}
-
Avi Drissman authored
It is redundant to the one that Chromium provides. BUG=960209 Change-Id: I5d9133311f19196b3cbe4d59376300defe5451c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611910 Auto-Submit: Avi Drissman <avi@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#659597}
-
Will Harris authored
https://helpx.adobe.com/security/products/flash-player/apsb19-26.html BUG=412078 TBR=jschuh@chromium.org Change-Id: Iba1a2b628b7fb796788691693c4ca94cf9651af4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611648Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#659596}
-
Theresa authored
A previous refactor switched dismissal of the app menu from ChromeActivity#onConfigurationChanged to a ComponentCallback inside of AppMenuHandler. The ComponentCallback does not get notified when entering/existing multi-window causing the app menu to no longer get dismissed in that scenario. Introduce a new ConfigurationChangedObserver, registered through the ActivityLifecycleDispatcher, and use that to dismiss the app menu in AppMenuHandler instead. BUG=962416, 956260 Change-Id: I96e5c5b3a369ece2ad235b4dd4eeabba2050be61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610587 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#659595}
-
Matt Menke authored
The removed code CHECKed if NetLogWithSource or socket pool request objects had been deleted. While the issues were never resolved, they're also not under active investigation, and the CHECKs did not prove useful, and we don't seem to seeing them in crashes at the moment. Bug: 467797, 652868 Change-Id: I07ae2e12f5e940a5cb8f3b23440f23a12df6680e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612017 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#659594}
-
Vladimir Levin authored
This patch makes it so size containment takes priority over display locked size. This makes it so that contain: size still treats the element as having no children, if even that child is indcued by a display lock size. R=ikilpatrick@chromium.org, cbiesinger@chromium.org Bug: 961297 Change-Id: Ia134c5522e0a1dde504d6866298c1543bb3bd47d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611514 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#659593}
-
Tim Volodine authored
After [1] landed the |method| and |headers| parameters are not needed anymore in the HandleExternalProtocol implementation. Also update all relevant sub-classes and method invocations. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1318976 BUG=841556,963008 Change-Id: Id43fe55c8a613cf0648013102675babcabbfb18f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609843 Commit-Queue: Tim Volodine <timvolodine@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#659592}
-
Tommy Steimel authored
This CL adds a |SetNeedsLayout()| call in PictureInPictureInterstitial to force the interstitial to layout after we receive a sizing change. This fixes an issue where the video size would change but the pip interstitial would be stuck at the previous video size. Bug: 960995 Change-Id: Ib4f18706b5f923a4f2c5bd34c70c95b02bcd2ade Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606246Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#659591}
-
Xianzhu Wang authored
The original code caused a side-effect of local rebaselining that new baselines would be created under flag-specific/disable-blink-features=LayoutNG directory instead of the default baseline directory. Now move the LayoutNG disabling code into Port.additional_driver_flags() to avoid the side-effect. Bug: 961437 Change-Id: I18c6c429e492c0ced59cef2e0dda41597a4ef9c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611105Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#659590}
-
Sylvain Defresne authored
The documentation on base::Callback<...> (src/docs/callback.md) recommends against using base::Passed(...) with base::BindOnce. > Avoid using `base::Passed()` with `base::BindOnce()`, as `std::move()` > does the same thing and is more familiar. This CL was uploaded by git cl split. Bug: none Change-Id: I871ad49a3e38a3a46f9b2462b56da3165032ffcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611887 Commit-Queue: Nick Harper <nharper@chromium.org> Reviewed-by:
Nick Harper <nharper@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#659589}
-
Nate Chapin authored
We now check a target name and select the correct frame before calling into FrameLoader, so there's no reason to store it on FrameLoadRequest. Change-Id: I4e48b15184d740b71fed242d0d1f8327f2325123 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610570Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#659588}
-
Patrick Monette authored
This is a reland of 391dff3d Original change's description: > Create source sets for tests in chrome/browser/conflicts > > This solves a filename collision that happens when moving all the files > in chrome/browser/conflicts to chrome/browser/win/conflicts because > module_info_win_unittest.cc becomes module_info_unittest.cc, and this > file already exists at > chrome/browser/install_verification/win/module_info_unittest.cc > > Change-Id: Id269f582259ac8e53a8a5aa64a61f4232ad732ab > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1593894 > Commit-Queue: Patrick Monette <pmonette@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#659186} Change-Id: I5428f2a79b65b5dd25aed85f467b4772fbaec0b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610593Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#659587}
-
Maksym Onufriienko authored
Use [ChromeEarlGrey setContentSettingsBlockPopups] instead of chrome_test_util::SetContentSettingsBlockPopups(..). This is part of EG1 to EG2 migration, which involves moving EarlGrey code from app-side helpers into test code. For GREYAsserts, the policy is to take assert- containing-helpers, modify them to return NSError* with localizedDescription containing the assert failure (in the event of a failure), and then assert on the result of the helper on the test side. Bug: 922813 Change-Id: Iba1f291af45c2676e0d04158542c4752716cf4bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600635 Commit-Queue: Maksym Onufriienko <monufriienko@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#659586}
-
Tanmoy Mollik authored
This cl is part of the effort to introduce strongly typed CoreAccountId instead of std::string in CoreAccountInfo to stop confusion among gaia_id, email and account_id. Bug: 959157 Change-Id: I78c1c77b9a5634d03154cfc4b8a95e517aa73620 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602647 Commit-Queue: Tanmoy Mollik <triploblastic@google.com> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
Jun Mukai authored
Instead, this CL exposes the existing ShellTestApi as ash/public/cpp/test/shell_test_api.h. Bug: 958216 Test: trybot Change-Id: I12aaa0aeccc13dbf65dbf90cdd0671d8276eae20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610573 Commit-Queue: Jun Mukai <mukai@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
-
Sylvain Defresne authored
The documentation on base::Callback<...> (src/docs/callback.md) recommends against using base::Passed(...) with base::BindOnce. > Avoid using `base::Passed()` with `base::BindOnce()`, as `std::move()` > does the same thing and is more familiar. This CL was uploaded by git cl split. Bug: none Change-Id: I0795227dcd8c9c95a9ae99324b7f6782fa0cb63e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611880 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
-
Sylvain Defresne authored
The documentation on base::Callback<...> (src/docs/callback.md) recommends against using base::Passed(...) with base::BindOnce. > Avoid using `base::Passed()` with `base::BindOnce()`, as `std::move()` > does the same thing and is more familiar. This CL was uploaded by git cl split. Bug: none Change-Id: I3d67bad8fd17130ffa750475a65a8cb25afdaa68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611884 Commit-Queue: Tommi <tommi@chromium.org> Reviewed-by:
Tommi <tommi@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#659582}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/e935dac9ef8a..f815e6fe51af git log e935dac9ef8a..f815e6fe51af --date=short --no-merges --format='%ad %ae %s' 2019-05-14 stevenperron@google.com Update CHANGES Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@f815e6fe51af The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=radial-bots+chrome-roll@google.com,syoussefi@google.com Change-Id: Ic109c1f3bdc3a04244917a4f239cc4a7e7333b72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611857Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#659581}
-
Elly Fong-Jones authored
This flag doesn't do much on Mac right now, since the old content fullscreen implementation was lost with the Cocoa browser window. Bug: None Change-Id: I9e263cc4546765b60ab8edaa28cbea3b67b95292 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611897 Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Sidney San Martín <sdy@chromium.org> Reviewed-by:
Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#659580}
-
Koji Ishii authored
It returned nullptr for any objects laid out by LayoutNG. `AXPosition::AtStartOfLine()` relies on this, and that it fails to return the correct value in LayoutNG. This patch fixes following content_browsertests with LayoutNG: AccessibilityAuraLinuxBrowserTest.TestParagraphTextAtOffsetWithBoundaryLine AccessibilityWinBrowserTest.TestParagraphTextAtOffsetWithBoundaryLine Change-Id: I409682232a29f84cda7e2d547ffd6a264357b3d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1608867Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#659579}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/13e06be378d8..9d5d210a420f git log 13e06be378d8..9d5d210a420f --date=short --no-merges --format='%ad %ae %s' 2019-05-14 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@9d5d210a420f The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: Id3d0d60b026959f757c9d6d7b369706be838b998 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611646Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/491b47da442e..d56a905e68a2 Created with: gclient setdep -r src-internal@d56a905e68a2 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=fergal@google.com,avi@google.com,btolsch@google.com,andypaicu@google.com Change-Id: Icb9d48ec0a0617c75f2a00b4ef36408004c84616 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611642Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#659577}
-
Tim Song authored
Currently, the message center closes apbruptly after the last notification slides out. It should instead gracefully animate being hidden. Video: https://screencast.googleplex.com/cast/NTQzNTM4NTg3MjEyMTg1Nnw2NmNlZThiNi1lZA TEST=manually verified, updated unit test BUG=958603 Change-Id: If1c9e6ced1670bc208af281d42f687af3084a488 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610651Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#659576}
-
Maksim Sisov authored
After https://crrev.com/c/1570014, Chromium started to crash immediately because of null accelerated widget provided to the WaylandBufferManager and hitting data validation error when --enable-native-gpu-memory-buffer with the --enable-gpu-rasterization passed. The problem was that the raster buffer provided can create a staging buffer for rasterization, which is not tight to any of the existing widgets. Thus, it seems like it just passes a null widget [1][2]. But, when the GbmPixmapWayland was created and the dmabuf handle was passed to the WaylandBufferManager to import a wl_buffer, it crashed on the data validation, because the widget was null. Thus, when a null widget is passed, just create a native pixmap and do not call the WaylandBufferManager with a request to import a wl_buffer as long as they can also be used as staging buffers and not meant for attaching to Wayland surfaces. [1] https://cs.chromium.org/chromium/src/cc/raster/one_copy_raster_buffer_provider.cc?type=cs&g=0&l=296 [2] https://cs.chromium.org/chromium/src/cc/raster/zero_copy_raster_buffer_provider.cc?type=cs&g=0&l=125 Bug: 962466 Change-Id: Ied6fd6d3e29fdd21939c8b159682537f9239ab84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609781Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#659575}
-
Becky Zhou authored
Bug: 957262 Change-Id: I37d425113c55ad479becd15f3734bee4ed305346 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610208Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#659574}
-
Jamie Walch authored
Change-Id: I1a12c5d90da11d43774a1306fa2459b30685badb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609596 Auto-Submit: Jamie Walch <jamiewalch@chromium.org> Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org> Cr-Commit-Position: refs/heads/master@{#659573}
-
Sylvain Defresne authored
The documentation on base::Callback<...> (src/docs/callback.md) recommends against using base::Passed(...) with base::BindOnce. > Avoid using `base::Passed()` with `base::BindOnce()`, as `std::move()` > does the same thing and is more familiar. This CL was uploaded by git cl split. Bug: none Change-Id: I6500004a85690c1d10ba9b1e1bad9e4912982448 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611879 Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org> Reviewed-by:
-
lonyele authored
chrome.tabs.move doesn't always move the tab to the requested index due to browser constraints. In these cases, an incorrect tab index might be returned to the chrome.tabs.move callback. Fix this and add regression tests. BUG=938881 Change-Id: I010cc390c1088936f6f2e0dedf1445918eaa4e62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517973 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#659571}
-
Fabrice de Gans-Riberi authored
The test is still flaky but the extra bot output has allowed to find a way to reproduce the failure locally. Bug: 760687 Change-Id: I8ee78da2a174937bd6b668f94efb48a8b87290b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611205 Commit-Queue: Ben Kelly <wanderview@chromium.org> Auto-Submit: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#659570}
-
Eugene But authored
ShellEarlGrey allows to keep old style for test helpers, but also allows logging file name and line number during the failures. Bug: None Change-Id: Ide6a1be98f03e29cd0a1bd3802d7e02852da5020 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1597957 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
-
Kyle Milka authored
This line was incorrectly removed in https://crrev.com/c/1610485. Bug: 937570 Change-Id: Ief210fbfce4cb993a75406716eabd2debff2d8a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611302Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Auto-Submit: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#659568}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/8a96493270cb..25eb8e4680ac git log 8a96493270cb..25eb8e4680ac --date=short --no-merges --format='%ad %ae %s' 2019-05-14 raul@tambre.ee Update colorama to 0.4.1 Created with: gclient setdep -r src/third_party/depot_tools@25eb8e4680ac The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:958138,chromium:958321 TBR=agable@chromium.org Change-Id: If2b6e01b1d14d8da7d6a5643480decd4588aad29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611960Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0ee3cd37199b..221ab9bee1be git log 0ee3cd37199b..221ab9bee1be --date=short --no-merges --format='%ad %ae %s' 2019-05-14 fmayer@google.com Consistenly increment heapprofd_invalid_string_id counter. 2019-05-14 fmayer@google.com Merge "Set timestamps in heap_profile_allocation." 2019-05-14 ilkos@google.com Merge "Add stats for invalid task state and fail more gracefully" Created with: gclient setdep -r src/third_party/perfetto@221ab9bee1be The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I103997255d562be6a661453faa794e9019faf671 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611486Reviewed-by:
-
Victor Fei authored
- Implemented firing property changed event for UIA_AriaPropertiesPropertyId and associated unit and browser dump tests for the following AriaProperties: - posinset - pressed - readonly - relevant - Added dump test for testing when multiple aria attributes of one element change at once to test the logic for consolidating UIA_AriaPropertiesPropertyId events introduced in part 1 (CL:1574834) - Modified comments on expected behaviors for various aria-*-changed.html dump test files. - Breakdown of UI Automation AriaProperties need to be implemented: atomic [part 1] busy [part 1] channel [part 2] checked [part 1] disabled [part 3] dropeffect [part 2] expanded [part 1] grabbed [part 2] haspopup [part 1] hidden [not implemented] invalid [part 1] level [part 3] live [part 3] multiline [part 1] multiselectable [part 3] posinset [part 4, this cl] pressed [part 4, this cl] readonly [part 4, this cl] relevant [part 4, this cl] required [part 1] secret [part 2] selected [part 1] setsize [part 5] sort [part 5] tabindex [part 2] valuemax [part 5] valuemin [part 5] valuenow [part 5] valuetext [part 5] - Documentation on UI Automation AriaProperties (see the second table's last column for AriaProperties properties): https://docs.microsoft.com/en-us/windows/desktop/WinAuto/uiauto-ariaspecification - Link to part 1, UIA: Fire UIA_AriaPropertiesPropertyId event: CL:1574834 - Link to part 2, UIA: Fire UIA_AriaPropertiesPropertyId event: CL:1576280 - Link to part 3, UIA: Fire UIA_AriaPropertiesPropertyId event: CL:1589100 - Link to part 4, UIA: Fire UIA_AriaPropertiesPropertyId event: CL:1592640 - Link to part 5, UIA: Fire UIA_AriaPropertiesPropertyId event: CL:1591487 Bug: 928949 Change-Id: Ica97e0a3afc850ad323bee25e6a778a073ac055f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592640Reviewed-by:
Katie Dektar <katie@chromium.org> Reviewed-by:
Ian Prest <iapres@microsoft.com> Commit-Queue: Victor Fei <vicfei@microsoft.com> Cr-Commit-Position: refs/heads/master@{#659565}
-
Mohammad Refaat authored
The main part here is to find a replacement to |didChangeTab|. It appears that, there is only need to change the leading/trailing edge sideSwipe state when didFinishNavigation so i added that. Also for webState, added a forwarder to forwarder to observe webStates through the WebStateList. TEST=Test that side swipe to navigate still works with slimnav off (or to and from NTP with either slimnav state). Also test that swipe to change tabs continues to work. Bug: 911350 Change-Id: I18148c0ed59c0a95b4f3cdfe868d4faa1a8b5ef1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610154 Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#659564}
-
Richard Townsend authored
The existing implementation relied on Intel changing its stack pointer predictably for leaf functions. Bug: 925584, 893460 Change-Id: I7d6c7ef5c77d7f1f9f5131dde262fb9f4ac2cbb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1593362 Commit-Queue: Richard Townsend <richard.townsend@arm.com> Reviewed-by:
Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#659563}
-
Yutaka Hirano authored
We need to attach an origin header when the request's method is neither GET nor HEAD. For requests made by an extension content scripts, we want to attach page's origin, whereas the request's origin is the content script's origin. See https://crbug.com/944704 for details. Revert this CL once 940068 is fixed, as this potentially weakens the security and is also a layering violation. Bug: 944704, 940068, 962870 Change-Id: I477230d72f38f44deccffaf54e873ba148a97004 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610667 Auto-Submit: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#659562}
-
Yoshifumi Inoue authored
Make NGAbstractInlineTextBox::GetText() to handle collapsed white space with soft line break correctly This patch changes |NGAbstractInlineTextBox::NeedsTrailingSpace()| to use |NGOffsetMapping| to check a space character collapsed by soft line wrap comes from same layout object. This patch also introduces unit test in |AbstractInlineTextBox| to cover following failed tests introduced by CL[1]: * DumpAccessibilityTreeTest.AccessibilityInputTextValue/blink <label>Email</label> <span>... => "Email " * DumpAccessibilityTreeTest.AccessibilitySpanLineBreak/blink abc<span> </span> => "abc " Note: This patch passes all DumpAccessibilityTreeTest in content_browsertest locally. [1] http://crrev.com/c/1609003 Make NGAbstractInlineTextBox::GetText() to include a collapsed space at soft line wrap Change-Id: Ib83c3042aedca33bd23280af98e42fc68108e865 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610664 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:Koji Ishii <kojii@chromium.org> Reviewed-by:
-
Caroline Rising authored
Make tab hover cards hit test transparent and add capability for any bubble frame view to be hit test transparent. Bug: 910739 Change-Id: Icbaf84b1aa4d0d2dcbdc45595f17618e5f1bc3c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610469Reviewed-by:
Dana Fried <dfried@chromium.org> Commit-Queue: Caroline Rising <corising@chromium.org> Cr-Commit-Position: refs/heads/master@{#659560}
-
