- 12 Apr, 2018 40 commits
-
-
Blake O'Hare authored
This isn't an ideal UX, although there is currently no defined UX for this and this mostly just lays the foundation of any future implementation. When the actual touch point (where the user's finger is) approaches within 10 pixels of the display edge where there is another display attached, the keyboard will transfer to the new display in a default location. This uses a similar mechanism as the ContainerBehavior change, where the new display is queued on the KeyboardController and the keyboard is then hidden. The HideAnimationFinished handler will then check for any queued display changes, and re-open the keyboard on the new display. Bug: 828701 Change-Id: I7d513791b5bd2de9133f6014469cd03c3fa44899 Reviewed-on: https://chromium-review.googlesource.com/1009507 Commit-Queue: Blake O'Hare <blakeo@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#550126}
-
Dean Liao authored
Currenlty TextureRef::ExportGpuMemoryBufferHandle() only exports the first plane of pixmap, which is wrong for multi-plane case. The fix is to add all planes into the handle to export. BUG=b:73327993 TEST=run video_decode_accelerator_unittest /usr/local/autotest/deps/chrome_test/test_src/out/Release/video_decode_accelerator_unittest \ --test_video_data=/usr/local/autotest/deps/chrome_test/test_src/\ media/test/data/test-25fps.vp8:320:240:250:250:35:150:11 \ --thumbnail_output_dir=/usr/local/autotest/results/default/video_VideoDecodeAccelerator/results \ --ozone-platform=gbm \ --rendering_fps=0 Change-Id: Idc9cddf69a43567d75793c327d6533c6bd7e4140 Reviewed-on: https://chromium-review.googlesource.com/1004074Reviewed-by:
Kuang-che Wu <kcwu@chromium.org> Commit-Queue: Shuo-Peng Liao <deanliao@google.com> Cr-Commit-Position: refs/heads/master@{#550125}
-
Julian Pastarmov authored
The site isolation policies until now could only enable site isolation but being set to disabled was equivalent to not being set at all. With this change their disabled state is going to prevent trials from turning on site isolation per default. The user can still decide to enable site isolation by using the command line flags directly. Additionally fixes the problem of adding the isolated origins flag twice if the browser is restarted programmatically. BUG=827821, 826624 Change-Id: I754e1d8837b5afb0e7a70acbdb2e823733ad9663 Reviewed-on: https://chromium-review.googlesource.com/997737Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#550124}
-
Tetsui Ohkubo authored
According to the UX spec, UnifiedSystemTray bubble corners are rounded and the radius is 20. To support custom corner radius, this CL adds corner_radius attribute to TrayBubbleView::InitParams. Screenshot: http://screen/d8Q63mzrU6A UX spec: http://shortn/_U7QSE9nhSk TEST=manual BUG=811641 Change-Id: Ibf67a61c62fa6db852c040dad91dfd8df2d409e9 Reviewed-on: https://chromium-review.googlesource.com/1003015Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#550123}
-
Dominic Mazzoni authored
This bug could be reproduced just by visiting https://www.lasestrellas.tv/ with accessibility enabled on any platform. The issue was that reparenting caused AXTreeSerializer to call Reset, which deleted the whole client tree and forced re-serializing everything again. However, because some nodes in the tree were not attached to the root at the time Reset was called, |client_id_map_| still had some entries pointing to nodes that were no longer valid. The solution is for Reset() to explicitly clear out |client_id_map_|. Bug: 704045 Change-Id: I0f1d7b24b547953970965fd49ec1a15fbade281e Reviewed-on: https://chromium-review.googlesource.com/1006073 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#550122}
-
Yuta Kitamura authored
Scheduler files are being moved as part of scheduler architecture refactoring. Bug: 826203 Change-Id: Ic5fec44a4e37309bc5432ccafa0de9d2d9d7f3bd Reviewed-on: https://chromium-review.googlesource.com/1006734 Commit-Queue: Yuta Kitamura <yutak@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#550121}
-
Michael Martis authored
Bug: None Change-Id: I765d5e3134721bd801a4dc673216e45ac938d448 Reviewed-on: https://chromium-review.googlesource.com/1009268Reviewed-by:
Jia Meng <jiameng@chromium.org> Commit-Queue: Michael Martis <martis@chromium.org> Cr-Commit-Position: refs/heads/master@{#550120}
-
Koji Ishii authored
This patch rebaselines image and/or text failures due to "Replace Verdana with Arimo GCS font" on Linux (CL:1006221), after manual reviews. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Ic0929ff843087436ddb6fec3a10dfad9911efc9d Reviewed-on: https://chromium-review.googlesource.com/1009449 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#550119}
-
Fergal Daly authored
This rearranges things to make the V0 and V1 codes flows more separate and linear. This also makes it easier to document the V1 code. Change-Id: I66a73582f7bd19c95fc2e65ff938ea5bd56797a9 Reviewed-on: https://chromium-review.googlesource.com/1009242Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#550118}
-
Gayane Petrosyan authored
Bug: 744672 Change-Id: I738348739de70fb0fc4273bbe73a936b98520361 Reviewed-on: https://chromium-review.googlesource.com/1005791 Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#550117}
-
Matthew Cary authored
Removes the ability to set a prerender speculation mode for custom tabs, making the background (hidden) tab the only option. Where appropriate, method names mentioning "prerender" have been changed to generically refer to "speculation". In one case shims for shouldPrerenderOnCellularForSession, etc, have been left in so that downstream code can be changed in a future CL. This is a reland of the CL after a downstream patch that allow removing the constants in SpeculationParams. TBR: lizeb@chromium.org,pasko@chromium.org,bauerb@chromium.org,gayane@chromium.org Bug: 755921,710720, 828968 Change-Id: I9a8002d1f0b8c2513d32469d2d7c4ed787912cb4 Reviewed-on: https://chromium-review.googlesource.com/998100 Commit-Queue: Matthew Cary <mattcary@chromium.org> Reviewed-by:
Matthew Cary <mattcary@chromium.org> Cr-Commit-Position: refs/heads/master@{#550116}
-
arthursonzogni authored
Test disabled: - OfflinePageRequestJobTest.LoadMostRecentlyCreatedOfflinePage - OfflinePageRequestJobTest.LoadOfflinePageForUrlWithFragment The last 48/50 builds on Marshmallow Phone Tester have failed due to these 2 tests. Bug: 830282 Change-Id: Iecb72c24071bf6f0b00990b8039ecc2531cc723b TBR: jianli@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1009823Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#550115}
-
Mirko Bonadei authored
This CL adds Abseil to the Chromium third_party folder. Since it is a new third_party, the following steps have been taken into account: - Add OWNERS: done. - Add README.chromium: done. - Add a LICENSE file and run related checks: done. - Modify Chromium DEPS: Added "-absl" to disable the inclusion of Abseil headers from Chromium code. - Setting up .gitignore: not necessary. - Get a Review: Security review done, Chrome Eng Review done. - Ask for a git mirror: not necessary. In order to avoid to start depend on Abseil, all the build target under //third_party/abseil-cpp are only visible to //third_party/webrtc and the main DEPS file prevents Chromium from #including Abseil headers. Document with the analysis: https://docs.google.com/document/d/1DgS1-A3rzboTLjpf4m1sqkJgWjnY_Ru2dokk1X1vBDU Bug: webrtc:8821 Change-Id: I339680e4b5b03b5bbcad82b0a2934b8bd302f916 Reviewed-on: https://chromium-review.googlesource.com/925605Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Patrik Höglund <phoglund@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#550114}
-
Devlin Cronin authored
Some extension browser tests generate extension objects at runtime. Update these to generate extensions with manifest_version: 2. Where it wasn't already used, also update these to use ExtensionBuilder, which uses manifest v2 by default. Bug: 816679 Bug: 756488 Change-Id: I7142d085ad9569dccd4e9b62e09c7a68da08e360 Reviewed-on: https://chromium-review.googlesource.com/1008633Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#550113}
-
Nicholas Verne authored
This is achieved by setting an extension in it AppLaunchParams. Bug: 813699 Change-Id: Id519c61a8974ba7aa69b982d9c594b71828425c2 Reviewed-on: https://chromium-review.googlesource.com/1009513Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#550112}
-
Sergey Poromov authored
This is part of migration from username check to Gaia id check. Component policies are validated against user policies, so gaia id could be used together with username, resulting in one AccountId. BUG=780792 TEST=Unit tests updated. Change-Id: I1c40587d2d6f193450a2c312609de0eba1822a83 Reviewed-on: https://chromium-review.googlesource.com/1003193 Commit-Queue: Sergey Poromov <poromov@chromium.org> Reviewed-by:
Lutz Justen <ljusten@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#550111}
-
Xiaocheng Hu authored
This patch rewrites the NG implementation of LocalCaretRectOfPosition() on top of NGPaintFragment instead of NGPhysicalFragment. Since paint fragments store parent pointers but physical fragments don't, this patch utilizes parent pointers to stop keeping track of line boxes for each inline fragment, which simplifies the implementation. As a side product, this patch also removes a non-self-contained member function NGPhysicalLineBoxFragment::HasSoftWrapFromPreviousLine(). Bug: 822575 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Idfd2af884a1933daa1d2bac265d51757949cbb14 Reviewed-on: https://chromium-review.googlesource.com/1000952 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#550110}
-
Bence Béky authored
Make HttpNetworkSession::proxy_resolution_service_ member const. Remove obsolete comment: HttpNetworkSessionPeer does not access this member since https://crrev.com/2146553007. Change-Id: I7decf9bec77015e0815af7ec5ac0467f91faf1d1 Reviewed-on: https://chromium-review.googlesource.com/1007156Reviewed-by:
Helen Li <xunjieli@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#550109}
-
Shridhar Sundarraj authored
In Viz, TracingHandler uses DevToolsFrameRecorderForViz for capturing frames. DevToolsFrameRecorderForViz, is the video consumer (it inherits from viz::mojom::FrameSinkVideoConsumer) for the frames produced by FrameSinkVideoCapturerImpl. PageHandler will soon also use FrameSinkVideoCapturerImpl for capturing frames. In this CL, DevToolsFrameRecorderForViz is generalized (by taking frame settings as parameters and adding a callback for when a frame is captured), so that PageHandler can also make use of it. TBR=dgozman@chromium.org Change-Id: Iee557ff5e0b641daa82b1bdf4d9898eeed331ad0 Reviewed-on: https://chromium-review.googlesource.com/980823Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Saman Sami <samans@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Shridhar Sundarraj <sundarrajs@google.com> Cr-Commit-Position: refs/heads/master@{#550108}
-
Marina Ciocea authored
Add function for creating input streams in audio::StreamFactory. This implementation is not used yet, and it uses a nullptr UserInputMonitor for now. UserInputMonitor will be moved to audio service in an upcoming CL. Design: http://drawings/1_ZIKj6lihGKRjq4Mflduitmkn_REqpHFeqVNelBGHHk Bug: 803102 Change-Id: Ie9633adfde67f42665bbc1fa3a2fa12b21171838 Reviewed-on: https://chromium-review.googlesource.com/999418 Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Reviewed-by:
Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#550107}
-
Yoshifumi Inoue authored
This patch changes |NextWordPosition()| to utilize |TextOffsetMapping| to make |NextWordPosition()| to work with LayoutNG. This patch is a part of the patch[1]. [1] http://crrev.com/c/737981 Simplify word granularity handling Bug: 778507, 810579 Change-Id: I7e196b0ee390d68b93f2494333554279d6fbd42d Reviewed-on: https://chromium-review.googlesource.com/1004536 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#550106}
-
Nikunj Bhagat authored
Bug: 822100 Change-Id: Idf29d6ea4648dcdf65620fe406441f2983a0a8f6 Reviewed-on: https://chromium-review.googlesource.com/963843 Commit-Queue: Nik Bhagat <nikunjb@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#550105}
-
Kent Tamura authored
Also, * Rename it to audit_non_blink_usage.py * Add //third_party/blink/tools to remove_stale_pyc_file.py target. Bug: 829697 Change-Id: I6848a5e64b599ce75fa0cea878fe7b17f432417c Reviewed-on: https://chromium-review.googlesource.com/1005644 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#550104}
-
Victor Costan authored
The SQLite cookie store has been migrated to schema version 10. The migration makes the store unusable by previous Chrome versions, so the compatible version should also be bumped. Change-Id: If430be6e925559b4e9ce119858df0f66f85ef833 Reviewed-on: https://chromium-review.googlesource.com/1008413Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#550103}
-
Kenichi Ishibashi authored
This fixes failures in http/tests/serviceworker/chromium/register-error-messages.html Bug: 715640 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Id089672074157d5e861d7539ee08115cf7b55488 Reviewed-on: https://chromium-review.googlesource.com/1004555 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#550102}
-
Bill Orr authored
TBR=vollick@chromium.org BUG=824825 Change-Id: I22bb8ca8287ba4d774d56fe48c66f5d0fd25418d Reviewed-on: https://chromium-review.googlesource.com/1003139 Commit-Queue: Klaus Weidner <klausw@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#550101}
-
siyua authored
The Autofill.CreditCardInfoBar.Server histogram was split into { Autofill.CreditCardInfoBar.Server, Autofill.CreditCardInfoBar.Server.PreviouslyDenied, Autofill.CreditCardInfoBar.Server.PreviouslyAccepted}. This caused confusion as it went against precedent where sub-histograms shouldn't affect their parent's data, and as a result hid a lot of data behind the .PreviouslyAccepted and .PreviouslyDenied subhistograms. Here's what we want to happen instead, using Autofill.CreditCardInfoBar.Server as an example: 1) Autofill.CreditCardInfoBar.Server goes back to containing ALL data, not just a portion of it. 2) What used to go to Autofill.CreditCardInfoBar.Server should now go to Autofill.CreditCardInfoBar.Server.NoPreviousDecision so that the subhistograms are still useful. Bug: 827414 Change-Id: I432e98f4729318e3e060e280551286b2bcfb80b0 Reviewed-on: https://chromium-review.googlesource.com/997026 Commit-Queue: Siyu An <siyua@chromium.org> Reviewed-by:Evan Stade <estade@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#550100}
-
Patrick Noland authored
Replace JsonFetcher with ContextualSuggestionsFetch. Add no-op/null implementations of methods. Move Cluster definition to its own file. Make ContextualSuggestion a struct, and give it a builder. Adjust bridge to properly use new ContextualSuggestion struct. Add deps on services/network and content/public. R:fgorski@chromium.org, mmenke@chromium.org Bug: 807697 Change-Id: I6a41937a3ae934283f57a8516e2017531adb063d Reviewed-on: https://chromium-review.googlesource.com/1000174 Commit-Queue: Filip Gorski <fgorski@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
-
Giovanni Ortuño Urquidi authored
Changes the logic to show the location bar any time a site is not secure e.g. if it displays mixed content, has a mixed content form, etc. Before, we would only show the location bar for dangerous sites e.g. invalid certificate, or if the site was not using https. Based on https://crrev.com/c/923226 by mgiuca. Bug: 811158 Change-Id: I72b59eaab031f20924057d1c7ec614f221c52c61 Reviewed-on: https://chromium-review.googlesource.com/1001075 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#550098}
-
Giovanni Ortuño Urquidi authored
Changes LocationBarView to also update its visibility based on the animation state. Before this patch, we would only update the height of the view which resulted in the LocationBarView's elements to still be focusable, even when the bar was supposed to be hidden. Bug: 822123 Change-Id: If8188bb11d5971072192036a4c644e3d3fb5e489 Reviewed-on: https://chromium-review.googlesource.com/1003932Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#550097}
-
Mounir Lamouri authored
This is a reland of a5439425 The CL failed after CQ because another CL that landed a couple of commits prior broke some assumptions made in the unit tests. Original change's description: > Media Controls: allow navigation with accessibility tools. > > The media controls auto-hide mechanism breaks accessibility tools. This > prevents the controls from fully hiding when navigated with > accessibility tools. Instead of marking themselves as `display:none;`, > this only mark the controls as hidden and will show them again if the > user navigates trough them again. Similar to using a mouse. > > Bug: 667833 > Change-Id: I7c2dbfd4b047e2955f6ffa9fb1a5f3bbe37878fd > Reviewed-on: https://chromium-review.googlesource.com/999637 > Reviewed-by: Tommy Steimel <steimel@chromium.org> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> > Cr-Commit-Position: refs/heads/master@{#549774} TBR=dmazzoni@chromium.org, pfeldman@chromium.org Bug: 667833 Change-Id: I03bbe4858d456a9131b257ca709f7d8728e712f7 Reviewed-on: https://chromium-review.googlesource.com/1007075Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#550096}
-
Ryan Hamilton authored
to avoid unregistering static streams with the priority dependency state. Change-Id: I5dcbfdc3bf08c4b3d18b334c650fe267580f4221 Reviewed-on: https://chromium-review.googlesource.com/1008176Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#550095}
-
Bill Orr authored
VR runtime-backed controllers should only be exposed when WebXR or WebVR APIs are available. BUG=830935 Change-Id: I354be9e62e90e7acac3fd712fc3497c141373a47 Reviewed-on: https://chromium-review.googlesource.com/1003732 Commit-Queue: David Dorwin <ddorwin@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Reviewed-by:
-
Hajime Hoshi authored
We plan to eliminate kUnthrottled, kUnspecedTimer and kUnspecedLoading and replace them with appropriate kInternal* task types. Bug: 830489 Change-Id: If0f260c6c7d4ec9f8ca476bc6731e54f1d7cb7d2 Reviewed-on: https://chromium-review.googlesource.com/1005642Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#550093}
-
Tom Anderson authored
Since libc++{abi} are included using -isystem and we compile with -MMD (not -MD), headers from these libraries will not be listed as dependencies. It's possible for libc++{abi} to be updated and for ninja to belive no rebuild is necessary. This CL adds defines for libc++{abi} to force a rebuild when the headers are updated. This CL also requires: https://chromium-review.googlesource.com/c/chromium/buildtools/+/1002869 R=thakis Change-Id: I4c48aa18643cd5fee1be23b6379569123e6fef51 Reviewed-on: https://chromium-review.googlesource.com/1002868 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by: -
Cathy Li authored
Change-Id: I11e64d59194d6dbb52dd0b6f3ff2fefa8f796608 Reviewed-on: https://chromium-review.googlesource.com/999010Reviewed-by:
Peter Williamson <petewil@chromium.org> Commit-Queue: Cathy Li <chili@chromium.org> Cr-Commit-Position: refs/heads/master@{#550091}
-
rbpotter authored
Add a timeout so that the list does not immediately begin changing. This will better match the behavior of the old UI. Bug: 773928 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I5c9d3c3ff2ccd48b30dbb8ef34a86aceb3cbee3a Reviewed-on: https://chromium-review.googlesource.com/1007895Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#550090}
-
Anna Offenwanger authored
Most of the Origin Trial names do not have spaces, so update this one to match. Also, some things needs to alphabetized. Bug: 779691 Change-Id: Ic7c45e751b35817c4bbaceb0b9f451cd375e4840 Reviewed-on: https://chromium-review.googlesource.com/1006044Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#550089}
-
Raphael Kubo da Costa authored
Follow-up to 5b84e88a ("Remove custom bindings for CSSStyleDeclaration"). The custom bindings code used to convert the property value to a string via V8StringResource<kTreatNullAsNullString> even though that does not match the setter's signature in the IDL file. Now that the bindings are being generated automatically, the IDL's signature was being respected and causing property values to be converted via V8StringResource<kTreatNullAndUndefinedAsNullString> Update the signature in the IDL so that we maintain compatibility with the older code. Bug: 764633 Change-Id: Ief868d4d3a0655f56e844d3b05cfbd771b2cf8da Reviewed-on: https://chromium-review.googlesource.com/1002878 Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by:
-
Jennifer Apacible authored
Currently, Picture-in-Picture window sizes are determined solely from calculating 20% of the primary display size. This change scales that initial size also adhere to the aspect ratio of the video size. BUG: 726621 829677 Change-Id: I61c26f0dc9d44ebf77620f875aed005b7594d88f Reviewed-on: https://chromium-review.googlesource.com/1001514 Commit-Queue: apacible <apacible@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
-
