GitLab

This change removes the enable-pinch flag and one of its switches
(kEnablePinch). The kDisablePinch switch is still used by Cast.
The kEnablePinch switch has no effect since pinch is default-
enabled.

Bug: None
Change-Id: I6006dd9766e9c6acc99cf47e2f18939b159fc399
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559385
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#649172}

This reverts commit 67167003.

Reason for revert: http://crbug.com/950211

Original change's description:
> [Mojo-IMF] Defines/implements mojo interface - ImeEngineClient.
> 
>  - Makes InputMethodChromeOS as an ImeEngineClient.
>  - Hooks up WindowTreeHostMus/WindowTreeClient to connect to ImeEngine.
>  - Makes calls from ImeEngine to ImeEngineClient.
> 
> Bug: 937167
> Change-Id: I0d27ce6e9bc547f4d269cdfe0ef38e8e83673267
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546795
> Commit-Queue: Shu Chen <shuchen@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Reviewed-by: Dominick Ng <dominickn@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#648188}

TBR=sky@chromium.org,shuchen@chromium.org,dominickn@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 937167
Change-Id: Iedc3a4e21c4236ee7a3529977fe74ba9f3a74c6b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559846Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#649171}

https://swiftshader.googlesource.com/SwiftShader.git/+log/42761d27612b..3ed8ba0c5a4b


git log 42761d27612b..3ed8ba0c5a4b --date=short --no-merges --format='%ad %ae %s'
2019-04-09 bclayton@google.com Reactor: Support printing pointers


Created with:
  gclient setdep -r src/third_party/swiftshader@3ed8ba0c5a4b

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=swiftshader-team+autoroll@chromium.org

Change-Id: I15e59542e7b7fe06f3391ce2a0720d649bb18dbc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559844Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#649170}

Instead of using texts baked in client side for the image clickthrough dialog,
read the texts from server response if they present, and only use client strings
as fallbacks.

Change-Id: Ib80bf91c8271e1f3559bca745c33535054bef535
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557081
Commit-Queue: Hui Wu <wuandy@chromium.org>
Reviewed-by: Mathias Carlen <mcarlen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#649169}

Coverage stats show these lines are never called in tests.
https://findit-for-me.appspot.com/p/chromium/coverage/file?host=chromium.googlesource.com&project=chromium/src&ref=refs/heads/master&revision=a5fa529d062c224c8659e2fc6dacb737709c50ca&path=//chrome/browser/ui/webui/chromeos/login/l10n_util_test_util.cc&platform=linux-chromeos

Change-Id: I9b72a978898e390f56daff71ec663c00a02cbbf8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1558622
Commit-Queue: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#649168}

This CL changes the expiration time of the FCM->Tango migration related
metrics. It either prolongates expiration_date or removes it completelly,
for the metrics we're planning to use in order to inspect health of the FCM invalidations

Bug: 801985, 945553, 945539
Change-Id: Iffe973f6a2c6eaeebf306a01fef5bcac1c018b8a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549415Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: Tatiana Gornak <melandory@chromium.org>
Cr-Commit-Position: refs/heads/master@{#649167}

Bug: 950471
Change-Id: I4c4a00f4ce0ff13fc0fa13a3312f31511cf4f3e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559956
Commit-Queue: Denis Kuznetsov <antrim@chromium.org>
Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#649166}

Since GVR doesn't like inverted selection indices (it silently uninverts them here:
go/cassew-gvrkeyboard-indices-invert), uninvert the indices before sending them to Gvr.

Bug: 819754
Change-Id: Ic6ef2a0f031af988d81579fd56de0cac2fd03c93
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1551861
Commit-Queue: Will Cassella <cassew@google.com>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#649165}

https://skia.googlesource.com/skia.git/+log/d9b8eed84814..4ffbfe61777f


git log d9b8eed84814..4ffbfe61777f --date=short --no-merges --format='%ad %ae %s'
2019-04-09 bsalomon@google.com Add support for importing GL_R16F for YUVA promise images
2019-04-09 martin@mainframe.co.uk add missing shared lib visibility macros
2019-04-09 herb@google.com Revert "Handle translating blob to origin in bulk"
2019-04-09 herb@google.com Revert "Reland "Do not use sub-pixel positioning for source space""
2019-04-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skia/third_party/skcms 36eeb1311a72..0da672fc2c69 (1 commits)
2019-04-09 herb@google.com Reland "Add maxDimension() to glyph"
2019-04-09 herb@google.com Reland "Do not use sub-pixel positioning for source space"
2019-04-09 brianosman@google.com Shader serialization experiment (with Mali Offline Compiler analysis)


Created with:
  gclient setdep -r src/third_party/skia@4ffbfe61777f

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=egdaniel@chromium.org

Change-Id: I338e8fa2c68835c26410ece788d3000b3bc9a111
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559843Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#649164}

Disables media key handling when locked on CrOS
because of privacy issues.

BUG=926019

Change-Id: Ib0e5fcc5f9d20b60fdc0c607d276ffddc7a846b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554795Reviewed-by: Tommy Steimel <steimel@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#649163}

As part of https://chromium-review.googlesource.com/c/chromium/src/+/1547051
InvalidateLayout() was changed to result in a Layout() at a later date. This
broke top-chrome sliding. The reason for that, is that if Layout() happens to
be called during top-chrome-slide, the NativeViewHost positions the WebContents
at an unexpected location. The reason for that is NativeViewHost calculates
the position using the transforms that are installed by
TopControlsSlideControllerChromeOS, which is unexpected.

The fix is to have TopControlsSlideControllerChromeOS calls
LayoutRootViewIfNecessary() before setting the transforms. This clears the
pending Layout().

BUG=949393
TEST=see bug for repro steps

Change-Id: I98ed95f301286e0e490f543800d20d2db3b0faec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559878Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#649162}

- Always apply dark mode filter to the gradients in dark mode.
- Apply dark mode filter if applicable to rounded images.

Bug: 936890
Change-Id: Ic1113b201eaab1d0803e67232364623e143a5e98
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520681Reviewed-by: Stephen Chenney <schenney@chromium.org>
Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org>
Commit-Queue: Anna Malova <amalova@chromium.org>
Cr-Commit-Position: refs/heads/master@{#649161}

EG2 tests will need to depend on this utility target without pulling in
all of //ios/web.

BUG=922813

Change-Id: I33e2ad2d5fc2d1a83bbe96903a8ec4238be785a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559873Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#649160}

This is in preparation for replacing EntityDataPtr with unique_ptr

Bug: 924978
Change-Id: I539186314bd30baf3a95d2f14ec8a7eecb128adf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556787
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#649159}

Actually this just removes the extra baseline on linux.

TBR=fmalita@chromium.org

Bug: 673539
Change-Id: I139977db7f846af7a6df95d2fdc7e2e07f953ad0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559387Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#649158}

This adds an implementation of ITextRangeProvider::MoveEndpointByUnit
for TextUnit_Page and TextUnit_Document.

Behavior for TextUnit_Page is identical to TextUnit_Document, as web
pages are not paginated.

TextUnit_Document behavior is to always move to the beginning or end of
the top-level document. iframes will jump out of the current iframe and
to the end of the top-most document. There currently is buggy behavior
for the iframe case, and a follow up task will address this issue.

Bug: 928948
Change-Id: I87056282dbe037e95a3cd43b29e10a849a9a9a0e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554132
Commit-Queue: Alison Maher <almaher@microsoft.com>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#649157}

Call sites are also updated to use base::BindOnce() instead of Bind()
or BindRepeating(), and remove AdaptCallbackForRepeating() where
possible.

Bug: 950118
Change-Id: I98449b98842a9c75f4ec670777cf245a51c683fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1555854
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#649156}

This was found when I was debugging failures within:
https://chromium-review.googlesource.com/c/chromium/src/+/1553646

Essentially we didn't clear all the members within the Reset call.
The initial bug I found meant that OOF-positioned candidates appeared
multiple times within a layout result.

Bug: 635619
Change-Id: I26acdad2c85045ce155449379cce68c447b39d99
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559930
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#649155}

This is a reland of 0ca38034

The tests were flaking because the tab indicator is only removed after the
browser process receives the Mojo connection error. To fix this the tests are
now unit tests where we can make sure to run the necessary message loop to make
sure that this event has been delivered before checking.

Original change's description:
> [serial] Implement tab indicator triggered by open()
>
> As long as there is an active connection between a frame in a tab and a
> serial port the tab should display an indicator.
>
> This is accomplished by adding an additional Mojo pipe that is kept open
> between the device service and the browser processes for as long as the
> render process has a connection to the port.
>
> Bug: 917204
> Change-Id: I6441070f3473bd6b4a98dae98844a89ee4eb2329
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546502
> Reviewed-by: Scott Violet <sky@chromium.org>
> Reviewed-by: Dominick Ng <dominickn@chromium.org>
> Reviewed-by: Yuri Wiitala <miu@chromium.org>
> Commit-Queue: Reilly Grant <reillyg@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#647109}

Bug: 917204
Change-Id: I26fbb51845ae6b7ce2fe54bad2cc0a271ce0cbd0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1555508Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#649154}

These performance tests can re-enabled because the culprit
CL that caused these to fail (http://crrev.com/c/1423601)
has been reverted (in http://crrev.com/c/1457745). As a
result, the tests run fine now.

Bug: 928796
Change-Id: I771f53015448e42e019de0e94b2abb1811b932b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557092
Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#649153}

This changes how we unload the feedback extension when the submission is
done on the signin screen. We used to remove it when the dialog was
closed, but that would cause the upload to not occur if the user clicked
'Send' before system information log collection was complete. Now we add
another JS FeedbackPrivate API call so that the extension can inform us
when it is done with its work and then we can remove it safely.

cases of Cancel/Send/CloseWindow whether done before or after system
information was loaded, and then also sending feedback and logging in
before it is sent.

Bug: 947344
Test: Verified feedback report is sent (or not), extension is unloaded in
Change-Id: I7c10593d063653a1a777dcf9e2cfb9e48962cbec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553426Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com>
Cr-Commit-Position: refs/heads/master@{#649152}

This change implements UIA_FontNameAttributeId and
UIA_StyleNameAttributeId for use in
ITextRangeProvider::GetAttributeValue.

Unit tests added for these, as well as for UIA_FontWeightAttributeId.

Bug: 847971
Change-Id: If7c59d2e6357d5b2621f1ff06742f221d765da6c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1551711
Commit-Queue: Alison Maher <almaher@microsoft.com>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#649151}

This allows specific inclusion of chromeos/dbus/audio only where needed.

For mechanical changes to extensions/ and media/:
TBR=tbarzic@chromium.org

Bug: 940810
Change-Id: I7b98e6bedaab8812603ee0f1da67aef759f54822
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554141
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#649150}

Moving an app into a folder should be accomplished with control-shift-arrow.

Doing control-shift-arrow inside a folder will move the item out of the folder
and place the item left/right/up/down relative to the folder.

Change-Id: I5f1aaf1c39eee39c087af02ca60bfdc5f1b9031d
Bug: 887996
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1532367
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#649149}

Fixes a compatibility issue with python3:
$1 = std::unordered_set (count=3)Traceback (most recent call last):
  File "libcxx-pretty-printers/printers.py", line 777, in children
    for elt in self.hashtableiter:
TypeError: instance has no next() method

BUG=929992
R=thakis

Change-Id: Ib297f98a2ff19ffa35f8688e3786a8d280a6d685
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559340
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Auto-Submit: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#649148}

This is a part of moving manifest implementation to blink.
This CL moves content::ManifestFetcher to blink and introduces
WebManifestFetcher in blink/public/web to expose the fetcher to
content::ManifestManager.

Bug: 704441
Change-Id: Ia4114390f124973542aca0151d06baec82fdaec1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548972Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Miyoung Shin <myid.shin@igalia.com>
Cr-Commit-Position: refs/heads/master@{#649147}

- Add new Object property, pendingPrinter_, to cups_edit_printer_dialog.
  This object serves as a copy of activePrinter and is used as the main
  property for changes in edit printers dialog.
- Previously, activePrinter was being directly edited in the edit
  printer dialog. This resulted in activePrinter's property values
  to change even if the user clicks on the cancel button. The new
  pendingPrinter_ object fixes this by making a copy of activePrinter
  and only modifying activePrinter when the user clicks on the save
  button.
- Edit BrowserTests to reflect this change.

Bug: 893986
Test: End to End, BrowserTest/gtest_filter=CrSettingsPrinting*

Change-Id: Ia015fcda1e53dc8848556365d49c215492418d40
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1490378
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#649146}

https://chromium.googlesource.com/angle/angle.git/+log/0086a8acd879..fc15ae5571b3


git log 0086a8acd879..fc15ae5571b3 --date=short --no-merges --format='%ad %ae %s'
2019-04-09 syoussefi@chromium.org Vulkan: parallelize internal shader compilation
2019-04-09 jmadill@chromium.org Formalize preference for handling generated code.


Created with:
  gclient setdep -r src/third_party/angle@fc15ae5571b3

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=ynovikov@chromium.org

Change-Id: I98bce45cf3776e8759d3d13d1b5ff7d18197bb72
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1558759Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#649145}

This also removes a now-unneeded include in about_flags.cc.

TBR=avi@chromium.org

Bug: None
Change-Id: I9c553e4604ab2d101accb35916ff639fce53dcce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559872
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#649144}

This class is not ref-counted for any particular reason and the shared
ownership is confusing/unnecessary. This CL removes its refcounting;
it is now passed around mostly as a const ref, and copied where
necessary, as described in detail below.

The AuthChallengeInfo for a request is created and populated by
HttpAuthController, and ownership is then handed off to HttpResponseInfo.
HttpResponseInfo stores the AuthChallengeInfo inside a base::Optional
rather than a unique_ptr so that HttpResponseInfo remains copyable (and
rather than as a member field directly because consumers need to tell when
the auth_challenge has been set or not).

The AuthChallengeInfo is then passed to delegates as a const ref so it
is clear that delegates don't own it and can't modify it. It is copied on
the UI thread when we get to the point of creating the LoginDelegate/
LoginHandler.

Bug: 949197
Change-Id: I8b91fd80d20b4771c38cf4785ea0ca33ddb25ab5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1550631Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Asanka Herath <asanka@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Commit-Queue: Emily Stark <estark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#649143}

When changing a PIN, the error message under the current PIN can get
quite long because it may highlight that only a single attempt remains.
When this was shown, the error message was wrapped to the length of the
cr-input, and took two or three lines.

This change sets only the width of the input itself, allowing the
containing cr-input, and any error messages, to be longer. With this
change, the error message wraps only when it reaches the with of the
whole dialog, and our error messages aren't that long.

Bug: 870892
Change-Id: I69fc9b96454cf88f3bd0fd01333cb8c170772014
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548239
Commit-Queue: Adam Langley <agl@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Auto-Submit: Adam Langley <agl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#649142}

https://dawn.googlesource.com/dawn.git/+log/865cad89b916..2d4c66d2b865


git log 865cad89b916..2d4c66d2b865 --date=short --no-merges --format='%ad %ae %s'
2019-04-09 ynovikov@google.com Revert "Rename texture.createTextureView to createView to match WebGPU"
2019-04-09 enga@chromium.org Update ComputePipelineDescriptor to use PipelineStageDescriptor
2019-04-09 enga@chromium.org Rename texture.createTextureView to createView to match WebGPU
2019-04-09 enga@chromium.org Remove sampler border color from Dawn to match WebGPU


Created with:
  gclient setdep -r src/third_party/dawn@2d4c66d2b865

The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:877147,chromium:877147,chromium:877147,chromium:877147
TBR=cwallez@chromium.org

Change-Id: I4151ff5dbab96b4d276181be0b327c9767adecb9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559200Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#649141}

Nested scoped feature must be used in ABBA pattern.
Using ABAB pattern leads to features corruption and make following tests
to fail.
Follow-up of https://chromium-review.googlesource.com/c/chromium/src/+/1547984

Bug: 831123
Change-Id: Ic5538fca1e456947c126eaf8897e4ff2d5777d21
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559085Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#649140}

This CL replaces if statements checking that count of typed visits is
_non-negative_ by DCHECKs. Negative typed count should never occur and
thus this CL simplifies the code.

Bug: 907476
Change-Id: I13494454ff41f3a7f6fc202e63458a7142368d84
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559318
Auto-Submit: Jan Krcal <jkrcal@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Jan Krcal <jkrcal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#649139}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/b04e2aaec8cc..3ef631ecd110


git log b04e2aaec8cc..3ef631ecd110 --date=short --no-merges --format='%ad %ae %s'
2019-04-09 evanhernandez@chromium.org Revert "scripts: Link build_api to wrapper.py."
2019-04-09 evanhernandez@chromium.org api: Regenerate proto.
2019-04-09 evanhernandez@chromium.org artifacts: Add BundleImageZip endpoint.


Created with:
  gclient setdep -r src/third_party/chromite@3ef631ecd110

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@chromium.org

Change-Id: I30d6dc0b6ea2212937b7fbfe4825dbd087fcbb28
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559201Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#649138}

This reverts commit 5a8aa78d.

Reason for revert: Causing test failures due to cast from IdentityManagerWrapper to TestIdentityManagerWrapper. Logs:
- https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8916648927362689184/+/steps/browser_tests/0/logs/Deterministic_failure:_GetAuthTokenFunctionTest.InteractiveApprovalSuccess__status_CRASH_/0
- https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8916648927362689184/+/steps/browser_tests/0/logs/Deterministic_failure:_ChromePasswordProtectionServiceBrowserTest.ChromeEnterprisePasswordAlertMode__status_CRASH_/0

Original change's description:
> Update IdentityManager to own ProfileOAuth2TokenService.
> 
> With this change, ProfileOAuth2TokenService is now constructed only when
> creating an IdentityManager, eliminating the need for
> ProfileOAuth2TokenService factories.
> 
> 
> Change-Id: Ie52e179058ef87193bbf6cb0dda45208392c9572
> Bug: 939372
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529018
> Reviewed-by: David Roger <droger@chromium.org>
> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
> Reviewed-by: Colin Blundell <blundell@chromium.org>
> Commit-Queue: Lowell Manners <lowell@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#649073}

TBR=droger@chromium.org,blundell@chromium.org,sdefresne@chromium.org,lowell@chromium.org

Change-Id: Ie3c8a6f0188d27d2b05809f581c1e560e248df8f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 939372
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559389Reviewed-by: Collin Baker <collinbaker@chromium.org>
Commit-Queue: Collin Baker <collinbaker@chromium.org>
Cr-Commit-Position: refs/heads/master@{#649137}

Subframes can also abuse the back button by adding multiple history entries
without user's interaction. This Cl prevents the back button from landing
on those
entries. If the user interacted with an ancestor frame but not with a cross
origin subframe that is creating an entry, this CL will mark the last
committed entry as skippable. If the user interacted with the subframe or a
child of this subframe or same origin ancestor frame, the last committed
entry will not be marked as skippable. This is based on how User Activation
V2 API's frame propagation is implemented.
In case the user interacts with this subframe or an ancestor/child frame
after the entry is marked as skippable, the skippable flag will be reset as
per an earlier CL.

NavigationControllerHistoryInterventionBrowserTest.
NoUserActivationSetSkipOnBackForwardSubframe

Test: content_browsertests --gtest_filter=
Bug: 907167
Change-Id: Icd24dd4fe5cb3c4863dc6328128696b2a4401d23
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541665Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Shivani Sharma <shivanisha@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Commit-Queue: Shivani Sharma <shivanisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#649136}

This CL adds a TRACE_EVENT_ASYNC_... for VideoFrameSubmitter's
frame round trip (e.g. from the CompositorFrame delivery to the
swap buffers event deep in the DRM Thread if on ChromeOS).

E.g. for a webm playback from file on my gLinux box it looks
like [1]. On a real time loopback webrtc conversation on
my nocturne chromebook it looks much more jittery.

[1] https://i.imgur.com/uyJk7cz.png (https://imgur.com/a/nbaBc7U)

Bug: 950183
Change-Id: Ia95fb0e9b60128343eecf699ba0551b920a497ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554952Reviewed-by: Frank Liberato <liberato@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#649135}

This patch has ChromeActivity consider whether the bottom sheet is in
the process of closing before determining which container to place
a snackbar in. This avoids inadvertently blocking snackbars that are
shown when the sheet is about closed.

Bug: 950739
Change-Id: Ib7e0b3d2bbd58580dad84c2d146b13b98dcb13ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559154Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#649134}

Bug: None
Change-Id: Ia1b7c8a1039d374d56d1235d66eda2b5950a2e7c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559447
Auto-Submit: Peng Huang <penghuang@chromium.org>
Reviewed-by: Jonathan Backer <backer@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#649133}