- 02 Dec, 2019 34 commits
-
-
Adam Rice authored
Remove the ReadableStream base class and rename ReadableStreamNative to ReadableStream, making the methods non-virtual. Remove ReadHandle and use ReadableStreamDefaultReader directly instead. Remove ReadableStreamDefaultControllerInterface and rename ReadableStreamDefaultControllerNative to ReadableStreamDefaultControllerWithScriptScope. Move some functions that used to be shared with ReadableStreamWrapper from miscellaneous_operations.h to readable_stream.h. Bug: 1029408,1011392 Change-Id: I27e93d00428a39868b963e9e721d7a6a46e07cb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943649Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#720395}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/fd0c2574518c..d050e5a75e36 git log fd0c2574518c..d050e5a75e36 --date=short --first-parent --format='%ad %ae %s' 2019-12-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader fb7ca1d5aca5..b64fbfec4dcd (3 commits) Created with: gclient setdep -r src/third_party/skia@d050e5a75e36 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bsalomon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:None Tbr: bsalomon@google.com Change-Id: I13009df22d1fb40c3f7d6e39619e9fdac75edda9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944944Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#720394}
-
Hiroki Nakagawa authored
Bug: 931087 Change-Id: Ic1cfb00abb3e7e2c598d16341a28f60f2277e464 TBR: kinuko@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943084 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#720393}
-
Edward Jung authored
One part of the sprite was misaligned causing a thin line to flicker whilst ducking in which could be see in dark mode. Bug: 1028467 Change-Id: I6850be4ba16cb3aa0b1e517ba1cbc1134db2b86a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939975Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#720392}
-
Matt Falkenhagen authored
Bug: 1007763 Change-Id: I4d8ff83c57851b4dc5d470b046ef76510eb36253 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942900 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#720391}
-
Kouhei Ueno authored
This reverts commit 57b585dc The change is now without the (accidentally included) failing test: BackForwardCacheBrowserTest.WebMidiNotCached > Revert "BFCache: Add browser_tests for WebRTC / WebLocks" > > This reverts commit 3022f4eb. > > Reason for revert: BackForwardCacheBrowserTest.WebMidiNotCached seems to fail consistently after being introduced in this CL: https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-google-rel/9378 > > Original change's description: > > BFCache: Add browser_tests for WebRTC / WebLocks > > > > Bug: 981740 > > Change-Id: Icd020d557eee5e0aa680119ade6022015f88f615 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1905296 > > Commit-Queue: Kouhei Ueno <kouhei@chromium.org> > > Reviewed-by: Alexander Timin <altimin@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#716916} Change-Id: Ie0240c20a236e43c2c62801649ad3e50855302ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942680 Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#720390}
-
Maggie Cai authored
Currently intent query doesn't check if the app is uninstalled because I assumed the intent_filter field will be removed from the app. This CL fix this issue. BUG=853604 Change-Id: Id418a1568477bbfe1a07792f17863229dacba100 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946047Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Commit-Queue: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#720389}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/0317de96ccff..f1017f0c7bd2 git log 0317de96ccff..f1017f0c7bd2 --date=short --first-parent --format='%ad %ae %s' 2019-12-02 abennetts@google.com Fix results2-frame, which was inadvertently broken by a recent fix. Created with: gclient setdep -r src/third_party/catapult@f1017f0c7bd2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC crouleau@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: crouleau@chromium.org Change-Id: I115e472aec677c9b6fe7bfd069e79c4d6bee0793 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944942Reviewed-by:
-
Giovanni Ortuño Urquidi authored
Change-Id: I6b14bd4a1ad8407afb13fc8e69c1ea0296f37715 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943879 Auto-Submit: Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Reviewed-by:
-
Hayato Ito authored
This is a pure refactoring, as a preparation for introducing a concept of 'offline' tasks later. Background: The WIP CL, https://crrev.com/c/1900803/, introduced a concept of a *Task* in ServiceWorkerTimeoutTimer, however, there are still two different queues in the timer, |pending_tasks_| (for normal tasks) and |pending_after_idle_timeout_tasks_| (for pending after-idle-timeout tasks). That are confusing and error-prone. So before proceeding further, I've decided to refactor the current ServiceWorkerTimeoutTimer, merging two different interfaces, StartEvent() and PushPendingTask(), into one interface, PushTask(). Now all callers should use PushTask(). The current StartEvent(), StartEventWithCustomCustomTimeout(), and PushPendingTask() are no longer available from outside. StartEvent() is now an internal function, and others were just removed. After this CL, I'll introduce a new kind of a task, OFFLINE. Bug: 965802 Change-Id: Ide270432f486484c1ac2127cff59e0258f88a835 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906452 Commit-Queue: Hayato Ito <hayato@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#720386}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: I7f0df9a128c573a414b94936def27c72ecaf3cf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1945889Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#720385}
-
Julie Jeongeun Kim authored
This CL cleans up old Mojo types for chromeos_camera::mojom::MjpegDecodeAccelerator from MojoMjpegDecodeAcceleratorServiceTest using Remote. Bug: 955171 Change-Id: I764a1a5b238022c8bcfa62477e27347e547e8bb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941650Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Ricky Liang <jcliang@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#720384}
-
Koji Ishii authored
Following bot results are included. 490 494 496 497 498 46 lines were removed and 109 lines were deflaked by consecutive results since 479. TBR=yosin@chromium.org NOTRY=true Bug: 982194 Change-Id: Ic58f75faf3e111a964c0097c7edc0026203ed9b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943773Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#720383}
-
Koji Ishii authored
|NGBoxFragmentPainter| was using |LayoutObject| as |DisplayItemClient| unless |NGPaintFragment| is available. When |NGFragmentItem| is enabled, it should be used for inline boxes instead. Fixes 4 crashes, and turns 4 crashes to failures due to incorrect offset. Bug: 982194 Change-Id: I85aaa80596b766c9315a126a9745fe0f96bb72d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942898Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#720382}
-
Staphany Park authored
This refactor condenses service worker test files by converting the service worker scripts into .any.js WPT files that test both window and worker contexts. Change-Id: Iee64f5cc68b939ab02b06910444b8ebffdf359a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851232 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#720381}
-
Hiroki Nakagawa authored
This is a part of the effort to split ServiceWorkerProviderHost into ServiceWorkerHost and ServiceWorkerContainerHost. This CL reduces dependencies on ServiceWorkerProviderHost from navigation in favor of ServiceWorkerContainerHost. Conceptually, navigation for service worker clients don't have to depend on ServiceWorkerProviderHost to be renamed to ServiceWorkerHost. See the design doc for details. Design doc: https://docs.google.com/document/d/1epWIgelE-7uwxJHrYPKlbwqMRP9in2xLUR6mpiU_afY/edit?usp=sharing Bug: 931087 Change-Id: I51c3bcb2e96149a576e58c98dceaa40ff88355fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942673 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
-
Hiroki Nakagawa authored
This CL renames ServiceWorkerContextWrapper::GetProviderHostIds() to GetWindowClientFrameRoutingIds() based on the following reasons: - GetProviderHostIds() returns pairs of process id and frame routing id (i.e., GlobalFrameRoutingId) contrary to its name. - GlobalFrameRoutingId doesn't make sense for worker clients because they don't have frame routing ids. The original GetProviderHostIds() contains GlobalFrameRoutingId for worker clients. The callers of GetProviderHostIds() filter them out by themselves, so that hasn't been problematic. However, worker clients should be filtered out by GetProviderHostIds() in the first place. This CL makes GetWindowClientFrameRoutingIds() filter out worker clients. Bug: 931087 Change-Id: I5c5c0a85a1ec68723453262066663b9aa030979c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942899 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
-
Jinsuk Kim authored
Tab.enter/exitFullscreenMode() doesn't actually do any mode toggling job but is used as a means to plumb the request from content layer to ChromeFullscreenManager via TabObserver.onFullscreen{Enter/Exit}Mode. This CL gets Tab/TabObserver out of the flow, lets the call sites deal with it using FullscreenManager.FullscreenListener to achieve the same effect. The change assumes fullscreen mode switching can take place only when the underying activity is ChromeActivity. Added assert's to prevent future change from introducing bugs. Bug: 995903 Change-Id: Ib875da5555d2895450dc970901c2b3e51922174a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1909956 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#720378}
-
Noel Gordon authored
No need to invoke the HTML parser from a template, when we can create the <icon-icon> directly using DOM createElement. Bug: 1026943 Fixed: 1026943 Change-Id: I2d026ac135310eb6cc4e997e5e9ffb0987f88cd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942676Reviewed-by:
Alex Danilo <adanilo@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#720377}
-
Yuta Kasai authored
This CL doesn't change any behaviors. This just fixes typo. Change-Id: Idf8f85314d8d718bec7562f7b25de3a2f8ce8b28 Bug: N/A Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943069 Auto-Submit: Yuta Kasai <yutakasai@google.com> Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#720376}
-
Jeremie Boulic authored
Fix unaddressed comments in CL:1935772 post-landing. Bug: 999825 Change-Id: Ieca3c0440c697e8e6c4291f3cf3270b022cbe396 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943083Reviewed-by:
-
David Staessens authored
When logging errors in the VaapiVideoDecoder the DVLOGF(3) and VLOGF(1) macros are currently used. The DVLOGF macro removes log messages in non-debug builds. The VLOGF macro hides error messages by default. This CL changes these macros to LOG(ERROR), so error messages are always immediately visible in the log. TEST=./video_decode_accelerator_tests on hana BUG=None Change-Id: I6abea849670e6a1ec4260e4ff8bfe6efdb143cca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939992 Commit-Queue: David Staessens <dstaessens@chromium.org> Reviewed-by:
Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#720374}
-
Jeevan Shikaram authored
Rename permission-view to detail-view for better clarity. Bug: 999016 Change-Id: I365ea44f97cb3c7b261176310f5372acfb28154a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943072 Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#720373}
-
Koji Ishii authored
This patch invalidates |LayoutBlockFlow| when inline |DisplayItemClient|s (i.e., |FragmentItem|s) will be destroyed. Currently, we invalidate |NGPaintFragment| for the root of the inline formatting context. With [FragmentItem], the containing |LayoutBlockFlow| is the |DisplayItemClient| for the root box, regardless whether it has inline children or not. Fixes ~70 crashes (DCHECK failures in paint_controller.cc). Bug: 982194 Change-Id: If3bfaad632b0cd3d2dc7bd3fce23b5bd99aa2b1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943079Reviewed-by:
-
Xianzhu Wang authored
to avoid confusion in VisualViewport about the element ids for page scale and scroll. This allows us to use ScrollableArea::GetScrollElementId() to find scrolling related entities, for all ScrollableArea subclasses. Previously PaintLayerScrollableArea::GetCompositorElementId() was the scroll element id, while VisualViewport::GetCompositorElementId() was not. Change-Id: Ic99b9ddf2ddda7cac8c68e7b8ce172bcb0b64c75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942675 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#720371}
-
Andres Calderon Jaramillo authored
This CL adds the guado-cfm and rikku-cfm builds to the IMPORT mode blacklist used by the video_decode_accelerator(_perf)_tests. The reason is that these boards decode VP8 using V4L2, so we need to force ALLOCATE mode for them. Bug: 1028329 Test: Run tast.video.DecodeAccel.vp8 in guado Change-Id: I7fb9b6d374cc65026b91c0ceafd82ece3d0c530e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943467 Auto-Submit: Andres Calderon Jaramillo <andrescj@chromium.org> Commit-Queue: David Staessens <dstaessens@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#720370}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/bcfcc04c53f0..0317de96ccff git log bcfcc04c53f0..0317de96ccff --date=short --first-parent --format='%ad %ae %s' 2019-12-01 perezju@chromium.org [dashboard] Skip identity test_path migration tasks Created with: gclient setdep -r src/third_party/catapult@0317de96ccff If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC crouleau@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1022380 Tbr: crouleau@chromium.org Change-Id: If9f1e41274b94a2ea04719e2a9273d689ab45fbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944620Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium cf5df561. With Chromium commits locally applied on WPT: 500a74f5 "Add a runtime flag to enforce strict MIME type checks for workers." a2a91a99 "Allow another touch start happen when there are active touch points" 85b61e6b "[resource-timing] Ensure workerStart is protected by TAO" a75430aa "Fix appcache tests." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I7fc233be0df0c2989c51cf3156c518de6ef9bf73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944381Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#720368}
-
Gyuyoung Kim authored
This CL removes Create() factory functions in //third_partyb/blink/renderer/core/page as much as possible, and makes all callers use MakeGarbageCollected<Foo> instead. Bug: 939691 Change-Id: I89d73850a0d6e5a7937ede262c166e317e63b253 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942674Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#720367}
-
Nicholas Verne authored
This is to allow different UI treatments. Currently, Export/Import progress is surfaced in ChromeOS notifications. The current design for the container upgrade needs to show export progress in main dialog rather than a notification. This refactor enables both UI options. Bug: 1024693 Change-Id: Icb39ae531dab34b673ad0e5f86ee4de804665c8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930271 Auto-Submit: Nicholas Verne <nverne@chromium.org> Commit-Queue: Nicholas Verne <nverne@chromium.org> Reviewed-by:
Julian Watson <juwa@google.com> Cr-Commit-Position: refs/heads/master@{#720366}
-
Gyuyoung Kim authored
This CL removes Create() factory functions in //third_partyb/blink/renderer/core/dom as much as possible, and makes all callers use MakeGarbageCollected<Foo> instead. Bug: 939691 Change-Id: Ief07b2217b90c859048b83aef1e8138ba0aaa14b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942896Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4c615f527533..df12488bf4f8 Created with: gclient setdep -r src-internal@df12488bf4f8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: I0b8839485e152dcca35540ffe0c1308225ceec05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944619Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#720364}
-
Noel Gordon authored
The files-ng directorytree CSS uses box-sizing: border-box, and does not need a .file-row transparent border anymore. Remove it. Bug: 992819 Change-Id: Ie007ef3d8783c53c7ae8c636404f87c4bddd824c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943774Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Auto-Submit: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#720363}
-
Jing Wang authored
Add contextual function information in all errors in input ime api calls. Make all error messages to be a constant instead of plain string. Polish the text in some error messages. R=keithlee, shend Bug: 1024606 Change-Id: I1ce4dfc7275d2a88fb63c63bde1a3db11c50f7df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939131Reviewed-by:
Keith Lee <keithlee@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Keith Lee <keithlee@chromium.org> Commit-Queue: Jing Wang <jiwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#720362}
-
- 01 Dec, 2019 6 commits
-
-
Chris Harrelson authored
A previous patch regressed performance due to the need to walk the containing block chain to find containing scrollable areas, in order to notify them of anchor adjustments. This patch iterates over all ScrollableAreas and notifies each of them. Bug: 1024434 Change-Id: Ibee4d9383ec1456c5e020c95aea941124fca048b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931148 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
-
Alan Cutter authored
Our hit testing for the title bar window control buttons was not taking RTL mirroring into account. This CL fixes that. Without this CL the user was not able to drag the window in the top right corner when in RTL mode. Fixed: 1008371 Change-Id: Id84d381dca00ebb70931e3692fe4982df8827471 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943491 Commit-Queue: Alan Cutter <alancutter@chromium.org> Auto-Submit: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#720360}
-
Greg Thompson authored
Explicitly shut down the ShortcutsBackend and HistoryService in TearDown before cleaning up the ScopedTempDir. BUG=546640 Change-Id: I961dc49376116550e63a9c353d3d15a436731e93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943130 Auto-Submit: Greg Thompson <grt@chromium.org> Reviewed-by:
Kevin Bailey <krb@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#720359}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/487dd6fe1154..4c615f527533 Created with: gclient setdep -r src-internal@4c615f527533 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: Ib78c85b249e3e45e387b31935cabf7665abd83c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1945523Reviewed-by:
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: I6b12640aaa12422197b463b67b9d4f3e1eec4db6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1945477Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#720357}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/877dd541e6bc..487dd6fe1154 Created with: gclient setdep -r src-internal@487dd6fe1154 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: I2f71e7b2975a6468d66a0d497bdd6a9f6007d082 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1945521Reviewed-by:
-
