GitLab

The name is stale since the class was renamed. It was
"NativeDisplayDelegateDri" and is now "DrmGpuDisplayManager".

TEST=compile

Review URL: https://codereview.chromium.org/1146493004

Cr-Commit-Position: refs/heads/master@{#330729}

Revert of [Telemetry] Disable auto issuing record for thread_times (patchset #3 id:60001 of https://codereview.chromium.org/1140353003/)

Reason for revert:
Seems to have broken service_worker tests (http://crbug.com/490130)

Original issue's description:
> [Telemetry] Disable auto issuing record for thread_times
>
> BUG=444705
> CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect
>
> Committed: https://crrev.com/2905d303db21f120aab1914f98fe0e44284f82ed
> Cr-Commit-Position: refs/heads/master@{#330613}

TBR=eakuefner@chromium.org,nednguyen@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=444705

Review URL: https://codereview.chromium.org/1151543002

Cr-Commit-Position: refs/heads/master@{#330728}

This will allow us (in a follow-up CL) to *not* grant permissions to extensions that come in via Sync disabled due to a permission increase.

BUG=484214

Review URL: https://codereview.chromium.org/1136543003

Cr-Commit-Position: refs/heads/master@{#330727}

Review URL: https://codereview.chromium.org/1145533004

Cr-Commit-Position: refs/heads/master@{#330726}

BUG=474249

Review URL: https://codereview.chromium.org/1147843002

Cr-Commit-Position: refs/heads/master@{#330725}

+ Update chrome://kill and chrome://crash icons. Both now use the same icon.
+ Make layout consistent with the SSL / Malware / net error set of interstitials.
+ Switched colours, margin, padding to use native UI constants.

BUG=457763

Review URL: https://codereview.chromium.org/1129513002

Cr-Commit-Position: refs/heads/master@{#330724}

BatteryStatusManagerTest does not compile on M because of the
changes to the BatteryManager class. This patch introduces
AndroidBatteryManagerWrapper to make the system battery manager
testable on M.

BUG=488690

Review URL: https://codereview.chromium.org/1130253012

Cr-Commit-Position: refs/heads/master@{#330723}

We removed SDP logging earlier because it was bloating bot logs, but
nowadays logs only get printed for failing tests, and SDP information
is very useful to debug for instance webrtc:4570.

BUG=webrtc:4570,484826,479093

Review URL: https://codereview.chromium.org/1124323005

Cr-Commit-Position: refs/heads/master@{#330722}

This CL adds the possibility to filter by certificate type
when issuing a certificate request to chrome.platformKeys API.

BUG=488367
TEST=browser_tests:PlatformKeysTest.Basic

Review URL: https://codereview.chromium.org/1141253003

Cr-Commit-Position: refs/heads/master@{#330721}

MessageLoopProxy is deprecated.
This basically does a search and replace:

MessageLoopProxy::current() -> ThreadTaskRunnerHandle::Get().

BUG=391045

Review URL: https://codereview.chromium.org/1126963003

Cr-Commit-Position: refs/heads/master@{#330720}

NOTRY=true
TBR=yurys

Review URL: https://codereview.chromium.org/1143163002

Cr-Commit-Position: refs/heads/master@{#330719}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/26d7fad7..d30001ae

Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1148773002

Cr-Commit-Position: refs/heads/master@{#330718}

WebRTC 9227:9229
Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/6859ada..ead3df8

TBR=
BUG=

Review URL: https://codereview.chromium.org/1143963003

Cr-Commit-Position: refs/heads/master@{#330717}

Expose TemplateURLPrepopulateData::GetCurrentCountryID() to detect that the
user changed the device region in order to update the list of search engine
on iOS.

Note that when a region change is detected we remove all default search
engines except the one selected by the user and then insert all the new
engines. This is possible because user cannot customize search engines,
only select one of the default engines.

BUG=None

Review URL: https://codereview.chromium.org/1130183004

Cr-Commit-Position: refs/heads/master@{#330716}

TEST=browser_tests: *Providers/FileSystemBrowserTest*
BUG=486864

Review URL: https://codereview.chromium.org/1145893002

Cr-Commit-Position: refs/heads/master@{#330715}

BUG=None

Review URL: https://codereview.chromium.org/1123383006

Cr-Commit-Position: refs/heads/master@{#330714}

BUG=420315
TEST=unit test

Review URL: https://codereview.chromium.org/1147563002

Cr-Commit-Position: refs/heads/master@{#330713}

Previously, if the user has never used the app launcher, and it loads
while in a guest mode browser window, the browser would crash. This was
particularly bad because it could happen during startup on Windows, even
without explicitly opening the launcher (due to app list warmup).

Now if the last used profile is the guest profile, just uses the
default.

Added DCHECKs on app list profile loads to ensure they are not guest
profiles.

BUG=468812

Review URL: https://codereview.chromium.org/1106453002

Cr-Commit-Position: refs/heads/master@{#330712}

Before, when entering contracted (gradd 2) braille, backtracking was done
using the chrome.input.ime.deleteSurroundingText API.  This made text entry
visible in the text field immediately.  Unfortunately, some contexts don't
handle programmatic deletion well (Google Docs' editor is an example).

The new approach is to not commit the text ot the edit field until a word
has been entered or a non-braille key is entered. To make the user experience
better for the braille user, entered braille cells are shown on the
display right before the curent selection so that the user gets immediate
feedback when typing on the braille dipslay.

This approach has drawbacks as well. For example, clicking with a mouse
while typing could move focus before the IME has a chance to submit the
in-progress word. The assumption is that this would be less of a
problem in practice then not being able to use grade 2 at all in some
situations.

BUG=392854

Review URL: https://codereview.chromium.org/1039703002

Cr-Commit-Position: refs/heads/master@{#330711}

Review URL: https://codereview.chromium.org/1134003008

Cr-Commit-Position: refs/heads/master@{#330710}

Because I no longer work on code in these directories these days.
Add hashimoto@ to chrome/browser/chromeos/dbus/OWNERS.

BUG=none

Review URL: https://codereview.chromium.org/1144023003

Cr-Commit-Position: refs/heads/master@{#330709}

https://www.chromium.org/developers/coding-style/cpp-dos-and-donts#TOC-Forward-declare-classes-instead-of-including-headers.

Review URL: https://codereview.chromium.org/1135793006

Cr-Commit-Position: refs/heads/master@{#330708}

Currently HWNDMessageHandler::OnSetFocus happens before WM_ACTIVATE is handled in HWNDMessageHandler::OnWndProc().
Root cause: when WM_ACTIVATE comes, in HWNDMessageHandler::OnWndProc(), it will call DefWindowProc() first, which may result in generating WM_SETFOCUS message and call OnWndProc() recursively and therefore OnSetFocus() is called.
After the recursive OnWndProc() returns, PostProcessActivateMessage() is called to handle WM_ACTIVATE.

So DWTHW::HandleNativeFocus() happens before DNWA::HandleActivationChanged().
Therefore, IMB::OnFocus() will get NULL for host_->GetTextInputClient(), which will result in the IMB instance set to the host InputMethod as the focused TextInputClient (which should be the RWHVA).

It would be risky to fix that order in HWNDMessageHandler.
Instead, we can remove the IMB::OnFocus call in DWTHW::HandleNativeFocus() which seems to be redundant, because DNWA::OnWindowFocused() can do the thing, which happens after the top window is activated.

TBR=ananta@chromium.org,sky@chromium.org
BUG=486604
TEST=Verified on local win build.

Review URL: https://codereview.chromium.org/1139623003

Cr-Commit-Position: refs/heads/master@{#330707}

Cr-Commit-Position: refs/heads/master@{#330706}

Disable AutoclickTest.DISABLED_SynthesizedMouseMovesIgnored test on official build since it has been failing for several days.

BUG=489896

Review URL: https://codereview.chromium.org/1124113006

Cr-Commit-Position: refs/heads/master@{#330705}

They should take up the entire screen, and the fullscreen button must
be enabled to allow the user to leave.

This also factors out NSWindowFullscreenNotificationWaiter.

BUG=459877

Review URL: https://codereview.chromium.org/1109493002

Cr-Commit-Position: refs/heads/master@{#330704}

updateAccount() is always called on startup with the signed in account,
so the removePeriodicSync() call will be hit even for already signed in
users when the app restarts.

This change was previously submitted as http://crrev.com/1148613002 but
got reverted due to a bad merge caused by http://crrev.com/1138013008.

BUG=480688

Review URL: https://codereview.chromium.org/1144993002

Cr-Commit-Position: refs/heads/master@{#330703}

BUG=489219,267773

Review URL: https://codereview.chromium.org/1123263005

Cr-Commit-Position: refs/heads/master@{#330702}

BUG=489264
TEST=build/gyp_chromium -Duse_ozone=1

Review URL: https://codereview.chromium.org/1139973005

Cr-Commit-Position: refs/heads/master@{#330701}

Both 'chrome:' and 'chrome-devtools:' are content-level schemes; we
should do their various renderer-side scheme registrations in content
(RenderThreadImpl::RegisterSchemes) rather than in chrome
(ChromeContentRendererClient::RenderThreadStarted).

Patch 1: https://codereview.chromium.org/1143593006
Patch 2: [This patch]
Patch 3: https://codereview.chromium.org/1139053004/

This is a re-land of https://codereview.chromium.org/1137103003/,
which was reverted due to trivial layout test changes.

TBR=jochen@chromium.org,philipj@opera.com,sofbjornf@opera.com,hiroshige@chromium.org
BUG=489672

Review URL: https://codereview.chromium.org/1134303009

Cr-Commit-Position: refs/heads/master@{#330700}

BUG=489751

Review URL: https://codereview.chromium.org/1148703002

Cr-Commit-Position: refs/heads/master@{#330699}

BUG=489751

Review URL: https://codereview.chromium.org/1143013002

Cr-Commit-Position: refs/heads/master@{#330698}

Not supporting file watchers is not an error. It's expected from eg. file
systems exposed via File System Provider API, especially those which are
read only.

TEST=Tested manually that watchers work and there is no spam in the log.
BUG=461735

Review URL: https://codereview.chromium.org/1150473002

Cr-Commit-Position: refs/heads/master@{#330697}

This patch removes the testing IPC from BluetoothDispatcher and
BluetoothDispatcherHost.

This patch also changes the way the mock BluetoothAdapter was set in
BluetoothDispatcherHost. Instead of receiving an IPC to set the adapter,
BluetoothDispatcherHost exposes a function to directly set the adapter.
This function is used by LayoutTestSupport to set the adapter.

Mock adapter flow before:
BlinkTestRunner -> LayoutTestSupport -> BluetoothDispatcher --IPC-->
BluetoothDispatcherHost (Mock constructed here)

After:
BlinkTestRunner --IPC--> LayoutTestMessages(Mock constructed here) ->
LayoutTestSupport -> BluetoothDispatcherHost

This is the first of two patches to remove testing from BluetoothDispatcher
and BluetoothDispatcherHost:

 [1] This patch.
 [2] http://crrev.com/1132943002

BUG=436284

Committed: https://crrev.com/3f7142d0acf5e930743cbe5d754084c464ac3c85
Cr-Commit-Position: refs/heads/master@{#330647}

Review URL: https://codereview.chromium.org/1125133005

Cr-Commit-Position: refs/heads/master@{#330696}

This reverts commit 587bef69.

BUG=485323

Review URL: https://codereview.chromium.org/1143763002

Cr-Commit-Position: refs/heads/master@{#330695}

Target of texStorage2D should be one of GL_TEXTURE_2D, or
GL_TEXTURE_CUBE_MAP.

BUG=429053

Review URL: https://codereview.chromium.org/1146633002

Cr-Commit-Position: refs/heads/master@{#330694}

As any includes present in the related header do not need to be included again in the related cc (i.e., foo.cc can rely on foo.h's includes).

A trivial way to fix these is by removing such an include from the .cc file. So this CL removes all includes from $X.cc files where the $X.h has the same include to confirm to the style guide.

BUG=460988

Review URL: https://codereview.chromium.org/1139323003

Cr-Commit-Position: refs/heads/master@{#330693}

As a result, removes the
NOTIFICATION_RENDERER_V8_HEAP_STATS_COMPUTED notification.

BUG=268984, 487927

Review URL: https://codereview.chromium.org/1081323003

Cr-Commit-Position: refs/heads/master@{#330692}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/cda0078..da030f3

TBR=hiroshige@chromium.org,szager@chromium.org,leviw@chromium.org

Review URL: https://codereview.chromium.org/1148683002

Cr-Commit-Position: refs/heads/master@{#330691}

Some of these files were forked in the initial Mandoline landing. After we forked the application code, we now had two implementations of some of these files. We only need one.

Review URL: https://codereview.chromium.org/1142323003

Cr-Commit-Position: refs/heads/master@{#330690}