- 17 Sep, 2019 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ea5731baa00c..87be585106e6 Created with: gclient setdep -r src-internal@87be585106e6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I544103a452e1168d4e7ca188d8412dd1a185bea9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809445Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#697298}
-
Elly Fong-Jones authored
Before this CL, MenuController's contract required that the provided MenuModel outlived a MenuController instance. As of 10.15, it's impossible to fulfill that contract: AppKit seems to like keeping MenuController instances (via [NSMenuItem target]) alive until the next autorelease pool drain, and there's no way for the C++ code that creates & manages a MenuModel to know when that will happen. See bug 998773 for more details about this change in 10.15. As such, this CL has MenuController hold a WeakPtr to its MenuModel, rather than a raw pointer, and handles the MenuModel being destroyed before the MenuController. One other possible approach would be to make MenuController own the MenuModel, but that would be a very large change to the ownership of MenuModel, and in particular would conflict with the fact that Views (in the //ui/views sense) are often used as MenuModels but are owned by their parent View. Bug: 998835 Change-Id: Ieb3b8928a40d07edf1b9a4d394fb4adc0410fde5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804538Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#697297}
-
John Abd-El-Malek authored
Change-Id: I960dc5baa75a855cb25a05256be3fee0983b6369 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808793 Auto-Submit: John Abd-El-Malek <jam@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#697296}
-
Eric Stevenson authored
This CL was generated by //base/android/jni_generator/jni_refactorer.py. Bug: 929661 Change-Id: Iacac16cd532577f19b26bdea50396d58dcedcce3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809334Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#697295}
-
Paul Moy authored
Now that cros_healthd is moving forward with a new mojo interface in ChromeOS, we need to update Chrome's mojom definitions as well. /var/log/chrome/chrome and make sure the correct sku_number is reported. Bug: b:128683357 Test: build and deploy Chrome for nami with crrev.com/c/1779132, check Change-Id: I1b75c418821c48c8f9bea01e915b5e8cd82d2e4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704947Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Paul Moy <pmoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#697294}
-
Dan Harrington authored
The underlying problem was that RequestCoordinator was reporting that a request had been added, but in fact it was rejected. This led auto-fetch code to believe there was an outstanding request remaining. Bug: 1003053 Change-Id: I5f1554481405ca63a050c119ef624053e58f3acf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801318Reviewed-by:
Peter Williamson <petewil@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#697293}
-
Nazerke authored
New colors, which are only used in tab grid, should be local colors instead of global. This CL is moving |kGridThemeSelectionTintColor| and |kGridThemeDarkSelectionTintColor| to ios/chrome/browser/ui/tab_grid/grid/resources/ from the common semantic colors folder. Bug: 995746 Change-Id: Ia7afebfc21add3466e7e8ad8e94ba9c49659fa8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807193Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Robbie Gibson <rkgibson@google.com> Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Auto-Submit: Nazerke Kalidolda <nazerke@google.com> Cr-Commit-Position: refs/heads/master@{#697292}
-
Boris Sazonov authored
This CL modifies sign-in flow SigninManager to remove the code that shows error dialogs from Google Play services. Now these dialogs are redundant, as Google Play services availability is checked from SystemAccountManagerDelegate.checkCanUseGooglePlayServices, so if there is no usable Google Play services package on the device, then accounts won't be exposed from AccountManagerFacade at all. Bug: 997218 Change-Id: I0ada3b6165387677c33a82b75e23bc38757d2f26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808861 Commit-Queue: Alex Ilin <alexilin@chromium.org> Auto-Submit: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#697291}
-
Eric Stevenson authored
This CL was generated by //base/android/jni_generator/jni_refactorer.py. Bug: 929661 Change-Id: I8da45e352eb54662a5debedbfb394fd7687ac1f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808552 Commit-Queue: Sky Malice <skym@chromium.org> Auto-Submit: Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#697290}
-
Manas Verma authored
When a user, who is opted-in for FIDO auth, attempts to unmask a new card, there will be a CVC check followed by a WebAuthn verification flow. This requires passing along an authorization token received from the GetRealPan response from the CVC unmask. Bug: 949269 Change-Id: Ief8fc1e6e8ccd06622daa77377c5e396c6d2b3e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761656Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Manas Verma <manasverma@google.com> Cr-Commit-Position: refs/heads/master@{#697289}
-
Yusuke Sato authored
ARCVM uses Concierge to throttle crosvm's CPU usage. Unlike session_manager which always outlives Chrome, Concierge may start after Chrome is started. Previously, if SetArcVmCpuRestriction is called before Concierge fully starts, the operation failed with the following errors: ERROR:object_proxy.cc(632)] Failed to call method: org.chromium.VmConcierge.SetVmCpuRestriction: object_path= /org/chromium/VmConcierge: org.freedesktop.DBus.Error.ServiceUnknown: The name org.chromium.VmConcierge was not provided by any .service files ERROR:arc_util.cc(57)] Failed to call SetVmCpuRestriction This CL fixes the error. BUG=b:139095697 TEST=Start ARCVM, verify /var/log/chrome/chrome no longer has the errors. Change-Id: I6e1caf28bbe0307525ee750b3da3008d884435cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808240Reviewed-by:
Yury Khmel <khmel@chromium.org> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#697288}
-
David Tseng authored
Bug: 1002134 Change-Id: If72b6b9a153c249b099fd4307a17ac81f23914b3 Change-Id: If72b6b9a153c249b099fd4307a17ac81f23914b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795575 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#697287}
-
Yusuke Sato authored
Unlike PluginVm's manager, CrostiniManager explicitly starts Concierge via debugd. Since debugd's StartVmConcierge() returns only after the service is ready over dbus, we can safely remove the WaitForServiceToBeAvailable() call for Concierge from CrostiniManager. The current debugd behavior is clearly documented here: https://chromium.googlesource.com/chromiumos/platform2/+/034a6259cd6b7a253c1c79bc7b315b69f8c0325c/debugd/dbus_bindings/org.chromium.debugd.xml#947 ..and the implementation follows that: https://chromium.googlesource.com/chromiumos/platform2/+/034a6259cd6b7a253c1c79bc7b315b69f8c0325c/debugd/src/simple_service_tool.cc#60 BUG=None TEST=Crostini still works Change-Id: I351971b68293f2d3ad175ba2f313266ef3c53935 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808227Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Reviewed-by:
-
Justin Cohen authored
Bots rolled with the following script: git grep -l '11a419c' | xargs sed -i '' -e 's/11a419c/11a420a/g' CIPD packages: infra_internal/ios/xcode/mac 11a420a infra_internal/ios/xcode/ios 11a420a Bug: 1004450 TBR: jbudorick Change-Id: I85da39c6dbe1528524a828cda75733c4f7699d95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804525 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#697285}
-
Imranur Rahman authored
Protected member variables of AutofillPopupRowView is made public. Also, DISALLOW_COPY_AND_ASSIGN is used in AutofillPopupRowView. Bug: 1001633 Signed-off-by:
Imranur Rahman <i.rahman@samsung.com> Change-Id: Ia6e5163b601f01e05a9b9685bcea37c1630684a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798224 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#697284}
-
Evan Stade authored
Bug: none Change-Id: I1aaa220b9631b66f74419c17c2851e51a00886fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808009Reviewed-by:
-
Ce Chen authored
device head suggest model from omaha servier. This will allow us to experiment with different model later. Bug: 925072 Change-Id: I53acf02b6a942cea04197d8fc7f12ac40b7ee3e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807564Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Ce Chen <cch@chromium.org> Cr-Commit-Position: refs/heads/master@{#697282}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a90382fcf675..932a2c0e3bb6 git log a90382fcf675..932a2c0e3bb6 --date=short --no-merges --format='%ad %ae %s' 2019-09-17 halcanary@google.com experimental/minimal_ios_mtl_skia_app 2019-09-17 brianosman@google.com Make SkSL::ByteCodeFunction::preprocess thread-safe Created with: gclient setdep -r src/third_party/skia@932a2c0e3bb6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC brianosman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=brianosman@google.com Bug: None Change-Id: Iae4eca36623b056d10db4b38a80c4e9e9f264b54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808801Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#697281}
-
Manu Cornet authored
Bug: 973481, 973482, 973483 Change-Id: I5e4a521508defaa48a7d62c26ade5d092b112b08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797486Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#697280}
-
Abhijeet Kandalkar authored
This CL converts interface ProducerClient occurrences to uses new Mojo types. Bug: 955171, 978694 Change-Id: I8de6441fdb00205deae283d6328c50afb4952838 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797951Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#697279}
-
Julie Jeongeun Kim authored
This CL converts FeatureManagerPtr and FeatureManagerRequest to new Mojo types. It uses Remote and PendingReceiver instead of FeatureManagerPtr and FeatureManagerRequest. Bug: 955171 Change-Id: I88f7e339768c0aaaafdc43d9ec515e1d4b8e7464 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804710Reviewed-by:
Sean Topping <seantopping@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#697278}
-
Christian Dullweber authored
Tbr: huanzhong@chromium.org Bug: 967668 Change-Id: I5757ac0dda9f33875a08d92a3c1927b3a7d3c3b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808846Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#697277}
-
Henrique Nakashima authored
Bug: 995916 Change-Id: I0a0a14719546f8468d4a25482b3ea162def9508e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774268Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#697276}
-
Doug Turner authored
Bug: 897312 Change-Id: I9061bb8f36ba86d069de08f7ba3823a17bc6c416 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750927Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Doug Turner <dougt@chromium.org> Cr-Commit-Position: refs/heads/master@{#697275}
-
Chris Lu authored
The BadgeView is added as an accessibilityElement when it is added as a subview to LocationBarSteadyView. It is also removed and added back in as a part of showing and hiding the SteadyView when the Omnibox focuses/defocuses. At the beginning the SteadyView is shown, so the BadgeView was being added twice. This change checks if the badgeView is already an a part of the accessibilityElements before adding it. Bug: 1004339 Change-Id: I59d6d7b148260ccbc61e68a1487e56c3bd2a72af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807596Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#697274}
-
Chris Lu authored
The translation team had a hard time limiting it to 15 characters, and it really shouldn't have a limit. Bug: 976901 Change-Id: I14af6189954c7813c3e7e9a738b4458f47f89455 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804456Reviewed-by:
Peter Lee <pkl@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#697273}
-
Martin Kreichgauer authored
This makes the following improvements to the security key settings UI subpage: 1) Label the "PIN" text field in the "Manage sign-in data" and "Enroll fingerprints" dialogs. 2) Add IronA11yAnnouncer support to settings-security-keys-pin-field PIN validation errors. 3) Disable credential management confirm buttons in between asynchronous operations. Bug: 955859 Change-Id: Ie05a237fe24d43a71bc24a89eb9a03d168b349cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808298 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#697272}
-
Lukasz Anforowicz authored
r694827 accidentally dropped a null check in RemoteFrame::Navigate when refactoring CanDisplay / introducing FrameLoadRequest::CanDisplay. This caused a crash when a URL is dragged into a frame that cannot display it. This CL introduces end-to-end regression tests for dropping a URL into a frame (one of them would fail before this CL). The CL reintroduces the null check into RemoteFrame::Navigate - this fixes the crashes. The CL also opportunistically moves when |document_under_mouse_| gets reset to null in DragController::PerformDrag. Before the CL, that field would be reset in all cases *after* PerformDrag finished handling the drag and returns early. Before the CL, that field would also be reset *while* handling a navigational drop and *before* a navigation - this would lead to always passing |nullptr| to NotifyUserActivation. After the CL, the field is reset *after* the navigation. Bug: 1003169, 940068 Change-Id: I15f328a98fc643b76f27d57c6a045547d29b7736 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803903 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
-
Mike Dougherty authored
Bug: 989550 Change-Id: Ib20196500921be1d0c5adc305e5a5eca56132991 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804214Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Eric Noyau <noyau@chromium.org> Commit-Queue: Eric Noyau <noyau@chromium.org> Auto-Submit: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#697270}
-
Lowell Manners authored
Calling EvictFromBackForwardCache() is better than directly deleting the RenderFrameHostImpl, because it matches the behavior when the document is evicted for other reasons (e.g. cache expiration, use of unsupported features). Change-Id: If76feb222b2496fb2431dd20892fd46a1f734bd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809163Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Lowell Manners <lowell@chromium.org> Cr-Commit-Position: refs/heads/master@{#697269}
-
Miyoung Shin authored
This CL converts InputDeviceManager{Ptr, Request} in services and chrome to the new Mojo type. Bug: 955171 Change-Id: Iec61f0adbfc760bc02dfd59ba6243b17df9e2e1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804711Reviewed-by:Colin Blundell <blundell@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#697268}
-
Natalie Chouinard authored
On the Legal Information settings page, in order for the links to share the same activity and correctly display the app icon in the recent apps view, unwrap the context to get the activity context. Bug: 1001485 Change-Id: I9275b837e1b86c0b90a6a6716be8a4295a357d67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807181Reviewed-by:
Patrick Noland <pnoland@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#697267}
-
Junyi Xiao authored
This change only adds an axe test for performance tool landing page Bug: 963183 Change-Id: I583e36a24d53fbb77c495c716876165deba66151 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699133Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Junyi Xiao <juxiao@microsoft.com> Cr-Commit-Position: refs/heads/master@{#697266}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/e1b777717bc9..809198edfff4 git log e1b777717bc9..809198edfff4 --date=short --no-merges --format='%ad %ae %s' 2019-09-17 eshr@google.com Fix minor regression caused by a8336d3 2019-09-17 phoglund@webrtc.org Remove old packet socket factory header. Created with: gclient setdep -r src/third_party/webrtc@809198edfff4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: I9e8741cabc5ce4392c252695ab4dd8cdfd53ff9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809437Reviewed-by:
-
Philip Rogers authored
ExtensionsClient::DoInitialize is still reported as ~2% of renderer startup time according to stack sampled metrics. This patch reduces the size of APIPermissionInfo to reduce malloc. Bug: 847237 Change-Id: Ib7d4a7156734ff84906925fa38174ece58925844 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807717 Auto-Submit: Philip Rogers <pdr@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#697264}
-
Tanmoy Mollik authored
Bug: 1004264 Change-Id: Ic2164a87dc65216cae1ab0943c9a4396623232b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1805667 Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#697263}
-
arthursonzogni authored
Bug: 976218 Change-Id: I08c10155b6f9522fa29d3f0f2af3e86c756d7b26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809306Reviewed-by:
Lowell Manners <lowell@chromium.org> Reviewed-by:
-
Francois Doray authored
This CL verifies that the thread priority is normal when a test process is launched and before/after each test. The goal is to avoid having tests that assume they run at normal priority be disabled because of other misbehaving tests (e.g. https://crbug.com/931706). Bug: 931706 Change-Id: I5ca18b87720b5305285be481f7b60ff5c941a324 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804786 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Auto-Submit: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#697261}
-
Lily Chen authored
This adds a fieldtrial testing config for SameSiteCookieMessages, which turns on the feature CookieDeprecationMessages for all versions 77+. Bug: 966576 Change-Id: Ibe4a83448cc1c2b547970e68de8e6f8b12e8a6e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1802635Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#697260}
-
Will Cassella authored
Since `XRRuntimeManager::GetRuntimeForOptions` returns a non-owning pointer, we can't pipe it all the way from `RequestSession` through `ShowConsentPrompt`, `OnConsentResult`, and `DoRequestSession`. However, we can eliminate the call in `DoRequestSession` (expecting the caller to provide it), and at least pass the ID through to `OnConsentResult` to assert that we receive the same runtime from the call there. Imagine the following scenario: 1) `RequestSession` finds a device, and posts a consent prompt for that device. 2) The device becomes unavailable. 3) The user accepts the consent prompt. 4) `OnConsentResult` selects a different device, and chrome caches consent for it. That's kind of weird, so this CL fixes that scenario. Change-Id: I71385b59f286d3d7c4a78590342eafe716175649 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804688Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Commit-Queue: Will Cassella <cassew@google.com> Cr-Commit-Position: refs/heads/master@{#697259}
-
