GitLab

Configure Views autofill dialogs to be closed when interstitial WebUI
is displayed (e.g. for SSL warnings prior to page load).

BUG=240575

Review URL: https://chromiumcodereview.appspot.com/23493025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221884 0039d316-1c4b-4281-b951-d872f2087c98

Now a reserved name is not allowed on any component of the path.

BUG=none
test=net_unittests

R=asanka@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23464037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221882 0039d316-1c4b-4281-b951-d872f2087c98

Removing one of the events.

BUG=285999

Review URL: https://chromiumcodereview.appspot.com/23449027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221881 0039d316-1c4b-4281-b951-d872f2087c98

The lifetime of the login webui can exceed that of the AppLaunchController,
so we need to do proper cleanup.

BUG=286406

Review URL: https://chromiumcodereview.appspot.com/23967008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221880 0039d316-1c4b-4281-b951-d872f2087c98

Take advantage of the ASYNC variants of the event tracing macros when
tracing model association times.  This makes the model association
tracing much more reliable and easier to read.

BUG=286541

Review URL: https://chromiumcodereview.appspot.com/23907005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221879 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221877 0039d316-1c4b-4281-b951-d872f2087c98

Previously, we were using the windows assets. As is, this is functional,
but will require further patches to get the button spacing correct.

BUG=281788

Review URL: https://chromiumcodereview.appspot.com/23993003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221875 0039d316-1c4b-4281-b951-d872f2087c98

This CL implements DesktopMediaPicker for the Mac used by the Desktop Capture API to present the user with a list of sources (including live thumbnails) to use.

BUG=237907

Review URL: https://chromiumcodereview.appspot.com/23944003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221874 0039d316-1c4b-4281-b951-d872f2087c98

This patch allows both the X11 and the Gtk message-pumps to be built
in a linux-gtk build. A subsequent patch will use the X11 message-pump
for the GPU process, while continue to use the Gtk message-pump for the
browser process.

BUG=145600
R=ccameron@chromium.org, oshima@chromium.org, piman@chromium.org, thakis@chromium.org

Review URL: https://codereview.chromium.org/23880006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221873 0039d316-1c4b-4281-b951-d872f2087c98

Changing the --enable-sctp-data-channels flag to --disable-sctp-data-channels so that SCTP is turned on by default.

BUG=248486

Review URL: https://chromiumcodereview.appspot.com/24042002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221872 0039d316-1c4b-4281-b951-d872f2087c98

Blink trybots don't need to zip build.

TBR=dpranke
BUG=230080

Review URL: https://codereview.chromium.org/23604049

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221871 0039d316-1c4b-4281-b951-d872f2087c98

This removes access of finder_options.output_profile_path from android_browser_backend.

BUG=269131
TEST=trybot

Review URL: https://chromiumcodereview.appspot.com/23466013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221870 0039d316-1c4b-4281-b951-d872f2087c98

Allows java bookmark UIs to update to changes to the underlying model.

BUG=247381

Review URL: https://chromiumcodereview.appspot.com/23849003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221869 0039d316-1c4b-4281-b951-d872f2087c98

-move command logging from http_handler to execute session command
-fix bug where didn't delete thread if session creation failed
-add logging for prefs
-LOG to driver log if on appropriate thread
BUG=none

Review URL: https://chromiumcodereview.appspot.com/23467010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221868 0039d316-1c4b-4281-b951-d872f2087c98

BUG=77656

Review URL: https://chromiumcodereview.appspot.com/23471007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221867 0039d316-1c4b-4281-b951-d872f2087c98

Attaching a file to feedback is crashing the app since we fail on the AttachedFile validate (since we don't actually send blobs over, the attachedFile.data field is always empty, which fails parameter validation on the Chrome side). The easiest way to fix it was to make the parameter optional, since we never read it anyway. It is only there to hold the data so that the feedback custom bindings can move it into attachedFileBlobUrl.

This CL also fixes the sys info, which wasn't being sent due to code that was ported over from the UI incorrectly. The new UI does not need to wait on system information collection, since that is now done via a separate call, making passing around the sys_info variable completely redundant, and in this case wrong.

R=asargent@chromium.org
BUG=285942,285938
TEST=We are able to attach a file and system information with a feedback report.

Review URL: https://chromiumcodereview.appspot.com/23458031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221866 0039d316-1c4b-4281-b951-d872f2087c98

(Windows XP issue should be fixed by usrsctp DEPS roll: https://codereview.chromium.org/23960004/)

BUG=

Review URL: https://chromiumcodereview.appspot.com/23766013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221865 0039d316-1c4b-4281-b951-d872f2087c98

R=asargent@chromium.org
BUG=285413
TEST=Launching feedback in Incognito/Guest mode works and the browser doesn't crash.

Review URL: https://chromiumcodereview.appspot.com/23523033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221864 0039d316-1c4b-4281-b951-d872f2087c98

Depends on: https://codereview.chromium.org/23499006/

R=vandebo
BUG=151701

Review URL: https://chromiumcodereview.appspot.com/23717027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221863 0039d316-1c4b-4281-b951-d872f2087c98

The "loading..." shield on OSX had the currently focused UI element
"shine through" - i.e. the entire dialog was hidden behind it except
for the one focused element.

This change makes the loading screen first responder for the duration
of its visibility, preventing focus rings.

R=sail@chromium.org
BUG=none

Review URL: https://chromiumcodereview.appspot.com/23477044

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221862 0039d316-1c4b-4281-b951-d872f2087c98

Today, PepperFileSystemBrowserHost errnoeously calls Shutdown() on the
FileSystemOperationRunner used by the FileSystemContext it gets.

This is incorrect; other code in Chrome (or another
PepperFileSystemBrowserHost) could be using the same FileSystemOperationRunner,
and its operations will be cancelled.

BUG=225441

Review URL: https://chromiumcodereview.appspot.com/23466012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221861 0039d316-1c4b-4281-b951-d872f2087c98

Rework the way that new actions are logged in the counting policy so
that it properly handles the case where there are duplicate records that
weren't properly coalesced.  (Duplicate records could arise from
clearing URL history, for example.)

This comes at the cost of additional queries--an update always takes 2
queries, instead 1 or 2 as before.  However, benchmarking shows the cost
to be not much different (worst case was ~5% slower, other cases were
indistinguishable or even a bit faster).

BUG=279465

Review URL: https://chromiumcodereview.appspot.com/23907004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221860 0039d316-1c4b-4281-b951-d872f2087c98

DWM was introduced with Windows Vista. DwmFlush seems to be sufficient to warm it up before lowering the token. DWM is required to present to a window with Vista and later and this allows us to do so with the GPU process sandbox enabled.

Enabling the sandbox for this case is not in this patch. Other things are required, such as making the sandbox broker allow certain event objects to be opened from the GPU process.

Review URL: https://chromiumcodereview.appspot.com/23992006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221859 0039d316-1c4b-4281-b951-d872f2087c98

This is one of the top crasher on some samsung devices
https://crash.corp.google.com/search?query=android.media.MediaCodec.flush
Capture some exceptions while we are trying to look into the problem

BUG=278464

Review URL: https://chromiumcodereview.appspot.com/23321004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221858 0039d316-1c4b-4281-b951-d872f2087c98

BUG=282594
TEST=Run ChromeOS with flags:
     --force-fieldtrials="ShowProfileSwitcher/AlwaysShow/"
     --multi-profiles

Review URL: https://chromiumcodereview.appspot.com/23583037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221857 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221856 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=157369:157375&mode=html
TBR=
BUG=

Review URL: https://chromiumcodereview.appspot.com/24054002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221855 0039d316-1c4b-4281-b951-d872f2087c98

Readback doesn't have all its steps synchronized properly with
impl side painting enabled. This patch prevents the readback
commit from being swapped to screen and avoids using non-readback
commits for readback by adding a SynchronousReadbackState.

This patch also gives forced draws due to checkerboarding its
own ForcedReadback state that behaves independently of readback.

Previously readback and forced draws shared drawing mechanisms,
but we want readbacks to occur ASAP while we want forced draws
to occur inline with the normal frame scheduling.

BUG=276082

Review URL: https://chromiumcodereview.appspot.com/23503003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221854 0039d316-1c4b-4281-b951-d872f2087c98

Specifically, AccessibilityEvent.TYPE_WINDOW_CONTENT_CHANGED should
be fired on the appropriate node any time the accessibility tree changes
- previously we were only firing it in a few circumstances. That guarantees
tools like uiautomatorviewer won't see a stale accessibility tree.

BUG=286374

Review URL: https://chromiumcodereview.appspot.com/23481011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221853 0039d316-1c4b-4281-b951-d872f2087c98

See https://codereview.chromium.org/18024002 for a similar example.

Note that this API doesn't work on UNIX, so we still need an in-app method of
opening a new window.

BUG=252881
R=lambroslambrou@chromium.org

Review URL: https://codereview.chromium.org/23536033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221852 0039d316-1c4b-4281-b951-d872f2087c98

BUG=282671

Review URL: https://chromiumcodereview.appspot.com/23890011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221851 0039d316-1c4b-4281-b951-d872f2087c98

Original CL: https://codereview.chromium.org/23522018/

Last CL had a mid-air collision with r221762. It is now merged.

BUG=278913
TBR=asvitkine@chromium.org
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/23857008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221850 0039d316-1c4b-4281-b951-d872f2087c98

This CL:
- adds a seek_label option to media seek action. Seek label is used to name the trace graphs of seek measurements.
- makes element ID the default tracing label.
- adds page level skip_basic_metrics check to media measurements.
- fix buffering_time sec to ms bug.

Review URL: https://chromiumcodereview.appspot.com/23456012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221849 0039d316-1c4b-4281-b951-d872f2087c98

BUG=242589
TEST=existing kiosk tests pass

Review URL: https://chromiumcodereview.appspot.com/23449023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221848 0039d316-1c4b-4281-b951-d872f2087c98

GTK message-pump defines its own observer, but it has the same name as the
message-pump observers used in other platforms. So rename the GTK version
to MessagePumpGdkObserver.

Also, GTK version of message-pump dispatcher is never used, so get rid of
that.

BUG=145600
R=piman@chromium.org, thakis@chromium.org

Review URL: https://codereview.chromium.org/23537016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221846 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=trybot
NOTRY=True

Review URL: https://chromiumcodereview.appspot.com/23935008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221845 0039d316-1c4b-4281-b951-d872f2087c98

Define _GLAPI_NO_EXPORTS for all platforms.

BUG=286467
R=kbr@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23803008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221844 0039d316-1c4b-4281-b951-d872f2087c98

First ensure that main thread offscreen context is created after
on-screen context by keeping count of the number of compositors
that are initialized for hardware draw. Also release the compositor
thread offscreen context when the last compositor releases hardware
draw. Freeing the main thread context is still a TODO.

In software mode, still create StreamTextureFactory, but skip creating
StreamTextureProxy. WebMediaPlayerAndroid already works in this
mode, and it just means in-line video does not work in this case.
But video playback is still successful and user is able to enter fullscreen
to get working playback.

BUG=285349

Review URL: https://chromiumcodereview.appspot.com/23618031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221843 0039d316-1c4b-4281-b951-d872f2087c98

dont_override_profile, profile_type, profile_dir, extra_browser_args, extra_wpr_args moved to browser_options.

BUG=269131
TEST=manual

Review URL: https://chromiumcodereview.appspot.com/23749004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221841 0039d316-1c4b-4281-b951-d872f2087c98

This makes dragging an image to a folder save the contents, rather than
just saving a .url file.

R=sky@chromium.org
BUG=280238

Review URL: https://chromiumcodereview.appspot.com/23591026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221840 0039d316-1c4b-4281-b951-d872f2087c98