GitLab

BUG=543161,561867

Review URL: https://codereview.chromium.org/1640503003

Cr-Commit-Position: refs/heads/master@{#371897}

Layout Tests dump page contents (to compare against expected results).
The dump can include frame contents (i.e. dump as text, dump as markup,
dump scroll positions with extra flavors like dump as printed, dump line
box trees, etc.).  Since renderer process is (for security / by design)
not able to see frame contents of remote frames, it means that old
Layout Tests code is not able to dump frame contents when site isolation
is enabled (i.e. when running with --additional-drt-flag=--site-per-process).

This CL is a step toward making layout tests compatible with site
isolation.  After this CL, if recursing over all frames is required,
then BlinkTestRunner::CaptureDump will ask the browser process for
stiching together the frame contents, before continuing with the other
dump flavors in BlinkTestRunner::OnLayoutDumpCompleted.

The above means testRunner.notifyDone() might no longer perform dumps
synchronously.  This is okay, because:

  - The dumps were already performed asynchronously in some cases:
    - pixel dumps (i.e. see how dumping is resumed after
      BlinkTestRunner::CaptureDumpPixels aka OnPixelsDumpCompleted),
    - ShouldDumpBackForwardList (i.e. see how dumping is resumed after
      BlinkTestRunner::OnSessionHistory),
    - the case where notifyDone is called from a secondary window (i.e.
      see how BlinkTestRunner::TestFinished asks the browser to continue
      in the main window).

  - The synchronous dumps are still performed if the test didn't ask for
    recursing over all the frames.  Retaining the synchronous behavior
    in this case is needed, because in some tests the dump is captured
    while the frame is being detached (and would no longer be present
    after an extra hop to the browser process).

This CL doesn't affect the following dump modes (which for now remain
potentially incompatible with OOPIFs): dump as audio, dump as custom
text, dump pixels, dump back/forward list).  Additionally, setting and
reading of dump modes is done in a renderer process (which can be
incompatible with OOPIFs when testRunner.dumpAsText() and
testRunner.notifyDone() are called in cross-site frames running in
different renderer processes).

BUG=477150
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1589643003

Cr-Commit-Position: refs/heads/master@{#371896}

BUG=551522
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect

Review URL: https://codereview.chromium.org/1641833002

Cr-Commit-Position: refs/heads/master@{#371895}

MenuMessagePumpDispatcher is used on Windows to handle keyboard events
and some other events in menu message loops. In order to have fully
async menus, we need to get rid of it. Instead, we can use
MenuKeyEventHandler which is used on Chrome OS and Linux with some
modifications. Following are messages that are handled in
MenuMessagePumpDispatcher and how they can be handled after removing
this class:

 - WM_KEYDOWN: This will be handled in MenuKeyEventHandler::OnKeyEvent.

 - WM_CHAR: This is used to handle "translated" characters for mnemonics
   according to the active keyboard layout. We can achieve this in
   MenuKeyEventHandler by using event->GetCharacter() instead of
   ui::DomCodeToUsLayoutCharacter().

 - WM_SYSKEYDOWN: This happens when Alt or F10 keys are pressed
   (according to MSDN). We can handle these keys in MenuKeyEventHandler.

 - WM_CANCELMODE: This is already handled in
   ActivationChangeObserverImpl::OnCancelMode() which is used in
   MenuMessageLoopAura.

BUG=564255,566019

Review URL: https://codereview.chromium.org/1625313002

Cr-Commit-Position: refs/heads/master@{#371894}

BUG=141518

Review URL: https://codereview.chromium.org/1645723002

Cr-Commit-Position: refs/heads/master@{#371893}

Crash occurs because we are referencing a member variable left_button_down_on_caption_ after the DefWindowProc call for WM_NCLBUTTONDOWN, which could destroy the window and in
turn the HWNDMessageHandler instance.

Fix is to reset the left_button_down_on_caption_ member before the DefWindowProc call.

BUG=581341
TEST=Covered by views_unittest WidgetTest.DestroyInSysCommandNCLButtonDownOnCaption

Review URL: https://codereview.chromium.org/1636183003

Cr-Commit-Position: refs/heads/master@{#371892}

This is a resubmission of https://codereview.chromium.org/1631313002/.
Since then, the //device/serial dependencies have been fixed.

This tool will also be used by the Chromium trace controller to find
any connected BattOrs.

TBR=zhenw@chromium.org,sky@chromium.org
BUG=542837

Review URL: https://codereview.chromium.org/1642763002

Cr-Commit-Position: refs/heads/master@{#371891}

Summary of changes:
1. Fails QUnit.test() it doesn't return within 5 seconds.
   Timing dependent tests should use fake timers instead.
2. Adds an option to disable the timeout when debugging failed tests
   locally.
3. Logs the current test to the console to ease debugging.

NOTRY=true

Trybots failing on tests that has already been deleted.

Review URL: https://codereview.chromium.org/1638753003

Cr-Commit-Position: refs/heads/master@{#371890}

This is a precurser to deleting tools/telemetry so we don't break the perf
presubmit when that lands.

BUG=478864

Review URL: https://codereview.chromium.org/1646653002

Cr-Commit-Position: refs/heads/master@{#371889}

Revert of [Template Expressions] changing ${ leader to $i18n{ (patchset #4 id:60001 of https://codereview.chromium.org/1585923011/ )

Reason for revert:
broke incognito NTP and chrome://apps
https://code.google.com/p/chromium/issues/detail?id=581621

Original issue's description:
> [Template Expressions] changing ${ leader to $i18n{
>
> This CL changes the Template Expressions from using
> a ${ to identify the start of an expression, to using
> $i18n{.  The intention is to reduce (eliminate) false
> positives when searching for expressions that need
> replacement.  This CL also prepares for the replacement
> work to be done in a background thread and used on a
> broader set of files.
>
> BUG=506009
>
> Committed: https://crrev.com/5aa7fd5f14e49c65ebba87e4248424d622b92930
> Cr-Commit-Position: refs/heads/master@{#371537}

TBR=thakis@chromium.org,dschuyler@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=506009

Review URL: https://codereview.chromium.org/1647583003

Cr-Commit-Position: refs/heads/master@{#371888}

This patch removes a DumpWithoutCrashing call in DoCancel that wasn't particularly useful.

BUG=557430

Review URL: https://codereview.chromium.org/1645513003

Cr-Commit-Position: refs/heads/master@{#371887}

Chromecast executables depend on several shared libraries in $ORIGIN for
platform and OEM abstraction. The rpath for executables should be
updated so that these libraries can be found at runtime. This logic is
added here, instead of //build/config/gcc:executable_ldconfig, to keep
Chromecast-specific configs as concentrated as possible.

A note about security concerns: Chrome only enables this by default for
component and sanitizer builds, never shipped builds. This is to protect
users from arbitrary binaries being run in the shared lib directory.
Chromecast does not share these concerns, as it only runs trusted web
applications in practice.

BUG=516899

Review URL: https://codereview.chromium.org/1639343002

Cr-Commit-Position: refs/heads/master@{#371886}

aura_android.gni no longer needed as Android Aura project has been cancelled.

BUG=NONE

Review URL: https://codereview.chromium.org/1636143002

Cr-Commit-Position: refs/heads/master@{#371885}

TBR=nednguyen@google.com,zhenw@chromium.org

Review URL: https://codereview.chromium.org/1642493004

Cr-Commit-Position: refs/heads/master@{#371884}

Split Geolocation and DeviceOrientation off of OverridesSupport, used them in SensorsView.
Migrated some tests, DeviceSettingsTab and EmulatedDevices to DeviceModeModel.

BUG=540864

Review URL: https://codereview.chromium.org/1631223003

Cr-Commit-Position: refs/heads/master@{#371883}

R=eugenis@chromium.org
BUG=581762

Review URL: https://codereview.chromium.org/1640863002

Cr-Commit-Position: refs/heads/master@{#371882}

Just running the generator caused such changes.  It's better to land them independently.

BUG=
TEST=build
TBR=piman@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/1647663003

Cr-Commit-Position: refs/heads/master@{#371881}

Currently, the logcat monitor can hang if nothing is being output
by logcat after you try to join the recorder thread. Adding a
timeout to join to prevent this.

BUG=581352

Review URL: https://codereview.chromium.org/1648443002

Cr-Commit-Position: refs/heads/master@{#371880}

RenderPassDrawQuad::MaskUVRect() computes the UV rect by scaling
the quad->rect() by mask_uv_scale, then dividing by quad->rect size.
However, RenderSurfaceImpl::AppendQuads() computes the mask UV scale
as quad->rect() size / mask size. So let's just take the quad->rect() size
out of mask_uv_scale in the first place, so we don't have to divide
it back out in MaskUVRect().

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1647573002

Cr-Commit-Position: refs/heads/master@{#371879}

TBR=pfeldman

BUG=581468

Review URL: https://codereview.chromium.org/1640603003

Cr-Commit-Position: refs/heads/master@{#371878}

Two cases:
1. Device(s) discovered already. No user visible changes.
2. No device(s) discoverd. Show "No bluetooth devices found. Search again"
   text. https://folio.googleplex.com/chrome-ux/mocks/236-fizz/choosers/032515_ChooserPhone#%2F03_NoneAfterTimeOut.jpg

BUG=539607

Review URL: https://codereview.chromium.org/1625633004

Cr-Commit-Position: refs/heads/master@{#371877}

This is a precursor to deleting tools/telemetry so we don't break the gpu tests
presubmit when that lands.

BUG=478864

Review URL: https://codereview.chromium.org/1644723002

Cr-Commit-Position: refs/heads/master@{#371876}

Without this change when system_libdir is set (e.g.
to lib64) it would apply this to all toolchains
including the host toolchain.

Review URL: https://codereview.chromium.org/1583093002

Cr-Commit-Position: refs/heads/master@{#371875}

Record replacementRange from setMarkedText: event, then send along with
next ImeSetComposition message.

BUG=460999

Review URL: https://codereview.chromium.org/1635953002

Cr-Commit-Position: refs/heads/master@{#371874}

NativeWidgetMus sets up the context-factory for the WindowTreeHostMus,
and so WindowTreeHostMus doesn't need to know about the surface-type.

BUG=none

Review URL: https://codereview.chromium.org/1647483002

Cr-Commit-Position: refs/heads/master@{#371873}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/fefcc888..778c5a60

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1639423002

Cr-Commit-Position: refs/heads/master@{#371872}

Direct copy-paste, no changes.

BUG=533681
TBR=erikchen

Review URL: https://codereview.chromium.org/1647523002

Cr-Commit-Position: refs/heads/master@{#371871}

Extracts the existing MediaSession usage from the browser media
player manager and moves it into the WebMediaPlayerDelegate where
it can be shared by both the desktop and android media players.

Notes:
- Removes RenderFrameObserver from all WebMediaPlayers since the
delegate observer interface handles all of their needs.
- The MediaStream WebMediaPlayer now has MediaSession support.
- Currently the WMPI has no concept of requesting permission to
play, the WMPA behavior has been preserved via a request to the
MediaWebContentsObserverAndroid from BrowserMediaPlayerManager.
- Fixes flakiness issues with the MediaSession tests which were
not completely waiting for playback to start before moving on
with test expectations.
- Extracts misplaced delegate messages from frame_messages.h and
puts them in their own media_player_delegate_messages.h file.
- During the message move, cleans up the player_cookie (a int64_t
pointer) in favor of a plain int. Renames messages for the better.
- Removes all delegate calls from the cast adapter since they are
always remote type which should be ignored anyways.
- |has_audio| is sticky in the MediaSessionController since WMPA
can't be relied upon to provide a true value and plumbing the
value from every MediaPlayerAndroid is non-trivial.
- Fixes MediaSession ContentShellTests which were passing on the
bots by happy circumstance -- the bots do not appear able to play
the .ogg files checked in -- instead instantly ending. Test were fixed
by adding .mp3 variants.

BUG=529887, 580626
TEST=new tests, existing MediaSession tests pass with and without
the unified media pipeline flag, manual verification of background
behavior.

Review URL: https://codereview.chromium.org/1570043002

Cr-Commit-Position: refs/heads/master@{#371870}

BUG=581758

Review URL: https://codereview.chromium.org/1640843002

Cr-Commit-Position: refs/heads/master@{#371869}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/4c5aff546a57..fd3f2b38d1fb

$ git log 4c5aff546..fd3f2b38d --date=short --no-merges --format='%ad %ae %s'

CQ_INCLUDE_TRYBOTS=
TBR=catapult-sheriff@chromium.org

Review URL: https://codereview.chromium.org/1639403003

Cr-Commit-Position: refs/heads/master@{#371868}

When determining what field type to upload, if both PHONE_HOME_CITY_AND_NUMBER and PHONE_HOME_WHOLE_NUMBER are matched, it means there is no country code in the profile's phone number. In that case, only match PHONE_HOME_CITY_AND_NUMBER because it's more precise.

BUG=580629
TEST=AutofillManagerTest

Review URL: https://codereview.chromium.org/1623803002

Cr-Commit-Position: refs/heads/master@{#371867}

Fork Shelf View, Model, Button, TooltipManager, etc.
These provide a baseline of ash/shelf-like functionality.
(show open mash windows, support reordering, tooltips, etc.)

Restructure some ownership patterns (eg. shelf owns model).
Minimal code refactoring, removal and commenting.
(attempt to minimize diff, keep/stub some features)

TODO: Restore missing functionality/tests.

BUG=557406
TEST=mojo:mash_shell's shelf starts looking more like ash.
R=sky@chromium.org,bungeman@google.com

Review URL: https://codereview.chromium.org/1585363002

Cr-Commit-Position: refs/heads/master@{#371866}

This removes all the PLUGIN_PRINTF/MODULE_PRINTF calls from
components/nacl/renderer/plugin/.

There aren't very many of these logging calls left now.  They don't
look useful to have in release binaries, and it's against Chromium
style to keep this sort of logging in the code.  Anyone doing
debugging can manually add their own logging.

My main motivation here is to remove a non-standard logging mechanism
that depends on some native_client/ headers.

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=2832
TEST=e.g. NaClBrowserTestPnacl.PPAPICore (tests PNaCl translation)

Review URL: https://codereview.chromium.org/1631413002

Cr-Commit-Position: refs/heads/master@{#371865}

BUG=493459

Review URL: https://codereview.chromium.org/1641783002

Cr-Commit-Position: refs/heads/master@{#371864}

Revert of mojo filesystem: Simplify full file reading/writing. (patchset #5 id:80001 of https://codereview.chromium.org/1634293002/ )

Reason for revert:
Broke the Windows build.

https://build.chromium.org/p/chromium.win/builders/Win%20x64%20GN/builds/10430/steps/compile/logs/stdio

FAILED: ninja -t msvc -e environment.x64 -- E:\b\build\goma/gomacc.exe "E:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64/cl.exe" /nologo /showIncludes /FC @obj/components/filesystem/lib/directory_impl.obj.rsp /c ../../components/filesystem/directory_impl.cc /Foobj/components/filesystem/lib/directory_impl.obj /Fdobj/components/filesystem/lib_cc.pdb
e:\b\build\slave\win_x64_gn\build\src\components\filesystem\directory_impl.cc(274) : error C2220: warning treated as error - no 'object' file generated
e:\b\build\slave\win_x64_gn\build\src\components\filesystem\directory_impl.cc(274) : warning C4267: 'argument' : conversion from 'size_t' to 'int', possible loss of data
ninja: build stopped: subcommand failed.

Original issue's description:
> mojo filesystem: Simplify full file reading/writing.
>
> One common pattern that's coming up multiple times is that we want to
> read or write the full contents of a file. The first attempt at an
> interface to that had was put on the File object.
>
> However, file seeking behaviour differs between platforms. Performing a
> seek on an empty file is safe on posix and errors on Windows. And when
> dealing with arbitrary File objects, we want to seek to the beginning
> just in case there was any previous usage on the File object.
>
> It was also cumbersome. The user was still responsible for opening the
> file and closing it once they were done with it. Putting these
> operations on Directory not only removes a bug, but also simplifies the
> interface.
>
> BUG=557405
>
> Committed: https://crrev.com/fd918ae590f61f145d75c800abb8eb050ca32b06
> Cr-Commit-Position: refs/heads/master@{#371845}

TBR=sky@chromium.org,erg@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=557405

Review URL: https://codereview.chromium.org/1643733002

Cr-Commit-Position: refs/heads/master@{#371863}

BUG=

Review URL: https://codereview.chromium.org/1634423002

Cr-Commit-Position: refs/heads/master@{#371862}

https://chromium.googlesource.com/skia.git/+log/ccfdaa5f2aee..2bbc343c1482

$ git log ccfdaa5f2..2bbc343c1 --date=short --no-merges --format='%ad %ae %s'
2016-01-27 ethannicholas switched to SkJSONCPP for JSON output GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1639333002
2016-01-27 yujieqin Fix Windows build
2016-01-27 scroggo Stop testing SkImageDecoder in DM/nanobench
2016-01-27 yujieqin Enable RAW codec for Windows
2016-01-27 ebrauer It derives the dng_host and overrides PerformAreaTask() to split the task into several sub-tasks which get added to SkTaskGroup.
2016-01-27 yujieqin Fix complier issue [-Werror, -Wvla]

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=msarett@google.com

Review URL: https://codereview.chromium.org/1640353002

Cr-Commit-Position: refs/heads/master@{#371861}

In some cases this could save a copy of the outer object
(rareNonInheritedData in all cases.)
This also saves almost 3.5k of binary footprint.

BUG=581413

Review URL: https://codereview.chromium.org/1638213004

Cr-Commit-Position: refs/heads/master@{#371860}

- update ProgramPath to obtain program path on Windows

R=aizatsky@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1635793002

Cr-Commit-Position: refs/heads/master@{#371859}

Daemon and desktop processes didn't have attachment brokers, and so the
desktop process was failing when trying to pass shared buffer to the
network process.

BUG=581174

Review URL: https://codereview.chromium.org/1634933007

Cr-Commit-Position: refs/heads/master@{#371858}