- 16 Sep, 2020 24 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/3f01e83f96b0..0063ad80f210 2020-09-15 johnchen@chromium.org [Catapult] Fix links in README.md. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC zhanliang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: zhanliang@google.com Change-Id: I32aad8bd9e09cc06d1ad75d01e755518d9e25a54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412962Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#807281}
-
Jeremie Boulic authored
ConvertPathToArcUrl rewrites file paths into URLs that can be resolved from ARC++. Tested manually that: - a .pdf file located within a ZIP file mounted with fuse-zip can be opened with an Android app (Adobe Acrobat). - The 'Share' button is functional. - Similar test for RAR files mounted with rar2fs. Bug: 912236 Test: Manual test mentioned above Change-Id: I62cdf2feee4ec535f579d470f0909c6593144c0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411987Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
François Degros <fdegros@chromium.org> Commit-Queue: François Degros <fdegros@chromium.org> Cr-Commit-Position: refs/heads/master@{#807280}
-
Jimmy Gong authored
Bug: 1106937 Change-Id: Ic2d5bf232dee7c12e3a207140b0824fc4c389fea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2407076 Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#807279}
-
Haiyang Pan authored
This reverts commit 37dea4b3. Reason for revert: Likely caused the test failure of DownloadTest#testDuplicateHttpPostDownload_Cancel__UseDownloadOfflineContentProviderEnabled in android builders since: * https://ci.chromium.org/p/chromium/builders/ci/android-marshmallow-x86-rel-non-cq/52 * https://ci.chromium.org/p/chromium/builders/ci/Lollipop%20Phone%20Tester/26965 Original change's description: > Update message in permission dialog overlay warning > > The current overlay warning message does not directly address the > typical case: when dialer or chat bubble is displayed on the screen. > > One change in behavior is that "Cancel" button of overlay warning dialog > dismisses both overlay warning and permission dialog. > > BUG=1127455 > R=twellington@chromium.org > > Change-Id: I9d5c13a6c7d4e52a3fa73b3193d1ef463272ab64 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406148 > Reviewed-by: Theresa <twellington@chromium.org> > Reviewed-by: Andy Paicu <andypaicu@chromium.org> > Commit-Queue: Pavel Yatsuk <pavely@chromium.org> > Cr-Commit-Position: refs/heads/master@{#807089} TBR=pavely@chromium.org,twellington@chromium.org,andypaicu@chromium.org Change-Id: I6ebee34a6bb6383b7ff58782608b81d0ec6d5cbb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1127455 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412836Reviewed-by:
Haiyang Pan <hypan@google.com> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#807278}
-
Ken Rockot authored
All typemap files have been converted to inlined GN target configuration. This removes all support for aggregating .typemap files at buildgen time and any associated build logic needed to process those files. Fixed: 1059389 Change-Id: Iabf8b8680d3bd9c9e310830c36a01c1c8ca5c389 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2408274 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#807277}
-
Max Curran authored
These new classes will eventually be used to log UKM and UMA metrics related to Translate at the end of each page load. For now the classes are just skeletons with the key timings added. Design Doc with more details: https://docs.google.com/document/d/1dyWh1Xw5VgUA00VA-5PTgKQ6ItziPBnSyeDR8saJ9vM/edit Bug: 1114868 Change-Id: Ie03b807124b8cf0d44f22665978c67bfd51a4e72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360499 Commit-Queue: Max Curran <curranmax@chromium.org> Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Auto-Submit: Max Curran <curranmax@chromium.org> Cr-Commit-Position: refs/heads/master@{#807276}
-
Haiyang Pan authored
This moves 3 shards from content_browsertests to network_service_out_of_process_content_browsertests which hopefully can mitigate the timeout issue for the latter test suite Bug: 1119314 Change-Id: Ia2d2ea767840ce9effa941886c55882b5a371b2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411473 Auto-Submit: Haiyang Pan <hypan@google.com> Reviewed-by:
benjamin joyce <bjoyce@chromium.org> Commit-Queue: benjamin joyce <bjoyce@chromium.org> Cr-Commit-Position: refs/heads/master@{#807275}
-
Chris Lu authored
Bug: 1107489 Change-Id: I10117e30eaf019fec202b05958af17b38133cdf8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412786 Auto-Submit: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#807274}
-
James Hawkins authored
R=khorimoto@chromium.org Bug: 1045266 Test: NetworkComponentsNetworkProxyTest* Change-Id: I500d1455da3ecfcb3c53c8477db539eb353e88b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412969 Commit-Queue: James Hawkins <jhawkins@chromium.org> Reviewed-by:
-
chrome://multidevice-internalsRegan Hsu authored
Allows user to input fake PhoneHub notification data, and for notifications to eventually display via FakeNotificationManager. User can send, update, delete, and view a list of notifications. This CL also cleans up some of the other phonehub forms in chrome://multidevice-internals. Screenshots: https://screenshot.googleplex.com/9XNVYwEeAQUZeWG Disabled Send button https://screenshot.googleplex.com/4nz5PaMH8bfLbdR Enabled Send button https://screenshot.googleplex.com/AUsqtxMgJwMwHBs Sent notification https://screenshot.googleplex.com/5nCmMZW6xcviatK Updated! UI https://screenshot.googleplex.com/3fnNdKZcFDCWgcL Multiple notifications https://screenshot.googleplex.com/86y2Mqa2C8AmZSP Unique id & inline id Bug: 1106937 Change-Id: Ie5aecd70a03b6e84aa8745a2ece421e0d8086970 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411546 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
-
Robert Ma authored
base.Port has some constants that need to be updated when e.g. concrete ports get new versions, which is easy to forget. Add unit tests to catch this and fix two existing issues (a typo and a missing version). Change-Id: I17dba9c47b8cc7fd345ccf104a482265f5ae0ae7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412368 Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Auto-Submit: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#807271}
-
Ken Rockot authored
The typemap configurations are merged into their respective mojom target definitions. Bug: 1059389 Change-Id: Id6822c500f9257fb2288f83d8173653a35474538 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2408272 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#807270}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7e0dbae74fcd..c52a95b75bb2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC davidbienvenu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: davidbienvenu@google.com Change-Id: Iafd23551befb8e41b44c08d79684e229e1fc7d7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412958Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#807269}
-
Dirk Pranke authored
The `resource_sizes_lacros_chrome` entry in //testing/buildbot/gn_isolate_map.pyl added a `script` parameter, which is no longer legal. Unfortunately, this is only checked when the target is actually used, which means that we didn't notice the problem for a few days because no one was looking at that bot over the weekend. Bug: 1128390 NoTry: true Change-Id: I079c1f3c5c81ae6ea8ae5600ce7ef9c30ac4f461 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410290 Commit-Queue: Dirk Pranke <dpranke@google.com> Reviewed-by:
Dirk Pranke <dpranke@google.com> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#807268}
-
Anastasia Helfinstein authored
Force all Switch Access nodes to identify the automation node they are associated with, defined to be the node that most closely contains all parts of the SAChildNode or SARootNode. This refactor has no side effects other than implicitly changing some debug strings. AX-Relnotes: n/a. Bug: None Change-Id: I3bb7c9dfe6866a1676af3b32ce0e580f4e134ad4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389048Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#807267}
-
Natalie Chouinard authored
Add timing and success/failure metrics to the browser-side implementation of AndroidFontLookup. These will be used to monitor for unexpected failures, and determine whether additional caching may be necessary to meet expected timing thresholds. Bug: 1127478 Change-Id: Ife135a0628a89779f82da6adf1a1ce1a9b7513ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406546 Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#807266}
-
Wei Li authored
Change text_box() function name to GetVisiblePromptField() so the name make it explicit that the field will only be returned when it is visible. Also the name will be consistent with the setter's name. The other two APIs GetInputText() and IsCheckBoxSelected() are ok given the default value of those invisible fields. This CL adds visibility checking and tests to make these APIs clearer. Bug: 1126997 Change-Id: I5d26b5daba0e8955c6491f980ca8ad57d0566176 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412508Reviewed-by:
-
Matt Wolenetz authored
Updates MediaSource and SourceBuffer to consult the MediaSourceAttachmentSupplement to obtain state information about the attached media element, instead of directly asking the element. Updates the SameThreadMediaSourceAttachment implementation to directly consult the element. The state information pumped from the media element is mostly ignored, except: 1) the contexts' destruction is verified to not have occurred already (since in same-thread attachments, the caller would also have been destructed already), 2) the error state of the media element is verified to match the synchronous retrieval (since in same-thread attachments, any update to the element error should also include pumping that to the attachment already),and 3) debug logs emit both the pumped and synchronous time information for comparison. Also includes notification of the attachment supplement when the media source execution context is destroyed. This will be useful especially in later prevention of UAF in a cross-thread attachment implementation. Later changes that add cross-thread attachment support (in a distinct "CrossThreadMediaSourceAttachment" implementation of a MediaSourceAttachment) will instead use the pumped information provided by the media element, to reduce latency and blocking, and to ensure safety/prevent UAF if either context has been destroyed. BUG=878133 Change-Id: Ia8d31c51d21d44552f2a92b76f67d33e164f774c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401808 Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Reviewed-by:
Will Cassella <cassew@google.com> Cr-Commit-Position: refs/heads/master@{#807264}
-
Peter McNeeley authored
Currently the build flag for the ozone platform DRM is actually ozone_platform_gbm. This change renames this flag to ozone_platform_drm in a backwards compatible way. This change will also require changes to third_party in order to support the deprecation of the old flag. (see https://crbug.com/1122010) The final act of this rename will be to remove the old flag. (See https://crbug.com/1122010) R=brucedawson@chromium.org, penghuang@chromium.org, rjkroege@chromium.org Bug: 1116466 Change-Id: I481edf07290eb27b011aede08de40e4210a52834 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373181Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Peter McNeeley <petermcneeley@chromium.org> Auto-Submit: Peter McNeeley <petermcneeley@chromium.org> Cr-Commit-Position: refs/heads/master@{#807263}
-
David Bokan authored
Root scroller assumes that if a LayoutBox is scrollable it must have an associated Node. However, there are some edge cases where an anonymous LayoutBox is created, such as for overflowing <input> and <fieldset> controls. To be strictly correct, we could make root scroller work in these cases but it's not likely to be useful in any use cases. It'd also be non-trivial work to fix root scroller machinery - for example, "is root scroller" bits are currently cached on the Node's LayoutBox rather than on the LayoutBoxForScrolling. Instead, we'll simply ignore these cases to avoid crashing. Bug: 1125621 Change-Id: I92880f4430aaa4a4b67d9bdf1ebed2e8dada7d9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411396 Auto-Submit: David Bokan <bokan@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#807262}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a195d101f96c..9791e50e3da4 2020-09-15 mtklein@google.com impl q14x2 ops in interpreter 2020-09-15 mtklein@google.com make skvx::if_then_else work at byte granularity 2020-09-15 michaelludwig@google.com Fully disable CCPR for unit test 2020-09-15 bsalomon@google.com SkYUVAPixmaps::toLegacy() init unused mapping for missing alpha channel 2020-09-15 csmartdalton@google.com Relax SkStrokeRec::hasEqualEffect If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: scroggo@google.com Change-Id: Ia6e3e9a223dde22c9fcef7c5a00149e8336e24db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412957Reviewed-by:
-
David Vallet authored
Bug: 1124062 Change-Id: I549503bf2ae09c30260133c48af304923bba0996 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409884 Commit-Queue: David Vallet <dvallet@chromium.org> Reviewed-by:
David Vallet <dvallet@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#807260}
-
Trent Apted authored
The AppService presents itself to the system differently in these profile configurations, which has resulted in subtle crashes. This CL configures SystemWebAppManagerBrowserTest with a third gtest parameter type. It "defaults" to TestProfileType::kRegular and establishes a way for system apps to neatly specify a set of their tests that should have coverage for all profile types. Bespoke tests for the HelpApp are migrated to this setup, and a subset of pertinent MediaApp tests are parameterised for profiles. Verified the desired coverage is satisfied by commenting out code in web_file_tasks.cc that fixed things that have crashed in the past. E.g. Unconditionally doing `profile = profile->GetOriginalProfile()` causes 6 of the guest mode tests to crash, and omitting that completely causes DCHECK(..IsAppServiceAvailableForProfile) to fail for the incognito tests. Bug: b/166730281 Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Change-Id: I22e7062eab0d4d21329602ec27afba89197e7c16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398450Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Rachel Carpenter <carpenterr@chromium.org> Reviewed-by:
Jiewei Qian <qjw@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#807259}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: Ie5acaacba6fc481453923281172dc836aea51b2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412949Reviewed-by:
-
- 15 Sep, 2020 16 commits
-
-
Alec Douglas authored
This commit makes explicit the nullability of the ControlContainer passed through the Chrome compositor classes. There is already null-checking present throughout, but the @Nullable annotation has been added to make things more clear. This also removes a recently added assert that the ControlContainer must be non-null (added in 144fcec9). There is an existing assert in BrowserControlsManager that checks that the ControlContainer is either non-null OR its position is NONE. cr https://code.amazon.com/reviews/CR-33223034 Bug: 1127053 Change-Id: I214f134c710a535970005e585f073bca9ad313f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404375Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#807257}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/986e74510613..ae073e44336f 2020-09-15 mbonadei@webrtc.org Clobber iOS builders. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Id3130789251670e672018b821930f17501e986e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412953Reviewed-by:
-
David Vallet authored
Bug: 1124062 Change-Id: Ifddf4d3c0f3eb4ec60b0364bf129ba33313bd8c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404282Reviewed-by:
-
Peng Huang authored
Bug: 1128175 Change-Id: Id9ad4f95dde6131fbf5e3754ee2eaa786d54e363 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412187 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#807254}
-
Robert Ma authored
With necessary changes to make Mojo lite bindings available in WPT: * Release mojo/public/mojom/base/*.mojom*.js (mojo_bindings_lite.js was already released). * Add an optional `lite` param to loadMojoResources(). Fixed: 1123987, 1126628 Change-Id: I35d37aa848e7a6333e6185450280c44afd6438c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410676Reviewed-by:
Michael Moss <mmoss@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#807253}
-
Clark DuVall authored
This enables WebLayer in a split in WebView bundles in canary. I tested on L-Q and ran all instrumentation tests on P with this setup. Bug: 1105096 Change-Id: I517bce4109531108a4fb3af64a87aa1f5d2a91bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412705Reviewed-by:
-
Ben Pastene authored
As outlined in https://bugs.chromium.org/p/chromium/issues/detail?id=1111436#c17 Bug: 1111436 Change-Id: I8e652b731de9de83bbde1a0acb54e5bf3093519f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2349928 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
Erik Staab <estaab@chromium.org> Cr-Commit-Position: refs/heads/master@{#807251}
-
Kyle Milka authored
Wrap the contents of the share sheet in a ScrollView so it can be scrolled if it doesn't all fit in the viewport. Bug: 1127249 Change-Id: Id86b92a52f93b107842f9ddb679537afdec75306 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410310 Commit-Queue: Kyle Milka <kmilka@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#807250}
-
Sadrul Habib Chowdhury authored
The 'SmoothnessDroppedFrame' trace event is reported every time an animation or scroll/pinch ends. The trace-event includes how many vsyncs the page was visible for, and how many dropped frames affected the smoothness during this time. BUG=1125152 Change-Id: I87e5668bd43911f2e66c27b0a4d04b7ed016e5f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378784 Auto-Submit: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#807249}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/dd48130b2905..52fdd1ffcefb 2020-09-15 miladfar@ca.ibm.com Adding AIX If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC apolito@google.com,ehmaldonado@google.com,sokcevic@google.com,ajp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: apolito@google.com,ehmaldonado@google.com,sokcevic@google.com,ajp@google.com Change-Id: I63f752040c060a10345a36da0800e212378170b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412952Reviewed-by:
-
Morten Stenshorne authored
This reverts commit 07caa42f. Reason for revert: Performance regression. crbug.com/1128152 Original change's description: > [TextAutosizer] Recalculate inline-size before layout on font size change. > > If the inline-size is deduced from the min/max size somehow (e.g. > shrink-to-fit), a font size change may change the intrinsic (min/max) > sizes, which in turn may affect the inline-size of the element. > > Additionally, we need to make sure that we actually DO recalculate the > intrinsic size of all elements affected by a font size change. > > Note that this bug also exists in the legacy layout engine, but this CL > doesn't address that. > > Bug: 1125109 > Change-Id: Ibb33648fcb9bc6c9061d95e42b7f3c4db7b1bd90 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404847 > Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> > Reviewed-by: Philip Rogers <pdr@chromium.org> > Commit-Queue: Morten Stenshorne <mstensho@chromium.org> > Cr-Commit-Position: refs/heads/master@{#806263} TBR=pdr@chromium.org,ikilpatrick@chromium.org,mstensho@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1125109, 1128152 Change-Id: Iad4e987046a1b9c1f289089ca6997775e47f494f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411942Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#807247}
-
chinsenj authored
In app list, the rename textfield is inconsistent with other renaming patterns. This CL aims to make it consistent and improve it as well. It makes the following changes: - Change background color on hover. - Change size of name textfield. - Add border when name textfield is focused. - When text field is pressed, highlight all text rather than position cursor. - Changes underlying view width from max width to variable length, depending on size of current folder name. Test: Manual Bug: 1127498 Change-Id: I78727116737acdc261419255e3b8b132f79c3313 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406281Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Jeremy Chinsen <chinsenj@chromium.org> Cr-Commit-Position: refs/heads/master@{#807246}
-
Matt Wolenetz authored
To facilitate implementation cleanup of the interaction between MSE API and the HTMLMediaElement, and also to make subsequent support changes in the MSE API to enable cross-thread function, this change updates HTMLMediaElement to, when attached to a MediaSource: 1) Notify the attachment upon updates to the notion of currentTime. This is necessary for continued proper function without behavior change of the pre-existing implementation of the MSE SourceBuffer coded frame eviction algorithm's eviction range selection heuristic, which attempts to preserve buffered media around the current playhead, or around the seek target. 2) Notify the attachment upon transition of the media element to having a non-null error attribute. This is necessary for continued proper function without behavior change of the pre-existing implementation of the MSE SourceBuffer Prepare Append Algorithm. 3) Notify the attachment upon media element receipt of context destruction notification. In later changes, this will enable protection against UAF of the element-owned webmediaplayer-owned MSE ChunkDemuxer when the element's context outlives the attached worker-context MediaSource. These changes simply notify these bits of information, with a minimal implementation change in the concrete attachment implementation in modules/mediasource. Later modules/mediasource changes to the attachment and media source implementations will actually use this information in at least a cross-thread attachment variant, instead of synchronously querying the media element directly. Note that a same-thread attachment variant may ignore this information and directly consult the media element to ensure no regression of existing same-thread MSE behavior. This change also includes a minimal piece that removes the unused MediaSourceAttachment::IsClosed() interface method. BUG=878133 Change-Id: I91950fdcc916144c82744bfb63382b66fb33b392 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391934 Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#807245}
-
Ken Rockot authored
This merges all remaining typemap configs in //content into their respective mojom target definitions. Bug: 1059389 Change-Id: Ieeb43ce49ff4bdb2a0c4b95965f374dcca73bc3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2407928 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#807244}
-
Elly Fong-Jones authored
This test needs a case for what clang does on Mac Arm64, so add that. Bug: 1128436,1121871 Change-Id: I5d57f99f7d041bc91d9fc862c1d10ddc1b48f540 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412552 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#807243}
-
Anastasia Helfinstein authored
Instead of iterating through the array to make a copy, use the ES6 spread operator. AX-Relnotes: n/a. Bug: None. Change-Id: Ia0e1a8d738c5c9480bf991ba9de4a50bb4fca482 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391506 Auto-Submit: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
-
