- 09 Jun, 2020 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/91286aa462fa..86d91fc0ded9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC xidachen@google.com,dimich@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:985590 Tbr: xidachen@google.com,dimich@google.com Change-Id: Ic10a610da4073eeed4b66014c855d4eab68ead84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237878Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#776622}
-
Frank Liberato authored
Bug: 1088908, 1088910, 1075628, 1075627 Change-Id: I9fc93989bb727b37e08441fd0cd43a20fc1fd9a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236250 Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Auto-Submit: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#776621}
-
Mikhail Khokhlov authored
Adds support for internal-only files in binary_deps_manager. Adds a script to convert device power profiles to SQL script and upload it to the internal cloud bucket. Bug: b/158459921 Change-Id: I9c3fd954bae350497cdf366ce856794b78835b0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235617Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Cr-Commit-Position: refs/heads/master@{#776620}
-
Sergey Poromov authored
Update the Chrome OS-only strings according to https://docs.google.com/document/d/17ZQF59-5Quw542S9SlnCkFfp8a100ZU2Pn5NOZqyJrE/edit?usp=sharing Include 3 changes: 1) Show filename instead of "Scan complete, no issues identified" for the case of successful scans, so it looks like a normal download. 2) Change all the strings for notification while scanning, so it's: Scanning <filename> In progress Checking with your organization's security policies. https://drive.google.com/open?id=1S6J03NbR-3Uv6MDlRse5SwjmC-fi3rPT 3) Show reason for downloads blocked due to large size or being encrypted. Bug: 1081203 Bug: b/153456225 Change-Id: I3c7e59e3a0a7cae0ce2a105f3dfac422a2fc30a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230467Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#776619}
-
Nathan Zabriskie authored
In OOPR Canvas2D we no longer have access to Skia in the client process. We need to update CanvasResourceProvider::Clear to not access SkCanvas in the case of OOPR. A more ideal fix is tracked in https://crbug.com/1090081 but simply ignoring it is fine for now as OOPR automatically handles clearing the canvas during initialization. Bug: 1090083 Change-Id: I5fb75e4fac312ec00b8e5215d3756219672461ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236193 Commit-Queue: Nathan Zabriskie <nazabris@microsoft.com> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#776618}
-
Xida Chen authored
TBR=dimich@chromium.org NOTRY=true Bug: 1073052 Change-Id: I69e19ecfe2edb3facfb5950585b3d754b71f58c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238586Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#776617}
-
Denis Kuznetsov authored
Fixed: 1071778 Bug: 856310 Change-Id: I3c4d0beb18a81edff017fc51159d05d214f4f1d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2195243 Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#776616}
-
evliu authored
This CL blocklists a hardcoded list of websites from the using the Live Caption feature because those frequently visited websites contain their own captions. This blocklist is temporary and is intended to reduce the usage of the feature while it is implemented using the Open Speech API behind a flag. The blocklist will be removed when the feature is officially launched with the Speech On-Device API. Bug: 1090862 Change-Id: Icc064a7dfd459a930afb5dadd5a52d488495094d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229149 Commit-Queue: Evan Liu <evliu@google.com> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#776615}
-
Evan Stade authored
This CL severs all //chrome dependencies from 1. CookieControlsBridge (java and native) 2. CookieControlsController 3. CookieControlsView Moving these files to //components is TODO. Bug: 1071775 Change-Id: Ib67bfd74b69e5443fca721fd08b52d85b2872eaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229423 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#776614}
-
Guido Urdaneta authored
Nested null callbacks can cause crashes. Bug: 1090007 Change-Id: I967b0f1365ce4df1f489b595344bf247e2fac9df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237890 Auto-Submit: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Marina Ciocea <marinaciocea@chromium.org> Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Cr-Commit-Position: refs/heads/master@{#776613}
-
Vladimir Levin authored
This patch updates the tests with the spec draft link, and moves all of the relevant tests into WPT. Some tests remain internal due to reliance on functionality not available in WPT. R=chrishtr@chromium.org Fixed: 1090375 Change-Id: Ifbad2eabbe46c41a223d8b63c3ec92c6ab9ccee6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236919 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#776612}
-
Clark DuVall authored
This implements site isolation for the preloaded origin list on Android, along with handling the memory threshold policy. The next step is to implement the dynamic detection of password sites. Bug: 1058364 Change-Id: I12b93c07bbb237a914f1f80704dbb049e5412db7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236064 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#776611}
-
Qiran Gong authored
base::UnguessableToken. This avoids a CHECK failure that can cause the fuzzer to crash. Change-Id: I88a5a64f0c86abeaaa7216d3e4b61346d4ed9e43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236337Reviewed-by:
Martin Barbella <mbarbella@chromium.org> Commit-Queue: Martin Barbella <mbarbella@chromium.org> Cr-Commit-Position: refs/heads/master@{#776610}
-
Xida Chen authored
TBR=dimich@chromium.org NOTRY=true Bug: 1092977 Change-Id: I58a647812237f5c543a3a2a5d5af717b79bc103f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238446Reviewed-by:
-
Rouslan Solomakhin authored
Before this patch, CanMakePaymentQuery would stop its timers in the destructor, which is the second phase of browser shutdown, as opposed to the KeyedService::Shutdown() method, which is the first phase, where all references should be released. This may have caused a crash when closing the browser. This is a speculative patch to have CanMakePaymentQuery stop its timers during the first phase of browser shutdown. After this patch, CanMakePaymentQuery stops its timers in the KeyedService::Shutdown() method, which is the first phase of browser shutdown. Bug: 1092472 Change-Id: Ie0b0ebb5642a4d7d80bbaee3ad4c00e48b765b21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236251 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Nick Burris <nburris@chromium.org> Cr-Commit-Position: refs/heads/master@{#776608}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/08328fea5ab9..68b2e15ee016 2020-06-09 rharrison@google.com Use correct type for var storing returned value (#2263) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,cnorthrop@google.com Change-Id: I7e99e09590cf15d937e99265285bc509be521014 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237873Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#776607}
-
Raphael Kubo da Costa authored
- Tuple parameter unpacking was removed in Python 3, so adjust type_order_priority() accordingly. - |cmp| as a parameter for list.sort() was removed in Python 3, use functools.cmp_to_key(). Bug: 941669 Change-Id: Icafb2024c77a335e5dd043be066f414a38f14b63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236404 Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#776606}
-
Thomas Anderson authored
This reverts commit 6ac4a0b6. Reason for revert: Build failure on official builder: https://ci.chromium.org/p/chrome/builders/official/linux64/1293 Original change's description: > Reland "Enable Snap package for official builds" > > This is a reland of d1bd3ffb > > Original change's description: > > Enable Snap package for official builds > > > > BUG=1055026,1090915 > > R=dpranke > > CC=goanuj > > > > Change-Id: I7009f67268fa5d35e9d41fca593248c36f6ef631 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232837 > > Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> > > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#776165} > > TBR=dpranke > > Bug: 1055026, 1090915 > Change-Id: I80fd77b927b9a832b779bdb09b843016a9c3a93f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236069 > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> > Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#776202} TBR=dpranke@chromium.org,thomasanderson@chromium.org Change-Id: I1de497c89600c89eece335198c6fef3699422caa No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1055026, 1090915 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238410Reviewed-by:
-
Amin Hassani authored
So system_api can be upreved. BUG=1071262 TEST=unittests Change-Id: I20eaf9671e9094eb9304eea161af6e530ab3e974 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237393 Auto-Submit: Amin Hassani <ahassani@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Amin Hassani <ahassani@chromium.org> Cr-Commit-Position: refs/heads/master@{#776604}
-
Chrome Metrics Logs authored
Updates the expires_after attribute for 164 histograms that show frequent access in the past 90 days. These are the 90% most frequently used histograms over that time that do not already have a date later than or within 60 days of 2020-12-06. TBR=chromium-metrics-reviews@google.com Change-Id: Icf8bbe2d04dd2f4130faf6671cbbf1d960681a55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238147Reviewed-by:
Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Commit-Queue: Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Cr-Commit-Position: refs/heads/master@{#776603}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/dffa944e0725..5ad16a50fcee 2020-06-09 danilchap@webrtc.org suppress 'Paramaterized test suite never instantiated' warning If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ifb73ba9b4a59a2f69d9d64c9ec9e145ad9e23234 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237871Reviewed-by:
-
Hans Wennborg authored
Since the destructor was not defined in the template definition, code referring to it would fail to link. This started happening in official windows builds when profile-guided-optimization performed virtual call promotion on a call to this function (see bug). Bug: 1092818 Change-Id: I9840e35dabc2d596b59ea5c315697ba15157542e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235826Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#776601}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/2ad47493f833..2943cc478e46 2020-06-09 cbruni@chromium.org Avoid UpdateTrafficSettings when possible If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1092870 Tbr: oysteine@google.com Change-Id: I601a9acc77f90aba9e8e44b0fbe2ee619cfc5d97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236728Reviewed-by:
-
Daniel Rubery authored
This reverts commit 0f871357. Reason for revert: Caused a spike in crash rate (see https://crbug.com/1092793) Original change's description: > Use IsVisualMatch in the PhishingClassifier > > This CL adds code to the PhishingClassifier to extract a screenshot of > the current page. It also sends this screenshot to the Scorer to > determine if the visual model matches the given screenshot. > > Bug: 1068617 > Change-Id: I9e4cb1ba8888fa76b116405611bf64280a87def0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226974 > Reviewed-by: vmpstr <vmpstr@chromium.org> > Reviewed-by: Bettina Dea <bdea@chromium.org> > Commit-Queue: Daniel Rubery <drubery@chromium.org> > Cr-Commit-Position: refs/heads/master@{#775835} TBR=vmpstr@chromium.org,bdea@chromium.org,drubery@chromium.org Bug: 1068617 Change-Id: Id0c5a638346a02bbdc33aab91b96a8e7b96ece48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237910Reviewed-by:
Bettina Dea <bdea@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#776599}
-
Anastasia Helfinstein authored
To allow Switch Access to automatically move the user's focus into the status tray when it's opened, an accessibility event must be fired when the status tray bubble is created. The event kShow was selected because, although the status tray is treated like a menu by Switch Access, ChromeVox expects that kMenuStart would only be fired on a menu item. AX-Relnotes: n/a. Bug: 866173 Change-Id: I5cd1ac908c6df473135ac2676e3ec5706577b2be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231903 Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#776598}
-
Hazim Mohamed authored
For drag&drop we'll need to factor out the method responsible for setting permissions for a NFSHandle. We'll also need to expose the method responsible for getting a FSURL from a path. This is done to deduplicate code responsible for and choosing permissions for SharedHandleStates, and to facilitate using the same logic when turning a NFSTransferToken into a Handle. Bug: 1080811 Change-Id: I783b6f1959e0fa03e0178466be4c07ee9d8776d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232879Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Hazim Mohamed <hazimmohamed@google.com> Cr-Commit-Position: refs/heads/master@{#776597}
-
Kevin Marshall authored
Mentions of `gclient runhooks` are replaced with `gclient sync`. The instructions previously stated that developers should run `gclient runhooks` after fetching. `runhooks` is not sufficient by itself for fetching all of the dependencies; some tools such as aemu are excluded by this step. Change-Id: I405e17018873fcb69d50e3ab9a49f5fb9503a6e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237724 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#776596}
-
Darren Shen authored
Launching in M85. Needs to land before Feature Freeze. Bug: 1076172 Change-Id: I8e7634ae13b3dbfce066109b779ff27f6ea457db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235220 Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: Darren Shen <shend@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#776595}
-
Chrome Metrics Logs authored
Updates the expires_after attribute for 33 histograms that have been used to generate alerts in the past 90 days and do not already have a date later than or within 60 days of 2020-12-06. TBR=chromium-metrics-reviews@google.com Change-Id: Ica45034954215a1b812c4fe18d98a050b00bca0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238146Reviewed-by:
-
Yue Li authored
Bug: b/156405987 Test: Manual Test Change-Id: I57c0c37ca7865f23df730e84167f9be6368dc33a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227900 Commit-Queue: Yue Li <updowndota@chromium.org> Reviewed-by:
Jeroen Dhollander <jeroendh@google.com> Cr-Commit-Position: refs/heads/master@{#776593}
-
Aaron Colwell authored
- Updates directory and filenames to use more inclusive naming. - Updates header guards on renamed files. - Updates build and dependency rules. - Update #includes Bug: 1092096 Change-Id: Ie084d8f786e63c7f49d6af2a546bdf8fe813f24f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236454Reviewed-by:
Chris Mumford <cmumford@google.com> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Aaron Colwell <acolwell@chromium.org> Auto-Submit: Aaron Colwell <acolwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#776592}
-
Rakib M. Hasan authored
Bug: 1050760, 1050754 Change-Id: I26e3b9262db6a7e7de40f3daf653d66abb959d5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236496Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#776591}
-
Xi Han authored
We don't re-enable the failing tests in the reland. Original change's description: > [Instant Start] Create ToolbarManger before showing overview. > > In this CL, we introduce an additional state in InflationObserver: > onInflationComplete. This event happens between onPreInflationStartup > and onPostInflationStartup, thus provides a way to split the > implementation of onPostInflationStartup into two methods. > > In RootUiCoordinatior, the ToolbarManger is created in > onInflationComplete, and ChromeTabbedActivity calls showOverview() > after RootUiCoordinatior#onInflationComplete but before initializing > other components in onPostInflationStartup. Thus, ToolbarManager setups > an OverviewModeObserver and won't lose any early events that an > overview is shown or overview mode is changed. > > Bug: 1077022 > Change-Id: I6bc8b96906a9519a928c6490bec0ca158b3d6241 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2181667 > Reviewed-by: Matthew Jones <mdjones@chromium.org> > Reviewed-by: Yaron Friedman <yfriedman@chromium.org> > Reviewed-by: Ender <ender@google.com> > Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org> > Commit-Queue: Xi Han <hanxi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#776073} Bug: 1077022 Change-Id: Id01abc7d9ed2df245a327105e72ab25fa844daa4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237646Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#776590}
-
Ian Barkley-Yeung authored
Increase the detail on the CrashReport.DumpWithoutCrashingResult.FromInitSharedMemoryIfNeeded metric. In particular, record which of the two crash handlers succeeded or failed. This will allow me to distinguish "Breakpad is always failing, Crashpad is sometimes succeeding" from "Breakpad sometimes succeeds, sometimes fails". NOTE: Renamed CrashReport.DumpWithoutCrashingResult.FromInitSharedMemoryIfNeeded2 because of the new enum. BUG=chromium:1074115 Change-Id: I8bcd6e10177d23f9c7c0f8a6e1c637192406a249 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236469 Commit-Queue: Ian Barkley-Yeung <iby@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#776589}
-
Bettina authored
Bug: 1038797 Change-Id: Icb3f4412796bae267cd0427ec440b49dd7c6c4dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236495Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#776588}
-
Will Harris authored
https://helpx.adobe.com/security/products/flash-player/apsb20-30.html BUG=412078 TBR=jschuh@chromium.org Change-Id: I4975af48096599a480342dacc3d49984be3e4bce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238012Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#776587}
-
Pavel Yatsuk authored
This reverts commit 3d506040. Reason for revert: The test fails on multiple builders. E.g.: https://ci.chromium.org/p/chromium/builders/ci/Marshmallow%2064%20bit%20Tester/32695 The call stack is: android.support.test.espresso.base.DefaultFailureHandler$AssertionFailedWithCauseError: View is present in the hierarchy: MessageCardView{id=2131428697, res-name=tab_grid_message_item, visibility=VISIBLE, width=1038, height=156, has-focus=false, has-focusable=true, has-window-focus=true, is-clickable=false, is-enabled=true, is-focused=false, is-focusable=false, is-layout-requested=false, is-selected=false, root-is-layout-requested=false, has-input-connection=false, x=21.0, y=603.0, child-count=3} Expected: is <false> Got: <true> at dalvik.system.VMStack.getThreadStackTrace(Native Method) at java.lang.Thread.getStackTrace(Thread.java:580) at android.support.test.espresso.base.DefaultFailureHandler.getUserFriendlyError(DefaultFailureHandler.java:82) at android.support.test.espresso.base.DefaultFailureHandler.handle(DefaultFailureHandler.java:53) at android.support.test.espresso.ViewInteraction.runSynchronouslyOnUiThread(ViewInteraction.java:184) at android.support.test.espresso.ViewInteraction.check(ViewInteraction.java:158) at org.chromium.chrome.browser.tasks.tab_management.TabGridIphTest.testNotShowIPHInMultiWindowMode(TabGridIphTest.java:344) Original change's description: > Skip showing tab switcher message card in multi-window mode > > Bug: 1085630 > Change-Id: If0e6e852458aedf448647e3ab8320519c4775bd2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216630 > Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org> > Reviewed-by: Mei Liang <meiliang@chromium.org> > Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#776308} TBR=wychen@chromium.org,meiliang@chromium.org,yuezhanggg@chromium.org Change-Id: I60c9ff0219832ccda197550ee8de92b6bb91fb54 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1085630 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236502Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#776586}
-
Raphael Kubo da Costa authored
IWYU. This fixes the libstdc++ build after commit 5e47a2b2 ("[gamepad] Keep track of which buttons and axes are used"). Bug: 957519 Change-Id: I835b279a84b129c7af78ff10a42c39b90d0bd6fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237253 Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#776585}
-
Nazerke authored
Bug: 1072370 Change-Id: Ib3b773f01e3c2f3b3d4d0e1ea60599878efe8840 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235596 Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#776584}
-
Raphael Kubo da Costa authored
dict.has_key() does not exist in Python 3. Just use dict.get() to achieve the same result with fewer checks. Bug: 941669 Change-Id: Iaeec0ac1ec8efd88c796c73344fea91eaab0df7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236435 Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#776583}
-
