- 21 Nov, 2019 40 commits
-
-
Anatoliy Potapchuk authored
Bug: 1006230 Change-Id: I1658e2ff0f2b7e91a74719e8eeeb26920273f54f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926491 Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#717680}
-
Chris Lu authored
This change adds InfobarTranslateMediator to handle most InfobarDelegate model information retrieval. The InfobarTranslateTableViewController will use a data source protocol to retrieve it from the mediator. Bug: 1014959 Change-Id: I793f4bf5b3cb009b4a965aafb20e8ad045809af9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921339 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#717679}
-
Richard Knoll authored
Removes these flags as they are enabled by default on stable already and we won't disable them anymore: - ClickToCallContextMenuForSelectedText - SharingDeviceRegistration - ClickToCallOpenDialerDirectly The ClickToCallReceiver feature is kept as a kill switch but the chrome flags entry for it is removed. Bug: None Change-Id: I05a5f10325176c56ecaaf6419d3c876675eced3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926627 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#717678}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/e835fc01b1a9..b86a1770ee64 git log e835fc01b1a9..b86a1770ee64 --date=short --no-merges --format='%ad %ae %s' 2019-11-21 sakal@webrtc.org Expose ABGRToI420 in YuvHelper. Created with: gclient setdep -r src/third_party/webrtc@b86a1770ee64 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: Iaec7ae149c60bae4dd8ef2ab76a7c484cb35a718 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928137Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#717677}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/f2c9ce1e08ed..72e68083f914 git log f2c9ce1e08ed..72e68083f914 --date=short --no-merges --format='%ad %ae %s' 2019-11-21 kadam@inf.u-szeged.hu Add new relocation types. Created with: gclient setdep -r src/third_party/swiftshader@72e68083f914 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:893460 Change-Id: I8f539e41ae0aaba518e060dd87f905194c538185 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928144Reviewed-by:
-
Joe Downing authored
This is the first step in removing the CRD Webapp code. First we need to make sure it's disappearance won't cause a problem for the official builders. After that we can continue cleaning up the various bits and bobs which build it and our pNaCl plugin. BUG= Change-Id: I7b30bc90e768505518046124ed887b23c09ddd4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925353Reviewed-by:
Jason Kersey <kerz@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#717675}
-
Sebastien Marchand authored
The L41r GraphObserver has been added in https://crrev.com/c/1579363 but it has never been created, this fix this by calling LocalSiteCharacteristicsWebContentsObserver::MaybeCreateGraphObserver(); when starting TabManager. This CL also removes notifications from the list of features that are ignored during the first seconds after a tab has been backgrounded. This list is meant to be for features that needs to "stabilize" (e.g. the tab title can change while a tab is in background after a same-document navigation), but notifications are an explicit form of communication with the user. This also enable the corresponding test to avoid any regression on this. Change-Id: I34c1efb88e101337b9f9913b9796a4442a876487 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925137Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#717674}
-
Sadrul Habib Chowdhury authored
The display compositor sends a list of LatencyInfo objects to the renderers during swap. This is used to report some of the latency metrics. In order to be able to report additional metrics, it is necessary to send additional information about the frame being swapped. So introduce a SwapFrameData to capture such information. BUG=1027129 Change-Id: Ide1773e7b7a2ce3aca1f942d8e2c6f7f1d097795 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928040 Commit-Queue: Saman Sami <samans@chromium.org> Auto-Submit: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#717673}
-
Mohamed Heikal authored
This reverts commit 8a4e1e84. Bug: 1027068 Reason for revert: https://www.androidpolice.com/2019/11/21/chrome-canary-gets-mysteriously-renamed-to-clankium-with-funky-dino-icon-apk-download/ Original change's description: > Allow android_resources targets to specify files rather than dirs > > Specifying directories in android_resources targets leads to subtle > failures such as the target not being rebuilt after adding new files to > it. > > Change-Id: I5f5cb1d50b5d7d6a8d7184b891182658aa690afa > Bug: 1026378 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919602 > Commit-Queue: Mohamed Heikal <mheikal@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#717177} TBR=agrieve@chromium.org,mheikal@chromium.org Change-Id: I7107e14539fded7a4ec67ec374ea1c91a23da0cb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1026378 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928558Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#717672}
-
David Roger authored
Change-Id: I55ddd99da9115affc449f4f2f9fb5a0539c1171a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924477 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#717671}
-
Yves Gerey authored
Reason for revert: Breaks iOS WebRTC bots. Change-Id: Ib85d9865dee9fb70637fa0e48e52a5ce3d45e649 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929219Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#717670}
-
Sam Maier authored
We no longer need the callGraphCycleEliminatorMaxDepthThreshold, since R8 fixed this issue (see b/143685705). Change-Id: Ibd9ad9c3ca3d7c7365c7475ff9435cc39fc9774c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928047 Auto-Submit: Sam Maier <smaier@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#717669}
-
Antonio Gomes authored
BUG=78725 R=guidou@chromium.org Change-Id: I2bd17004fd4635330e761980bc6a1304e0475f4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924887 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#717668}
-
Doug Arnett authored
Back-forward navigations can trigger the ClientRedirectCycle.RedirectToReferrer logic (which is applicable for DeferAllScript previews). We have a better approach now (RedirectLoopDetectedUsingCache) so we can revert this initial approach and allow these false positive cases to be eligible for the DeferAllScript preview. Bug: 1026089 Change-Id: Id415aa2a0e7e33742b942976b428b27dd1231a2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925884Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#717667}
-
David Roger authored
This CL removes the non-forced dice migration. There code to perform the forced migration is not removed. Bug: 777774 Change-Id: Icdcb6cbaa1eeaa2ff174bc4c73d3a93e919665ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917177 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
-
Monica Basta authored
Bug: 305720 Change-Id: I283ada9ff6b7d55c1055bfbdfb301854d372b651 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926473 Commit-Queue: Monica Basta <msalama@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#717665}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/c36744bff1ae..4da3b30c3879 git log c36744bff1ae..4da3b30c3879 --date=short --no-merges --format='%ad %ae %s' 2019-11-21 aerotwist@chromium.org Migrates css_overview/ to esm Created with: gclient setdep -r src/third_party/devtools-frontend/src@4da3b30c3879 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1006759 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ib42dd6434e4f078178a6025be24f7cc981495f06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928138Reviewed-by:
-
Alex Ilin authored
This reverts commit 8c36510c. Reason for revert: Added missing include on ChromeOS. Original change's description: > Revert "[base] Remove base::SharedMemory and base::SharedMemoryHandle" > > This reverts commit fa7e8cc7. > > Reason for revert: It looks like there was at least one missed instance of transitively including file_util. Sample build log: https://ci.chromium.org/p/chrome/builders/ci/chromeos-kevin-google-rel/4373 > > Original change's description: > > [base] Remove base::SharedMemory and base::SharedMemoryHandle > > > > There are no users of the deprecated shared memory left, so its code > > can safely removed. > > > > To use shared memory in Chrome, please refer to > > base::WritableSharedMemoryRegion and base::ReadOnlySharedMemoryRegion > > classes. > > > > This CL removes all remaining #includes of > > "base/memory/shared_memory.h" and > > "base/memory/shared_memory_handle.h". They are replaced by new shared > > memory includes when needed. > > > > It also appears that "base/files/file_util.h" and > > "base/posix/eintr_wrapper.h" were transitively included in many places > > through the removed files. This CL includes them explicitly in all > > those files. > > > > TBR: wfh@chromium.org > > Bug: 795291 > > Change-Id: I97ecac4b529c0ad6498b6e5ccf01515f750448ad > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919152 > > Commit-Queue: Alex Ilin <alexilin@chromium.org> > > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > > Reviewed-by: Jochen Eisinger <jochen@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#717588} > > TBR=dcheng@chromium.org,jochen@chromium.org,alexilin@chromium.org > > Change-Id: I16c6e4c2ada01240d577706478cf739ce1061ee5 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 795291 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929252 > Reviewed-by: Tommy Martino <tmartino@chromium.org> > Commit-Queue: Tommy Martino <tmartino@chromium.org> > Cr-Commit-Position: refs/heads/master@{#717644} TBR=dcheng@chromium.org,tmartino@chromium.org,jochen@chromium.org,alexilin@chromium.org Change-Id: I437cf7f93965858840170eb49b2d611b37e79b25 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 795291 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929221Reviewed-by:
-
Eric Seckler authored
This reverts commit 5d686312. Reason for revert: turns out this was caused by a different patch afterall. Original change's description: > Revert "Disable failing tests on android-go_webview-perf" > > This reverts commit 7a502f46. > > Reason for revert: patch that caused the failures was reverted > > Original change's description: > > Disable failing tests on android-go_webview-perf > > > > Disabling the following tests on android-go_webview-perf: > > * system_health.common_mobile/browse:media:youtube:2019 > > * system_health.common_mobile/browse:news:nytimes:2019 > > * system_health.common_mobile/browse:news:cnn:2018 > > > > TBR=crouleau@chromium.org > > NOTRY=true > > > > Bug: 1026822 > > Change-Id: I2581e3c21158edff2563de628bfa41de7349271d > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1927216 > > Reviewed-by: John Chen <johnchen@chromium.org> > > Commit-Queue: John Chen <johnchen@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#717272} > > TBR=crouleau@chromium.org,johnchen@chromium.org > > Change-Id: I0cf407e4ec8f3a44afa229c9fae82c064d9bb9a0 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1026822 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928322 > Reviewed-by: Eric Seckler <eseckler@chromium.org> > Commit-Queue: Eric Seckler <eseckler@chromium.org> > Cr-Commit-Position: refs/heads/master@{#717618} TBR=crouleau@chromium.org,eseckler@chromium.org,johnchen@chromium.org Change-Id: I0c6f3f761c335df3463564ba84946735b552c713 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1026822 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928557Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#717662}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/bf492e4910bb..1898c08274eb git log bf492e4910bb..1898c08274eb --date=short --no-merges --format='%ad %ae %s' 2019-11-21 jmadill@chromium.org Roll third_party/android_ndk/ 89e8db0cd..27c0a8d09 (1 commit) Created with: gclient setdep -r src/third_party/angle@1898c08274eb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=courtneygo@google.com Bug: None Change-Id: I9732fd4cc1eeb8af13ec755b3ce0b558bcff8bc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928134Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b4f854080375..b184e9654d26 git log b4f854080375..b184e9654d26 --date=short --no-merges --format='%ad %ae %s' 2019-11-21 egdaniel@google.com Update failure calls in GrVkMemory and shader creation. Created with: gclient setdep -r src/third_party/skia@b184e9654d26 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=robertphillips@google.com Bug: None Change-Id: I22328bc7f04f65073f39c0fe40028c5377017898 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928139Reviewed-by:
-
Tobias Sargeant authored
This allows us to support starting code loading earlier, as well as supporting APIs that may not need or want to fully initialize WebLayer, but just make use of Java code from the WebLayer provider. Also clean up calls to getApplicationContext to ensure that they happen at the public API surface rather than internally. Bug: 1027076 Change-Id: I16d7ce196c680722981883ed7d2be463d482b801 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928779Reviewed-by:
Pavel Shmakov <pshmakov@chromium.org> Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org> Cr-Commit-Position: refs/heads/master@{#717659}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/26c7fb61a9db..10146cfca138 git log 26c7fb61a9db..10146cfca138 --date=short --no-merges --format='%ad %ae %s' 2019-11-21 mmortensen@google.com BuildAPI: Add unit tests and mocks for Image Service. Created with: gclient setdep -r src/third_party/chromite@10146cfca138 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I5b6b2987393ff50989a8835279d7ed9acccd6014 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928133Reviewed-by:
-
Ella Ge authored
Currently, when recording in devtool performance tab, it will draw all events even though some GestureScrollUpdate are coalesced into others. In that case, coalesced GSUs are terminated earlier, and the slice are smaller than what it should be and meaningless (as it's not really been handled) This CL adds a is_coalesced bit to latencyInfo trace event data, it will be used for filtering out unnecessary GSUs in devtool performance panel(crrev.com/c/1928916). Bug: 956681 Change-Id: I9d999dd86e54f2b75d0a2527a4ba0e39f0e6ce9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924311Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#717657}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/d17a8eeb608a..235c2525d2c0 git log d17a8eeb608a..235c2525d2c0 --date=short --no-merges --format='%ad %ae %s' 2019-11-21 fmayer@google.com Fix dep path. 2019-11-21 ilkos@google.com Add missing group by for clarity 2019-11-20 ilkos@google.com Merge "Improve process to package matching" 2019-11-20 rsavitski@google.com Merge "traced_perf: basic producer scaffolding with logging of samples on Flush." 2019-11-20 rsavitski@google.com Merge "traced_perf: trivial config proto (PerfEventConfig) for further development." 2019-11-20 treehugger-gerrit@google.com Merge "Fix bazel build" 2019-11-20 treehugger-gerrit@google.com Merge "Add parser for proguard maps." Created with: gclient setdep -r src/third_party/perfetto@235c2525d2c0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I9b760e5b8e8aca638ca767bdab8e4efb022c01b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928135Reviewed-by:
-
Maksim Ivanov authored
The comment was still referring to the old name of one of the methods, before it got renamed. Bug: none Change-Id: I4f539546581e20d5c244da425a220e0f8db7875b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919145Reviewed-by:
Igor <igorcov@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#717655}
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=pastarmovj@chromium.org Bug: 1023677 Change-Id: I5fe629d2b7e3725a41a53d0be763dfd3b9086ede Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1927017 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#717654}
-
Ilya Nikolaevskiy authored
Bug: webrtc:11058 Change-Id: I75b68535a33978206acdbb27908167d323822fd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926142 Commit-Queue: Ilya Nikolaevskiy <ilnik@chromium.org> Auto-Submit: Ilya Nikolaevskiy <ilnik@chromium.org> Reviewed-by:
-
Elly Fong-Jones authored
Bug: 1011446 Change-Id: Idf440f08fdfaa8ce44d879487aeae9567f68eecb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925750Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#717652}
-
Dave Tapuska authored
Remove Collapse from the WebFrame interface and move it directly to the LocalFrame/RemoteFrame interfaces. BUG=1008432 Change-Id: Ib8a7ce13b76a9618e075e175db8649f0c8ed7b71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1920479Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#717651}
-
Mihai Sardarescu authored
This CL removes the explicit conversion from (and to) std::string and CoreAccountId. Bug: 959157 Change-Id: Ibfc5ca50bf595a089e63ed1462361cbe8a316001 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926482Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#717650}
-
Anqing Zhao authored
Similar to the existing flag 'EnterpriseReportingInBrowser', the new feature flag is used for similar functionality, uploading usage data from Chrome OS to DM server. Bug: 1010213 Change-Id: I53b2e20535fccd2dd357cde42660832f6359df61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926489Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Anqing Zhao <anqing@google.com> Cr-Commit-Position: refs/heads/master@{#717649}
-
Connie Wan authored
Pulled out TabGroupModel and TabGroup from TabStripModel. See the comments in each class for how they're used. See also the TODOs in the comments for how this can be further improved in future CLs (working on this next). The API in TabStripController still remains despite my best efforts to get rid of it. For now that seems better because I have to touch fewer things while refactoring. Eventually I'm interested in seeing how we can avoid duplicating APIs across models and controllers, which is a bigger philosophical question. Change-Id: I96130622ab939de7d986c7e3dd1b19b476658f02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1915194Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Commit-Queue: Connie Wan <connily@chromium.org> Cr-Commit-Position: refs/heads/master@{#717648}
-
Himanshu Jaju authored
Moves all browsertests to ui/views/sharing to add UI checks in browsertests. Bug: 1015850 Change-Id: I64062a8e1d89898fce7e8a3902d1eb1ea4c48d45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928707Reviewed-by:
Richard Knoll <knollr@chromium.org> Reviewed-by:
-
Clemens Backes authored
This test is failing after a v8 change, we need to investigate. R=ahaas@chromium.org CC=nicohartmann@chromium.org Bug: chromium:1027131 Change-Id: Ie8968916a477f6e0e802927b76540dcfbba24c2c No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929236 Commit-Queue: Clemens Backes <clemensb@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Auto-Submit: Clemens Backes <clemensb@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#717646}
-
David Van Cleve authored
Currently, the referrer browsertests check the outgoing request's headers on subresource requests but just use JS to check the outgoing referrer on navigation requests. This patch expands the check to navigation requests, too, in order to cover more of the navigation logic. This patch also - adds a test covering browser-initiated navigations' referrers - resolves a few linter complaints (reset -> make_unique; default constructors) Change-Id: I804ca43632b881878df63cad33ffaf94b5db6741 Bug: 1021277 Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924871Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#717645}
-
Tommy Martino authored
This reverts commit fa7e8cc7. Reason for revert: It looks like there was at least one missed instance of transitively including file_util. Sample build log: https://ci.chromium.org/p/chrome/builders/ci/chromeos-kevin-google-rel/4373 Original change's description: > [base] Remove base::SharedMemory and base::SharedMemoryHandle > > There are no users of the deprecated shared memory left, so its code > can safely removed. > > To use shared memory in Chrome, please refer to > base::WritableSharedMemoryRegion and base::ReadOnlySharedMemoryRegion > classes. > > This CL removes all remaining #includes of > "base/memory/shared_memory.h" and > "base/memory/shared_memory_handle.h". They are replaced by new shared > memory includes when needed. > > It also appears that "base/files/file_util.h" and > "base/posix/eintr_wrapper.h" were transitively included in many places > through the removed files. This CL includes them explicitly in all > those files. > > TBR: wfh@chromium.org > Bug: 795291 > Change-Id: I97ecac4b529c0ad6498b6e5ccf01515f750448ad > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919152 > Commit-Queue: Alex Ilin <alexilin@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Jochen Eisinger <jochen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#717588} TBR=dcheng@chromium.org,jochen@chromium.org,alexilin@chromium.org Change-Id: I16c6e4c2ada01240d577706478cf739ce1061ee5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 795291 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929252Reviewed-by:
Tommy Martino <tmartino@chromium.org> Commit-Queue: Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#717644}
-
Fredrik Söderquist authored
This moves the "animation interface", i.e the methods: ResetAnimatedType(), ClearAnimatedType(), ApplyResultsToTarget(), OverwritesUnderlyingAnimationValue() and UpdateAnimation() From SVGSMILElement to SVGAnimationElement. This means that we can make the SMILAnimationSandwich only care about SVGAnimationElements which is slightly more logical. The |attribute_name_| field is also moved to more logical place, namely SVGAnimateElement. Bug: 1017723 Change-Id: I870cca66b44d42288b40cb5d09cd06c04160420d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928775Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#717643}
-
Colin Blundell authored
This test currently isn't being built and has bitrotted. This CL adds it to the build and gets it to build. It also doesn't pass, which this CL doesn't attempt to fix (see linked bug). Bug: 1026557 Change-Id: I66ecc1e5344047092d7ed0f30963c44cec796950 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925057 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#717642}
-
Vaclav Brozek authored
Currently the PasswordCSVWriter test uses CSVReader to check serializations of passwords into CSV, the result of the tested code. However, CSVReader will be soon removed together with its main client, the PasswordCSVReader. This CL replaces CSVReader use in PasswordCSVWriter test with the replacement of PasswordCSVReader: the CSVPasswordSequence. This has an additional benefit: CSVPasswordSequence both decodes CSV and constructs a PasswordForm out of it, unlike CSVReader, which only does the former. Therefore, the test must no longer include implementation details of PasswordCSVWriter, and can instead just verify that PasswordCSVWriter is the reverse operation of CSVPasswordSequence. Bug: 934326 Change-Id: If010b42c7c46dd1ece8f6ef96e85eddbd49d09e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1920122 Commit-Queue: Vaclav Brozek <vabr@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#717641}
-
