- 25 Apr, 2018 40 commits
-
-
https://skia.googlesource.com/skia.git/+log/e1c37a7b8f21..77e95f7067e3 $ git log e1c37a7b8..77e95f706 --date=short --no-merges --format='%ad %ae %s' 2018-04-24 enne Fix SkDashImpl::CreateProc OOM on garbage input 2018-04-25 kjlubick Migrate NUC7i5BNK to Debian 9 Created with: roll-dep src/third_party/skia BUG=chromium:835418 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stani@chromium.org Change-Id: I25c051ac40ebbcf464beffe40852de8ccafcbd66 Reviewed-on: https://chromium-review.googlesource.com/1027994Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#553556}
-
Olivier Robin authored
Test hangs on this iOS device running iOS 10. Disable until we find the root cause. Bug: 836808 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ic2dde07f54e0af49d2bc5a5584138cd631e53248 Reviewed-on: https://chromium-review.googlesource.com/1028270Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#553555}
-
Leonard Grey authored
Bug: 673362 Change-Id: Id318b8c8b7e6c3def6f38c51961032b3f3270a65 Reviewed-on: https://chromium-review.googlesource.com/1026476Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#553554}
-
Peng Huang authored
Bug: 776877 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: If78208ecf3f5becb366b7860e15e1ac09d94c9df Reviewed-on: https://chromium-review.googlesource.com/1023165Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#553553}
-
Calder Kitagawa authored
Was causing ClusterFuzz crashes when an unknown exe type was returned. Instead of crashing the runtime should just return kExeTypeUnknown and let the runtime handle the problem as before. Bug: 836803 Change-Id: I23841fc50025a9850ac322960069270cd3e524be Reviewed-on: https://chromium-review.googlesource.com/1028212Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@google.com> Cr-Commit-Position: refs/heads/master@{#553552}
-
Justin Cohen authored
Followup to crrev.com/c/1005912, missed another case where we need to inject the status bar height for iOS10. Bug: 819460 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I2749ac4d5fcf24edd446741e5927868e856dd4c6 Reviewed-on: https://chromium-review.googlesource.com/1026420Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#553551}
-
Henrik Boström authored
The internal class owns AdapterRefs which have to be destructed on the main thread. As such, the last reference to the internal class had to be freed on the main thread. In flaky cases, when tasks were posted to the signaling thread, an operation performed and a task posted back to the main thread - the main thread would finish before the signaling thread task and the last reference to the internal class would be released on the signaling thread, causing DCHECK crashes at ~AdapterRef for being on the wrong thread. With destructor traits, if we are not already on the main thread we post to the main thread and delete RTCRtpSenderInternal there. The TearDown of RTCRtpSenderTest is updated to ensure that any pending tasks get a chance to execute, in case the signaling thread was not finished yet or else the destructor posted to the main thread does not get a chance to execute and the test would flakily leak. Before this CL: Flake's symptoms could be reproduced by adding a thread sleep at RTCRtpSenderInternal::GetStatsOnSignalingThread. After this CL: Unable to repro flake. The same applies for the other flaking tests based on replaceTrack(). Bug: 827450 Change-Id: Ib594a53042e441e591ccc2c87ae8012bcb4ec75e Reviewed-on: https://chromium-review.googlesource.com/1015002 Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#553550}
-
Devlin Cronin authored
PolicyTests have been updated to manifest v2. Remove the allowance for manifest v1 extensions. Bug: 816679 Change-Id: Ifc1db03aa42db2ae367389d4ec3df4efb18573db Reviewed-on: https://chromium-review.googlesource.com/1026073Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#553549}
-
Devlin Cronin authored
DeviceLocalAccountTests have been updated to manifest v2. Remove the allowance for manifest v1 extensions. Bug: 816679 Change-Id: If61d9bf5b3b9a919c152c5486bae57513e095c18 Reviewed-on: https://chromium-review.googlesource.com/1026074Reviewed-by:
-
Rohit Rao authored
Updates the egtest utils to support the new TabGrid. Adds a temporary workaround for a TabGrid bug. BUG=818732,836312 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I66efdbcfce9318a7245463cb2cf7d4f0592ed5de Reviewed-on: https://chromium-review.googlesource.com/1026411 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#553547}
-
Bence Béky authored
Many classes in //net have a private io_callback_ member that is initialized upon class construction and is passed every time an async operation is called. This CL introduces CompletionRepeatingCallback and uses it in seven classes, where this member is used multiple times. (This part is no-op, since currently base::Callback is aliased to base::RepeatingCallback, and base::Bind to base::BindRepeating.) The rationale is that both a CompletionRepeatingCallback and a CompletionOnceCallback has a scoped_refptr<BindStateBase> deep under the hood (using a scoped_refptr for OnceCallback seems unnecessary, but this allows efficient cast from RepeatingCallback to OnceCallback). Instantiating such a scoped_refptr on the heap is more expensive than copying an existing CompletionRepeatingCallback (which reuses the BindStateBase object, only increases its reference count). Therefore it is better to create and reuse a CompletionRepeatingCallback then to bind a new CompletionOnceCallback every time in classes that use io_callback_ often. On the other hand, HttpStreamFactoryImpl::JobController::io_callback_ is only used once, for proxy resolution, and only if there is a proxy involved. Therefore it is better to bind this callback at the call site. (This CompletionCallback will later be changed to a CompletionOnceCallback once ProxyResolutionService::ResolveProxy() supports that.) Bug: 807724 Change-Id: Ib342b057b8960789514baa21afcda0820a633404 Reviewed-on: https://chromium-review.googlesource.com/1016671Reviewed-by:
Misha Efimov <mef@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#553546}
-
Kazuhiro Inaba authored
The vector icon field causes Mojo de-serialization error for unregistered icons, and anyway they are not used by the caller (autotest_private API.) Bug: 836080 Test: cheets_MediaProjectionPermissionsTest Change-Id: Id7f680fafbe91c21e42dce794601deef5e5d8ac2 Reviewed-on: https://chromium-review.googlesource.com/1025243Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Kazuhiro Inaba <kinaba@chromium.org> Cr-Commit-Position: refs/heads/master@{#553545}
-
Manuel Rego Casasnovas authored
LayoutBox had two attributes override_content_logical_width_ and override_content_logical_height_, that are used by different layout models like tables, flexbox and grid layout. There was a FIXME to rename them as the name was not correct. The were not storing the content width/height but the content width/height plus the scrollbar size. So the FIXME suggested to rename them to override_logical_width/height, and store the logical width/height in them. This patch implements the suggestion on the FIXME, renaming the attributes and methods accordingly, and storing the override logical width/height instead of the content one there. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Ia4a15996f43692c789f7f29fe6b96f40708c3e3b Reviewed-on: https://chromium-review.googlesource.com/1024171 Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#553544}
-
Fredrik Söderquist authored
This avoids the implicit conversion to float, which can lead to loss of precision. Bug: 836722 Change-Id: I66ea0f42823347b17e41e5d823aaf766429eacbf Reviewed-on: https://chromium-review.googlesource.com/1027710Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#553543}
-
Nico Weber authored
Bug: none Change-Id: Id2f0923fbeeac975098ccb45678eddf10e18d80b Reviewed-on: https://chromium-review.googlesource.com/1027791Reviewed-by:
-
Marc Treib authored
It was previously disabled on Windows, but it's flaky everywhere. TBR=mastiz Bug: 836289 Change-Id: I100c69c513118872824fbfdf58a4a7b6cef8ceca Reviewed-on: https://chromium-review.googlesource.com/1027838Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#553541}
-
Mihai Sardarescu authored
Some sign-in access points do not support personalized sign-in promos, so |Signin_SigninNewAccount_From*| user actions are not recorded for them. When the Desktop Identity Consistency flow is started for a new account from any access point, the PROMO_ACTION_NEW_ACCOUNT is used for convenience in order to avoid bloating the API (showing the sign-in page does pass though a sevaral layers of code). This CL avoids recording the Signin_SigninNewAccount_From* for access points that do not support personalized promos, but also avoids treating it as an error. Bug: 836153 Change-Id: I4f8f686c86fa7556a2d943e2668af636abd93894 Reviewed-on: https://chromium-review.googlesource.com/1025891Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#553540}
-
Gabriel Charette authored
Changes in patch set 1 were scripted as part of the effort to restrict exposure of the raw MessageLoop*. I've manually cleaned it up in the latest patch set to remove usage of MessageLoop* another level. This CL was uploaded by git cl split (initially). R=haraken@chromium.org TBR=piman@chromium.org (naming side-effect in ppapi_plugin/) Bug: 825327 Change-Id: Id2c1dcb68c7a8fccafa5e0eee86fb5db82939a2f Reviewed-on: https://chromium-review.googlesource.com/1024654 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#553539}
-
Jonathan Backer authored
Notable changes in this CL: - mark all RasterDecoderImpl class final (maybe compiler can devirtualize) - copy over context loss related methods from GLES2DecoderImpl to RasterDecoderImpl - port over GLES2Decoder context loss unit tests to RasterDecoder Bug: 789238 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I919163ce459603109b12ee864561debb136ff594 Reviewed-on: https://chromium-review.googlesource.com/1025961 Commit-Queue: Jonathan Backer <backer@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#553538}
-
Philip Jägenstedt authored
Intent to Deprecate and Remove: https://groups.google.com/a/chromium.org/d/msg/blink-dev/0D_37iuh1zc/ndyyNaxgCQAJ Bug: 692084 Change-Id: Iae09a7d82e09c9bc3f0394dfa476370fd1efe516 Reviewed-on: https://chromium-review.googlesource.com/1013699Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#553537}
-
https://webrtc.googlesource.com/src.git/+log/a945aee72e4e..09408115cda7 $ git log a945aee72..09408115c --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=chromium:None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ia0b06d701ad86f290ac3a3bee1140c4d6c6e2af6 Reviewed-on: https://chromium-review.googlesource.com/1027991Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#553536}
-
John Abd-El-Malek authored
I forgot to update the filter in that fix. TBR=leon.han@intel.com NOTRY=true Bug: 729848 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I50456a8a863277c06d054a7ba9a5f5834be5057c Reviewed-on: https://chromium-review.googlesource.com/1027993 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#553535}
-
https://skia.googlesource.com/skia.git/+log/9f63153a03c7..e1c37a7b8f21 $ git log 9f63153a0..e1c37a7b8 --date=short --no-merges --format='%ad %ae %s' 2018-04-24 benjaminwagner [infra] Add image dimension for Win GCE bots Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stani@chromium.org Change-Id: Iae673561a38863a7b1caa17177e950bc9fe43879 Reviewed-on: https://chromium-review.googlesource.com/1027443 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
-
Mark Pilgrim authored
Bug: 773295 Change-Id: I9cc62ea0aaf4eab4639c68b3d76ec82e17ab0e3c Reviewed-on: https://chromium-review.googlesource.com/1024077Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Satoru Takabayashi <satorux@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Mark Pilgrim <pilgrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#553533}
-
Gabriel Charette authored
These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. R=mkwst@chromium.org Bug: 825327 Change-Id: Ic19845b885a4527fbdf5acb2e41a4b75153a1998 Reviewed-on: https://chromium-review.googlesource.com/1024395Reviewed-by:
-
John Abd-El-Malek authored
Bug: 729848 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I7bafe16cda83030209f357340c6503154e9b55cf Reviewed-on: https://chromium-review.googlesource.com/1027121Reviewed-by:
-
John Abd-El-Malek authored
Bug: 729848 Change-Id: Ic1fc3f01184585c79f75cd060d4ce94226affb29 Reviewed-on: https://chromium-review.googlesource.com/1027205Reviewed-by:
Han Leon <leon.han@intel.com> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#553530}
-
Charlie Harrison authored
In general, features should not be changed in the test body. My guess is that InitFromCommandLine is clobbering all features in a non-safe way. This CL stops all feature setting in all test bodies in favor of just using test subclasses. Bug: 836215 Change-Id: I4ffb6f9d16f87359ed1d9df9966faa345f4a72a3 Reviewed-on: https://chromium-review.googlesource.com/1025640Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#553529}
-
Fady Samuel authored
WasResized is a misnomer. This is one of many CLs to change the language in a post-surface-sync world. Change-Id: I546e914e98e9746894a9dae7b1bf65a894cb6fe7 Bug: 836367, 672962 Reviewed-on: https://chromium-review.googlesource.com/1026468 Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#553528}
-
Elly Fong-Jones authored
TBR=jbudorick@chromium.org Bug: 828031 Change-Id: I40fbb54ee6399ff5a30e7d65a77d786648dcb83d Reviewed-on: https://chromium-review.googlesource.com/1027894Reviewed-by:
-
Yutaka Hirano authored
...in order to make the logic work after frame detach. This CL also removes Resource::SetDetachable which is no longer needed. Bug: 836641 Change-Id: I6ebc978021cafa9a6337afab5de29532fc28c4c1 Reviewed-on: https://chromium-review.googlesource.com/1027210Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#553526}
-
Thomas Tangl authored
The UI of the top-level master toggle is added to sync settings. For now the toggle changes whether all data types of sync should be turned on or only a custom selection (taken over from before). This should be changed once the unified consent service is implemented. Bug: 800974 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I7eea3059ab90a3e47d9d5306e4a6359efdba0cf5 Reviewed-on: https://chromium-review.googlesource.com/1023934 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#553525}
-
Takuto Ikuta authored
I applied modernize-use-override in blink/renderer/platform http://clang.llvm.org/extra/clang-tidy/checks/modernize-use-override.html Bug: 428099 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I481f68cd5dfce10e19e938fdee31d4efcadfabef Reviewed-on: https://chromium-review.googlesource.com/1027230Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#553524}
-
David Reveman authored
It should not be possible to minimize transient dialog windows. These windows typically disable input for the parent and minimizing them and leaving the parent in a disabled state can be very confusing. Bug: 821498 Test: exo_unittest --gtest_filter=ShellSurface.Minimum Change-Id: I288b57a4b36f61d6ae0d491796ba45d8c9e44686 Reviewed-on: https://chromium-review.googlesource.com/1027890 Commit-Queue: David Reveman <reveman@chromium.org> Reviewed-by:
Kristian H. Kristensen <hoegsberg@chromium.org> Cr-Commit-Position: refs/heads/master@{#553523}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 8a67bbae. With Chromium commits locally applied on WPT: 303956b6 "Enable WPT tests for the Generic Sensor classes" afb472c0 "Try to fix crash when terminating a worker while it is XHR-ing to a blob." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/16248 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: meade@chromium.org: external/wpt/web-animations TBR=markdittmer No-Export: true Change-Id: I85211ab928f7aa846dac4b0fa294302186fd4acf Reviewed-on: https://chromium-review.googlesource.com/1027790 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#553522}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a5f8be1f..2875ae01 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I738550c46b6b5c1a8e9e80d94fcc0aa72e1b8f60 Reviewed-on: https://chromium-review.googlesource.com/1027314Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#553521}
-
Mike West authored
In order to make a reasonable decision about the reasonable-sounding feature request in https://crbug.com/835465, this patch starts processing XFO headers on redirect responses in order to collect metrics about how many requests we'd impact by tightening our enforcement. Bug: 835465 Change-Id: Ieb4571aae10e31fb61f1ccc245da5eb5dab791ae Reviewed-on: https://chromium-review.googlesource.com/1023393 Commit-Queue: Mike West <mkwst@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#553520}
-
Ulan Degenbaev authored
Currently the function adds "other_spaces" that contains the difference between the total metrics and the sum of spaces. If the sizes do not match, then this can result in size_t underflow: https://bugs.chromium.org/p/v8/issues/detail?id=7668 We should just assert that the sizes match and remove "other_spaces". Bug: v8:7668 Change-Id: Ib768cec6b2fb7faf3e2c53a89cbd926547ddf603 Reviewed-on: https://chromium-review.googlesource.com/1016602 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Siddhartha S <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#553519}
-
Henrik Boström authored
The test is flaky. See https://crbug.com/836783. TBR=orphis@chromium.org No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 836783 Change-Id: I854823be77f95bed0d562f5f2968064e7342352e Reviewed-on: https://chromium-review.googlesource.com/1027871Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#553518}
-
Rune Lillesveen authored
The style_ member of StyleResolverState is a ComputedStyle which is being built. There's no reason to have a separate Mutable* method to access it, we can always return it non-const. Bug: 813068 Change-Id: I7282441f2cac2e37ace98d0ee0709baf1ec656ea Reviewed-on: https://chromium-review.googlesource.com/1026682Reviewed-by:
-
