1. 27 Jan, 2010 3 commits
    • mitz@apple.com's avatar
      Fixed an off-by-one error. · ab45f00a
      mitz@apple.com authored
      Reviewed by Simon Fraser.
      
      * rendering/break_lines.cpp:
      (WebCore::shouldBreakAfter):
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53872 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      ab45f00a
    • dimich@chromium.org's avatar
      Avoid reloading iframe on re-parenting between documents. · 7e6503e1
      dimich@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=32848
      
      Reviewed by David Levin.
      
      WebCore:
      
      Achieved by setting a flag on iframe element when it is a target of document.adoptNode(node) operation.
      The flag prevents unload/load cycle and is reset once element is attached to a new document.
      If iframe is adopted but not actually inserted into the tree, it gets unloaded by async timer
      once JS yields, to avoid having active content in non-attached iframe.
      
      Test: fast/frames/iframe-reparenting.html
      
      * dom/Document.cpp:
      (WebCore::Document::adoptNode): If the adopted node is iframe, set a remainsAliveOnRemovalFromTree on it.
      * html/HTMLFrameElementBase.h:
      * html/HTMLFrameElementBase.cpp:
      (WebCore::HTMLFrameElementBase::HTMLFrameElementBase):
      (WebCore::HTMLFrameElementBase::attach): Skip actual loading of the frame if it has remainsAliveOnRemovalFromTree flag. Reset the flag.
      (WebCore::HTMLFrameElementBase::willRemove): Skip unloading the frame if it has remainsAliveOnRemovalFromTree flag set.
      (WebCore::HTMLFrameElementBase::setRemainsAliveOnRemovalFromTree): Set the flag, start the async timer to check if the frame was actually attached.
      (WebCore::HTMLFrameElementBase::checkAttachedTimerFired):
      * html/HTMLFrameOwnerElement.h:
      (WebCore::HTMLFrameOwnerElement::willRemove): Move from private to protected, since it is conditionally called in HTMLFrameElementBase::willRemove now.
      
      LayoutTests:
      
      * fast/frames/iframe-reparenting-expected.txt: Added.
      * fast/frames/iframe-reparenting.html: Added.
      * fast/frames/resources/iframe-reparenting-frame1.html: Added.
      * fast/frames/resources/iframe-reparenting-frame2.html: Added.
      * fast/frames/resources/iframe-reparenting-iframe-content.html: Added.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53871 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      7e6503e1
    • kevino@webkit.org's avatar
      [wx] Build fix, make sure stub function returns a value. · 47d12a9c
      kevino@webkit.org authored
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53870 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      47d12a9c
  2. 26 Jan, 2010 36 commits
    • aroben@apple.com's avatar
      2010-01-26 Adam Roben <aroben@apple.com> · b6a16320
      aroben@apple.com authored
              No review, rolling out r53861.
              http://trac.webkit.org/changeset/53861
              https://bugs.webkit.org/show_bug.cgi?id=33224
      
              Caused 2 regression tests to fail.
      
              * fast/loader/stateobjects/document-destroyed-navigate-back-expected.txt:
              * fast/loader/stateobjects/document-destroyed-navigate-back.html:
      2010-01-26  Adam Roben  <aroben@apple.com>
      
              No review, rolling out r53861.
              http://trac.webkit.org/changeset/53861
              https://bugs.webkit.org/show_bug.cgi?id=33224
      
              Caused 2 regression tests to fail.
      
              * dom/Document.cpp:
              (WebCore::Document::detach):
              (WebCore::Document::registerHistoryItem):
              (WebCore::Document::unregisterHistoryItem):
              * dom/Document.h:
              * history/BackForwardList.cpp:
              (WebCore::BackForwardList::pushStateItem):
              * history/BackForwardListChromium.cpp:
              (WebCore::BackForwardList::pushStateItem):
              * history/HistoryItem.cpp:
              (WebCore::HistoryItem::HistoryItem):
              (WebCore::HistoryItem::~HistoryItem):
              (WebCore::HistoryItem::setStateObject):
              (WebCore::HistoryItem::setDocument):
              (WebCore::HistoryItem::documentDetached):
              * history/HistoryItem.h:
              (WebCore::HistoryItem::document):
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::navigateWithinDocument):
              (WebCore::FrameLoader::loadItem):
              * loader/HistoryController.cpp:
              (WebCore::HistoryController::updateBackForwardListForFragmentScroll):
              (WebCore::HistoryController::pushState):
              (WebCore::HistoryController::replaceState):
              * loader/RedirectScheduler.cpp:
              (WebCore::RedirectScheduler::scheduleHistoryNavigation):
              * page/History.cpp:
              (WebCore::History::stateObjectAdded):
              * page/Page.cpp:
              (WebCore::Page::goToItem):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53869 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      b6a16320
    • mitz@apple.com's avatar
      <rdar://problem/7576663> Crash caused by anonymous list item · 448b68d0
      mitz@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=34183
      
      Reviewed by Beth Dakin.
      
      WebCore: 
      
      Test: fast/lists/anonymous-items.html
      
      enclosingList() and previousListItem() were DOM-based, but in order to work with anonymous
      list items, they need to work with rthe render tree.
      
      * rendering/RenderListItem.cpp:
      (WebCore::isList): Factored out.
      (WebCore::enclosingList): Added this variant that takes a RenderObject.
      (WebCore::previousListItem): Changed to travers the render tree.
      (WebCore::RenderListItem::calcValue): Use the RenderObject version of enclosingList()
      (WebCore::RenderListItem::setExplicitValue): Added an assertion.
      (WebCore::RenderListItem::clearExplicitValue): Ditto.
      
      LayoutTests: 
      
      * fast/lists/anonymous-items.html: Added.
      * platform/mac/fast/lists/anonymous-items-expected.checksum: Added.
      * platform/mac/fast/lists/anonymous-items-expected.png: Added.
      * platform/mac/fast/lists/anonymous-items-expected.txt: Added.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53868 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      448b68d0
    • bweinstein@apple.com's avatar
      Crash in WebKit!WebCore::RenderMenuList::itemStyle · d465668b
      bweinstein@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=34182
      <rdar://7087757>
              
      Reviewed by Jon Honeycutt.
      
      Added bounds checks in RenderMenuList to make sure we are
      not making an out of bounds check in a vector once an option
      element has been deleted. If we are out of bounds, we fall back to
      a default value and return early, and in the case of itemStyle, we use a 
      previous option's style, if it is available.
      
      * manual-tests/select-delete-item.html: Added.
      * rendering/RenderMenuList.cpp:
      (WebCore::RenderMenuList::itemText): If out of bounds check, return early.
      (WebCore::RenderMenuList::itemToolTip): Ditto.
      (WebCore::RenderMenuList::itemIsEnabled): Ditto.
      (WebCore::RenderMenuList::itemStyle): If out of bounds check, try using the 0th index
          option style, then fall back to the select's style if that option doesn't exist.
      (WebCore::RenderMenuList::itemBackgroundColor): If out of bounds check, return early.
      (WebCore::RenderMenuList::itemIsSeparator): Ditto.
      (WebCore::RenderMenuList::itemIsLabel): Ditto.
      (WebCore::RenderMenuList::itemIsSelected): Ditto.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53867 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      d465668b
    • barraclough@apple.com's avatar
      Whoops, fixerate ChangeLog. · b2c2f9cb
      barraclough@apple.com authored
      git-svn-id: svn://svn.chromium.org/blink/trunk@53866 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      b2c2f9cb
    • barraclough@apple.com's avatar
      <<<<<<< .mine · c01d7269
      barraclough@apple.com authored
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53865 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      c01d7269
    • sfalken@apple.com's avatar
      2010-01-26 Steve Falkenburg <sfalken@apple.com> · 2f672628
      sfalken@apple.com authored
              Reviewed by Oliver Hunt.
      
              Windows build references non-existent include paths
              https://bugs.webkit.org/show_bug.cgi?id=34175
      
              * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
              * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:
              * JavaScriptCore.vcproj/WTF/WTFCommon.vsprops:
              * JavaScriptCore.vcproj/jsc/jscCommon.vsprops:
              * JavaScriptCore.vcproj/testapi/testapi.vcproj:
              * JavaScriptCore.vcproj/testapi/testapiCommon.vsprops:
      2010-01-26  Steve Falkenburg  <sfalken@apple.com>
      
              Reviewed by Oliver Hunt.
      
              Windows build references non-existent include paths
              https://bugs.webkit.org/show_bug.cgi?id=34175
      
              * WebKit.vcproj/WebKit.vcproj:
      2010-01-26  Steve Falkenburg  <sfalken@apple.com>
      
              Reviewed by Oliver Hunt.
      
              Windows build references non-existent include paths
              https://bugs.webkit.org/show_bug.cgi?id=34175
      
              * WebCore.vcproj/QTMovieWin.vcproj:
              * WebCore.vcproj/WebCoreCommon.vsprops:
      2010-01-26  Steve Falkenburg  <sfalken@apple.com>
      
              Reviewed by Oliver Hunt.
      
              Windows build references non-existent include paths
              https://bugs.webkit.org/show_bug.cgi?id=34175
      
              * DumpRenderTree/win/DumpRenderTree.vcproj:
              * DumpRenderTree/win/ImageDiff.vcproj:
              * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53864 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      2f672628
    • cfleizach@apple.com's avatar
      Another attempt to get this test to pass for GTK. · f92c9842
      cfleizach@apple.com authored
      Add ability for image maps to be focused via tabbing
      https://bugs.webkit.org/show_bug.cgi?id=17513
      
      * fast/events/tab-imagemap-expected.txt:
      * fast/events/tab-imagemap.html:
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53863 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      f92c9842
    • kenneth@webkit.org's avatar
      [Qt] Separating out the UrlLoader from the QtLauncher in it's · 436c3f15
      kenneth@webkit.org authored
      own implementation and header file.
      
      Reviewed by Ariya Hidayat.
      
      * QtLauncher/main.cpp:
      (main):
      * QtLauncher/urlloader.cpp: Added.
      (UrlLoader::UrlLoader):
      (UrlLoader::loadNext):
      (UrlLoader::init):
      (UrlLoader::getUrl):
      * QtLauncher/urlloader.h: Added.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53862 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      436c3f15
    • darin@chromium.org's avatar
      2010-01-25 Darin Fisher <darin@chromium.org> · 6f81dc43
      darin@chromium.org authored
              Reviewed by Brady Eidson.
      
              Chains of history items representing same-document navigation need to
              always remember that association
      
              https://bugs.webkit.org/show_bug.cgi?id=33224
      
              Replace HistoryItem's Document pointer with a DocumentSequenceNumber.
              During session history traversal, if the current HistoryItem and the
              target HistoryItem have the same DocumentSequenceNumber, then it means
              that the current Document should remain.
      
              NOTE: To support Chromium's serialization of HistoryItems, I generate
              DocumentSequenceNumbers that are unique across application launches.
              DocumentSequenceNumbers are generated using a counter initialized with
              the time of day.
      
              Test: fast/loader/stateobjects/document-destroyed-navigate-back.html
      
              * dom/Document.cpp:
              (WebCore::Document::detach):
              * dom/Document.h:
              * history/BackForwardList.cpp:
              (WebCore::BackForwardList::pushStateItem):
              * history/BackForwardListChromium.cpp:
              (WebCore::BackForwardList::pushStateItem):
              * history/HistoryItem.cpp:
              (WebCore::generateDocumentSequenceNumber):
              (WebCore::HistoryItem::HistoryItem):
              (WebCore::HistoryItem::~HistoryItem):
              (WebCore::HistoryItem::setStateObject):
              * history/HistoryItem.h:
              (WebCore::HistoryItem::setDocumentSequenceNumber):
              (WebCore::HistoryItem::documentSequenceNumber):
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::navigateWithinDocument):
              (WebCore::FrameLoader::loadItem):
              * loader/HistoryController.cpp:
              (WebCore::HistoryController::updateBackForwardListForFragmentScroll):
              (WebCore::HistoryController::pushState):
              (WebCore::HistoryController::replaceState):
              * loader/RedirectScheduler.cpp:
              (WebCore::RedirectScheduler::scheduleHistoryNavigation):
              * page/History.cpp:
              (WebCore::History::stateObjectAdded):
              * page/Page.cpp:
              (WebCore::Page::goToItem):
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53861 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      6f81dc43
    • oliver@apple.com's avatar
      2010-01-26 Oliver Hunt <oliver@apple.com> · aa1cb156
      oliver@apple.com authored
              Reviewed by Geoffrey Garen.
      
              Using JavaScriptCore API with a webkit vended context can result in slow script dialog
              https://bugs.webkit.org/show_bug.cgi?id=34172
      
              Make the APIShim correctly increment and decrement the timeout
              entry counter.
      
              * API/APIShims.h:
              (JSC::APIEntryShimWithoutLock::APIEntryShimWithoutLock):
              (JSC::APIEntryShimWithoutLock::~APIEntryShimWithoutLock):
              (JSC::APICallbackShim::APICallbackShim):
              (JSC::APICallbackShim::~APICallbackShim):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53860 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      aa1cb156
    • cfleizach@apple.com's avatar
      One more attempt to get GTK version to pass. · 53108f5f
      cfleizach@apple.com authored
      Add ability for image maps to be focused via tabbing
      https://bugs.webkit.org/show_bug.cgi?id=17513
      
      * fast/events/tab-imagemap-expected.txt:
      * fast/events/tab-imagemap.html:
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53859 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      53108f5f
    • cfleizach@apple.com's avatar
      Unreviewed. · 576169d6
      cfleizach@apple.com authored
      Attempt to make this test pass on GTK.
      
      Add ability for image maps to be focused via tabbing
      https://bugs.webkit.org/show_bug.cgi?id=17513
      
      * fast/events/tab-imagemap.html:
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53858 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      576169d6
    • cfleizach@apple.com's avatar
      Add ability for image maps to be focused via tabbing · 75ad1167
      cfleizach@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=17513
      
      Reviewed by Darin Adler.
      
      WebCore: 
      
      Test: fast/events/tab-imagemap.html
      
      * accessibility/AXObjectCache.cpp:
      (WebCore::AXObjectCache::focusedImageMapUIElement):
      (WebCore::AXObjectCache::focusedUIElementForPage):
      * accessibility/AXObjectCache.h:
      * accessibility/AccessibilityImageMapLink.h:
      (WebCore::AccessibilityImageMapLink::areaElement):
      (WebCore::AccessibilityImageMapLink::mapElement):
      (WebCore::AccessibilityImageMapLink::isImageMapLink):
      * accessibility/AccessibilityObject.h:
      (WebCore::AccessibilityObject::isImageMapLink):
      * accessibility/AccessibilityRenderObject.cpp:
      (WebCore::AccessibilityRenderObject::accessibilityParentForImageMap):
      * html/HTMLAreaElement.cpp:
      (WebCore::HTMLAreaElement::getPath):
      (WebCore::HTMLAreaElement::getRect):
      (WebCore::HTMLAreaElement::imageElement):
      (WebCore::HTMLAreaElement::isKeyboardFocusable):
      (WebCore::HTMLAreaElement::isFocusable):
      (WebCore::HTMLAreaElement::dispatchBlurEvent):
      (WebCore::HTMLAreaElement::updateFocusAppearance):
      (WebCore::HTMLAreaElement::supportsFocus):
      * html/HTMLAreaElement.h:
      * html/HTMLMapElement.cpp:
      (WebCore::HTMLMapElement::imageElement):
      * html/HTMLMapElement.h:
      * platform/graphics/GraphicsContext.h:
      * platform/graphics/cairo/GraphicsContextCairo.cpp:
      (WebCore::GraphicsContext::drawFocusRing):
      * platform/graphics/haiku/GraphicsContextHaiku.cpp:
      (WebCore::GraphicsContext::drawFocusRing):
      * platform/graphics/mac/GraphicsContextMac.mm:
      (WebCore::drawFocusRingToContext):
      (WebCore::GraphicsContext::drawFocusRing):
      * platform/graphics/qt/GraphicsContextQt.cpp:
      (WebCore::GraphicsContext::drawFocusRing):
      * platform/graphics/skia/GraphicsContextSkia.cpp:
      (WebCore::GraphicsContext::drawFocusRing):
      * platform/graphics/win/GraphicsContextCGWin.cpp:
      (WebCore::GraphicsContext::drawFocusRing):
      * platform/graphics/wince/GraphicsContextWince.cpp:
      (WebCore::GraphicsContext::drawFocusRing):
      * platform/graphics/wx/GraphicsContextWx.cpp:
      (WebCore::GraphicsContext::drawFocusRing):
      * rendering/RenderImage.cpp:
      (WebCore::RenderImage::paint):
      (WebCore::RenderImage::paintFocusRings):
      (WebCore::RenderImage::imageMap):
      * rendering/RenderImage.h:
      * rendering/RenderReplaced.h:
      
      LayoutTests: 
      
      * fast/events/resources/tabindex-focus-blur-all.js:
      (test):
      (testProgrammaticFocus):
      * fast/events/tab-imagemap-expected.txt: Added.
      * fast/events/tab-imagemap.html: Added.
      * fast/events/tabindex-focus-blur-all-expected.txt:
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53857 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      75ad1167
    • pfeldman@chromium.org's avatar
      2010-01-26 Pavel Feldman <pfeldman@chromium.org> · 6c55ec0d
      pfeldman@chromium.org authored
              Reviewed by Timothy Hatcher.
      
              Web Inspector: add support for breakpoints, messages and search into the SourceFrame2.
      
              https://bugs.webkit.org/show_bug.cgi?id=34165
      
              * inspector/front-end/SourceFrame2.js:
              (WebInspector.SourceFrame2):
              (WebInspector.SourceFrame2.prototype.get executionLine):
              (WebInspector.SourceFrame2.prototype.set executionLine):
              (WebInspector.SourceFrame2.prototype.revealLine):
              (WebInspector.SourceFrame2.prototype.addBreakpoint):
              (WebInspector.SourceFrame2.prototype.removeBreakpoint):
              (WebInspector.SourceFrame2.prototype.sizeToFitContentHeight):
              (WebInspector.SourceFrame2.prototype.setContent):
              (WebInspector.SourceFrame2.prototype.findSearchMatches):
              (WebInspector.SourceFrame2.prototype.setSelection):
              (WebInspector.SourceFrame2.prototype._addMessageToSource):
              (WebInspector.SourceFrame2.prototype._addExistingBreakpointsToSource):
              (WebInspector.SourceFrame2.prototype._addBreakpointToSource):
              (WebInspector.SourceFrame2.prototype._removeBreakpointFromSource):
              (WebInspector.SourceFrame2.prototype._contextMenu.addConditionalBreakpoint):
              (WebInspector.SourceFrame2.prototype._contextMenu):
              (WebInspector.SourceFrame2.prototype._toggleBreakpoint):
              (WebInspector.SourceFrame2.prototype._editBreakpointCondition.committed):
              (WebInspector.SourceFrame2.prototype._editBreakpointCondition.dismissed):
              (WebInspector.SourceFrame2.prototype._editBreakpointCondition):
              (WebInspector.SourceFrame2.prototype._showBreakpointConditionPopup):
              (WebInspector.SourceFrame2.prototype._createConditionElement):
              (WebInspector.SourceFrame2.prototype._keyDown):
              (WebInspector.SourceFrame2.prototype._evalSelectionInCallFrame):
              (WebInspector.SourceFrame2.prototype._breakpointChanged):
              (WebInspector.SourceFrame2.prototype.resize):
              (WebInspector.BreakpointLineNumberDecorator.prototype.decorate):
              (WebInspector.BreakpointLineNumberDecorator.prototype._paintBreakpoint):
              (WebInspector.BreakpointLineNumberDecorator.prototype.mouseDown):
              (WebInspector.BreakpointLineNumberDecorator.prototype.contextMenu):
              (WebInspector.ExecutionLineDecorator.prototype.decorate):
              * inspector/front-end/TextEditor.js:
              (WebInspector.TextEditor):
              (WebInspector.TextEditor.prototype.set mimeType):
              (WebInspector.TextEditor.prototype.set readOnly):
              (WebInspector.TextEditor.prototype.setDivDecoration):
              (WebInspector.TextEditor.prototype.reveal):
              (WebInspector.TextEditor.prototype.packAndRepaintAll):
              (WebInspector.TextEditor.prototype._updateSize):
              (WebInspector.TextEditor.prototype.updateCanvasSize):
              (WebInspector.TextEditor.prototype.repaintAll):
              (WebInspector.TextEditor.prototype._paintLinesContinuation):
              (WebInspector.TextEditor.prototype._repaintOnScroll):
              (WebInspector.TextEditor.prototype._mouseDown):
              (WebInspector.TextEditor.prototype._contextMenu):
              (WebInspector.TextEditor.prototype._caretForMouseEvent):
              (WebInspector.TextEditor.prototype._columnForOffset):
              (WebInspector.TextEditor.prototype._handleNavigationKey):
              (WebInspector.TextEditor.prototype._positionDivDecoration):
              (WebInspector.TextEditor.prototype._replaceSelectionWith):
              (WebInspector.TextEditor.prototype.setCoalescingUpdate):
              (WebInspector.TextEditor.prototype._handleUndo):
              (WebInspector.TextEditor.prototype._handleRedo):
              (WebInspector.TextEditor.prototype._changeFont):
              * inspector/front-end/TextEditorHighlighter.js:
              (WebInspector.TextEditorHighlighter):
              (WebInspector.TextEditorHighlighter.prototype.set mimeType):
              * inspector/front-end/inspector.css:
              * inspector/front-end/textEditor.css:
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53856 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      6c55ec0d
    • pfeldman@chromium.org's avatar
      2010-01-26 Pavel Feldman <pfeldman@chromium.org> · cb64ce85
      pfeldman@chromium.org authored
              Reviewed by Timothy Hather.
      
              Web Inspector: add methods for getting resource content from within frontend.
      
              https://bugs.webkit.org/show_bug.cgi?id=34163
      
              * inspector/InspectorBackend.cpp:
              (WebCore::InspectorBackend::getResourceContent):
              * inspector/InspectorBackend.h:
              * inspector/InspectorBackend.idl:
              * inspector/InspectorFrontend.cpp:
              (WebCore::InspectorFrontend::didGetResourceContent):
              * inspector/InspectorFrontend.h:
              * inspector/InspectorFrontendHost.cpp:
              * inspector/InspectorFrontendHost.h:
              * inspector/InspectorFrontendHost.idl:
              * inspector/front-end/InspectorBackendStub.js:
              (.WebInspector.InspectorBackendStub.prototype.getResourceContent):
              * inspector/front-end/InspectorFrontendHostStub.js:
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53855 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      cb64ce85
    • hausmann@webkit.org's avatar
      [Qt] Fix compilation of QtScript with non-gcc compilers · dc44ca23
      hausmann@webkit.org authored
      Variable length stack arrays are a gcc extension. Use QVarLengthArray
      as a more portable solution that still tries to allocate on the stack
      first.
      
      * qt/api/qscriptvalue_p.h:
      (QScriptValuePrivate::call):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53854 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      dc44ca23
    • hausmann@webkit.org's avatar
      [Qt] Fix the build on platforms without JIT support. · 4b6e3e05
      hausmann@webkit.org authored
      Reviewed by Tor Arne Vestbø.
      
      The JIT support should be determined at compile-time via wtf/Platform.h
      
      * qt/api/QtScript.pro:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53853 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      4b6e3e05
    • pfeldman@chromium.org's avatar
      2010-01-26 Pavel Feldman <pfeldman@chromium.org> · 0224085d
      pfeldman@chromium.org authored
              Not reviewed: added null check into the timeline agent getter.
      
              * inspector/InspectorTimelineAgent.h:
              (WebCore::InspectorTimelineAgent::retrieve):
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53852 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      0224085d
    • eric@webkit.org's avatar
      2010-01-26 Simon Hausmann <simon.hausmann@nokia.com> · f910ceb0
      eric@webkit.org authored
              Reviewed by Kenneth Rohde Christiansen.
      
              [Qt] Show comboboxes on Maemo 5
              https://bugs.webkit.org/show_bug.cgi?id=34088
      
              Don't try to show the combobox by simulating a mouse event from QCursor::pos() to
              get the combobox position right. The position on Maemo 5 is independent from the mouse
              and there's no QCursor::pos().
      
              * WebCoreSupport/QtFallbackWebPopup.cpp:
              (WebCore::QtFallbackWebPopup::show):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53851 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      f910ceb0
    • eric@webkit.org's avatar
      2010-01-26 Jedrzej Nowacki <jedrzej.nowacki@nokia.com> · cf8197a8
      eric@webkit.org authored
              Reviewed by Simon Hausmann.
      
              First steps of the QtScript API.
      
              Two new classes were created; QScriptEngine and QScriptValue.
              The first should encapsulate a javascript context and the second a script
              value.
      
              This API is still in development, so it isn't compiled by default.
              To trigger compilation, pass --qmakearg="CONFIG+=build-qtscript" to
              build-webkit.
      
              https://bugs.webkit.org/show_bug.cgi?id=32565
      
              * WebKit.pro:
      2010-01-26  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>
      
              Reviewed by Simon Hausmann.
      
              First steps of the QtScript API.
      
              Two new classes were created; QScriptEngine and QScriptValue.
              The first should encapsulate a javascript context and the second a script
              value.
      
              This API is still in development, so it isn't compiled by default.
              To trigger compilation, pass --qmakearg="CONFIG+=build-qtscript" to
              build-webkit.
      
              https://bugs.webkit.org/show_bug.cgi?id=32565
      
              * qt/api/QtScript.pro: Added.
              * qt/api/qscriptconverter_p.h: Added.
              (QScriptConverter::toString):
              * qt/api/qscriptengine.cpp: Added.
              (QScriptEngine::QScriptEngine):
              (QScriptEngine::~QScriptEngine):
              (QScriptEngine::evaluate):
              (QScriptEngine::collectGarbage):
              * qt/api/qscriptengine.h: Added.
              * qt/api/qscriptengine_p.cpp: Added.
              (QScriptEnginePrivate::QScriptEnginePrivate):
              (QScriptEnginePrivate::~QScriptEnginePrivate):
              (QScriptEnginePrivate::evaluate):
              * qt/api/qscriptengine_p.h: Added.
              (QScriptEnginePrivate::get):
              (QScriptEnginePrivate::collectGarbage):
              (QScriptEnginePrivate::makeJSValue):
              (QScriptEnginePrivate::context):
              * qt/api/qscriptvalue.cpp: Added.
              (QScriptValue::QScriptValue):
              (QScriptValue::~QScriptValue):
              (QScriptValue::isValid):
              (QScriptValue::isBool):
              (QScriptValue::isBoolean):
              (QScriptValue::isNumber):
              (QScriptValue::isNull):
              (QScriptValue::isString):
              (QScriptValue::isUndefined):
              (QScriptValue::isError):
              (QScriptValue::isObject):
              (QScriptValue::isFunction):
              (QScriptValue::toString):
              (QScriptValue::toNumber):
              (QScriptValue::toBool):
              (QScriptValue::toBoolean):
              (QScriptValue::toInteger):
              (QScriptValue::toInt32):
              (QScriptValue::toUInt32):
              (QScriptValue::toUInt16):
              (QScriptValue::call):
              (QScriptValue::engine):
              (QScriptValue::operator=):
              (QScriptValue::equals):
              (QScriptValue::strictlyEquals):
              * qt/api/qscriptvalue.h: Added.
              (QScriptValue::):
              * qt/api/qscriptvalue_p.h: Added.
              (QScriptValuePrivate::):
              (QScriptValuePrivate::get):
              (QScriptValuePrivate::QScriptValuePrivate):
              (QScriptValuePrivate::isValid):
              (QScriptValuePrivate::isBool):
              (QScriptValuePrivate::isNumber):
              (QScriptValuePrivate::isNull):
              (QScriptValuePrivate::isString):
              (QScriptValuePrivate::isUndefined):
              (QScriptValuePrivate::isError):
              (QScriptValuePrivate::isObject):
              (QScriptValuePrivate::isFunction):
              (QScriptValuePrivate::toString):
              (QScriptValuePrivate::toNumber):
              (QScriptValuePrivate::toBool):
              (QScriptValuePrivate::toInteger):
              (QScriptValuePrivate::toInt32):
              (QScriptValuePrivate::toUInt32):
              (QScriptValuePrivate::toUInt16):
              (QScriptValuePrivate::equals):
              (QScriptValuePrivate::strictlyEquals):
              (QScriptValuePrivate::assignEngine):
              (QScriptValuePrivate::call):
              (QScriptValuePrivate::engine):
              (QScriptValuePrivate::context):
              (QScriptValuePrivate::value):
              (QScriptValuePrivate::object):
              (QScriptValuePrivate::inherits):
              (QScriptValuePrivate::isJSBased):
              (QScriptValuePrivate::isNumberBased):
              (QScriptValuePrivate::isStringBased):
              * qt/api/qtscriptglobal.h: Added.
              * qt/tests/qscriptengine/qscriptengine.pro: Added.
              * qt/tests/qscriptengine/tst_qscriptengine.cpp: Added.
              (tst_QScriptEngine::tst_QScriptEngine):
              (tst_QScriptEngine::~tst_QScriptEngine):
              (tst_QScriptEngine::init):
              (tst_QScriptEngine::cleanup):
              (tst_QScriptEngine::collectGarbage):
              (tst_QScriptEngine::evaluate):
              * qt/tests/qscriptvalue/qscriptvalue.pro: Added.
              * qt/tests/qscriptvalue/tst_qscriptvalue.cpp: Added.
              (tst_QScriptValue::tst_QScriptValue):
              (tst_QScriptValue::~tst_QScriptValue):
              (tst_QScriptValue::init):
              (tst_QScriptValue::cleanup):
              (tst_QScriptValue::ctor):
              (tst_QScriptValue::toString_data):
              (tst_QScriptValue::toString):
              (tst_QScriptValue::copyConstructor_data):
              (tst_QScriptValue::copyConstructor):
              (tst_QScriptValue::assignOperator_data):
              (tst_QScriptValue::assignOperator):
              (tst_QScriptValue::dataSharing):
              (tst_QScriptValue::constructors_data):
              (tst_QScriptValue::constructors):
              (tst_QScriptValue::call):
              * qt/tests/tests.pri: Added.
              * qt/tests/tests.pro: Added.
      2010-01-26  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>
      
              Reviewed by Simon Hausmann.
      
              First steps of the QtScript API.
      
              Two new classes were created; QScriptEngine and QScriptValue.
              The first should encapsulate a javascript context and the second a script
              value.
      
              This API is still in development, so it isn't compiled by default.
              To trigger compilation, pass --qmakearg="CONFIG+=build-qtscript" to
              build-webkit.
      
              https://bugs.webkit.org/show_bug.cgi?id=32565
      
              * docs/qtwebkit.qdocconf:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53850 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      cf8197a8
    • eric@webkit.org's avatar
      2010-01-26 Steve Block <steveblock@google.com> · 131e282c
      eric@webkit.org authored
              Reviewed by Adam Barth.
      
              Moves JSC-specific classes from bridge/jni/JNIBridge to bridge/jni/jsc/JNIBridgeJSC
              https://bugs.webkit.org/show_bug.cgi?id=33958
      
              This allows bridge/jni/JNIBridge to be used with both JSC and V8.
              A later change will add the V8 equivalent of these JSC-specific classes.
      
              No new tests, refactoring only.
      
              * Android.jscbindings.mk: Modified. Added JNIBridgeJSC.cpp
              * GNUmakefile.am: Modified. Added JNIBridgeJSC.h
              * WebCore.xcodeproj/project.pbxproj: Modified. Added JNIBridgeJSC.[cpp|h]
              * bridge/jni/JNIBridge.cpp: Modified. Moved JavaField and JavaArray to JNIBridgeJSC.cpp
              (appendClassName): Modfied. Guard calls to JSLock
              (JavaMethod::signature): Modfied. Guard calls to JSLock
              * bridge/jni/JNIBridge.h: Modified. Moved JavaField and JavaArray to JNIBridgeJSC.h
              * bridge/jni/jsc/JNIBridgeJSC.cpp: Copied from WebCore/bridge/jni/JNIBridge.cpp.
              * bridge/jni/jsc/JNIBridgeJSC.h: Copied from WebCore/bridge/jni/JNIBridge.h.
              * bridge/jni/jsc/JNIUtilityPrivate.cpp: Modified. Include JNIBridgeJSC.h
              * bridge/jni/jsc/JavaClassJSC.h: Modified. Include JNIBridgeJSC.h
              * bridge/jni/jsc/JavaInstanceJSC.cpp: Modified. Include JNIBridgeJSC.h
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53849 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      131e282c
    • jocelyn.turcotte@nokia.com's avatar
      Unreviewed build fix. · cfdf673d
      jocelyn.turcotte@nokia.com authored
      [Qt] Fix Windows build when sqlite is not available.
      
      * WebCore.pri:
      * WebCore.pro:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53848 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      cfdf673d
    • hausmann@webkit.org's avatar
      WebCore: [Qt] JavaScript prompt is currently broken. · 236477b4
      hausmann@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=30914
      
      Patch by Holger Hans Peter Freyther <zecke@selfish.org> on 2010-01-26
      Reviewed by Simon Hausmann.
      
      Remove the manual test case in favor of an automated
      test case in WebKit/qt/tests/qwebpage.
      
      * manual-tests/qt/java-script-prompt.html: Removed.
      
      WebKit/qt: [Qt] JavaScript prompt is currently broken
      https://bugs.webkit.org/show_bug.cgi?id=30914
      
      Patch by Holger Hans Peter Freyther <zecke@selfish.org> on 2010-01-26
      Reviewed by Simon Hausmann.
      
      In r52152 a patch was landed to convert a null QString
      to an empty WebCore::String in case the prompt was accepted
      but the default implementation returned the null QString.
      
      The patch tried to avoid assign to result twice and
      was not checking the QString if it is null but the default
      value. This lead to always returning an empty string on
      successful prompts. Fix it by checking the variable 'x'
      for isNull.
      
      The manual test case used didn't cover the case of non
      empty input, replace it with an automatic test case that
      should cover all cases.
      
      * WebCoreSupport/ChromeClientQt.cpp:
      (WebCore::ChromeClientQt::runJavaScriptPrompt): Fix the bug.
      * tests/qwebpage/tst_qwebpage.cpp: Add automatic test case
      (JSPromptPage::JSPromptPage):
      (JSPromptPage::javaScriptPrompt):
      (tst_QWebPage::testJSPrompt):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53847 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      236477b4
    • pfeldman@chromium.org's avatar
      2010-01-26 Pavel Feldman <pfeldman@chromium.org> · f93131b4
      pfeldman@chromium.org authored
              Reviewed by Timothy Hatcher.
      
              Web Inspector: Implement HTML and CSS highlighters.
      
              https://bugs.webkit.org/show_bug.cgi?id=34144
      
              * WebCore.gypi:
              * WebCore.vcproj/WebCore.vcproj:
              * inspector/front-end/JavaScriptTokenizer.js: Removed.
              * inspector/front-end/JavaScriptTokenizer.re2js: Removed.
              * inspector/front-end/SourceCSSTokenizer.js: Added.
              (WebInspector.SourceCSSTokenizer):
              (WebInspector.SourceCSSTokenizer.prototype._stringToken):
              (WebInspector.SourceCSSTokenizer.prototype._isPropertyValue):
              (WebInspector.SourceCSSTokenizer.prototype.nextToken):
              * inspector/front-end/SourceCSSTokenizer.re2js: Added.
              * inspector/front-end/SourceHTMLTokenizer.js: Added.
              (WebInspector.SourceHTMLTokenizer):
              (WebInspector.SourceHTMLTokenizer.prototype._stringToken):
              (WebInspector.SourceHTMLTokenizer.prototype.nextToken):
              * inspector/front-end/SourceHTMLTokenizer.re2js: Added.
              * inspector/front-end/SourceJavaScriptTokenizer.js: Added.
              (WebInspector.SourceJavaScriptTokenizer):
              (WebInspector.SourceJavaScriptTokenizer.prototype.nextToken):
              * inspector/front-end/SourceJavaScriptTokenizer.re2js: Added.
              * inspector/front-end/TextEditorHighlighter.js:
              (WebInspector.TextEditorHighlighter):
              (WebInspector.TextEditorHighlighter.prototype._highlightLines):
              (WebInspector.TextEditorHighlighter.Tokenizer):
              (WebInspector.TextEditorHighlighter.Tokenizer.prototype.set line):
              (WebInspector.TextEditorHighlighter.Tokenizer.prototype.set condition):
              (WebInspector.TextEditorHighlighter.Tokenizer.prototype.get condition):
              (WebInspector.TextEditorHighlighter.Tokenizer.prototype.hasCondition):
              (WebInspector.TextEditorHighlighter.Tokenizer.prototype.getLexCondition):
              (WebInspector.TextEditorHighlighter.Tokenizer.prototype.setLexCondition):
              (WebInspector.TextEditorHighlighter.Tokenizer.prototype._charAt):
              * inspector/front-end/WebKit.qrc:
              * inspector/front-end/inspector.html:
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53846 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      f93131b4
    • hausmann@webkit.org's avatar
      REGRESSION(r53835): Fix editing/pasteboard/paste-noscript-xhtml.xhtml · a7b4fcd6
      hausmann@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=34157
      
      Reviewed by Holger Freyther.
      
      WebCore:
      
      Pass the FragmentScriptingPermission correctly through to the DOM
      and disallow scripting elements in parseEndElement(), similar to
      the libxml tokenizer change in r53835.
      
      * dom/XMLTokenizerQt.cpp:
      (WebCore::handleElementNamespaces):
      (WebCore::handleElementAttributes):
      (WebCore::XMLTokenizer::parseStartElement):
      (WebCore::XMLTokenizer::parseEndElement):
      
      LayoutTests:
      
      Add Qt specific result for this test that differs from the cross-platform
      result in only one character: In htmlcontent.html the href attribute value
      is http://www.cnn.com, which somehow becomes http://www.cnn.com/ in the cross
      platform result. With the Qt xml parser that attribute is somehow preserved
      and so our result does not have the trailing slash.
      
      * platform/qt/editing/pasteboard/paste-noscript-xhtml-expected.txt: Added.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53845 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      a7b4fcd6
    • tkent@chromium.org's avatar
      2010-01-26 Kent Tamura <tkent@chromium.org> · 54862e2f
      tkent@chromium.org authored
              Reviewed by Shinichiro Hamaji.
      
              Convert textarea-rows-cols.html to dumpAsText()
              https://bugs.webkit.org/show_bug.cgi?id=34074
      
              * fast/forms/script-tests/textarea-rows-cols.js: Added.
              * fast/forms/textarea-rows-cols-expected.txt: Added.
              * fast/forms/textarea-rows-cols.html:
              * platform/mac/fast/forms/textarea-rows-cols-expected.checksum: Removed.
              * platform/mac/fast/forms/textarea-rows-cols-expected.png: Removed.
              * platform/mac/fast/forms/textarea-rows-cols-expected.txt: Removed.
              * platform/qt/fast/forms/textarea-rows-cols-expected.txt: Removed.
              * platform/win/fast/forms/textarea-rows-cols-expected.txt: Removed.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53844 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      54862e2f
    • eric@webkit.org's avatar
      2010-01-26 Garret Kelly <gdk@chromium.org> · ea23f952
      eric@webkit.org authored
              Reviewed by Eric Seidel.
      
              Add missing declaration for the feMorphology SVG element.
              https://bugs.webkit.org/show_bug.cgi?id=34151
      
              * bindings/v8/V8DOMWrapper.cpp:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53843 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      ea23f952
    • zoltan@webkit.org's avatar
      Unreviewed build fix. · f7db8494
      zoltan@webkit.org authored
      Patch by Andras Becsi <abecsi@inf.u-szeged.hu> on 2010-01-26
      [Qt] Build fix after API changes in r53835.
      
      No new tests needed.
      
      * dom/XMLTokenizerQt.cpp:
      (WebCore::XMLTokenizer::XMLTokenizer):
      (WebCore::parseXMLDocumentFragment):
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53842 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      f7db8494
    • cjerdonek@webkit.org's avatar
      2010-01-25 Chris Jerdonek <cjerdonek@webkit.org> · 1025c2bc
      cjerdonek@webkit.org authored
              Reviewed by Shinichiro Hamaji.
      
              Refactored check-webkit-style by removing the file path
              parameter from the style error handler functions.
      
              https://bugs.webkit.org/show_bug.cgi?id=34031
      
              * Scripts/webkitpy/style/checker.py:
                - Added _default_style_error_handler() to StyleChecker class.
                - Moved handle_style_error() to inside _default_style_error_handler().
      
              * Scripts/webkitpy/style/checker_unittest.py:
                - Removed file path from calls to error handler.
      
              * Scripts/webkitpy/style/cpp_style.py:
                - Removed file path from calls to error handler.
      
              * Scripts/webkitpy/style/cpp_style_unittest.py:
                - Removed file path from calls to error handler.
      
              * Scripts/webkitpy/style/text_style.py:
                - Removed file path from calls to error handler.
      
              * Scripts/webkitpy/style/text_style_unittest.py:
                - Removed file path from calls to error handler.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53841 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      1025c2bc
    • jorlow@chromium.org's avatar
      2010-01-22 Jeremy Orlow <jorlow@chromium.org> · 506e00c9
      jorlow@chromium.org authored
              Reviewed by Darin Adler.
      
              Make storage events match the spec.
              https://bugs.webkit.org/show_bug.cgi?id=30546
      
              Update the storageEvent algorithm to match the change in WebCore.
      
              * src/StorageAreaProxy.cpp:
              (WebCore::StorageAreaProxy::storageEvent):
      2010-01-22  Jeremy Orlow  <jorlow@chromium.org>
      
              Reviewed by Darin Adler.
      
              Make storage events match the spec.
              https://bugs.webkit.org/show_bug.cgi?id=30546
      
              This meat of the patch I just posted is very simple.  It's just making events
              asynchronous, not posting them to the frame that generated them, passing a null
              for the key when issuing a clear storage event, and making the events
              non-cancelable/non-bubbleable...all of which are clearly stated in the spec.
      
              The asynchronous and not posting to the frame that generated them forced me to
              re-write all the layout tests that dealt with storage events.  There's a lot of
              code there, but I tried to be fairly careful to ensure that test coverage did
              not shrink in any area.
      
              Tests: storage/domstorage/events/basic-body-attribute.html
                     storage/domstorage/events/basic-setattribute.html
                     storage/domstorage/events/basic.html
                     storage/domstorage/events/case-sensitive.html
                     storage/domstorage/events/documentURI.html
      
              * dom/Document.cpp:
              (WebCore::Document::Document):
              (WebCore::Document::enqueueStorageEvent):
              (WebCore::Document::storageEventTimerFired):
              * dom/Document.h:
              * storage/StorageEvent.cpp:
              (WebCore::StorageEvent::StorageEvent):
              * storage/StorageEvent.idl:
              * storage/StorageEventDispatcher.cpp:
              (WebCore::StorageEventDispatcher::dispatch):
      2010-01-22  Jeremy Orlow  <jorlow@chromium.org>
      
              Reviewed by Darin Adler.
      
              Make storage events match the spec.
              https://bugs.webkit.org/show_bug.cgi?id=30546
      
              This meat of the patch I just posted is very simple.  It's just making events
              asynchronous, not posting them to the frame that generated them, passing a null
              for the key when issuing a clear storage event, and making the events
              non-cancelable/non-bubbleable...all of which are clearly stated in the spec.
      
              The asynchronous and not posting to the frame that generated them forced me to
              re-write all the layout tests that dealt with storage events.  There's a lot of
              code there, but I tried to be fairly careful to ensure that test coverage did
              not shrink in any area.
      
              * storage/domstorage/complex-values-expected.txt:
              * storage/domstorage/documentURI-expected.txt: Removed.
              * storage/domstorage/documentURI.html: Removed.
              * storage/domstorage/events: Added.
              * storage/domstorage/events/basic-body-attribute-expected.txt: Added.
              * storage/domstorage/events/basic-body-attribute.html: Added.
              * storage/domstorage/events/basic-expected.txt: Added.
              * storage/domstorage/events/basic-setattribute-expected.txt: Added.
              * storage/domstorage/events/basic-setattribute.html: Added.
              * storage/domstorage/events/basic.html: Added.
              * storage/domstorage/events/case-sensitive-expected.txt: Added.
              * storage/domstorage/events/case-sensitive.html: Added.
              * storage/domstorage/events/documentURI-expected.txt: Added.
              * storage/domstorage/events/documentURI.html: Added.
              * storage/domstorage/events/resources: Added.
              * storage/domstorage/events/resources/body-event-handler.html: Added.
              * storage/domstorage/events/resources/eventTestHarness.js: Added.
              * storage/domstorage/events/resources/setattribute-event-handler.html: Added.
              * storage/domstorage/events/script-tests: Added.
              * storage/domstorage/events/script-tests/TEMPLATE.html: Copied from LayoutTests/storage/domstorage/script-tests/TEMPLATE.html.
              * storage/domstorage/events/script-tests/basic-body-attribute.js: Added.
              * storage/domstorage/events/script-tests/basic-setattribute.js: Added.
              * storage/domstorage/events/script-tests/basic.js: Added.
              * storage/domstorage/events/script-tests/case-sensitive.js: Added.
              * storage/domstorage/events/script-tests/documentURI.js: Added.
              * storage/domstorage/localstorage/iframe-events-expected.txt: Removed.
              * storage/domstorage/localstorage/iframe-events.html: Removed.
              * storage/domstorage/localstorage/index-get-and-set-expected.txt:
              * storage/domstorage/localstorage/index-get-and-set.html:
              * storage/domstorage/localstorage/onstorage-attribute-markup-expected.txt: Removed.
              * storage/domstorage/localstorage/onstorage-attribute-markup.html: Removed.
              * storage/domstorage/localstorage/onstorage-attribute-setattribute-expected.txt: Removed.
              * storage/domstorage/localstorage/onstorage-attribute-setattribute.html: Removed.
              * storage/domstorage/localstorage/onstorage-attribute-setwindow-expected.txt: Removed.
              * storage/domstorage/localstorage/onstorage-attribute-setwindow.html: Removed.
              * storage/domstorage/localstorage/simple-events-expected.txt: Removed.
              * storage/domstorage/localstorage/simple-events.html: Removed.
              * storage/domstorage/script-tests/complex-values.js:
              * storage/domstorage/script-tests/documentURI.js: Removed.
              * storage/domstorage/sessionstorage/iframe-events-expected.txt: Removed.
              * storage/domstorage/sessionstorage/iframe-events.html: Removed.
              * storage/domstorage/sessionstorage/index-get-and-set-expected.txt:
              * storage/domstorage/sessionstorage/index-get-and-set.html:
              * storage/domstorage/sessionstorage/onstorage-attribute-markup-expected.txt: Removed.
              * storage/domstorage/sessionstorage/onstorage-attribute-markup.html: Removed.
              * storage/domstorage/sessionstorage/onstorage-attribute-setattribute-expected.txt: Removed.
              * storage/domstorage/sessionstorage/onstorage-attribute-setattribute.html: Removed.
              * storage/domstorage/sessionstorage/onstorage-attribute-setwindow-expected.txt: Removed.
              * storage/domstorage/sessionstorage/onstorage-attribute-setwindow.html: Removed.
              * storage/domstorage/sessionstorage/simple-events-expected.txt: Removed.
              * storage/domstorage/sessionstorage/simple-events.html: Removed.
              * storage/domstorage/window-attributes-exist-expected.txt:
              * storage/domstorage/window-attributes-exist.html:
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53840 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      506e00c9
    • mitz@apple.com's avatar
      <rdar://problem/7573493> Error with line break inside ?&raquo; pair of characters. · 606f5bb3
      mitz@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=17475
      
      Reviewed by Darin Adler.
      
      WebCore: 
      
      Test: fast/text/line-break-after-question-mark.html
      
      Instead of unconditionally allowing lines to break after a question mark, which was intended
      to mimic Internet Explorer, apply the Unicode line breaking behavior after a question mark,
      with one exception in the ASCII range to match IE, namely not allowing a line break between
      a question mark and a vertical line.
      
      * rendering/break_lines.cpp:
      (WebCore::shouldBreakAfter): Added a next character parameter. Changed to consult a table
      for the question mark case in order to keep it fast and not require a text break iterator in
      the ASCII case.
      (WebCore::nextBreakablePosition): Pass the next character to shouldBreakAfter.
      
      LayoutTests: 
      
      * fast/text/line-break-after-question-mark-expected.txt: Added.
      * fast/text/line-break-after-question-mark.html: Added.
      * fast/text/script-tests/line-break-after-question-mark.js: Added.
      ():
      * platform/mac/tables/mozilla/bugs/bug6674-expected.checksum: Updated.
      * platform/mac/tables/mozilla/bugs/bug6674-expected.png: Updated.
      * platform/mac/tables/mozilla/bugs/bug6674-expected.txt: Updated.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53839 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      606f5bb3
    • pkasting@chromium.org's avatar
      WebCore: Mac scrollbar thumbs were drawn with the wrong size. · 86ed8ce6
      pkasting@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=34049
      
      Reviewed by Dan Bernstein.
      
      * platform/chromium/ScrollbarThemeChromiumMac.mm:
      (WebCore::ScrollbarThemeChromiumMac::paint):
      * platform/mac/ScrollbarThemeMac.mm:
      (WebCore::ScrollbarThemeMac::paint):
      
      LayoutTests: Rebaseline pixel tests affected by changes in scrollbar thumb size.
      https://bugs.webkit.org/show_bug.cgi?id=34049
      
      Reviewed by Dan Bernstein.
      
      * platform/mac/compositing/overflow/overflow-scroll-expected.checksum:
      * platform/mac/compositing/overflow/overflow-scroll-expected.png:
      * platform/mac/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.checksum:
      * platform/mac/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
      * platform/mac/fast/body-propagation/overflow/002-expected.checksum:
      * platform/mac/fast/body-propagation/overflow/002-expected.png:
      * platform/mac/fast/body-propagation/overflow/002-xhtml-expected.checksum:
      * platform/mac/fast/body-propagation/overflow/002-xhtml-expected.png:
      * platform/mac/fast/body-propagation/overflow/003-declarative-expected.checksum:
      * platform/mac/fast/body-propagation/overflow/003-declarative-expected.png:
      * platform/mac/fast/body-propagation/overflow/003-expected.checksum:
      * platform/mac/fast/body-propagation/overflow/003-expected.png:
      * platform/mac/fast/body-propagation/overflow/003-xhtml-expected.checksum:
      * platform/mac/fast/body-propagation/overflow/003-xhtml-expected.png:
      * platform/mac/fast/body-propagation/overflow/004-declarative-expected.checksum:
      * platform/mac/fast/body-propagation/overflow/004-declarative-expected.png:
      * platform/mac/fast/body-propagation/overflow/004-expected.checksum:
      * platform/mac/fast/body-propagation/overflow/004-expected.png:
      * platform/mac/fast/body-propagation/overflow/004-xhtml-expected.checksum:
      * platform/mac/fast/body-propagation/overflow/004-xhtml-expected.png:
      * platform/mac/fast/body-propagation/overflow/007-declarative-expected.checksum:
      * platform/mac/fast/body-propagation/overflow/007-declarative-expected.png:
      * platform/mac/fast/body-propagation/overflow/007-expected.checksum:
      * platform/mac/fast/body-propagation/overflow/007-expected.png:
      * platform/mac/fast/body-propagation/overflow/007-xhtml-expected.checksum:
      * platform/mac/fast/body-propagation/overflow/007-xhtml-expected.png:
      * platform/mac/fast/clip/014-expected.checksum:
      * platform/mac/fast/clip/014-expected.png:
      * platform/mac/fast/forms/basic-textareas-expected.checksum:
      * platform/mac/fast/forms/basic-textareas-expected.png:
      * platform/mac/fast/forms/form-element-geometry-expected.checksum:
      * platform/mac/fast/forms/form-element-geometry-expected.png:
      * platform/mac/fast/forms/listbox-hit-test-zoomed-expected.checksum:
      * platform/mac/fast/forms/listbox-hit-test-zoomed-expected.png:
      * platform/mac/fast/forms/textarea-scroll-height-expected.checksum:
      * platform/mac/fast/forms/textarea-scroll-height-expected.png:
      * platform/mac/fast/inline-block/tricky-baseline-expected.checksum:
      * platform/mac/fast/inline-block/tricky-baseline-expected.png:
      * platform/mac/fast/layers/scroll-rect-to-visible-expected.checksum:
      * platform/mac/fast/layers/scroll-rect-to-visible-expected.png:
      * platform/mac/fast/overflow/002-expected.checksum:
      * platform/mac/fast/overflow/002-expected.png:
      * platform/mac/fast/overflow/003-expected.checksum:
      * platform/mac/fast/overflow/003-expected.png:
      * platform/mac/fast/overflow/005-expected.checksum:
      * platform/mac/fast/overflow/005-expected.png:
      * platform/mac/fast/overflow/007-expected.checksum:
      * platform/mac/fast/overflow/007-expected.png:
      * platform/mac/fast/overflow/008-expected.checksum:
      * platform/mac/fast/overflow/008-expected.png:
      * platform/mac/fast/overflow/childFocusRingClip-expected.checksum:
      * platform/mac/fast/overflow/childFocusRingClip-expected.png:
      * platform/mac/fast/overflow/float-in-relpositioned-expected.checksum:
      * platform/mac/fast/overflow/float-in-relpositioned-expected.png:
      * platform/mac/fast/overflow/image-selection-highlight-expected.checksum:
      * platform/mac/fast/overflow/image-selection-highlight-expected.png:
      * platform/mac/fast/overflow/overflow-auto-position-absolute-expected.checksum:
      * platform/mac/fast/overflow/overflow-auto-position-absolute-expected.png:
      * platform/mac/fast/overflow/overflow-rtl-expected.checksum:
      * platform/mac/fast/overflow/overflow-rtl-expected.png:
      * platform/mac/fast/overflow/overflow-stacking-expected.checksum:
      * platform/mac/fast/overflow/overflow-stacking-expected.png:
      * platform/mac/fast/overflow/overflow-text-hit-testing-expected.checksum:
      * platform/mac/fast/overflow/overflow-text-hit-testing-expected.png:
      * platform/mac/fast/overflow/overflow-with-local-background-attachment-expected.checksum:
      * platform/mac/fast/overflow/overflow-with-local-background-attachment-expected.png:
      * platform/mac/fast/overflow/overflow-x-y-expected.checksum:
      * platform/mac/fast/overflow/overflow-x-y-expected.png:
      * platform/mac/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.checksum:
      * platform/mac/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.png:
      * platform/mac/fast/overflow/scrollbar-position-update-expected.checksum:
      * platform/mac/fast/overflow/scrollbar-position-update-expected.png:
      * platform/mac/fast/overflow/table-overflow-float-expected.checksum:
      * platform/mac/fast/overflow/table-overflow-float-expected.png:
      * platform/mac/fast/repaint/block-selection-gap-stale-cache-2-expected.checksum:
      * platform/mac/fast/repaint/block-selection-gap-stale-cache-2-expected.png:
      * platform/mac/fast/repaint/layout-state-only-positioned-expected.checksum:
      * platform/mac/fast/repaint/layout-state-only-positioned-expected.png:
      * platform/mac/fast/repaint/selection-gap-overflow-scroll-expected.checksum:
      * platform/mac/fast/repaint/selection-gap-overflow-scroll-expected.png:
      * platform/mac/fast/table/edge-offsets-expected.checksum:
      * platform/mac/fast/table/edge-offsets-expected.png:
      * platform/mac/scrollbars/key-window-not-first-responder-expected.checksum:
      * platform/mac/scrollbars/key-window-not-first-responder-expected.png:
      * platform/mac/svg/custom/invisible-text-after-scrolling-expected.checksum:
      * platform/mac/svg/custom/invisible-text-after-scrolling-expected.png:
      * platform/mac/tables/mozilla/bugs/bug149275-1-expected.checksum:
      * platform/mac/tables/mozilla/bugs/bug149275-1-expected.png:
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53838 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      86ed8ce6
    • jorlow@chromium.org's avatar
      Adding myself as reviewer. No review necessary. · 4e8e57b4
      jorlow@chromium.org authored
      Patch by Jeremy Orlow <jorlow@chromium.org> on 2010-01-25
      * Scripts/webkitpy/committers.py:
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53837 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      4e8e57b4
    • andersca@apple.com's avatar
      Featureless build fixes. · e870e371
      andersca@apple.com authored
      * Misc/WebCache.mm:
      (+[WebCache empty]):
      * WebCoreSupport/WebApplicationCache.mm:
      * WebCoreSupport/WebChromeClient.h:
      * WebView/WebDataSource.mm:
      (-[WebDataSource _transferApplicationCache:]):
      * WebView/WebFrame.mm:
      (-[WebFrame _cacheabilityDictionary]):
      * WebView/WebView.mm:
      (WebKitInitializeApplicationCachePathIfNecessary):
      (-[WebView _close]):
      * WebView/WebViewData.mm:
      (-[WebViewPrivate dealloc]):
      (-[WebViewPrivate finalize]):
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53836 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      e870e371
    • enrica@apple.com's avatar
      WebCore: Cleanup unwanted tags after pasting. · c139664f
      enrica@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=34148
              
      Reviewed by Darin Adler.
      
      Test: editing/pasteboard/paste-noscript-xhtml.xhtml
      
      * dom/Element.cpp:
      (WebCore::Element::setAttributeNS):
      * dom/Element.h:
      * dom/XMLTokenizer.h:
      * dom/XMLTokenizerLibxml2.cpp:
      (WebCore::XMLTokenizer::XMLTokenizer):
      (WebCore::handleElementNamespaces):
      (WebCore::handleElementAttributes):
      (WebCore::XMLTokenizer::startElementNs):
      (WebCore::XMLTokenizer::endElementNs):
      (WebCore::parseXMLDocumentFragment):
      * html/HTMLElement.cpp:
      (WebCore::HTMLElement::createContextualFragment):
      
      LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=34148
      
      Reviewed by Darin Adler.
      
      * editing/pasteboard/paste-noscript-xhtml-expected.txt: Added.
      * editing/pasteboard/paste-noscript-xhtml.xhtml: Added.
      * editing/resources/htmlcontent.html: Added.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53835 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      c139664f
    • sfalken@apple.com's avatar
      2010-01-25 Steve Falkenburg <sfalken@apple.com> · 312b83e8
      sfalken@apple.com authored
              Reviewed by Simon Fraser.
      
              A WebGeolocationControllerClient is leaked for every WebView
              https://bugs.webkit.org/show_bug.cgi?id=34145
      
              * WebCoreSupport/WebGeolocationControllerClient.cpp:
              (WebGeolocationControllerClient::geolocationDestroyed): Added.
              * WebCoreSupport/WebGeolocationControllerClient.h:
      2010-01-25  Steve Falkenburg  <sfalken@apple.com>
      
              Reviewed by Simon Fraser.
      
              A WebGeolocationControllerClient is leaked for every WebView
              https://bugs.webkit.org/show_bug.cgi?id=34145
      
              * WebCoreSupport/WebGeolocationControllerClient.h:
              * WebCoreSupport/WebGeolocationControllerClient.mm:
              (WebGeolocationControllerClient::geolocationDestroyed):
      2010-01-25  Steve Falkenburg  <sfalken@apple.com>
      
              Reviewed by Simon Fraser.
      
              A WebGeolocationControllerClient is leaked for every WebView
              https://bugs.webkit.org/show_bug.cgi?id=34145
      
              * page/GeolocationController.cpp:
              (WebCore::GeolocationController::~GeolocationController):
              * page/GeolocationControllerClient.h:
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53834 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      312b83e8
  3. 25 Jan, 2010 1 commit