- 18 Oct, 2017 40 commits
-
-
Takashi Toyoshima authored
blobs.mojom-blink.h internally depends on url.mojom-blink.h. So, we should have //url/mojo:url_mojom_gurl_blink__generator dependency in blob:generator target on which other test_support source_set depends. confirmed that generated ninja files, i.e. ../obj/third_party/WebKit/Source/platform/loader/test_support.ninja has a dependency to obj/url/mojo/url_mojom_gurl_blink_generator.stamp This is a reland of 1cf9f36e Original change's description: > Reland "Reland "Split WebKit platform build file"" > > test_support of platform/loader and platform/network should > depends on //storage/public/interfaces:interfaces_blink__generator > because it indirectly includes generated mojo interface headers. > > This is the root cause of the original issue, and it seems > BUILD file splitting makes it happens more easily. > > This is a reland of 997ce7ad > Original change's description: > > Reland "Split WebKit platform build file" > > > > platform/network/BUILD.gn lacked mojo_bindings_blink dependency. > > This caused a race on compiling. > > > > This is a reland of 080c70a7 > > Original change's description: > > > Split WebKit platform build file > > > > > > A race condition was found in the build of //third_party/WebKit/Source/platform/loader. > > > To resolve it necessary to extract targets //third_party/WebKit/Source/platform/blob and //third_party/WebKit/Source/platform/network form //third_party/WebKit/Source/platform. And add correct dependencies where it is needed. > > > All of these done in this CL. > > > > > > Original author is apisarev@yandex-team.ru, and toyoshim@chromium.org takes over it > > > to submit since it needs quick rebase works to catch up HEAD. > > > > > > Bug: 754600 > > > Change-Id: I5f70348fac10f270df99b658608cf23685ed937e > > > Test: gn check out/Release && ninja -C out/Release > > > Reviewed-on: https://chromium-review.googlesource.com/612284 > > > Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> > > > Reviewed-by: Daniel Bratell <bratell@opera.com> > > > Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org> > > > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > > > Reviewed-by: Dimitri Glazkov <dglazkov@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#508661} > > > > TBR=engedy@chromium.org > > > > Bug: 754600 > > Change-Id: I250e67581e61e1d36c32b01ccad3372b442c08bc > > Reviewed-on: https://chromium-review.googlesource.com/718243 > > Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> > > Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#508993} > > TBR=engedy@chromium.org > > Bug: 754600 > Change-Id: Ia1231a3ee2213bb44474bd8ffeacf67b86002bfd > Reviewed-on: https://chromium-review.googlesource.com/720542 > Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> > Reviewed-by: Emil A Eklund <eae@chromium.org> > Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org> > Cr-Commit-Position: refs/heads/master@{#509359} TBR=jam@chromium.org Bug: 754600 Change-Id: Ica01cdfc20e7cf26e1adf4c42a5fae7ac83a310e Reviewed-on: https://chromium-review.googlesource.com/725139Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#509749}
-
Sam McNally authored
Add a DedicatedWorkerHost and use it to receive interface requests from dedicated workers. Create DedicatedWorkerFactory mojo interface for frames to use when creating dedicated workers. Bug: 734210 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Change-Id: I6a65798e9f59efbb4683c0b67d24bc67c43a96d5 Reviewed-on: https://chromium-review.googlesource.com/696501Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#509748}
-
Mikhail Pozdnyakov authored
As it follows from https://github.com/w3c/sensors/pull/315 Change-Id: I6e2adaae43153fdff3cb792f7e9741652f12f9c0 Reviewed-on: https://chromium-review.googlesource.com/725326Reviewed-by:
Alexander Shalamov <alexander.shalamov@intel.com> Commit-Queue: Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> Cr-Commit-Position: refs/heads/master@{#509747}
-
Sylvain Defresne authored
Bug: none Change-Id: I658af99ffa8bb7ff7551da3c691f8d9e7e11c802 Reviewed-on: https://chromium-review.googlesource.com/724162Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#509746}
-
Marja Hölttä authored
Bug: Change-Id: Ibd1195b37ae1f17dbf280b9e4664c8a3514c6085 Reviewed-on: https://chromium-review.googlesource.com/702355 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by:
Jonathan Metzman <metzman@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#509745}
-
Chris Pickel authored
I removed the tabindex in https://crrev.com/c/720917, but that meant that it was no longer possible to tab to the span and div elements. Bug: 774147 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ic3c40b9b48b2daeb5a59eabfd9f679fc5a0c2e6f Reviewed-on: https://chromium-review.googlesource.com/725288Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Chris Pickel <sfiera@chromium.org> Cr-Commit-Position: refs/heads/master@{#509744}
-
Chris Nardi authored
Update spellcheck_common.cc to pull in the new 8.0 versions of the English dictionaries. Bug: 774804 Change-Id: Iab844509ec206636f1075f0d03d568dcc12304db Reviewed-on: https://chromium-review.googlesource.com/722439Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#509743}
-
Primiano Tucci authored
It is causing too much spam. TBR=ssid Bug: 762723 Change-Id: If4e57ff410d3dcef1c53192edc70536f51161618 Reviewed-on: https://chromium-review.googlesource.com/725383Reviewed-by:
Primiano Tucci <primiano@chromium.org> Commit-Queue: Primiano Tucci <primiano@chromium.org> Cr-Commit-Position: refs/heads/master@{#509742}
-
Klemen Kozjek authored
This CL makes sure that new name for external drive contains only printable ASCII characters. Bug: 775139 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Idffe403d35c9e0870dc2abc6c55b41eeae5599ed Reviewed-on: https://chromium-review.googlesource.com/722486 Commit-Queue: Klemen Kozjek <klemenko@google.com> Reviewed-by:
Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/heads/master@{#509741}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/1f7c31e27e26..079e50bbdeeb $ git log 1f7c31e27..079e50bbd --date=short --no-merges --format='%ad %ae %s' 2017-10-18 angle-deps-roller Roll skia/third_party/externals/angle2/ 0a6752e3c..d042fba42 (1 commit) Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=benjaminwagner@chromium.org Change-Id: I82c639d79429a62cdd0cf2f82245dd9d6b05c061 Reviewed-on: https://chromium-review.googlesource.com/725539Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#509740}
-
Naoki Fukino authored
The blue background for a selected tree item should be visible only when the directory tree is focused. Bug: 459463 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I8042ab72f9fa83359e107028ca72c9b017829385 Reviewed-on: https://chromium-review.googlesource.com/725207Reviewed-by:
Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Commit-Queue: Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/heads/master@{#509739}
-
Mark Cogan authored
- Correct the URL of the public Google ObjC style guide. - Correct the guide to no longer assert that Google ObjC style "inherits" from C++ style. TBR: eugenebut@chromium.org Bug: Change-Id: I67c42c648536d8c0d1fbcd3cfef98424c811bdb1 Reviewed-on: https://chromium-review.googlesource.com/725327Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#509738}
-
Kári Tristan Helgason authored
I will enable other platforms when I have the opportunity to test on them. Bug: 775413 Change-Id: I38fd1308ba3a3e7dcedc8802c813814d737f4fe6 Reviewed-on: https://chromium-review.googlesource.com/725379 Commit-Queue: Kári Tristan Helgason <kthelgason@chromium.org> Reviewed-by:
Henrik Andreasson <henrika@chromium.org> Cr-Commit-Position: refs/heads/master@{#509737}
-
Maxim Kolosovskiy authored
The CL re-uses the constant from bookmarks UI (https://cs.chromium.org/chromium/src/chrome/browser/ui/views/harmony/textfield_layout.cc?rcl=4de610bbd16d98f5e1496eb68e96402214d0a0ec&l=86) Bug: 772893 Change-Id: Iae4969df9a5d022d98699e72645a09ad2653229b Reviewed-on: https://chromium-review.googlesource.com/725283Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#509736}
-
Han Leon authored
BUG=758151 TEST=content_unittests --gtest_filter=ServiceWorkerRegistrationHandleTest.* Change-Id: I348b18919edee58ea5183ac0efedbdbe21e9fb90 Reviewed-on: https://chromium-review.googlesource.com/722723Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Han Leon <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#509735}
-
Lucas Garron authored
This is the sister test to ChromeContentRendererClientBrowserTest.RewriteYouTubeFlashEmbedObject. Both of them are incompatible with preloading HSTS for youtube.com as written. Bug: 771338 Change-Id: I6d3357cbbd3ae978721e0e7c7cafd9410c274db9 Reviewed-on: https://chromium-review.googlesource.com/722448Reviewed-by:
Lucas Garron <lgarron@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Lucas Garron <lgarron@chromium.org> Cr-Commit-Position: refs/heads/master@{#509734}
-
Manuel Rego Casasnovas authored
This patch just removes the free_space argument from free_space was calculated from available_space, so there is no need to pass both as parameters. GridTrackSizingAlgorithm: :Setup(). Change-Id: I0d3122d63884ba187bbf2829fb6d7ca40901e2e8 Reviewed-on: https://chromium-review.googlesource.com/725419Reviewed-by:
Javier Fernandez <jfernandez@igalia.com> Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#509733}
-
Marc Treib authored
During Omnibox navigations, the visible URL is already the new one, so we want the last committed URL. Bug: 774798 Change-Id: Iea1a67b9308d1aa33021501dc63f641506815155 Reviewed-on: https://chromium-review.googlesource.com/723470Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#509732}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/7a12bb43..7c554053 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: I63d0f11b4979987620fd4064e310dd1ebe81a315 Reviewed-on: https://chromium-review.googlesource.com/725040Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#509731}
-
Kunihiko Sakamoto authored
This patch - Moves the face_ member of CSSFontFaceSource into RemoteFontFaceSource - Sets face_ in the constructor so it's non-nullable - Moves PruneTable() from RemoteFontFaceSource to CSSFontFaceSource Pure refactoring, no behavior change. Change-Id: I1e4ec4951c1856d74d37a8a8164de3bc5d9c5399 Reviewed-on: https://chromium-review.googlesource.com/722141Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#509730}
-
Andy Paicu authored
Bug: 651742 Change-Id: I5d03992fa5cbbb492c5091f008b1df8967113bfe Reviewed-on: https://chromium-review.googlesource.com/725341Reviewed-by:
Mike West <mkwst@google.com> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Andy Paicu <andypaicu@chromium.org> Commit-Queue: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#509729}
-
Marc Treib authored
SearchBox may execute JS in response to IPCs, but running JS in the given frame is illegal before the provisional navigation has committed. Bug: 765101 Change-Id: I7fc01989177b768667b5d64c2198b2da3ec0adb9 Reviewed-on: https://chromium-review.googlesource.com/723079Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#509728}
-
Takashi Toyoshima authored
Cache-aware loading is an internal optimization and implementation details that should not be exposed to the fetch event. That makes a hidden request in order to check cache entry existence for legacy sites, but it is useless for modern sites that enables service worker to optimize such resource loading by hands. This patch just stops using the cache-aware loading on service worker enabled pages. It solves the problem that expose the hidden request to the fetch event, and does not cause real world performance impact. Bug: 750612 Change-Id: I8c698ae259274482d35cdbb5abde84c946652cfd Reviewed-on: https://chromium-review.googlesource.com/725026Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#509727}
-
Erik Luo authored
This adds counters to each sidebar item, revealing the number of messages within. Screenshot: https://imgur.com/a/o4pSF Bug: 685283 Change-Id: Iee551c44506d9949b6a1a143ec6650cb12c9f728 Reviewed-on: https://chromium-review.googlesource.com/719958 Commit-Queue: Erik Luo <luoe@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#509726}
-
Koji Ishii authored
Following bot results are included. 1673 1674 1676 1677 1678 1680 1681 1685 1687 1688 1691 1696 1697 1699 1700 1701 1702 1709 1712 1720 1722 1723 1725 1731 30 lines were removed by consecutive passes since 1685. TBR=eae@chromium.org NOTRY=true Bug: 591099 Change-Id: Ib64f101f2ef3ce6c10d56fab65fe6b352f76fedc Reviewed-on: https://chromium-review.googlesource.com/720859 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#509725}
-
Stanislav Albreht authored
It seems that offline_pages component participates in desktop builds whereas it is currently Android only. This puts such dependencies under an appropriate GN variable. Change-Id: Ic6b401ba60e40648eafeaf382068342a5d37d311 Reviewed-on: https://chromium-review.googlesource.com/721701Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Dmitry Titov <dimich@chromium.org> Commit-Queue: Stanislav Albreht <fatalerr@yandex-team.ru> Cr-Commit-Position: refs/heads/master@{#509724}
-
Renee Wright authored
(where possible) Remove commas from ends of lists Remove stray newlines Clarify logical_side comment I have checked to gen diff to verify no change Bug: Change-Id: Iaade785508cec25741dca08e54ea2294a5293eb1 Reviewed-on: https://chromium-review.googlesource.com/717956 Commit-Queue: Renée Wright <rjwright@chromium.org> Reviewed-by:
meade_UTC10 <meade@chromium.org> Cr-Commit-Position: refs/heads/master@{#509723}
-
Alex Clarke authored
Bug: 775513 Change-Id: I5917eeebcf1e86f0e6dc2db588ca18e34452d0c0 Reviewed-on: https://chromium-review.googlesource.com/723421Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#509722}
-
Roman Sorokin authored
Fixes Chrome crash on Chromad devices if DeviceUserWhitelist policy is set Bug: 775834 Test: manual Change-Id: I3264363336d0186d7401ef8733457c1cdbcd1829 Reviewed-on: https://chromium-review.googlesource.com/725421Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: Roman Sorokin <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#509721}
-
Martin Šrámek authored
This reverts commit 0cece6a4. Reason for revert: The test indeed flakes again. Original change's description: > Re-enable TabCaptureApiTest.ApiTests on Mac. > > I have run the test locally multiple times with iteration count of 100 > and 200 without any failures. Re-enabling to see if it will flake on > the bots or whatever the root cause was is possibly fixed. > > Bug: 764464 > Change-Id: Iedd41ec3b7fa1172766ac32196f3c8dbc2994f9d > Reviewed-on: https://chromium-review.googlesource.com/716797 > Reviewed-by: Yuri Wiitala <miu@chromium.org> > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > Commit-Queue: Nasko Oskov <nasko@chromium.org> > Cr-Commit-Position: refs/heads/master@{#508486} TBR=nasko@chromium.org,miu@chromium.org,alexmos@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 764464 Change-Id: I770164ccc298fdb33cf082fc3aa6aef307c10f49 Reviewed-on: https://chromium-review.googlesource.com/725399Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#509720}
-
Daniel Cheng authored
This reverts commit 585cd042. Reason for revert: it's relatively common to load > 2MB data URLs as subresources =( Bug: 774039 Original change's description: > Treat overly long URLs as invalid during canonicalization. > > Bug: 571784 > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation > Change-Id: Ied18e9d76e13028b7077a4ed3631f0a64ce8bdf6 > Reviewed-on: https://chromium-review.googlesource.com/678058 > Commit-Queue: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Asanka Herath <asanka@chromium.org> > Reviewed-by: Charlie Reis <creis@chromium.org> > Reviewed-by: Mike West <mkwst@chromium.org> > Cr-Commit-Position: refs/heads/master@{#506553} TBR=dcheng@chromium.org,creis@chromium.org,asanka@chromium.org,mkwst@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 571784 Change-Id: I011fd8a9bcf5534ec23bcee10cc1de0add21d150 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Reviewed-on: https://chromium-review.googlesource.com/725023Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#509719}
-
Fredrik Söderquist authored
Said function would ignore any size keyword or explicit size specification if there was a shape keyword. Adjust the comparisons so that first any explicit size checked, followed by checking the size keyword and the shape value. Also rewrite the if-ladder for the center point (|first_x_| and |first_y_|) to just use two DataEquivalent. Bug: 775201 Change-Id: I44686b54d3e02e1fd4682c4288eec3aca0e3e441 Reviewed-on: https://chromium-review.googlesource.com/723460Reviewed-by:
meade_UTC10 <meade@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#509718}
-
Dariusz Marcinkiewicz authored
BUG=b:67364190 Change-Id: I4ed4699343fa9604ec4d47a033dc30f3427b628e Reviewed-on: https://chromium-review.googlesource.com/718749 Commit-Queue: Dariusz Marcinkiewicz <darekm@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#509717}
-
Emily Stark authored
- What percentage of connections with EV certificates are CT-compliant? We used to have this histogram but removed it when the EV whitelist was removed. I think it's still useful to have around, as it helps us gauge how often connections that are supposed to be CT-compliant are in fact CT-compliant. For example, a high rate of non-compliant EV certs might indicate that a CA is logging improperly. - What percentage of connections where CT is required are actually CT-compliant? As above, this helps us judge whether servers that are supposed to send CT actually are. The existing count that we have of the ERR_CERTIFICATE_TRANSPARENCY_REQUIRED error code is not enough to tell us this, because it doesn't tell us how many connections were actually supposed to have CT, only how many were supposed to but didn't. The latter histogram requires a modification to the return value of TransportSecurityState::CheckCTRequirements; instead of returning early when a connection is compliant and telling the caller that CT requirements were met, it now differentiates "CT requirements met" from "CT wasn't required". (An alternative approach is to record the histogram inside CheckCTRequirements itself and not modify its return value, but I thought it was preferable to minimize side effects inside that method [even though it does already have other side effects, unfortunately].) Bug: 772534 Change-Id: Ifd3d6f72475e07e1470b0d0b171f9ce0a325807e Reviewed-on: https://chromium-review.googlesource.com/707994 Commit-Queue: Emily Stark <estark@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#509716}
-
arthursonzogni authored
This CL adds a test for issue 769645 that was fixed by: https://chromium-review.googlesource.com/c/709057 It checks that when a browser-initiated same-document navigation happens while the current document is loading, the load isn't interrupted. Bug: 769645 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Change-Id: I2e2ae42d970dacc7217143488b5506759d61f22f Reviewed-on: https://chromium-review.googlesource.com/716756 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#509715}
-
Yutaka Hirano authored
RequestInit is manually implemented and has some compatibility issues. 1. undefined value is treated as a real value, e.g., (new Request('/', {method: undefined}).method returns "undefined". 2. Exceptions are silently ignored, e.g., new Request('/', {get method() { throw Error(); }}) doesn't throw. This change fixes the issues. Bug: 775318 Change-Id: I3d5b2b49f47cfdf92ba0707f6af0260653e386d9 Reviewed-on: https://chromium-review.googlesource.com/722543 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#509714}
-
Sheng-Hao Tsao authored
JPEG encode accelerator interface will be implemented with VAAPI and v4l2 solutions for different platforms. JPEG encode acceleration can be used to reduce camera still capture encoding latency. BUG=b:67488323 TEST=It compiles. Change-Id: I3b135f0ad07971e0ec68684015816f5da02cbb28 Reviewed-on: https://chromium-review.googlesource.com/704619 Commit-Queue: Sheng-hao Tsao <shenghao@google.com> Reviewed-by:
Ricky Liang <jcliang@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#509713}
-
Makoto Shimazu authored
As a step of removing SWReadFromCacheJob, this patch adds a path to get the same installed scripts multiple times. WebServiceWorkerInstalledScriptsManager asks the browser if the script has already been taken, and the browser side counterpart (SWInstalledScriptsSender) sends the script after streaming all of scripts. This is not optimal for sites which importing the same script multiple times, but it simplifies the code. Bug: 756312 Change-Id: I8d8c03fe8488367b5aa1b8d2c02e13a5f25e676e Reviewed-on: https://chromium-review.googlesource.com/697165 Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#509712}
-
Darren Shen authored
Spec: https://drafts.css-houdini.org/css-typed-om-1/#keywordvalue-objects There are no failing tests. Bug: 774887 Change-Id: If78a3e490c406e8743eb591f1e9bdcb28f9fb3a5 Reviewed-on: https://chromium-review.googlesource.com/720582 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Renée Wright <rjwright@chromium.org> Cr-Commit-Position: refs/heads/master@{#509711}
-
Rakina Zata Amni authored
In some cases, relatedTarget kept its value after event dispatch has finished even though target is set to null. See test file for the cases. This change adds a check so that when target is set to null in the post-processing phase, the change is also reflected in relatedTarget. Bug: 771580 Change-Id: Idda5d00c1a793b2669be66e76439851d1f66459c Reviewed-on: https://chromium-review.googlesource.com/720897Reviewed-by:
Hayato Ito <hayato@chromium.org> Reviewed-by:
Takayoshi Kochi <kochi@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#509710}
-