- 14 Jul, 2018 26 commits
-
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1128ebcb6dde..a4e94c6f5b5c git log 1128ebcb6dde..a4e94c6f5b5c --date=short --no-merges --format='%ad %ae %s' 2018-07-14 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 0cc291365934..06ca634eba4a (7 commits) Created with: gclient setdep -r src/third_party/skia@a4e94c6f5b5c The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=robertphillips@chromium.org Change-Id: I5f7672e3336a616d9c3a0d8711c2dda6263996f4 Reviewed-on: https://chromium-review.googlesource.com/1137511Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#575145}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/579c98612b6f..455ee3a61e2b git log 579c98612b6f..455ee3a61e2b --date=short --no-merges --format='%ad %ae %s' 2018-07-13 ehmaldonado@chromium.org bot_update: Don't pass reset-fetch-config to gclient Created with: gclient setdep -r src/third_party/depot_tools@455ee3a61e2b The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:862547 TBR=agable@chromium.org Change-Id: Ib5211668747e1ca339123b4efa6058c774768b63 Reviewed-on: https://chromium-review.googlesource.com/1137491Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#575144}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: I4b9e51747be22bd43e5b0b364b716b09032b13b3 Reviewed-on: https://chromium-review.googlesource.com/1137375Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#575143}
-
Hwanseung Lee authored
replace std::find() with base::containsValue() at components/offline_pages and components/previews and components/safe_browsing Bug: 561800 Change-Id: I5162d0c53126edf6b5cd12fae5fcacab634d2719 Reviewed-on: https://chromium-review.googlesource.com/1134936Reviewed-by:
rajendrant <rajendrant@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com> Cr-Commit-Position: refs/heads/master@{#575142}
-
Francois Doray authored
With this CL, Hangouts should no longer be discarded during a screenshare session. See privacy doc update: https://docs.google.com/a/google.com/document/d/1BNQ5nLOtPuwP7oxr9r-XKNKr5iObXEiA_69WXAvuYAo/edit?disco=AAAACBUojIc Bug: 775644, 857495 Change-Id: I2fa58efc58d1a9c92ae49c5eb308514722637c14 Reviewed-on: https://chromium-review.googlesource.com/1136513Reviewed-by:
Robert Kaplow (slow) <rkaplow@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#575141}
-
Lei Zhang authored
The scale factor code calculation code in CreatePreviewDocument() is getting too big. Change-Id: Id6fded23c2d9e07e8400632cd92c22c3b68bc29b Reviewed-on: https://chromium-review.googlesource.com/1136947Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#575140}
-
Andrew Grieve authored
Bug: 851596 Change-Id: Id4c18ac2be3c5d05b426f4a0f84a9c46b12352e0 Reviewed-on: https://chromium-review.googlesource.com/1137707Reviewed-by:
Marc-Antoine Ruel <maruel@chromium.org> Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org> Cr-Commit-Position: refs/heads/master@{#575139}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/cf403ba5720c..bfeb9343ee79 git log cf403ba5720c..bfeb9343ee79 --date=short --no-merges --format='%ad %ae %s' 2018-07-14 thestig@chromium.org Use more ternary operators in content mark code. Created with: gclient setdep -r src/third_party/pdfium@bfeb9343ee79 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I5373ff7efa6fa60a9d8c04178270a8a0bcb0ba5b Reviewed-on: https://chromium-review.googlesource.com/1137451Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#575138}
-
Sammie Quon authored
Depending on if we start in tablet or clamshell, there can either be a shelf item shown on neither shelf, or a shelf item shown on both shelfs. Test: added test Bug: 863169 Change-Id: Id99c3f270d49db8acea535b689576c3de077ea0c Reviewed-on: https://chromium-review.googlesource.com/1135751 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#575137}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 7e115d5d. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/21207 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: hongchan@chromium.org, rtoy@chromium.org: external/wpt/webaudio TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: I37ec185c314fb37d631e9c0e0d06c4f8eabaa0e6 Reviewed-on: https://chromium-review.googlesource.com/1137479 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#575136}
-
Mina Almasry authored
If the audio underruns or the video decoder implementation on the platform has an issue that prevents it from returning the PTS, these logs become very spammy. Limit them to more reasonable values per play session. Bug: b/111371425 Test: Build Change-Id: Ia03d46733941ce393190d8d742fe8f7aa9e40b2f Reviewed-on: https://chromium-review.googlesource.com/1135933 Commit-Queue: Mina Almasry <almasrymina@chromium.org> Reviewed-by:
Sergey Volk <servolk@chromium.org> Cr-Commit-Position: refs/heads/master@{#575135}
-
dpapad authored
- Update reproduce.sh as necessary. - Add python script to minify Polymer 2 since it does not come minified from bower, unlike Polymer 1. Minified version is 135kb (pre-gzip), which is smaller than Polymer 1 (220kb). - grd files will be modified in follow up CLs, along with the addition of the runtime flag. Bug: 862472 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ia2d084e9ee37c419175831ff64694f47ea277bba Reviewed-on: https://chromium-review.googlesource.com/1132478 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#575134}
-
Alex Moshchuk authored
Currently, when a frame navigates, or a tab closes, we only run beforeunload handlers in the affected frame, but not in its cross-process subframes. This can cause data loss in those subframes. For example, if a subframe contains an editable Google Doc or Office Online doc with unsaved changes, it uses beforeunload to prompt the user about losing those changes. This CL introduces support to dispatch beforeunload handlers to cross-process subframes. We now dispatch multiple FrameMsg_BeforeUnload IPCs and wait for all of them to receive beforeunload ACKs before proceeding with a navigation or tab close. This is done for browser-initiated navigations, renderer-initiated navigations, and when closing a tab or browser. For more details and design discussions, see https://docs.google.com/document/d/1XmwjGNUl_PF9OgDTs0JsRe0iuGrtEk6mzDYGkkbqHKg/edit# A few notable tradeoffs and compromises in this initial CL: - We send one IPC per local root (roughly) and let Blink process same-site descendants. - Cross-site beforeunload handlers run in parallel; we only guarantee ordering among same-site frames. This is similar to how we handle unload handlers. - For now, we always send the beforeunload IPC to a navigating frame. For subframes, we only send it if the subframe has registered a beforeunload handler. - Renderer-initiated navigations still execute the navigating frame's beforeunload before notifying the browser process about the navigation. The browser process then additionally executes any cross-site subframe beforeunload handlers, if needed. This avoids an extra IPC roundtrip. - beforeunload in window.close() is not yet supported. This is essentially a renderer-initiated tab close, and it expects to synchronously set window.closed after executing beforeunload handlers in all subframes. Supporting this is left to a future CL. - Blink currently implements an intervention to limit the number of beforeunload dialogs shown to at most one per navigation. To support this with OOPIFs, similar support is added on the browser side in RFHI::OnRunBeforeUnloadConfirm(). More followup work will be needed here with renderer-initiated navigations and with recording metrics. Change-Id: I0b1f86c119a548ee16d34eff229705748f9560be Bug: 853021 Reviewed-on: https://chromium-review.googlesource.com/1121586 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#575133}
-
Xiangjun Zhang authored
This CL introduced CastMirroringServiceHost that will be created and connected to Mirroring Service when mirroring starts. It is used by Cast Media Router Provider to start/control a mirroring session, and also provides the in-process resources to Mirroring Service. This CL creates a video capture host when requested. More implementation will be added in later CLs. Bug: 734672 Change-Id: I405c10cb29c7fcca48cfe4f508783d4d1456b38c Reviewed-on: https://chromium-review.googlesource.com/1115773 Commit-Queue: Xiangjun Zhang <xjz@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#575132}
-
Alan Cutter authored
These names are useful when printing out the views hierarchy while debugging. Change-Id: Ie574d464c68e8bfb83af06a970f96efc655c912b Reviewed-on: https://chromium-review.googlesource.com/1127507Reviewed-by:
-
Mina Almasry authored
A number of changes to improve AV sync at playback start: - AvSync now will not perform corrections if it measures a slope that is way off from what it expects. There are a number of reasons this could happen: - Samples measured right after resuming playback may be from the paused state, which messes with the measured slope. This is especially important given our current interaction with the BufferingController... - Some vendor video decoder implementations will play video at an accelerated rate if they are not able to start playback in time, to 'catch up' to the required value, and then resume normally. We need to ignore this behavior in AvSync. - Modify the initialization of AvSync a bit to treat Start/Stop similar to Pause/Resume. From the prespective of AvSync these should be identical calls, and should maybe be combined to one in the future. Also, due to the interaction with BufferingController, Start is actually Start + Pause + Resume, so we need to treat Resume as we do for Start, because the start of playback is actually the first Resume. - For AvSync to compare the slope to an expected case, it needs to know the current rate of playback, so add code from MediaPipelineBackend to notify AvSync of playback rate changes. - As a bonus, the playback rate change is handled a bit better now. It's not perfect, but this is the first time I'm testing it as it seems no app supports it. - Add ability for linear regression to dump its samples. This is very useful for debugging unexpected slope calculations. This was very useful to root cause the issue. Bug: b/110481225 Test: Manual Change-Id: I28ffa83c633446f2441ff5dfb8d5674b5e149ea5 Reviewed-on: https://chromium-review.googlesource.com/1132518Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Mina Almasry <almasrymina@chromium.org> Cr-Commit-Position: refs/heads/master@{#575130}
-
Takumi Fujimoto authored
Add CastDialogMetrics, which will be used by CastDialogView to record various UI metrics. The recorder will keep track of when/if certain events (init, paint, load sinks, first user action) happened, to record when an event happens for the first time, and the durations between events. MediaRouterMetrics calls that CastDialogView was making directly will now go through CastDialogMetrics. Metrics recorded by CastDialogMetrics via MediaRouterMetrics: MediaRouter.Ui.Device.Count MediaRouter.Ui.Dialog.Paint MediaRouter.Ui.Dialog.LoadedWithData (new) MediaRouter.Ui.Action.StartLocalPosition MediaRouter.Ui.Action.CloseLatency (new) MediaRouter.Ui.Action.StartLocal.Latency (new) (MediaRouter.Ui.FirstAction will be added later) (MediaRouter.Ui.Action.StopRoute will be added later) Bug: 853369 Change-Id: Ib27ecc9293fd148d8592b76b22c9fbab3910a5e5 Reviewed-on: https://chromium-review.googlesource.com/1135582 Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#575129}
-
Yafei Duan authored
Use the first tile of the 'Most Visited' as the homepage tile when NTPButton is enabled. HomepageClient will be used to provide information of the homepage from Java to native side, and the tile will be added (if necessary) along with other tiles aggregated by MostVisitedSites. The homepage tile will always be the first tile if enabled, currently it would not be degraded as other tiles, unless the user removes it from NTP. This CL mostly revives the code removed by the following CLs: https://chromium-review.googlesource.com/c/chromium/src/+/1087048 https://chromium-review.googlesource.com/c/chromium/src/+/1087270, and ignoring the changes related with Chrome Home. Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I261a0c4cff8e3beb37f4a97db33512abc87b2f23 Reviewed-on: https://chromium-review.googlesource.com/1132613Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Friedrich Horschig <fhorschig@chromium.org> Reviewed-by:
Dmitry Titov <dimich@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Yafei Duan <romax@chromium.org> Cr-Commit-Position: refs/heads/master@{#575128}
-
Ryan Hansberry authored
This provides a simple wrapper around MultiDeviceSetup service, allowing it to easily be stubbed out in tests. R=khorimoto@chromium.org Bug: 824568 Change-Id: I3a15ee75cc2886f15dabd90a8b5bba7712a9201e Reviewed-on: https://chromium-review.googlesource.com/1136897Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#575127}
-
Xiaocheng Hu authored
When the first letter part of a text node has 'visibility' CSS property set to non-visible, while the remaining text remains visible, current TextIterator fails to skip the first letter part and proceed to remaining text correctly. This patch fixes that. This patch also reveals other existing issues in TextIterator, which will be fixed later. Bug: 858924 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Id2a52d229393d9f6c4d3a664ac24d794e836cff1 Reviewed-on: https://chromium-review.googlesource.com/1134487Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#575126}
-
Takumi Fujimoto authored
When the dialog reports the number of sinks, pseudo sinks should be excluded, because they aren't real sinks and they inflate the number of devices recorded. Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ieb8840c0a06c98ca76275e682fcfa42ca52629a8 Reviewed-on: https://chromium-review.googlesource.com/1137029Reviewed-by:
-
Vladimir Levin authored
This is called frequently and might be skewing parent slice times when tracing. R=chrishtr@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ibfc3f81b78b191a5a7e1dfc44933796337763ca7 Reviewed-on: https://chromium-review.googlesource.com/1137337Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#575124}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/882c91ed97c3..579c98612b6f git log 882c91ed97c3..579c98612b6f --date=short --no-merges --format='%ad %ae %s' 2018-07-13 ehmaldonado@chromium.org Reset the fetch config in the bots before each run. Created with: gclient setdep -r src/third_party/depot_tools@579c98612b6f The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:862547 TBR=agable@chromium.org Change-Id: If4f65f2adf63d619ef4846a57255dcdae2d9badf Reviewed-on: https://chromium-review.googlesource.com/1137313Reviewed-by:
-
bsheedy authored
Renames/moves a number of files related to VR/AR testing: 1. "Vr" files that apply to both VR and AR have been renamed to "Xr" 2. "WebVr" tests have been moved to "WebXrVr" 3. "VrShell" tests have been moved to "VrBrowser" 4. //chrome/test/data/vr has been moved to //chrome/test/data/xr Bug: 863256 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I09cd6f7dad1c62377ac13106fbda2050908be138 Reviewed-on: https://chromium-review.googlesource.com/1136009 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#575122}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/b2ecc3dc49dc..c528c0a07f85 git log b2ecc3dc49dc..c528c0a07f85 --date=short --no-merges --format='%ad %ae %s' 2018-07-13 emircan@webrtc.org Revert "Reland "Add Profile 2 configuration to VP9 Encoder and Decoder"" 2018-07-13 mhoro@webrtc.org I have been informed that the fix to libvpx for which the unit test in this CL was created has been rolled into chrome. Consequently, I will again revert to (hopefully) land this CL. 2018-07-13 emircan@webrtc.org Reland "Add Profile 2 configuration to VP9 Encoder and Decoder" Created with: gclient setdep -r src/third_party/webrtc@c528c0a07f85 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I115873bc98e2a78877c7dbc7b269d90fc7d04455 Reviewed-on: https://chromium-review.googlesource.com/1137312Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#575121}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/ecbaf6663915..06ca634eba4a git log ecbaf6663915..06ca634eba4a --date=short --no-merges --format='%ad %ae %s' 2018-07-13 jmadill@chromium.org Vulkan: Refactor for draw call shader patching. 2018-07-13 fjhenigman@chromium.org Vulkan: prepare for buffer format fallbacks. Created with: gclient setdep -r src/third_party/angle@06ca634eba4a The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: I2afba6ae066406e279dd5a8a72ccff80bafa97bb Reviewed-on: https://chromium-review.googlesource.com/1137311Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#575120}
-
- 13 Jul, 2018 14 commits
-
-
Yue Cen authored
This screen should show after the user accepts ARC terms of service. Bug: 835029 Change-Id: Ib17cc71e5c322cbe48fa824c299d5269d30226c1 Reviewed-on: https://chromium-review.googlesource.com/1111334 Commit-Queue: Yue Cen <rsgingerrs@chromium.org> Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#575119}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/a50a4e11ae0f..0cd3404ce483 git log a50a4e11ae0f..0cd3404ce483 --date=short --no-merges --format='%ad %ae %s' 2018-07-13 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@0cd3404ce483 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I67c669c3b7aeb62d34e7bc95c63f066eed3dc36e Reviewed-on: https://chromium-review.googlesource.com/1136773Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#575118}
-
Alexander Alekseev authored
Bug: 857193, b/79987581 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Iebac32d290096c148a615bf0b3d1278a9038649b Reviewed-on: https://chromium-review.googlesource.com/1136010 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
-
Tommy Steimel authored
This reverts commit 76ee32bd. Reason for revert: Histogram recording crashes Chrome if it isn't already open because native isn't initialized. Original change's description: > [Media Intent Handler] Add UMA metrics for media type > > This CL adds a MediaLauncherActivity.MediaType histogram to track the > type of media the user opens with the MediaLauncherActivity > (audio/image/video). > > Bug: 861954 > Change-Id: I28cc0a379ad2bc70d34f2d2f5751c3eb2ebbda45 > Reviewed-on: https://chromium-review.googlesource.com/1135522 > Reviewed-by: Steven Holte <holte@chromium.org> > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> > Commit-Queue: Tommy Steimel <steimel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#575071} TBR=mlamouri@chromium.org,holte@chromium.org,steimel@chromium.org Change-Id: Ic090a8660d6139fc6043a8990b0c6966a9cb311e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 861954 Reviewed-on: https://chromium-review.googlesource.com/1137392Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#575116}
-
Ken Rockot authored
We never want to explicitly close a Channel endpoint until after the corresponding child process is dead. This prevents that from happening in some cases where it's still possible today. TBR=dcheng@chromium.org Bug: 859386,861607,863430 Change-Id: I2858b6e011e06a000ae976c1e6ae96595cf67a85 Reviewed-on: https://chromium-review.googlesource.com/1135712 Commit-Queue: Ken Rockot <rockot@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#575115}
-
chrome://omniboxMark Pearson authored
as this can affect what suggestions are offered a lot, and sometimes isn't obvious from looking at the input. Only show this in "detailed" mode. Also move cursor position information into detailed mode section, as we rarely need it. Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ic78751fe07c968f4fa30854cb7e3bb1442f0fcb2 Reviewed-on: https://chromium-review.googlesource.com/1119232Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#575114}
-
Katie D authored
Fixes a bug by using a "while" rather than an "if" when stepping to the next node in word boundary events. This allows STS to skip nodes if they are not spoken, which may occur if there are nodes that are punctuation only in the list, like ")" or "-". For example, on the English alphabet Wikipedia page, A a * B b * C c * etc, the * node is not spoken, which causes highlight to get delayed because those nodes could not be skipped. Changing the "if" to a "while" fixes that. Bug: 830116,830116 Change-Id: Ic40aa7c32ab10db3a084e94f1d4db49f096abd9c Reviewed-on: https://chromium-review.googlesource.com/1136524Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#575113}
-
Taylor Bergquist authored
The various content setting bubbles were listening to their radio buttons and maintaining a separate copy of the buttons' checkedness state. However, radio buttons didn't notify their listeners when the arrow keys were used to change checkedness; they only notified on mouse events. This CL makes the bubbles refer to the actual radio button state when closing instead of listening to the buttons. It also gets rid of radio button listening as a thing, since it didn't work anyways and nobody else was using it. Other yaks shaved by this change: - Remove Checkbox::set_listener so that it can't be called on radio buttons. Listeners must be added at construction time now. - Move the business logic out of destructors in the content setting bubbles so that the bubble models can reference their views without worrying about them having been already cleaned up. It's now in an explicitly invoked separate method 'CommitChanges'. - The RPH (register protocol handler) content setting bubble was the only one that applied settings changes as users clicked on radio buttons, rather than when the dialog was closed. It's now consistent with the other bubbles. Bug: 841202 Change-Id: I16761571fd03bb1925d95995d8b7e6f0e03aa02a Reviewed-on: https://chromium-review.googlesource.com/1128377Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Taylor Bergquist <tbergquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#575112}
-
Kim Paulhamus authored
-virtual/gpu/fast/canvas/canvas-blend-image.html -external/wpt/requestidlecallback/callback-iframe.html TBR: tkent@chromium.org Bug: 863350, 863599 Change-Id: I56246e6b83ecad9365a2974f82e17f5d8e7de65a Reviewed-on: https://chromium-review.googlesource.com/1137234Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org> Cr-Commit-Position: refs/heads/master@{#575111}
-
liberato@chromium.org authored
This CL adds a cleanup CB to AbstractTexture, so that it can notify the client that it is no longer keeping a reference to the underlying TextureBase. This lets the client perform any cleanup tasks that are associated with either (a) the client dropping the AbstractTexture or (b) the decoder stub being destroyed. This CL also modifies TexturePool to use it, rather than sending a callback to be run when the sync token clears. This has the advantage of freeing codec resources immediately upon context loss, rather relying on VideoFrame cleanup to happen properly when the renderer is being torn down. Bug: 863012 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I672ae8831c1e5a8d92aa3812fa938901d2a171fd Reviewed-on: https://chromium-review.googlesource.com/1135757Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#575110}
-
Reilly Grant authored
This is a follow-up to r564119 where it was suggested that by always returning true from ShouldShowIconBeforeText() the "no devices found" message would be offset to the right. To fix this, when there are no options to display this change hides the table view entirely and displays the message using the same style of overlayed label as the "adapter off" message. Bug: 654137 Change-Id: I7544698425e94fb3d1666ba9c70063091f85f438 Reviewed-on: https://chromium-review.googlesource.com/1117873 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#575109}
-
erikchen authored
There appears to be a bug in Launch Services that causes MallocNanoZone=1 to always be set by default for all applications [this affects applications launched by Finder, and on restart, but not applications launched from the Terminal]. I filed https://bugreport.apple.com/web/?problemID=42181038 to track this. MallocNanoZone causes libMalloc to use the nano malloc zone by default [affects allocations <= 256 bytes]. The implementation of nano malloc never frees memory. See https://bugs.chromium.org/p/chromium/issues/detail?id=861939#c6 for more details. This has been observed to cause > 1GB of wasted memory in the browser process. Possibly a lot more when added up across all processes. To test this: 1) Build Chrome with patch. 2) Run /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/LaunchServices.framework/Versions/A/Support/lsregister -f <path_to_chrome> 3) Launch Chrome from Finder 4) Use "vmmap <pid>" to observe whether there is a MALLOC_NANO summary. Bug: 861939 Change-Id: I740bcbb006e4ce641d0dde6f6e53dcf4f032ff0b Reviewed-on: https://chromium-review.googlesource.com/1137131Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#575108}
-
Oksana Zhuravlova authored
Change-Id: I97dd67db41337f69cc9ed54eb743b7f1664301f3 Reviewed-on: https://chromium-review.googlesource.com/1137271Reviewed-by:
-
Toni Barzic authored
https://chromium.googlesource.com/chromiumos/platform/system_api.git/+log/ec6d4902f36c..0eac64e18aba $ git log ec6d4902f..0eac64e18 --date=short --no-merges --format='%ad %ae %s' 2018-07-09 phongo Un-deprecate supervision_transition field. 2018-07-10 dgreid vm_concierge: Add an export message 2018-07-09 baileyberro system_api: Add StartCopy and ContinueCopy to SmbProvider constants 2018-07-06 tbarzic Add is_demo_session to UpgradeArcContainerRequest 2018-06-26 hychao service_constants: Add GetSystemAecSupported method 2018-06-28 baileyberro system_api: Add Smb Copy Errors 2018-06-22 zachr vm_cicerone: add debug information constants 2018-05-22 xzhou cryptohome: add nvspace bootlockbox protos Created with: roll-dep src/third_party/cros_system_api Change-Id: I1d4d9f055c3fd9e4dbca69755fb3d40a162e0448 Reviewed-on: https://chromium-review.googlesource.com/1137056Reviewed-by:
-
