GitLab

Notable changes:

1. Reorder the cipher suites offered in ClientHello.
https://bugzilla.mozilla.org/show_bug.cgi?id=936828
https://bugzilla.mozilla.org/show_bug.cgi?id=946147

2. Store a random value in the gmt_unix_time field of ClientHello and
ServerHello.
https://bugzilla.mozilla.org/show_bug.cgi?id=937976

3. Handle >= 2048-bit DSA certificates.
https://bugzilla.mozilla.org/show_bug.cgi?id=925591

4. Session ticket renewal bug fixes.
https://bugzilla.mozilla.org/show_bug.cgi?id=930857
https://bugzilla.mozilla.org/show_bug.cgi?id=930874

The following patches are removed.

1. Patches that are no longer necessary because we require NSS 3.14.3:
versionskew.patch
ecpointform.patch
cbc.patch

2. Patches that have been committed in NSS upstream:
renegoscsv.patch
peercertchain.patch	
peercertchain2.patch
negotiatedextension.patch
sslsock_903565.patch	
aesgcm.patch
tls12backuphash.patch	
tls12backuphash2.patch
ciphersuiteversion.patch
resumeclienthelloversion.patch
canfalsestart.patch
nullcipher_934016.patch

3. Miscellaneous:
channelid2.patch: merged with channelid.patch.
disableticketrenewal.patch: bug fixed in the NSS upstream.

R=agl@chromium.org,rsleevi@chromium.org
BUG=331625
TEST=none

Review URL: https://codereview.chromium.org/111853013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243395 0039d316-1c4b-4281-b951-d872f2087c98

V8ObjectStatsMetric would previously capture all V8 statistics.
Added a constructor parameter so that users could capture a subset
of the V8 statistics if desired. Default is as before: capture them
all.

Making this change so that the IndexedDB perf tests (indexeddb_perf)
can be modified to report only a few metrics to simplify the test
results.

Review URL: https://codereview.chromium.org/99903009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243394 0039d316-1c4b-4281-b951-d872f2087c98

http://crbug.com/330416

R=sky@chromium.org

Review URL: https://codereview.chromium.org/120503003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243393 0039d316-1c4b-4281-b951-d872f2087c98

Fix a few instances where !Windows is assumed to be Linux.

Chang many instances of !USE_GTK_MESSAGE_PUMP &&
!OS_MACOSX && !OS_ANDROID to just USE_AURA (they are
equivalent now).

Add a very minimal RootWindowHostMac.

Of note is that building with Aura requires running
"gyp_chromium --no-circular-check" (the circular
check is only enabled on Mac, and doesn't work with
Aura).

Also note that the demo does not work properly unless BGRA
support is disabled (in FeatureInfo::InitializeBasicState these
extensions can be disabled).

BUG=331669

Review URL: https://codereview.chromium.org/110283005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243392 0039d316-1c4b-4281-b951-d872f2087c98

The apps grid uses [NSView menuForEvent:..] for its menus, so needs to
check the button state explicitly to match the behaviour of [NSButton
menu] (which isn't used, e.g., because the NSButton doesn't fill the
grid cell).

This CL adds a check to suppress the menu when the button is in the
"lit" state, which occurs when the button is being held down.

BUG=328835
TEST=Hold the left, then the right, mouse buttons over a app launcher
item. A menu shouldn't appear. Releasing the left button (without moving
the mouse cursor) will launch the item.

Review URL: https://codereview.chromium.org/93793012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243391 0039d316-1c4b-4281-b951-d872f2087c98

BUG=315922
R=dalecurtis@chromium.org
TBR=jam

Review URL: https://codereview.chromium.org/66183002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243390 0039d316-1c4b-4281-b951-d872f2087c98

BUG=151703

Review URL: https://codereview.chromium.org/86743002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243389 0039d316-1c4b-4281-b951-d872f2087c98

These represent the non-Telemetry tests currently running on these bots.

Tested locally on Linux. Will test on other platforms after the initial
commit and update the isolates as necessary.

BUG=321878
R=maruel@chromium.org
TBR=maruel@chromium.org

Review URL: https://codereview.chromium.org/101783011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243388 0039d316-1c4b-4281-b951-d872f2087c98

The transition type of a prerendered page loaded from the omnibox now
has the qualifier PAGE_TRANSITION_FROM_ADDRESS_BAR.

BUG=263246

Review URL: https://codereview.chromium.org/23475040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243387 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243384 0039d316-1c4b-4281-b951-d872f2087c98

The animation was not specifying an NSAnimationContext or duration, which meant
that the duration was not well defined. I used the same value that I observed
on my machine prior to my change. It seems a bit slow, but presumably it's the
value most users are seeing.

BUG=NONE
TEST=NONE

Review URL: https://codereview.chromium.org/110753004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243383 0039d316-1c4b-4281-b951-d872f2087c98

* Create extensions/common/test_util.h for shared test code
* Consolidate duplicated CreateExtensionWithID() functions
* Create extensions_test_support build target because you can't have multiple
  files named test_util.h in a single build target on MSVS, all the other
  names are taken (test_utils.h, extension_test_util.h, etc.), and this gets
  us a step closer to having an extensions-only test suite.
* Fix some missing dependencies for the extensions_common target
* Remove unnecessary includes that create a dependency on themes

BUG=none
TEST=compiles, unit_tests
TBR=thakis@chromium.org for mechanical changes to chrome/browser/ui/cocoa/extensions/

Review URL: https://codereview.chromium.org/110463003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243382 0039d316-1c4b-4281-b951-d872f2087c98

We'll use this in-tree fontconfig when "embedded=1" is set in GYP_DEFINES.

BUG=318315

Review URL: https://codereview.chromium.org/102813007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243381 0039d316-1c4b-4281-b951-d872f2087c98

show at the same time when clicking "Use Google Wallet".

BUG=331935
R=estade@chromium.org
TEST=manual

Review URL: https://codereview.chromium.org/101383006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243380 0039d316-1c4b-4281-b951-d872f2087c98

Remove call of PrerenderTracker::TryCancelOnIOThread in ChromeContentBrowserClient::CanCreateWindow. I moved cancelling the prerender on the UI thread.

BUG=304341
R=jochen@chromium.org, tburkard@chromium.org

Review URL: https://codereview.chromium.org/112573008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243375 0039d316-1c4b-4281-b951-d872f2087c98

BUG=331125
R=navabi@chromium.org, navabi@google.com, skyostil@chromium.org

Review URL: https://codereview.chromium.org/97983005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243372 0039d316-1c4b-4281-b951-d872f2087c98

Accidentally left disabled when the underlying issue was resolved.

BUG=172786,156800

Review URL: https://codereview.chromium.org/118333004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243370 0039d316-1c4b-4281-b951-d872f2087c98

Fix perf and build time output. Previously, times reported were a lot smaller than they really were since we weren't filtering out skipped steps and they were getting averaged in with actual build/run times. This is just a fix in output, no changes to logic.

BUG=
NOTRY=true

Review URL: https://codereview.chromium.org/126253002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243369 0039d316-1c4b-4281-b951-d872f2087c98

And into TransientWindowManager. Additionally moves handling of NULL
layer stacking into TransientStackingWindowClient. The tests that were
exercising these code paths have all been moved to ui/views/corewm.

Also wires up TransientStackingWindowClient in a couple of places that
didn't have it.

The order of removing from transient parent as well as destroying of
transient children is slightly differently than before. To get the
order exactly as it was would require some new specific observer
functions. I'm hoping we don't need those. Hopefully this doesn't
cause issues, if it does I'll revisit.

I ended up exposing convenience functions. That's because typing
something like:

views::corewm::TransientWindowManager::Get(window)->AddTransientChild()

was too much for me. There is also some subtlety in so far as the
Get() function that takes a const Window* may return NULL, where as
non-const never returns NULL.

Lastly I had to make Window friend TransientWindowManager. This is
temporary until I create a specific TransientWindowManagerObserver
that contains the two transient related observer functions in
WindowObserver.

BUG=none
TEST=none
R=ben@chromium.org

Review URL: https://codereview.chromium.org/115453004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243368 0039d316-1c4b-4281-b951-d872f2087c98

This reverts r237591. The added CHECK() breaks the Android WebView and
was added to help diagnose a now-fixed bug that turned out to be
unrelated.

BUG=332079
NOTRY=true

Review URL: https://codereview.chromium.org/106433010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243367 0039d316-1c4b-4281-b951-d872f2087c98

Also remove ChromeURLRequestUserData since no one else is using it.

BUG=304341
R=davidben@chromium.org

Review URL: https://codereview.chromium.org/124383008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243366 0039d316-1c4b-4281-b951-d872f2087c98

Finally remove ResourceRequestInfo::GetAssociatedRenderView. Also remove the shared worker plumbing that existed only to support it.

BUG=304341
R=nasko@chromium.org

Review URL: https://codereview.chromium.org/125513002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243365 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/125773002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243364 0039d316-1c4b-4281-b951-d872f2087c98

BUG=n/a
TEST=compile

Review URL: https://codereview.chromium.org/125553005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243363 0039d316-1c4b-4281-b951-d872f2087c98

BUG=240195

Review URL: https://codereview.chromium.org/124373004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243362 0039d316-1c4b-4281-b951-d872f2087c98

They are not offline available.
See the comments added in the patch and metadata_cache.js.

BUG=none

Review URL: https://codereview.chromium.org/103013004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243361 0039d316-1c4b-4281-b951-d872f2087c98

> IndexedDB: Fix cursor prefetching edge cases
> 
> Cursor prefetch caches must be discarded when other
> requests are made to ensure proper request sequencing.
> Two edge cases were handled improperly if new records
> was written just ahead of the cursor.
> 
> * A reset occurring before the prefetch results were
> received would be ignored; since the newly records
> weren't in the prefetch data, the cursor wouldn't see
> them.
> 
> * A reset occurring after the results are received
> would back up the cursor to before the new records,
> even though the prefetch itself is a "continue"
> and advanced past them already.
> 
> The fix is to reset the cache on receipt if necessary,
> and to ensure the reset state accounts for the implicit
> advance.
> 
> BUG=331570
> 
> Review URL: https://codereview.chromium.org/124323002

TBR=jsbell@chromium.org

Review URL: https://codereview.chromium.org/126263003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243359 0039d316-1c4b-4281-b951-d872f2087c98

> Revert 243291 "[Buildfix] Fix PlatformFileInfo usage in pdf_brow..."
> 
> > [Buildfix] Fix PlatformFileInfo usage in pdf_browsertest.cc
> > 
> > BUG=None
> > TBR=thestig@chromium.org
> > NOTRY=true
> > 
> > Review URL: https://codereview.chromium.org/125973003
> 
> TBR=tzik@chromium.org
> 
> Review URL: https://codereview.chromium.org/126093004

TBR=dxie@chromium.org

Review URL: https://codereview.chromium.org/109733004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243356 0039d316-1c4b-4281-b951-d872f2087c98

Label::OnPaint also draws a focus border, so Link doesn't need to do
it.

BUG=330675
TEST=none
R=ben@chromium.org

Review URL: https://codereview.chromium.org/124553006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243351 0039d316-1c4b-4281-b951-d872f2087c98

When a system menu is showing we continue to get and receive mouse
events while the mouse is over the menu. The tooltip code thinks the
mouse is over the aura::Window and will then show the tooltip. The fix
is to disable tooltips while system menus are showing.

I'm also making the only way to enable/disable tooltips be by way of a
scoper. This should hopefully be less error prone.

BUG=327970
TEST=none
R=varunjain@chromium.org

Review URL: https://codereview.chromium.org/109403008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243350 0039d316-1c4b-4281-b951-d872f2087c98

Fix remaining nits.

BUG=323697

Review URL: https://codereview.chromium.org/125253006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243346 0039d316-1c4b-4281-b951-d872f2087c98

sockets.udp permission is obsolete, as we now depend only on the "sockets" manifest key.

BUG=328973

Review URL: https://codereview.chromium.org/101843008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243345 0039d316-1c4b-4281-b951-d872f2087c98

Cursor prefetch caches must be discarded when other
requests are made to ensure proper request sequencing.
Two edge cases were handled improperly if new records
was written just ahead of the cursor.

* A reset occurring before the prefetch results were
received would be ignored; since the newly records
weren't in the prefetch data, the cursor wouldn't see
them.

* A reset occurring after the results are received
would back up the cursor to before the new records,
even though the prefetch itself is a "continue"
and advanced past them already.

The fix is to reset the cache on receipt if necessary,
and to ensure the reset state accounts for the implicit
advance.

BUG=331570

Review URL: https://codereview.chromium.org/124323002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243344 0039d316-1c4b-4281-b951-d872f2087c98

* Extracted non-Chrome-specific manifest handler registration into
  src/extensions/common/common_manfiest_handlers.cc
* Moved app_shell app load/launch code into ShellExtensionSystem so it can
  signal that the system is ready
* Refactored more of runtime API to use browser context instead of Profile
* Cleaned up or removed some uses of ExtensionService

This allows app_shell to get into the background page loading code before it crashes.

BUG=162530,288226,309909
TEST=existing browser_tests of extension system

Review URL: https://codereview.chromium.org/101203008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243343 0039d316-1c4b-4281-b951-d872f2087c98

BUG=320090
R=abarth@chromium.org, davemoore@chromium.org

Review URL: https://codereview.chromium.org/99623010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243341 0039d316-1c4b-4281-b951-d872f2087c98

BUG=331124
R=isherman@chromium.org

Review URL: https://codereview.chromium.org/123313002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243338 0039d316-1c4b-4281-b951-d872f2087c98

> [Buildfix] Fix PlatformFileInfo usage in pdf_browsertest.cc
> 
> BUG=None
> TBR=thestig@chromium.org
> NOTRY=true
> 
> Review URL: https://codereview.chromium.org/125973003

TBR=tzik@chromium.org

Review URL: https://codereview.chromium.org/126093004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243336 0039d316-1c4b-4281-b951-d872f2087c98

This CL just parses and stores the field for future use.

BUG=324165

Review URL: https://codereview.chromium.org/125553004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243335 0039d316-1c4b-4281-b951-d872f2087c98

This adds a build step to generate mirrored images for use in
right-to-left (RTL) languages. Images are mirrored by flipping the
original image over the vertical axis. Every image must be explicitly
listed as mirrorable or non-mirrorable in a config file.

The goal: ensure that our RTL image assets are always up-to-date.

BUG=290225
NOTRY=true

Review URL: https://codereview.chromium.org/106173002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243332 0039d316-1c4b-4281-b951-d872f2087c98

When setting up the ThreadIdNameManager we need to make a duplicate of the
thread handle on Windows. That handle is currently be leaked as pointed out by
Dr.Memory. This CL closes the handle after the ThreadIdNameManager has removed
the relevant entry.

BUG=315203

Review URL: https://codereview.chromium.org/75133004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243330 0039d316-1c4b-4281-b951-d872f2087c98