GitLab

The bug is that the changes in an onChangesApplied() event is set to
n copies of the first change.

Fix similar bug in test code (which is why this bug wasn't caught).

BUG=69500
TEST=

Review URL: http://codereview.chromium.org/6546009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75373 0039d316-1c4b-4281-b951-d872f2087c98

75361 seems to introduce new crashes caught by reliability:

"anonymous namespace'::purecall____invalid_parameter_noinfo___ots::parselookuplisttable"

BUG=none
TEST=ran try

Review URL: http://codereview.chromium.org/6539010

TBR=bashi@chromium.org
Review URL: http://codereview.chromium.org/6542010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75372 0039d316-1c4b-4281-b951-d872f2087c98

Try to fix the Win Builder (dbg)(shared) build break by adding a dependency from content_browser to WebKit.gyp (TabContents uses WebView's zoom constants and helper functions).

TBR=avi
Review URL: http://codereview.chromium.org/6546013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75371 0039d316-1c4b-4281-b951-d872f2087c98

Start moving core pieces of Chrome multi-process code to src\content.  I'm starting with tab_contents directory.In future changes the headers that include these files will be updated.  Once all the files are moved (i.e. renderer_host, rest of browser, renderer etc), then refactoring can begin so that content\DEPS doesn't have chrome in it.
Review URL: http://codereview.chromium.org/6537015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75369 0039d316-1c4b-4281-b951-d872f2087c98

Changed parsing code for the phonenumbers fields to incorporate different combinations of the phone fields in the forms.
Should fix a lot of the phone parsing bugs and make changes to parsing code much easier.
BUG=71893,71897
TEST=unit-tested, please also check that any web-form that includes a phone number fields gets that fields parsed correctly
Review URL: http://codereview.chromium.org/6480083

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75368 0039d316-1c4b-4281-b951-d872f2087c98

(by https://bugs.webkit.org/show_bug.cgi?id=54632).

Otherwise, landing the WebKit patch results in Chromium build breakage.
Example:
.\glue\media\buffered_resource_loader_unittest.cc(87) : error C2259: 'testing::NiceMock<MockClass>' : cannot instantiate abstract class
    with
    [
      MockClass=webkit_glue::MockWebFrame
    ]
    due to following members:
    'void WebKit::WebFrame::setScrollOffset(const WebKit::WebSize &)' : is abstract
    c:\b\build\slave\webkit-win-latest-rel\build\src\third_party/WebKit/Source/WebKit/chromium/public/WebFrame.h(146) : see declaration of 'WebKit::WebFrame::setScrollOffset'

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/6538049

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75367 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:12188
TEST=manually on netbook

Review URL: http://codereview.chromium.org/6532050

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75366 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=evan
Review URL: http://codereview.chromium.org/6538051

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75365 0039d316-1c4b-4281-b951-d872f2087c98

the benchmark lab.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/6519042

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75364 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=ran try

Review URL: http://codereview.chromium.org/6539010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75361 0039d316-1c4b-4281-b951-d872f2087c98

Since Callback<> is essentially a smartpointer, some introspective APIs are
required for sensible usage.

BUG=35223
TEST=new unittests

Review URL: http://codereview.chromium.org/6507029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75360 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6538043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75353 0039d316-1c4b-4281-b951-d872f2087c98

BUG=73252
TEST=see bug

Review URL: http://codereview.chromium.org/6543003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75352 0039d316-1c4b-4281-b951-d872f2087c98

Detect this case and automatically switch to showing the menu above the button in this case.
BUG=69996
TEST=NONE
Review URL: http://codereview.chromium.org/6531019

TBR=maf@chromium.org
Review URL: http://codereview.chromium.org/6544010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75351 0039d316-1c4b-4281-b951-d872f2087c98

BUG=73558
TEST=None

Review URL: http://codereview.chromium.org/6469040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75350 0039d316-1c4b-4281-b951-d872f2087c98

BUG=73358
TEST=None

Review URL: http://codereview.chromium.org/6532046

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75349 0039d316-1c4b-4281-b951-d872f2087c98

BUG=73558
TEST=None

Review URL: http://codereview.chromium.org/6538040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75348 0039d316-1c4b-4281-b951-d872f2087c98

Revert 75306 - Force native frames to repaint when OnNCActivate is called. With a profile menu button added to the GlassBrowserFrameView, failure to trigger the frame repaint means that the button will remain in the active state even when the frame has been deactivated.

DesktopNotification tests failing on win full - speculative revert since this is the only CL in the range that seems possibly related.

BUG=none
TEST=frames behave normally in Aero mode, when activated and deactivated.

Review URL: http://codereview.chromium.org/6507044

TBR=mirandac@chromium.org
Review URL: http://codereview.chromium.org/6546006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75347 0039d316-1c4b-4281-b951-d872f2087c98

Split up sync_index.html into chrome_sync.js and various included
html files.

Added simple Event and AsyncFunction classes to abstract out the grungy
WebUI communication details.

BUG=69500
TEST=

Review URL: http://codereview.chromium.org/6531038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75345 0039d316-1c4b-4281-b951-d872f2087c98

throw away junk profiles. Includes a dataset converter script
to convert csv file into profile dictionary list.

testMergeDuplicateProfilesInAutofill

Added additional tests:
testFilterMalformedEmailAddresses - covers fixed bug 73654.
testFilterIncompleteAddresses - covers fixed bug 71710.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6246147

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75344 0039d316-1c4b-4281-b951-d872f2087c98

BUG=73241
Review URL: http://codereview.chromium.org/6507033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75343 0039d316-1c4b-4281-b951-d872f2087c98

Detect this case and automatically switch to showing the menu above the button in this case.
BUG=69996
TEST=NONE
Review URL: http://codereview.chromium.org/6531019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75342 0039d316-1c4b-4281-b951-d872f2087c98

There was a race condition in the chromoting extension javascript. We wait
for OnUpdated() in order to send the chromoting tab a request for connection.
However OnUpdated() is insufficient for the chromoting tab is fully loaded.
And thus sending a request may not always work. This change will wait for the
tab to go to a "complete" status before a request is sent.

BUG=73202
TEST=Click on chromoting connect, it should always connect

Review URL: http://codereview.chromium.org/6532042

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75341 0039d316-1c4b-4281-b951-d872f2087c98

BUG=59945, 59946
TEST=trybots

Review URL: http://codereview.chromium.org/6541006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75340 0039d316-1c4b-4281-b951-d872f2087c98

BUG=68954
TEST=Sign into sync for first time with --vmodule="*/sync/*"=1 and see what gets printed

Review URL: http://codereview.chromium.org/6534013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75336 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/6018010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75335 0039d316-1c4b-4281-b951-d872f2087c98

Delete accessor declaration for an NSMenu object that doesn't exist in the code any more.
Review URL: http://codereview.chromium.org/6546001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75334 0039d316-1c4b-4281-b951-d872f2087c98

Fixed a corner case issue with printing XPS documents to the Microsoft XPS Document Writer which would not generate a job id.

BUG=None
TEST=Test submitting an XPS document to the XPS Document Writer via cloud print.

Review URL: http://codereview.chromium.org/6544002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75333 0039d316-1c4b-4281-b951-d872f2087c98

BUG=73178
TEST=unittests

This adds two tests for the basic list-management functionality of the BackgroundApplicationListManager.  The first minimizes testing logic with explicit adding and removing of Background Apps and other extensions.  The second does more extensive testing over a large series of operations that add and remove Background App and other extensions.

Review URL: http://codereview.chromium.org/6525056

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75332 0039d316-1c4b-4281-b951-d872f2087c98

This also changes the FileRef interface to remove the Query function, since
there is no close function, there's no way to cancel the current request, which
makes memory management of the info structure very difficult.

Review URL: http://codereview.chromium.org/6519057

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75331 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=compiles

Review URL: http://codereview.chromium.org/6532008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75330 0039d316-1c4b-4281-b951-d872f2087c98

a filesystem: URL that refers to a directory.

This avoids leaking implementation details of the sandboxed filesystem.

Review URL: http://codereview.chromium.org/6537011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75329 0039d316-1c4b-4281-b951-d872f2087c98

TEST=trybots
BUG=none

Review URL: http://codereview.chromium.org/6534026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75327 0039d316-1c4b-4281-b951-d872f2087c98

BUG=41073
TEST=hover the icon in the omnibox, you should see "View site information".

Review URL: http://codereview.chromium.org/6531033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75326 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6538033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75325 0039d316-1c4b-4281-b951-d872f2087c98

BUG=NONE
TEST=NONE

Review URL: http://codereview.chromium.org/6544001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75324 0039d316-1c4b-4281-b951-d872f2087c98

BUG=73252
TEST=see bug

Review URL: http://codereview.chromium.org/6539013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75323 0039d316-1c4b-4281-b951-d872f2087c98

BUG=73198
TEST=self

Review URL: http://codereview.chromium.org/6534004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75322 0039d316-1c4b-4281-b951-d872f2087c98

The theme on the gallery that corresponds to classic has a real extension id
that we need to detect. By the time the BrowserThemeProvider can detect it, it
has already been unpacked so just hard code the extension ID into chrome.

BUG=67751
TEST=Install a theme, verify that 'use classic theme' is enabled, install Default theme, verify that 'use classic theme' is disabled

Review URL: http://codereview.chromium.org/6532033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75321 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75320 0039d316-1c4b-4281-b951-d872f2087c98