- 24 May, 2019 40 commits
-
-
Jay Harris authored
Bug: 906508 Change-Id: I7a1484874fd2afe1d7b4603b0de1ae6f20d08bbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1624066 Commit-Queue: Jay Harris <harrisjay@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#662986}
-
Kuo Jen Wei authored
Bug: None Change-Id: Ifbbbe1ad0c5f50ea7454e1256b0ba8f9cdce2e55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1624365Reviewed-by:
Sheng-hao Tsao <shenghao@chromium.org> Commit-Queue: Kuo Jen Wei <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#662985}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/e794ddc8a662..431ef2fdd373 git log e794ddc8a662..431ef2fdd373 --date=short --no-merges --format='%ad %ae %s' 2019-05-24 minkyu.jeong@samsung.com Add support for EXT_blend_minmax Created with: gclient setdep -r src/third_party/angle@431ef2fdd373 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@google.com Change-Id: I8a3c4976ac8d14931b8307fe1bb57ce662d5265e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628547Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#662984}
-
Tsuyoshi Horo authored
The existing SXG prefetch browsertests doesn't check the typical cross origin SXG loading behavior involving sender and distributor and publisher. This CL adds PrefetchedSignedExchangeCache_CrossOrigin, and PrefetchAlternativeSubresourceSXG_CrossOrigin tests. Bug: 935267 Change-Id: I3017c08c2096d2dba42227894db3519e542eae9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627846Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#662983}
-
Luciano Pacheco authored
Conversion done manually. Added static method "decorate" since it isn't using cr.ui.define anymore. This is the same idea used in FileTable, ComboButton, ProgressCenterItemElement and DirectoryTree. Manually tested "refresh" button triggering its command. Bug: 778674 Change-Id: Ib01207f6336d9f003d6c6d159ca4cc20ebab7e96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626843 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: François Degros <fdegros@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
François Degros <fdegros@chromium.org> Cr-Commit-Position: refs/heads/master@{#662982}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/c1c0d6d8ad74..316f3ac13b51 git log c1c0d6d8ad74..316f3ac13b51 --date=short --no-merges --format='%ad %ae %s' 2019-05-23 sukhanov@webrtc.org Datagram Transport Integration Created with: gclient setdep -r src/third_party/webrtc@316f3ac13b51 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I16523a8fc4f0f365f4a317eb003c655e4086e9c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627584Reviewed-by:
-
Tsuyoshi Horo authored
Data URL for cert-url had been supported. But after crrev.com/c/1577483 which landed in 76.0.3774.0, Chrome failes to load the data URL when NetworkService is enabled. To fix this issue, this CL change SignedExchangeCertFetcher to use DataURLLoaderFactory when the cert-url's scheme is "data:". Bug: 966736,939871 Change-Id: I352caf29e54f288371f18266597f5374ab7ca2bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628488Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#662980}
-
Donna Wu authored
This CL changed //services/device/public/cpp/test:test_support to //services/device/public/cpp:test_support or conciseness, and merged separated target ":serial" to the main "mojom" target of services' public mojo interfaces as it has no special requirement and it's not a good practice to keep a transitive dependency through public_deps. Bug: null Change-Id: I2bcd95e23d6c776f442675b74e2b3d1275ef598d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614425 Commit-Queue: Donna Wu <donna.wu@intel.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#662979}
-
Alan Cutter authored
This CL changes the default action in a PWA install confirmation dialog to be nothing. Before this change it was cancel. This is in the interest of consistency with other situations where we don't want "do security sensitive action" to be the default and for accessibility concerns. Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=392968&signed_aid=sk4b6UZkAkZ9U6T9qqwovw==&inline=1 After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=395017&signed_aid=jecG6nW4xOnmcpJS4uDMYA==&inline=1 Bug: 957848 Change-Id: Id2b39cac3685891db5605b12aeaa2d069236316a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626842 Commit-Queue: Jay Harris <harrisjay@chromium.org> Auto-Submit: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Jay Harris <harrisjay@chromium.org> Cr-Commit-Position: refs/heads/master@{#662978}
-
Jay Harris authored
We weren't taking the TopContainer's (where the window close buttons live) height into account. This adds the result of GetTopInset to GetWindowBoundsFromClientBounds on ChromeOS, which other platforms were doing already. In addition, it ensures that the FrameHeader is correctly setup, so the size constraints will be correct. Before and After screenshots for opening a 480x300px popup Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=394786&signed_aid=1sRqzN7-EINNjSfsWHhj6A==&inline=1 After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=394787&signed_aid=EIwCu-QkBAjpW1dGVHvu_Q==&inline=1 A second CL (https://chromium-review.googlesource.com/c/chromium/src/+/1626441) fixes a separate but related bug and adds tests to ensure this does not regress. Bug: 777854 Change-Id: Ia4f9170a5bf538fd40bd1ce34056a5693f773047 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626909 Commit-Queue: Jay Harris <harrisjay@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#662977}
-
Noel Gordon authored
There are no #include <files> present in the build (piex) directory so the "-I ." flag does nothing anymore, remove it. Bug: 935285 Change-Id: I7aa2c4c30f417c8a9930edf1f9e57badadcb71c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627836Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#662976}
-
Tetsui Ohkubo authored
When ExoRawGamepadInfo is enabled, exo sends raw gamepad scancode to ARC instead of Web Gamepad keycode, and it's remapped in Android. (See https://crrev.com/c/1612857) This CL makes the similar change to analog sticks. In order to do that, Exo also has to forward motion range information to ARC, so it adds new Wayland events, axis_added and activated. This is a part of the effort to improve ARC Gampad compatibility. Design doc: go/arc-improved-gamepad TEST=manual(--enable-features=ExoRawGamepadInfo to /etc/chrome_dev.conf) BUG=b:130597086 Change-Id: If713d4b28bff934ee2d3beba54d3cc15995f6825 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1624385 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Malay Keshav <malaykeshav@chromium.org> Reviewed-by:
Mitsuru Oshima (OOO 5/23) <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#662975}
-
Yoshifumi Inoue authored
This patch makes |HarfBuzzRunGlyphData| four byte smaller by omitting structure alignment padding to reduce memory usage for Windows. Note: Linux doesn't insert padding after |unit16_t|. In rude estimation, we can reduce: number_of_character_in_page × 4 byte per page. Example: https://en.wikipedia.org document.body.innerText.length = 9681 Thus, we can reduce 38,724 byte. Before this patch: +----------+----------+ +0 | utin16_t | padding | +----------+----------+ +4 | bit field | +----------+----------+ +8 | float advance | +----------+----------+ ... sizeof(HarfBuzzRunGlyphData)==20 After this patch: +----------+----------+ +0 | bit field | +----------+----------+ +4 | float advance | +----------+----------+ ... sizeof(HarfBuzzRunGlyphData)==16 Bug: 965564 Change-Id: I73cae1096d74168ead1e2e48251dc2d50597e7e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627832 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#662974}
-
Takashi Toyoshima authored
With this change, specifying port in the manifest URLPattern works even for CORS bypassing rules. Bug: 936900 Change-Id: I3744b65307c923c9c593efef7a41a651ab67d494 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619530 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#662973}
-
May Lippert authored
This change: 1) Creates a new os_a11y_page that has the non-OS bits removed 2) Makes a11y_page show the link to the store if OS settings is enabled to have parity with Win/Mac/Linux BUG=950007 Change-Id: I54acaefbc4b000ba3c5523c03cf92645ce3acee5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626028 Auto-Submit: May Lippert <maybelle@chromium.org> Commit-Queue: May Lippert <maybelle@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#662972}
-
Yang Guo authored
R=jshin@chromium.org Bug: chromium:938223 Change-Id: Ifa6392cd4d657e76d87f6a9f96c8ad610291cfef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520406 Auto-Submit: Yang Guo <yangguo@chromium.org> Reviewed-by:
Jungshik Shin <jshin@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#662971}
-
Tetsui Ohkubo authored
Linux's input_absinfo offers axis information of gamepad devices. In order to improve gamepad support in ARC++, we need this information in Exo. To do that, we have to subclass ui::InputDevice and add ui::GamepadDevice. This is based on another example of subclassing ui::InputDevice, which is ui::TouchscreenDevice. Design doc: go/arc-improved-gamepad TEST=manual BUG=b:130597086 Change-Id: I7656740f77dce035856cc5a847472d5e10e0f1fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1624285 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Kevin Schoedel <kpschoedel@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#662970}
-
Victor Fei authored
- Implemented firing property changed event for UIA_AriaPropertiesPropertyId and associated unit and browser dump tests for the following AriaProperties: - dropeffect - grabbed - Added internal blink representation for aria-grabbed and aria-dropeffect and associated tests. - Removed support for aria attributes: - channel - secret - tabindex from AXPlatformNodeWin::ComputeUIAProperties since these attributes do not exist in the WAI-ARIA spec, even though they are referenced in the UIA spec. - Documentation on UI Automation AriaProperties (see the second table's last column for AriaProperties properties): https://docs.microsoft.com/en-us/windows/desktop/WinAuto/uiauto-ariaspecification Bug: 928949 Change-Id: I2243479a212353410145e210b0992a07306106e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576280Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Ian Prest <iapres@microsoft.com> Commit-Queue: Victor Fei <vicfei@microsoft.com> Cr-Commit-Position: refs/heads/master@{#662969}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/93490699ae99..45750efbcdf2 Created with: gclient setdep -r src-internal@45750efbcdf2 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome BUG=chromium:891734 TBR=lowell@google.com,kmilka@google.com,yutak@google.com Change-Id: Ifbc4be33afdfa49bcd2c4cdba2a9795018f081c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628262Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#662968}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/d2683459da1d..e794ddc8a662 git log d2683459da1d..e794ddc8a662 --date=short --no-merges --format='%ad %ae %s' 2019-05-24 jiawei.shao@intel.com OpenGL: Remove all attachments before executing internal clear Created with: gclient setdep -r src/third_party/angle@e794ddc8a662 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@google.com Change-Id: Ie1c437b255aba04f2aa5383511f08c0933984d64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628447Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/a541b28d4eba..54434e7e1dab git log a541b28d4eba..54434e7e1dab --date=short --no-merges --format='%ad %ae %s' 2019-05-24 eliribble@chromium.org Ignore git submodules when calculating dirty files. Created with: gclient setdep -r src/third_party/depot_tools@54434e7e1dab The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:958499 TBR=agable@chromium.org Change-Id: I0ba1de16f1c9cc680c9abba5da054f89cf500633 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628338Reviewed-by:
-
Jia authored
Bug: 881215 Change-Id: I1857c6393a7faebfcc87610af3f455fc0f07bc98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627269Reviewed-by:
Andrew Moylan <amoylan@chromium.org> Commit-Queue: Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#662965}
-
Wei Lee authored
This CL enables DMA-buf encoding on VAAPI JEA to optimize the performance and reduce the CPU consumption. Bug: 944705, b/123057886 Test: Manually Test: ./jpeg_encode_accelerator_unittest Change-Id: I05d80c8bb649b0c09ad26d3545377c77e3d385bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1532135 Commit-Queue: Wei Lee <wtlee@chromium.org> Reviewed-by:
Ricky Liang <jcliang@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Tommi <tommi@chromium.org> Reviewed-by:
-
Sunny Sachanandani authored
WaitForVBlank returns very early when the monitor goes to sleep. Fallback to Sleep() if that happens. Bug: 965936 Change-Id: I4df347d56a3ec12c02ae398a9b9325c93845fb44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628159 Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#662963}
-
Hiroki Nakagawa authored
This reverts commit c95749d2. Reason for revert: Some web_tests are crashing due to this change. https://test-results.appspot.com/data/layout_results/WebKit_Linux_Trusty_ASAN/26566/webkit_layout_tests/layout-test-results/results.html Original change's description: > Worker: Abort all inflight tasks in Worklet::ContextDestroyed() > > Before this CL, all inflight tasks can be retained in > Worklet::pending_tasks_set_ even after context destruction, and that causes > dcheck failures in the destructor of Worklet. This CL fixes it by aborting them > in Worklet::ContextDestroyed(). > > In addition, this CL adds test coverage of addModule() calls on a detached > iframe. In the tests, LayoutWorklet is used for testing main thread worklets > instead of PaintWorklet because PaintWorklet will be switched to > off-the-main-thread worklets (see https://crbug.com/829967). > > Bug: 962355 > Change-Id: I7da71e7f4bdcbfa20125853832122a733c118a7a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626062 > Reviewed-by: Matt Falkenhagen <falken@chromium.org> > Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> > Cr-Commit-Position: refs/heads/master@{#662923} TBR=falken@chromium.org,nhiroki@chromium.org Change-Id: I54041a299dfdc74ff298b001cd42609fe2c11901 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 962355 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627843Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#662962}
-
Ben Kelly authored
In order to support moving CacheStorage off the IO thread and on to a separate SequencedTaskRunner, we are encapsulating the threading requirements. This CL does this by removing the requirement that external clients of CacheStorageContext must be on the IO thread. Instead the API can be accessed directly on the UI thread and CacheStorageContextImpl will handle executing the code on the correct sequence. Bug: 960012 Change-Id: I7d576a7deb484113cff0e9454b038f7b87c5e503 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625971Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#662961}
-
Hiroki Nakagawa authored
Off-the-main-thread shared worker script fetch depends on PlzSharedWorker (NetworkService). Therefore, even after this CL, on-the-main-thread shared worker script fetch is still used in some platforms where PlzSharedWorker (NetworkService) has not been enabled by default yet. Bug: 924041 Change-Id: Ic2282fc69b4af666932fcf35a0375e25a88ac052 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1535499Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
-
chrome://prefs-internalsKyle Milka authored
This page is useful for debugging so it should appear at about:about. Also update the comment explaining how to do so. Bug: None Change-Id: I5c0ecac337381315ca8427d7046831f0f00275e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627855Reviewed-by:
-
Kent Tamura authored
https://html.spec.whatwg.org/multipage/forms.html#dom-form-requestsubmit Intent: https://groups.google.com/a/chromium.org/d/msg/blink-dev/CxelaeahNho/aC6Zp8KvAwAJ Bug: 964062 Change-Id: Iea72587605c8f1c13c98b05be3b7d971c9fe7543 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616924 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#662958}
-
Tsuyoshi Horo authored
This CL adds following flags to show "from prefetch cache" in DevTools. - ResourceResponseInfo.was_in_prefetch_cache - WebURLResponse::SetWasInPrefetchCache() - blink::ResourceResponse ::WasInPrefetchCache() ::SetWasInPrefetchCache() - Response.fromPrefetchCache in browser_protocol.pdl - SDK.NetworkRequest .SetFromPrefetchCache() .fromPrefetchCache() And checks fromPrefetchCache() in NetworkDataGridNode.js to show "(prefetch cache)" in DevTools' Network tab's data grid, and in RequestHeadersView.js to show "(from signed-exchange prefetch cache)" in DevTools' Network tab's request header's view. TBR=caseq@chromium.org,pfeldman@chromium.org Bug: 935267 Change-Id: Ia026f586f65a021089eafde09b77f6364754c38e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619527 Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Reviewed-by:Alexei Filippov <alph@chromium.org> Reviewed-by:
-
Devlin Cronin authored
Update the parameterized declarativeContent tests to exercise the behavior with the "action" manifest key, in addition to the page and browser action keys. Bug: 893373 Change-Id: I407be25d6dd8a9e567806d756d2c185bb37f4ce5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613735Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#662956}
-
tzik authored
The constructor of mojo::InterfacePtr that takes InterfacePtrInfo used to call InterfacePtr::Bind without TaskRunner. That causes the default task runner usage, which is discouraged. This adds a SequencedTaskRunner parameter to align InterfacePtr::Bind. Change-Id: I07cf911a6110f078d3bf128edc905dc1ac960c69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621802Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#662955}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/63ab0c82ecf5..65790b717589 git log 63ab0c82ecf5..65790b717589 --date=short --no-merges --format='%ad %ae %s' 2019-05-24 dberris@chromium.org Pinpoint: Add dberris@ to OWNERS 2019-05-24 dberris@chromium.org Pinpoint: Fix comparison to handle None sentinel Created with: gclient setdep -r src/third_party/catapult@65790b717589 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:966328 TBR=eyaich@google.com Change-Id: I60aaf1d8a827e48da03a2abdf825aab0fa9d3284 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628335Reviewed-by:
-
Keishi Hattori authored
Bug: 965307 Change-Id: I57e35104a748ff5194a556ba212974114d2e59be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627431Reviewed-by:
-
Lukasz Anforowicz authored
Bug: 966555 Change-Id: Ib75128520a9f20f68e336beee6d8e63b1e81bd29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627820 Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Ehsan Karamad <ekaramad@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#662952}
-
Ehsan Karamad authored
"MimeHandlerView" is a chrome/extensions layer term and should not leak into blink or content layers. This CL renames public APIs for creating a MimeHandlerView uses terms "external plugin" and "handle externally" when appropriate. The change is purely mechanical. TBR=haraken@chromium.org, dcheng@chromium.org, jam@chromium.org, creis@chromium.org Bug: 659750 Change-Id: Icafa827d8e792d4d4d007a9232504965f580b4d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626641Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Cr-Commit-Position: refs/heads/master@{#662951}
-
Dan Beam authored
R=rbpotter@chromium.org BUG=964906 Change-Id: I031fd80a4513cc2b99164ad10a10cafd364642b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625848 Commit-Queue: Dan Beam <dbeam@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#662950}
-
Kenneth Russell authored
ContextLost_WebGLBlockedAfterJSNavigation ContextLost_WebGLUnblockedAfterUserInitiatedReload TraceTest_Video_Context_Loss_VP9 These three tests are flaking frequently, and despite two of them being marked flaky, their failures are showing up often enough in the data that they're ranked highly on FindIt's flake portal. Skip them entirely on this configuration. Bug: 965268 Bug: 965730 Change-Id: Id1b3efe3577d348d0c04fc20a847f9b40a98c046 Tbr: ynovikov@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628391Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#662949}
-
Yuzu Saijo authored
This CL stores per-frame task runners for IPC messages to be executed on using routing_id. The task runners are stored on IPC::ChannelProxy::Context and will be looked up each time when IPC messages arrives to the renderer. Code-wise, this CL - Introduces IPC::ChannelProxy::Context::{AddListenerTaskRunner, GetTaskRunner} - {Associate, query} a task runner {to, from} a IPC routing_id - Before this CL, all IPC tasks were PostTask to {ipc, listener} task runner, but after this CL, they are PostTask to the task runner associated to their IPC message's routing_id. - Renames kInternalNavigation to kInternalNavigationAssociated, - Associate frame routing_id to per-frame task runner, so the frame IPC messages are routed to the task runner. Design-doc: https://docs.google.com/document/d/1dfQEPeeqOBigyzaeLR5dYaAgeeNDhCkWsPyxodD5xTA/edit?usp=sharing Change-Id: Ie7500355ca489ee192f9de53f05d07774cf286fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526067 Commit-Queue: Yuzu Saijo <yuzus@chromium.org> Reviewed-by:Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
-
Timothy Loh authored
This reverts commit 4ded38ed. Reason for revert: WebViewPluginTest.TestLoadPluginInternalResource timing out on linux-chromeos-dbg e.g. https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/12542 Original change's description: > [ MimeHandlerView ] Block PluginStatus != kAllowed/kPlayImportantContent > > Currently, a MimeHandlerView is created as long as there is a plugin > for it. This behavior undermines issues such as <webview> permissions > API. > > This CL will avoid creating MimeHandlerView if the plugin is not > allowed. This change will also make the test > WebViewPluginTest.TestLoadPluginInternalResource pass with the flag > MimeHandlerViewInCrossProcessFrame. > > Note that when the plugin is not allowed, no (frame-based) > MimeHandlerView will be created and the code will follow the ordinary > CreatePlugin code path. > > Bug: 963694 > Change-Id: I91b88956480139ffdb0df06077d099746b713751 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622890 > Reviewed-by: Ehsan Karamad <ekaramad@chromium.org> > Reviewed-by: James MacLean <wjmaclean@chromium.org> > Reviewed-by: Tommy Li <tommycli@chromium.org> > Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org> > Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> > Cr-Commit-Position: refs/heads/master@{#662641} TBR=thestig@chromium.org,tommycli@chromium.org,ekaramad@chromium.org,lukasza@chromium.org,wjmaclean@chromium.org Change-Id: I348e495fd03a3acaed1aaa86d71fee38770a9aa5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 963694 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627837Reviewed-by:
Timothy Loh <timloh@chromium.org> Commit-Queue: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#662947}
-
