GitLab

Revert of Add test for system tray network menu icon for extension-controlled networks (patchset #3 id:40001 of https://codereview.chromium.org/2558083003/ )

Reason for revert:
NetworkingConfigDelegateChromeosTest.SystemTrayItem is failing on Linux Chromium OS ASan LSan Tests: see http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=browser_tests&tests=SystemTrayItem.

Original issue's description:
> Add test for system tray network menu icon for extension-controlled networks
>
> Eventually extension-controlled network information will come out of a mojo
> service. This provides test coverage to make sure the icon shows up in the
> system tray menu.
>
> BUG=651157
> TEST=chrome browser_tests
>
> Committed: https://crrev.com/af700b84d792456061162fc8fdcd08065ad8773a
> Cr-Commit-Position: refs/heads/master@{#437341}

TBR=stevenjb@chromium.org,jamescook@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=651157

Review-Url: https://codereview.chromium.org/2563943002
Cr-Commit-Position: refs/heads/master@{#437480}

The last change caused a reliable failure on Linux AMD.

BUG=671791
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=zmo@chromium.org,geofflang@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2566603002
Cr-Commit-Position: refs/heads/master@{#437479}

SkPictureBuilder records DisplayItems and plays them into
an SkPicture.  GeneratedImage::drawPattern() was misusing
SkPictureBuilder; using it to create a GraphicsContext and
draw to it directly.  It results in the pattern:

1) GraphicsContext::beginRecording()
2) Draw content to GraphicsContext
3) GraphicsContext::beginRecording() again
5) SkPicture picture = GraphicsContext::endRecording()

This is hitting undefined behavior in SkPictureRecorder which
happens to work but is a bug.

This change removes SkPictureBuilder and records directly
to a GraphicsContext.

BUG=672618

Review-Url: https://codereview.chromium.org/2565433003
Cr-Commit-Position: refs/heads/master@{#437478}

This patch is a subtask of "Decoupling Gamepad from //content".

The Gamepad IPC messages are converted into mojo interfaces, so the
GamepadBrowserMessageFilter doesn't need to extend BrowserMessageFilter anymore
so we renamed it as GamepadMonitor.
GamepadMonitor still extend GamepadConsumer interface. Each RenderProcessHost
owns one GamepadMonitor. GamepadMonitor instance is created by "StrongBinding"
and will be registered into the "ConsumerSet" of GamepadService.
The base::SharedMemory handle are wrapped into mojo::SharedMemoryHandle and
passed as parameter of mojo interface from Browser to Renderer, Renderer Process
unwrap it to get the real shared memory contents.
Note that to obtain a new SharedMemoryHandle to wrap in a Mojo handle we simply
clone the existing one. While it's not obvious, this is functionally equivalent
to the old approach of passing the peer handle: when the renderer unwraps the
Mojo handle that it obtained into a base::SharedMemoryHandle, it fills in that
handle with its own process ID.

BUG=612330

Review-Url: https://codereview.chromium.org/2522843002
Cr-Commit-Position: refs/heads/master@{#437477}

On mobile devices, there are less available memory and high tab
switching cost compared to desktop environments. Given that, it would
make sense to throttle background renderers immediately.

BUG=617492

Review-Url: https://codereview.chromium.org/2564623004
Cr-Commit-Position: refs/heads/master@{#437476}

- Remove HTMLFormElement argument from HTML element constructors
- Remove HTMLFormElement argument from HTMLElementFactory
- Update unit tests

BUG=672359

Review-Url: https://codereview.chromium.org/2561043002
Cr-Commit-Position: refs/heads/master@{#437475}

This patch replaces PropertyInterpolationTypesMapping with CSS and SVG
InterpolationTypesMap classes that are provided to InvalidatableInterpolation
objects via the InterpolationEnvironment.

InvalidatableInterpolations are no longer provided with the list of
InterpolationTypes at construction, now they retrieve the list at effect
application time during applyStack().

This is in preparation for supporting smooth animation of registered
custom properties.

BUG=671904

Committed: https://crrev.com/3ac8b90fcbda4c6e3ef484140751cd0341b31c48
Review-Url: https://codereview.chromium.org/2555923003
Cr-Original-Commit-Position: refs/heads/master@{#437381}
Cr-Commit-Position: refs/heads/master@{#437474}

https://pdfium.googlesource.com/pdfium.git/+log/94afac986c9d..1babeeed9c25

$ git log 94afac986..1babeeed9 --date=short --no-merges --format='%ad %ae %s'
2016-12-08 dsinclair Change CFWL_Widget::GetMatrix to return the matrix

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2563923002
Cr-Commit-Position: refs/heads/master@{#437473}

https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/f554de2..e9afa18

BUG=672380, 662644

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2563603002
Cr-Commit-Position: refs/heads/master@{#437472}

It has been marked as flaky on Win7 Debug but it is flaky on all debug bots.

BUG=652187
NOTRY=true
TBR=asargent@chromium.org, grt@chromium.org, vasilii@chromium.org

Review-Url: https://codereview.chromium.org/2565653002
Cr-Commit-Position: refs/heads/master@{#437471}

Previously we checked equality of reference filters by comparing the
pointers to SkImageFilters. This cause false-positive when we forced
property update for under-invalidation checking.

Now ignore reference filters when comparing effect nodes, and check
for changes of filter operations defined in style to remedy the
ignored check.

An alternative way is to add value equality operators in SkImageFilter
subclasses, but that seems to need more code and time than this CL.
We might make that a long-term objective.

BUG=671097
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2556013002
Cr-Commit-Position: refs/heads/master@{#437470}

- Added kAccessibilityFocusFallsbackToWidget property to aura::Window.
- Default value of kAccessibilityFocusFallsbackToWidget is true.
- kAccessibilityFocusFallsbackToWidget is set to false for arc window.

BUG=661061
TEST=manually tested as described in the issue; User can navigate
     elements in Android window by using TalkBack.
     interactive_ui_tests:SpokenFeedbackTest

Review-Url: https://codereview.chromium.org/2530073002
Cr-Commit-Position: refs/heads/master@{#437469}

Following up on the outcome of discussions on
https://codereview.chromium.org/2553503002, added a typ
runner at the end of run-bindings-tests. Now,
every unit test in Source/bindings/scripts will be
automatically ran by run-bindings-tests.

R=dpranke,bashi,yukishiino
BUG=654129

Review-Url: https://codereview.chromium.org/2554503004
Cr-Commit-Position: refs/heads/master@{#437468}

This patch skips binary UISourceCodes so that we don't search in them.

BUG=585383
R=dgozman

Review-Url: https://codereview.chromium.org/2564733002
Cr-Commit-Position: refs/heads/master@{#437467}

BUG=672696, 672371
NOTRY=true
TBR=asargent@chromium.org, grt@chromium.org, vasilii@chromium.org

Review-Url: https://codereview.chromium.org/2560033003
Cr-Commit-Position: refs/heads/master@{#437466}

Review-Url: https://codereview.chromium.org/2561893002
Cr-Commit-Position: refs/heads/master@{#437465}

We don't really want the "touch event API" support to be dynamic (you can
always open devtools at use mobile emulation to generate touch events).  It's
just the feature detection (eg.'ontouchstart' in window) that needs to be
dynamic due to 632881.

BUG=644318

Review-Url: https://codereview.chromium.org/2547373002
Cr-Commit-Position: refs/heads/master@{#437464}

After https://crrev.com/432737, memory allocation does not do IPC
anymore. So it does not need the IPC::Sender anymore. Also, it is no
longer necessary to have special code to decide when the allocation
request failed due to out-of-memory. So remove that code too.

BUG=612500

Review-Url: https://codereview.chromium.org/2544953002
Cr-Commit-Position: refs/heads/master@{#437463}

This CL converts extendable message event IPCs into mojo interface:
  ServiceWorkerMsg_ExtendableMessageEvent
  ServiceWorkerHostMsg_ExtendableMessageEventFinished

BUG=629701
TEST=content_unittests

Review-Url: https://codereview.chromium.org/2534403002
Cr-Commit-Position: refs/heads/master@{#437462}

The motion* deprecations were temporarily removed, until offset-rotate was
available. We now enable them again.
motion-path becomes offset-path
motion-offset becomes offset-distance
motion-rotation becomes offset-rotate
motion becomes motion-path

We also add a new deprecation:
offset-rotation becomes offset-rotate

BUG=669782,672264

Review-Url: https://codereview.chromium.org/2564703002
Cr-Commit-Position: refs/heads/master@{#437461}

Cr-Commit-Position: refs/heads/master@{#437460}

Adds Sidebar control to chrome://bluetooth-internals.
Adds PageManager to manage view switching.
Adds DevicesPage wrapper around DeviceTable for paging.
Changes style to user-facing WebUI standard.

Screenshots: https://goo.gl/photos/EKWMtQ2DBfF3m9WC8

BUG=651282
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2538653002
Cr-Commit-Position: refs/heads/master@{#437459}

BUG=672615

Review-Url: https://codereview.chromium.org/2557763003
Cr-Commit-Position: refs/heads/master@{#437458}

MacOS has a lot of Emacs-style keyboard shortcuts that we lost when
moving the console from contenteditable to CodeMirror.

BUG=671269

Review-Url: https://codereview.chromium.org/2559603002
Cr-Commit-Position: refs/heads/master@{#437457}

Removed references to the property object from templates used in
make_computed_style_base.py. This is important pre-work for adding
fields that don't have a property object associated with them, but even
if those aren't added, reducing the amount of information sent to the
templates makes the code easier to follow and understand.

BUG=628043

Review-Url: https://codereview.chromium.org/2554243002
Cr-Commit-Position: refs/heads/master@{#437456}

If VEA encoder fails to initialize because the driver
detects plane size is unalign with cache line and
returns VIDIOC_S_FMT error, the test hangs at waiting
undefinitely in error state. This change makes the test
to fail properly.

BUG=672377
TEST=Run VEA unittest on Kevin.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2561063002
Cr-Commit-Position: refs/heads/master@{#437455}

BUG=620813

Review-Url: https://codereview.chromium.org/2511043003
Cr-Commit-Position: refs/heads/master@{#437454}

BUG=668196

Committed: https://crrev.com/ca8dc086777939dbf144e40feddd6e5d4957b32b
Review-Url: https://codereview.chromium.org/2525033003
Cr-Original-Commit-Position: refs/heads/master@{#435954}
Cr-Commit-Position: refs/heads/master@{#437453}

Content appears to actually be the owner of the process running a
browser. As such, it stands to reason that it should be the one
initializing and controlling the lifetime of the task scheduler.

BUG=662052

Review-Url: https://codereview.chromium.org/2539263003
Cr-Commit-Position: refs/heads/master@{#437452}

BUG=659487

Review-Url: https://codereview.chromium.org/2475593002
Cr-Commit-Position: refs/heads/master@{#437451}

This is necessary for the case where a client creates a window, sets
the transient parent and then adds it. Without this change the wm
wouldn't know about the transient parent and would be in a weird
state.

BUG=663903
TEST=covered by tests
R=ben@chromium.org, tsepez@chromium.org

Review-Url: https://codereview.chromium.org/2557353003
Cr-Commit-Position: refs/heads/master@{#437450}

Provide a concrete implementation of a CTVerifier that allows consumers
to opt-out of verifying CT information. While this is not generally
desirable for consumers of "the Web PKI" (e.g.: websites), it's
acceptable and potentially desirable for things like peer-to-peer
[D]TLS sockets (like WebRTC or Remoting), or for cases where the
overall application is not ready to support Certificate Transparency
(for example: may lack any form of update path).

BUG=none
R=eroman@chromium.org

Review-Url: https://codereview.chromium.org/2540293004
Cr-Commit-Position: refs/heads/master@{#437449}

The system.display.overscanCalibrationStart method displays an overlay
for adjusting overscan when called.

If the web context initiating the call is deleted before
overscanCalibrationComplete is called, the overaly will remain with
no way to remove it (without running Settings or an app that shows
and removes the overaly correctly).

This change creates a tracker so that if the render frame is deleted
before overscanCalibrationComplete is called, the calibration will
be reset and completed to remove the overlay.

BUG=666590

Review-Url: https://codereview.chromium.org/2558453004
Cr-Commit-Position: refs/heads/master@{#437448}

Computing surface_is_clipped on effect node depends on creating a clip
node for render surface. This CL puts the code that computes
surface_is_clipped into its own method in such a way that it can be
called even from the path where we don't create clip nodes for render
surfaces

BUG=594675
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2543723003
Cr-Commit-Position: refs/heads/master@{#437447}

BUG=650398

Review-Url: https://codereview.chromium.org/2563443002
Cr-Commit-Position: refs/heads/master@{#437446}

BUG=670519

Review-Url: https://codereview.chromium.org/2562843002
Cr-Commit-Position: refs/heads/master@{#437445}

BUG=644626

R=gavinp@chromium.org

Review-Url: https://codereview.chromium.org/2503993002
Cr-Commit-Position: refs/heads/master@{#437444}

This is a follow-up CL of crrev.com/2550183007.

BUG=617492

Review-Url: https://codereview.chromium.org/2561863003
Cr-Commit-Position: refs/heads/master@{#437443}

BUG=636271, 672676
NOTRY=true
TBR=asargent@chromium.org, grt@chromium.org, vasilii@chromium.org

Review-Url: https://codereview.chromium.org/2561283002
Cr-Commit-Position: refs/heads/master@{#437442}

Remove ShelfItemDelegate::ShouldShowTooltip and overrides.
Add ShelfItem::shows_tooltip and plumbing, update users.

Remove WindowState panel-attached member and accessors.
Add ash, mus, and common panel-attached property keys.

Add requisite WmWindow::SetBoolProperty and aura impl.
Add requisite ShelfItem copy ctor (compiler complained...)

BUG=557406
TEST=No Chrome OS shelf tooltip (or panel) behavior changes.
R=sky@chromium.org
TBR=tsepez@chromium.org

Review-Url: https://codereview.chromium.org/2558963002
Cr-Commit-Position: refs/heads/master@{#437441}