GitLab

If I type an exact query that I issued before, SearchProvider shouldn't
offer an extension to the autocompletion, even if that I issued that longer
query more recently.  This is counter to user's expectations: if I issued
the query before and type it again and hit enter, I should get that query.

I do not plan to bother running an experiment for this change.

BUG=246411

Review URL: https://codereview.chromium.org/397723003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283836 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/353063005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283835 0039d316-1c4b-4281-b951-d872f2087c98

BUG=394627
R=zea@chromium.org

Review URL: https://codereview.chromium.org/395413002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283833 0039d316-1c4b-4281-b951-d872f2087c98

Demonstrate in the NaCl SDK API demo for pp::Graphics2D how
to use full device resolution on HiDPI displays. For Graphics2D,
the example now calls pp::View::GetDeviceScale(), and creates
a Graphics 2D context with the correct number of pixels, as well
as show when to call pp::Graphics2D::SetScale().

It also scales the mouse position to the correct location and
increases the radius of the circle created in DrawMouse() to match.

BUG=144071,392557
TEST=Build NaCl SDK, run with --force-device-scale-factor=2

Review URL: https://codereview.chromium.org/397173003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283832 0039d316-1c4b-4281-b951-d872f2087c98

This also fixes a bug caused by registering for notifications in all profiles instead of just our own.

BUG=394158,354046

Review URL: https://codereview.chromium.org/399603002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283831 0039d316-1c4b-4281-b951-d872f2087c98

change_ids are more trouble then they are worth. I'm going to try
something else for resolving conflicts.

BUG=389339
TEST=covered by tests
R=ben@chromium.org

Review URL: https://codereview.chromium.org/397263004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283830 0039d316-1c4b-4281-b951-d872f2087c98

Based on existing LSan suppression from
  https://codereview.chromium.org/63153007

BUG=318221
R=earthdok@chromium.org
TBR=earthdok@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/399893004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283828 0039d316-1c4b-4281-b951-d872f2087c98

BUG=346958

Review URL: https://codereview.chromium.org/402663002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283826 0039d316-1c4b-4281-b951-d872f2087c98

selection_requestor.h

BUG=367549
TEST=None
R=derat
TBR=dcheng,sky (for trivial changes to clipboard_aurax11.cc and os_exchange_data_provider_aurax11.cc)

Review URL: https://codereview.chromium.org/396813004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283825 0039d316-1c4b-4281-b951-d872f2087c98

ConvertSkiatoRGBA in png_coder.cc calls gfx::ConvertSkiaToRGBA.
It's little bit confusing.

For readability sake,
I change ConvertSkiatoRGBA to ConvertSkiaToRGBA.

BUG=NONE
TEST=gfx_unittests --gtest_filter="PNGCodec*"

Review URL: https://codereview.chromium.org/396133002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283824 0039d316-1c4b-4281-b951-d872f2087c98

We should have the same handling regardless of whether the 'mode' member is
NotifyGrab or NotifyUngrab. According to
http://tronche.com/gui/x/xlib/events/input-focus/grab.html, whether the mode
field is NotifyGrab or NotifyUngrab depends on whether there is a new
capturer for the keyboard. The X window has lost keyboard capture in both cases.

BUG=392480
TEST=None

Review URL: https://codereview.chromium.org/379773003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283823 0039d316-1c4b-4281-b951-d872f2087c98

Previously the fake input stream is creating a new thread to pump the callbacks, this is unnecessary and FakeAudioInputStream::Stop() might take time to stop the thread. I suspect that this is one of the potential causes for the timeout in WebRtc content browser tests on Android bots.

This patch changes the code to use AudioManager audio thread instead, hopefully this can reduce the flakiness on Android tests.
Also it changes |beep_lock| from a global lock to a lock used only by BeepContext privately.

BUG=387895
TEST=bots

Review URL: https://codereview.chromium.org/399623008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283822 0039d316-1c4b-4281-b951-d872f2087c98

Port InsertHistoryAndBookmark and InsertSearchTerm to use
base::CancelableTaskTracker instead of CancelableRequestConsumer.

BUG=371818

Review URL: https://codereview.chromium.org/365133003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283821 0039d316-1c4b-4281-b951-d872f2087c98

BUG=90057
R=thestig@chromium.org
TBR=thestig@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/402713003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283819 0039d316-1c4b-4281-b951-d872f2087c98

Make behavior uniform with other apps on Android, where after a copy from
an editable field, the insertion handle is hidden and only the cursor
remains visible.

BUG=394773

Review URL: https://codereview.chromium.org/394953005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283818 0039d316-1c4b-4281-b951-d872f2087c98

BUG=367239

Review URL: https://codereview.chromium.org/387903003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283817 0039d316-1c4b-4281-b951-d872f2087c98

Added "Net.QuicClientHelloRejectReasons" histogram to track 
the reject reason in UMA. Currently it tracks only reject 
reason. 

Once we have more data, will add the multiple reject reasons
to histograms.xml (instead of listing all potential 
combinations). We are guessing, that we would have few 
failures due to multiple errors.

R=jar@chromium.org, rch@chromium.org, asvitkine@chromium.org, wtc@chromium.org

Review URL: https://codereview.chromium.org/342863005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283816 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283815 0039d316-1c4b-4281-b951-d872f2087c98

It removes erase operations for SkBitmaps
which touch whole inside pixels
since all pixels should be drawn fully.

Additionally, it removes a unused function, CreateSuperimposedBitmap().

BUG=NONE
TEST=gfx_unittests --gtest_filter="SkBitmapOperationsTest*"

Review URL: https://codereview.chromium.org/394183002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283814 0039d316-1c4b-4281-b951-d872f2087c98

(This is a reland of r283542 which was reverted in r283591 because it
broke the WebView build. The android_aosp trybots are broken[1] so this
based on hope.)

This is a much larger change than its diff suggests. If it breaks
something, please revert first and ask questions later.

[1] http://code.google.com/p/chromium/issues/detail?id=394597

BUG=none

Review URL: https://codereview.chromium.org/399993002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283813 0039d316-1c4b-4281-b951-d872f2087c98

The default implementation (CastServiceSimple) starts up a single page
passed in on the command line.

R=damienv@chromium.org,lcwu@chromium.org,jam@chromium.org
BUG=336640

Review URL: https://codereview.chromium.org/397143003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283812 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Added wrapper test class for touch_exploration_controller. (https://codereview.chromium.org/386043002/)

Reason for revert:
Causes LSAN errors on CrOS: http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%283%29/builds/2299/steps/ui_unittests/logs/DoubleTap

e.g.
Indirect leak of 2904 byte(s) in 1 object(s) allocated from:
    #0 0x44edfb in operator new(unsigned long) /usr/local/google/work/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:55
    #1 0x9fbc47 in CreateStrategy ui/events/gesture_detection/velocity_tracker.cc:201
    #2 0x9fbc47 in ui::VelocityTracker::VelocityTracker(ui::VelocityTracker::Strategy) ui/events/gesture_detection/velocity_tracker.cc:234
    #3 0x9fa322 in ui::VelocityTrackerState::VelocityTrackerState() ui/events/gesture_detection/velocity_tracker_state.cc:18
    #4 0x9f5d64 in ui::GestureDetector::GestureDetector(ui::GestureDetector::Config const&, ui::GestureDetector::GestureListener*, ui::GestureDetector::DoubleTapListener*) ui/events/gesture_detection/gesture_detector.cc:191
    #5 0x1431ddf in GestureListenerImpl ui/events/gesture_detection/gesture_provider.cc:296
    #6 0x1431ddf in ui::GestureProvider::InitGestureDetectors(ui::GestureProvider::Config const&) ui/events/gesture_detection/gesture_provider.cc:629
    #7 0x142ebdd in ui::FilteredGestureProvider::FilteredGestureProvider(ui::GestureProvider::Config const&, ui::GestureProviderClient*) ui/events/gesture_detection/filtered_gesture_provider.cc:19
    #8 0x1410cd3 in ui::GestureProviderAura::GestureProviderAura(ui::GestureProviderAuraClient*) ui/events/gestures/gesture_provider_aura.cc:19
    #9 0x9e9bcd in ui::TouchExplorationController::TouchExplorationController(aura::Window*) ui/chromeos/touch_exploration_controller.cc:33
    #10 0x663c47 in ui::TouchExplorationTest::SwitchTouchExplorationMode(bool) ui/chromeos/touch_exploration_controller_unittest.cc:214
    #11 0x674532 in ui::TouchExplorationTest_DoubleTap_Test::TestBody() ui/chromeos/touch_exploration_controller_unittest.cc:563
    #12 0x7babc8 in HandleExceptionsInMethodIfSupported\u003Ctesting::Test, void> testing/gtest/src/gtest.cc:2045
    #13 0x7babc8 in testing::Test::Run() testing/gtest/src/gtest.cc:2061
    #14 0x7bcd08 in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2237
    #15 0x7bda46 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2344
    #16 0x7d072a in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4065
    #17 0x7cfd70 in HandleExceptionsInMethodIfSupported\u003Ctesting::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2045
    #18 0x7cfd70 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:3697
    #19 0x7770b4 in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2231
    #20 0x7770b4 in base::TestSuite::Run() base/test/test_suite.cc:227
    #21 0x76e0c1 in Run base/callback.h:401
    #22 0x76e0c1 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::Callback\u003Cint ()> const&, int, bool, base::Callback\u003Cvoid ()> const&) base/test/launcher/unit_test_launcher.cc:498
    #23 0x76da5c in base::LaunchUnitTests(int, char**, base::Callback\u003Cint ()> const&) base/test/launcher/unit_test_launcher.cc:553
    #24 0x59cfaa in main ui/base/test/run_all_unittests.cc:105
    #25 0x7fd0195b276c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226

Original issue's description:
> Added wrapper test class for touch_exploration_controller.
> Wrapper class is currently located in the unittest file and is a friend of touch_exploration_controller.
> 
> BUG=377040
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283741

TBR=aboxhall@chromium.org,dmazzoni@chromium.org,evy@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=377040

Review URL: https://codereview.chromium.org/404473006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283811 0039d316-1c4b-4281-b951-d872f2087c98

Watching for new hid devices is racy because the hidraw device rules are
still running. Fix the race by explicitly waiting for the hidraw device
add event. The properties needed from the hid device can be gotten by
fetching the parent of the hidraw device from the sysfs tree.

BUG=394200

Review URL: https://codereview.chromium.org/396993010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283810 0039d316-1c4b-4281-b951-d872f2087c98

WebApp code was deleted here:
https://codereview.chromium.org/19746

WebIntents code was deleted here:
https://codereview.chromium.org/22407016/
https://codereview.chromium.org/12225076/

BUG=241909

Review URL: https://codereview.chromium.org/382703002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283808 0039d316-1c4b-4281-b951-d872f2087c98

Since we're already including the HTTP response code as a field in the report,
don't bother including the specific error code in the status as well.

BUG=

Review URL: https://codereview.chromium.org/398173003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283807 0039d316-1c4b-4281-b951-d872f2087c98

tests.

Until now, setting up password manager python tests is
complicated and doesn't fit the requirement of the test
bots. This cl allows to make running and configuring of the
tests much easier for the bots.

BUG=393531

Review URL: https://codereview.chromium.org/386423002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283806 0039d316-1c4b-4281-b951-d872f2087c98

Password Autofill is supposed to be a convenience. If it creates a
blocking dialog, it is no longer convenient. The original intention of
password Autofill was that it would only prompt the user after a full
username was typed in. Until that behavior is implemented, never prompt the
user for keychain access.

Effectively, this means that passwords stored by Chrome still work, since
Chrome can access those without a prompt, but passwords stored by Safari,
Firefox, or Chrome Canary will not work. Note that the latest build of Safari
and Firefox don't create keychain items with the relevant tags anyways.

BUG=178358

Review URL: https://codereview.chromium.org/386043005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283805 0039d316-1c4b-4281-b951-d872f2087c98

The home-card can be in a minimized state. In this state, only a narrow line
is displayed at the bottom of the screen, and dragging it up shows the overview
mode. When a window is selected in the overview mode, the home-card is minimized
again.

BUG=381224
R=mukai@chromium.org, oshima@chromium.org

Previously landed in r283539, reverted in r283564 because it broke tests.

Review URL: https://codereview.chromium.org/394043002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283804 0039d316-1c4b-4281-b951-d872f2087c98

BUG=388289

Review URL: https://codereview.chromium.org/393583002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283802 0039d316-1c4b-4281-b951-d872f2087c98

This broke Chrome OS valgrind bots, for example:
http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20OS%20%28valgrind%29%284%29/builds/27033

> Refactor code that defers extension background page loading
> 
> src/extensions depends on chrome::NOTIFICATION_PROFILE_CREATED to support deferred loading of extension background pages when the profile isn't ready yet. This is a layering violation.
> 
> * Remove Chrome concepts like "browser window ready" and "profile created" from ProcessManager. Introduce ProcessManagerDelegate with a general concept of deferring background page loading.
> * Consolidate all the tricky Chrome-specific background page loading rules into ChromeProcessManagerDelegate. This keeps all the rules in one place. Annotate each block of special case code with the bug that inspired it.
> * Extend unit test coverage for ProcessManager.
> 
> This will make it easier to eliminate chrome::NOTIFICATION_PROFILE_DESTROYED in ProcessManager in a later CL.
> 
> BUG=392658
> TEST=unit_tests ProcessManagerTest, browser_tests ProcessManagerBrowserTest, manual
> 
> Review URL: https://codereview.chromium.org/381283002

TBR=jamescook@chromium.org

Review URL: https://codereview.chromium.org/399153002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283801 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283800 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert:
I spoke to gab over chat and we're going to try rolling back in and clobbering the bot.  The compile error looks more like an issue with the bot state than an issue with the code.

Original issue's description:
> Revert of Blink roll 178334:178351 (https://codereview.chromium.org/400523006/)
> 
> Reason for revert:
> Speculative revert to fix Mac compile (http://build.chromium.org/p/chromium.mac/builders/Mac%20Builder/builds/6454/steps/compile/logs/stdio#error1)
> 
> (...)
> [381/849 | 12.544] LINK cast_unittests, POSTBUILDS
> [382/849 | 13.277] CXX obj/third_party/WebKit/Source/web/tests/webkit_unit_tests.RunAllTests.o
> [383/849 | 13.756] CXX obj/third_party/WebKit/Source/core/html/webkit_unit_tests.TimeRangesTest.o
> ld:warning: could not create compact unwind for _S32A_Opaque_BlitRow32_SSE4_asm: stack subl instruction is too different from dwarf stack size
> [384/849 | 16.741] CXX obj/third_party/WebKit/Source/core/page/webkit_unit_tests.NetworkStateNotifierTest.o
> FAILED: if [ ! -e mojo_html_viewer.so -o ! -e mojo_html_viewer.so.TOC ] || otool -l mojo_html_viewer.so | grep -q LC_REEXPORT_DYLIB ; then /Volumes/data/b/build/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -bundle -Wl,-search_paths_first -Wl,-dead_strip -mmacosx-version-min=10.6 -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.6.sdk -arch i386 -L. -o mojo_html_viewer.so @mojo_html_viewer.so.rsp && { otool -l mojo_html_viewer.so | grep LC_ID_DYLIB -A 5; nm -gP mojo_html_viewer.so | cut -f1-2 -d' ' | grep -v U$; true; } > mojo_html_viewer.so.TOC; else /Volumes/data/b/build/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -bundle -Wl,-search_paths_first -Wl,-dead_strip -mmacosx-version-min=10.6 -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.6.sdk -arch i386 -L. -o mojo_html_viewer.so @mojo_html_viewer.so.rsp && { otool -l mojo_html_viewer.so | grep LC_ID_DYLIB -A 5; nm -gP mojo_html_viewer.so | cut -f1-2 -d' ' | grep -v U$; true; } > mojo_html_viewer.so.tmp && if ! cmp -s mojo_html_viewer.so.tmp mojo_html_viewer.so.TOC; then mv mojo_html_viewer.so.tmp mojo_html_viewer.so.TOC ; fi; fi
> ld: malformed archive TOC entry for __ZN5blink13V8Coordinates11domTemplateEPN2v87IsolateE, offset 327528552 is beyond end of file 12713984
>  file 'libmodules.a' for architecture i386
> clang:error: linker command failed with exit code 1 (use -v to see invocation)
> FAILED: /Volumes/data/b/build/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -Wl,-search_paths_first -Wl,-pie -Wl,-dead_strip -mmacosx-version-min=10.6 -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.6.sdk -arch i386 -L. -o ppapi_unittests obj/ppapi/host/ppapi_unittests.resource_message_filter_unittest.o obj/ppapi/proxy/ppapi_unittests.device_enumeration_resource_helper_unittest.o obj/ppapi/proxy/ppapi_unittests.file_chooser_resource_unittest.o obj/ppapi/proxy/ppapi_unittests.file_system_resource_unittest.o obj/ppapi/proxy/ppapi_unittests.flash_resource_unittest.o obj/ppapi/proxy/ppapi_unittests.interface_list_unittest.o obj/ppapi/proxy/ppapi_unittests.mock_resource.o obj/ppapi/proxy/ppapi_unittests.nacl_message_scanner_unittest.o obj/ppapi/proxy/ppapi_unittests.pdf_resource_unittest.o obj/ppapi/proxy/ppapi_unittests.plugin_dispatcher_unittest.o obj/ppapi/proxy/ppapi_unittests.plugin_resource_tracker_unittest.o obj/ppapi/proxy/ppapi_unittests.plugin_var_tracker_unittest.o obj/ppapi/proxy/ppapi_unittests.ppb_var_unittest.o obj/ppapi/proxy/ppapi_unittests.ppp_instance_private_proxy_unittest.o obj/ppapi/proxy/ppapi_unittests.ppp_instance_proxy_unittest.o obj/ppapi/proxy/ppapi_unittests.ppp_messaging_proxy_unittest.o obj/ppapi/proxy/ppapi_unittests.printing_resource_unittest.o obj/ppapi/proxy/ppapi_unittests.raw_var_data_unittest.o obj/ppapi/proxy/ppapi_unittests.serialized_var_unittest.o obj/ppapi/proxy/ppapi_unittests.talk_resource_unittest.o obj/ppapi/proxy/ppapi_unittests.video_decoder_resource_unittest.o obj/ppapi/proxy/ppapi_unittests.websocket_resource_unittest.o obj/ppapi/shared_impl/ppapi_unittests.media_stream_audio_track_shared_unittest.o obj/ppapi/shared_impl/ppapi_unittests.media_stream_buffer_manager_unittest.o obj/ppapi/shared_impl/ppapi_unittests.media_stream_video_track_shared_unittest.o obj/ppapi/shared_impl/ppapi_unittests.proxy_lock_unittest.o obj/ppapi/shared_impl/ppapi_unittests.resource_tracker_unittest.o obj/ppapi/shared_impl/ppapi_unittests.thread_aware_callback_unittest.o obj/ppapi/shared_impl/ppapi_unittests.time_conversion_unittest.o obj/ppapi/shared_impl/ppapi_unittests.tracked_callback_unittest.o obj/ppapi/shared_impl/ppapi_unittests.var_tracker_unittest.o libppapi_host.a libppapi_proxy.a libppapi_shared.a libppapi_unittest_shared.a librun_all_unittests.a libtest_support_base.a libgpu_ipc.a libipc.a libtest_support_ipc.a libshared_memory_support.a libgmock.a libgtest.a libsurface.a libbase.a libbase_static.a liballocator_extension_thunks.a libmodp_b64.a libdynamic_annotations.a libmach_override.a libudis86.a libevent.a libskia_library.a libskia_opts.a libskia_opts_ssse3.a libskia_opts_sse4.a libchrome_zlib.a libsfntly.a libicuuc.a libicudata.a libskia_chrome.a libskia_chrome_opts.a libui_base.a libbase_i18n.a libicui18n.a libnet.a libbase_prefs.a libcrcrypto.a libcrnspr.a libcrnss.a libnss_static.a libsqlite3.a libsdch.a liburl_lib.a libcrssl.a libevents_base.a libgfx.a libharfbuzz-ng.a libpng.a libgfx_geometry.a libjpeg_turbo.a libdom4_keycode_converter.a libevents_platform.a libevents.a libgesture_detection.a libmozilla.a libgl_wrapper.a libgles2_utils.a libppapi_ipc.a libcommand_buffer_common.a libevents_ipc.a libcommand_buffer_client.a libgles2_implementation.a libgles2_cmd_helper.a libblink_platform.a libwtf.a libblink_common.a libblink_heap_asm_stubs.a libgles2_c_lib.a libwebp_dec.a libwebp_dsp.a libwebp_utils.a libwebp_demux.a libwebp_enc.a libots.a libbrotli.a libqcms.a libv8_base.a libv8_libbase.a libv8_snapshot.a libiccjpeg.a libblink_web.a libwebcore_dom.a libtranslator.a libtranslator_lib.a libpreprocessor.a libxml2.a libxslt.a libwebcore_html.a libwebcore_remaining.a libwebcore_rendering.a libwebcore_svg.a libwebcore_generated.a libgin.a libmodules.a  -framework AppKit -framework ApplicationServices -framework Carbon -framework CoreFoundation -framework Foundation -framework IOKit -framework Security -framework IOSurface -framework Accelerate -framework AudioUnit -framework CoreVideo -framework SystemConfiguration /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.6.sdk/usr/lib/libresolv.dylib -framework CoreServices -framework OpenGL -framework QuartzCore && (export BUILT_PRODUCTS_DIR=/Volumes/data/b/build/slave/Mac_Builder/build/src/out/Release; export CONFIGURATION=Release; export EXECUTABLE_NAME=ppapi_unittests; export EXECUTABLE_PATH=ppapi_unittests; export FULL_PRODUCT_NAME=ppapi_unittests; export PRODUCT_NAME=ppapi_unittests; export PRODUCT_TYPE=com.apple.product-type.tool; export SDKROOT=/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.6.sdk; export SRCROOT=/Volumes/data/b/build/slave/Mac_Builder/build/src/out/Release/../../ppapi; export SOURCE_ROOT="${SRCROOT}"; export TARGET_BUILD_DIR=/Volumes/data/b/build/slave/Mac_Builder/build/src/out/Release; export TEMP_DIR="${TMPDIR}"; (cd ../../ppapi && ../build/mac/change_mach_o_flags_from_xcode.sh); G=$?; ((exit $G) || rm -rf ppapi_unittests) && exit $G)
> ld: malformed archive TOC entry for __ZN5blink13V8Coordinates11domTemplateEPN2v87IsolateE, offset 327528552 is beyond end of file 12713984
>  file 'libmodules.a' for architecture i386
> clang:error: linker command failed with exit code 1 (use -v to see invocation)
> FAILED: /Volumes/data/b/build/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -bundle -Wl,-search_paths_first -Wl,-ObjC -Wl,-dead_strip -mmacosx-version-min=10.6 -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.6.sdk -arch i386 -L. -o ppapi_tests.plugin/Contents/MacOS/ppapi_tests @ppapi_tests.plugin.rsp
> ld: malformed archive TOC entry for __ZN5blink13V8Coordinates11domTemplateEPN2v87IsolateE, offset 327528552 is beyond end of file 12713984
>  file 'libmodules.a' for architecture i386
> clang:error: linker command failed with exit code 1 (use -v to see invocation)
> ninja: build stopped: subcommand failed.
> 
> Original issue's description:
> > Blink roll 178334:178351
> > 
> > http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=178335:178351&mode=html
> > TBR=abarth@chromium.org,johnme@chromium.org,eseidel@chromium.org
> > BUG=
> > 
> > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283779
> 
> TBR=abarth@chromium.org,eseidel@chromium.org,johnme@chromium.org,blink-deps-roller@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283788

TBR=eseidel@chromium.org,johnme@chromium.org,blink-deps-roller@chromium.org,gab@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/399593005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283799 0039d316-1c4b-4281-b951-d872f2087c98

BUG=362553

Review URL: https://codereview.chromium.org/399623009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283798 0039d316-1c4b-4281-b951-d872f2087c98

Removes some obsolete TODOs from the code.

BUG=355425
TEST=none

Review URL: https://codereview.chromium.org/395223002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283796 0039d316-1c4b-4281-b951-d872f2087c98

TBR=abarth@chromium.org

Review URL: https://codereview.chromium.org/401613002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283795 0039d316-1c4b-4281-b951-d872f2087c98

I'm refiling the CL from https://codereview.chromium.org/283603003/ on behalf of mem.

BUG=

Review URL: https://codereview.chromium.org/391243004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283792 0039d316-1c4b-4281-b951-d872f2087c98

The ChromeOS Diamond key arrives as F15. Since F15 is not a modifier,
we need to track its pressed state explicitly, and apply the selected
modifier flag to key and mouse presses that arrive while F15 is down.
(Maintaining and applying the modifier state in the rewriter is
consistent with how the sticky keys feature is implemented.)

TEST=EventRewriterTest.TestRewriteDiamondKey*
BUG=390982

Review URL: https://codereview.chromium.org/399443004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283791 0039d316-1c4b-4281-b951-d872f2087c98

Fixed TrayBackgroundView::GetBubbleAnchorRect to handle left/right alignment when the tray isn't visible.

BUG=392473

Review URL: https://codereview.chromium.org/391213002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283790 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283789 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert:
Speculative revert to fix Mac compile (http://build.chromium.org/p/chromium.mac/builders/Mac%20Builder/builds/6454/steps/compile/logs/stdio#error1)

(...)
[381/849 | 12.544] LINK cast_unittests, POSTBUILDS
[382/849 | 13.277] CXX obj/third_party/WebKit/Source/web/tests/webkit_unit_tests.RunAllTests.o
[383/849 | 13.756] CXX obj/third_party/WebKit/Source/core/html/webkit_unit_tests.TimeRangesTest.o
ld:warning: could not create compact unwind for _S32A_Opaque_BlitRow32_SSE4_asm: stack subl instruction is too different from dwarf stack size
[384/849 | 16.741] CXX obj/third_party/WebKit/Source/core/page/webkit_unit_tests.NetworkStateNotifierTest.o
FAILED: if [ ! -e mojo_html_viewer.so -o ! -e mojo_html_viewer.so.TOC ] || otool -l mojo_html_viewer.so | grep -q LC_REEXPORT_DYLIB ; then /Volumes/data/b/build/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -bundle -Wl,-search_paths_first -Wl,-dead_strip -mmacosx-version-min=10.6 -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.6.sdk -arch i386 -L. -o mojo_html_viewer.so @mojo_html_viewer.so.rsp && { otool -l mojo_html_viewer.so | grep LC_ID_DYLIB -A 5; nm -gP mojo_html_viewer.so | cut -f1-2 -d' ' | grep -v U$; true; } > mojo_html_viewer.so.TOC; else /Volumes/data/b/build/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -bundle -Wl,-search_paths_first -Wl,-dead_strip -mmacosx-version-min=10.6 -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.6.sdk -arch i386 -L. -o mojo_html_viewer.so @mojo_html_viewer.so.rsp && { otool -l mojo_html_viewer.so | grep LC_ID_DYLIB -A 5; nm -gP mojo_html_viewer.so | cut -f1-2 -d' ' | grep -v U$; true; } > mojo_html_viewer.so.tmp && if ! cmp -s mojo_html_viewer.so.tmp mojo_html_viewer.so.TOC; then mv mojo_html_viewer.so.tmp mojo_html_viewer.so.TOC ; fi; fi
ld: malformed archive TOC entry for __ZN5blink13V8Coordinates11domTemplateEPN2v87IsolateE, offset 327528552 is beyond end of file 12713984
 file 'libmodules.a' for architecture i386
clang:error: linker command failed with exit code 1 (use -v to see invocation)
FAILED: /Volumes/data/b/build/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -Wl,-search_paths_first -Wl,-pie -Wl,-dead_strip -mmacosx-version-min=10.6 -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.6.sdk -arch i386 -L. -o ppapi_unittests obj/ppapi/host/ppapi_unittests.resource_message_filter_unittest.o obj/ppapi/proxy/ppapi_unittests.device_enumeration_resource_helper_unittest.o obj/ppapi/proxy/ppapi_unittests.file_chooser_resource_unittest.o obj/ppapi/proxy/ppapi_unittests.file_system_resource_unittest.o obj/ppapi/proxy/ppapi_unittests.flash_resource_unittest.o obj/ppapi/proxy/ppapi_unittests.interface_list_unittest.o obj/ppapi/proxy/ppapi_unittests.mock_resource.o obj/ppapi/proxy/ppapi_unittests.nacl_message_scanner_unittest.o obj/ppapi/proxy/ppapi_unittests.pdf_resource_unittest.o obj/ppapi/proxy/ppapi_unittests.plugin_dispatcher_unittest.o obj/ppapi/proxy/ppapi_unittests.plugin_resource_tracker_unittest.o obj/ppapi/proxy/ppapi_unittests.plugin_var_tracker_unittest.o obj/ppapi/proxy/ppapi_unittests.ppb_var_unittest.o obj/ppapi/proxy/ppapi_unittests.ppp_instance_private_proxy_unittest.o obj/ppapi/proxy/ppapi_unittests.ppp_instance_proxy_unittest.o obj/ppapi/proxy/ppapi_unittests.ppp_messaging_proxy_unittest.o obj/ppapi/proxy/ppapi_unittests.printing_resource_unittest.o obj/ppapi/proxy/ppapi_unittests.raw_var_data_unittest.o obj/ppapi/proxy/ppapi_unittests.serialized_var_unittest.o obj/ppapi/proxy/ppapi_unittests.talk_resource_unittest.o obj/ppapi/proxy/ppapi_unittests.video_decoder_resource_unittest.o obj/ppapi/proxy/ppapi_unittests.websocket_resource_unittest.o obj/ppapi/shared_impl/ppapi_unittests.media_stream_audio_track_shared_unittest.o obj/ppapi/shared_impl/ppapi_unittests.media_stream_buffer_manager_unittest.o obj/ppapi/shared_impl/ppapi_unittests.media_stream_video_track_shared_unittest.o obj/ppapi/shared_impl/ppapi_unittests.proxy_lock_unittest.o obj/ppapi/shared_impl/ppapi_unittests.resource_tracker_unittest.o obj/ppapi/shared_impl/ppapi_unittests.thread_aware_callback_unittest.o obj/ppapi/shared_impl/ppapi_unittests.time_conversion_unittest.o obj/ppapi/shared_impl/ppapi_unittests.tracked_callback_unittest.o obj/ppapi/shared_impl/ppapi_unittests.var_tracker_unittest.o libppapi_host.a libppapi_proxy.a libppapi_shared.a libppapi_unittest_shared.a librun_all_unittests.a libtest_support_base.a libgpu_ipc.a libipc.a libtest_support_ipc.a libshared_memory_support.a libgmock.a libgtest.a libsurface.a libbase.a libbase_static.a liballocator_extension_thunks.a libmodp_b64.a libdynamic_annotations.a libmach_override.a libudis86.a libevent.a libskia_library.a libskia_opts.a libskia_opts_ssse3.a libskia_opts_sse4.a libchrome_zlib.a libsfntly.a libicuuc.a libicudata.a libskia_chrome.a libskia_chrome_opts.a libui_base.a libbase_i18n.a libicui18n.a libnet.a libbase_prefs.a libcrcrypto.a libcrnspr.a libcrnss.a libnss_static.a libsqlite3.a libsdch.a liburl_lib.a libcrssl.a libevents_base.a libgfx.a libharfbuzz-ng.a libpng.a libgfx_geometry.a libjpeg_turbo.a libdom4_keycode_converter.a libevents_platform.a libevents.a libgesture_detection.a libmozilla.a libgl_wrapper.a libgles2_utils.a libppapi_ipc.a libcommand_buffer_common.a libevents_ipc.a libcommand_buffer_client.a libgles2_implementation.a libgles2_cmd_helper.a libblink_platform.a libwtf.a libblink_common.a libblink_heap_asm_stubs.a libgles2_c_lib.a libwebp_dec.a libwebp_dsp.a libwebp_utils.a libwebp_demux.a libwebp_enc.a libots.a libbrotli.a libqcms.a libv8_base.a libv8_libbase.a libv8_snapshot.a libiccjpeg.a libblink_web.a libwebcore_dom.a libtranslator.a libtranslator_lib.a libpreprocessor.a libxml2.a libxslt.a libwebcore_html.a libwebcore_remaining.a libwebcore_rendering.a libwebcore_svg.a libwebcore_generated.a libgin.a libmodules.a  -framework AppKit -framework ApplicationServices -framework Carbon -framework CoreFoundation -framework Foundation -framework IOKit -framework Security -framework IOSurface -framework Accelerate -framework AudioUnit -framework CoreVideo -framework SystemConfiguration /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.6.sdk/usr/lib/libresolv.dylib -framework CoreServices -framework OpenGL -framework QuartzCore && (export BUILT_PRODUCTS_DIR=/Volumes/data/b/build/slave/Mac_Builder/build/src/out/Release; export CONFIGURATION=Release; export EXECUTABLE_NAME=ppapi_unittests; export EXECUTABLE_PATH=ppapi_unittests; export FULL_PRODUCT_NAME=ppapi_unittests; export PRODUCT_NAME=ppapi_unittests; export PRODUCT_TYPE=com.apple.product-type.tool; export SDKROOT=/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.6.sdk; export SRCROOT=/Volumes/data/b/build/slave/Mac_Builder/build/src/out/Release/../../ppapi; export SOURCE_ROOT="${SRCROOT}"; export TARGET_BUILD_DIR=/Volumes/data/b/build/slave/Mac_Builder/build/src/out/Release; export TEMP_DIR="${TMPDIR}"; (cd ../../ppapi && ../build/mac/change_mach_o_flags_from_xcode.sh); G=$?; ((exit $G) || rm -rf ppapi_unittests) && exit $G)
ld: malformed archive TOC entry for __ZN5blink13V8Coordinates11domTemplateEPN2v87IsolateE, offset 327528552 is beyond end of file 12713984
 file 'libmodules.a' for architecture i386
clang:error: linker command failed with exit code 1 (use -v to see invocation)
FAILED: /Volumes/data/b/build/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -bundle -Wl,-search_paths_first -Wl,-ObjC -Wl,-dead_strip -mmacosx-version-min=10.6 -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.6.sdk -arch i386 -L. -o ppapi_tests.plugin/Contents/MacOS/ppapi_tests @ppapi_tests.plugin.rsp
ld: malformed archive TOC entry for __ZN5blink13V8Coordinates11domTemplateEPN2v87IsolateE, offset 327528552 is beyond end of file 12713984
 file 'libmodules.a' for architecture i386
clang:error: linker command failed with exit code 1 (use -v to see invocation)
ninja: build stopped: subcommand failed.

Original issue's description:
> Blink roll 178334:178351
> 
> http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=178335:178351&mode=html
> TBR=abarth@chromium.org,johnme@chromium.org,eseidel@chromium.org
> BUG=
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283779

TBR=abarth@chromium.org,eseidel@chromium.org,johnme@chromium.org,blink-deps-roller@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/405473003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283788 0039d316-1c4b-4281-b951-d872f2087c98