- 09 Nov, 2019 21 commits
-
-
Clark DuVall authored
Add weblayer_browsertests to the list of BROWSER_TEST_SUITES so that the test launcher will spawn a new java process for each browser test. Change-Id: Idef3f66f20dc1ac8aac70fb35018f3f2650160eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907549Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#714043}
-
Anqing Zhao authored
The existing ReportGenerator class contains the logic of generating report list, which is used for ChromeDesktopReport. Now to share the same logic with new ChromeOsUserReport, this part needs be extracted to a new class: ProfileListReportGenerator. Bug: 1010213 Change-Id: Id88df8924c134592628d395e9e35b19d553bbb49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894005 Commit-Queue: Anqing Zhao <anqing@google.com> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#714042}
-
Dale Curtis authored
For some reason the MessagePumpDefault isn't scheduled with enough precision to execute 20ms interval callbacks, so our fake audio path ends up lagging further and further behind and slowing down tests. BUG=1003761,1014646 TEST=osxbeta-rel trybot passes. R=tmathmeyer Change-Id: Icc0fa9ef9ff698d866ff77aab86206be2f16a23d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906120Reviewed-by:
Ted Meyer <tmathmeyer@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#714041}
-
Josh Nohle authored
This class is an analog of RemoveDeviceLoader. It converts the CryptAuthDevice objects from the CryptAuthDeviceRegistry into RemoteDevice objects. Some RemoteDevice fields are left empty if the CryptAuthDevice does not have CryptAuthBetterTogetherDeviceMetadata, for instance, if the metadata cannot be decrypted. If the public key is available for a device, a persistent symmetric key (PSK) is derived and added to the RemoteDevice; otherwise, the PSK is set to an empty string. An instance of this class can only be used once. The async calls to SecureMessage are guarded by the default DBus timeout (currently 25s). Bug: 951969 Change-Id: I9295b48448c03e5a7df03248949195c60964e0f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904330Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#714040}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/0e9afd2a56f2..ea1884b651e6 git log 0e9afd2a56f2..ea1884b651e6 --date=short --no-merges --format='%ad %ae %s' 2019-11-08 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@ea1884b651e6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: None Change-Id: I60a1cf359103a60682e28f775fcd07d7d8cc2b2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907567Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#714039}
-
Hesen Zhang authored
Bug: 1021767 Change-Id: Icabdc3ca2bf7400af03c255324f9f9935b9078bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900355 Commit-Queue: Hesen Zhang <hesen@chromium.org> Auto-Submit: Hesen Zhang <hesen@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#714038}
-
Clark DuVall authored
Change-Id: Ibb89e3a3597e12648d729d1f8e40db5da87b1d35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907551 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#714037}
-
Erik Jensen authored
Also adds copyright that was missing from file_transfer.proto. Bug: 141571779 Change-Id: Ibaa8dbffc45cf79e33f814d3cdef55eeec9b9553 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848937 Commit-Queue: Jamie Walch <jamiewalch@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Auto-Submit: Erik Jensen <rkjnsn@chromium.org> Cr-Commit-Position: refs/heads/master@{#714036}
-
Daniel Rubery authored
The download deep scanning mocks suggested a few design improvements for download warnings in general, outside the enterprise space. One such improvement was to place the warning icon over the file icon as a sort of badge, to preserve continuity. Link to mocks: https://docs.google.com/presentation/d/1MH7zM5YiuCZr3jYsqkTJRC0cqtdo8wuWZOOQ66jptVk/edit#slide=id.g5e05da6dd9_0_63 Screenshots: In progress: https://screenshot.googleplex.com/76WnABzzaWS.png Paused: https://screenshot.googleplex.com/ytFeKiXBVOS.png Failed: https://screenshot.googleplex.com/jVYPuOzQqxU.png Complete: https://screenshot.googleplex.com/GgwNkEYu0bC.png Dangerous: https://screenshot.googleplex.com/57bs5vLAYd3.png Bug: 1020423 Change-Id: I32e4660a71fbc3b9333b64666d56a3378035bd7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898520Reviewed-by:
-
Rune Lillesveen authored
Enables marking of flat tree, instead of light tree, ancestors child- dirty for style recalc. This means we can skip traversing sub trees for shadow host children which are not part of the flat tree. Bug: 972752, 971588 Change-Id: I302e840aed435c9cf146d5e49a01388b9e8718a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715298 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#714034}
-
Dale Curtis authored
We invalidated the callback we give to MediaCodecBridge for asynchronous API callbacks during MCVD::Destroy(), so we never get notified when the EOS we queued as input completes. Thus leaking VP8 players continuously! We could change to not invalidating the WeakPtr for the asynchronous callback, but since draining is for a KitKat era issue, lets drop the drain entirely when using the asynchrous API (N+). BUG=1006092 TEST=vp8 instances are no longer leaked. R=liberato Change-Id: I3ea9c6013686000f176891eb8e645a60430adc71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906116 Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#714033}
-
Scott Violet authored
BUG=none TEST=none Change-Id: I0bb59ce7360419c14a67074fb5a0d432aac6634d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906308 Auto-Submit: Scott Violet <sky@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
-
Joon Ahn authored
Make the crash ID clickable for Googlers and redirect to http://crash/crash_id Fixed: 1009148 Change-Id: Icf26d9c7ac2bf78beb00a17d5a85d50c29c94ecb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888534 Commit-Queue: Joon Ahn <joonbug@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Ian Barkley-Yeung <iby@chromium.org> Cr-Commit-Position: refs/heads/master@{#714031}
-
Chris Mumford authored
This change switches from using testing::CreateFunctor when calling testing::Invoke() to a C++ lambda. This improves test readibility and allows for gmock_mutant.h to be removed in an upcoming CL. TBR=pinkerton@chromium.org Bug: 1007833, 806952 Change-Id: Id60006d1fb841ca89f47c20170ee2df4c16e8c2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887842Reviewed-by:
Chris Mumford <cmumford@google.com> Commit-Queue: Chris Mumford <cmumford@google.com> Cr-Commit-Position: refs/heads/master@{#714030}
-
Chris Mumford authored
base::RepeatingTimer::Start explicitly requires a RepeatingTimer. TBR=miu@chromium.org Bug: 1007810 Change-Id: Iac362b7f0f806c416551af44a233ba6df72ae3d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880462Reviewed-by:
-
Sean Kau authored
Adding Printing.CUPS.HighestIppVersion which will record the largest version a printer supports when it is queried during setup. Bug: chromium:1020016 Change-Id: I7180ed1f147b812d660903381af7aaba6e500bcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892193Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#714028}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/c03ce008b9fe..ef55c4e738de git log c03ce008b9fe..ef55c4e738de --date=short --no-merges --format='%ad %ae %s' 2019-11-08 chrisforbes@google.com Fix PointCoord builtin Created with: gclient setdep -r src/third_party/swiftshader@ef55c4e738de If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:b/140680704 Change-Id: I8036cbeb1c31a3bb2dad59def390e9a701550bc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907284Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/fdd7f421..f2af41c8 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Id703966e518bee4da60a2cc5a2ffccb599619fe1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906810Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#714026}
-
Austin Orion authored
A couple of pixel-diff web tests that load videos are flakily failing when the video thumbnail doesn't load before the test completes. This change adds a call to requestAnimationFrame(), this will delay test completion until the next paint event which should ensure the thumbnail has time to render. These are the specific tests and examples of this failure: media/track/track-cue-rendering-vertical.html Actual output: https://isolateserver.appspot.com/browse?namespace=default-gzip&digest=f442e58feefd4b369fe10ad79d0a08fd06c52e98&as=layout-test-results%5Cvirtual%5Caudio-service%5Cmedia%5Ctrack%5Ctrack-cue-rendering-vertical-actual.png Expected output: https://isolateserver.appspot.com/browse?namespace=default-gzip&digest=1825086dd5eba7e7f44f92eb65f8a7d96d4d96a9&as=layout-test-results%5Cvirtual%5Caudio-service%5Cmedia%5Ctrack%5Ctrack-cue-rendering-vertical-expected.png media/video-display-toggle.html Actual output: https://isolateserver.appspot.com/browse?namespace=default-gzip&digest=8af52e11ce9cde942897c679774a0cb7ee7defe2&as=layout-test-results%5Cvirtual%5Caudio-service%5Cmedia%5Cvideo-display-toggle-actual.png Expected output: https://isolateserver.appspot.com/browse?namespace=default-gzip&digest=a3189550a01f577a6eb50ff52c912dee59a840bc&as=layout-test-results%5Cvirtual%5Caudio-service%5Cmedia%5Cvideo-display-toggle-expected.png Change-Id: I005c4795bf08a26dd3555f7e5050172897660dd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901643Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Austin Orion <auorion@microsoft.com> Cr-Commit-Position: refs/heads/master@{#714025}
-
Josh Karlin authored
What: Measures FCP of third-party iframes on pages. Note that this will be a bit wonky at times, as lazy-loaded frames will have a very long FCP. Why: So that we can measure the impact of triple-keying the cache on loading subframes. How: Added a third_party_metrics_observer metric. The class records third-party origin iframes FCP and remembers that the RenderFrameHost has been recorded so that it's not recorded again. Change-Id: Ib4b053eee81210a5ea0a2fec167d4f5995e29967 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890996Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
John Delaney <johnidel@chromium.org> Commit-Queue: Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#714024}
-
Wei-Yin Chen (陳威尹) authored
INITIAL_SCROLL_INDEX_OFFSET was not properly set if tab restoration finishes after tab switcher is shown. Bug: 1022289 Change-Id: I63d18d0fae7b6e6d40865667f7bd0fecdd684f4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903526 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#714023}
-
- 08 Nov, 2019 19 commits
-
-
Jon Mann authored
There was a 10px margin at the top of each collapsible section which was not included in the animation used when collapsing. This lead to a smooth animation for most of the collapse, followed by an awkward jump for the end of it. Fixed: 1009978 Change-Id: I04b94a4c8f497fe0d6e7574f201fae389b626d00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907198Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/814821a14375..5eb17d38f7f7 git log 814821a14375..5eb17d38f7f7 --date=short --no-merges --format='%ad %ae %s' 2019-11-08 tsepez@chromium.org Better testing of CJS_Icon from JavaScript 2019-11-08 awscreen@chromium.org [FXCRT] Add unit tests for CFX_FloatRect::GetOuterRect() 2019-11-08 tsepez@chromium.org Remove bWillCommit argument from OnField_Format() methods. 2019-11-08 tsepez@chromium.org Cover some JS public methods that do not "commit". 2019-11-08 shwali@microsoft.com Fix nits in FPDFAnnot_SetAP 2019-11-08 tsepez@chromium.org De-virtualize CBC_OneDimWriter::RenderTextContents(). Created with: gclient setdep -r src/third_party/pdfium@5eb17d38f7f7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=pdfium-deps-rolls@chromium.org Bug: chromium:1019026 Change-Id: I02c04c3f9bdff76dfc54dc080ef4789eef783c46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907285Reviewed-by:
-
Wei-Yin Chen (陳威尹) authored
Simplify ReturnToChromeTest before adding more tests to it in http://crrev.com/c/1903526. Bug: 1022289 Change-Id: I5faa1814addfa58f3cb5729b7176025ae3092fc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904958 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#714020}
-
Chris Mumford authored
Switching to using a base::OnceClosure when calling RemotingDataStreamSender::set_connection_error_handler as it explicitly accepts a base::OnceClosure (see mojo/public/cpp/bindings/interface_ptr.h). TBR=erickung@chromium.org Bug: 1007810 Change-Id: I02aa1ea954c961b1a1158fc817969d5404936e81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880147Reviewed-by:
-
Matt Menke authored
This was once used by a perftest, but that test was deleted over 2 years ago in https://codereview.chromium.org/2752713002 Bug: 701387 Change-Id: Ied2cc55f89bff9a13cf9fc07f9dc5fa64e115c4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906304Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#714018}
-
Peter Kotwicz authored
WebappActivity is the only class which extends SingleTabActivity. BUG=1022819 Change-Id: I1f837d2251f45e97b8dec8cbde2a53056867cb04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906312 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#714017}
-
Clark DuVall authored
This matches what the aidl processor will do in google3 and the behavior described in https://developer.android.com/guide/components/aidl. Change-Id: I849664d28642dfecd615ec1b4ae66821367312d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906305Reviewed-by:
-
Alexander Timin authored
Remove kInternalIPC task type. - If it's used to bind associated interface, use kInternalNavigationAssociated instead. - If it's used to bind non-associated interface, use the task source mentioned in the spec or kInternalDefault if it's not speced. R=tobiasjs@chromium.org Change-Id: I0f1ac37df2afda909b8fe018192197cce64a0e01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906212Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#714015}
-
James Cook authored
The build flag was introduced when we supported the app list on Windows, Mac and Linux. However, the app list currently only works on Chrome OS and it's been that way for years. Eliminate the separate build flag. This exposes some dead code (e.g. app list support for desktop linux) and unused art assets. We also don't need Title Case translations, since Chrome OS uses sentence case. This CL cleans up everything except chrome/test/BUILD.gn and chrome/chrome_paks.gni. For chrome/browser/extensions/component_extensions_whitelist: TBR=benwells@chromium.org Bug: 1022886 Change-Id: I6ddb06a27565f2ef765156b1db6b2fb2da7e420e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906936Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#714014}
-
Alexander Timin authored
Remove kInternalIPC task type. - If it's used to bind associated interface, use kInternalNavigationAssociated instead. - If it's used to bind non-associated interface, use the task source mentioned in the spec or kInternalDefault if it's not speced. R=haraken@chromium.org Change-Id: I4b898b0988dfb741f6bb59544684ca69ff5f6b62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887693Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#714013}
-
Chris Mumford authored
This change switches from using testing::CreateFunctor when calling testing::Invoke() to a C++ lambda. This improves test readibility (slightly) and allows upcoming changes to gmock_mutant.h (switch away from base::Bind()). TBR=dimich@chromium.org Bug: 1007833, 806952 Change-Id: I47ece0d764fd503846ba788e5be5e0d53a8bce34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873399Reviewed-by:
-
Tommy Li authored
The previous way we counted async match changes in AutocompleteController was wrong, because I misunderstood how AutocompleteResult::CopyOldMatches works. Previously, CopyOldMatches would actually *move* the matches from the old result to the new result. This operation cleared out |last_result|. Since we determine if a match position has changed by comparing |last_result| to the new |result_|, this overinflated the number of changed matches. I've verified this by adding detailed logging on my test machine. This CL makes CopyOldMatches take a const parameter, and copy over the old matches without mutating |last_result|. I think there's no way for us to do this type of logging while still doing the destructive-move from |last_result|, and I suspect doing a copy instead of a move will have a negligible performance impact, and no memory impact. Bug: 398135 Change-Id: I0e1c5f58c6264b5be4c3d12366ae6e3c66f2a04f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899314Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Kevin Bailey <krb@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#714011}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/16787735601c..39b4b38f4f36 git log 16787735601c..39b4b38f4f36 --date=short --no-merges --format='%ad %ae %s' 2019-11-08 ellyjones@google.com mac newsdk: build glfw with -Wno-objc-multiple-method-names Created with: gclient setdep -r src/third_party/dawn@39b4b38f4f36 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: chromium:973128 Change-Id: I2029461d55d6453b8dcdfbc21d836707bea8408c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906715Reviewed-by:
-
Felix Zhu authored
As part of FTP-048, unions will be migrated to use explicit ordinals. This updates all FIDL unions to use the explicit ordinal syntax. Bug: fuchsia:40859 Change-Id: Ie4cab2101cd7340affe8148cad7989a86776bbcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899910Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Felix Zhu <fcz@google.com> Cr-Commit-Position: refs/heads/master@{#714009}
-
Nektarios Paisios authored
Every accessibility object has an ID that is used to identify the object in accessibility events, calls to methods that navigate the accessibility tree, such as IAccessible::get_accChild and get_accParent, etc. Before this patch, we were erroniously exposing an ID of -1 in the accessibility data of every View instead of its correct ID. R=aleventhal@chromium.org Change-Id: I77f31c2a3c0138ff505ff386999c60bf7465fac1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907428Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#714008}
-
Victor Vasiliev authored
quic_transport_simple_server is a simple QuicTransport server that can discard or echo back all of the traffic it receives, depending on how it's configured. Note that I've not tested the functionality of this server fully (as I don't have a corresponding client binary), but it does correctly parse ALPN and reject HTTP/3 when offered. R=rch@chromium.org Change-Id: I6396e95d180a41a9afdb185f0891c787d0c67c36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903958 Commit-Queue: Victor Vasiliev <vasilvv@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#714007}
-
Toni Barzic authored
Removes HomeScreenDelegate::UpdateAfterHomeLauncherShown, which was only updating expand arrow visibility, and move the logic to HomeScreenDelegate::OnHomeLauncherTargetPositionChanged. The method was used to update expand arrow visibility when home launcher is shown. Given that OnHomeLauncherTargetPositionChanged is expected to get called during the same sequence, expand arrow visilibity can be moved there without losing much, and reduces the number of methods that need to be called while using gestures to show/hide home launcher. Also, updates how app list progress is calculated when app list is scaled in tablet mode to ignore app list translation that was added during scaling (without this, if arrow is painted while app list view is scaled down, it might be slightly bent). BUG=1022530 Change-Id: Ie284b413bdc576121757c1c4bb1b4280c97e06b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904235Reviewed-by:
Manu Cornet <manucornet@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#714006}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/e9709db85ca9..c1e84c789f8d git log e9709db85ca9..c1e84c789f8d --date=short --no-merges --format='%ad %ae %s' 2019-11-08 oysteine@google.com Merge "Re-land "Stack profiles: Reuse existing frame/module rows rather than adding one per sequence"" Created with: gclient setdep -r src/third_party/perfetto@c1e84c789f8d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I3cc3f4de7db752e95d241ba91ac7fa25ede12bc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907277Reviewed-by:
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: Ic8d59cb796fe30a71d4ed21abe9eda9202411ec3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906526Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#714004}
-
