- 05 Oct, 2018 40 commits
-
-
Tommy Steimel authored
This CL updates the volume slider length to be shorter in order to fix an issue where the slider is too long for the default audio controls length. Bug: 892048 Change-Id: I545fd2395ec277125f7c6edbfbdc56aa03b2580f Reviewed-on: https://chromium-review.googlesource.com/c/1265057Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#597244}
-
Mounir Lamouri authored
Bug: 892483 Change-Id: Ia0a8347c1f31ba087759c2f53bea156f9d091d41 Reviewed-on: https://chromium-review.googlesource.com/c/1264818Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#597243}
-
Mounir Lamouri authored
This changes follow the spec with regards to pausing a video when it leaves a document: when a video leaves a document, the removal process should continue and, asynchronously, Blink checks that the video is still in an active document. It allows a video to move from one part of the document to another without pausing. Moving into a document or into two different outside of the document trees will also not pause. This is following the specification and Edge/Safari/Firefox implementations. Bug: 382879, 490511 Change-Id: I48abdaa5f81790e2cae7edc7b0bfb444f6ee7787 Reviewed-on: https://chromium-review.googlesource.com/c/1074808 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/64626344db73..942603d49e30 git log 64626344db73..942603d49e30 --date=short --no-merges --format='%ad %ae %s' 2018-10-05 ihf@chromium.org Add betty-arcnext to pre-cq. Created with: gclient setdep -r src/third_party/chromite@942603d49e30 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I0660fda5253a32c71f5109b81b8413778e095779 Reviewed-on: https://chromium-review.googlesource.com/c/1265045Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#597241}
-
James Wallace-Lee authored
Pass mouse events to chromevox's mouse_handler.js, and fire hover events on mousemove. This allows mousemove events to cause spoken feedback using the same functions as touch exploration. Mouse events are only rewritten if the chromevox option speakTextUnderMouse is enabled. Note: chromevox only receives mousemove events when the mouse is down. Temporarily, this functionality is used by holding the mouse button down and moving the pointer around the page. Bug: 853581 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I2feb14a1f5d765296fde9a923b862c99f45b41bb Reviewed-on: https://chromium-review.googlesource.com/c/1234260Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: James Wallace-Lee <jamwalla@chromium.org> Cr-Commit-Position: refs/heads/master@{#597240}
-
Xi Han authored
In the new startup code, ServiceManagerContext (SMC) will be created before the BrowserMainRunner is created. In the constructor of SMC, the GetMediaTaskRunner() accesses the TaskRunner of a media thread created by CastBrowserMainParts which will be created after the BrowserMainRunner. So we make the CastContentBrowserClient own the media thread and create it upon request. Bug: 887638 Change-Id: I8986f5b00600760afc8bf00bac140f459c7145d1 Reviewed-on: https://chromium-review.googlesource.com/c/1258204 Commit-Queue: Xi Han <hanxi@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#597239}
-
Christopher Cameron authored
Track parent and children in BridgedNativeWidgetHostImpl. This tracking is already done in BridgedNativeWidgetImpl, which is not necessarily accessible in the browser process. Update the parent in NativeWidgetPrivate::ReparentNativeView, but only when the BridgedNativeWidgetImpl state would be updated by BridgedNativeWidgetImpl::ReparentNativeView. Remove BridgedNativeWidgetHostImpl from its parent in OnWindowWillClose. Move removal of children from being in BridgedNativeWidgetImpl's destructor to between calling OnWindowWillClose and OnWindowHasClosed, to ensure that all children have detached themselves before their parent is destroyed. Update some functions in NativeWidgetMac and NativeWidgetPrivate to use the state in BridgedNativeWidgetHostImpl, instead of using the state in BridgedNativeWidgetImpl. Bug: 859152 Change-Id: Id98b9239db88154d9304f84d369d40d47af61d0f Reviewed-on: https://chromium-review.googlesource.com/c/1262624 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#597238}
-
Kurt Horimoto authored
Bug: none Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Iadcd8c150ab8cf90821f0ea9bef7e71eccf706d6 Reviewed-on: https://chromium-review.googlesource.com/c/1262796 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#597237}
-
Jonathan Metzman authored
Bug: 888006 Change-Id: I95b5936b1d9f2358a1b6dd75f7f3e3f1edcf2dd2 Reviewed-on: https://chromium-review.googlesource.com/c/1260217 Commit-Queue: Jonathan Metzman <metzman@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#597236}
-
Anne Lim authored
Implemented a cache in form of a [key, StrikeData] map for set or retrieved values to avoid hitting the disk repeatedly for the same card. Bug: 884717 Change-Id: I5e8a5936a54f30a64a919a97314cd04d3874b2a2 Reviewed-on: https://chromium-review.googlesource.com/c/1249130 Commit-Queue: Anne Lim <annelim@google.com> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#597235}
-
Drew Davenport authored
In UpdateControllerToWindowMapping, EnableController only needs to be called if the window is moving from one controller to another. Check if the window was not associated with a controller, and do not call EnableController in that case. BUG=888561 Change-Id: Ie077c13c804dbbce9315c75b6ad22a3ec4d6c8d8 Reviewed-on: https://chromium-review.googlesource.com/c/1263415Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Drew Davenport <ddavenport@chromium.org> Cr-Commit-Position: refs/heads/master@{#597234}
-
Marijn Kruisselbrink authored
This is a reland of 9594a943 Original change's description: > [FileSystem] Add support for selecting multiple files or directories. > > Bug: 878581 > Change-Id: I65fc0029da2e3951495a6cd96704085e5c1b942c > Reviewed-on: https://chromium-review.googlesource.com/1227366 > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Daniel Murphy <dmurph@chromium.org> > Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#594132} Tbr: dmurph@chromium.org, dcheng@chromium.org Bug: 878581 Change-Id: Ic145a6b48279f29368fbbc802751eb3d43b4ef4c Reviewed-on: https://chromium-review.googlesource.com/c/1265058Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#597233}
-
Morten Stenshorne authored
Remove NG special code from LayoutText::DebugRect() and have it call FirstRunOrigin() instead of FirstRunX() and FirstRunY(). Remove those two methods. Also update WriteTextFragment(), so that the coordinates it outputs match those from DebugRect(). Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I10947db5a031580095633eb690711720736c99d1 Reviewed-on: https://chromium-review.googlesource.com/c/1264639 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#597232}
-
Jian Li authored
Also make EoS url fetcher support immediate or background fetch with different backoff policy. Bug: 867488 Change-Id: If41abed1f85781cf84b9038f600e0a94c6c1524c Reviewed-on: https://chromium-review.googlesource.com/c/1263053 Commit-Queue: Jian Li <jianli@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#597231}
-
Matt Menke authored
Since NetLog is moving to the network service, we will no longer need ChromeNetLog. This is a step towards removing the class, while maintaining all functionality. This is the only member of ChromeNetLog that was used on iOS, so this CL also updates iOS to use NetLog directly instead. Bug: 767450 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I0ef4674b564f4575e256d40795bac051242ccf2a Reviewed-on: https://chromium-review.googlesource.com/c/1264915 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Reviewed-by:
-
Scott Violet authored
This argument ended up setting the field twist on PointerDetails. The TouchEvent constructor *also* takes a PointerDetails. So, having TouchEvent reset the twist was mildly confusing, especially when it has a default value. This patch removes the angle argument to PointerDetails. BUG=none TEST=covered by tests Change-Id: I5edf042df2e6e61c73a406bf2f15f45079991cb9 Reviewed-on: https://chromium-review.googlesource.com/c/1264975Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#597229}
-
Lan Wei authored
In the test "hover-during-scroll.html", we tried to test that new hover effects should not be invoked during scroll if the mouse cursor is not visible, so we set |internals.setIsCursorVisible| to false. However, when we run the test, we set the mouse cursor visible to true when we run smoothScroll function, and a mouse move will also set the mouse cursor to be true. Therefore, we should remove the related code from this test. Bug: 877132 Change-Id: I860b778dacc62c20dbd541d607a2b4ee83bb84b1 Reviewed-on: https://chromium-review.googlesource.com/c/1250082Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#597228}
-
Steven Bennetts authored
This also includes some cleanup of default values, renames 'override' -> 'behavior', and documents the KeyboardOverscrollBehavior enum. Bug: 843332 Change-Id: I5149d41701ff44606f2ce4dec3f74d263ed411d2 Reviewed-on: https://chromium-review.googlesource.com/c/1262958Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#597227}
-
Donn Denman authored
Introduced recently in CL https://chromium-review.googlesource.com/c/chromium/src/+/1262090. BUG=892669 Change-Id: I9b69ba69c0a950c11de218a622bce041b4b6a98f Reviewed-on: https://chromium-review.googlesource.com/c/1265156Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#597226}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/497958d899c3..03cbf33a695e git log 497958d899c3..03cbf33a695e --date=short --no-merges --format='%ad %ae %s' 2018-10-05 jaebaek@google.com Validator: FPRoundingMode decoration (#1482) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@03cbf33a695e The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I43af696c49d7bbcd206ec534629ad1568bbdbfb2 Reviewed-on: https://chromium-review.googlesource.com/c/1265067Reviewed-by:
-
danakj authored
Currently the URL is acquired through a few jumps between RenderWidget and RenderViewImpl. RenderFrameImpl asks RenderView for the URL, but it is actually asking the RenderWidget. RenderWidget goes to the owner delegate if present, so back to the RenderView, to get the main frame in order to get the URL. With pepper, the RenderWidgetFullscreenPepper overrides the RenderWidget method, so when it tries to get the URL it ends up going to the pepper object instead. This makes 2 different ways that the GetURLForGraphicsContext3D() method gets redirected. Then also the UpdateURLForCompositorUKM() finds the main frame and gets the URL itself, if the RenderWidget is attached to the main frame. Notably, popups do not provide a way to redirect GetURLForGraphicsContext3D(), so they do not get a URL at all for the gpu channel ever. Instead of these many methods, we add a GetURLForDebugTrace() method on WebWidget, that RenderWidget can query. When the RenderWidget is for a frame, the WebFrameWidget will acquire the URL. When the RenderWidget is for a popup, the WebPagePopupImpl will do likewise, from the frame tree that spawned the popup. And when the RenderWidget is for fullscreen pepper, the PepperWidget can know the URL and return it (in this case RenderFrameImpl continues to grab the URL and give it to the RenderWidgetFullscreenPepper in order for it to provide it. Then UKM can also use this method, and but just only use the URL if the RenderWidget is itself attached to the main frame, which can be queried without involving the RenderView. R=ajwong@chromium.org, dcheng@chromium.org, piman@chromium.org Bug: 419087 Change-Id: Iad18c5f7ea902eaa02f58645ede61a5b4609b561 Reviewed-on: https://chromium-review.googlesource.com/c/1237177 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#597224}
-
rbpotter authored
Fixing and enabling: CrSettingsInternetDetailPageTest.InternetDetailPage CrSettingsInternetPageTest.InternetPage Bug: 875454 Change-Id: I2a1f31c623d67e178ab99d3558aa9e7e06a8c8c0 Reviewed-on: https://chromium-review.googlesource.com/c/1262934Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#597223}
-
Mark Pearson authored
and re-enable it Call the scoped feature list earlier in test setup instead of in the middle of a test. Calling scoped feature list in the middle of a test will clobber existing features, which could result in problems as behavior changes mid-run. (I am not ready to review this feature flag yet. This feature has caused problems in the past, so I'd like to keep the flag around for longer. It has little overhead in the code.) Bug: 891959 Change-Id: I2cee38ff6ff2cc7de16ba1d260f831cee5a68349 Reviewed-on: https://chromium-review.googlesource.com/c/1263562Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#597222}
-
Charlie Harrison authored
It is easy to misuse this class and either: 1. Ignore the return value for |Initialize| 2. Forget to check |IsValid| after initialization This CL makes it impossible to ignore initialize, so callers must handler mmap failures. Bug: None Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Idc39565ccd80234ed54aafdd6174d37fff259e9f Reviewed-on: https://chromium-review.googlesource.com/c/1262758Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Fredrik Hubinette <hubbe@chromium.org> Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#597221}
-
Xi Han authored
Add an additional check before calling GetPreemptedSequenceToScheduleLockRequired(). Bug: 892633 Change-Id: I7ee9bcf1e05a96dbabb9378fc6ea99118e0810fe Reviewed-on: https://chromium-review.googlesource.com/c/1263894Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#597220}
-
Scott Little authored
This is a partial revert of https://chromium-review.googlesource.com/c/chromium/src/+/1166600, as a temporary workaround to the bug listed below, which is caused by a bug in the network stack that affects partial range cache revalidations. This CL only bypasses the cache when reloading placeholders for LoFi, and not when reloading placeholders for lazily loaded images, because bypassing the cache when lazily loading images can potentially waste a lot of network data, plus lazy image loading isn't launched yet, so keeping the behavior as-is will make it easier to debug and fix the underlying problem. Bug: 892461 Change-Id: I96ed023431fc4e7e346497820da1de14940aca64 Reviewed-on: https://chromium-review.googlesource.com/c/1263565Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Scott Little <sclittle@chromium.org> Cr-Commit-Position: refs/heads/master@{#597219}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/949f77f4..da3dfedf Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I0860759a870f581047fe28eb4e5e2427e41b5b2a Reviewed-on: https://chromium-review.googlesource.com/c/1265076Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#597218}
-
Dmitry Titov authored
It should compute and report monthly visited host count approximatley every week. It also only runs once per Chrome session and after a delay to avoid slowing down startup. The average cost of computation is less than 10ms and most of it is on background thread, however this is still enough to implement 'sparse' way of querying. Bug: 867488 Change-Id: I000ef4224f87d4d98c0a73519ce9648feb158df7 Reviewed-on: https://chromium-review.googlesource.com/c/1260494 Commit-Queue: Dmitry Titov <dimich@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#597217}
-
Kurt Horimoto authored
This CL updates the |-hitTest:withEvent:| implementation for the toolbar container view such that touches are ignored when they occur within the container, but not on an actual toolbar. This allows touches to reach the web content area when the toolbars are collapsed and the content is laid out behind the container. Bug: 889884 Change-Id: Ifbb6aff819784c692da9fdd649febfe51688e9f7 Reviewed-on: https://chromium-review.googlesource.com/c/1259882Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#597216}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/2fb631023730..0c3bd49069d4 git log 2fb631023730..0c3bd49069d4 --date=short --no-merges --format='%ad %ae %s' 2018-10-05 ehmaldonado@chromium.org bot_update: Don't use apply_patch_on_gclient. Created with: gclient setdep -r src/third_party/depot_tools@0c3bd49069d4 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:891917 TBR=agable@chromium.org Change-Id: I5d9d64b7c5d3f22b4958d8e4629f54246d1d7799 Reviewed-on: https://chromium-review.googlesource.com/c/1265061Reviewed-by:
-
Becca Hughes authored
Add an about://flags flag to enable unified audio focus on ARC++. BUG=883958 Change-Id: Idd0738a116d9eeaf225fab79de5945f73299dca7 Reviewed-on: https://chromium-review.googlesource.com/c/1237406 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#597214}
-
Ryan Hansberry authored
Delay showing the 'Chromebook added' notification until the MultiDeviceSetupDialog has been closed. R=jhawkins@chromium.org, khorimoto@chromium.org Bug: 883069 Change-Id: If8ae079f77de89cede94ea840e5335445fb7a0ad Reviewed-on: https://chromium-review.googlesource.com/c/1260304Reviewed-by:
James Hawkins <jhawkins@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#597213}
-
Robbie McElrath authored
Bug: 881976 Change-Id: I39b93d0db822c341c7834ee100be957eaecbd15d Reviewed-on: https://chromium-review.googlesource.com/c/1263046Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#597212}
-
Ned Nguyen authored
Bug:792928 Change-Id: Ie383f3a5f499eee5e118668b6570800fa78fbdbe NOTRY=true # doesn't affect CQ Change-Id: Ie383f3a5f499eee5e118668b6570800fa78fbdbe Reviewed-on: https://chromium-review.googlesource.com/c/1263336 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
-
Stephane Zermatten authored
runnable scripts. Before this patch, the controller only run an autostart script if it was the single runnable script. This means that the presence of non-autostart, but runnable script prevents autostart from triggering. This was a misunderstanding. As long as there is exactly one autostart script, it must be started, and other runnable scripts can be ignored. After this patch, as long as there is exactly one autostart script, it is run. Bug: 806868 Change-Id: Id60223064bc3ed8fc364f7f9a8ae1a4ed4ef921b Reviewed-on: https://chromium-review.googlesource.com/c/1264658Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Commit-Queue: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#597210}
-
Mugdha Lakhani authored
"background-fetch" permission was added to the Permissions API with this commit: https://github.com/w3c/permissions/pull/183/commits/096436eb59caaa5b244b0514d84f287392cb069b Chrome uses Automatic Downloads for this permission, so as not to add yet another user facing permission to the UI. This CL: 1. Adds a background_fetch content setting, because that's needed by PermissionContext and allows us to decouple from Automatic Downloads content setting. 2. Adds a BackgroundFetch PermissionContext mapped to this content setting. 3. Makes this PermissionContext decide whether background fetch() is permitted, which we do by: a. Querying DownloadRequestLimiter when there' a top level frame. b. Querying the Automatic Downloads content setting in other cases. For context and details, please see this document: https://docs.google.com/document/d/1rPYSlbzScw_6PLUJ3m96ZLIkxXVAWyBSL75-VDJEMso/edit?usp=sharing Bug: 886896 Change-Id: Id0fcc64d4242290f3782c61ef11babe5717b409f Reviewed-on: https://chromium-review.googlesource.com/c/1233714 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#597209}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: I67564c434bcf88639d7703d207f5a8f874549c9b Reviewed-on: https://chromium-review.googlesource.com/c/1265068Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/39cf6a765ae3..9934cc2f2f1a git log 39cf6a765ae3..9934cc2f2f1a --date=short --no-merges --format='%ad %ae %s' 2018-10-05 tsepez@chromium.org Tidy PWL_FLOATRANGE Created with: gclient setdep -r src/third_party/pdfium@9934cc2f2f1a The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ib220b512ee0b339c7f7a0ffc41c945182817ceac Reviewed-on: https://chromium-review.googlesource.com/c/1265063Reviewed-by:
-
Kyle Milka authored
This reverts commit 5d112920. Reason for revert: Broke old UI and we probably won't be able to completely remove the old UI in M71. Original change's description: > [NTP] Remove UI MD flag > > Remove flag for ntp md ui. Change the new styling to be the > default and remove the md class, this mainly affects the fakebox > as the icons are styled via md-icons. > > Bug: 864673 > Change-Id: I7eb5da522a657417c527e3aa666bab14f8485bef > Reviewed-on: https://chromium-review.googlesource.com/1255600 > Reviewed-by: Ilya Sherman <isherman@chromium.org> > Reviewed-by: Kristi Park <kristipark@chromium.org> > Commit-Queue: Kyle Milka <kmilka@chromium.org> > Cr-Commit-Position: refs/heads/master@{#595953} TBR=isherman@chromium.org,kristipark@chromium.org,kmilka@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 864673 Change-Id: I5ef13705787953e96b7e4b0ead21e1e8aeb558d1 Reviewed-on: https://chromium-review.googlesource.com/c/1265024Reviewed-by:
Kyle Milka <kmilka@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#597206}
-
Christian Biesinger authored
R=ikilpatrick@chromium.org,eae@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I3836a9f162723371650e239918cc43412ab6c6c4 Reviewed-on: https://chromium-review.googlesource.com/c/1265066Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#597205}
-
