Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 31 Mar, 2020 36 commits
  3. 30 Mar, 2020 4 commits
    • behdad's avatar
      Long main thread work is not blocking Impl work being reported · 65b15787
      behdad authored 
      During submit, if the frame is not activated yet, a copy of reporter at
Begin_Impl stage will be created and reported. This reporter is the
Begin_Impl portion of the existing reporter which is in Begin_main or
Commit stage.

So in the case of:
BI_1 BM_1 S_1 P_1 BI_2 C_1 A_1 S_2 P_2

In addition to:
BI_1 -> BM_1 -> C_1 A_1 S_2 P_2

This set will also be reported:
BI_1 -> S_1 -> P_1

Bug: chromium:1059282
Change-Id: I581088a41cd8ee1247fa18e28e4a24f5d4870103
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095350
Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org>
Reviewed-by: default avatarSadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754719}
      65b15787
    • Pavel Yatsuk's avatar
      tools/mb/mb.py should handle gn args with different number of spaces · fcbd5218
      Pavel Yatsuk authored 
      Currently GNArgsFromDir expects gn arg to have exactly one space around
assignment operator (target_os = "android"). It removes both spaces so
that later the code could to a check in the form
('target_os="android"' in vals['gn_args']). If an arg doesn't have
spaces or have extra (target_os ="android"), the logic works
incorrectly.

This CL fixes GNArgsFromDir to break name/value line on '=' and strip
spaces around both name and value.

BUG=1066289

Change-Id: I958b2cb400415f33f6b5310da0f127df715bd059
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127742
Commit-Queue: Pavel Yatsuk <pavely@chromium.org>
Reviewed-by: default avatarGarrett Beaty <gbeaty@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754718}
      fcbd5218
    • Collin Baker's avatar
      Handle swipes with no preceding scroll events · c275fc57
      Collin Baker authored 
      I incorrectly assumed that any ET_GESTURE_SWIPE would be preceded by an
ET_GESTURE_SCROLL_BEGIN. Sometimes this is not the case, and this caused a
DCHECK.

This change handles swipes that weren't preceded by a scroll event.

Bug: None
Change-Id: I535e43a10e6f6162080af4ba4b85a8fefc8e2cd6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128091Reviewed-by: default avatardpapad <dpapad@chromium.org>
Commit-Queue: Collin Baker <collinbaker@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754717}
      c275fc57
    • Karandeep Bhatia's avatar
      DNR: Implement indexing of multiple static rulesets. · c99af485
      Karandeep Bhatia authored 
      This CL:
  1. changes the installation code to index all static rulesets provided
  by an extension.
  2. Adds unittests to ensure 1. above works as intended.

Remaining work:
  1. Currently rule limits for static rulesets are only evaluated per
  ruleset. Implement them for the set of enabled rulesets once we
  start supporting the 'enabled' property as part of rulesets specified
  in manifest.
  2. We have limits on the no. of install warnings per ruleset. Also,
  add a limit on the total number of warnings across all rulesets.
  3. Load multiple static rulesets on extension load.
  4. Provide ability to dynamically toggle the set of enabled static
  rulesets.

BUG=754526

Change-Id: I92202ae69724f41ce1645af72dbc88e04fdc9f3c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107239
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: default avatarDevlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754716}
      c99af485