- 15 Jul, 2020 40 commits
-
-
Justin Cohen authored
Bug: 1106030 Change-Id: I7a422c99de9f3de5b613e38625260c93927adb36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299533 Commit-Queue: Justin Cohen <justincohen@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Auto-Submit: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#788769}
-
Leonid Baraz authored
Bug: b:161266545 Change-Id: I57f47b6c8acff90de983ca4c553b6f4fdacfba0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296636 Commit-Queue: Leonid Baraz <lbaraz@chromium.org> Reviewed-by:
Zach Trudo <zatrudo@google.com> Cr-Commit-Position: refs/heads/master@{#788768}
-
Miguel Casas authored
VASupportedProfiles is an internal class of vaapi_wrapper.cc in charge of enumerating the encoding/decoding video/image profiles supported in Chrome. It basically holds a |supported_profiles_| member, filled upon construction from GetSupportedProfileInfosForCodecModeInternal(). This CL: - Refactors GetSupportedProfileInfosForCodecModeInternal(), renaming it to FillSupportedProfileInfos()) to do all the enumerations needed, and reorders a bit the contents of the for-for-for loops, so that IsEntrypointSupported_Locked() is unnecessary and removed entirely. - Changes the signature of IsProfileSupported() to maybe-return a ptr to the ProfileInfo entry (and not a bool), which simplifies callsites. - Removes GetSupportedProfileInfosForCodecMode(), simplifying some of the callsites as well (except GetSupported...ForTesting() which is made a friend). - Sprinkles static_assert()s to verify sizes of constexpr data structs. This CL also removes the references to VAProfileVP9Profile1 and 3, because those are not present in my experience in the wild, neither in libva impls nor in videos, and are not properly validated nor tested. Bug: 1040291, 1105103 Change-Id: I6717cac3e57f5e304eae04272842efacf7e1f762 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292780Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#788767}
-
chrome://nearby-internalsJuliet Levesque authored
Add a tab that will eventually display Nearby-related HTTP messages. See the following screenshot for display: https://screenshot.googleplex.com/mL7965ihWuh. Bug: 1093634 Change-Id: I7d0cb3a15f6f114a888ff86ab0545f645ae5b9c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269700Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Josh Nohle <nohle@chromium.org> Commit-Queue: Juliet Levesque <julietlevesque@google.com> Cr-Commit-Position: refs/heads/master@{#788766}
-
Xiaohan Wang authored
The session expiration should only change after Update(), Load() or Remove(). This CL updates Update() and Remove() to update session expiration if needed. Load() remains unimplemented. Note that we don't need to update expiration on Close(), which is handled at a higher layer in MediaKeySession::OnSessionClosed(). Bug: 999747 Change-Id: Ie0f32cde8fcae46581cf135753a3de4b7e2ca7ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298344Reviewed-by:
John Rummell <jrummell@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#788765}
-
Stephanie Kim authored
It looks like win-official and win32-official occasionally take 4+ hours to complete. Even though win32-official hasn't seen any5 hour timeouts, some runs cut it pretty close so I'm increasing timeout for that too. Bug: 1106006, 1072012 Change-Id: I361ea8a3ee921a6af86fee34163f497529222ae2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300628Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Stephanie Kim <kimstephanie@google.com> Cr-Commit-Position: refs/heads/master@{#788764}
-
Anupam Snigdha authored
Clamped the values in |EnclosingIntRect| to avoid integer overflow while calculating the |IntSize| of the rectangle. Bug: 1100102 Change-Id: Ied4208ff989ac4bbf6c9a1f469ea4699b55b9dac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293232Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Anupam Snigdha <snianu@microsoft.com> Cr-Commit-Position: refs/heads/master@{#788763}
-
Tommy Li authored
Currently the section toggle buttons just announce the tooltips, which are a succinct "Show Suggestions" or "Hide Suggestions". This CL makes the announcement a more explanatory: "Show the 'Related to recent searches' section" Bug: 1099788 Change-Id: I7a8e982ab9bf1b62d8e5f5200174ff2ebb19488a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295929 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#788762}
-
Sven Zheng authored
Bug: 1104291 Change-Id: I5a988387b7c200aed1add10efe853d36c96a6578 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300229Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Sven Zheng <svenzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#788761}
-
Xi Han authored
Adds more logs to investigate the failures on test-go-phone. Bug: 1096833 Change-Id: Ic067a93ddb87c6afb314f415f69307fe31794394 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300269Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#788760}
-
Stepan Khapugin authored
Removes this histogram since it's not longer logged, and M85 has already branched. Bug: 1089174 Change-Id: Ic20d16aaedaf8aea83d6d58facd539bbec932820 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300112Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#788759}
-
Justin Cohen authored
Bug: 1103822 Change-Id: Id17a92cd2da3bbc57343c190fd63e77a859afc5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298940Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6531f33eb2bc..ed9549e829b5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC kristipark@google.com,rogerm@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: kristipark@google.com,rogerm@google.com Change-Id: I6b5ce281e4c811b4a5fd1ca6774b8a0045f342c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300291Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#788757}
-
Anand K Mistry authored
DictionaryValue::RemoveWithoutPathExpansion() is deprecated. For the case where nullptr is passed for the output argument, Value::RemoveKey() is a trivial replacement. Mostly done with the following command line, plus a bit of finesse: % git grep -l RemoveWithoutPathExpansion | \ xargs sed -E -i 's/RemoveWithoutPathExpansion\((.*), nullptr/RemoveKey\(\1/g' Bug: 646113 This CL was uploaded by git cl split. R=sorin@chromium.org Change-Id: Ic4ae22fba1a0d2012a6d89a80ef332a84a452e9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298761 Auto-Submit: Anand K Mistry <amistry@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#788756}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I256e893dacffdc33c793824249429d62fdc77d05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300503Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#788755}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I99ec4b5a1f2b4c23384b58d8e1a1eeb44848de65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300620Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/c44b2b2567ae..9277ee741395 2020-07-15 lehoangq@gmail.com Metal: Implement MSAA default framebuffer. 2020-07-15 jmadill@chromium.org Fix stale validation cache on buffer deletion. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1105202 Tbr: jonahr@google.com Change-Id: I20ba4fe11548660d3a0203425f1c64fc98ee85f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300289Reviewed-by:
-
Nodir Turakulov authored
metadata-exporter builder is modernization of https://ci.chromium.org/p/chromium/builders/ci/linux_chromium_component_updater It uses a new recipe which uses a new tool that understands both legacy OWNERS and new DIR_METADATA files. Try using new bbagent (as opposed to kitchen) from the start. Rename "component-mapping" notifier to "metadata-mapping" because it is cheap, compared to changing mailing list emails and service account emails. Create a new Milo console for new builder. Move existing builder from goma-specific console, because it has nothing to do with goma. Bug: 1102997 Change-Id: Ia0a988768c334b319fc11c38804c524a899fb119 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300602 Commit-Queue: Nodir Turakulov <nodir@chromium.org> Reviewed-by:
-
Vasiliy Telezhnikov authored
WebView/GLRenderer checks active frame of child surface for backdrop filters to decide if merging SurfaceQuad is possible. If surface doesn't have active frame it will fail CHECK. This CL adds guard if the surface has active frame before retrieving to prevent crashing. Bug: 1100340 Change-Id: Ia02cead1c2195ba738ad19cf99db83b10669c948 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300323Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#788751}
-
Anand K Mistry authored
DictionaryValue::RemoveWithoutPathExpansion() is deprecated. For the case where nullptr is passed for the output argument, Value::RemoveKey() is a trivial replacement. Mostly done with the following command line, plus a bit of finesse: % git grep -l RemoveWithoutPathExpansion | \ xargs sed -E -i 's/RemoveWithoutPathExpansion\((.*), nullptr/RemoveKey\(\1/g' Bug: 646113 This CL was uploaded by git cl split. R=rdevlin.cronin@chromium.org Change-Id: I9bb8090747407e77408a9fa1556ccba3633cbd51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298783 Auto-Submit: Anand K Mistry <amistry@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#788750}
-
Kristi Park authored
Multiple flakes on Webkit Linux Leak (e.g. https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20Leak/16692) TBR=hiroshige@chromium.org Bug: 1068175 Change-Id: Iee830b5b4c604ff4cf0527643447f389d3674a1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300231Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#788749}
-
Anand K Mistry authored
DictionaryValue::RemoveWithoutPathExpansion() is deprecated. For the case where nullptr is passed for the output argument, Value::RemoveKey() is a trivial replacement. Mostly done with the following command line, plus a bit of finesse: % git grep -l RemoveWithoutPathExpansion | \ xargs sed -E -i 's/RemoveWithoutPathExpansion\((.*), nullptr/RemoveKey\(\1/g' Bug: 646113 This CL was uploaded by git cl split. R=rdevlin.cronin@chromium.org Change-Id: Ic1fa9cea86ab7c6106af4db2837d773aaf8dac6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298859 Auto-Submit: Anand K Mistry <amistry@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b0b63703..e7945d6e Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Id36999313702de5f83d56987884af85326c2c5ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300007Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#788747}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/1de497cc50ab..0a8f44c514ce 2020-07-15 bclayton@google.com Regres: Collate and add new documentation for Regres If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I92e566619f9a7e5d14deb678350a73e7109bff4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300579Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/3bda66062b2e..1a82e68482aa 2020-07-15 treehugger-gerrit@google.com Merge "Use version script for heapprofd client API." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ia0c02d196546ad0dcdfda94e76362e6e10b94592 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300524Reviewed-by:
-
Peter Wen authored
Add benchmarks to measure improvements to turbine header generation and java compilation. A change to turbine.py will re-build all headers that chrome_public_apk depends on. Similarly for compile_java.py and building all .javac.jar files. Example: $ tools/android/build_speed/benchmark.py extra_incremental Summary gn args: target_os="android" use_goma=true android_fast_local_dev=true gn gen: 6.6s turbine_headers: 43.3s avg (43.2s, 43.5s) compile_java: 60.2s avg (59.9s, 60.5s) Bug: 1092528 Change-Id: I815ea2020b054c0fc0552afb5837dc1aa670e2e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300404 Commit-Queue: Peter Wen <wnwen@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#788744}
-
Francois Doray authored
This method was only used by the obsolete agent interference recorder. The "enqueue order at which we became unblocked" is still tracked internally, because it is used to compute the value of the "was_blocked_or_low_priority" argument passed to TaskObserver::WillProcessTask(). Bug: 1019856, 984057 Change-Id: Iaf7d742c7ab978eee4e105c53b28c6170642698a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297661 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#788743}
-
Bin Wu authored
Change-Id: Ib6254975ed3313b1debd3e147abeec11ddfa4c0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292788Reviewed-by:
David Schinazi <dschinazi@chromium.org> Commit-Queue: Bin Wu <wub@chromium.org> Cr-Commit-Position: refs/heads/master@{#788742}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I09561300dff61ba4d7a0688ae6653865aa1a363b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299522Reviewed-by:
-
Christopher Cameron authored
TBR=mcasas Bug: 1105566 Change-Id: Ie07c3f3c2197faf77aefa5fd35090020fda204fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300085Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#788740}
-
ckitagawa authored
This CL adds separate unit tests suits for - ScaleController - ScrollController - Viewport BitmapState is tightly coupled to the mediator so that continues to be covered by the mediator test. This CL also removes redundant mediator tests and cleans up the BitmapState @VisibleForTesting annotation. Many tests need to remain in the mediator to ensure that scroll/scale interact correctly with bitmap updates. Bug: 1099722 Change-Id: Ie38ece7d7e8bbbb05fa4356475f44ae537858139 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295223 Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Fred Mello <fredmello@chromium.org> Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#788739}
-
Dana Fried authored
Code now tries to align the badge font with the center of the primary menu item text (which actually aligns the "cap-height boxes" rather than the whole font because of how fonts are rendered. Values have been adjusted to meet redlines; see: https://docs.google.com/presentation/d/1iERU69_-_PpQba5MAvSdxCX_wZrqMpCZOjHCSbFyZWY/edit#slide=id.g8abf29f0df_2_60 but also to look best on both Windows 10 and Linux with standard font-rendering options. We may have to make some additional small tweaks for Mac. This patch also consolidates code and moves more general computations into text_utils at the request of some of the gfx/fonts owners. Bug: 1098731 Change-Id: I50fafa7291aad3131e16428f537bc0ed0266dae9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285511Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#788738}
-
rbpotter authored
Bug: 1000989 Change-Id: I56a24453859b60133d8d0366a51968de53c62c7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299000Reviewed-by:
John Lee <johntlee@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#788737}
-
John Delaney authored
Adds an enabled expirement for the Heavy Ads Intervention. Change-Id: Icf8f645fb171f2d97568915bae595e23910dc5dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300262Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: John Delaney <johnidel@chromium.org> Cr-Commit-Position: refs/heads/master@{#788736}
-
Dana Fried authored
These are important for hover card and tablet tabstrip performance monitoring. Bug: 1105000 Change-Id: Icc65936d1407a044afb58aaef12d8a002283ccc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298710Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#788735}
-
Ben Pastene authored
This is a reland of 8f372d5f Reason for reland: - All hand-rolled DEPS-consuming apps have been updated. - No changes in this CL between original & reland. Original change's description: > Split the cros_boards gclient var into two for fetching QEMU images. > > This will help with the TODO at: > https://source.chromium.org/chromium/chromium/src/+/master:build/config/chromeos/rules.gni;drc=ded9eb5153bb13b3f8821a6fa6fac6b3f0f590fd;l=22 > > It will also remove the need for hard-coding the names of all these > QEMU-compatible boards. > > Bug: 937821 > Change-Id: Iab180fc012bd694b4908ba0654da93d42e2274fa > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265498 > Commit-Queue: Ben Pastene <bpastene@chromium.org> > Reviewed-by: Erik Chen <erikchen@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@google.com> > Cr-Commit-Position: refs/heads/master@{#786005} Bug: 937821, 1103538 Change-Id: I6124b41f5032d9daffd4b9747ec3a974b19c6db4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299469Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#788734}
-
Katie D authored
This matches UX spec for these reader mode strings. AX-Relnotes: n/a Bug: 1041918 Change-Id: I12c1e54a684c42b655581851a15fc45c4850a9c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292695 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#788733}
-
Andrew Grieve authored
Bug: 1041930 Change-Id: Id4419b20a9f586bb4e00a751f7e10a36ac3f1a44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297729Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#788732}
-
Torne (Richard Coles) authored
Check final_android_sdk instead of public_android_sdk when deciding how to set the APK versionCode. This is a no-op for upstream as they are always the same, but for downstream builds means that we will only add the +50 offset when we're building against a preview SDK, instead of also adding it when we're building with a final-but-not-yet-upstreamed SDK. Bug: 1025990 Change-Id: Ife01462fa3f214760e88f498e33fca2c3d1c5c58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300265Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
-
Mike Wittman authored
The build id flag was enabled in non-official builds in https://crrev.com/776312. The tests depending on it can now be enabled in that configuration. Bug: 870919 Change-Id: I37e7bc2fbfad4b6df2126071652c4c5982e84e90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296263 Commit-Queue: Wez <wez@chromium.org> Auto-Submit: Mike Wittman <wittman@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#788730}
-
