GitLab

Remove //chrome/browser from the friend list for
//net/dns:host_resolve.  gn check passes without it now because all of
//chrome/browser's usage has been fixed to use //net/dns/public.

Also had to fix one last unused dns_config.h include.

Fixed: 1129993
Change-Id: I405ecb969398972ed335fa6b3674dc659ad033b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427346
Commit-Queue: Eric Orth <ericorth@chromium.org>
Reviewed-by: Dan McArdle <dmcardle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811320}

Roll ChromeOS Broadwell AFDO profile from 87-4247.0-1600681610-benchmark-87.0.4275.0-r1 to 87-4258.0-1601290734-benchmark-87.0.4275.0-r1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-broadwell-chromium
Please CC c-compiler-chrome@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: c-compiler-chrome@google.com
Change-Id: I29c7c0a2a654abe576a0e33100ce5423a2d1df7e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435915Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#811319}

Adding a wrapper function around Window's Share operation to allow using
it like a traditional async operation.

Adding tests (and one more test-helper class) that verify the behavior
of the wrapper function.

Bug: 1035527
Change-Id: I71cc7aaa6826d53cc1273c99b603db89612f1544
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402293
Commit-Queue: Hoch Hochkeppel <mhochk@microsoft.com>
Reviewed-by: Robert Liao <robliao@chromium.org>
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811318}

This reverts commit a5707a7d.

Reason for revert: Likely the cause of test failure in AccountPickerDialogFragmentTest on android builders:
* https://ci.chromium.org/p/chromium/builders/ci/android-arm64-proguard-rel/2755
* https://ci.chromium.org/p/chromium/builders/ci/android-pie-x86-rel/2363

The error said:
Attempt to invoke virtual method 'boolean org.chromium.base.ObserverList.c(java.lang.Object)' on a null object reference
	at org.chromium.components.signin.identitymanager.IdentityManager.addObserver(IdentityManager.java:95)
	at org.chromium.chrome.browser.signin.ProfileDataCache.addObserver(ProfileDataCache.java:211)

Original change's description:
> [Android][Signin] Add observer to listen to monogram update
>
> This CL adds an observer to update ProfileDataCache when user's profile
> photo(include monogram) from IdentityManager is updated.
>
> Bug: 1127886
> Change-Id: I0c70f72708e50dceb63eb122055315f7818cba06
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430984
> Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
> Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
> Commit-Queue: Alice Wang <aliceywang@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#811237}

TBR=msarda@chromium.org,bsazonov@chromium.org,aliceywang@chromium.org

Change-Id: I91562cb8017c2a74afd391fede5d9b206e7e6b5d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1127886
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435151Reviewed-by: Haiyang Pan <hypan@google.com>
Commit-Queue: Haiyang Pan <hypan@google.com>
Cr-Commit-Position: refs/heads/master@{#811317}

This CL marks marcheu@ as legacy OWNER (a.k.a. OWNER of last resort)
and proposes dcastagna@ to step up.

Change-Id: I430e02174a02fae85a95b87e9ee0d1728520d98a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432967Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811316}

Bug: 1131340
Change-Id: Idfe1fc338fabcb9d35840a00aaf3517ab26ef17c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433255
Commit-Queue: Gang Wu <gangwu@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811315}

Fetch weather separately with dedicated weather API. Also change
it to a different timer so we don't need to fetch it as frequently
as the photos.

Bug: b:166160411
Test: unittest and manual test
Change-Id: Ib0bd1ca271b1b4ac8daabadf9ee72c4899231551
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425344
Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811314}

Enable safety check and settings utils unittests.

Switch safety check to grouped style.

Switch to mediator unittests instead of view controller.

Remove unneeded call to resetCheckStartItemIfNeeded.

Bug: 1078782
Change-Id: I16a1c188182747634f8af108bcb72f01bbc20985
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435646
Commit-Queue: Sean Harrison <harrisonsean@chromium.org>
Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811313}

This reverts commit b37c27dc.

Reason for revert: the test is failing on many waterfall bots: https://bugs.chromium.org/p/chromium/issues/detail?id=1132945

Original change's description:
> Enable test for persistent overlays
>
> The test has been implemented in [1] and now, when DevTools rolled,
> it can be enabled.
>
> [1]: crrev.com/c/2400478
>
> Bug: 1109224
> Change-Id: I43e4dffbf7d50eae856b5c78290768079094ab69
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435188
> Reviewed-by: Mathias Bynens <mathias@chromium.org>
> Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#811260}

TBR=mathias@chromium.org,alexrudenko@chromium.org

Change-Id: I2b94a3927529be3977c21c960b75d09b7e76ff79
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1109224, 1132945
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435780Reviewed-by: Joey Arhar <jarhar@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811312}

Roll ChromeOS Airmont AFDO profile from 87-4262.0-1600690455-benchmark-87.0.4275.0-r1 to 87-4265.0-1601286022-benchmark-87.0.4275.0-r1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-airmont-chromium
Please CC c-compiler-chrome@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: c-compiler-chrome@google.com
Change-Id: Ifdfe01a95263cce38f7afda9c7168686f1d46225
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435917Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#811311}

static_cast is better suited for downcasting since it can check that the
types are related.

/chrome/browser/ui/ash/launcher
This CL was uploaded by git cl split.

R=skuhne@chromium.org

Change-Id: I4e9943d6a465583be28cb3bf940ad65499ed33e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434774
Auto-Submit: Kevin McNee <mcnee@chromium.org>
Reviewed-by: Stefan Kuhne <skuhne@chromium.org>
Commit-Queue: Stefan Kuhne <skuhne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811310}

This reverts commit 45e2dc4e.

Reason for revert: not the cause of the perf regression

Original change's description:
> Revert "[Sampling profiler] Move ENABLE_ARM_CFI_TABLE to profiler header"
>
> This reverts commit 74826cab.
>
> Reason for revert: testing whether this is responsible for rendering.mobile perf regression
>
> Original change's description:
> > [Sampling profiler] Move ENABLE_ARM_CFI_TABLE to profiler header
> >
> > ENABLE_ARM_CFI_TABLE is in service of the sampling profiler on Android,
> > and is unrelated to any debugging functionality, so move it to a
> > buildflag header under base/profiler.
> >
> > Also add the required includes to the files that use it.
> >
> > Bug: 1129939
> > Change-Id: I884b2128fc2ab2f6f1bec2343c59134448328529
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421443
> > Commit-Queue: Mike Wittman <wittman@chromium.org>
> > Commit-Queue: Lei Zhang <thestig@chromium.org>
> > Auto-Submit: Mike Wittman <wittman@chromium.org>
> > Reviewed-by: Lei Zhang <thestig@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#809167}
>
> TBR=thestig@chromium.org,wittman@chromium.org
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> Bug: 1130974, 1129939
> Change-Id: I00050d0bf8cd7988d0ad8969f0b8a29e8accf669
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432308
> Reviewed-by: Mike Wittman <wittman@chromium.org>
> Commit-Queue: Mike Wittman <wittman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#810801}

TBR=thestig@chromium.org,wittman@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1130974
Bug: 1129939
Change-Id: I3180fd8161b3df701d467d1a028d0e504938dfe1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435778Reviewed-by: Mike Wittman <wittman@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Mike Wittman <wittman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811309}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/685e35de..3860f7c6

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I3897e7c1877287633addafcc4a7d31bd404874dc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435664Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#811308}

static_cast is better suited for downcasting since it can check that the
types are related.

/chrome/browser/paint_preview
This CL was uploaded by git cl split.

R=ckitagawa@chromium.org

Change-Id: If816d7c4d2d7d898688497b0d368d6145eeaaf68
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435998
Auto-Submit: Kevin McNee <mcnee@chromium.org>
Reviewed-by: Calder Kitagawa <ckitagawa@chromium.org>
Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811307}

This reverts commit 8b7817c7.

Reason for revert: assertion failures in the default configuration of webgl_conformance_tests per crbug.com/1132730 .

Original change's description:
> Enable SharedImages for VTVideoDecodeAccelerator
>
> Add a method to media::VideoDecodeAccelerator to indicate whether
> SharedImage-backed picture buffers are supported. Make this return
> true only for the VTVideoDecodeAccelerator.
>
> Add a parameter to media::PictureBufferManager::CreatePictureBuffers
> to indicate if SharedImage-backed PictureBuffers are desired.
>
> Hook the two of these together in the ProvidePictureBuffersAsync
> method of media::VdaVideoDecoder.
>
> Video playback fails with the Metal-based command decoder, because
> it binds IOSurfaces as TEXTURE_2D, not TEXTURE_RECTANGLE. Plumb
> through a flag to specify if TEXTURE_RECTANGLE support is present.
>
> Bug: 1108909
> Change-Id: I1e42aa38e122714517724cee87eb51987645e410
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427545
> Commit-Queue: ccameron <ccameron@chromium.org>
> Reviewed-by: ccameron <ccameron@chromium.org>
> Reviewed-by: Dan Sanders <sandersd@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#811077}

TBR=ccameron@chromium.org,sandersd@chromium.org,jonahr@google.com

Change-Id: I21aa3be7737dc3a2d3d9d0d0cceb4fea2b1fca54
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1108909, 1132730
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435779Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811306}

This typo redirect from M73 is probably no longer needed.
Added in http://crrev.com/c/1534934

Bug: NONE
Change-Id: Ieb81b6750de2258ed2aaca434a43a30c3685dbc0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432142
Auto-Submit: Michael Wasserman <msw@chromium.org>
Commit-Queue: Carlos IL <carlosil@chromium.org>
Reviewed-by: Carlos IL <carlosil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811305}

This change introduces an option to enable query trends in the Omnibox.

Bug: 1122669
Change-Id: I4c5efe7adf2073c7122f65202890a52b4bf58791
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433145Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Tomasz Wiszkowski <ender@google.com>
Cr-Commit-Position: refs/heads/master@{#811304}

Targets in //chrome:* had several unspecified dependencies that were
still linked in by other listed dependencies. The targets linked
correctly, but GN checked failed for these targets. This CL adds all
dependencies explicitly and re-enables GN check for these targets.

Bug: 949535
Change-Id: I9855b68e5616164cddad54c7ac49bd44eecd024c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422347
Commit-Queue: Collin Baker <collinbaker@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811303}

Check the click action of default search engine managed UI in EG test.

Test scenario:
1. Set the DefaultSearchProviderEnabled policy to false.
2. Open settings menu.
3. Click on the info button of search engine item.
4. Check if the enterprise info bubble has popped up.
5. Click outside of the bubble.
6. Check if the enterprise info bubble is hidden.

Bug: 1131052
Change-Id: Iadf059b54d9bc06ef191e6fb99ea393f46d7fecc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425064
Commit-Queue: Tina Wang <tinazwang@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811302}

static_cast is better suited for downcasting since it can check that the
types are related.

/components/cronet
This CL was uploaded by git cl split.

R=ericorth@chromium.org

Change-Id: I4d485c7b43cdc9a755112f093e691f6077b13bdb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435753
Auto-Submit: Kevin McNee <mcnee@chromium.org>
Reviewed-by: Eric Orth <ericorth@chromium.org>
Commit-Queue: Eric Orth <ericorth@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811301}

Confirm Infobars do not have badges, so there is not need to update
the state of the Infobar. Moreover, after
ConfirmInfobarDelegate::Accept() the tab, and therefore the infobar,
is removed.

Bug: 1129762
Change-Id: I79d9c636b1df3e9de19c3f24f20193e9d0c2df88
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432584
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811300}

The builder runs a smaller test suite since crrev.com/c/2422710.
The GCE capacity should be able to hold more traffic.

Bug: 997376, 1127110
Change-Id: I23c9bb5b55aa5f335dea3bdc1817c4793fcf9eb0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429249Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
Commit-Queue: Haiyang Pan <hypan@google.com>
Cr-Commit-Position: refs/heads/master@{#811299}

After the test suites adjustment in crrev.com/c/2427028, the device
usage looks in a good shape and should be able to hold more traffc:
http://shortn/_E2uBVeObl6

Bug: 1111436
Change-Id: I9bfb44a96feb2bc2d49ec8335afc73324711db5c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429931Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Haiyang Pan <hypan@google.com>
Cr-Commit-Position: refs/heads/master@{#811298}

Added support for virtual capture device that can transport
video frames backed by GpuMemoryBuffer.

Bug: 1129531
Test: service_unittests, manual test on Cast device
Change-Id: I045046c403df714996e4c3908d889cecfab22fb6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417105Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Peter Qiu <zqiu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811297}

Bug: 1132059
Change-Id: Ie6a27071d2427f5ce529c0b481138cff8ae66290
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434098Reviewed-by: Emircan Uysaler <emircan@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811296}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/58ceb60bf6b1..5ac564dd6553

2020-09-28 wolfi@chromium.org Fix horizontal scroll/overflow for frame details view

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: chromium:1066415
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I01cb5415333e80dec19be54e795b46c2602dd1ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435498Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#811295}

R=khorimoto@chromium.org

Bug: 1045266
Test: OSSettingsNetworkSummary*
Change-Id: I7829685316e5f9cf52e20296a0d73f66ef5cc2ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432081
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811294}

Roll ChromeOS Silvermont AFDO profile from 87-4258.0-1600689257-benchmark-87.0.4275.0-r1 to 87-4265.0-1601289755-benchmark-87.0.4275.0-r1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-silvermont-chromium
Please CC c-compiler-chrome@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: c-compiler-chrome@google.com
Change-Id: I3f1a9de8d4e7066a565821bfd708778e9a9e835a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435913Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#811293}

This change moves the two frequently used interfaces to a shared
Omnibox suggestions namespace.

Bug: 1106109
Change-Id: Ida2aa4f3ea2f961b5ab901df62e570fa4402122b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433053Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Tomasz Wiszkowski <ender@google.com>
Cr-Commit-Position: refs/heads/master@{#811292}

This patch adds support for logical styles in animations created via
element.animate(). Previously, CSSPropertyValueSets were kept for
shorthand properties for the sole purpose of serialization of the
shorthand property values in getKeyframes. These sets now hold
additional usage for reevaluation as needed to resolve naming conflicts
or applying updates after a change to the text direction or writing
mode. An optimistic strategy is used during the initial parse to
minimize computational overhead. A second pass of the property name
expansion is only applied when needed.

During style update, a change in text direction or writing mode will
trigger an update to all running animations. CSS animations and
transitions are affected only if modified by a setKeyframes call.
Keyframes without logical properties are also uneffected. Any keyframe
model with one or more affected keyframes is automatically invalidated
and resampled.

Bug: 865579
Change-Id: Ia2a34b465fadbb8c8f81aeefa72ea38d52fd97d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425167
Commit-Queue: Kevin Ellis <kevers@chromium.org>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811291}

This change creates AffiliationFetcherBase which derives from AffiliationFetcherInterface. This is a base class for existing AffiliationFetcher, which allows a derived class to implement the request part of the fetcher. The response part stays the same.

Bug: 1108279
Change-Id: Ia54a4d88f6684c0c95345b6c26eb5132d1ec6233
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404843Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: Nela Kaczmarek <nelakaczmarek@google.com>
Cr-Commit-Position: refs/heads/master@{#811290}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/79c5fa7eebcb..8b16441c661b

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC gayane@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: gayane@google.com
Change-Id: I5381376db49143743769f34364da613347253c25
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435494Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#811289}

The crash described in the issue 1132762 was caused by our rencet change
in r811115, to ensure the trailing_collapsible_space_ structure is reset
when the associated item_result changed.

However, there was an error in the condition, so that we should ensure
we only call the 'reset()' function when the Optional has value.

Bug: 1132762, 1132811
Change-Id: I73d10c309162649e143cd66ff7702c4ac7e5eed2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435388
Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811288}

For some edgecases, i.e. Chromeboxes, there is an ethernet section shown
with "No network". Show a search result for Ethernet that links to
the Network Section.

Fixed: 1096768
Test: Remove the lines as seen in Patchset 2 (test setup) and run on Linux CrOS emulator..
Change-Id: I0dd06b1fd77129499ad11b732dffedb5c28d2f00
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429258
Commit-Queue: Daniel Classon <dclasson@google.com>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811287}

There are some build hacks that compile ozone/wayland into the stock
chromeos build. Those hacks caused the original CL to pass GN check
for the CQ linux, chromeos and lacros bots, but fail gn check on the
on chromeos code search bot.

I'm trying to remove the hacks with crrev.com/c/2432137 but it may
take some time to validate and get reviewed.

For now, add nogncheck to the include. I've verified locally that the
codesearch config builds correctly and passes gn check.

Original CL description:
The ID prefix is shared between the Wayland client code in Lacros and
the Wayland server code in ash, so share the constant.

Bug: 1095360
Change-Id: Ied9c879e3aef8224e1d6c5f871a42cfe0745e614
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427546Reviewed-by: Antonio Gomes (GMT-4) <tonikitoo@igalia.com>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#810277}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433024
Cr-Commit-Position: refs/heads/master@{#811286}

Adds strings to ash/ash_strings.grd and uses them in the
NearbyShareVisibilityFeaturePodController.

Change-Id: I112c8a413bb8deffc038e9272ecbebd7f53ddc99
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401842
Commit-Queue: Curt Clemens <cclem@google.com>
Reviewed-by: James Vecore <vecore@google.com>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811285}

This CL sets line height of the bottom sheet subtitle and incognito
message to 20sp, according to UI mock and chrome UI spec on Android.

Screenshots: https://crbug.com/1132215/#c4
Bug: 1132215
Change-Id: I7f632f2d8906a8cdbf4e4b1965a667ef38d35860
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435187
Commit-Queue: Alice Wang <aliceywang@chromium.org>
Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811284}

Bug: 1132904
Change-Id: If39e460248f4358002f1d05c76a32a24d3a0d154
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435747Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Tommy Steimel <steimel@chromium.org>
Commit-Queue: Jazz Xu <jazzhsu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811283}

* Change title and body text alignment to left.
* Change font size to
  - with title: title 18pt, body 13pt, button 13pt
  - w/o title: body 14pt, button 13pt

This change will apply to all IPH bubbles, i.e. both
snooze and non-snooze bubbles.

spec: go/desktop-iph-snooze-ux-spec

Bug: 1121399
Change-Id: Idee04707d42d57b9f65cb99b36a29fa19a99318b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425194Reviewed-by: Collin Baker <collinbaker@chromium.org>
Commit-Queue: Keren Zhu <kerenzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811282}

Change description:
-------------------
This CL changes the intensive wake up throttling policy so that it does
not affect the execution of timers with nesting level < 5 :

  In a Window whose top Window has been hidden for 5 minutes and which
  is not opted out from intensive wake up throttling, a timer task can
  run:

  - on a 1-second aligned wake up if:
      - the task's nesting level is < 5, or,
      - the Window is same-origin with the top Window and at least
        1 minute has elapsed since the last timer with nesting level
        >= 5 has run in any Window in the tree that is same-origin with
        the top Window

  - on a 1-minute aligned wake up, otherwise.

Rationale:
----------
Unfortunately, limiting all timers to 1 wake up per minute caused
breakages on some sites. After reaching out to site owners, we
established that opting out timer tasks with nesting level < 5 prevents
these breakages. Local tests suggest that most timers tasks have a
nesting level >= 5. Therefore, we don't expect that this policy change
will have a significant impact on power usage.

Timers with nesting level >= 5 can run on a 1-second aligned wake up
if there hasn't been a wake up in the last minute, because we don't
want to penalize pages that have their own logic to ensure that the wake
up rate is below 1 per minute. For example, a repeating timer with a
90 seconds timeout should not be affected by intensive throttling.

Discussion:
-----------
https://groups.google.com/a/chromium.org/g/scheduler-dev/c/EWKYCZlWjpc

Bug: 1075553
Change-Id: I90d553608b9e3e64a9e6456112d5f4454d51bf1d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417293Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811281}