GitLab

When tapping the complete notification, Chrome should re-use the tab that
originally contained the dino page, unless the tab's URL changed.

To explain what this change does and why this change is necessary, let's assume
this redirect chain:

foo.com -> bar.com -> baz.com

When rendering the offline page, we attempt to load foo.com, and end up loading
the full redirect chain. Depending on the cache headers, it's possible that
only the first redirect is cached. So if we attempt to set a tab's URL to
foo.com later, we can end up at bar.com. If we're offline, we will reach another
dino page. If we're online, we'll end up at baz.com, but not the offlined page.

Instead, to load the offlined page, we navigate to baz.com. The problem is that
the old tab's URL is still 'foo.com', so the intent handler doesn't let us
re-use the tab, and instead creates a new tab.

This change introduces a new extra for the intent to pass along 'foo.com' so
that the intent handler can determine whether or not the tab's URL has changed.

Bug: 939850
Change-Id: I3b97113da944fa215f2a04434d21ccaf6fc9de4c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547943
Commit-Queue: Dan H <harringtond@chromium.org>
Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#656418}

This reverts commit e3d0f13d.

Original change description:

Adds plumbing so that window event changes will notify the
autoclick controller to update the menu's bounds if needed. This
allows the menu, like the PIP menu, to re-position itself so as
not to overlap system menus and dialogs.

Bug: 943703
Change-Id: I80f79fb093948a2585a64f849d50759640476d2a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1593454Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#656417}

As per the latest spec change we need to use
pointerrawupdate instead of pointerrawmove.

TBR=foolip@chromium.org

Change-Id: If18d28ccfd326a3550bd7d0e5ebffd5e96def782
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584405Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#656416}

This CL is intended to be a no-op logic wise (aside from merging
DoWork()/DoDelayedWork() into a single call).

As a follow-up, it might be possible to take better advantage of
NextWorkInfo::recent_now but it wasn't trivial to do so in this pump
since the sleep is not invoked directly from Run() but rather implicit
from HandlePrepare(). We could also potentially reuse |recent_now|
between HandlePrepare() and HandleCheck(). For now we stick to invoking
TimeTicks::Now() as much as the previous impl did.

Bug: 885371
Change-Id: I4f9d6642c44dbad82cb3588cf3f5323ddf9c19ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594695
Commit-Queue: Gabriel Charette <gab@chromium.org>
Commit-Queue: Mark Mentovai <mark@chromium.org>
Auto-Submit: Gabriel Charette <gab@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#656415}

This code should be unnecessary after moving from UIWebView to WKWebView.

Bug: 617560
Change-Id: I5079874bfb850333872d4336ea6b9195b78d480b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1593978
Auto-Submit: Eugene But <eugenebut@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#656414}

This CL is adding unittests for the GetFallbackFont on Windows.
It's fixing GetUniscribeFallbackFont which was failing on multiple
added tests.

The ShapeRuns (ui/gfx/render_text_harfbuzz.h) function applies fonts on runs
in a specific order. The FallbackFont is a fastpath to determine a font based
on a sequence of characters. If this is failing, the FallbackFonts returns
the list of fonts in that family.

FallbackFont on windows 7 is using the Uniscribe API and on windows 10 it's
using the DWrite API. We are exposing the Uniscribe API to allow better
unittests.

GetUniscribeFallbackFont is determining the fallback fonts by parsing the
uniscribe commands generated in a metafile. The previous code was assuming
the fallback font is the first font to be set. By looking to failing cases
we realized that multiple fonts may be selected and some spacing may be
produced into the metafile. A state machine is now assuming the fallback
font is the font used when the requested text is produced.

We are adding tests for script that are currently working. A CL will follow
with fixes for broken scripts. They are working in Chrome because the
FallbackFonts is able to return the full list of fonts.

BUG: 944227

Change-Id: I272a877d82fa031eff9e129e9cd4af915c756e89
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549882
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#656413}

Tbr: wfh@chromium.org
Bug: 959223
Change-Id: I935873e5ae1ed2c86288f0cce3dcc5d2f81b58b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594653
Commit-Queue: John Budorick <jbudorick@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#656412}

This is a reland of ca80dfd9.
Update layout test expectations for Mac.

Original change's description:

> [Dark Web Contents]: Implement color inversion using CIELAB.
>
> To invert color:
> 1. Tranform color to CIELab.
> 2. Invert the L and add 10.
> 3. Transform back to RGB.
>
> Bug: 939312
> Change-Id: Iadeec2232afbe35cb189f0a36722392514db4781
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547830
> Commit-Queue: Anna Malova <amalova@chromium.org>
> Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org>
> Reviewed-by: Stephen Chenney <schenney@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#656195}

Bug: 959104
Change-Id: Ic776983f2cb2a2d9b6b53d116bf122db174b26c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594579Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Anna Malova <amalova@chromium.org>
Cr-Commit-Position: refs/heads/master@{#656411}

Bug: 958841
Change-Id: If9cd5570d6d1b6ceb34b9b34310ef11052b39757
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1593979
Commit-Queue: Eric Roman <eroman@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#656410}

This CL changes the CookiesWithoutSameSiteMustBeSecure flag's behavior.
Previously, a SameSite=None cookie set without Secure, would be treated
as Secure if set from a secure context, or rejected if set from an
insecure context. This CL changes that to always reject such a cookie
regardless of source scheme.

Bug: 954551
Change-Id: Ie035ebc97425f855665b81419ac717173e2dcba5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594693
Commit-Queue: Lily Chen <chlily@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#656409}

Bug: 959076
Change-Id: I5e9c7e34c016f6496d34db2b8e669653f50860c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594113Reviewed-by: Lucas Tenório <ltenorio@chromium.org>
Commit-Queue: Bruno Santos <brunoad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#656408}

SkiaOutputDeviceOffscreen is not using the color space that is passed
in.

Bug: 957040
Change-Id: I51bfa5c8ee890abe960d0059ec71c54823abb252
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1586345Reviewed-by: Jonathan Backer <backer@chromium.org>
Commit-Queue: weiliangc <weiliangc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#656407}

This is a reland of a283f958

Original change's description:
> [Native File System] FileSystemWriter::write takes non-stream data only
>
> The implementation of `write` before this CL accepted a Blob or a
> ReadableStream.
>
> This change limits `write` to byte-array-like data, the stream-semantics
> to be implemented in another dedicated API.
>
> Bug: 955190
> Change-Id: Icdec561a706bb18fc2b56bd3304b9e8346923fcc
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1589671
> Auto-Submit: Olivier Yiptong <oyiptong@chromium.org>
> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
> Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#656209}

Bug: 955190
Change-Id: I67e488f3b0dddf09ca1b31a34e15b6e4e185d0b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594154Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Olivier Yiptong <oyiptong@chromium.org>
Cr-Commit-Position: refs/heads/master@{#656406}

This function is reverted from pointerevent_support.js file, but the
tests that use it are still in the wpt repository.

Bug: 606367

TBR=nzolghadr@chromium.org

Change-Id: Ifd97bab0bf411b000573056152a563f4385f2500
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594735Reviewed-by: Lan Wei <lanwei@chromium.org>
Commit-Queue: Lan Wei <lanwei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#656405}

I previously changed the scroll into view behavior to edge-aligned, with
the idea that we don't want to scroll to the middle of a long text
range, but this results in the scroll position being at the bottom of
the page for shorter text ranges. This patch reverts to centering the
text range, but specifically the top of the text range to handle the
case of long ranges.

Also changes the text highlight color to light yellow instead of orange
as recommended.

Bug: 958545 958544
Change-Id: I8d35d916acec0199db2a33a6d05089311129d66d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592399
Commit-Queue: Nick Burris <nburris@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#656404}

Previously, cleanup timer (schedules cache cleanups for soonest TTL)
would keep running after MDnsClientImpl::Core destruction but it used
unretained references to the destroyed Core. Now it's always stopped on
Core destruction.

Also cleaned up MDnsClientImpl to ensure time is destroyed after Core to
ensure the new Stop() call is always safe. Reordered fields and added a
StopListening() call in the destructor.

Bug: 958307
Change-Id: I6d3063e7f6a6ad49991ae41cbcab4739d81c5da8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1593841
Auto-Submit: Eric Orth <ericorth@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#656403}

Add the page language as user data on the last committed navigation entry.
Then, make SyncSessionsRouterTabHelper listen to OnLanguageDetermined.
That way, it knows when to notify that the tab's sync data has been modified.

Bug: 957657
Change-Id: Iacde546d789d325d6700be4acaaa15dc5eef7076
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504131
Commit-Queue: Alexandre Frechette <frechette@chromium.org>
Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#656402}

This CL adds functionality to OverlayPresenter to drive the
presentation of overlay UI.

It also updates the presenter to observe its WebStateList
and OverlayRequestQueueImpls for the lifetime of the object,
rather than only when a UI delegate is provided.
ShowNextOverlay() no-ops without a UI delegate, and is already
called in scenarios where an overlay may not be shown.

Bug: 941745
Change-Id: Ib8fe7b49bfba3d8624c5acf40f7e0f512d6cd0ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1586776
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#656401}

The parts of a composited scrollbar (like the thumb, buttons etc) were
expressed as being relative to the origin of the owner scroll layer.
This will cause hit testing for the div scrollbars to fail (except
when the div is absolutely positioned at 0,0). To fix this, we need to
tranform the following coordinates and make them relative to the
scrollbar layer's origin:
a) The pointer coordinates before hit testing (in ScrollbarController)
b) The back,forward,track rect getters in ScrollbarLayerDelegate

Bug: 952314
Change-Id: Ib42ed4df80e30a5c0dc983bc003fb21fb6a42df2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585017
Commit-Queue: Rahul Arakeri <arakeri@microsoft.com>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#656400}

Define 'invalid' as a new property in class Combobox.

TBR=pkasting@chromium.org
BUG=957271

Change-Id: Ib8035aebb363396789b32bd7e3bfccb35fb52f6e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1589145
Commit-Queue: Wei Li <weili@chromium.org>
Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#656399}

- When input state update is requested, skip the update if the timeline is inactive.
- If composited animation is initialized with inactive timeline, call the animator only when the
  timeline becomes active. Disabled the following tests, where the animator is called with
  initially inactive timeline. These tests will be fixed as part of https://crbug.com/937456.

  virtual/threaded/animations/animationworklet/scroll-timeline-non-compositable.html
  virtual/disable-blink-gen-property-trees/animations/animationworklet/scroll-timeline-non-compositable.html
  virtual/disable-blink-gen-property-trees/animations/animationworklet/scroll-timeline-non-scrollable.html
  virtual/threaded/animations/animationworklet/scroll-timeline-non-scrollable.html

Bug: 906050
Change-Id: I3ab9cc41b901103c37d4fb6f7f701c0aef142827
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1535135
Commit-Queue: Olga Gerchikov <gerchiko@microsoft.com>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#656398}

Bug: 958999
Change-Id: Iba957d6e0fc59edd0b5bd5183c59655e8dde5cc8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592690Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#656397}

https://w3c.github.io/IndexedDB/#dom-idbcursor-request

Chrome status:
https://chromestatus.com/feature/5432744081358848

Intent to Implement and Ship:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/o6mUiI09BUc/25khjTHYAAAJ

Bug: 943344
Change-Id: I9c7c801ae266c0dd75cd9bc21355913865ecbcc8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585892
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#656396}

This CL moves logic which can be shared with TWAs from SameActivityWebappSplashDelegate
to SplashController. The following logic is moved:
- tracing
- hide animation code

BUG=817263

Change-Id: I21fce0d2eae964d9499f72a89e3d8e7d3d4ab6d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592829Reviewed-by: Dominick Ng <dominickn@chromium.org>
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#656395}

Bug: 945282
Change-Id: I08c4e6c4d263fb3cd6dc431320e7cd2c3f56b692
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1588647
Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Pavel Shmakov <pshmakov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#656394}

More fixes for getting the histograms from the right place.

Also did a good amount of clean up and robustness fixes for things that
came up in local testing

Bug: 959043
Change-Id: I4e83051d39de15c6a67555ed25fc8dec5923b8e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594794Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Cr-Commit-Position: refs/heads/master@{#656393}

system_health.common_desktop/browse:social:tumblr_infinite_scroll:2018
is failing consistently on Win7. Disabling it.

TBR=crouleau@chromium.org
NOTRY=true

Bug: 958422
Change-Id: Id2ab551bb91a3819fb15f7444ec81f99e03fda55
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594801Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#656392}

It's no longer used. Clean it up.

Bug: None
Change-Id: I845bef3903af5ff4f765bb2878f2bbc9ea8c5334
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592691Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#656391}

/FORCE:MultipleRes makes duplicate resources emit a warning instead of
an error, but /WX converts all warnings into errors.

TBR=hans

Bug: 958955
Change-Id: I0764edbcd9f13f7412e160075985ce611675dc4c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594701
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#656390}

Uses portal/portalHost.postMessage instead of broadcast channels in the
following tests:

- portals-cross-origin-load.html
- portals-host-exposure.html
- portals-rendering.html

Change-Id: I1c2a74f07d3566d7046e48d2355508c5f0e6149e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1591876Reviewed-by: Lucas Gadani <lfg@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#656389}

This is failing because assertPreviewShownViaHistogram needs to check
browser histograms.
Also cleaned up the test while I was at it.

Bug: 959036
Change-Id: Ie634d8be4268b73661f3e06ffc496d399d3ad1d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1593508
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#656388}

Rename Diagnosticsd mojo and D-Bus interfaces to WilcoDtcSupportd.

Since the renamed code is meant only for wilco_dtc_supportd usage and
is not used for pure diagnostics purposes, the name is confusing.

It is a final CL for the wilco_dtc_supportd rename.

BUG=b:124423615
TEST=build,unit_tests

Change-Id: I2447d6db96eea8c0e54be399aae7c0b178adfdd2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565984
Commit-Queue: Polina Bondarenko <pbond@chromium.org>
Reviewed-by: Mattias Nissler <mnissler@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Auto-Submit: Polina Bondarenko <pbond@chromium.org>
Cr-Commit-Position: refs/heads/master@{#656387}

This removes the implementation of the mojom::AXHost interface and the
interface itself.

TBR=rmrossi@chromium.org

Bug: 958187
Change-Id: I68f9eec4e7004a623579f90bf22bdc7e7e9473f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592847Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: David Tseng <dtseng@chromium.org>
Auto-Submit: James Cook <jamescook@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#656386}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/9a23d151..8b263bbf

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Iecf8e47c6587ab6bc99ade346fa07739256b83d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592386Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#656385}

Bug: 951492
Change-Id: Ie993974ea7bb5779bf396921a3931020d90e7f53
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1564554
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Bill Orr <billorr@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#656384}

Add SimpleLinkedHashMap and its platform impl's. Deprecate net::linked_hash_map and replace it with the new class.

R=rch@chromium.org

Change-Id: I326fbe373d9e036c2c7cd30dd378f44e5055ef21
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1590616Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Dan Zhang <danzh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#656383}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/a5d3e861c684..29afe3e4c351


git log a5d3e861c684..29afe3e4c351 --date=short --no-merges --format='%ad %ae %s'
2019-05-03 saklein@chromium.org chroot_lib: New class to begin handling chroot logic
2019-05-03 mikenichols@chromium.org upload_symbols: Refactor error handling for duplicates


Created with:
  gclient setdep -r src/third_party/chromite@29afe3e4c351

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@chromium.org

Change-Id: I5cde2dcf6a2f00b6e4040dcc99b9648d5adfe583
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594098Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#656382}

A lot of new boards and Cr50 versions have been released since these
enums were introduced.

The intergers reported by UMA were converted to 4 byte ASCII and
looked up in the RLZ database.

All released Cr50 versions were taken through the same hash generating
process used before.

BUG=none
TEST=none

Change-Id: I9a756c766301b6662cc04ab59b87e973dad29831
Signed-off-by: Vadim Bendebury <vbendeb@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592346Reviewed-by: Alex Ilin <alexilin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#656381}

So far the linked bug has resisted reproduction outside of the bots;
unconditionally log more state to help debug.

Bug: 922068
Change-Id: Ia2d93a1cfc03c1ea2fb1055d3b9cfea764a85217
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592682
Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: David Benjamin <davidben@chromium.org>
Reviewed-by: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/master@{#656380}

On a 32 bit machine, an extra large chunk length can result in overflow
when added to other small numbers. Check for that overflow in
Parse/ParseSize and mark the decoder as failed if it occurs. DCHECK
that the length is valid in Decode methods, since it has already been
checked by Parse.

In ParseSize, check for length > PNG_UINT_31_MAX. This matches Parse,
and the PNG spec (https://www.w3.org/TR/PNG/), which demands that all
four byte integers are <= PNG_UINT_31_MAX.

Bug: 954983
Change-Id: I86d92c2ce1db54b2326188d41d378f3c172bf67c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1588943Reviewed-by: Noel Gordon <noel@chromium.org>
Reviewed-by: Madeleine Barowsky <mbarowsky@chromium.org>
Commit-Queue: Leon Scroggins <scroggo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#656379}