- 24 Oct, 2018 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/38b827049c96..7b6a59fda6b6 git log 38b827049c96..7b6a59fda6b6 --date=short --no-merges --format='%ad %ae %s' 2018-10-24 perezju@chromium.org [soundwave] Move ListTestPaths to services.dashboard Created with: gclient setdep -r src/third_party/catapult@7b6a59fda6b6 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:890691 TBR=sullivan@chromium.org Change-Id: I5a3be93243967dd0c9429b07cfeee80e790afbb1 Reviewed-on: https://chromium-review.googlesource.com/c/1297343Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#602320}
-
Alex Clarke authored
The task scheduler is usable before native is loaded although only a subset the full native task prioritisation will be available. After native libraries are loaded, all remaining tasks will be migrated to native queues. Design Doc: https://docs.google.com/document/d/1ZRXRypVluu7YvnB9MC73J3Z9NTsYDDxkhUDK4O-siJg/edit?ts=5bb5f398#heading=h.8n30tv8r1tun And https://docs.google.com/document/d/1z1BDq9vzcEpkhN9LSPF5XMnZ0kLJ8mWWkNAi4OI7cos/edit#heading=h.7nki9mck5t64 Bug: 863341, 872372 Change-Id: I1c71a670662065d1d84cb23493f4cde53db9ae7c Reviewed-on: https://chromium-review.googlesource.com/c/1268021 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#602319}
-
Marc Treib authored
TBR=wangxianzhu@chromium.org Bug: 898485 Change-Id: Ib0adea0db6371d32aaab5e8714246efaaca15ed4 Reviewed-on: https://chromium-review.googlesource.com/c/1297428Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#602318}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a6bda76c..96e1e621 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I1eb7d9692ea4eb8b5259d8ed146516f034fe04e4 Reviewed-on: https://chromium-review.googlesource.com/c/1297741Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#602317}
-
Gauthier Ambard authored
This CL creates the SettingsSwitchItem, replacing the old item for the collection view. Bug: 894791 Change-Id: Ie78e6bf3f5d358ae41a4d2bf407a2cadf7252d96 Reviewed-on: https://chromium-review.googlesource.com/c/1296597 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#602316}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/70bd0b72f3f8..b11ab578ad63 git log 70bd0b72f3f8..b11ab578ad63 --date=short --no-merges --format='%ad %ae %s' 2018-10-24 mtklein@google.com remove src/jumper Created with: gclient setdep -r src/third_party/skia@b11ab578ad63 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=brianosman@chromium.org Change-Id: Ia686967b0e0282980e8ddfdf31247c63ad07ee15 Reviewed-on: https://chromium-review.googlesource.com/c/1297338Reviewed-by:
-
Marc Treib authored
This reverts commit 0c3cbcc1. Reason for revert: Looks like this was a false positive; the test has failed again after the revert. Original change's description: > Revert "[CI] Combine GetBackgroundPaintLocation of PaintLayer and LayoutBoxModelObject" > > This reverts commit af460e9a. > > Reason for revert: > Seems to have broken paint/invalidation/table/cached-69296.html from webkit_layout_tests on Mac 10.11 - currently failed 7/7 times after this landed: > https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.11%20Tests > First failing build: > https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.11%20Tests/30030 > > Original change's description: > > [CI] Combine GetBackgroundPaintLocation of PaintLayer and LayoutBoxModelObject > > > > For fixing SlimmingPaintV2 scrolling background painting and > > invalidation, we need a single place to get the accurate value > > of the background paint location. > > > > Bug: 732611 > > > > Change-Id: I0ad696395d73c9c19078e13e9a32cf9dbd0c628f > > Reviewed-on: https://chromium-review.googlesource.com/c/1297586 > > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > > Reviewed-by: Robert Flack <flackr@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#602250} > > TBR=flackr@chromium.org,wangxianzhu@chromium.org > > Change-Id: I279520fc9deafd9891dd3a5457e42d6fa0b201aa > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 732611 > Reviewed-on: https://chromium-review.googlesource.com/c/1297362 > Reviewed-by: Marc Treib <treib@chromium.org> > Commit-Queue: Marc Treib <treib@chromium.org> > Cr-Commit-Position: refs/heads/master@{#602289} TBR=flackr@chromium.org,wangxianzhu@chromium.org,treib@chromium.org Change-Id: Ic728b318732d88d37686c938f32ed3a27ee95588 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 732611 Reviewed-on: https://chromium-review.googlesource.com/c/1297142Reviewed-by:
-
Gauthier Ambard authored
When the app is launched after a cold start, the size of the collection view is 0, even if the size of the wrapper view isn't 0. This CL fixes it by setting the frame of the collectionView if it is 0. This only seems to happen when the NTP is contained in a native view. Bug: 896234 Change-Id: I4309bf35c0a3d82e2a5c6c78265f8293ff65a43c Reviewed-on: https://chromium-review.googlesource.com/c/1297360Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#602313}
-
Jordan Demeulenaere authored
Before this patch, we were instantiating a date using the java.util.Date constructor, which is deprecated and required us to decrement the year by 1900. This patch is using the recommended Calendar class instead. Bug: 806868 Change-Id: Id723c3ee8a1abc602f179c0924782c17d123c06b Reviewed-on: https://chromium-review.googlesource.com/c/1297136 Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#602312}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/624fe7f9b061..fbcd8762f2cc Created with: gclient setdep -r src-internal@fbcd8762f2cc The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I34486037af806a9f843b0e89433f606abba55ab7 Reviewed-on: https://chromium-review.googlesource.com/c/1297339Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#602311}
-
Leszek Swirski authored
This reverts commit dd9df78c. Reason for revert: Makes VR tests flaky (https://crbug.com/894796) Original change's description: > Reland "[blink] Control ScriptStreamer with ScriptResource" > > This is a reland of 7bd91635 > > No changes from the original, revert reason is fixed with > https://chromium-review.googlesource.com/c/1283037 > > Original change's description: > > [blink] Control ScriptStreamer with ScriptResource > > > > Move the ScriptStreamer control logic from ClassicPendingScript to > > ScriptResource. In the future, this will allow us to start streaming > > a ScriptResource before the ClassicPendingScript is available, e.g on > > preload. > > > > The ClassicPendingScript now only sends one "finished" callback, from > > ScriptResource. This callback is either when the streaming completes, > > or when there is no streaming and the ClassicPendingScript has told > > the ScriptResource that it doesn't intend to start streaming. In the > > long run, we want all scripts to go through the streaming interface, > > and we want ScriptResource to control when streaming starts, so the > > "no more streaming" call will disappear -- however it is necessary to > > maintain the current behaviour, and be able to control it with a > > runtime flag. > > > > Bug: chromium:865098 > > Change-Id: I2c4cc16635a6538b7ff24a24463fe6f34efd8a2e > > Reviewed-on: https://chromium-review.googlesource.com/c/1181430 > > Commit-Queue: Leszek Swirski <leszeks@chromium.org> > > Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org> > > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > > Reviewed-by: Kouhei Ueno <kouhei@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#599148} > > TBR=kouhei@chromium.org,kinuko@chromium.org > > Bug: chromium:865098 > Change-Id: I0df324ef8e284f4d3d55a1721d71be5a66a3285c > Reviewed-on: https://chromium-review.googlesource.com/c/1286450 > Commit-Queue: Leszek Swirski <leszeks@chromium.org> > Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org> > Cr-Commit-Position: refs/heads/master@{#601143} TBR=kinuko@chromium.org,rmcilroy@chromium.org,haraken@chromium.org,hiroshige@chromium.org,kouhei@chromium.org,vogelheim@chromium.org,leszeks@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:865098 Change-Id: Ibdbd7e80d0fcfacc84a73e83d165581c7f1d02d2 Reviewed-on: https://chromium-review.googlesource.com/c/1297138 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#602310}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/700b4a4e65c2..e068ad62628f git log 700b4a4e65c2..e068ad62628f --date=short --no-merges --format='%ad %ae %s' 2018-10-24 jonasolsson@webrtc.org Use a sufficiently large bitmask. 2018-10-24 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 5e500373..869181c2 (602066:602275) 2018-10-24 kron@webrtc.org Increase the UDP receive buffer for video 2018-10-24 peah@webrtc.org APM: Correct includes required for the data dumping functionality Created with: gclient setdep -r src/third_party/webrtc@e068ad62628f The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:898373,chromium:None,chromium:b/115713113 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ic8bbee1f85f9c0855a438de32e18e7bdd45df687 Reviewed-on: https://chromium-review.googlesource.com/c/1297337Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/a1e7b1c440e1..78f4835a7135 git log a1e7b1c440e1..78f4835a7135 --date=short --no-merges --format='%ad %ae %s' 2018-10-24 hjd@google.com Merge "protozero: Update hash unittest" 2018-10-24 hjd@google.com Merge "traced_probes: Common pids trigger process scanning" Created with: gclient setdep -r src/third_party/perfetto@78f4835a7135 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I7cca52e2dee3490988d5296135f8c15d6a6c92a8 Reviewed-on: https://chromium-review.googlesource.com/c/1297336Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/685b5de1133a..38b827049c96 git log 685b5de1133a..38b827049c96 --date=short --no-merges --format='%ad %ae %s' 2018-10-24 titovartem@chromium.org Add support for metric abbreviation for physics units. Created with: gclient setdep -r src/third_party/catapult@38b827049c96 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Ib0f2c9baeacba4fcbb2064a7d36bef5b9b8a9a15 Reviewed-on: https://chromium-review.googlesource.com/c/1297334Reviewed-by:
-
Christian Dullweber authored
Dynamically update the cookie notice on the advanced tab when sync state changes. Bug: 894848 Change-Id: I62d507d41a1bd91d37738f2d68d00427bd2bb386 Reviewed-on: https://chromium-review.googlesource.com/c/1293451Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#602306}
-
yoshiki iguchi authored
Previously, the swipe controls are closed before the button click is processed. This CL moves the code to close them after the button click handlers. Also this CL removes the unnecessary CloseSwipeControl(s), because we had some redundant calls. Bug: 897653 Test: manual Change-Id: I2dd728c7e2069278c5f7a09ea66c79e31e28ab59 Reviewed-on: https://chromium-review.googlesource.com/c/1295756Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#602305}
-
Morten Stenshorne authored
We only need break tokens when doing block fragmentation. Long-term, even when we do have block fragmentation, we might not need to create break tokens when we're finished with a node, but that will require some more work, in any case. We currently use break tokens to figure out how much block space has been used in total by all previous fragments generated for a node, for instance. We now have to stop cheating in the paged overflow layout algorithm. If height was auto, we used to just disable block fragmentation, but since block fragmentation is what now triggers creation of break tokens, and we still have a flow thread to feed, we need to always enable block fragmentation for paged overflow (this is the correct solution long-term, anyway). We'll now fail all tests that have paged overflow and auto height, but only when LayoutNGBlockFragmentation is enabled, so no big deal. This should give both performance improvements and memory usage reduction. Some tests started to pass and some started to fail. Three new failures: Two of them are an obvious result of no longer supporting auto-height paged overflow containers. The last one (wpt/css/css-multicol/filter-with-abspos.html for the LayoutNGBlockFragmentation virtual test suite) I'm not quite sure about, but it probably has something to do with us no longer creating break tokens where we previously used to do it, and that upsets someone. Nothing to worry about for now, since it only affects NG block fragmentation, which isn't shipping in this phase. Some new tests also start to pass. Didn't do a thorough analysis, but we now only create break tokens from fragments generated by NGBlockLayoutAlgorithm, so e.g. nodes laid out by the legacy engine and nested column algorithms will no longer create break tokens. Which apparently is a good thing in some cases. Or it could be bugs canceling out other bugs. Anyway, since all the tests in question are also only for the LayoutNGBlockFragmentation virtual test suite, we don't have to worry about it yet. Finally, one unit test had to be updated, because orthogonal flow roots disable block fragmentation, and that suddenly means that there'll be no break tokens generated. Change-Id: Ief3d354e7ae0741ee239f530811ac9d9b3576ce3 Reviewed-on: https://chromium-review.googlesource.com/c/1296535Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#602304}
-
Nico Weber authored
This is a reland of 538e9529 It was reverted at https://chromium-review.googlesource.com/c/1297139 but the problem has already been fixed in https://chromium-review.googlesource.com/c/1297262. Original change's description: > Move 'Windows deterministic' from FYI to the main waterfall. > > Bug: 897980,330260 > Change-Id: I71bb304c6398484d5af5a981fdbc09314d69dd22 > Reviewed-on: https://chromium-review.googlesource.com/c/1295272 > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Commit-Queue: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#602198} TBR=thakis@chromium.org,dpranke@chromium.org,martiniss@chromium.org No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 897980, 330260 Change-Id: I03a1784ea48bcaa6567d4ec2dd482d218d0f4740 Reviewed-on: https://chromium-review.googlesource.com/c/1297426Reviewed-by:
-
Vivek Galatage authored
Post rename, there are certain links within README.md file which are pointing to the old directory structure. Correct these links to point to the correct ones! REVIEWER=mstensho@chromium.org R=mstensho@chromium.org Signed-off-by:
Vivek Galatage <vivekg@chromium.org> Change-Id: Ib1148cb4339823081ef96f2e24a87f2f21f57c15 Reviewed-on: https://chromium-review.googlesource.com/c/1293431Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#602302}
-
yoshiki iguchi authored
This method is declared in the header but not defined anywhere. Bug: none Test: build passes Change-Id: I6db055a785a549d1b1f24b5cb5b22400937ca241 Reviewed-on: https://chromium-review.googlesource.com/c/1295749Reviewed-by:
-
Mikel Astiz authored
DataTypeManager is allowed to call Stop() while a datatype is NOT_RUNNING or FAILED. In both cases, the function should be a no-op, but the completion callback should be called. Prior to this patch, the completion callback would NOT be run and hence future sync reconfigurations may never complete, leading to weird behavior including UI implications (missing updates), UMA metric biases (error-related scenarios may be underrepresented) and issues related custom passphrase encryption (which may never start or never complete, observed in tests and the reason why this bug got surfaced). Bug: 898453,870624 Change-Id: I47a9c04ab34ac48e0fdf000df2acb70bbf3e4446 Reviewed-on: https://chromium-review.googlesource.com/c/1297419Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#602300}
-
Mustaq Ahmed authored
Bug: 897829 Change-Id: Id1ab2eb8c4bc76c1de959e8f229a8a3298bcbc78 TBR: rkaplow@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1297000 Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#602299}
-
Oskar Sundbom authored
Only the default constructor used to do this. Bug: 895501 Change-Id: Ic68a82348d014be7fcffcce891d8571029922808 Reviewed-on: https://chromium-review.googlesource.com/c/1293912 Commit-Queue: Oskar Sundbom <ossu@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#602298}
-
Marc Treib authored
This reverts commit 538e9529. Reason for revert: "Windows deterministic" has been consistently failing on the main waterfall: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Windows%20deterministic First failing build: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Windows%20deterministic/10487 Error message from the lookup_GN_args step looks like this: Traceback (most recent call last): File "C:\b\swarming\w\ir\kitchen-workdir\src\tools\mb\mb.py", line 63, in Main ret = self.args.func() File "C:\b\swarming\w\ir\kitchen-workdir\src\tools\mb\mb.py", line 332, in CmdLookup vals = self.Lookup() File "C:\b\swarming\w\ir\kitchen-workdir\src\tools\mb\mb.py", line 614, in Lookup config = self.ConfigFromArgs() File "C:\b\swarming\w\ir\kitchen-workdir\src\tools\mb\mb.py", line 696, in ConfigFromArgs (self.args.builder, self.args.master, self.args.config_file)) MBErr: Builder name "Windows deterministic" not found under masters[chromium.fyi] in "C:\b\swarming\w\ir\kitchen-workdir\src\tools\mb\mb_config.pyl" Original change's description: > Move 'Windows deterministic' from FYI to the main waterfall. > > Bug: 897980,330260 > Change-Id: I71bb304c6398484d5af5a981fdbc09314d69dd22 > Reviewed-on: https://chromium-review.googlesource.com/c/1295272 > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Commit-Queue: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#602198} TBR=thakis@chromium.org,dpranke@chromium.org,martiniss@chromium.org Change-Id: Ib9aff7c076f1f0e3192788f10da80036b4262ed1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 897980, 330260 Reviewed-on: https://chromium-review.googlesource.com/c/1297139Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2e57da0a..a6bda76c Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I2a4e866ed3607f9c73e359d311496fb69971b04c Reviewed-on: https://chromium-review.googlesource.com/c/1297723Reviewed-by:
-
Mikel Astiz authored
Most if not all sync integration tests output this red-herring and annoying trace: "Skipping unexpected progress marker for non-enabled type <type>". The reason is that, prior to this patch, the loopback server returned progress markers for all datatypes that the server knows about (i.e. at least one entity exists). Instead, let's mimic the real server and return progress markers for types that have been requested by the client. Bug: None Change-Id: I7354c0f38afbd71cf06ab3e7e7c4113f44db6ee2 Reviewed-on: https://chromium-review.googlesource.com/c/1296545 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0b9c09194c6a..624fe7f9b061 Created with: gclient setdep -r src-internal@624fe7f9b061 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I8cf0eadd802c752c0eef02ac29afb3876987266b Reviewed-on: https://chromium-review.googlesource.com/c/1297335Reviewed-by:
-
Friedrich Horschig authored
Before this CL, several places (esp. in browser/) would override the instance of the keyboard delegate in ui/. This caused an inconsistent, hard to track state of the KeyboardVisibilityDelegate. With this CL, the ui/ takes control of setting the delegate and specific browser-side implementations are called by using the appropriate factory methods. For that, the KeyboardVisibilityDelegate (brief: KVD) uses sublasses with very clearly split responsibilities: KeyboardVisibilityDelegate (ui/; public interface for all clients) <-- ActivityKVD (ui/; propagates visibility changes to listeners) <-- SingleWindowKVD (browser/; prevents multi-window use) <-- ChromeKVD (browser/ separates extensions/native) <-- FakeKeyboard (javatests/; mocks native keyboard) The CL actually has no functional changes, it performs these moves: - WindowAndroid Listeners moved into KeyboardVisibilityDelegate - AcivityWindowAndroid callbacks moved into ActivityKVD - ProcessInitializationHandler delegate became SingleWindowKVD - ManualFillingTestHelper's FakeKeyboard became a new, public class Functional changes follow with https://crrev.com/c/1286426 and mainly affect the ChromeKVD. Purpose of isAndroidSoftKeyboardShowing(...) and hideAndroidSoftKeyboardKeyboard(...): - Template methods to simplify mocking the calls to InputMethodManager - Ensures access to keyboard without extensions in subclasses (e.g. Chrome KVD) - prevents use of @CallSuper Change-Id: I06cf50f48625d2d883efc8cd66a3d062204e51b2 Reviewed-on: https://chromium-review.googlesource.com/c/1286649 Commit-Queue: Friedrich Horschig [EDT] <fhorschig@chromium.org> Reviewed-by:Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#602293}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/41ed3e083ed5..700b4a4e65c2 git log 41ed3e083ed5..700b4a4e65c2 --date=short --no-merges --format='%ad %ae %s' 2018-10-24 peah@webrtc.org AEC3: Allow limiting dominant nearend to the non-initial phase Created with: gclient setdep -r src/third_party/webrtc@700b4a4e65c2 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:898273 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I3ae8759bf93d26497f457efeef579669fbc32ee0 Reviewed-on: https://chromium-review.googlesource.com/c/1297332Reviewed-by:
-
Marc Treib authored
Before SyncAuthManager::RegisterForAuthNotifications(), the active/authenticated account isn't initialized, so the histogram would always record "not signed in". So make sure we record the histogram only after registering for auth. Bug: 898430 Change-Id: I00064541cefe6cb65d5a246f12c7a8eaef469c28 Reviewed-on: https://chromium-review.googlesource.com/c/1297420Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#602291}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/ea62998cdf18..a1e7b1c440e1 git log ea62998cdf18..a1e7b1c440e1 --date=short --no-merges --format='%ad %ae %s' 2018-10-24 hjd@google.com Merge "perfetto-ui: A number of small improvements" Created with: gclient setdep -r src/third_party/perfetto@a1e7b1c440e1 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I8cec73ea3005cfbf43ed5edcc696af4bb01803a8 Reviewed-on: https://chromium-review.googlesource.com/c/1297333Reviewed-by:
-
Marc Treib authored
This reverts commit af460e9a. Reason for revert: Seems to have broken paint/invalidation/table/cached-69296.html from webkit_layout_tests on Mac 10.11 - currently failed 7/7 times after this landed: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.11%20Tests First failing build: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.11%20Tests/30030 Original change's description: > [CI] Combine GetBackgroundPaintLocation of PaintLayer and LayoutBoxModelObject > > For fixing SlimmingPaintV2 scrolling background painting and > invalidation, we need a single place to get the accurate value > of the background paint location. > > Bug: 732611 > > Change-Id: I0ad696395d73c9c19078e13e9a32cf9dbd0c628f > Reviewed-on: https://chromium-review.googlesource.com/c/1297586 > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Reviewed-by: Robert Flack <flackr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#602250} TBR=flackr@chromium.org,wangxianzhu@chromium.org Change-Id: I279520fc9deafd9891dd3a5457e42d6fa0b201aa No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 732611 Reviewed-on: https://chromium-review.googlesource.com/c/1297362Reviewed-by:
-
Joel Hockey authored
Depends on https://chromium-review.googlesource.com/c/chromiumos/platform2/+/1287389 https://chromium-review.googlesource.com/c/chromiumos/platform2/+/1287390 Bug: 878324 Bug: 890649 Change-Id: I20b57cc7900727fa15ef2de12d247052dd040bff Reviewed-on: https://chromium-review.googlesource.com/c/1288095 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#602288}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/84fbe1444f3c..0b9c09194c6a Created with: gclient setdep -r src-internal@0b9c09194c6a The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I5a8e2aae26c599ffbe67598f524b037e66e7863d Reviewed-on: https://chromium-review.googlesource.com/c/1297331Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 950fb63e. With Chromium commits locally applied on WPT: f79c6fe7 "Reimplementing getDatabaseNames() as databases() for indexeddb." 57cc1d42 "Added 304 CSP test and removed "content-*" prefix from headers to ignore on 304" 89bcea96 "[run_web_tests] Remove extra baselines after crrev.com/c/1277654" 36e64bc7 "Updating tests for Window onerror is not triggered bug fix." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/26627 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=kyleju No-Export: true Change-Id: Iaf4edd35b07965fff3160503d3140be9a40950c8 Reviewed-on: https://chromium-review.googlesource.com/c/1297720 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#602286}
-
Nico Weber authored
https://chromium-review.googlesource.com/c/1295272 moved the bot on the console and updated mb_config.pyl. But once the bot had synced in the mb_config.pyl change, it started failing with lookup GN args Failed to extract GN args from output of "mb lookup" The lookup step still passes in `-m chromium.fyi`, and due to the mb_config.pyl change that no longer works. My best guess is that the mastername comes from the cr-buildbucket.cfg file, so change the master here too. (Seems like a nice thing to do in general.) TBR=dpranke Bug: 897980 Change-Id: I95fe0b7470ec39eb8ebfd0dc5a57980d598b0e46 Reviewed-on: https://chromium-review.googlesource.com/c/1297262Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#602285}
-
Nico Weber authored
Bug: 324079 Change-Id: I6a98e713094a8a158d7ef227efd77e75a79be810 Reviewed-on: https://chromium-review.googlesource.com/c/1296681Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#602284}
-
Olivier Robin authored
Bug: 897341 Change-Id: I311db2e8f685bae5aa2b218750ddaf6b7a4c02f0 Reviewed-on: https://chromium-review.googlesource.com/c/1296170Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#602283}
-
Gauthier Ambard authored
This CL fixes the way the utils are checking if the preferred content size category is an accessibility category for iOS 10. Even if iOS 10 support will be dropped, the code should be correct. Bug: 895804 Change-Id: I4ba1066b7eef712534da876777013476513c060a Reviewed-on: https://chromium-review.googlesource.com/c/1297417Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#602282}
-
Gauthier Ambard authored
New files are needed by the MDC repo. Bug: 898170 Change-Id: Ib48862834df9d677db459e5efccee761269f49a9 Reviewed-on: https://chromium-review.googlesource.com/c/1296500Reviewed-by:
-
