- 28 Aug, 2020 40 commits
-
-
Meilin Wang authored
Previously we leave the weather settings as their default values on the server side, which causes an unpredictable behavior on whether server will return weather info to us in the response. This CL fixed this issue by setting these values explicitly to notify server that we are always expecting weather info to be included in the response. Related CL: https://chrome-internal-review.googlesource.com/c/chrome/assistant/+/3215310 Bug: b/158630188 Test: manually Change-Id: I0e38e9fa46d22e36a6e5f6e2f42f84818acea433 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363914 Commit-Queue: Meilin Wang <meilinw@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#802702}
-
Nicolás Peña Moreno authored
This CL implements VisibilityStateEntry behind a flag. Only browsertests are added at the moment. Some WPTs will be added in a followup but full WPT support is not possible until we receive more support from the harness, see https://github.com/web-platform-tests/wpt/issues/25233. Explainer: https://docs.google.com/document/d/1l5kHiJRkdQwEN-CYI5_mUNODhQVB5rCyjN4jHDdXDHA/edit Intent to Prototype: https://groups.google.com/a/chromium.org/forum/#!searchin/blink-dev/visibility%7Csort:date/blink-dev/0rW4Q_NtL20/h1C2C0rLAAAJ Bug: 1103451 Change-Id: I72d98cf0884d1f820ddffec9da2007e4d253bc08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375733Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#802701}
-
Sergei Glazunov authored
This is a reland of 4d9450df Original change's description: > [PartitionAlloc] Use reciprocal multiplication to speed up GetSlotOffset > > Currently, the "get offset of a pointer within its allocated slot" > functionality, which is used extensively by several MiraclePtr > implementations, performs an expensive modulo operation. This commit > replaces it with a cheaper sequence of multiplications and bit shifts. > > Bug: 1092288 > Change-Id: I866689a79fff704b5f83fc07d8f28b3386ef644d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335443 > Commit-Queue: Sergei Glazunov <glazunov@google.com> > Reviewed-by: Benoit L <lizeb@chromium.org> > Reviewed-by: Bartek Nowierski <bartekn@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#802194} Bug: 1092288 Change-Id: Iec17efe8f9837f55c2f40dcf80033e6efd9580dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380277 Commit-Queue: Sergei Glazunov <glazunov@google.com> Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#802700}
-
Peng Huang authored
This reverts commit a37811d1. Reason for revert: https://chromium-swarm.appspot.com/task?id=4e4ecbbb4657b710#ScreenshotSync_GPURasterWithDivs,ScreenshotSync_SWRasterWithDivs Original change's description: > SkiaOutputDevice: use buffer format passed to Reshape > > Bug: 1108406 > Change-Id: Iaca79e3b6c1d66e421711c46f75a1cb614b7f961 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378745 > Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org> > Commit-Queue: Peng Huang <penghuang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#802450} TBR=penghuang@chromium.org,vasilyt@chromium.org Change-Id: Idd1c5aaca95ede1e052e72fd19e8b590ed21c79a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1108406 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382056Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#802699}
-
chromium-internal-autoroll authored
Release_Notes: http://go/help_app-x20/relnotes/Nightly/help_app_nightly_202008280800_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/e6UISBIfdcTS7sATnTUvRDyO7rV3PGA8ubhN8f-RejgC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: help-app@grotations.appspotmail.com Change-Id: Ia4acb51c95e6f983b75fdd66d0525ab1aabd1fbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380304Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#802698}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/33a6332a9232..d7c4e9418e36 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I1ce94f1b85675c3913e4df3933040cd9c3e1e058 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381259Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#802697}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/5c8601ed8285..167a0f22e2ee 2020-08-28 syoussefi@chromium.org Vulkan: Fixes to transform feedback emulation path If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: courtneygo@google.com Change-Id: I0e9fdd120afba6b6af01434e012ccf27ad914ade Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380305Reviewed-by:
-
danakj authored
This primitive didn't pan out to be helpful for splitting view vs widget responsibilities and codepaths in WebViewImpl. So let's remove it and its complexity. R=dcheng@chromium.org Change-Id: I19044e36e3bf39550b308fc03fe8a7bdd6fe09a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380104Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#802695}
-
Dirk Pranke authored
A few tests (some Android resource_sizes tests, and one Perfetto test), were using generated_script tests that were generating wrappers that weren't named 'bin/run_$target_name'. We want all generated_script tests to be using consistent names, so this CL changes those targets. Bug: 816629 Change-Id: If447fbee6b33637de4c9711e87379128272285af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380672 Commit-Queue: Dirk Pranke <dpranke@google.com> Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#802694}
-
Adam Langley authored
Also remove gcm_driver from BrowserProcess on Android since it always returns nullptr there. Change-Id: I2b694177a88280faf8529f348e09c829dc1bfd4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378596Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Auto-Submit: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#802693}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/900bd341a3c6..9ed8d518cacf 2020-08-28 cwallez@chromium.org Unify ProgrammableStageDescriptor handling in PipelineBase If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Ib1a6a625cf2880b037557c4f79a91a746819371e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381596Reviewed-by:
-
Chris Palmer authored
Fall back to reading from urandom only when that fails. This is a re-land of https://chromium-review.googlesource.com/c/chromium/src/+/1762604, which was reverted in https://chromium-review.googlesource.com/c/chromium/src/+/2377418. Bug: 995996 Change-Id: I007581630f789881ab956c1b1666b99f087fa154 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380673Reviewed-by:
Julien Tinnes <jln@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Chris Palmer <palmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#802691}
-
Kuo-Hsin Yang authored
GetAvailableMemoryKB will be used by the memory pressure D-Bus service provider, and SystemMemoryPressureEvaluator will call the memory pressure D-Bus API. Move GetAvailableMemoryKB to avoid the circular dependency between SystemMemoryPressureEvaluator and the memory pressure D-Bus service provider. BUG=b:149833548 TEST=run chromeos_unittests Change-Id: Ieab7763fe9b9291e2503463dbdce19cc92838c9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381241 Commit-Queue: Kuo-Hsin Yang <vovoy@chromium.org> Reviewed-by:
Brian Geffon <bgeffon@chromium.org> Cr-Commit-Position: refs/heads/master@{#802690}
-
James Hawkins authored
R=khorimoto@chromium.org Bug: 1045266 Test: NetworkComponentsNetworkConfigToggleTest* Change-Id: I854fbb35447a20a3a33e051b71c57378529c5f06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380265Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#802689}
-
Noah Rose Ledesma authored
This reverts commit 442effe1. Reason for revert: Breaks linux-chromeos-chrome builds see https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/8079 Original change's description: > Add a MediaSessionAction for audio output device switching. > > This change adds an action to the MediaSessionAction enum for signaling > if audio output device switching is possible for that session. A session > supports switching audio devices if and only if the session has at > least one player and all of the players support audio device switching. > > When the audio output device cannot be changed, the Global Media > Controls UI should not display a device picker. This change is a part > of a series of changes for appropriately hiding this UI. > > Bug: 1120620 > Change-Id: If03ef110ff32fa0db3463c63a6a1730da60d2278 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369440 > Commit-Queue: Noah Rose Ledesma <noahrose@google.com> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: Fabrice de Gans-Riberi <fdegans@chromium.org> > Reviewed-by: Nasko Oskov <nasko@chromium.org> > Reviewed-by: Tommy Steimel <steimel@chromium.org> > Reviewed-by: Becca Hughes <beccahughes@chromium.org> > Cr-Commit-Position: refs/heads/master@{#802666} TBR=xiyuan@chromium.org,nasko@chromium.org,fdegans@chromium.org,beccahughes@chromium.org,steimel@chromium.org,noahrose@google.com Change-Id: Id9d684d9b7970d6a0a0de1716a8798adb5daec35 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1120620 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382050Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#802688}
-
Marijn Kruisselbrink authored
This reverts commit 88d45f78. Reason for revert: Unfortunately this seems to be causing frequent flaky crashes in ECKIncognitoEncryptedMediaTest.FileIO https://ci.chromium.org/p/chromium/builders/ci/Linux%20Ozone%20Tester%20%28X11%29/16596 BrowserTestBase received signal: Segmentation fault. Backtrace: #0 0x5556b3a3edb9 base::debug::CollectStackTrace() #1 0x5556b39b4743 base::debug::StackTrace::StackTrace() #2 0x5556b3f82016 content::(anonymous namespace)::DumpStackTraceSignalHandler() #3 0x7f4df599a4c0 (/lib/x86_64-linux-gnu/libc-2.23.so+0x354bf) #4 0x7f4df5ab3095 (/lib/x86_64-linux-gnu/libc-2.23.so+0x14e094) #5 0x5556b130ff73 _ZNSt3__16vectorIhNS_9allocatorIhEEE6insertIPKcEENS_9enable_ifIXaasr21__is_forward_iteratorIT_EE5valuesr16is_constructibleIhNS_15iterator_traitsIS8_E9referenceEEE5valueENS_11__wrap_iterIPhEEE4typeENSC_IPKhEES8_S8_ #6 0x5556b5ed32e7 storage::ObfuscatedFileUtilMemoryDelegate::WriteFile() #7 0x5556b5ee0cdf base::internal::Invoker<>::RunOnce() ... Original change's description: > Run ObfuscatedFileUtilMemoryDelegate entirely on TaskRunner. > > MemoryFileStreamWriter called some ObfuscatedFileUtilMemoryDelegate > functions through IO thread while other functions in OFUMD are called > on a threadpool sequence. This could result in races in updating > directory structure. > > To fix the issue, MemoryFileStreamWriter and MemoryFileStreamReader are > updated to call all OFUMD on the default task runner of the file system > context. > > Bug: 1100136 > Change-Id: I59146ca690eee810c52f807bd1fb4ef2b1f2c929 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308721 > Commit-Queue: Ramin Halavati <rhalavati@chromium.org> > Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#802584} TBR=mek@chromium.org,rhalavati@chromium.org Change-Id: Ib856bac5a978b8da33e74f8646ddd5be2a285865 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1100136 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382051Reviewed-by:
-
Nelson Billing authored
This reverts commit ee340b0b. Reason for revert: New symupload version is encountering issues on Mac OS build bots, need to investigate and fix before re-rolling changes. Original change's description: > Roll breakpad to 9c38ab7c67e5b199e6b7ffafa27b7f463f06dedd > > This is primarily needed to bring in symupload native symbols support on Mac. > > 9c38ab7 Add native symbol uploads to Mac OS symupload tool. > 62d9272 linux: Fix segfault when there is no section header in ELF file > 087795c processor: subtract 1 from return pointers while scanning > 014e842 Escape more characters in Mac OS sym-upload-v2 debug_file strings. > > BUG=1021742 > R=nbilling@google.com, rohitrao@chromium.org > > Change-Id: I7bc63acfb5fb94e1c9b9f6d38801886a6225c2f3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380139 > Reviewed-by: Rohit Rao <rohitrao@chromium.org> > Commit-Queue: Rohit Rao <rohitrao@chromium.org> > Auto-Submit: Michael Moss <mmoss@chromium.org> > Cr-Commit-Position: refs/heads/master@{#802357} TBR=rohitrao@chromium.org,mmoss@chromium.org,nbilling@google.com Change-Id: I40b4c2aac99b4153e9df8b268e0ca2d5b7bae6f4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1021742 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382010Reviewed-by:
Michael Moss <mmoss@chromium.org> Commit-Queue: Michael Moss <mmoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#802686}
-
Donn Denman authored
The IPH for the Translations Feature that encourages users to Opt-in was landed previously without triggering logic, and some other essential features. It included the string to show and the definition of the IPH Feature, so the basic functionality is there but inactive. This CL adds triggering when a translation is needed and the user has not fully enabled Contextual Search. The help bubble points to the Bar. BUG=1121867 Change-Id: I710a40b90c650e6cd3fdc607131701fd1a7a5fbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377305Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Auto-Submit: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#802685}
-
Bence Béky authored
Use ElideSpdyHeaderBlockForNetLog() for SpdyHeaderBlock, fork it as ElideQuicHeaderListForNetLog() for QuicHeaderList. Bug: 1122684 Change-Id: I3f6abe810657bc5ae4655fd7d4fec60825eff38e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380573Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Auto-Submit: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#802684}
-
Sadrul Habib Chowdhury authored
Notify the CompositorFrameReporter when a main-frame is aborted because of lack of updates (e.g. page is not visible, or no visual changes were made). BUG=1123039 Change-Id: I1970e0fcffdca0680a086eaeda02ab2fd118411e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378783 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Behdad Bakhshinategh <behdadb@chromium.org> Reviewed-by:
Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#802683}
-
Andrew Paseltiner authored
This reverts commit 0c891022. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=1109599#c10 Original change's description: > Reland "Trigger heavy ad intervention when an unloaded heavy ad navigates" > > This is a reland of 312a57a1 > > Original change's description: > > Trigger heavy ad intervention when an unloaded heavy ad navigates > > > > Bug: 1099014 > > Change-Id: I98a2d0e548a48fd93618fbae1c1d458f1dbd58a4 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269740 > > Reviewed-by: John Delaney <johnidel@chromium.org> > > Commit-Queue: Andrew Paseltiner <apaseltiner@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#791488} > > Bug: 1099014 > Change-Id: I0894d1f43127e3776e9f71bd35dcb723a1778ceb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356164 > Reviewed-by: John Delaney <johnidel@chromium.org> > Commit-Queue: Andrew Paseltiner <apaseltiner@chromium.org> > Cr-Commit-Position: refs/heads/master@{#801381} Bug: 1099014, 1109599 Change-Id: Ia73fb4cf681524d2ecd2604622c765ac22a21049 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381254Reviewed-by:
John Delaney <johnidel@chromium.org> Commit-Queue: Andrew Paseltiner <apaseltiner@chromium.org> Cr-Commit-Position: refs/heads/master@{#802682}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/b90423b45298..a4ec7f6e5af7 2020-08-28 kimiyuki@google.com cros_deploy: Warn when the user seems to forget cros workon 2020-08-28 chrome-bot@chromium.org Update config settings by config-updater. 2020-08-28 chrome-bot@chromium.org Update config settings by config-updater. 2020-08-28 engeg@google.com paygen_payload_lib.py: measure actual payload time 2020-08-27 bhanumaiya@google.com zork: Replace firmware-zork-13421.B builder with firmware-zork-13434.B 2020-08-27 chrome-bot@chromium.org Update config settings by config-updater. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: I8e545b2ee8a79139ab3bedecf318f0d0830135a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381600Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/1f2195b4..15826356 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ifd26a7a5e9ad521633a8f71639cdf74d531a9204 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379638Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#802680}
-
Tina Wang authored
This test causes consistently build failure. TBR = himanshujaju@chromium.org TBR = alexchau@chromium.org Bug: 1123022 Change-Id: I9e8270ac73118ad6f571374125f9c55411a7ab9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381067 Commit-Queue: Tina Wang <tinazwang@chromium.org> Reviewed-by:
Tina Wang <tinazwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#802679}
-
Frédéric Wang authored
A source comment says Font::PrimaryFont() should generally not return a nullptr but it does every now and then [1]. Callers use a DCHECK, or handle the nullptr case or do both [2]. For MathML, let's be safe and always provide a fallback when that happens. Bug: 1107928 [1] https://source.chromium.org/chromium/chromium/src/+/master:third_party/blink/renderer/platform/fonts/font.h;drc=7d57c572aa28cd2de288b2f6fe690053c239c987;l=199 [2] https://source.chromium.org/search?q=%22PrimaryFont()%22%20filepath:renderer%2Fcore Change-Id: I482e4a0b0d554aba6b5213ceeaab3156fb053837 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379916Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Frédéric Wang <fwang@igalia.com> Cr-Commit-Position: refs/heads/master@{#802678}
-
Andy Paicu authored
Disclaimer: initially these were separate CLs but I've discovered many tests that would need a temporary fix until all CLs were landed. This CL is a precursor to removing the permission delegation flag (as it's been enabled by default for 2 years) and it attempts to do the following: * Switch GEOLOCATION, MIDI_SYSEX, PROTECTED_MEDIA_IDENTIFIER to being SINGLE_ORIGIN_ONLY_SCOPE. As was the intent with permission delegation, these permissions are requested only by the top-origin which can then use feature policy to allows subframes to use its permission. * Un-deprecate REQUESTING_ORIGIN_AND_TOP_LEVEL_ORIGIN_SCOPE scoping and now treat it as non-recommended. There are other permission types and content settings that use REQUESTING_ORIGIN_AND_TOP_LEVEL_ORIGIN_SCOPE so deprecating it doesn't make sense anymore. * Enforce the usage of (x,*) patterns for SINGLE_ORIGIN_ONLY_SCOPE settings. Extensions can still use (x,x) but that will be silently transformed into (x,*) by chrome. Bug: 880684 Change-Id: I0915bbf5649c9805010dbb2059c2c9f37452b84d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292432 Commit-Queue: Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#802677}
-
Irina Fedorova authored
This CL adds kWeakCredential flag to CompromiseTypeFlags enum and rename it to InsecureCredentialTypeFlags. We need this changes because in the feature we want to add passwords weakness check and use this enum. Bug: 1119752 Change-Id: Ic27157ef119f9725b20d35507e371117ae95d51c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377720 Commit-Queue: Irina Fedorova <irfedorova@google.com> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#802676}
-
Ana SollanoKim authored
Previously, in a fragmented fieldset its top and bottom borders would paint in every fragment. In this change, we supply the paint border function (inside the fieldset painter) with the sides to include variable. As a result, the top border is only painted in the first fragment and the bottom border is only painted in the last. Bug: 829028 Change-Id: I758795ae7a368d81319ddcd54bea032320100535 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378812Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Alison Maher <almaher@microsoft.com> Commit-Queue: Ana Sollano Kim <ansollan@microsoft.com> Cr-Commit-Position: refs/heads/master@{#802675}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1598572748-c240e19e9b06ea3510ae397a3f34ad9e6bf7d036.profdata to chrome-win64-master-1598613564-d41b98b98dbc5191c7849f32cc1e8367c121c9d0.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I2907ea8874280424486ef574770efdb8c0a8cee5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381447Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 71768faf. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: bjonesbe@adobe.com: external/wpt/css/css-shapes yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: Iad44559f303f65bc7067eb58dab63cff0ac74c74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379639Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#802673}
-
Evan Stade authored
It's not needed since KitKat support has been removed. Bug: none Change-Id: Id3602b3b942899aae5fcf6a074cf82f34b7cf6b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380339Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#802672}
-
Evan Stade authored
Bug: 470582 Change-Id: I2bcb08e74061643af08a756f067c7cd37717313f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380385Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#802671}
-
Christian Dullweber authored
Use a scheme and path-less URL in page info. Toggle to full URL display on click. Screenshot: https://crbug.com/1077766#27 Bug: 1077766 Change-Id: If3f50b513de84fd2a54eef9438153c00e47bc650 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375367Reviewed-by:
Ehimare Okoyomon <eokoyomon@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#802670}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/7ab9c51e8047..e3e2618b1b05 2020-08-28 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 186593cd..4bf6d398 (802477:802598) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ie3426785902ae8dbbe33e85a53ddb247bd8ffba7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381592Reviewed-by:
-
Marijn Kruisselbrink authored
This reverts commit e0309342. Reason for revert: doesn't compile on for example https://ci.chromium.org/p/chrome/builders/ci/win-chrome/14113 ../../chrome/browser/ui/webui/policy_ui_handler.cc(1298,30): error: no viable overloaded '=' updater_status_provider_ = std::make_unique<UpdaterStatusProvider>(); ~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../../buildtools/third_party/libc++/trunk/include\memory(2551,15): note: candidate function not viable: 'this' argument has type 'const std::unique_ptr<PolicyStatusProvider>', but method is not marked const Original change's description: > Policy WebUI: 'Reload Policies' button reloads google update policies > > Bug: 1119703 > Change-Id: Ib91b37dc1da4f06782caea7b67ecc6d0c8c87b2d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367673 > Commit-Queue: Yann Dago <ydago@chromium.org> > Reviewed-by: Owen Min <zmin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#802644} TBR=zmin@chromium.org,ydago@chromium.org Change-Id: I6c3b3bb79801e5aae68ab97f5ba79e5b8d10509a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1119703 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381300Reviewed-by:
-
David Landell authored
The patch set in https://crrev.com/c/2267919 refactored the processing of additional_readme_paths.json files but introduced the change that such paths will be absolute instead of relative to the root. Other paths found by walking the directory tree are relative. This makes such additional paths relative. Bug: N/A Change-Id: Ia2b8cfe99d5e704ed423a17f791aea43a94a8d7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379771 Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#802667}
-
Noah Rose Ledesma authored
This change adds an action to the MediaSessionAction enum for signaling if audio output device switching is possible for that session. A session supports switching audio devices if and only if the session has at least one player and all of the players support audio device switching. When the audio output device cannot be changed, the Global Media Controls UI should not display a device picker. This change is a part of a series of changes for appropriately hiding this UI. Bug: 1120620 Change-Id: If03ef110ff32fa0db3463c63a6a1730da60d2278 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369440 Commit-Queue: Noah Rose Ledesma <noahrose@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I43b1d1fd403bf302e7190dd5ccf3f3f21a6c3048 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381595Reviewed-by:
-
Mohsen Izadi authored
In a gesture scroll sequence, generally speaking, nothing much happens on scroll-begin and most of the interesting updates happen in response to scroll-updates. It would be useful to report event latency metrics for the first scroll-update in the sequence separately from the rest so it can be used in determining the latency of starting a scroll. This also matches the behavior of existing Event.Latency metrics which report the latency of the first scroll-update as ScrollBegin and the rest as ScrollUpdate. For now, we use LatencyInfo to determine whether a scroll-update is the first one or not. As a follow-up we will move this off of LatencyInfo and calculate it in the renderer as there is no need to pass it around between process along with the LatencyInfo. Bug: 1079116 Change-Id: I6f4181f927215226692161a365d2e42f32712193 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356651Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#802664}
-
Rushan Suleymanov authored
SendTabToSelfBridge::SetTargetDeviceInfoList checks that there is recent local cache GUID in device info tracker. However it might still not be initialized during browser startup. In that case it is possible that TrackedCacheGuid() returns non-empty value and it is not in recent local cache GUID list. This leads to DCHECK vialoation. This patch adds check that device info tracker is syncing and has actual list with recent cache GUIDs. Bug: 1023457 Change-Id: I8261551859a3cf75109b3dcac9d1559a5bec4a22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379733Reviewed-by:
Jeffrey Cohen <jeffreycohen@chromium.org> Commit-Queue: Rushan Suleymanov <rushans@google.com> Cr-Commit-Position: refs/heads/master@{#802663}
-
