Commits · abc2056e55ea99b6065acea7582127f8ed46f220 · eriksson monteiro / tangled

26 May, 2011 40 commits

Revert 86802 - Remove ProtocolFactory/Interceptor uses in GViewRequestInterceptor. · abc2056e

willchan@chromium.org authored May 26, 2011

Gets rid of more use of net/ globals, replacing with URLRequestJobFactory uses. Helps make net/ more thread-compatible.

BUG=81979
TEST=none

Review URL: http://codereview.chromium.org/7019030

TBR=willchan@chromium.org
Review URL: http://codereview.chromium.org/7075005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86803 0039d316-1c4b-4281-b951-d872f2087c98

abc2056e

Remove ProtocolFactory/Interceptor uses in GViewRequestInterceptor. · bbf82107

willchan@chromium.org authored May 26, 2011

Gets rid of more use of net/ globals, replacing with URLRequestJobFactory uses. Helps make net/ more thread-compatible.

BUG=81979
TEST=none

Review URL: http://codereview.chromium.org/7019030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86802 0039d316-1c4b-4281-b951-d872f2087c98

bbf82107

Prevent registerProtocolHandler for pseudo-schemes and disabled schemes. · 82616d31

koz@chromium.org authored May 26, 2011

Review URL: http://codereview.chromium.org/7069006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86799 0039d316-1c4b-4281-b951-d872f2087c98

82616d31

Revert 81536 that made all updates during OOBE required · 847de66e

dpolukhin@chromium.org authored May 26, 2011

BUG=chromium-os:2718
TEST=browser_tests

Review URL: http://codereview.chromium.org/6976021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86797 0039d316-1c4b-4281-b951-d872f2087c98

847de66e

Updating trunk VERSION from 777.0 to 778.0 · b073e5a6
chrome-release@google.com authored May 26, 2011
```
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86796 0039d316-1c4b-4281-b951-d872f2087c98
```
b073e5a6

Land http://codereview.chromium.org/6869009 for the third time. · 5c9977be

glider@chromium.org authored May 26, 2011

Introduce the ANNOTATE_LEAKING_OBJECT_PTR annotation that can be used to mark
heap allocated objects as intentionally leaked ones.
Annotate the histograms produced by {Histogram,BooleanHistogram,LinearHistogram,CustomHistogram}::FactoryGet(), as leaked.

Rename StatsHistogram::StatsHistogramFactoryGet to StatsHistogram::FactoryGet, annotate the result as leaky, update the suppressions.

BUG=79322
TBR=jar,willchan
Review URL: http://codereview.chromium.org/7062016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86794 0039d316-1c4b-4281-b951-d872f2087c98

5c9977be

Allow chrome to become the os default handler for arbitrary protocols on mac/win. · 4468a5b3

koz@chromium.org authored May 26, 2011

Note this is unused currently, but will be hooked up to
navigator.registerProtocolHandler in a subsequent change.

BUG=83556
TEST=Manual

Review URL: http://codereview.chromium.org/6961013
Patch from Ben Wells <benwells@chromium.org>.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86793 0039d316-1c4b-4281-b951-d872f2087c98

4468a5b3

Leak fix in FileSystemOperationUnitTest. · e31d4c24

kinuko@chromium.org authored May 26, 2011

BUG=83944
TEST=valgrind bots green

Review URL: http://codereview.chromium.org/7053029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86792 0039d316-1c4b-4281-b951-d872f2087c98

e31d4c24

OS_CHROMEOS isn't defined on the Linux views bot. · 11f9de05

vandebo@chromium.org authored May 26, 2011

BUG=NONE
TEST=NONE

Review URL: http://codereview.chromium.org/7062017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86791 0039d316-1c4b-4281-b951-d872f2087c98

11f9de05

Roll ANGLE to r654 · adc01d27

nduca@chromium.org authored May 26, 2011

```---------------------------------------------------------------------
r654 | nduca@chromium.org | 2011-05-24 18:55:06 -0700 (Tue, 24 May 2011) | 4 lines

Use D3DSWAPEFFECT_FLIPEX on Windows 7.

Reduces frame rate jitters on Windows 7 reported in crbug.com/82925
Review URL: http://codereview.appspot.com/4517096
```

---------------------------------------------------------------------
r653 | daniel@transgaming.com | 2011-05-17 11:34:24 -0700 (Tue, 17 May 2011) | 3 lines

Add missing newlines to source files

Issue=154
------------------------------------------------------------------------
r652 | daniel@transgaming.com | 2011-05-17 11:34:18 -0700 (Tue, 17 May 2011) | 4 lines

Improve robustness of Context::finish and flush

Trac #16690
Signed-off-by: Nicolas Capens
------------------------------------------------------------------------
r651 | daniel@transgaming.com | 2011-05-13 09:05:22 -0700 (Fri, 13 May 2011) | 7 lines

Fix the order of the error() parameters in Surface.cpp and advertise EGL_ANGLE_d3d_share_handle_client_buffer extension

Trac #16711

Also rename the extension file to match the extension name

Signed-off-by: Nicolas Capens
------------------------------------------------------------------------
r650 | jbauman@chromium.org | 2011-05-12 16:04:07 -0700 (Thu, 12 May 2011) | 6 lines

Add support for eglCreatePbufferFromClientBuffer, taking as input a D3D share handle corresponding to the enum EGL_D3D_TEXTURE_2D_SHARE_HANDLE_ANGLE. No spec as of yet, but it does the obvious thing.

BUG=129
TEST=

Review URL: http://codereview.appspot.com/4325048
------------------------------------------------------------------------
r649 | jbauman@chromium.org | 2011-05-12 13:53:34 -0700 (Thu, 12 May 2011) | 8 lines

Use SSE2 to swizzle RGBA to BGRA

Using SSE2 can drastically reduce the amount of time it takes to do glTexImage2D. I've also added a plain-C path that's much faster than the one that was there before.

BUG=151
TEST=

Review URL: http://codereview.appspot.com/4465052
------------------------------------------------------------------------
r648 | apatrick@chromium.org | 2011-05-12 11:15:03 -0700 (Thu, 12 May 2011) | 38 lines

Cache result of D3DPERF_GetStatus.

I profiled the WebGL acquarium with AMD CodeAnalyst and it turns out this function got a lot of hits. Top 10 before change:

CS:EIP     	Symbol + Offset                                                              	64-bit 	Timer samples
0x62a87260 	CBatchFilterI::ProcessBatch                                                  	       	13.41
0x62a171f1 	D3DPERF_GetStatus                                                            	       	6.04
0x629ce831 	CD3DBase::SetVertexShaderConstantF_FP                                        	       	5.12
0x62a88bea 	CBatchFilterI::GetBatchBufferPointer<_LH_SETPIXELSHADERCONSTIMM_TOKEN_SMALL> 	       	4.61
0x6298060b 	UpdateViewportCache                                                          	       	4.2
0x6298da3a 	CD3DBase::UpdateTextures                                                     	       	3.58
0x6298db6b 	CD3DDDIDX10::SetTexture                                                      	       	2.76
0x6298df1d 	CD3DDDIDX10::InsertStreamSource                                              	       	2.46
0x629d1c1a 	CD3DBase::SetPixelShaderConstantF_FP                                         	       	2.25
0x6297efc4 	CD3DHal::SetSamplerState_FP                                                  	       	2.05

10 functions, 186 instructions, Total: 454 samples, 46.47% of shown samples, 2.51% of total session samples

And after:

CS:EIP     	Symbol + Offset                                                              	64-bit 	Timer samples
0x69317260 	CBatchFilterI::ProcessBatch                                                  	       	13.87
0x69318bea 	CBatchFilterI::GetBatchBufferPointer<_LH_SETPIXELSHADERCONSTIMM_TOKEN_SMALL> 	       	5.84
0x6921060b 	UpdateViewportCache                                                          	       	5.29
0x6925e831 	CD3DBase::SetVertexShaderConstantF_FP                                        	       	4.93
0x6921da3a 	CD3DBase::UpdateTextures                                                     	       	4.38
0x6921e034 	CD3DBase::SetStreamSource_FP                                                 	       	3.65
0x69261c1a 	CD3DBase::SetPixelShaderConstantF_FP                                         	       	3.65
0x69227651 	CD3DBase::DrawIndexedPrimitive                                               	       	2.74
0x6920efc4 	CD3DHal::SetSamplerState_FP                                                  	       	2.37
0x6925e9f7 	CD3DBase::SetVertexShaderConstantIntF                                        	       	2.37

10 functions, 152 instructions, Total: 269 samples, 49.09% of shown samples, 0.80% of total session samples

UpdateViewportCache looks like it might be low hanging fruit as well.
Review URL: http://codereview.appspot.com/4535049
------------------------------------------------------------------------

Review URL: http://codereview.chromium.org/7077003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86790 0039d316-1c4b-4281-b951-d872f2087c98

adc01d27

WebKit Roll 87341:87361 · 5f350017

ukai@chromium.org authored May 26, 2011

BUG=none
TEST=none
TBR=mnaganov

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86789 0039d316-1c4b-4281-b951-d872f2087c98

5f350017

Removes obsolete code in WebPluginDelegateImpl. · 352cbe44

hbono@chromium.org authored May 26, 2011

This change removes obsolete code in my r42445 <http://crrev.com/42445> because Flash does not need to have the keyboard layout of a plug-in process synchronized with a browser process. (This is a preparation change for Issue 82507.)

BUG=82507
TEST=none
Review URL: http://codereview.chromium.org/7069004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86788 0039d316-1c4b-4281-b951-d872f2087c98

352cbe44

Disable CaptureVisibleTabPng/Jpeg on platforms where they time out. · 3ebc22ea

vandebo@chromium.org authored May 26, 2011

BUG=83876
TEST=NONE

Review URL: http://codereview.chromium.org/7071005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86787 0039d316-1c4b-4281-b951-d872f2087c98

3ebc22ea

Suppressing another leak in P2PSocketHost · 508426a8

oshima@google.com authored May 26, 2011

TBR=sergeyu@chromium.org
BUG=83949
TEST=chromeos valgrind bot cycle green.

Review URL: http://codereview.chromium.org/6976019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86786 0039d316-1c4b-4281-b951-d872f2087c98

508426a8

Fix clang error. · 9fbb3dd8

asargent@chromium.org authored May 26, 2011

BUG=none
TEST=none

TBR=mpcomplete@chromium.org

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86785 0039d316-1c4b-4281-b951-d872f2087c98

9fbb3dd8

Fix preprocessor macro for flaky test (BrowserTest.FaviconChange). · 162a2228

vandebo@chromium.org authored May 26, 2011

BUG=83828
TEST=NONE

Review URL: http://codereview.chromium.org/7075004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86784 0039d316-1c4b-4281-b951-d872f2087c98

162a2228

Add BASE_API to the remaining functions in linux_util. · fb96946a

bryner@chromium.org authored May 26, 2011

These symbols are used by chrome/browser/crash_handler_host_linux.cc when building with branding==Chrome, so they need to be exported for shared-library builds to work in that configuration.

BUG=none
TEST=builds

Review URL: http://codereview.chromium.org/7076007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86782 0039d316-1c4b-4281-b951-d872f2087c98

fb96946a

Undo mistaken revert. · 6d8e2732

vandebo@chromium.org authored May 26, 2011

Revert "Revert "Add VideoCaptureImpl and VideoCaptureImplManager""
This reverts commit r86770

BUG=NONE
TEST=NONE
TBR=wjia@google.com

Review URL: http://codereview.chromium.org/6962006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86781 0039d316-1c4b-4281-b951-d872f2087c98

6d8e2732

Change the web store private install API to accept a localized extension name. · ad93c6ba

asargent@chromium.org authored May 26, 2011

In our initial design of the beginInstallWithManifest function, we forgot that
some extensions have a name which needs token substitution for i18n/l10n. This
change renames beginInstallWithManifest to beginInstallWithManifest2, and
modifies the signature to take optional localizedName and locale parameters.

I also refactored how we compare the passed in manifest used in the
pre-download confirmation dialog - we now keep a copy of the source from the
.crx file to compare against, since i18n substututions can happen on the
manifest we use to construct the Extension object.

BUG=75821
TEST=Covered by browser tests for now; will require web store server-side
changes before it can be manually tested.

Review URL: http://codereview.chromium.org/6992047

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86780 0039d316-1c4b-4281-b951-d872f2087c98

ad93c6ba

Remove the last prefs code from content. I tried hard to move... · b5cca98e

jam@chromium.org authored May 26, 2011

Remove the last prefs code from content. I tried hard to move ShouldShowBookmarkBar out of TabContents, but this looked very tricky so I've punted and filed http://crbug.com/83975 to track that.

BUG=76697
Review URL: http://codereview.chromium.org/7068034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86779 0039d316-1c4b-4281-b951-d872f2087c98

b5cca98e

Non-path Time Machine Exclusions · 22e0af99

mrossetti@chromium.org authored May 26, 2011

Enable setting of file exclusion for non-admin/non-root users. We no longer support setting exclusion-by-path.
Enhanced error reporting in SetFileBackupExclusion.
Change exclusion calls for History and Thumbnail databases.
Made MacUtilTest.TestExcludeFileFromBackups more robust.

BUG=74053
TEST=Updated base_unittests's MacUtilTest.TestExcludeFileFromBackups.
Review URL: http://codereview.chromium.org/7069021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86778 0039d316-1c4b-4281-b951-d872f2087c98

22e0af99

views: Get rid of View::SetParent() method. · b5fe7445

tfarina@chromium.org authored May 26, 2011

This method is private to View class, and thus can be removed.

BUG=72040
TEST=None

R=ben@chromium.org

Review URL: http://codereview.chromium.org/7076002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86775 0039d316-1c4b-4281-b951-d872f2087c98

b5fe7445

Initial implementation of stream switching in AdaptiveDemuxer. · dbff0a42

acolwell@chromium.org authored May 26, 2011

BUG=82167
TEST=none

Review URL: http://codereview.chromium.org/7044008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86774 0039d316-1c4b-4281-b951-d872f2087c98

dbff0a42

Disable CaptureVisibleTabPng on choromeos · e19bd2aa

oshima@google.com authored May 26, 2011

This timeouts out often on chromeos.

BUG=83876
TEST=browser_tests on chromeos will no longer hang.

Review URL: http://codereview.chromium.org/7077002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86771 0039d316-1c4b-4281-b951-d872f2087c98

e19bd2aa

Revert "Add VideoCaptureImpl and VideoCaptureImplManager" · 86ca97fc

vandebo@chromium.org authored May 26, 2011

This reverts commit r86758

Revert "fix clang"

This reverts commit r86761

BUG=NONE
TEST=NONE
TBR=wjia@google.com

Review URL: http://codereview.chromium.org/7071002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86770 0039d316-1c4b-4281-b951-d872f2087c98

86ca97fc

Address bar is shown on pop-out extension windows. · f112b0f0

prasadt@chromium.org authored May 26, 2011

The code path for window.open() call from extensions is not setting the
app_name_ on the browser instance which is causing the location bar to
be displayed.

This is a regression from "Cleanup popup related browser navigation
code." - svn://svn.chromium.org/chrome/trunk/src@83399

BUG=83692
TEST=Invoke window.open() from an extension background page.  There
should be no location bar displayed.

modified:   chrome/browser/extensions/extension_host.cc
modified:   chrome/browser/ui/browser_navigator.cc

Review URL: http://codereview.chromium.org/6992018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86768 0039d316-1c4b-4281-b951-d872f2087c98

f112b0f0

Fixes bug in NativeWidgetWin::GetAcceleratedWidget. I had the ifdef · aa6752c9

sky@chromium.org authored May 26, 2011

wrong.

BUG=none
TEST=none
R=ben@chromium.org

Review URL: http://codereview.chromium.org/6992086

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86767 0039d316-1c4b-4281-b951-d872f2087c98

aa6752c9

Updating trunk VERSION from 776.0 to 777.0 · 57a67eb1
chrome-release@google.com authored May 26, 2011
```
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86766 0039d316-1c4b-4281-b951-d872f2087c98
```
57a67eb1

Allow overriding WebUIFactory when test flag is set. · 0f03bcee

scr@chromium.org authored May 26, 2011

In order to allow mocking function calls as soon as possible (before any javascript is
run), we create a factory capable of registering overrides per-host.

BUG=82437
R=estade@chromium.org
TEST=browser_tests --gtest_filter=TestChromeWebUIFactoryTest.*


Review URL: http://codereview.chromium.org/6992019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86764 0039d316-1c4b-4281-b951-d872f2087c98

0f03bcee

Widen suppression · 2808c2bc

oshima@google.com authored May 26, 2011

TBR=sergeyu@chromium.org
BUG=83949
TEST=none

Review URL: http://codereview.chromium.org/6976015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86763 0039d316-1c4b-4281-b951-d872f2087c98

2808c2bc

Handler settings page. · 365dd5b9

koz@chromium.org authored May 26, 2011

This change implements a settings page that allows users to manage protocol
handlers registered via navigator.registerProtocolHandler.

tony: could you review the ProtocolHandlerRegistry stuff?
estade: could you review the webui stuff?

Thanks!

TEST=Unit tests provided.

Review URL: http://codereview.chromium.org/7033018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86762 0039d316-1c4b-4281-b951-d872f2087c98

365dd5b9

fix clang · b12f6391

wjia@google.com authored May 26, 2011

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7062011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86761 0039d316-1c4b-4281-b951-d872f2087c98

b12f6391

Modifying a download test to wait until download is completed. · bb724614

sunandt@google.com authored May 26, 2011

BUG=83942
TEST=downloads.DownloadsTest.testDownloadsPersistence
Review URL: http://codereview.chromium.org/6992090

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86760 0039d316-1c4b-4281-b951-d872f2087c98

bb724614

In PageClickTracker: · 772e38b0

dpanpong@google.com authored May 26, 2011

As soon as we start to handle an event, filter against the type of
nodes we care about (only text fields), rather than waiting to filter
in DidHandleMouseEvent().

Otherwise, PageClickTracker could hold a reference to the node until the
next mouse event, potentially keeping the node alive for longer than
necessary.

Review URL: http://codereview.chromium.org/7064012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86759 0039d316-1c4b-4281-b951-d872f2087c98

772e38b0

Add VideoCaptureImpl and VideoCaptureImplManager · ae70b1aa

wjia@google.com authored May 26, 2011

BUG=none
TEST=try bots
Review URL: http://codereview.chromium.org/6902166

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86758 0039d316-1c4b-4281-b951-d872f2087c98

ae70b1aa

WebKit roll 87314:87341. · 38eacdfe

adamk@chromium.org authored May 26, 2011

Removes now-upstreamed test_expectations updates.

TBR=ukai@chromium.org

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86757 0039d316-1c4b-4281-b951-d872f2087c98

38eacdfe

Rename Chromoting webapp to "Remoting". · a1115990

garykac@chromium.org authored May 26, 2011

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/6979025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86756 0039d316-1c4b-4281-b951-d872f2087c98

a1115990

Enable cross-filesystem moves and copies. · 81b7f667

ericu@chromium.org authored May 26, 2011

BUG=none
TEST=unit tests included; I also tested locally with a cross-filesystem-sync-copy layout test [that I'll add to webkit later], both with and without obfuscation.

Review URL: http://codereview.chromium.org/7066033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86755 0039d316-1c4b-4281-b951-d872f2087c98

81b7f667

Enabling pyauto tests involving PDF. · 03b11bc8

sunandt@google.com authored May 26, 2011

BUG=83763
TEST=pdf.PDFTest.testPDFRunner, find_in_page.FindMatchTests.testSearchInPDF
Review URL: http://codereview.chromium.org/6987035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86754 0039d316-1c4b-4281-b951-d872f2087c98

03b11bc8

Mac. Build bookmark tooltips more intelligently, not showing title if same as URL. · 26848cb1

maf@chromium.org authored May 26, 2011

Refactor tooltip string code to remove duplication.
R=mrossetti@chromium.org
BUG=70709
Review URL: http://codereview.chromium.org/6979021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86753 0039d316-1c4b-4281-b951-d872f2087c98

26848cb1