GitLab

The EtwTraceConsumerRealtimeTest test fixture subclass contained a second instance of the
test_provider_ member variable. This occluded the initialized superclass instance's variable
and led to the test relying on uninitialized data.

BUG=127671
TEST=Unittests pass on Vista.


Review URL: https://chromiumcodereview.appspot.com/10386141

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137129 0039d316-1c4b-4281-b951-d872f2087c98

Rename tests_run to test_isolation_mode.

TBR=mad@chromium.org
BUG=98636
TEST=
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/10392073

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137127 0039d316-1c4b-4281-b951-d872f2087c98

Show credit card icons for the new Autofill Gtk popup.


BUG=51644
TEST=


Review URL: https://chromiumcodereview.appspot.com/10396003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137126 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137125 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10381153

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137124 0039d316-1c4b-4281-b951-d872f2087c98

Depends on https://bugs.webkit.org/show_bug.cgi?id=85976.
This is used by chrome on android.

BUG=
TEST=


Review URL: https://chromiumcodereview.appspot.com/10388045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137123 0039d316-1c4b-4281-b951-d872f2087c98

rateInMilliseconds should be rate_in_milliseconds.

BUG=Style
TEST=Existing


Review URL: https://chromiumcodereview.appspot.com/10381148

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137122 0039d316-1c4b-4281-b951-d872f2087c98

It's the only plausible cause for UserManagerTest.RemoveAllExceptOwnerFromList failures.

BUG=None
TEST=Tree becomes greener.
TBR=bartfab@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10377147

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137121 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137120 0039d316-1c4b-4281-b951-d872f2087c98

It broke Chromium OS test bots:
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/3668

BUG=None
TEST=None
TBR=tkent@chromium.org, jianli@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10382173

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137119 0039d316-1c4b-4281-b951-d872f2087c98

The problem with the current component build is that chrome.exe and setup.exe only know to look for DLLs like base.dll in the current directory (except chrome.dll for which they're hardcoded to know where to look). On an install those DLLs are in the version directory so chrome.exe and setup.exe fail to run not finding required DLLs...

To fix this we generate config files (to point in the version directory) and manifests (to list all the DLL dependencies explicitly) to be installed  beside the exes.

Each DLL also has a manifest in the version directory to give it an "assemblyIdentity" (i.e. a unique name which is referred to as a dependency by each exe's manifest).

In order for external manifests to work, embedded manifests had to be disabled for component builds (otherwise Windows ignores the external one).

Since embedded manifests are disabled and the generated manifests are only generated in the archive to be extracted at install-time. This CL also adds a copy step for the usually embedded manifests to be dropped in the build directory so that chrome.exe and setup.exe are usable from there without requiring an install.

This doesn't make mini_installer.exe compatible with the component build yet (as mini_installer runs setup.exe right after extracting it and without any other DLLs/manifests beside it).

However it is now possible to use setup.exe (which takes the exact same parameters as mini_installer.exe) from the build output directory with a component build :)!!!

BUG=127233
TEST=Turn on component build with gyp config "component=shared_libary" and make sure we can install chrome with setup.exe.
Make sure we can run the installed Chrome.
Make sure we can uninstall the installed Chrome (i.e. that setup.exe in <version_dir>/Installer is able to find its DLLs).

Review URL: https://chromiumcodereview.appspot.com/9701050

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137118 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137116 0039d316-1c4b-4281-b951-d872f2087c98

TBR=danno@chromium.org

BUG=
TEST=


Review URL: https://chromiumcodereview.appspot.com/10392103

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137115 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137114 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=jianli@chromium.org


Review URL: https://chromiumcodereview.appspot.com/10310165

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137113 0039d316-1c4b-4281-b951-d872f2087c98

And while I'm here rename item_at to GetItemAt. I think this is more consistent
with AddAt, DeleteAt, etc.

TEST=ui_unittests --gtest_filter=ListModel*
R=xiyuan@chromium.org
TBR=sky@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10386118

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137112 0039d316-1c4b-4281-b951-d872f2087c98

When Chrome is restarted after a crash, it needs to determine whether the user is logged in as ephemeral. This can be done by checking whether the user is found on the persistent list in local store.

BUG=127230
TEST=Log in as ephemeral, turn off ephemeral users, induce a crash:
TEST=Chrome now correctly determines that the user is still ephemeral

Review URL: https://chromiumcodereview.appspot.com/10382086

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137111 0039d316-1c4b-4281-b951-d872f2087c98

With this cl a WebKitMediaStreamDescriptor holds a scoped_refptr to the native implementation of MediaStreams.
This simplifies the glue code and allows us to hook up events from MediaStreamCenter to the correct native MediaStream.


BUG=
TEST= unit tests and https://apprtc.appspot.com

Review URL: https://chromiumcodereview.appspot.com/10383151

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137110 0039d316-1c4b-4281-b951-d872f2087c98

BUG=113688
TEST=BrowsingDataCookieHelperTest*

Review URL: https://chromiumcodereview.appspot.com/10092013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137109 0039d316-1c4b-4281-b951-d872f2087c98

BUG=128144
TEST=

Review URL: https://chromiumcodereview.appspot.com/10399024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137107 0039d316-1c4b-4281-b951-d872f2087c98

BUG=127251
TEST=Manual test.

Review URL: https://chromiumcodereview.appspot.com/10384179

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137103 0039d316-1c4b-4281-b951-d872f2087c98

[File Manager] Add/remove Google Drive folder in the open File Manager when Drive enabled/disabled in settings

BUG=127626
TEST=

Review URL: https://chromiumcodereview.appspot.com/10391103

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137102 0039d316-1c4b-4281-b951-d872f2087c98

BUG=127031,127184
TEST="Searchbox is cleared when user presses Esc or clicks an X on the right ride of the box."
Review URL: https://chromiumcodereview.appspot.com/10386139

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137101 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=linux_chromeos bots turn green

Review URL: https://chromiumcodereview.appspot.com/10332170

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137100 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137095 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137093 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=jianli@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10381144

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137092 0039d316-1c4b-4281-b951-d872f2087c98

BUG=103711
TEST=tsan-mac bot
TBR=jhawkins
Review URL: https://chromiumcodereview.appspot.com/10387126

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137090 0039d316-1c4b-4281-b951-d872f2087c98

BUG=80654
TEST=Heapcheck bots
TBR=jhawkins
Review URL: https://chromiumcodereview.appspot.com/10332168

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137089 0039d316-1c4b-4281-b951-d872f2087c98

BUG=128145
TEST=memory.fyi waterfall
TBR=jhawkins
Review URL: https://chromiumcodereview.appspot.com/10403002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137087 0039d316-1c4b-4281-b951-d872f2087c98

++++ REVERT NOTICE ++++

Broke update phase on all pyauto chromium bots.
See one at:
http://build.chromium.org/p/chromium.pyauto/builders/Linux%20%28deb%29/builds/33094/steps/update/logs/stdio

+++++++++++++++++++++++

Selectively disabling precompiled headers for release builds with msvs2010
Precompiled headers seem to interact badly with auto-sharding using the
msvs_shard option.

BUG=http://code.google.com/p/chromium/issues/detail?id=127875
TEST=builds on trybots.
R=kerz@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10392091

TBR=bradnelson@google.com
Review URL: https://chromiumcodereview.appspot.com/10402002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137085 0039d316-1c4b-4281-b951-d872f2087c98

Selectively disabling precompiled headers for release builds with msvs2010
Precompiled headers seem to interact badly with auto-sharding using the
msvs_shard option.

BUG=http://code.google.com/p/chromium/issues/detail?id=127875
TEST=builds on trybots.
R=kerz@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10392091

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137083 0039d316-1c4b-4281-b951-d872f2087c98

Added browser_action_pinned extension preference and modified BrowserActionContainer to show extensions based on it.

BUG=125307
TEST=make sure you have extensions that show icon in browser action area; add --enable_action_box to command line; make sure browser doesn't show any extensions in browser actions area; go to extensions setting, try show/hide extensions

Review URL: https://chromiumcodereview.appspot.com/10378117

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137081 0039d316-1c4b-4281-b951-d872f2087c98

This fixes a regression from http://crrev.com/135984.
The reversed result parsing unintentionally left the nav results unsorted.
Suggest results are unaffected, as they're all added to map and sorted.

Subsequent CLs should help make this whole process cleaner.

BUG=125871
TEST=Automated. Also, the *first* NAVIGATION result from suggest JSON is used as a SearchProvider match.

Review URL: https://chromiumcodereview.appspot.com/10381121

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137080 0039d316-1c4b-4281-b951-d872f2087c98

and convert the GTK code to use it (mac/views come next).

This is for the currentTab permission work where the page action area will
be used to display icons for extensions with scripts running on the current
page ("script badges"), and will also need to have various different UIs for
them (hence the "decoration" stuff). To implement this I plan on injecting
a different BadgeController implementation given a command line flag for the
new behaviour.

BUG=127988

Review URL: https://chromiumcodereview.appspot.com/10381105

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137079 0039d316-1c4b-4281-b951-d872f2087c98

Logout automation used to apply the IDC_EXIT accelerator to the first
browser window. This would not work in the case of aura if no browser
windows are present.

Fix automation to use ash system tray calls.

BUG=chromium:127859
TEST=new pyauto test: chromeos_login.ChromeosLogin.testLogoutWithNoWindows

R=sadrul@chromium.org


Review URL: https://chromiumcodereview.appspot.com/10388107

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137078 0039d316-1c4b-4281-b951-d872f2087c98

This makes fullscreen RWHVAs close themselves when they lose
the focus; unlike NPAPI Flash, Pepper Flash doesn't close
automatically on blur.

BUG=123083
TEST=manual: alt-tab or escape exits fullscreen flash


Review URL: https://chromiumcodereview.appspot.com/10377066

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137077 0039d316-1c4b-4281-b951-d872f2087c98

Bug=124566
Test=Compiles on CrOS,Mac

Review URL: https://chromiumcodereview.appspot.com/10378009

TBR=pkotwicz@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10332163

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137076 0039d316-1c4b-4281-b951-d872f2087c98

Bug=124566
Test=Compiles on CrOS,Mac

Review URL: https://chromiumcodereview.appspot.com/10378009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137075 0039d316-1c4b-4281-b951-d872f2087c98

This sets a flag in didAutoResize() that
didCompleteSwapBuffers() inspects when deciding whether to
send an UpdateRect message or not.  Without this, extension
bubbles aren't getting resized correctly when using the
threaded compositor.

BUG=120247
TEST=manual: "Google Calendar (by Google)" and "Google +1 Button" extensions' bubbles resize to fit their content on Chrome OS


Review URL: https://chromiumcodereview.appspot.com/10399020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137073 0039d316-1c4b-4281-b951-d872f2087c98