GitLab

Revert of Omnibox: Combine Two Input Type Enums into One (https://codereview.chromium.org/319523005/)

Reason for revert:
Broke the build on http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Mac

Original issue's description:
> Omnibox: Combine Two Input Type Enums into One
> 
> There are two input type enums:
> * one in the autocomplete code
> * one in the metrics code that's used for UMA logging;
>   this one is meant to remain stable
> 
> As part of fixing the linked bug, I created
> https://codereview.chromium.org/314773002/
> whch needed an input type enum, one which would remain stable.
> It didn't necessarily have to be the metrics enum.
> 
> After discussion with the UMA folks (who deal with how to handle
> stable enum problems all the time), we reached the conclusion
> that we should have one stable enum and use it everywhere.  That's
> the cleanest answer.
> 
> This single enum has to live in the metrics directory because metrics
> is a component.
> 
> This change combines the two existing enums into one, putting the
> new enum in a new file in the metrics directory.  The reason for
> a new file is so we can include it without include the whole
> OmniboxEventProto or any other metrics code.
> 
> The main files to review are autocomplete_input.h and *.proto.
> All other changes are a mechanical result of the changes in
> those three files.
> 
> The internal proto change has been submitted.
> 
> TBR=stevenjb
> for the trivial change to chrome/browser/ui/app_list/search/omnibox_provider.cc
> that removes an unnecessary include
> 
> BUG=284781
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275696

TBR=pkasting@chromium.org,isherman@chromium.org,mpearson@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=284781

Review URL: https://codereview.chromium.org/320713002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275706 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275705 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=175750:175751&mode=html

TBR=yhirano@chromium.org

Review URL: https://codereview.chromium.org/325613002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275704 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275703 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=175719:175750&mode=html

TBR=yhirano@chromium.org

Review URL: https://codereview.chromium.org/322673002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275702 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275701 0039d316-1c4b-4281-b951-d872f2087c98

All platforms use autofill profiles, which use libaddressinput.

TBR=estade@chromium.org
BUG=327046

Review URL: https://codereview.chromium.org/319373003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275700 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Revert of [Telemetry] Overhaul startup metric. (https://codereview.chromium.org/317743003/)

Reason for revert:
Blocking patches are landed now.

Original issue's description:
> Revert of [Telemetry] Overhaul startup metric. (https://codereview.chromium.org/313993003/)
> 
> Reason for revert:
> Other patches need to land before this. This broke bots.
> 
> Original issue's description:
> > [Telemetry] Overhaul startup metric.
> > 
> > This focuses us on the user-perceived aspects of startup.
> > 
> > BUG=
> > 
> > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275194
> 
> TBR=aiolos@chromium.org,jeremy@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275345

TBR=aiolos@chromium.org,jeremy@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/319393003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275699 0039d316-1c4b-4281-b951-d872f2087c98

BUG=350898

Review URL: https://codereview.chromium.org/317203004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275698 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none

Review URL: https://codereview.chromium.org/323633002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275697 0039d316-1c4b-4281-b951-d872f2087c98

There are two input type enums:
* one in the autocomplete code
* one in the metrics code that's used for UMA logging;
  this one is meant to remain stable

As part of fixing the linked bug, I created
https://codereview.chromium.org/314773002/
whch needed an input type enum, one which would remain stable.
It didn't necessarily have to be the metrics enum.

After discussion with the UMA folks (who deal with how to handle
stable enum problems all the time), we reached the conclusion
that we should have one stable enum and use it everywhere.  That's
the cleanest answer.

This single enum has to live in the metrics directory because metrics
is a component.

This change combines the two existing enums into one, putting the
new enum in a new file in the metrics directory.  The reason for
a new file is so we can include it without include the whole
OmniboxEventProto or any other metrics code.

The main files to review are autocomplete_input.h and *.proto.
All other changes are a mechanical result of the changes in
those three files.

The internal proto change has been submitted.

TBR=stevenjb
for the trivial change to chrome/browser/ui/app_list/search/omnibox_provider.cc
that removes an unnecessary include

BUG=284781

Review URL: https://codereview.chromium.org/319523005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275696 0039d316-1c4b-4281-b951-d872f2087c98

BUG=315312
TEST=Test pages still work.

Review URL: https://codereview.chromium.org/315733003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275695 0039d316-1c4b-4281-b951-d872f2087c98

BUG=381934
R=msw

Review URL: https://codereview.chromium.org/325563002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275694 0039d316-1c4b-4281-b951-d872f2087c98

The original BlueZ GATT API doc spec used DBus.Properties interface for
characteristic value access. Since we are modifying this API for Chrome OS,
this CL updates the Chrome D-Bus bindings and modifies the device/bluetooth
GATT code to use the new bindings for characteristic value reads, writes, and
updates.

BUG=378182
TEST=Tested against my custom bluetoothd build; device_unittests

Review URL: https://codereview.chromium.org/301093003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275693 0039d316-1c4b-4281-b951-d872f2087c98

TBR=vrk@chromium.org, posciak@chromium.org

Review URL: https://codereview.chromium.org/322483006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275692 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/318253002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275690 0039d316-1c4b-4281-b951-d872f2087c98

TBR=dtu@chromium.org
NOTRY=True
BUG=

Review URL: https://codereview.chromium.org/323703003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275689 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Remove the id field of inspector_backend since no public caller uses it (https://codereview.chromium.org/322553003/)

Reason for revert:
Apparently it was used somewhere:

http://chromegw/i/chromium.perf/builders/Android%20GN%20Perf/builds/1776/steps/blink_perf/logs/stdio

Traceback (most recent call last):
  _RunPage at tools/telemetry/telemetry/page/page_runner.py:521
    page_state.ImplicitPageNavigation(test)
  ImplicitPageNavigation at tools/telemetry/telemetry/page/page_runner.py:175
    test.RunNavigateSteps(self.page, self.tab)
  RunNavigateSteps at tools/telemetry/telemetry/page/page_test.py:259
    page.RunNavigateSteps(action_runner)
  RunNavigateSteps at tools/telemetry/telemetry/page/page.py:42
    action_runner.NavigateToPage(self)
  NavigateToPage at tools/telemetry/telemetry/page/actions/action_runner.py:63
    self.RunAction(NavigateAction(attributes))
  RunAction at tools/telemetry/telemetry/page/actions/action_runner.py:20
    action.RunActionAndMaybeWait(self._tab)
  RunActionAndMaybeWait at tools/telemetry/telemetry/page/actions/page_action.py:37
    self.RunAction(tab)
  RunAction at tools/telemetry/telemetry/page/actions/navigate.py:22
    tab.Navigate(self.url, script_to_evaluate_on_commit)
  Navigate at tools/telemetry/telemetry/core/tab.py:257
    self._inspector_backend.Navigate(url, script_to_evaluate_on_commit, timeout)
  Navigate at tools/telemetry/telemetry/core/backends/chrome/inspector_backend.py:161
    self._page.Navigate(url, script_to_evaluate_on_commit, timeout)
  Navigate at tools/telemetry/telemetry/core/backends/chrome/inspector_page.py:109
    self.WaitForNavigate(timeout)
  WaitForNavigate at tools/telemetry/telemetry/core/backends/chrome/inspector_page.py:85
    self._inspector_backend.DispatchNotifications(remaining_time)
  DispatchNotifications at tools/telemetry/telemetry/core/backends/chrome/inspector_websocket.py:68
    self._Receive(timeout)
  _Receive at tools/telemetry/telemetry/core/backends/chrome/inspector_websocket.py:108
    self._error_handler(elapsed_time)
  _HandleError at tools/telemetry/telemetry/core/backends/chrome/inspector_backend.py:238
    if self._IsInspectable():
  _IsInspectable at tools/telemetry/telemetry/core/backends/chrome/inspector_backend.py:215
    return self.id in [c['id'] for c in contexts]
AttributeError: 'InspectorBackend' object has no attribute 'id'

Locals:
  contexts : [{u'url': u'http://127.0.0.1:48700/XMLHttpRequest/send.html', u'title': u'127.0.0.1:48700/XMLHttpRequest/send.html', u'type': u'page', u'description': u'', u'id': u'432A3A74-D6DE-77B0-9358-3780FA59FA70'}]


Original issue's description:
> Remove the id field of inspector_backend since no public caller uses it
> 
> TBR=nduca@chromium.org
> 
> BUG=
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275541

TBR=nednguyen@google.com
NOTREECHECKS=true
NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/323713002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275688 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275682 0039d316-1c4b-4281-b951-d872f2087c98

BUG=245436

Review URL: https://codereview.chromium.org/319133002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275680 0039d316-1c4b-4281-b951-d872f2087c98

This dialog is very usable and is ready to be enabled by default to get
wider exposure.

BUG=266739

Review URL: https://codereview.chromium.org/312423004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275679 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Telemetry: Last ditch effort to dump symbols on tab crashes if none are found (https://codereview.chromium.org/318123002/)

Reason for revert:
page_runner_unittest.PageRunnerTests.testHandlingOfCrashedTab is failing on the main waterfall after this change:

http://build.chromium.org/p/chromium.mac/builders/Mac10.6%20Tests%20%283%29/builds/48907

http://build.chromium.org/p/chromium.mac/builders/Mac10.7%20Tests%20%283%29/builds/27652

http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/11451

Original issue's description:
> Telemetry: Last ditch effort to dump symbols on tab crashes if none are found
> 
> Put this together to find a crash which only happened on telemetry unittest runs on Mac trybots; figured it might be useful for later too.
> 
> R=dtu,tonyg
> BUG=
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275675

TBR=dtu@chromium.org,tonyg@chromium.org,oysteine@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/320693002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275678 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
R=sky@chromium.org

Review URL: https://codereview.chromium.org/321553004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275677 0039d316-1c4b-4281-b951-d872f2087c98

This change makes the Managed Bookmarks folder visible in the bookmarks
bar if it contains at least one bookmark:

- this folder is always shown floating to the left, next to the Apps button;
- this folder also appears in the bookmarks menu from the hotdog menu, as if
  it were part of the bookmarks bar;
- bookmarks can't be dragged into this folder or any of its subfolders;
- dragging bookmarks out of this folder always creates a new copy and never
  moves (the mouse cursor is decorated with the + "copy" indicator);
- the bookmark editor can't select managed folders for new bookmarks;
- bookmarks a page that already has a managed bookmarks creates a new
  bookmark instead.

BUG=49598
R=sky@chromium.org

Review URL: https://codereview.chromium.org/302313005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275676 0039d316-1c4b-4281-b951-d872f2087c98

Put this together to find a crash which only happened on telemetry unittest runs on Mac trybots; figured it might be useful for later too.

R=dtu,tonyg
BUG=

Review URL: https://codereview.chromium.org/318123002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275675 0039d316-1c4b-4281-b951-d872f2087c98

BUG=364141
Test=No visible change.

Review URL: https://codereview.chromium.org/299753011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275674 0039d316-1c4b-4281-b951-d872f2087c98

Use the same fake User-Agent string as GetContentShell()->GetUserAgent() for URLRequestContext in content_shell

ShellContentClient::GetUserAgent() returns a fake User-Agent. It's used
for navigator.userAgent, loading layout test test case file, etc. But
ShellURLRequestContextGetter has an HttpUserAgentSettings with an empty
string for User-Agent. Factor out the code to build the fake User-Agent
from ShellContentClient::GetUserAgent() into GetShellUserAgent() and use
it for ShellURLRequestContextGetter. This is almost the same as how
ChromeShellContentClient and ChromeURLRequestContextGetter are doing.

With this, we can test that WebSocket handshake request contains the
correct user-agent header value.

BUG=347109

Review URL: https://codereview.chromium.org/319083003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275673 0039d316-1c4b-4281-b951-d872f2087c98

BUG=380839
R=meacer, jww

Review URL: https://codereview.chromium.org/314283003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275672 0039d316-1c4b-4281-b951-d872f2087c98

We add the list of tab's markers to traces as metadata and later reconstruct the maps from tab markers to renderer thread in trace_event_importer. This makes it possible to reconstruct the timeline model with the mapping between tabs & renderer threads from the raw json tracing data. 

BUG=

Review URL: https://codereview.chromium.org/309533016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275671 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/319953002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275670 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Revert of Merge VideoDecodeAcceleratorImpl with VideoDecodeAccelerator (https://codereview.chromium.org/319323002/)

Reason for revert:
Relanding since the failure appears to be unrelated.

Original issue's description:
> Revert of Merge VideoDecodeAcceleratorImpl with VideoDecodeAccelerator (https://codereview.chromium.org/317083003/)
> 
> Reason for revert:
> Speculative revert to fix content_unittest failures in http://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/20807
> 
> Original issue's description:
> > Merge VideoDecodeAcceleratorImpl with VideoDecodeAccelerator
> > 
> > This moves the single method CanDecodeOnIOThread on
> > VideoDecodeAcceleratorImpl to VideoDecodeAccelerator. The
> > implementations that were subclasses of VideoDecodeAcceleratorImpl now
> > get an override for CanDecodeOnIOThread that returns false.
> > 
> > TEST=linux desktop build
> > BUG=380884
> > 
> > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275621
> 
> TBR=scherkus@chromium.org,fischman@chromium.org,spang@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=380884
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275636

TBR=scherkus@chromium.org,fischman@chromium.org,spang@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=380884

Review URL: https://codereview.chromium.org/318243002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275669 0039d316-1c4b-4281-b951-d872f2087c98

BUG=380973
TEST=n/a

Review URL: https://codereview.chromium.org/313273003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275668 0039d316-1c4b-4281-b951-d872f2087c98

The test hasn't failed since I submitted my fix.

BUG=379170
TBR=sky

Review URL: https://codereview.chromium.org/312093006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275667 0039d316-1c4b-4281-b951-d872f2087c98

BUG=335192

Review URL: https://codereview.chromium.org/319573006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275666 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275665 0039d316-1c4b-4281-b951-d872f2087c98

Picks up a single change:
r275589 - Add PK11_MakeIDFromPubKey to windows exports

BUG=378315, 245025

Review URL: https://codereview.chromium.org/321643002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275664 0039d316-1c4b-4281-b951-d872f2087c98

Upon duplicated ACKs for a frame the previous behavior was to resend
all packets of the first unacked frame. It was shown in reports that it
is excessive. Instead this change sends the first packet of the last
encoded frame. This significantly reduces the amount of packet
re-transmitted.

PacketStorage is also redesigned in this code. It is now a simple deque
instead of a map.

Review URL: https://codereview.chromium.org/317243007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275663 0039d316-1c4b-4281-b951-d872f2087c98

Protect |active_paths| from garbage collection even when they are not direct subdirectories of |storage_root|.

BUG=328637

Review URL: https://codereview.chromium.org/314293003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275662 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275661 0039d316-1c4b-4281-b951-d872f2087c98

This roll fixes support for Crop* attributes.

BUG=321825
TBR=tomfinegan@chromium.org

Review URL: https://codereview.chromium.org/324553002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275660 0039d316-1c4b-4281-b951-d872f2087c98