- 30 Mar, 2017 18 commits
 - 
- 
Jeff Carpenter authored
Bug: 705561, 693821 Change-Id: I682573698ac7c053c44962846744c510b88f4e18 Reviewed-on: https://chromium-review.googlesource.com/462042 Commit-Queue: Jeff Carpenter <jeffcarp@chromium.org> Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#460603}
 - 
jamescook authored
Same person, just the account name changed. BUG=none TEST=none Review-Url: https://codereview.chromium.org/2780183003 Cr-Commit-Position: refs/heads/master@{#460602}
 - 
dgozman authored
It exposes DOMModel already, there is no need for the target. There is also no need to extend from Common.Object, have an extra field for nothing and provide event listening capabilities. BUG=none Review-Url: https://codereview.chromium.org/2778283002 Cr-Commit-Position: refs/heads/master@{#460601}
 - 
caseq authored
Here comes another small batch of coverage UX fixes. BUG=697599 Review-Url: https://codereview.chromium.org/2784993002 Cr-Commit-Position: refs/heads/master@{#460600}
 - 
dgozman authored
This also allows to use <label for='..'> and removes manual click events. BUG=none Review-Url: https://codereview.chromium.org/2776263006 Cr-Commit-Position: refs/heads/master@{#460599}
 - 
jbauman authored
Ensure that the compositor draws these correctly. BUG=704389 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2769063006 Cr-Commit-Position: refs/heads/master@{#460598}
 - 
fsamuel authored
If the window type is EMBED_IN_OWNER, or TOP_LEVEL_IN_WM, then allocate a cc::LocalSurfaceId on size change and propagate that new LocalSurfaceId down to the WindowTreeHost of the embedded client. The embedded client will use that LocalSurfaceId to submit CompositorFrames. If surface synchronization is enabled (subsequent patch), then the embedder can immediately embed the surface ID (if the FrameSinkId is available), and submit its own CompositorFrame with that embedding. The parent's CompositorFrame will block until the embedded client submits a CompositorFrame or a deadline is hit. BUG=672962 Review-Url: https://codereview.chromium.org/2780043002 Cr-Commit-Position: refs/heads/master@{#460597}
 - 
lushnikov authored
This patch starts to cleanup CSS sourcemaps as they get detached from host stylesheets. BUG=670180 R=dgozman Review-Url: https://codereview.chromium.org/2779703004 Cr-Commit-Position: refs/heads/master@{#460596}
 - 
cblume authored
third_party/WebKit/Source/platform/wtf/PassRefPtr.h has a typo on line 47: https://cs.chromium.org/chromium/src/third_party/WebKit/Source/platform/wtf/PassRefPtr.h?dr=CSs&l=47 "ReftPtr" R=esprehn@chromium.org BUG=706566 Review-Url: https://codereview.chromium.org/2780903005 Cr-Commit-Position: refs/heads/master@{#460595}
 - 
tommycli authored
Currently, when collapsing a section, to another route that is part of a section, we scroll to the new section. This is not desirable for direct subpage->subpage navigations. This CL limits that scroll behavior to only when navigating to a section route (and not when navigating to a subpage route). BUG=705927 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2777013006 Cr-Commit-Position: refs/heads/master@{#460594}
 - 
dominicc authored
Local changes which were fixed upstream: Issue 676623 Fixed upstream with https://git.gnome.org/browse/libxslt/commit/?id=08ab2774b870de1c7b5a48693df75e8154addae5 Issue 670720 The norm:localTime extension function was removed with the following commit: https://git.gnome.org/browse/libxslt/commit/?id=b9d63e5f53c29be83f72849e4ac93bb42f737b9b BUG=705944 Review-Url: https://codereview.chromium.org/2777943003 Cr-Commit-Position: refs/heads/master@{#460593}
 - 
rkjnsn authored
PolicyWatcher::Create automatically creates an underlying AsyncPolicyLoader corresponding to the policy storage location of the current platform. This commit adds an alternative constructor, CreateFromPolicyLoaderForTesting, which allows a custom AsyncPolicyLoader to be specified to allow testing other components with different policy configurations. Review-Url: https://codereview.chromium.org/2764333003 Cr-Commit-Position: refs/heads/master@{#460592}
 - 
pdr authored
This patch starts using fast malloc (aka partition alloc) for the following paint-related data structures: PaintInfo PaintLayerRareData PaintArtifactCompositor GeometryMapper GeometryMapperClipCache GeometryMapperTransformCache PropertyTreeState For more information about USING_FAST_MALLOC, see the Allocator.md docs. Review-Url: https://codereview.chromium.org/2783913002 Cr-Commit-Position: refs/heads/master@{#460591}
 - 
rch authored
QUIC HTTP stream, by centralizing the logic into a single method. Review-Url: https://codereview.chromium.org/2777333002 Cr-Commit-Position: refs/heads/master@{#460590}
 - 
dgozman authored
With new fromSurface parameter, this should work on all OSes. BUG=638281 Review-Url: https://codereview.chromium.org/2773173002 Cr-Commit-Position: refs/heads/master@{#460589}
 - 
alph authored
Review-Url: https://codereview.chromium.org/2782953002 Cr-Commit-Position: refs/heads/master@{#460588}
 - 
mrefaat authored
BUG=706486 Review-Url: https://codereview.chromium.org/2779363002 Cr-Commit-Position: refs/heads/master@{#460587}
 - 
laforge authored
Update min engagement_threshold_for_flash to 8, to match the external experiment for HTML5ByDefault. BUG=706532 Review-Url: https://codereview.chromium.org/2772343008 Cr-Commit-Position: refs/heads/master@{#460586}
 
 - 
 - 29 Mar, 2017 22 commits
 - 
- 
erikchen authored
The logic was accidentally double-counting the size of a memory region, causing some memory regions to get skipped. BUG=706547 Review-Url: https://codereview.chromium.org/2786733004 Cr-Commit-Position: refs/heads/master@{#460585}
 - 
rtoy authored
Interpret throw(undefined) to mean that an error of any type is expected. This is the same as throw(). BUG=706558 TEST=audit.html Review-Url: https://codereview.chromium.org/2783033002 Cr-Commit-Position: refs/heads/master@{#460584}
 - 
xzhou authored
ARC++ allows Android app to run on Chrome OS. It is necessary to change the behavior of Chrome on CrOS on handling apk and dex files. This CL prevents auto download apk and dex file on CrOS and also disallow auto open such files. BUG=694872 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2778283003 Cr-Commit-Position: refs/heads/master@{#460583}
 - 
tbansal authored
Make network quality estimator (NQE) params a class. Next CL will move the storing of the params to the Params class from the NQE class to make it simpler to query the params again and again. This CL does not make any functional change. BUG=705691 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester Review-Url: https://codereview.chromium.org/2775223004 Cr-Commit-Position: refs/heads/master@{#460582}
 - 
John Abd-El-Malek authored
This allows PlzNavigate to only pause fetching the request if it knows that the page has an onbeforeunload handler, where today it currently always goes to the renderer. This avoids delaying the network requests in the 95% cases that don't onbeforeunload handler on a process hop to the renderer. BUG=365039,705559 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation R=dcheng@chromium.org, nasko@chromium.org Review-Url: https://codereview.chromium.org/2783723002 . Cr-Commit-Position: refs/heads/master@{#460581}
 - 
gfhuang authored
Bug: internal b/36447710 Change-Id: I5db3d8203d7c7369a48bff45cbaf582a673c57b6 Review-Url: https://codereview.chromium.org/2786723002 Cr-Commit-Position: refs/heads/master@{#460580}
 - 
anthonyvd authored
BUG=697921 Review-Url: https://codereview.chromium.org/2782303002 Cr-Commit-Position: refs/heads/master@{#460579}
 - 
robertogden authored
BUG= Review-Url: https://codereview.chromium.org/2779973005 Cr-Commit-Position: refs/heads/master@{#460578}
 - 
danakj authored
Currently CompositorResizeLock doesn't work unless deferred since the base class tries to use a virtual method from its constructor which doesn't know about the subclass yet. This fixes that and makes the following changes in the process: I noticed that there are no longer any unit tests that depend on ResizeLock being an interface. So I made CompositorResizeLock the concrete type. I noticed that CompositorResizeLock was in located in files named compositor_resize_lock_aura.{h,cc} but is not named for aura anymore, and is in fact used in non-aura cases for mac. So I renamed the files, and moved the aura pieces out to DelegatedFrameHostClientAura. In order for DelegatedFrameHostClientAura to know when to release events however, it needs to know when the resize lock ends. So I introduced CompositorResizeLockClient, which tells when the lock is over. Importantly, the above is not the same as the CompositorLock ending. That can be done by calling CompositorResizeLock::UnlockCompositor, which does not end the resize lock, but does release the CompositorLock inside it. So this doesn't inform the client at that time until the resize lock actually ends. I've tried to make this more clear with function names and comments. In order to unit test everything I've pulled CompositorLock out of compositor.h and removed the friend relationships between Compositor and CompositorLock. To do so CompositorLock now has 2 interfaces: - CompositorLockClient which it informs about timeouts. This is so that CompositorResizeLock knows when its internal CompositorLock is released by timeout. - CompositorLockDelegate which performs actual unlocking. This is the ui::Compositor outside of tests. Lastly, CompositorResizeLock has a timeout, and CompositorLock has a timeout. These happen to be the same number tho CompositorResizeLock allows you to override it. I've combined these into a single timeout (with the help of CompositorLockClient). And will allow GetCompositorLock to request a specific timeout. With that, Compositor no longer needs SetLocksWillTimeOut which has some action-at-distance properties. This maintains the property that the first to grab a lock chooses the timeout for all other locks grabbed during that time, however Mac code which wants no timeouts now doesn't cause other parts of the system to also get no timeout unless the mac lock is currently active without a timeout. R=piman@chromium.org BUG=704928 NOTRY=true Review-Url: https://codereview.chromium.org/2773433003 Cr-Commit-Position: refs/heads/master@{#460577} - 
servolk authored
This new API is similar to IsSupportedVideoConfig and is strictly-typed unlike the old MediaCodecSupportShlib::IsSupported, which is going to be deprecated. Review-Url: https://codereview.chromium.org/2677143003 Cr-Commit-Position: refs/heads/master@{#460576}
 - 
rtoy authored
Manually converted these tests to use new Audit from old Audit. BUG=704967 TEST=Analyser/realtimeanalyser-byte-data.html Analyser/realtimeanalyser-downmix.html Analyser/realtimeanalyser-fftsize-reset.html Analyser/realtimeanalyser-float-data.html Analyser/realtimeanalyser-freq-data.html Analyser/realtimeanalyser-freq-data-smoothing.html Analyser/realtimeanalyser-multiple-calls.html Analyser/realtimeanalyser-zero.html Review-Url: https://codereview.chromium.org/2777983002 Cr-Commit-Position: refs/heads/master@{#460575}
 - 
rouslan authored
Before this change, selecting "Close all incognito windows" while Chrome was showing "You're leaving incognito mode" warning dialog will cause a crash. After this change, the crash is avoided. BUG=705844 Review-Url: https://codereview.chromium.org/2778193003 Cr-Commit-Position: refs/heads/master@{#460574}
 - 
jinsukkim authored
https://crbug.com/2697213002 (not guessing UTF8 encoding) doesn't have to be applied to local file resources. This CL makes such cases an exception to the policy. BUG=704800 Review-Url: https://codereview.chromium.org/2784483003 Cr-Commit-Position: refs/heads/master@{#460573}
 - 
esprehn authored
The id path inside SelectorQuery::findTraverseRootsAndExecute is not actually reachable for the right most selector since we handle that separately inside the top level ::execute() call. We also only ever take the fast path when rootNode.isConnected() (as checked by canUseFastPath) so we can use that too. By using these two truths inside this code we can simplify what it was doing and delete a bunch of the code. BUG=703900 Review-Url: https://codereview.chromium.org/2786763002 Cr-Commit-Position: refs/heads/master@{#460572}
 - 
xiyuan authored
This is caused by racing between mojo and non-mojo code path. The avater image is updated via SessionController mojo interface but UserObserver interface is still a direct call and could reach ash before the mojo message. The CL fixes the issue by replacing UserObserver interface with SessionController observer. BUG=704862 Review-Url: https://codereview.chromium.org/2780963002 Cr-Commit-Position: refs/heads/master@{#460571}
 - 
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/4a24e10a0b80..291932e8e42e $ git log 4a24e10a0..291932e8e --date=short --no-merges --format='%ad %ae %s' 2017-03-29 jvanverth Fix is_convex() check for inset polys. 2017-03-29 bsalomon Make analysis optional to GrPipeline::init(). 2017-03-28 egdaniel Remove blacklist of Vulkan GPUMemoryTest 2017-03-29 robertphillips More GrSurfaceProxy-clean up 2017-03-29 bungeman Use FontWeight symbols when available on Mac. 2017-03-29 robertphillips Miscellaneous GrSurfaceProxy-related cleanup 2017-03-29 bsalomon Remove GrPipelineOptimizations computation from GrPipeline::init and nest in GrMeshDrawOp. Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=stephana@chromium.org Change-Id: I31fc6a3812796d42b876424a56f6bc60ff95d892 Reviewed-on: https://chromium-review.googlesource.com/462516Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#460570}
 - 
stevenjb authored
This CL makes Settings specific changes to the 'Network' (was 'Internet conneciton') section. See issue for specs and screenshots. BUG=701945 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2752223003 Cr-Commit-Position: refs/heads/master@{#460569}
 - 
smut authored
BUG=705510 R=baxley@chromium.org Review-Url: https://codereview.chromium.org/2782023002 . Cr-Commit-Position: refs/heads/master@{#460568}
 - 
smut authored
This reverts commit 54548ddb. Reason for revert: Likely to have caused a significant regression in net_unittests cycle time, which is producing a long pending queue on ios-simulator, which in turn is blocking the entire commit queue. BUG=706609 TBR=baxley Review-Url: https://codereview.chromium.org/2779213004 . Cr-Commit-Position: refs/heads/master@{#460567}
 - 
ccameron authored
Create a separate sequence number for GLImages created from CVPixelBufferRefs (previously they had no sequence number, so they would alias each other). Make VTVideoDecodeAccelerator be a dump provider. This dumps through the GLImage interface, and so it will correctly link the CVPixelBufferRefs that with the command buffer textures. Fix TextureManager's dump code to not assume that GLImage presence and texture state BOUND are related (a texture can have a GLImage but not be BOUND because it can't be textured out of directly). BUG=704792 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2771923006 Cr-Commit-Position: refs/heads/master@{#460566}
 - 
chaopeng authored
In this patch, remove right stroke for vertical scrollbar, remove bottom stroke for horizontal scrollbar and flip the scrollbar canvas to remove left stroke for left vertical scrollbar. BUG=669673 Review-Url: https://codereview.chromium.org/2763373002 Cr-Commit-Position: refs/heads/master@{#460565}
 - 
noel authored
The extensions/common/extension_utility_messages.h message file was deleted in http://crrev.com/460280 Its corresponding IPC START entry ExtensionUtilityMsgStart is not needed either, so we can remove it. BUG=691410 Review-Url: https://codereview.chromium.org/2785463003 Cr-Commit-Position: refs/heads/master@{#460564}
 
 -