- 25 Sep, 2018 40 commits
-
-
Ulan Degenbaev authored
Currently we have two V8 memory metrics: - Memory.Experimental.Renderer2.V8, - Memory.Experimental.Renderer2.V8.AllocatedObjects This patch adds memory metrics of - the main isolate of V8, - the heap spaces in the main isolate of V8, - the malloced memory in the main isolate of V8, - worker isolates of V8. Note that the heap spaces and the malloced memory of worker isolates are omitted. Privacy review doc: https://goo.gl/X5eYHh List of all new metrics: - Memory.Experimental.Renderer2.V8.Main, - Memory.Experimental.Renderer2.V8.Main.AllocatedObjects, - Memory.Experimental.Renderer2.V8.Main.Heap, - Memory.Experimental.Renderer2.V8.Main.Heap.AllocatedObjects, - Memory.Experimental.Renderer2.V8.Main.Heap.CodeSpace, - Memory.Experimental.Renderer2.V8.Main.Heap.CodeSpace.AllocatedObjects, - Memory.Experimental.Renderer2.V8.Main.Heap.LargeObjectSpace, - Memory.Experimental.Renderer2.V8.Main.Heap.LargeObjectSpace.AllocatedObjects, - Memory.Experimental.Renderer2.V8.Main.Heap.MapSpace, - Memory.Experimental.Renderer2.V8.Main.Heap.Map.AllocatedObjects, - Memory.Experimental.Renderer2.V8.Main.Heap.NewLargeObjectSpace, - Memory.Experimental.Renderer2.V8.Main.Heap.NewLargeObjectSpace.AllocatedObjects, - Memory.Experimental.Renderer2.V8.Main.Heap.NewSpace, - Memory.Experimental.Renderer2.V8.Main.Heap.NewSpace.AllocatedObjects, - Memory.Experimental.Renderer2.V8.Main.Heap.OldSpace, - Memory.Experimental.Renderer2.V8.Main.Heap.OldSpace.AllocatedObjects, - Memory.Experimental.Renderer2.V8.Main.Heap.ReadOnlySpace, - Memory.Experimental.Renderer2.V8.Main.Heap.ReadOnlySpace.AllocatedObjects, - Memory.Experimental.Renderer2.V8.Main.Malloc - Memory.Experimental.Renderer2.V8.Workers, - Memory.Experimental.Renderer2.V8.Workers.AllocatedObjects, Bug: 852415 Change-Id: I4727c1159617208908925f79de82bc755edea696 Reviewed-on: https://chromium-review.googlesource.com/1213169Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#593830}
-
Ned Nguyen authored
Bug: 828466 Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi Change-Id: I7a0805b72598fcb978e2123f0c3c92c1d5ef1cad Reviewed-on: https://chromium-review.googlesource.com/1238491 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
Ryan Tseng <hinoka@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#593829}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/64b61330ec7f..d4c867355a8b git log 64b61330ec7f..d4c867355a8b --date=short --no-merges --format='%ad %ae %s' 2018-09-25 tandrii@chromium.org git cl: use explicit Gerrit mirrors on 404s during upload. Created with: gclient setdep -r src/third_party/depot_tools@d4c867355a8b The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:881860 TBR=agable@chromium.org Change-Id: Ibbc5a380a04d1b9c6a9433dcd29d930e2664f65c Reviewed-on: https://chromium-review.googlesource.com/1242630Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#593828}
-
Koji Ishii authored
Following bot results are included. 9975 9976 9983 9995 10000 0 lines were removed and 0 lines were deflaked by consecutive results since 9966. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I63a8e5260e6403e63088aa9999e8c52dc092d40f Reviewed-on: https://chromium-review.googlesource.com/1239802 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#593827}
-
Kenichi Ishibashi authored
When S13nServiceWorker is on but NetworkService is off, we want to use URLLoaderFactory from RenderProcessHost as AppCacheReqeustHandler wouldn't work when NetworkService is off. Before this CL we used RenderProcessHost's URLLoaderFactory only for subresources. This CL changes to use it for main resources as well. This fixes external/wpt/html/browsers/offline/appcache/workers/appcache-worker.https.html. Bug: 869302 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I7ad8c840ac9b6424e102f09cf43a146f9f858c60 Reviewed-on: https://chromium-review.googlesource.com/1229720 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#593826}
-
chromium-autoroll authored
https://chromium.googlesource.com/native_client/src/native_client.git/+log/9f85491d8830..2ebbdab4bfb1 git log 9f85491d8830..2ebbdab4bfb1 --date=short --no-merges --format='%ad %ae %s' 2018-09-25 efoo@chromium.org Whitespace change to kick off LUCI jobs Created with: gclient setdep -r src/native_client@2ebbdab4bfb1 The AutoRoll server is located here: https://autoroll.skia.org/r/nacl-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:868204 TBR=mseaborn@chromium.org Change-Id: I5c447a5a79b4eefb44df075c72e100e5584f5e29 Reviewed-on: https://chromium-review.googlesource.com/1242628Reviewed-by:
-
Yuki Yamada authored
This CL removes a private property. We do not have to have both of the private property of "ErrorEventError" and |error_|, the TraceWrapperV8Reference<v8::Value> in blink::ErrorEvent. Also, the error attribute passed to listener should be initialized to null for dedicated workers. https://html.spec.whatwg.org/multipage/workers.html#runtime-script-errors-2 This CL modifies some tests regarding this too. Bug: 872138 Change-Id: I497434d04c30f222ea8847239edf4e9a0ee97b19 Reviewed-on: https://chromium-review.googlesource.com/1233080 Commit-Queue: Yuki Yamada <yukiy@google.com> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#593824}
-
Ting Shao authored
When a navigation preload request is aborted, no console message is sent to the service worker. That's because the "unsanitized_message" field of blink::WebServiceWorkerError is not set. When Sending the message to console, prefer the unsanitized one if avaiable. Update service worker browser test to cover this change. Bug: 877870 Test: content_browsertests -gtest_filter=ServiceWorkerNavigationPreloadTest.CanceledByInterceptor Change-Id: Icad28ce1a9feb40b729bc2504d9c9adb33593a0a Reviewed-on: https://chromium-review.googlesource.com/1235376 Commit-Queue: Leon Han <leon.han@intel.com> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#593823}
-
Kenichi Ishibashi authored
Some tests in SharedWorkerHostTest were failing because they didn't pass some parameters which are required as of https://crrev.com/c/1154743. Pass some mock objects to make them pass. Bug: 884960 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I9ea6e04746a632e5ae069f7d810123c628ce7f06 Reviewed-on: https://chromium-review.googlesource.com/1235257Reviewed-by:
-
Xiaocheng Hu authored
Now that we have spec-conformant implementation of Element.innerText, we should change layout test text dump to use it. To avoid an extra- large patch rebaselining 10k+ at once, which is vulnerable to test flakes, we will rebaseline progressively in a per-directory manner. This patch adds mechanism that chooses which text dump implementation to use based on the the test path. Actual rebaseline will be done in follow up patches. Bug: 887148 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I0fe248b20c6a924549aae424990374b18f070027 Reviewed-on: https://chromium-review.googlesource.com/1234874Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#593821}
-
Ned Nguyen authored
Bug: 828469, 828465 Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi Change-Id: I0d5fd3cdb0a701c56c2ac717d1e7b15d6a84380d Reviewed-on: https://chromium-review.googlesource.com/1238482Reviewed-by:
-
Nasko Oskov authored
This CL adds caching of the online status in the RenderThread for each renderer process to make it available to query on demand. Without it, when navigation in a new process results in an error page, the NetErrorHelper object is initialized with incorrect state, leading to breakage of autoreload functionality when the browser is back online. Bug: 865914 Change-Id: I9eb388ddd4f06a80f48d5c4f9c774ac4b29f5377 Reviewed-on: https://chromium-review.googlesource.com/1237143Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#593819}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/e2d2270a6f75..85c4b43e6db1 git log e2d2270a6f75..85c4b43e6db1 --date=short --no-merges --format='%ad %ae %s' 2018-09-25 fjhenigman@chromium.org Vulkan: Translate line loop indices from buffer. 2018-09-25 tobine@google.com Avoid flush/invalidate of host-coherent memory Created with: gclient setdep -r src/third_party/angle@85c4b43e6db1 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=syoussefi@chromium.org Change-Id: I37e921973b79b3caf87ba8baae4b71d3df6d0402 Reviewed-on: https://chromium-review.googlesource.com/1242314Reviewed-by:
-
Scott Violet authored
This is primarily to prevent a bad renderer from forcing capture. BUG=621234 TEST=none Change-Id: I66475bff12f260f8adaf95c1ee0d65d3931bf58d Reviewed-on: https://chromium-review.googlesource.com/1241834 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#593817}
-
Christopher Cameron authored
The views_bridge_mac directory contains the Cocoa front-end of the macOS implementation of the views framework. Start moving sources from ui/views/cocoa that have no dependencies on ui/views over to this component. Eventually the app shim process on macOS will only require this component (and views will exist entirely in the browser process). Bug: 821651 Change-Id: I215acfa0620154771cd039fe593d43fb068d51cb Reviewed-on: https://chromium-review.googlesource.com/1241199 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#593816}
-
Oksana Zhuravlova authored
Bug: 866967 Change-Id: Ib47116819dc1100a8781e6a3e380dbf33101f474 Reviewed-on: https://chromium-review.googlesource.com/1235195Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#593815}
-
Devlin Cronin authored
Gracefully handle null web contents in ExtensionActionViewController::GetIcon(). This can happen when TabStripModel::GetActiveWebContents() returns null. Add a regression unittest for the same. Bug: 888121 Change-Id: Iaf3194b3d0475314b9a953158951bd3cb23af503 Reviewed-on: https://chromium-review.googlesource.com/1242195Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#593814}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=kariah@chromium.org Change-Id: Icbb9ffd719540844413717d14d0cb125177b5e36 Reviewed-on: https://chromium-review.googlesource.com/1242334Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#593813}
-
Eugene But authored
This argument has incorrect value when displaying SSL interstitial and during provisional navigation. This CL replaces RequestInfo::source_url usage with WebState::GetLastCommittedURL, which actually represents page URL. RequestInfo::source_url will be deleted in a separate CL. Bug: None Test: App Launcher prompt works correctly. Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I0e320bd2d68df9eb96f5ca71c6e764bb12c6e7f5 Reviewed-on: https://chromium-review.googlesource.com/1217583Reviewed-by:
Mohammad Refaat <mrefaat@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#593812}
-
agrieve authored
This reverts commit a2136115. Reason for revert: Broke Cronet bot (see bug) Original change's description: > Network servicification of NQE in network metrics provider > > Use Network Quality Tracker (NQT) in network metrics provider > instead of the network quality estimator (NQE). > > NQT works when network servicification is enabled or disabled. > NQE works only when network servicification is disabled. > > Note that NQT is to be used on UI thread, while NQE was on > IO thread, which makes the code a bit simpler. > > Change-Id: If95a8882d578ef6d00ea1a51e4bc5a861b3a47a2 > Bug: 882482 > Reviewed-on: https://chromium-review.googlesource.com/1215371 > Reviewed-by: Robert Kaplow (sloooow) <rkaplow@chromium.org> > Reviewed-by: Ryan Sturm <ryansturm@chromium.org> > Commit-Queue: Tarun Bansal <tbansal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#593566} TBR=rkaplow@chromium.org,tbansal@chromium.org,robertogden@chromium.org,ryansturm@chromium.org Change-Id: I339700eb7875d805413eddf3b5405243ad02a5c7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 882482, 888612 Reviewed-on: https://chromium-review.googlesource.com/1242198Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#593811}
-
Kunihiko Sakamoto authored
These will help to understand UA-side time skews. Design doc: https://docs.google.com/document/d/1kzQRLybaUk12UgG8YTyACwNZ7tpcXwdjzPXU3CV25J8/edit Bug: 863305 Change-Id: I61d900cc6e6dd7d64ef49cd534a1837cf6b47b1d Reviewed-on: https://chromium-review.googlesource.com/1237901 Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#593810}
-
momohatt authored
ServiceWorkerNewScriptLoader uses an internal variable called |network_loader_state_| to control the state of URLLoaderClient. This state is changed from kLoadingHeader to kWaitingForBody at the end of OnReceiveResponse(). However, WriteHeaders() could call OnWriteHeadersComplete() synchronously and it calls MaybeStartNetworkConsumerHandleWatcher() when |network_loader_state_| is set to kLoadingHeader. And later OnStartLoadingResponseBody() calls MaybeStartNetworkConsumerHandleWatcher() again and hits DCHECK_EQ(kNotStarted, body_writer_state_). Change-Id: I3b9450ca53e6b98423d532ea02134d002d7753b6 Reviewed-on: https://chromium-review.googlesource.com/1237634Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Momoko Hattori <momohatt@google.com> Cr-Commit-Position: refs/heads/master@{#593809}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 7f62e82c. With Chromium commits locally applied on WPT: 398ba6bd "service worker: Add WPT tests for resultingClientId." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/25176 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: binji@chromium.org: external/wpt/wasm bjonesbe@adobe.com: external/wpt/css/css-shapes creis@chromium.org, lukasza@chromium.org, nick@chromium.org: external/wpt/fetch/corb ecobos@igalia.com: external/wpt/css/css-display foolip@chromium.org: external/wpt/fullscreen guidou@chromium.org: external/wpt/mediacapture-streams hbos@chromium.org, hta@chromium.org: external/wpt/webrtc hongchan@chromium.org, rtoy@chromium.org: external/wpt/webaudio jinho.bang@samsung.com, mathp@chromium.org, rouslan@chromium.org: external/wpt/payment-handler jochen@chromium.org, estark@chromium.org: external/wpt/referrer-policy jsbell@chromium.org: external/wpt/resources kojii@chromium.org: external/wpt/css/css-text/i18n external/wpt/css/css-writing-modes ksakamoto@chromium.org: external/wpt/resource-timing mkwst@chromium.org: external/wpt/x-frame-options mstensho@chromium.org: external/wpt/css/css-break rego@igalia.com: external/wpt/css/css-contain rouslan@chromium.org, mathp@chromium.org: external/wpt/payment-method-basic-card external/wpt/payment-request yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: Ic3a05c47b49666a3614d28ffb45208cad3d910f7 Reviewed-on: https://chromium-review.googlesource.com/1242077 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#593808}
-
Justin DeWitt authored
Version as integer timestamp has problems when considering caching versions that are actually filtered dynamically on the server, so we switch to an opaque string version_token that the server can choose. Client loses the ability to determine if a new version is "newer" or "older" but this doesn't seem like much of a loss. Bug: 867488 Change-Id: I43fadaf2ccfecec8143f45473d1b863f38345cac Reviewed-on: https://chromium-review.googlesource.com/1241531 Commit-Queue: Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Cathy Li <chili@chromium.org> Cr-Commit-Position: refs/heads/master@{#593807}
-
Tsuyoshi Horo authored
TBR=dmazzoni@chromium.org,dtseng@chromium.org Bug: 888824 Change-Id: Iec684ed1c801070ee2c1af5dcac39afee750910b Reviewed-on: https://chromium-review.googlesource.com/1242473Reviewed-by:
-
chrome://extensionsDevlin Cronin authored
Bug: 884878 Change-Id: I595c6c8f0a26db7ceafc4f08882c071233162eda Reviewed-on: https://chromium-review.googlesource.com/1242394Reviewed-by:
-
momohatt authored
A variable named test_loader_factory, declared in SetUp() of the ServiceWorkerNewScriptLoaderTest is not used and therefore can be removed. Change-Id: I5d344dc6d29c5c473e62a76c6a1a005f3e6cc349 Reviewed-on: https://chromium-review.googlesource.com/1237693Reviewed-by:
-
Erik Luo authored
Bug: none Change-Id: Ib88d07f8a3456f1974db490980d14907cf774274 Reviewed-on: https://chromium-review.googlesource.com/1240714Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#593803}
-
Alan Cutter authored
The color of Ash app window title bar was changed to the same color of the settings app title bar accidentally in https://chromium-review.googlesource.com/c/chromium/src/+/1125512. This changed DevTools, the Terminal and Chrome App windows to be blue. This CL fixes the unintentional change in behavior by updating UpdateFrameColors() to use the same guard as CreateFrameHeader() when setting the frame color to kMdWebUiFrameColor. Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=359594&signed_aid=Yr-u3b9GUhWb0iEc6igy5Q==&inline=1 After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=359595&signed_aid=rfGnleo9Sj8jmcVXfDipeg==&inline=1 Bug: 879851 Change-Id: I8980b7f52f529390938a1a5ff05742b336e665d2 Reviewed-on: https://chromium-review.googlesource.com/1223951 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#593802}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/5272a543705e..e2d2270a6f75 git log 5272a543705e..e2d2270a6f75 --date=short --no-merges --format='%ad %ae %s' 2018-09-25 jmadill@chromium.org Vulkan: Merge append/beginWriteResource. Created with: gclient setdep -r src/third_party/angle@e2d2270a6f75 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=syoussefi@chromium.org Change-Id: I8ca2a8236320efce9657032e82746edfdaa93e37 Reviewed-on: https://chromium-review.googlesource.com/1242313Reviewed-by:
-
Jialiu Lin authored
Change from "AdvancedProtectionStatus" to "AdvancedProtectionStatusRollout" to match .../finch/gcl_studies/AdvancedProtectionStatus.gcl Change-Id: I364235ce83d1efa9c8f0230c8f5875f464b413db Reviewed-on: https://chromium-review.googlesource.com/1241954Reviewed-by:
-
Junliang Yan authored
As we decided to drop support for 31-bit s390 and 32-bit ppc, so those are cleaned up here. Change-Id: I400c88639c461de7380f59bfcb6a2900f4541972 Reviewed-on: https://chromium-review.googlesource.com/1240864Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#593799}
-
Ramya Nagarajan authored
Bug: none Change-Id: Ieefde51da92fd4f896007c07ee45321423360e83 Reviewed-on: https://chromium-review.googlesource.com/1241938Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Ramya Nagarajan <ramyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#593798}
-
Christopher Cameron authored
The feature has been around for a while, but having it in about:flags will help development along. Bug: 859152 Change-Id: I3da5fff7b57961f3c41a628c69a9b65b69122860 Reviewed-on: https://chromium-review.googlesource.com/1226298 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#593797}
-
Luciano Pacheco authored
Issue is explained here [1], in crrev.com/c/1237754 I changed this in the Files app, however the Polymer component is used in Audio Player, so moving the CSS fix to Audio Player. [1] - https://developers.google.com/web/updates/2013/12/300ms-tap-delay-gone-away Bug: 875525 Change-Id: Ideab2aa12fe6dcdfb5665be201e867687e046c50 Reviewed-on: https://chromium-review.googlesource.com/1239801Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#593796}
-
Luciano Pacheco authored
Bug: 875525 Change-Id: I81fd85c9636537f15735801ead680ef5d67c3bea Reviewed-on: https://chromium-review.googlesource.com/1237755Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#593795}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a85f3a138cbc..e514fa0f1a6c git log a85f3a138cbc..e514fa0f1a6c --date=short --no-merges --format='%ad %ae %s' 2018-09-24 brianosman@google.com Report "correct" color type for lazy images Created with: gclient setdep -r src/third_party/skia@e514fa0f1a6c The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=bsalomon@chromium.org Change-Id: I60a0f82f40db8869cda99fff4049f8e6dd3e9bb8 Reviewed-on: https://chromium-review.googlesource.com/1241598Reviewed-by:
-
Eugene But authored
This should dismiss ‘Add to Apple Wallet’ dialog as intended by BVC. Bug: 810379 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Id4cb59c20adb0730808ff47492653468f2a12d18 Reviewed-on: https://chromium-review.googlesource.com/1241934 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#593793}
-
Tom Anderson authored
This CL adds the initial wiring and observer interface for dynamic MD mode switching. Currently, parts of browser windows get a relayout when switching to/from tablet mode on ChromeOS, but there are still several imperfections that must be fixed by registering with the observer interface that this change adds. BUG=737995,881371 R=robliao,sky Change-Id: I0e2169850b32d3fe1c79a40a28654389293727e2 Reviewed-on: https://chromium-review.googlesource.com/1238546Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#593792}
-
Dmitry Gozman authored
We can do this from the worker thread itself now, since we have all the tokens available. Bug: none Change-Id: Ibc1f0de3bc46974dd8ec037226a4c610b2cb53bd Reviewed-on: https://chromium-review.googlesource.com/1232877 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#593791}
-
