- 09 Nov, 2017 40 commits
-
-
Gabriel Charette authored
Migrate MessageLoop::ScopedNestableTaskAllower to RunLoop::Type::kNestableTasksAllowed in /ash/drag_drop This pass focuses on ML::SNTA in same scope as RunLoop variable Scripted via https://bugs.chromium.org/p/chromium/issues/detail?id=781352#c1 The script should have replaced a MessageLoop::ScopedNestableTaskAllower in the same scope as a RunLoop with a RunLoop of Type::kNestableTasksAllowed. If there was a comment above the MessageLoop::ScopedNestableTaskAllower, it should have been moved alongside the augmented RunLoop. Please CQ if LGTY This CL was uploaded by git cl split. R=mfomitchev@chromium.org Bug: 781352 Change-Id: I4b8d600da667c5222b589da0d5881f8c6285200b Reviewed-on: https://chromium-review.googlesource.com/758574Reviewed-by:
Mikhail Fomitchev <mfomitchev@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#515278}
-
Ned Williamson authored
If migrate_sessions_early is true, then migrate_sessions_on_network_change must also be true. BUG=782767 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ifd3f484d2d18e252848c0b75aac0d56a13e35b54 Reviewed-on: https://chromium-review.googlesource.com/760097Reviewed-by:
Max Moroz <mmoroz@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#515277}
-
Lei Zhang authored
Make it behave more like Save As as implemented in the downloads code. BUG=375330,782041 Change-Id: I62d373f8f356bc6614ffa2ad293fc05a3d9e1ba3 Reviewed-on: https://chromium-review.googlesource.com/759411 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#515276}
-
Chris Harrelson authored
An earlier patch moved expansion of the interest rect to root space, but this doesn't work for non-linear transforms like perspective. The intent of the earlier patch was to account for layer scale when determining the amount to expand, with the intent to expand by a certain number of pixels in screen space, not layer space. This patch achieves the same result, but changing the expansion amount by the scale factor. Bug: 781699 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I85bcbd8301caa8b3abd36035df63f3eca0e1235c Reviewed-on: https://chromium-review.googlesource.com/758821 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#515275}
-
Vadim Tryshev authored
It was used only in the old launcher. Bug: 780526 Change-Id: I0c44e32b74f3f748f11ca4010ebe0e415d0c6027 Reviewed-on: https://chromium-review.googlesource.com/757940Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Vadim Tryshev <vadimt@chromium.org> Cr-Commit-Position: refs/heads/master@{#515274}
-
Yuzhu Shen authored
This reverts commit bc2056c3. Reason for revert: Causing compilation failure: https://uberchromegw.corp.google.com/i/chromium.mac/builders/ios-device-xcode-clang/builds/43902 Original change's description: > Change size in memory mapped region to size_t > > Subsequently, remove some static_casts that are no longer needed. > > On Windows, while it is possible to create a file mapping of a file > > 32-bits long it is not possible to create the view to the file > mapping, so changing this to size_t should have no loss of functionality. > > BUG=778316 > > Change-Id: I81cd2e0808794fdb83fc21c796367369ea2da220 > Reviewed-on: https://chromium-review.googlesource.com/755114 > Reviewed-by: Mark Mentovai <mark@chromium.org> > Commit-Queue: Will Harris <wfh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#515257} TBR=wfh@chromium.org,mark@chromium.org Change-Id: I9a41a960cb7b3e457af41e330806285f5ab7879f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 778316 Reviewed-on: https://chromium-review.googlesource.com/761597Reviewed-by:
Yuzhu Shen <yzshen@chromium.org> Commit-Queue: Yuzhu Shen <yzshen@chromium.org> Cr-Commit-Position: refs/heads/master@{#515273}
-
xdai authored
Bug: 761718 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: If330d3684b0e01b5de32c271b30acac1e665d4b5 Reviewed-on: https://chromium-review.googlesource.com/756324 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#515272}
-
danakj authored
ImageLayerBridge should check the SharedGpuContext to determine if gpu compositing is on or off, then submit a texture or a bitmap accordingly. R=junov@chromium.org, piman@chromium.org TBR=chrishtr Bug: 772574 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I4918efd9eebb7447aa5a4d04ffeae1be22ad678e Reviewed-on: https://chromium-review.googlesource.com/756869Reviewed-by:
Justin Novosad <junov@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#515271}
-
Weidong Guo authored
Changes: 1. Disable all selection related test. 2. Disable AutoLaunch tests because it breaks in new focus model. (They are not used now because we removed voice search, these tests will be fixed and reenabled after voice search is back.) 3. Enable kEnableAppListFocus by default. 4. Use Answer Card in AppListViewFocusTest. BUG=780076,780075 Change-Id: I498d727f641c022fddc130cc844dd79b0f50122f Reviewed-on: https://chromium-review.googlesource.com/754365 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#515270}
-
Chris Harrelson authored
column fragmentation. Visual rects may not have an origin at the (0, 0) point of the object, which makes them inappropriate for paint offsets. They are also not appropriate for fragmentation, because visual overflow should extend beyond column bounds rather than causing elements to paint into multiple fragments. Note that fragment clips may still cut off visual overflow, which is a bug, but now visual overflow will not extend across columns. Bug: 782608, 774699, 779998 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I23feab957c018c124f59b5b9b84644709c466e03 Reviewed-on: https://chromium-review.googlesource.com/759233Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#515269}
-
Alexey Kozyatinskiy authored
I extracted part that should be loaded into separate resources file and used TestRunner.navigate to load it. R=chenwilliam@chromium.org TBR=dgozman@chromium.org Bug: chromium:667560 Change-Id: Ica9ca20d0f105f21f82a613055b2a02c3def0ada Reviewed-on: https://chromium-review.googlesource.com/758972Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
Will Chen <chenwilliam@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#515268}
-
Matt Falkenhagen authored
This removes the failing expectations so we have test coverage: * fast/dom/Window/dom-access-from-closure-iframe.html [ NeedsManualRebaseline ] * fast/dom/Window/dom-access-from-closure-window-with-gc.html [ NeedsManualRebaseline ] * fast/dom/Window/dom-access-from-closure-window.html [ NeedsManualRebaseline ] Bug: 713732 Change-Id: Icb2e7f23854a96affb32cdff6ff3a2bf832daa19 TBR: verwaest Reviewed-on: https://chromium-review.googlesource.com/760658Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#515267}
-
Michael Giuffrida authored
Adds an option for Chrome on Chrome OS to the DevTools User Agent string customization. Like the other values, this uses a static platform version and a placeholder for the Chrome version. R=dgozman@chromium.org Change-Id: I367484918e3921ff19c56fb97ece8a763d760496 Reviewed-on: https://chromium-review.googlesource.com/738931Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#515266}
-
Maxim Kolosovskiy authored
Bug:725883 Change-Id: I34399226fecf8180dc62cf5b846b2c3da2fda564 Reviewed-on: https://chromium-review.googlesource.com/610080 Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#515265}
-
Matt Falkenhagen authored
This is in preparation for upstreaming to WPT for easier reviewing. * Use promise_test for the different test cases. * Other minor cleanups. Bug: 446188, 688116 Change-Id: I9905b904da538e2cfe7bd84d18b88d24057f064b Reviewed-on: https://chromium-review.googlesource.com/760387 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#515264}
-
Ben Chan authored
Since C++11, nullptr is preferred over NULL. This CL replaces NULL with nullptr, and also updates unit tests to use ASSERT_EQ/ASSERT_NE and EXPECT_EQ/EXPECT_NE when comparing values against nullptr. Bug: None Change-Id: I8074586f8f0c9924d6551fef18904107fa466981 Reviewed-on: https://chromium-review.googlesource.com/760139Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Ben Chan <benchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#515263}
-
Joel Einbinder authored
This contains support for new TypeScript syntax highlighting Bug: none Change-Id: I845e839f60d529cf665308e458f1cc2497bdd269 Reviewed-on: https://chromium-review.googlesource.com/758630 Commit-Queue: Joel Einbinder <einbinder@chromium.org> Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#515262}
-
rbpotter authored
Bug: 773928 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I1a63fb17857e7f746b8dc62f8830fa8205e59bf9 Reviewed-on: https://chromium-review.googlesource.com/753430 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#515261}
-
Alexander Timin authored
Move thread load tracker from base/ as a preparation for moving scheduler/base into base/task_scheduler. R=robliao@chromium.org Bug: Change-Id: Ic72e7424a5dc92ca590dad34bfc4ac420cf7af15 Reviewed-on: https://chromium-review.googlesource.com/759001Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#515260}
-
Sidney San Martín authored
The menu button was setting the button's hoverSuppressed property after it had been deallocated. This change fixes that, and switches from overloading -[HoverButton setHoverState:] to KVO. Bug: 769343 Change-Id: Iec57d457434fa4c640a6a1f34e4b824ba1ccd271 Reviewed-on: https://chromium-review.googlesource.com/761476Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#515259}
-
Francois Doray authored
No build file refers to that file. Bug: 783309 Change-Id: I7e7d26575cfa7814112645205d11ae05259aed4a Reviewed-on: https://chromium-review.googlesource.com/761297Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#515258}
-
Will Harris authored
Subsequently, remove some static_casts that are no longer needed. On Windows, while it is possible to create a file mapping of a file > 32-bits long it is not possible to create the view to the file mapping, so changing this to size_t should have no loss of functionality. BUG=778316 Change-Id: I81cd2e0808794fdb83fc21c796367369ea2da220 Reviewed-on: https://chromium-review.googlesource.com/755114Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#515257}
-
Raymond Toy authored
Remove the old stale copy of the spec and remove js/lodash.js which is loaded in several places but not actually used for anything. Bug: 782901 Change-Id: Idfdbc9f1cf2d9edf190d649168074f4d4ec66c73 Reviewed-on: https://chromium-review.googlesource.com/759225Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#515256}
-
Xi Han authored
Update the shell APK template to support adaptive icons which are introduced on Android O (API 26): - Both foreground and background layers are image resources in /mipmap dir. - Add /mipmap-anydpi-v26/ic_launcher.xml to specify the adaptive icons. - In AndroidManifest, use different icon_id for android::icon and metadata ICON_ID. Therefore, WebAPKs can have a splash icon which is different than the app icon. Bug: 780929 Change-Id: I2f0c2f7156c094bdd444ef6019ef22fd9437bf45 Reviewed-on: https://chromium-review.googlesource.com/753812Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Glenn Hartmann <hartmanng@chromium.org> Commit-Queue: Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#515255}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/f83c79a6db05..b3971d87403a $ git log f83c79a6d..b3971d874 --date=short --no-merges --format='%ad %ae %s' 2017-11-08 nednguyen Reland "Fix reinit after failure"" 2017-11-07 crouleau Don't use grouping_keys for cache and traffic. 2017-11-08 dtu [pinpoint] Separate exception comparisons for each Quest. 2017-11-08 nednguyen Disable TestBrowserOperationDoNotLeakTempFiles.testBrowserNotLeakingTempFiles 2017-11-08 dtu [pinpoint] Compress Job.state. 2017-11-08 perezju [Telemetry] Log Telemetry's memory usage after collecting all results 2017-11-07 sadrul Reland "viz: Fix collecting rendering stats with viz." 2017-11-08 benjhayden Save memory with __slots__ in python Histogram library. 2017-11-06 benjhayden Fix default bin boundaries in python Histogram. 2017-11-07 benjhayden Fix a bug with results.html deep-linking sortDescending. 2017-11-03 sergiyb Add VPython checks to Catapult presubmit 2017-11-02 benjhayden Syntax updates for Polymer 2.0. Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Ia595e1f6151201611ae9d53ab629ad507580084c Reviewed-on: https://chromium-review.googlesource.com/760878 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#515254}
-
Nicolas Pena authored
This CL ensures that a child iframe does not report paint timing entries when only the parent does all of the painting. Bug: chromium:736114 Change-Id: Idcba2bb9e93eeb7168e604840df4497df4073472 Reviewed-on: https://chromium-review.googlesource.com/755857 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#515253}
-
Albert J. Wong authored
Original CL: https://chromium-review.googlesource.com/742227 Renderer Sampling mode was causing tests to be non-deterministic. This adds an override method that test can use to make the sampling be 100% which is deterministic. Bug: 780955, 777984 Change-Id: I239654ebd41fc51227b257525008f62322ff8318 TBR: brettw,erikchen Reviewed-on: https://chromium-review.googlesource.com/758490 Commit-Queue: Albert J. Wong <ajwong@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Cr-Commit-Position: refs/heads/master@{#515252}
-
Yuri Wiitala authored
Looks like the "dump without crashing" has never triggered. Thus, the issue seems to be long-gone. Bug: 519022, 694688 Change-Id: I253efa3438930d708c6c1e1f9554b532ecbdc9b9 Reviewed-on: https://chromium-review.googlesource.com/760017Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#515251}
-
Fernando Serboncini authored
Bug: 782119 Change-Id: I534996d8f222b0ed277de74c0ee6f860f7d60a36 Reviewed-on: https://chromium-review.googlesource.com/759093Reviewed-by:
Justin Novosad <junov@chromium.org> Commit-Queue: Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#515250}
-
Stephen McGruer authored
A KeyframeEffect's target is allowed to be null. This CL detects that situation and fails the WorkletAnimation's creation. Doing so is not spec-compliant (we should allow a null target) but at least avoids crashing on a null dereference. Bug: 781567 Change-Id: I4074eb25b53411e184c060e8d984fa43c5777568 Reviewed-on: https://chromium-review.googlesource.com/754599Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#515249}
-
Mathias Bynens authored
This patch prints a helpful error message if the Xcode license agreement hasn’t been accepted or if the CommandLineTools are installed separately from Xcode. BUG=729990 Change-Id: I8d7c6550c6b144473892a8f8c491eba32cbf9e6c Reviewed-on: https://chromium-review.googlesource.com/758651 Commit-Queue: Mathias Bynens <mathias@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
Sergiy Byelozyorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#515248}
-
Miriam Gershenson authored
There are cases of huge numbers of allocations by the HostsReader, which are probably caused by devices with huge hosts files. This memory dump provider checks the number of hosts entries and the size of the hosts file on the device to confirm. Bug: 772538 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Id241e62c8f8b63599f0459fbb6537d94fcfb61f9 Reviewed-on: https://chromium-review.googlesource.com/757063 Commit-Queue: Miriam Gershenson <mgersh@chromium.org> Reviewed-by:
Siddhartha S <ssid@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#515247}
-
Eugene But authored
This CL adds public headers to //ios/web/public/download. Implementation files will be sent in separate CLs. Design doc: http://go/ios-web-download-api Bug: 780646 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ic5935b205bacf485b369f506fe28af86dbcfd904 Reviewed-on: https://chromium-review.googlesource.com/754013 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Gregory Chatzinoff <gchatz@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#515246}
-
angle-deps-roller@chromium.org authored
https://chromium.googlesource.com/angle/angle.git/+log/70b715c9b8bc..73dcc60c868f $ git log 70b715c9b..73dcc60c8 --date=short --no-merges --format='%ad %ae %s' 2017-11-08 geofflang Support more always-available extensions in ContextNULL. 2017-11-08 svaisanen Support B8G8R8A8_UNORM_SRGB as D3D11 texture format 2017-10-24 geofflang Validate GL_COLOR_ATTACHMENT0 separately from the draw buffers attachments. Created with: roll-dep src/third_party/angle BUG=781164 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: I654e15d3c7d65f063aeea18fc4e9ad1c01d3c80c Reviewed-on: https://chromium-review.googlesource.com/760669Reviewed-by:
angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#515245}
-
Tom Anderson authored
Before: https://bugs.chromium.org/p/chromium/issues/detail?id=782980 After: https://bugs.chromium.org/p/chromium/issues/detail?id=782980#c1 BUG=782980 R=erg@chromium.org TBR=msw@chromium.org Change-Id: I0f0bc6e29bb821215fffaa98ea56d50b3abcd72d Reviewed-on: https://chromium-review.googlesource.com/758633Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Elliot Glaysher <erg@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#515244}
-
Elliot Glaysher authored
This replaces a bool on ash::wm::WindowState with an aura::Window property. Bug: 780160 Change-Id: I1537071cb1dcc985bd6757c906dfe3e87acda356 Reviewed-on: https://chromium-review.googlesource.com/752484 Commit-Queue: Elliot Glaysher <erg@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#515243}
-
xdai authored
If splitview and overview are both active at the same time - i.e., one side of the screen is occupied by a snapped window and the other side of the screen is occupied by the overview window grid: - Dragging the divider toward closing overview window grid should end split view mode and overview mode and activate the snapped window. - Dragging the divider toward closing the snapped window should end split view mode and the overview window grid should occupy the entire screen. Bug: 725683 Change-Id: I73498a96a15e89780eb2a06cc060d1c24c82975d Reviewed-on: https://chromium-review.googlesource.com/759028 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#515242}
-
Koji Ishii authored
This patch handles margins in line height quirks[1] as defined in the spec. Edge and Gecko don't do this, but Blink and WebKit do, and there are wpt tests. [1] https://quirks.spec.whatwg.org/#the-line-height-calculation-quirk Bug: 636993 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I38c5b22075cd5bd24dba46b9491e3b0f7fe93abf Reviewed-on: https://chromium-review.googlesource.com/757884Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#515241}
-
Dmitry Skiba authored
Child process is blocked until it receives the invitation, but sending it requires a hop to the client thread. Renderers are started from the UI thread on Android, and the UI thread can be busy with other tasks, delaying renderer initialization. This CL separates sending Mojo invitation from other child process notification tasks, and sends the invitation from the launcher thread. Bug: 768253 Change-Id: Id0c7397b239241b1693e2f9c108c7caba6d910c5 Reviewed-on: https://chromium-review.googlesource.com/687821 Commit-Queue: Dmitry Skiba <dskiba@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#515240}
-
webrtc-autoroll@chromium.org authored
https://webrtc.googlesource.com/src.git/+log/8c34a824b458..675513b96a7a $ git log 8c34a824b..675513b96 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I5fb5a8fe30df4ba4328ba17bc14da8cdd10d7379 Reviewed-on: https://chromium-review.googlesource.com/760397Reviewed-by:
WebRTC Roll Bot <webrtc-autoroll@chromium.org> Commit-Queue: WebRTC Roll Bot <webrtc-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#515239}
-