- 20 Feb, 2020 40 commits
-
-
Viktor Semeniuk authored
Changed Reauth dialog message for Copy password into clipboard feature. Added new Reauth Purpose reason. Bug: 917337 Change-Id: If805234969a39a98b24af1816f33c88388a06b87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061814 Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#743012}
-
Luciano Pacheco authored
Change TreeItem classes to avoid doing a full rescan just to work out if we should show the expand icon or not. Instead, only scan down to the first sub-directory using the new method updateExpandIcon(). Replace calls to updateSubDirectories() with updateExpandIcon() where the content of sub-directories aren't needed. The most important call replaced is in SubDirectoryItem constructor, because this caused scanning of an additional level down from the folder that user was interacting with. This significantly improves the performance of navigating on folders that have large sub-folders. For example, the time to run integration test directoryTreeExpandFolder() cut down from ~40 secs to ~7 secs, where the most of time is spent expanding a sub-folder that contains 1k children. Test: browser_tests --gtest_filter="DirectoryTree/FilesAppBrowserTest.Test/directoryTreeExpandFolder" Bug: 1039820 Change-Id: Ib629601f2c795a6dedd80a04f85827fd33e96af0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2059729Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#743011}
-
Yoshifumi Inoue authored
Before this patch, |NGPhysicalTextFragment::ResolvedDirection()| takes long time for text ranges not having text shape result, e.g. force line break, tab, etc. Then selection painting for large plain text containing newline, e.g. <pre>. This patch changes |NGPhysicalTextFragment| to hold resolved direction known at inline formatting rather than finding |NGInlineItem| from inline formatting context. This means we scan |NGInlineItem| list for every newline. On sample page (having 20,000 newline in <pre>), rendering time is 4,689ms to 1,881ms (2.4 times faster). Bug: 1050397 Change-Id: I0cc2a7b9c4ac75232b70b41f7d97134bdc966eef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063562 Commit-Queue: Kent Tamura <tkent@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#743010}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/c008fcb8cc0f..c12493ff69e2 git log c008fcb8cc0f..c12493ff69e2 --date=short --first-parent --format='%ad %ae %s' 2020-02-20 johnkslang@users.noreply.github.com Merge pull request #2086 from samuelig/SPV_AMD_shader_image_load_store_lod Created with: gclient setdep -r src/third_party/glslang/src@c12493ff69e2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: radial-bots+chrome-roll@google.com,cwallez@google.com Change-Id: Ib3b59c6f9b8f0569b948c485474ab8bbe2ac0291 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066049Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743009}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/048075425abc..adeb0b9fdd32 Created with: gclient setdep -r src-internal@adeb0b9fdd32 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ied8471d178b746b37434d41625797181ce370d14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066048Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743008}
-
Kai Ninomiya authored
https://chromium.googlesource.com/external/github.com/gpuweb/cts/+log/ec18cc3262922e7dcdbe70243c6f40606f979144..02b62c256590b040d514ec15c0f12041be8d1575 Change-Id: I6db0043cf844a81d1ccdecb4e7c0a51de5430fb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050036Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
Rakib Hasan <rmhasan@google.com> Reviewed-by:
Austin Eng <enga@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#743007}
-
Sean Kau authored
Some subsystems don't have access to a profile but need to observe CupsPrintersManager. Build a Proxy object that can be observed and will attach the primary user CupsPrintersManager when it's created. Change-Id: I6b52d51740e7d72359030c7ab6551541d8b2d30c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057859Reviewed-by:
Luum Habtemariam <luum@chromium.org> Commit-Queue: Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#743006}
-
Armando Miraglia authored
Bug: 1053255 Change-Id: Iac23a5c894030573013a92071ef31dbee9c938aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062398Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Armando Miraglia <armax@chromium.org> Cr-Commit-Position: refs/heads/master@{#743005}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a5097354217b..2c2db2762809 git log a5097354217b..2c2db2762809 --date=short --first-parent --format='%ad %ae %s' 2020-02-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 fa9eff37c38a..2801bf43716e (16 commits) Created with: gclient setdep -r src/third_party/skia@2c2db2762809 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: lovisolo@google.com Change-Id: I376009552376e12556eefb0b3e1c9f1b7c14261a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066050Reviewed-by:
-
Maksim Sisov authored
Fix crash that happens in tests if there is no data_device_. PS: we don't have tests running in our bot yet. This is what I observer, when did first runs locally. Bug: 578890 Change-Id: I6b9b01fb1f29b71f6fb459b9c69d4967cbb99b95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062441 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#743003}
-
Jonah Chin authored
This CL is the first step in creating a PaintRecord backed resource provider for canvas OOP-R. Changes of ownership: - PaintRecorder entirely moved from Canvas2DLayerBridge to CanvasResourceProvider. - Management of needs_flush_ for MemoryManagedPaintRecorder moved to CanvasResourceProvider. - RestoreCanvasMatrixClipStack logic centralized to CanvasResourceHost and can be accessed via callback - Backing SkiaPaintCanvas now private to CanvasResourceProvider with no external access. Any users of the backing SkiaPaintCanvas in Canvas2DLayerBridge had their functionality moved to CanvasResourceProvider (ie. new RestoreBackBuffer() function) Updates to test files: - Addition of explicit FlushCanvas() calls in tests that used to expect SkiaPaintCanvas to immediately update. - Some tests expected the CanvasResourceProvider to be created on first draw. This expectation has been changed since the CanvasResourceProvider now gets set up on SetCanvasResourceHost(). Other new functionality: - Display Item List now has a bit that tracks if it contains any draw operations. This is used to see if there are draw ops to flush. Bug: 1019288 Change-Id: I717b18e22d6699dc876d8f8121a25d147738579d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891292 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Aaron Krajeski <aaronhk@chromium.org> Reviewed-by:
Juanmi Huertas <juanmihd@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#743002}
-
Nick Harper authored
Change-Id: Ia542f2467e9b58a018f388327cd1b7a3c83b41f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064778Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#743001}
-
Maksim Sisov authored
Some tests may want to create a popup window without a parent. In case of Wayland, it requires to pass a parent window's widget. If there is no parent, and we are unable to find a current focused window (by cursor or by keyboard), what we can do is to create a normal surface. Bug: 578890 Change-Id: Iacbddd0cb85f62ea1f59fbf3efc6a160a3047fbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062976 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#743000}
-
jessing authored
An example of how to embed a chrome-untrusted iframe into a system web app. To do so, we need to add abstract methods in WebUI despite WebUIImpl being the only class to actually implement it. This is so the WebUIController can add requestable schemes so the WebUI can request the chrome-untrusted resource. Bug: 1048951 Change-Id: Ia3152e21412845cf421df74bb00a16e0a8f264b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037186 Commit-Queue: Jessica Huang <jessing@google.com> Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Auto-Submit: Jessica Huang <jessing@google.com> Cr-Commit-Position: refs/heads/master@{#742999}
-
Kenichi Ishibashi authored
ServiceWorkerStorage uses the const but it is going to be moved to the Storage Service. Bug: 1016064 Change-Id: Idded7b81c6ba84dd431d1784d90b3ad14cc21508 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060354 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#742998}
-
Alan Cutter authored
This is a reland of ef364481 Fixed test on linux-chromeos-chrome, see passing tryjob: https://ci.chromium.org/p/chrome/builders/try/linux-chromeos-chrome/5156 The tree failure was due to an incorrect test expectation that wasn't being exercised due to AutoupgradeMixedContent being enabled on the trybots. linux-chromeos-chrome caught the problem because it has AutoupgradeMixedContent disabled. This CL fixes the issue by forcing AutoupgradeMixedContent to be disabled so we can detect that we show security UI for mixed content: https://chromium-review.googlesource.com/c/chromium/src/+/2064310/1..2 Original change's description: > Allow mixed-security content in promoted PWA windows > > Prior to this CL, mixed-security content was blocked entirely in > standalone PWA windows with scopes. This CL allows those PWAs to display > mixed-security content, but when this happens, the window will show the > CustomTabBarView with the URL and a "Not Secure" indicator to indicate > the presence of mixed content. > > Screenshot: > https://bugs.chromium.org/p/chromium/issues/attachment?aid=432401&signed_aid=JeW6cXlVCQ3bSebdZ-FoJg==&inline=1 > > This removes a behavioural difference between promoted PWAs and "create > shortcut" apps without manifest scopes. > > > Bug: 910016 > Change-Id: Ic9b3bbdba14218bb1ad8fd4f2ca8cf47cd4e3a37 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041380 > Commit-Queue: Alan Cutter <alancutter@chromium.org> > Reviewed-by: Evan Stade <estade@chromium.org> > Reviewed-by: Dominick Ng <dominickn@chromium.org> > Reviewed-by: Peter Boström <pbos@chromium.org> > Reviewed-by: Glen Robertson <glenrob@chromium.org> > Cr-Commit-Position: refs/heads/master@{#742515} TBR=estade@chromium.org,dominickn@chromium.org,pbos@chromium.org,glenrob@chromium.org Bug: 910016 Change-Id: I7cde915c261406a32e3dc2d8f95318f0f4b5e534 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064310Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#742997}
-
Anand K. Mistry authored
Bug: 634140 Change-Id: I43c748a416ae83dc51394fd98c5e8ac7f4e4e6a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065769Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#742996}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ed1ff23c2768..a5097354217b git log ed1ff23c2768..a5097354217b --date=short --first-parent --format='%ad %ae %s' 2020-02-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 8def9063c4fd..74d3f371f201 (1 commits) Created with: gclient setdep -r src/third_party/skia@a5097354217b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: lovisolo@google.com Change-Id: Ibec880019f2c651058d242df1342a131e2e6b7ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065425Reviewed-by:
-
Erik Anderson authored
This updates from revision d8985509a9df2c25f5118f9d1e41a24f9739bd1f (2019-12-09) to revision 7922d7c20e246552be418e8f72e577899fd30d99 (2020-02-18) Bug: 1054078 Change-Id: I9a4da744ef4bd66ee13b15c64844686cc2228b4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064776Reviewed-by:
-
François Degros authored
Removed code that changed the permissions of the file to mount. It is not needed anymore. Files in MyFiles and Downloads are already readable by everyone. Bug: 996549 Cq-Depend: chromium:2055949 Change-Id: I0ef4d25aa2ca2a536ddee87d64ec5e417aeffe0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061628 Commit-Queue: François Degros <fdegros@chromium.org> Reviewed-by:
Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#742993}
-
Joel Hockey authored
Bug: 1033339 Change-Id: Ia8f0c24deb742d04b0a10bb4fbcb4c3322ea1547 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065776 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
-
Kazuki Takise authored
This is a follow-up CL of crrev.com/c/2040505, which introduced a regression where, if the client sends a bounds that is not along any of the edges of the PIP movement area, a wrong snap fraction is saved to the window. To avoid this, this CL ensures to snap the bounds to one of the edges. BUG=b:204050 TEST=atest android.server.am.ActivityManagerPinnedStackTests TEST=#testEnterPictureInPictureSavePosition on kevin Change-Id: I9d617790fb31c1a9c9bf33cf21ff67d2ae923e02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058934Reviewed-by:
Stefan Kuhne <skuhne@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Kazuki Takise <takise@chromium.org> Auto-Submit: Kazuki Takise <takise@chromium.org> Cr-Commit-Position: refs/heads/master@{#742991}
-
Daniele Castagna authored
With crrev.com/c/1830084 we removed the only workaround that was using disable_non_empty_post_sub_buffers_for_onscreen_surfaces. This CL cleans up related code. Bug: 457511 Change-Id: Id2ea16b9ce91e5b59401e253519057c7f45796a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700562 Auto-Submit: Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
Ken Rockot authored
This adds crash recovery to out-of-process Storage Service usage in Content, and also to Blink's DOM Storage implementation. Upon reconnecting after a crash, the browser pushes all known Session Storage namespaces back down into the service, and renderers re-connect their StorageAreas. A reconnected StorageArea begins by fetching a complete snapshot of the backend's cache. The delta between this and the last known cache in the renderer is used to do one of two things: - For Session Storage, updates are pushed to the backend so that it reflects the renderer's own local cache - For Local Storage, the renderer fully adopts the restored backend cache and dispatches events to update script about any deltas from the previously cached state. This should provide sufficient best-effort recovery for both Session and Local Storage in the event of a Storage Service crash. Fixed: 1052037 Change-Id: I047e480e58f9abba292967db3e4b63b398d60194 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055805 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#742989}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/2e7884eaaac7..631436b3c1f2 git log 2e7884eaaac7..631436b3c1f2 --date=short --first-parent --format='%ad %ae %s' 2020-02-20 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@631436b3c1f2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I40389bbff5fed511b0959b031268d878e2072021 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066044Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I8f2c4def353e064a0534bb1061ad2f653cdb59f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066045Reviewed-by:
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: I3a5fec7a4d24b4700170c49947ecf6f613015125 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065356Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#742986}
-
Kent Tamura authored
Similar to crrev.com/742068, this CL moves the code of LayoutMenuList::ComputeLogicalHeight() to LayoutBox in order to make LayoutNG transition easier. This CL has no behavior changes. Bug: 1040828 Change-Id: Ia338d7edf01bf513bc653dc26510862433beee9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065191 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#742985}
-
yjliu authored
Bug: 1035639 Change-Id: Ib33a4af151e4c0551f96f272bc67612f5e904032 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060122Reviewed-by:
weiliangc <weiliangc@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c08fcf30d513..e4a608b99a32 git log c08fcf30d513..e4a608b99a32 --date=short --first-parent --format='%ad %ae %s' 2020-02-20 treehugger-gerrit@google.com Merge "Parse user action hash and add to args table" Created with: gclient setdep -r src/third_party/perfetto@e4a608b99a32 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ic5b2302ecdccbc433aded1413c75533ff95ebaf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065993Reviewed-by:
-
jessing authored
pages. We want to embed an iframe with a URL of scheme 'chrome-untrusted://'. Currently, embedding chrome-untrusted:// iframes is blocked in multiple areas: the WebUI navigation throttle in the browser side and in the renderer side which currently treats chrome-untrusted as a display isolated scheme. This means it expects only the same scheme can load the same scheme e.g. chrome-untrusted:// can only load chrome-untrusted://. Since we want chrome:// to load chrome-untrusted://, it makes sense to no longer treat chrome-untrusted as a display isolated scheme. This cl unblocks those 2 areas (though there are more blocks we need to remove) by deregistering chrome-untrusted as a display isolated scheme and we allow chrome-untrusted schemes to proceed in the WebUI navigation throttle. Bug: 1048951 Change-Id: I9bfce2909f6a25c535866d1b8d57507393429bb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038192 Commit-Queue: Jessica Huang <jessing@google.com> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
-
Joey Scarr authored
Fixed: 1007673 Change-Id: Ia6a20e26124e8a8a0203c2460de9b6d2031fee57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2059749 Commit-Queue: Joey Scarr <jsca@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
-
Luum Habtemariam authored
Per Chrome Translation instructions, printing_strings.grdp should have an accompanying screeshot-hash directory named printing_strings_grdp/ Bug: none Test: none Change-Id: I50894498489f7df65ff3ca0043fb2403e91a8dfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066099 Commit-Queue: Luum Habtemariam <luum@chromium.org> Auto-Submit: Luum Habtemariam <luum@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#742980}
-
Takashi Toyoshima authored
The flag and base::Feature instance was removed, but still flag description strings and base::Feature declaration are remained. This patch removes them. Bug: 963307 Change-Id: Ic38e5dffabbb4967ee95e229d99ffd77d5950509 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063618 Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#742979}
-
Kenichi Ishibashi authored
We don't check these metrics anymore. Bug: 1053035 Change-Id: I6f0ca9f46d3d1437e0a2202ca067d2a00bdcda02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065772Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Yuzu Saijo <yuzus@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#742978}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/df996b82917a..402a68bf7d41 git log df996b82917a..402a68bf7d41 --date=short --first-parent --format='%ad %ae %s' 2020-02-20 fancl@chromium.org Add caching for Matching and Listing Created with: gclient setdep -r src/third_party/catapult@402a68bf7d41 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC crouleau@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1052720 Tbr: crouleau@google.com Change-Id: Ia6f8159f9e0e7ea8e3459d108be9ec0872b8bd0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065995Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/8def9063c4fd..74d3f371f201 git log 8def9063c4fd..74d3f371f201 --date=short --first-parent --format='%ad %ae %s' 2020-02-20 sugoi@google.com Array length fix Created with: gclient setdep -r src/third_party/swiftshader@74d3f371f201 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Ib09941c5f0d4d2e41d9e58428693817d251bcf91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066039Reviewed-by:
-
Mounir Lamouri authored
One metric was removed from the code and obsoleted. The other ones had their expiry pushed more or less in the future depending on how likely they are to be removed. Bug: 1052952,1053005,1053018,1053015,1053023,1053024,1053320 Change-Id: I78d4d0fadfcec5c36761b8ab2b33d69e3d5d59f0 Fixed: 1052952,1053005,1053018,1053015,1053023,1053024 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061110 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#742975}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 2bf8565a. With Chromium commits locally applied on WPT: d5cd6b98 "SharedWorker: Assign unique names to SharedWorkers to avoid unintentional matching" 2bf8565a "Clipboard API: Consistently return on detached contexts." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I730289bb9312b9ee5bdf54eefa4974cc33137e6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064410Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#742974}
-
Abhijeet Kandalkar authored
This CL has two goals, 1. Use To<KeyboardEvent> and DynamicTo<KeyboardEvent> as new downcast helper 2. Use IsA<KeyboardEvent>(element) in place of IsKeyboardEvent(element) Bug: 891908 Change-Id: I0bafee3560da2bcb7562aaed2a356774c2c10b3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019743 Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Reviewed-by:Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#742973}
-
