- 16 Oct, 2019 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5f410c266cfa..48014ea23a48 Created with: gclient setdep -r src-internal@48014ea23a48 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Ib5e5ab6296229caa19236c86552bc3b8555c3b5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864459Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706407}
-
Shik Chen authored
Echo cancellation is mainly for video conferencing. Disable it in CCA could save ~10% cpu on Nocturne in video recording. Bug: b:139788862 Test: Record video on Nocturne, measure performance by pprof and top. Change-Id: Ib531c338a46e9a6c611e269ade1e96541be764ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864757Reviewed-by:
Wei Lee <wtlee@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#706406}
-
Jan Scheffler authored
This patch keeps the focus on the main menu when changing from undocked back to docked again. Bug: chromium:1002424 Change-Id: Ic36f3e6852cb4e0a43ced6387dfeb3e2491d1d8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798344Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Jan Scheffler <janscheffler@chromium.org> Cr-Commit-Position: refs/heads/master@{#706405}
-
Jan Scheffler authored
This patch uses the descriptions from composititing_reasons.cc when tracing layers but transfers the reason via their short name to make it compatible with LayerTree.compositingReasons from the devtools protocol. Bug: chromium:737838 Change-Id: Id019d725d51ae7b740ab10bd94a470c8a053bc0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1800410Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
-
Parastoo Geranmayeh authored
Test is flaky for search/india and social. See bug. TBR=sullivan@chromium.org Bug: 1014661 Change-Id: I2c098f543ed2f6acd2575e821a21328e474735c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863379Reviewed-by:
Parastoo Geranmayeh <parastoog@google.com> Commit-Queue: Parastoo Geranmayeh <parastoog@google.com> Cr-Commit-Position: refs/heads/master@{#706403}
-
jonross authored
This is based on the original change: https://chromium-review.googlesource.com/c/chromium/src/+/1478489 The goal is to be able to capture the peak of GPU Memory usage. So that we can detect regressions caused by changes in gpu code/skia In order to do this we are introducing the PeakGpuMemoryTracker in content/ This can be used to connect to the GPU service, to request the peak memory seen over an interval. The GPU service expands the MemoryTracker class with an Observer. GpuChannelManager implements this in order to aggregate the memory allocations. It responds to requests from content/ A new UMA group "Memory.GPU.PeakMemoryUsage" has been added, with "TabChange" as the initial implementation. We will use the new API to record the max memory seen during a tab change. Bug: 908462 Change-Id: Iadb959b895edc7b2e756a812972b8410353ed571 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756206 Commit-Queue: Jonathan Ross <jonross@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#706402}
-
Mikel Astiz authored
Nigori is a special datatype because failing to commit local changes (e.g. custom passphrase set) can lead to problematic scenarios (e.g. user data exposed unencrypted) or in rare cases complicated conflict-resolution scenarios (e.g. keystore rotation took place before committing the custom passphrase) that worst-case cannot be resolved synchronously (e.g. keystore keys are missing and hence keys are pending for some time, until keystore keys are received). It's very hard to universally reason about all side effects of local commits and conflict resolution cases. Instead, this patch introduces infrastructure that adopts the command design pattern to concisely represent what the intended local change is. Local changes may now fail to apply, in particular if there is a conflict. But in such case the infrastructure allows dealing with the failure, with custom logic that depends on the precise command type. Similarly, success is only reported once the commit is acked by the sync server, which is a desirable property and useful foundation for future work. This may introduce additional latency in the existing UX, e.g. while setting up a custom passphrase, but manual tests indicate that it's not noticeable. In this patch, only the infrastructure is introduced without actually adopting it for the various local changes. Future patches will take care of such adoption. Bug: 922900 Change-Id: Ib55d3a401f1f68a1a910ee1e2b9119889d4f73b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864770 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/master@{#706401}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/810ee9415435..692ad2ff20be git log 810ee9415435..692ad2ff20be --date=short --no-merges --format='%ad %ae %s' 2019-10-16 engeg@google.com chromite: make ResponseNotReady python3 compat Created with: gclient setdep -r src/third_party/chromite@692ad2ff20be If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I32207fdf87a8a0e032ba77ba6d87cf7e8dcc372c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864486Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706400}
-
Alex Chau authored
- Refactored VAPID key manager to separate get key and refresh key - Derive from sync secret if kSharingDeriveVapidKey is enabled - Observe for VAPID key source changes, refresh cached key and re-register if cached VAPID key has changed Bug: 1010968 Change-Id: I178a6cd931ad41ab0184dd8a511e8ac0569e2269 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848171 Commit-Queue: Alex Chau <alexchau@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#706399}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/74f3784d..be181e24 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I65adae7dbf5021bc194eebd35424cb303610720d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864870Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706398}
-
Mario Sanchez Prada authored
Convert the remaining bits in both the implementation and clients from the browser and renderer processes for the XRInputSourceButtonListener interface. Bug: 955171, 978694 Change-Id: I2647b973b9784061918030bd2fb5f10e04b98212 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844995Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#706397}
-
Alex Chau authored
- As a follow-up of https://crrev.com/c/1841451, return the ECPrivateKey directly to avoid unnecessary hashing Bug: 1010968 Change-Id: Iff13d775f511ba031eba33d63e4d47403d205280 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863297 Commit-Queue: Alex Chau <alexchau@chromium.org> Reviewed-by:
-
Antonio Gomes authored
.. by calling PeerConnectionDependencyFactory::GetWebRtcWorkerThreadRtcThread() directly. This is now possible, after [1], where peer_connection_dependency_factory.cc|h is moved to Blink. [1] https://crrev.com/c/1805159 BUG=787254 R=guidou@chromium.org, haraken@chromium.org Change-Id: I7e1a516dff8ffbfbe69101a70b02b3da71e3b632 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807396 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#706395}
-
Rune Lillesveen authored
Reset the forced colors mode in the tests and re-enable disabled tests that failed because of the missing reset. Bug: 1014380 Change-Id: I95064e021c3dd1be4ade08e1edd0c0f4092bd03b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863010Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#706394}
-
Abhijeet Kandalkar authored
This CL has two goals, 1. Use To<HTMLSelectElement> and DynamicTo<HTMLSelectElement> as new downcast helper 2. Use IsA<HTMLSelectElement>(element) in place of IsHTMLSelectElement(element) Bug: 891908 Change-Id: I1b9d2a5dfef3729ba294ff105ef12d1640c1f534 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859988 Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#706393}
-
Emilio Cobos Álvarez authored
It was introduced in I0ad30908e76a9084ba8d685285e613a7194c02fb, but without giving it a name it just creates and destroys a temporary, which is useless. Bug: 1009806 Change-Id: I900a4f652c1ef4233a182d69a742c5162479af72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863796 Auto-Submit: Emilio Cobos Álvarez <emilio@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#706392}
-
Abhijeet Kandalkar authored
This CL converts, - |Binding<TracingSessionHost>| to |Receiver<TracingSessionHost>| - |Binding<TracingSessionClient>| to |Receiver<TracingSessionClient>| - |TracingSessionHostPtr| to |Remote<TracingSessionHost>| - |ProducerClientRequest| to |PendingReceiver<ProducerClient>| Bug: 955171, 978694 Change-Id: I52566c7c7561149f73df2a5aa7ecd494eafdd489 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1843993Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#706391}
-
Pavel Shmakov authored
Currently the cookies are not persisted because the default implementation of ContentBrowserClient::CreateNetworkContext doesn't specify cookie_path parameter. In this CL CreateNetworkContext is overridden in WebLayer implementation. Bug: 1014048 Change-Id: I1b7a307a64cd836eb5c4a45817412b997b89f1f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862677 Commit-Queue: Pavel Shmakov <pshmakov@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#706390}
-
Stepan Khapugin authored
This is a reland of http://crrev.com/c/1827373. The original CL broke downstream multitasking fix. This includes a fix to multitasking tests. Original description: Adds |window| property to SceneState. It is backed by SceneDelegate's |window| property and by UIWindowScene's |scenes| property on iOS 13 with multiwindow; or with an ivar otherwise. When it's an ivar, SceneController is now responsible for window creation. Note that the getter for AppDelegate's window remains for iOS 12 compat. Note that the window is always a ChromeOverlayWindow. have tested it manually on my machine and it still works) Change-Id: Id286f8c8d957504558effdfd1e9d7ac22ad2a23c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856320Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#706389}
-
Hans Wennborg authored
This reduces the number of preprocessor tokens in content_browser_client.h from 1,335,281 to 754,474. Since this is a widely included file, reducing build times a fair bit (see bug). TBR=tsepez for content/browser/child_process_security_policy_* Bug: 1014009 Change-Id: Id3c2de29f5b08cab80820d01aff722afeb1618e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857126 Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#706388}
-
Armando Miraglia authored
BUG=796964 Change-Id: Ife3b4b9d4ded591b162884df4c83bd8a0a51d449 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859985 Commit-Queue: Armando Miraglia <armax@chromium.org> Reviewed-by:
-
Antonio Gomes authored
.. by calling PeerConnectionDependencyFactory::GetSenderCapabilities() directly. This is now possible, after [1], where peer_connection_dependency_factory.cc|h is moved to Blink. As a bonus, blink::Platform::GetRtpReceiverCapabilities was not being used and got removed. [1] https://crrev.com/c/1805159 BUG=787254 R=guidou@chromium.org, haraken@chromium.org Change-Id: I8614838651a388d81d2d913fbd3657b31a195f7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807157 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Henrik Boström <hbos@chromium.org> Reviewed-by:
-
Koji Ishii authored
This patch supports adding list markers to |NGFragmentItems|. List markers are not part of the line box it belongs to in the |NGPhysicalFragment| tree. In |NGFragmentItem| world, it is an |NGFragmentItem| in the inline formatting context in most cases. When a list marker is attached to a block boxes, there is no change; i.e., it still appears in the |NGPhysicalFragment| tree. e.g., <li><div>text</div></li> then the list marker is propagated to a block formatting context. Some tests should turn to pass, but since bots are not setup yet, I'll update FlagExpectation later. Bug: 982194 Change-Id: I6af233360d1872de3e9507d69ef3c50275689267 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846627Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#706385}
-
Jüri Valdmann authored
GCC doesn't like that the Value data member has no out-of-line definition. The problem is triggered specifically only when compiling components/services/leveldb/leveldb_database_impl.cc which has lambda functions returning locally-defined classes. The current code works as-is in C++17 mode which introduces the concept of inline variables, but in C++14 we need either an explicit out-of-line definition or a function member instead of a data member. Use std::integral_constant for defining the value. Bug: 819294 Change-Id: I5c68e14ce3fa9d8b4d8a2cb42d7f9b53938aabf3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862451Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Jüri Valdmann <juri.valdmann@qt.io> Cr-Commit-Position: refs/heads/master@{#706384}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/febc913dd024..5f410c266cfa Created with: gclient setdep -r src-internal@5f410c266cfa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I8663b38726403be30f76db125e8e03a9445ff07d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864453Reviewed-by:
-
Takashi Toyoshima authored
This patch adds the "WebView P OOR-CORS FYI (rel)" bot to run WebView instrumentation tests, unittests, and CTS tests with OOR-CORS enabled. Preceding tools/build side change is here: https://chromium-review.googlesource.com/c/chromium/tools/build/+/1863899 Bug: 1013529 Change-Id: Ia35a9928138be322e9b6cab3531807957da0ffa7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864502 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#706382}
-
Mikel Astiz authored
No behavioral changes: this avoids repeated for loops in the bridge, and unblocks the option to pass around a single observer to helper functions/classes in follow-up patches. Bug: 922900 Change-Id: I3c58cae19858404e2bce0eb865536397e273797d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862923Reviewed-by:
-
Anatoliy Potapchuk authored
There will help us mitigate code duplication for regular kiosk,arc kiosk managers, and the future web kiosk app manager. Bug: 1006230 Change-Id: Iede5c0d400caee03f4ed9f5aefb1e68a42f9f7a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852254Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Oleg Davydov <burunduk@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Cr-Commit-Position: refs/heads/master@{#706380}
-
Julie Jeongeun Kim authored
This CL converts URLLoaderFactoryPtr from //third_party/blink to new Mojo types using PendingRemote and Remote. It also update some appcache APIs which has URLLoaderFactoryPtr and communicate with blink. Bug: 955171 Change-Id: I1c9caaf4937eebac04d9aa703f9a7163cc976ac9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855626 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#706379}
-
Miyoung Shin authored
This CL converts ResolveHostHandle{Ptr, Request} in services to the new Mojo type, and uses pending_receiver<ResolveHostHandle> in host_resolver.mojom. Bug: 955171 Change-Id: Icff06d2041c33437b0e1d8b76d50ce5b1d86b958 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859969 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by: -
Vadym Doroshenko authored
This teat failed, because input form data wasn't updated after removal of the old parser. Bug: 1008818 Change-Id: I145a4da89092fd72f197a62536e1d37e99f06797 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862921Reviewed-by:
-
Andy Paicu authored
Bug: 1014085 Change-Id: Ibc831829014e235b964c62417d9b7c8d8467b7fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860030 Commit-Queue: Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#706376}
-
A Olsen authored
(Test is currently disabled for ASAN since it cannot find all the JS libraries are runtime for ASAN builds on MAC.) Adds Azure and Okta success detection by checking URL and response. Ping is still TODO. Bug: 930109 Change-Id: I6f495ccd1371e171e6df2e3a4b9eb9bca5152723 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826786Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: A Olsen <olsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#706375}
-
Jan Krcal authored
This CL removes flags for a feature that has been launched to Stable for over a year. Bug: 931272 Change-Id: I48318a895cbdfe35c4262ce592a09a4e6d07aa3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859970Reviewed-by:
Patrick Noland <pnoland@chromium.org> Reviewed-by:
-
Hajime Hoshi authored
We found that the definition of 'not-cached' and 'evicted' was blurred. For example, when a render frame host decides to disallow back-forward cache, the existing cache is evicted, and at the same time, the page is no longer put into the back forward cache. This CL unifies HistoryNavigationOutcome.kNotCached and kEvicted. Bug: 1004676 Change-Id: I1d7cf4d65db9ecde825dd88489784da019c90287 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862135Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#706373}
-
Yutaka Hirano authored
Supporting preflight is tricky because preflight requests are made in the network service, and they don't have request IDs. We are adding a new message, OnLoaderForCorsPreflightCreated, to TrustedURLLoaderHeaderClient to address that. We are using TrustedURLLoaderHeaderClient, which means this mechanism works only when "extraHeaders" is specified. Unlike for usual requests, WebRequestProxyingUrlLoaderFactory::InProgressRequest dispatches - onBeforeRequest when OnLoaderForCorsPreflightCreated is called, - onBeforeSendHeaders and onSendHeaders when OnBeforeSendHeaders is called, and - onHeadersReceived, onResponseStarted, and onCompleted when OnHeadersReceived is called. This CL is a preliminary change. It adds - TrustedURLLoaderHeaderClient.OnLoaderForCorsPreflightCreated as described above, - "remote_endpoint" param to TrustedHeaderClient.OnHeadersReceived to get endpoint information in OnHeadersReceived, and - kURLLoaderOptionAsCorsPreflight to mark a request as a CORS preflight. This CL doesn't change any behavior because we have not set kURLLoadOptionAsCorsPreflight and kURLLoadOptionUseHeaderClient in network::cors::PreflightController yet. The subsequent change is: https://crrev.com/c/1837561 Bug: 1002884 Change-Id: Ib396e35ce636f6ed016df089d393dedec94db430 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833395 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#706372}
-
Thomas Tangl authored
Screenshots: https://drive.google.com/open?id=1Shi3W_cUIY1X-iREiTFwcSZEuKaHyf14 https://drive.google.com/open?id=1F5NzqWp0Y3gFoDYvsIF4M-suvFLSwVFE Bug: 995720 Change-Id: I9bea3d7df3560d24b849625f20d548a235a2919e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863413Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#706371}
-
Tom Anderson authored
> Also needed is [1] in webrtc, which fixes some build warnings. Could > land in parallel. > > [1] https://webrtc-review.googlesource.com/c/src/+/156980 > > BUG=1012850 > > Change-Id: Ia24e490db5e71cf1add0e10f4c1264aefb69143c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859935 > Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#705589} BUG=1012850 R=dpranke Change-Id: I1a3113201042d09931c0fe1ec68fe494b1b70df2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862623 Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#706370}
-
Primiano Tucci authored
ui_devtools/connector_delegate.h #include-s perfetto_service.mojom.h. This means that whoever includes connector_delegate.h needs to be able to include perfetto_service.mojom.h. In turn this means that the dependency on tracing needs to be in public_deps not just in deps. Concretely this is preventing to switch some of the objects that the mojo typemap refers to into compile-time generated files (the CL that is doing so is [1]), because the targets that depend on ui_devtools don't see the transitive dep required by the header. This fixes it (tested by manually rolling [1] into chrome). [1] https://android-review.googlesource.com/c/platform/external/perfetto/+/1106801 Bug: 1006776 Bug: b/132880619 Change-Id: Ic5d3cccd9bce3b77ebea69259cbe7e415d963b12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863791 Auto-Submit: Primiano Tucci <primiano@chromium.org> Reviewed-by:
Wei Li <weili@chromium.org> Commit-Queue: Primiano Tucci <primiano@chromium.org> Cr-Commit-Position: refs/heads/master@{#706369}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 0c1cb510. With Chromium commits locally applied on WPT: 6386d9d8 "Update service_worker_unregister_and_register()" f399b336 "Fetch Metadata: Add a test for `<embed>` navigated after loading." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: kenneth.r.christiansen@intel.com, rijubrata.bhaumik@intel.com: external/wpt/web-nfc NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I862085f6c15608c0cb5bd5e2451d1e3807496d18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863444Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706368}
-
