- 15 Jun, 2018 40 commits
-
-
Alexander Timin authored
This is a reland of 586e21ec Original change's description: > [scheduler] Add a perftest to measure basic scheduling costs. > > Change-Id: Idda9f71ae005250848fd2a118e5c4344e36be452 > Reviewed-on: https://chromium-review.googlesource.com/1085295 > Reviewed-by: Alex Clarke <alexclarke@chromium.org> > Commit-Queue: Alexander Timin <altimin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#566362} Change-Id: Ib9cfd16602c6bd0719059905250b91e0eb91dd22 Reviewed-on: https://chromium-review.googlesource.com/1097295Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#567645}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/90d481078b9b..ce952677d647 git log 90d481078b9b..ce952677d647 --date=short --no-merges --format='%ad %ae %s' 2018-06-15 dgarrett@google.com config_lib: Remove most UseBuildbucketScheduler hardcoding. Created with: gclient setdep -r src/third_party/chromite@ce952677d647 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:851183 TBR=chrome-os-gardeners@chromium.org Change-Id: Ic2db98b3dbf6ef5b994dfbda8e019d03e507cf82 Reviewed-on: https://chromium-review.googlesource.com/1102401Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#567644}
-
Dave Schuyler authored
This CL updates the vector icons for several Answers in Suggest (AiS) icons. Bug: 841594 Change-Id: Id4464de95bdbaf02d9f8fc48d17868acedb2e594 Reviewed-on: https://chromium-review.googlesource.com/1102105 Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#567643}
-
Luna Lu authored
Bug: 804645 Change-Id: I19e29e9d201eea3d6bd9e8a42f6e0621672ae2aa Reviewed-on: https://chromium-review.googlesource.com/1100972Reviewed-by:
Rick Byers <rbyers@chromium.org> Commit-Queue: Luna Lu <loonybear@chromium.org> Cr-Commit-Position: refs/heads/master@{#567642}
-
Robert Liao authored
This reverts commit 43e035ee. Reason for revert: browser_test failures on https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20Tests%20%28dbg%29%281%29 starting around 69747 Small subset of tests failing: PrerenderBrowserTest.PrerenderPageNewTab DefaultIsolation/TaskManagerOOPIFBrowserTest.OrderingOfDependentRows/0 PrerenderBrowserTest.PrerenderDownloadClientRedirect PrintPreviewBrowserTest.TaskManagerNewPrintPreview TabManagerTest.OomPressureListener Stack: Received fatal exception EXCEPTION_BREAKPOINT Backtrace: base::win::RegisterInvalidParamHandler [0x738B4167+71] invalid_parameter [0x6FDAECD1+161] std::_Tree_const_iterator<std::_Tree_val<std::_Tree_simple_types<std::pair<unsigned long const ,std::unique_ptr<memory_instrumentation::GlobalDumpGraph::Process,std::default_delete<memory_instrumentation::GlobalDumpGraph::Process> > > > > >::operator* [0x6296CB0C+156] std::_Tree_const_iterator<std::_Tree_val<std::_Tree_simple_types<std::pair<unsigned long const ,std::unique_ptr<memory_instrumentation::GlobalDumpGraph::Process,std::default_delete<memory_instrumentation::GlobalDumpGraph::Process> > > > > >::operator-> [0x6299A3C1+17] memory_instrumentation::QueuedRequestDispatcher::Finalize [0x62998EF4+3364] memory_instrumentation::CoordinatorImpl::FinalizeGlobalMemoryDumpIfAllManagersReplied [0x629303EB+587] memory_instrumentation::CoordinatorImpl::OnOSMemoryDumpResponse [0x629324F3+819] Original change's description: > Add RequestPrivateMemoryFootprint method to MemoryInstrumentation. > > Most clients only need private memory footprint, but the existing methods would > still query all the MemoryDumpProviders and then filter the results. This CL > adds a new method that avoids querying MemoryDumpProviders. > > Bug: 851712 > Change-Id: I269be2b5a74c32205ba6f4087a9bb8affb9cffb6 > Reviewed-on: https://chromium-review.googlesource.com/1098623 > Reviewed-by: Primiano Tucci <primiano@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Commit-Queue: Erik Chen <erikchen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#567417} TBR=dcheng@chromium.org,thakis@chromium.org,primiano@chromium.org,erikchen@chromium.org,lalitm@chromium.org Change-Id: I5dd27418aad49f2fcfbcb10c5510f11b91f4d875 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 851712 Reviewed-on: https://chromium-review.googlesource.com/1102518Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#567641}
-
Arthur Sonzogni authored
Assigned Node ID may not be the same for each executions of the test DomTreeExtractionBrowserTest.RunAsyncTest. This CL clears the value of backendNodeId to make this test more deterministic. backendNodeId uses DOMNodIds::IdForNode(). Here are two stack traces where the ID number 3 is assigned to a different Node. 02 blink::DOMNodeIds::IdForNode() 03 blink::InspectorDOMSnapshotAgent::VisitNode() 04 blink::InspectorDOMSnapshotAgent::VisitContainerChildren() 05 blink::InspectorDOMSnapshotAgent::VisitNode() 06 blink::InspectorDOMSnapshotAgent::getSnapshot() 07 blink::InspectorDOMSnapshotAgent::getSnapshot() 08 blink::protocol::DOMSnapshot::DispatcherImpl::getSnapshot() 09 blink::protocol::DOMSnapshot::DispatcherImpl::dispatch() 10 blink::protocol::UberDispatcher::dispatch() 11 blink::InspectorSession::DispatchProtocolMessage() 12 blink::WebDevToolsAgentImpl::Session::DispatchProtocolCommand() 13 blink::mojom::blink::DevToolsSessionStubDispatch::Accept() 02 blink::DOMNodeIds::IdForNode() 03 blink::CompositedLayerMapping::CreateGraphicsLayer() 04 blink::CompositedLayerMapping::CreatePrimaryGraphicsLayer() 05 blink::CompositedLayerMapping::CompositedLayerMapping() 06 blink::PaintLayer::EnsureCompositedLayerMapping() 07 blink::PaintLayerCompositor::AllocateOrClearCompositedLayerMapping() 08 blink::CompositingLayerAssigner::AssignLayersToBackingsInternal() 09 blink::CompositingLayerAssigner::Assign() 10 blink::PaintLayerCompositor::UpdateIfNeeded() 11 blink::PaintLayerCompositor::UpdateIfNeededRecursiveInternal() 12 blink::PaintLayerCompositor::UpdateIfNeededRecursive() 13 blink::LocalFrameView::UpdateLifecyclePhasesInternal() 14 blink::LocalFrameView::UpdateAllLifecyclePhases() 15 blink::PageAnimator::UpdateAllLifecyclePhases() 16 blink::PageWidgetDelegate::UpdateLifecycle() 17 blink::WebViewImpl::UpdateLifecycle() 18 blink::WebViewFrameWidget::UpdateLifecycle() 19 content::RenderWidget::UpdateVisualState() 20 content::RenderWidgetCompositor::UpdateLayerTreeHost() 21 cc::LayerTreeHost::RequestMainFrameUpdate() Currently, this test doesn't appear to be flaky. I am working on: https://crbug.com/831155. It causes the navigation to commit slightly faster. The test fails one time out of four, all the backendNodeId in getSnapshot() are shifted by one. Bug: 831155 Change-Id: I83a30202877bb65953957438284062f13fabeb6c Reviewed-on: https://chromium-review.googlesource.com/1101693Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#567640}
-
Alex Newcomer authored
Fixes menu positioning miscalculations in MenuController. Bug: 852153 Change-Id: I494bf3b80e33712d515c1369a0fa1be9e3c3e90b Reviewed-on: https://chromium-review.googlesource.com/1101966Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#567639}
-
jonross authored
There were capacity issues when we last added viz_browser_tests to Windows. However based on discussions in https://crbug.com/829187 there appears to be capacity on Win7 Tests (dbg)(1). This change re-eanbles them on that config. TEST=viz_browser_tests Bug: 851631 Change-Id: Ie5f33ee667097faf0a1aadc3b5e23b85b2bd1aca Reviewed-on: https://chromium-review.googlesource.com/1096078 Commit-Queue: Jonathan Ross <jonross@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#567638}
-
Rohit Rao authored
Screenshots: https://bugs.chromium.org/p/chromium/issues/detail?id=805521#c11 BUG=805521,805522 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Iee04f09c04a95a58368ee8cd9b51448729b437aa Reviewed-on: https://chromium-review.googlesource.com/1101218Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#567637}
-
Takayoshi Kochi authored
Between when a host element with its shadow root gets orphaned and when it gets connected again, its slot assignment can become dirty by some DOM mutation of its host children, but slots still hold stale assigned nodes. When a detached host child becomes an ancestor of the shadow host, unless those cached assigned nodes are cleared, it can make a cycle during DetachLayoutTree() traverses down to those cached nodes. See the case (cyclic-detach-crash2.html) for details. Bug: 847056, 845770 Change-Id: I44d3c118c9810ad3847fa24d630b7ddb9f9d2e50 Reviewed-on: https://chromium-review.googlesource.com/1100718Reviewed-by:
Hayato Ito <hayato@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Takayoshi Kochi <kochi@chromium.org> Cr-Commit-Position: refs/heads/master@{#567636}
-
Emily Hanley authored
TBR=charliea@chromium.org NOTRY=true Bug: 853199 Change-Id: I6059004feb8134ee163294f035d42188113d0940 Reviewed-on: https://chromium-review.googlesource.com/1102349Reviewed-by:
Emily Hanley <eyaich@chromium.org> Commit-Queue: Emily Hanley <eyaich@chromium.org> Cr-Commit-Position: refs/heads/master@{#567635}
-
Robert Liao authored
This reverts commit a2a4e677. Reason for revert: Fails virtual/layout_ng_experimental/printing/ellipsis-printing-style.html on https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Win10/ starting at 36497 Original change's description: > [LayoutNG] hidden overflow still contributes to scrollWidth > > Bug: 849751 > Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng > Change-Id: I8c203eb45b980539b22dc5838f4546ed200323de > Reviewed-on: https://chromium-review.googlesource.com/1101826 > Commit-Queue: Aleks Totic <atotic@chromium.org> > Reviewed-by: Koji Ishii <kojii@chromium.org> > Cr-Commit-Position: refs/heads/master@{#567578} TBR=kojii@chromium.org,atotic@chromium.org Change-Id: Ied593263c291a73864e9c9830c6f4dd747ee4377 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 849751 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Reviewed-on: https://chromium-review.googlesource.com/1102517Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#567634}
-
clamy authored
This CL is part of a serie of CLs to remove usage of the deprecated method NavigationController::GetActiveEntry. Bug: 273710 Change-Id: Id54366b63dbca52290f754e52267906e566f60f3 Reviewed-on: https://chromium-review.googlesource.com/1102465Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#567633}
-
Dominic Battre authored
This CL increases password readablity by preventing sequences of -- and __ which are rendered as long strokes in some fonts. At the same time it adds some new special characters that are "not scary" ('!' and ':'). Bug: 846694 Change-Id: I19d5b9007725943ac8eafe512339ef85a8c232e5 Reviewed-on: https://chromium-review.googlesource.com/1101208 Commit-Queue: Dominic Battré <battre@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#567632}
-
Francois Doray authored
This reverts commit 7a59e081. Reason for revert: https://crbug.com/853194 Original change's description: > GPU: Don't flush when destroying transfer buffers. > > Destroying a transfer buffer now requires only an ordering barrier, not > a full flush. This removes a source of unnecessary flushes and makes > resizing the transfer buffer more efficient. > > Bug: 850271, 835353, 828363 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > Change-Id: I9bfe43c46c00f8e9fc29e6450da788f86e74bc52 > Reviewed-on: https://chromium-review.googlesource.com/1093580 > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Reviewed-by: Antoine Labour <piman@chromium.org> > Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org> > Commit-Queue: James Darpinian <jdarpinian@chromium.org> > Cr-Commit-Position: refs/heads/master@{#567494} TBR=sunnyps@chromium.org,rsesek@chromium.org,piman@chromium.org,jdarpinian@chromium.org No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 850271, 835353, 828363 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I7cd21d6cee9beca02ae28da8614a58e2f53dc848 Reviewed-on: https://chromium-review.googlesource.com/1102346 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#567631}
-
Emily Hanley authored
system_health.memory_mobile/browser:media:youtube system_health.memory_mobile/browse:new:cnn TBR=charliea@chromium.org NOTRY=true Bug: 853190 Change-Id: Id51228dccae8dc8d1f03f608f03183b54c79eec6 Reviewed-on: https://chromium-review.googlesource.com/1102344Reviewed-by:
Emily Hanley <eyaich@chromium.org> Commit-Queue: Emily Hanley <eyaich@chromium.org> Cr-Commit-Position: refs/heads/master@{#567630}
-
Nico Weber authored
When the chromium.clang waterfall was converted to have its json files autogenerated in https://chromium-review.googlesource.com/c/chromium/src/+/818075 ToTMac was the only bot that ran 'isolated_scripts': 'chromium_isolated_scripts', in waterfalls.pyl (to get telemetry tests and crash tests). chromium_isolated_scripts also includes webkit_layout_tests, but until https://chromium-review.googlesource.com/c/chromium/src/+/1060293 it was excluded on ToTMac. Since that CL landed, ToTMac is the only tot bot running layout tests. (We should probably add chromium_isolated_scripts to the other bots too.) It looks like layout tests don't fully pass on macOS 10.13 yet, so pin them to 10.12 swarming slaves, like the Mac10.13 Tests bot does. Bug: 843511 Change-Id: I92c02169e49dd9cce729e32f200149e6bceb5eb7 Reviewed-on: https://chromium-review.googlesource.com/1102478Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#567629}
-
Mark Pilgrim authored
TBR=sdefresne@chromium.org Bug: 844974 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ie3e26e7fb7ce5e2624c45927f03f0ee8613f766a Reviewed-on: https://chromium-review.googlesource.com/1097213 Commit-Queue: Mark Pilgrim <pilgrim@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#567628}
-
Emily Hanley authored
TBR=charliea@chromium.org NOTRY=true Bug: 853188 Change-Id: I97662b6f615018d4e792185f5bf8786527e9b0b1 Reviewed-on: https://chromium-review.googlesource.com/1102343Reviewed-by:
Emily Hanley <eyaich@chromium.org> Commit-Queue: Emily Hanley <eyaich@chromium.org> Cr-Commit-Position: refs/heads/master@{#567627}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/d02fd6682709..31767de5cf0a git log d02fd6682709..31767de5cf0a --date=short --no-merges --format='%ad %ae %s' 2018-06-15 nednguyen@google.com Add wait to make sure that activate tab call wait for the tab to be foregrounded Created with: gclient setdep -r src/third_party/catapult@31767de5cf0a The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:851463 TBR=sullivan@chromium.org Change-Id: I41847b83c6fbe4d7c0052e9a49dc38ef2f46c464 Reviewed-on: https://chromium-review.googlesource.com/1102399Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#567626}
-
David Roger authored
This CL makes DicePrepareMigration the default in profile_management_switches. The entry fieldtrial_testing_config can now be removed. sync_confirmation_handler tests are updated to no longer require or test the OneClickSigninSyncStarter Change-Id: I214b4c50da08f5c2ae49883b21ed18a717157a19 Bug: 781761 Reviewed-on: https://chromium-review.googlesource.com/1088612Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#567625}
-
Yuki Shiino authored
ExceptionState is a fundamental utility to throw an exception. Moving ExceptionState into platform/ enables us to implement utilities in platform/ that need to throw exceptions. Bug: 849607 TBR: jbroman@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ic3b3e5ad09e80510049399a70b7d9e5de0b81a9f Reviewed-on: https://chromium-review.googlesource.com/1100732 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#567624}
-
Mathieu Perreault authored
Permanent error string and "Update card" links. Bug: 850571 Test: none Change-Id: Ic5f726363336ac7c2e860d8794e3614d3654627d Reviewed-on: https://chromium-review.googlesource.com/1102038 Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#567623}
-
David Bokan authored
These are all currently failing in ToT when run with --enable-slimming-paint-v2 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ia4b74131b00a26bfc5ba074472aac863cafad484 Reviewed-on: https://chromium-review.googlesource.com/1102170 Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#567622}
-
Anders Hartvoll Ruud authored
R=futhark@chromium.org Bug: 853062 Change-Id: I3cc1727fb5696b53810589994d864dcd579ddfc9 Reviewed-on: https://chromium-review.googlesource.com/1102325Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Anders Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#567621}
-
Kush Sinha authored
Bug: 851455 Change-Id: I4570ad8ae909ec32015f38deb1d3d8339f55582f Reviewed-on: https://chromium-review.googlesource.com/1095102Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#567620}
-
Thomas Tangl authored
The consent bump now is only shown when there is no refresh token error, i.e. when the user is in a sync-paused state. This can happen because of a local sign-out of Gmail for instance. Bug: 819909 Change-Id: I57e3d0427897acea095ff33933126bbf1dde20a9 Reviewed-on: https://chromium-review.googlesource.com/1102326 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#567619}
-
Dmitry Gozman authored
We always pass kNavigationPolicyCurrentTab from FrameLoader, which is turned into kNavigationPolicyNewForegroundTab. This observation allows us to remove dead branches in EffectiveNavigationPolicy and simplify some calls there. Bug: 849055 Change-Id: I9d1c08fba784111f3a544685da3f69c69380bedc Reviewed-on: https://chromium-review.googlesource.com/1100243Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#567618}
-
Allen Bauer authored
The previous CL (https://crrev.com/c/1089723) only focused on getting the tab colors from the browser frame. This CL focuses on ensuring the tab strip is notified of activation and color changes so those colors can be recalculated. Bug: 852388 Change-Id: Ib66c43038e1e8ea823fe991e55239754e5fce097 Reviewed-on: https://chromium-review.googlesource.com/1099048Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#567617}
-
Saman Sami authored
Use NavigationAndFirstPaintWaiter to ensure we wait for the first paint. Bug: 843921 Change-Id: Ia469d2460adf71f7151e2874bed034d6d3acbf10 Reviewed-on: https://chromium-review.googlesource.com/1101641Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#567616}
-
Thomas Tangl authored
When the user is signed into Chrome and clicks the profile card in the user menu, they are now directed to chrome://settings/people. Bug: 852092 Change-Id: I89c770869232956ae8fb00a61cad8ebb6375532f Reviewed-on: https://chromium-review.googlesource.com/1102422Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#567615}
-
Rune Lillesveen authored
Do style recalc for re-attachment in the RecalcStyle machinery. Change-Id: Ic16542e1914fbaf0fa4ed743e67762f577a3f320 Reviewed-on: https://chromium-review.googlesource.com/1098968 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Anders Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#567614}
-
Vadym Doroshenko authored
Bug: 853149, 831123 Change-Id: I973730d248c560859bc1328fd655bc24fb28ecee Reviewed-on: https://chromium-review.googlesource.com/1102423Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#567613}
-
kylechar authored
Things stored in the various FrameSinkManagerImpl maps have pointers back to SurfaceManager and HitTestManager. Ensure the maps are destroyed first. Bug: 850198 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: Iadb554ff7079ec91a8220c211790af0671c36335 Reviewed-on: https://chromium-review.googlesource.com/1101545Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#567612}
-
jonross authored
Update skip list for telemetry_perf_unittests on viz. Bug: 799594 Change-Id: I18737703c6e98e0275a2fa2b3f99e339529e6c49 Reviewed-on: https://chromium-review.googlesource.com/1101457Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#567611}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/67c2514bf571..d02fd6682709 git log 67c2514bf571..d02fd6682709 --date=short --no-merges --format='%ad %ae %s' 2018-06-15 perezju@chromium.org [Telemetry] Do not clear Chrome command line on Android after create Created with: gclient setdep -r src/third_party/catapult@d02fd6682709 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:849703 TBR=sullivan@chromium.org Change-Id: I6c647e93a0655db67aed5c093f5b0eb0bcc23b70 Reviewed-on: https://chromium-review.googlesource.com/1102397Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#567610}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/3df694fe1174..b7a72a501713 git log 3df694fe1174..b7a72a501713 --date=short --no-merges --format='%ad %ae %s' 2018-06-15 caryclark@skia.org fix bookmaker Created with: gclient setdep -r src/third_party/skia@b7a72a501713 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=csmartdalton@chromium.org Change-Id: I7d714f4c900aee21c7f81e150394c44ffe6cd60a Reviewed-on: https://chromium-review.googlesource.com/1101733Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#567609}
-
Maksim Sisov authored
It's now possible to create menu/popup windows in ozone/wayland. What is more, Ozone/Wayland now implements xdg popup objects, which are used for such windows as menus. Basically, popup windows are the only windows, which clients are able to set to whatever place they want on top of a parent window (global coordinates are not available). The FakeServer has also been extended to support xdg popup and positioner objects. What is more, ownership model for the new added objects is a bit different. Instead of keeping them owned by surfaces, they are making use of helper template methods with wl_resource_set_implementation, which automatically take and release unique_ptrs. In the future, all the other mock objects must be turned to that model for simplicity. TEST=XdgVersionV5Test or XdgVersionV6Test WaylandWindowTest.CreateAndDestroyMenuWindow/0, WaylandWindowTest.CreateAndDestroyNestedMenuWindow/0, WaylandWindowTest.CanDispatchEventToMenuWindowNested/0, WaylandWindowTest.CanDispatchEventToMenuWindowNonNested/0 (1 ms) Bug: 578890 Change-Id: Ia644862cce34375d3a758d8c0ff398c75dd47772 Reviewed-on: https://chromium-review.googlesource.com/1075309 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#567608}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/9eb38866cd65..8643b78750bb git log 9eb38866cd65..8643b78750bb --date=short --no-merges --format='%ad %ae %s' 2018-06-15 ilnik@webrtc.org Moved NackModule and VCMPacket to their own targets 2018-06-15 kwiberg@webrtc.org Remove support for old test modes in EncodeDecodeTest 2018-06-15 kwiberg@webrtc.org Remove dead RED code in TestRedFec 2018-06-15 kwiberg@webrtc.org Remove executable insert_packet_with_timing 2018-06-14 titovartem@webrtc.org Revert "Drop tools/gyp from dependencies." 2018-06-14 zhihuang@webrtc.org Use RTC_HISTOGRAM_ENUMERATION to report SRTP/SRTCP unprotect error. Created with: gclient setdep -r src/third_party/webrtc@8643b78750bb The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng // All bots passed except for a bot that is purple (unrelated to changes). NOTRY=True BUG=chromium:b/110121202 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I33ad7e85945fd9c2bbeca37c2e94a9557ee77fd0 Reviewed-on: https://chromium-review.googlesource.com/1101734Reviewed-by:
Henrik Boström <hbos@chromium.org> Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#567607}
-
Greg Kraynov authored
Removed outdated TODO. Removed unnecessary use of ThreadTaskRunnerHandle. Change-Id: Ib9f36222c6fd8745d94177fe0762188fdd551fa9 Reviewed-on: https://chromium-review.googlesource.com/1102327 Commit-Queue: Greg Kraynov <kraynov@chromium.org> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#567606}
-