- 16 Sep, 2019 29 commits
-
-
Matt Giuca authored
Bug: 1001405 Change-Id: I918c57d6922915e624b731432b393311d8ab1a3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1802780 Commit-Queue: Matt Giuca <mgiuca@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#696721}
-
David Vallet authored
Bug: 937152 Change-Id: Ibf516ba18d596dd82f15cdcb060c7bd3e0345863 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803946Reviewed-by:
David Vallet <dvallet@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Auto-Submit: David Vallet <dvallet@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#696720}
-
Keishi Hattori authored
This reverts commit 0d7047f8. Reason for revert: Caused regression in memory usage Bug: 1003130 Original change's description: > [Resolve Leak Error]Make ScriptValue Traceable > > We made ScriptValue Traceable to replace SharedPersistent > with TraceWrapperV8Reference in a follow-up CL. > > In this CL, most of the changes are just: > - Replace Vector<ScriptValue> with HeapVector<ScriptValue> because > ScriptValue has a Trace method. > - Add a trace method for ScriptValue and ScriptPromise since > they have objects to Trace. > > We recommend you to mainly check > - script_value.h where I add VectorTraits. > - script_promise.h where I add VectorTraits. > - v8_callback_function.py where I add a code to generate HeapVector. > - v8_types.py > * Add ScriptValue and ScriptPromise to "is_traceable==True" > which is used to generate Trace method & HeapVector. > > + I removed code to detect leak around ScriptPromise because > ScriptPromise no longer has persistent which may cause memory leak. > > Bug: 998994 > Change-Id: I63fcbf01de099577fe14045785b3072c615d78c4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792583 > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Keishi Hattori <keishi@chromium.org> > Reviewed-by: Yuki Shiino <yukishiino@chromium.org> > Reviewed-by: Kouhei Ueno <kouhei@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Commit-Queue: Rika Fujimaki <rikaf@google.com> > Cr-Commit-Position: refs/heads/master@{#695505} TBR=peria@chromium.org,yukishiino@chromium.org,haraken@chromium.org,keishi@chromium.org,kouhei@chromium.org,rikaf@google.com Change-Id: I35a1c06c1e9079950e03023f7577b28ca0811bef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803942Reviewed-by:
Keishi Hattori <keishi@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#696719}
-
Andrew Moylan authored
Bug: chromium:1000119 Change-Id: I2da457de5901a8771b249bb19c2f6edb6895e3b1 Tested: No Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782020 Commit-Queue: Andrew Moylan <amoylan@chromium.org> Reviewed-by:
Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#696718}
-
Giovanni Ortuño Urquidi authored
TBR=afakhry@chromium.org Bug: 1003339 Change-Id: I49bdda14651699c562dbfc25be3ce434d570ab54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803945Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#696717}
-
Jinsuk Kim authored
This CL makes half/full state height of BottomSheet dynamic so that the sheet can have both half/full state and keep the content wrapped. Gesture navigation shows how it can be used as an example. By overriding BottomSheetContent.getCustomized{Half,Full}Ratio: - The sheet expands to the half state with content wrapped. The height is maxed out at the half the container height. - If slided up, the content moves to the full state, the content still wrapped. The height is maxed out at the full container height, and the content becomes scrollable if necessary. Bug: 993051 Change-Id: I7e000716ee6b544b541d385e34cae026d64798d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1781123 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#696716}
-
Maksim Sisov authored
To make ozone/linux really use the DesktopWindowTreeHostLinux, it is also needed to share the BrowserDesktopWindowTreeHost* impl between X11/linux and ozone/linux. This CL renames the BrowserDesktopWindowTreeHostX11 to BrowserDesktopWindowTreeHostLinux and adds some USE_X11 guards, which will be removed in the future. Bug: 990756 Change-Id: Id99d63a627257fbaca7e5de65ec4973d8396d4fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796547 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#696715}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I82d3c60b12de9f9a0e5ceaf9fb1e960678c12e6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1805482Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#696714}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/cb52badca04a..561b90bd1d76 git log cb52badca04a..561b90bd1d76 --date=short --no-merges --format='%ad %ae %s' 2019-09-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 46548997..48c8f915 (416 commits) Created with: gclient setdep -r src/third_party/skia@561b90bd1d76 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC brianosman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=brianosman@google.com Bug: chromium:None Change-Id: Ifc855099d1236306a8a286dba2e706340bc10950 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1805481Reviewed-by:
-
Fergal Daly authored
This bug was introduced https://crrev.com/c/1772850. Set.add does not take multiple arguments, so most revealed elements were not added to the observed set. Bug: 1004102 Change-Id: If57b3125a54a52e1d0fd242c29b059b1cf69b2cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804096 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by:
Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/master@{#696712}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/6fe107e0feca..b8a20f9d9f71 git log 6fe107e0feca..b8a20f9d9f71 --date=short --no-merges --format='%ad %ae %s' 2019-09-16 sidereal@google.com Update GUEST_IMAGES_PINS_PATH Created with: gclient setdep -r src/third_party/chromite@b8a20f9d9f71 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I93e870fa735a44d73d031a5aa8dde2a93d43b9ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1805479Reviewed-by:
-
Jeevan Shikaram authored
This CL adds a no-search tag to the os-settings/app-management subpage. This prevents the search provider from loading the App Management subpages as this can lead to long search times and recursive behaviors. Bug: 1003277 Change-Id: Ie72a574bf0e040961fa6f79b6281af8fbedf6457 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804697 Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Auto-Submit: Jeevan Shikaram <jshikaram@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#696710}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/fcbe4071ce46..7af1bb3f90b3 git log fcbe4071ce46..7af1bb3f90b3 --date=short --no-merges --format='%ad %ae %s' 2019-09-16 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 9f151687..1d12ff69 (696593:696696) Created with: gclient setdep -r src/third_party/webrtc@7af1bb3f90b3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: I97cb84522a0b5b125039d68c447f6680642a16a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1805478Reviewed-by:
-
Giovanni Ortuño Urquidi authored
This reverts commit cfc19ddd. Reason for revert: Initial revert didn't fix failures. Original change's description: > Revert "DevTools: Add ARIAUtils.setCheckboxAsIndeterminate" > > This reverts commit 2cf002af. > > Reason for revert: Breaks http/tests/devtools/a11y-axe-core/basic-a11y-test.js and 5 other(s), see issue 1004150 - locally identified > tests as fixed when reverting this CL (on Linux) > > Original change's description: > > DevTools: Add ARIAUtils.setCheckboxAsIndeterminate > > > > This adds a new API to UI.ARIAUtils to set an element's aria-checked > > attribute to 'mixed', which is the equivalent of setting > > intedeterminate=true on an actual checkbox element. > > This is needed to support keyboard accessibility in the javascript and > > event listener breakpoints views. > > > > Equivalent to the Animation checkbox in this screenshot: > > https://gyazo.com/99f2067f6810af3366943176393d8b2f > > > > Bug: 963183 > > Change-Id: Ie09f8e993d1776774c410f6099356f3a1d912048 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715815 > > Reviewed-by: Pavel Feldman <pfeldman@chromium.org> > > Auto-Submit: Jack Lynch <jalyn@microsoft.com> > > Commit-Queue: Jack Lynch <jalyn@microsoft.com> > > Cr-Commit-Position: refs/heads/master@{#696551} > > TBR=pfeldman@chromium.org,einbinder@chromium.org,jalyn@microsoft.com > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 963183, 1004150 > Tbr: ortuno@ > Change-Id: I3ef2a4a5b74be00de669db215f27c2586acba40f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803937 > Commit-Queue: Dominik Röttsches <drott@chromium.org> > Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Reviewed-by: Dominik Röttsches <drott@chromium.org> > Cr-Commit-Position: refs/heads/master@{#696700} TBR=pfeldman@chromium.org,drott@chromium.org,ortuno@chromium.org,einbinder@chromium.org,jalyn@microsoft.com Change-Id: I433a1549e7f1ef909fe2b3b0fc2cea584bceafcd No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 963183, 1004150 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804703Reviewed-by:
-
Alan Cutter authored
This CL moves kSaveCard and kLocalCardMigration PageActionIcons into the OmniboxPageActionIconContainerView so they can be reused by PWA windows. This removes them from the LocationBarView and makes them conform to the interface used by the majority of the PageActionIcons. Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=411699&signed_aid=oN3fSiCBdesl2B-kWaptBQ==&inline=1 After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=411700&signed_aid=PouzN_Ing1hmoMWdLqXZVA==&inline=1 Bug: 788051 Change-Id: Iebc963bdf24eeb5e16257065f79caefdc9158dba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803018 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#696707}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/3de1b8d0b098..cc17f852d575 git log 3de1b8d0b098..cc17f852d575 --date=short --no-merges --format='%ad %ae %s' 2019-09-15 :avih [cmake] Don't fail if brotli is missing (#56894). Created with: gclient setdep -r src/third_party/freetype/src@cc17f852d575 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:mac10.13_retina-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel TBR=bungeman@google.com,drott@google.com,thestig@google.com Bug: None Change-Id: I23f67d997c39dbae01bbee0e7f577d946c5e718f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1805917Reviewed-by:
-
Eric Willigers authored
In preparation for testing with WebAppBrowserController, change BookmarkAppTest to use WebAppControllerBrowserTest. Similar to reverted CL https://chromium-review.googlesource.com/c/chromium/src/+/1787758 which experienced win-asan failures with observer lists on shutdown. Observer list issues on shutdown have been addressed by https://chromium-review.googlesource.com/c/chromium/src/+/1800884 Bug: 966290 Change-Id: I1180a12ad4a2f23255f9c711a40da21e71a5d205 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801401Reviewed-by:
-
Emil A Eklund authored
Remove a DCHECK in ng_absolute_utils liable to trigger incorrectly when any combination of the component values are near the saturation limits. Bug: 1002317 Change-Id: I1bc22823dd72a23c162eecb2f3c676e059617817 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804937 Commit-Queue: Emil A Eklund <eae@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#696704}
-
Eric Willigers authored
InstallableManager::CheckServiceWorker() now quits immediately if called after the service worker context has been destroyed. Bug: 993666 Change-Id: Idcb336f5532d52e9181c85f71a255579ae0f0cc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1806159 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#696703}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a5cce89fe5f6..bdf64c9f6d8e Created with: gclient setdep -r src-internal@bdf64c9f6d8e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I3e4d0deb9ab6e25a56a0bb920e0213731a0a9c01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1805477Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#696702}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: Iec9a010782222ae75eff8aaf74a3a0e4eca6f86d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804325Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#696701}
-
Dominik Röttsches authored
This reverts commit 2cf002af. Reason for revert: Breaks http/tests/devtools/a11y-axe-core/basic-a11y-test.js and 5 other(s), see issue 1004150 - locally identified tests as fixed when reverting this CL (on Linux) Original change's description: > DevTools: Add ARIAUtils.setCheckboxAsIndeterminate > > This adds a new API to UI.ARIAUtils to set an element's aria-checked > attribute to 'mixed', which is the equivalent of setting > intedeterminate=true on an actual checkbox element. > This is needed to support keyboard accessibility in the javascript and > event listener breakpoints views. > > Equivalent to the Animation checkbox in this screenshot: > https://gyazo.com/99f2067f6810af3366943176393d8b2f > > Bug: 963183 > Change-Id: Ie09f8e993d1776774c410f6099356f3a1d912048 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715815 > Reviewed-by: Pavel Feldman <pfeldman@chromium.org> > Auto-Submit: Jack Lynch <jalyn@microsoft.com> > Commit-Queue: Jack Lynch <jalyn@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#696551} TBR=pfeldman@chromium.org,einbinder@chromium.org,jalyn@microsoft.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 963183, 1004150 Tbr: ortuno@ Change-Id: I3ef2a4a5b74be00de669db215f27c2586acba40f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803937 Commit-Queue: Dominik Röttsches <drott@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#696700}
-
Stephen McGruer authored
https://drafts.csswg.org/css-transitions/#interface-globaleventhandlers-idl Intent to ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/dxDGBFKvO3A Bug: 868224 Change-Id: I68b33822badc36c3cebcdca7bf6f47d834160270 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797226Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#696699}
-
Leon Han authored
nfc_constants.{cc,h} just defines some const texts like error messages etc. that we can just use directly in code. BUG=520391 Change-Id: Ied00da5594f22d07d9328d75874e9a2d54f8feff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797368 Commit-Queue: Leon Han <leon.han@intel.com> Auto-Submit: Leon Han <leon.han@intel.com> Reviewed-by:Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#696698}
-
Alan Cutter authored
This CL replaces BrowserWindow::GetOmniboxPageActionIconContainer() BrowserWindow::GetToolbarPageActionIconContainer() with BrowserWindow::UpdatePageActionIcon(type) BrowserWindow::ExecutePageActionIconForTesting(type) in order to hide the implementation detail of which container any given icon resides in. This is in preparation for adding more page-action-icons to PWA windows which only have one container. This is a pure refactor with no behavioural changes. Bug: 788051 Change-Id: I71a4e117db7595ac2bccdafc454f76e6b27c3bac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792521 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
-
Koji Ishii authored
This patch changes positions in |ShapingLineBreaker| from |LayoutUnit| to |float|. This change turns a few operations from |LayoutUnit| to |float|, but because |CachedPositionForOffset| uses |float|, it avoids a few casts between |LayoutUnit| and |float|, and avoids complexities caused by casting twice (|float| -> |LayoutUnit| -> |float|.) This patch can fix issue 1002442 without the previous one by eliminating snapping, because the issue occurs by the errors in snapping to |LayoutUnit|. There seems to be slight difference in the behavior, such as when extreme letter-spacing is used and positions become inifite numbers. The new behavior seems to be more correct, though an experiment to use the overflow state of |ShapingLineBreaker| more (crrev.com/c/1803994) in |NGLineBreaker| breaks slightly differently. Bug: 1002442, 1003742 Change-Id: I5ece8478b99fe76e7aa798b98cab64f24a95d5af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801394Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#696696}
-
Matt Giuca authored
- Added tests for scope parameter. - Added lots of different types and values for inputs. - Tests which value is set, not just the type of value. - Fixed assert argument order and fix failure messages. Explainer (current, but vague): https://github.com/WICG/badging/blob/master/explainer.md Spec (out of date): https://wicg.github.io/badging/ Bug: 987514, 1000968, 1001404, 1001405 Change-Id: I518ff82a81c9a56bd45421cf8b7b16b9855a7ba6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788966 Commit-Queue: Matt Giuca <mgiuca@chromium.org> Reviewed-by:
-
Rune Lillesveen authored
This makes us match how Firefox applies minimum font-size and makes us not break relative length computation when pages use a font-size less than the user's minimum font-size as a basis for widths, heights, margins, padding, etc. This is a behavioral change for relative lengths for the following cases: - minimum-font-size does not affect em lengths - minimum-logical-font-size does not affect em lengths - text autosizing does not affect em lengths - text scaling accessibility setting in Chrome for Android does not affect em lengths Test expectation changes and reasons: Text scaling no longer applies to relative lengths (text zoom set from testRunner): svg/zoom/text/zoom-hixie-mixed-008.xml svg/zoom/text/zoom-hixie-rendering-model-004.xhtml svg/zoom/text/zoom-svg-float-border-padding.xml Minimum logical font-size not applying to relative lengths (minimum logical font-size set to 9px when running layout tests): fast/backgrounds/background-position-parsing.html virtual/controls-refresh/fast/forms/controls-new-ui/password/password-eye-icon-zoom-0.5x.html http/tests/misc/object-embedding-svg-delayed-size-negotiation-2.htm Bug: 308862 Change-Id: I5e5fb99e69b516c9c0c3758d232cbae8f7f5894a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803281Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1843b085ee93..a5cce89fe5f6 Created with: gclient setdep -r src-internal@a5cce89fe5f6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I8da01f897bba9efa239599d9cefa92cdebf4b959 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1805857Reviewed-by:
-
- 15 Sep, 2019 11 commits
-
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I990d21b752327dc982d0df087fc84a618c99e765 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1805308Reviewed-by:
-
tby authored
There is a bug where a Drive file can be deleted via DriveFS, which takes a few seconds to propagate back to the Drive QuickAccess results, creating a window where we could surface a Drive file that can't be launched. We already deal with this for local files by checking they exist on-disk before finalizing the results, so this CL does the same thing for Drive files. integration service right now. Tested: manually, as we don't have a good way of mocking the drive Bug: 1003588 Change-Id: I3ad839c18ad0dbb28fec13141e756993a4b65c74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1802775Reviewed-by:
Jia Meng <jiameng@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#696691}
-
tby authored
We currently trigger a prefetch of Drive QuickAccess results via the AppListClientImpl::ViewShown method, which misses some launcher uses in tablet mode, leading to stale Drive results in zero state. There's a simple fix for this: AppListControllerImpl:: OnAppListVisibilityChanged is called in exactly the cases we want to prefetch. Note: this doesn't solve the issue of possibly stale results if the user sits on the home screen app list for a long time, that will come in a follow-up CL. Bug: 959679 Change-Id: Idf2c489ee39c2625ddd84622f42c160837442e1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798080Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Auto-Submit: Tony Yeoman <tby@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#696690}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/52a8c7a0d882..1843b085ee93 Created with: gclient setdep -r src-internal@1843b085ee93 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I108ac4b62e74513155734dd879e3fe5861af1075 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1805971Reviewed-by:
-
Kevin Qin authored
Test runtime actually updates IPD after session starts. In this test, I checked if runtime passed the IPD to js side. But we have to notice that fov and ipd is only updated in the following conditions: 1. "when the canvas element for this session's output context is resized." 2. when "ApplyPendingRenderState()" gets called Bug: 996502 Change-Id: I26496d0997290fbd2330a2a22e7dd1d40c5226ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793946 Commit-Queue: Zheng Qin <zheqi@microsoft.com> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#696688}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/af6fbc37d76b..52a8c7a0d882 Created with: gclient setdep -r src-internal@52a8c7a0d882 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I23ded47194d8a8e4d2fb86a48652fd41c2ae815a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1805903Reviewed-by:
-
chromium-autoroll authored
Roll ChromeOS orderfile from 78-3877.0-1567418235-benchmark-78.0.3893.0-r1 to 78-3877.0-1568022778-benchmark-78.0.3902.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-orderfile-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_EXTRA_TRYBOTS= TBR=c-compiler-chrome@google.com Change-Id: I1f35f1d88beecbd55322c5cbab9981e2929f7245 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1805923Reviewed-by:
-
Keishi Hattori authored
We should use asyncGC() instead of gc() to ensure a precise BlinkGC runs, so the wrapper object is collected. Bug: 1003268 Change-Id: I8210d6d718adb3490752c28f7647f287800d2c9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1800855Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Dominic Farolino authored
The network service's OnCancelURLRequestWithPolicyViolatingReferrerHeader method is called after it has been determined that a URLRequest's referrer does not match what the policy demands. This method performs a DumpWithoutCrash for debugging. However, this is called within the network service, so the path of the request's creation is not captured in the stack trace, making it less useful. This CL checks whether or not a request's referrer matches what its policy demands earlier, when a network::ResourceRequest is created by WebURLLoaderImpl. This captures a better picture of a renderer-initiated request's origins in the stack trace, which is much more useful for debugging. Bug: 1004083 Change-Id: I867e488a860e2ac042a1eb93bff04e5f10a3126e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803936 Commit-Queue: Dominic Farolino <dom@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#696684}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/da33810f35a7..af6fbc37d76b Created with: gclient setdep -r src-internal@af6fbc37d76b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Ic4c001f7e48230acb4b05eca364f20412f836e3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1805837Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I421c6dcb899623ebf71d3beffa407524f130aae5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804933Reviewed-by:
-
