- 18 Dec, 2017 40 commits
-
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/ad4583d06ecd..6c84ef00005b $ git log ad4583d06..6c84ef000 --date=short --no-merges --format='%ad %ae %s' 2017-12-15 nednguyen Update Telemetry README.md doc Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Ice1ade4c3957c65cb2854be4b586a49e9bd3f0ad Reviewed-on: https://chromium-review.googlesource.com/831849 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#524689}
-
Chromium WPT Sync authored
Using wpt-import in Chromium c0773253. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/8124 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jsbell@chromium.org: external/wpt/storage TBR=foolip No-Export: true Change-Id: I00dae81d55f6cb2d85bd69f84736c98bde35c5bf Reviewed-on: https://chromium-review.googlesource.com/831550 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#524688}
-
Rune Lillesveen authored
Adjusted how display:contents affect various SVG elements as specified in https://drafts.csswg.org/css-display/#unbox-svg By using IsOutermostSVGSVGElement() for svg root testing , this change also fixes 795685. Bug: 794498, 795685 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I6b45f1ad65cfe9b29378d9ea9f2c4f9d855da231 Reviewed-on: https://chromium-review.googlesource.com/829633 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#524687}
-
Mirko Bonadei authored
This reverts commit 7c1a115d. Reason for revert: I think this CL is still breaking Win8 and Win10: https://ci.chromium.org/buildbot/chromium.webrtc.fyi/Win10%20Tester/10071 https://ci.chromium.org/buildbot/chromium.webrtc.fyi/Win8%20Tester/3085 Original change's description: > Reland: Win video capture: use IMFCaptureEngine for Media Foundation > > Fixes for reland: > - "Win8 Tester" browser_tests_functional failure > - "Win8 Tester" capture_unittests failure > > Original description: > - Full rewrite of the MediaFoundation implementation video part to use > IMFCaptureEngine > - Implementation of takePhoto, setPhotoOptions and getPhotoCapabilities > - takePhoto triggers a still image capture with the highest available > resolution without stopping the video stream thanks to IMFCaptureEngine > > TEST=adapted video_capture_device_unittest.cc and > webrtc_image_capture_browsertest.cc; launch Chrome with > --force-mediafoundation on Win8+ and capture video using > e.g. https://webrtc.github.io/samples/src/content/getusermedia/gum/ > > R=mcasas@chromium.org > > Bug: 730068 > Change-Id: I3835a48ca8516fc66a6a8394b3709d4dea862f89 > Reviewed-on: https://chromium-review.googlesource.com/734042 > Commit-Queue: Christian Fremerey <chfremer@chromium.org> > Reviewed-by: Miguel Casas <mcasas@chromium.org> > Reviewed-by: Christian Fremerey <chfremer@chromium.org> > Cr-Original-Commit-Position: refs/heads/master@{#521435} > Reviewed-on: https://chromium-review.googlesource.com/810766 > Cr-Commit-Position: refs/heads/master@{#524417} TBR=mcasas@chromium.org,chfremer@chromium.org,alaoui.rda@gmail.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 730068 Change-Id: I04e276e3b9f42e7f8ec3a60fd8b9439788ad994f Reviewed-on: https://chromium-review.googlesource.com/831588 Commit-Queue: Olga Sharonova <olka@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#524686}
-
Tomasz Moniuszko authored
Bug: 638977 Change-Id: I3336f64fc9497417831afa24f8403a63b77797bb Reviewed-on: https://chromium-review.googlesource.com/817435 Commit-Queue: Tomasz Moniuszko <tmoniuszko@opera.com> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#524685}
-
Dominic Battre authored
A website may have an <input type="password"> that is dynamically changed to an <input type="text"> when the user clicks on an eye icon to reveal the password. This means that the text input field now has the user's password which is susceptible to learning for autofill and the Android keyboard. We should track the past state of input field and prevent learning if a field has ever been a password field. Bug: 794949 Change-Id: I14023dbf9f2e2449bc5155b4432cdb73c7bcc223 Reviewed-on: https://chromium-review.googlesource.com/827075Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Keishi Hattori <keishi@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#524684}
-
Leo Zhang authored
CL/179034570 asked for adding an entry for my experiment group. This change should resolve it. TBR=isherman@chromium.org Change-Id: I30de06b41f5266635cf2cab3b1710702cc9811af Reviewed-on: https://chromium-review.googlesource.com/831003Reviewed-by:
Leo Zhang <googleo@chromium.org> Commit-Queue: Leo Zhang <googleo@chromium.org> Cr-Commit-Position: refs/heads/master@{#524683}
-
Gauthier Ambard authored
When any button of the toolbar is pressed, the event should be logged. Also if the omnibox is being edited, the edit mode should be removed. This CL adds a method to add those actions to all buttons. Bug: 795257 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: If6b34153b6f2fcaa7fa9037f26a7f0a15ab75da2 Reviewed-on: https://chromium-review.googlesource.com/829315Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#524682}
-
Marc Treib authored
Some tests depend on the availability of the default prepopulated MV items from TopSites. Since TopSites loads asynchronously, it's possible that these items aren't available when a test runs, which manifests as test flakiness. This CL adds an explicit wait before running the tests. Bug: 793818 Change-Id: Iabb745f038bc44fc2d46ab263fe944b6e996412f Reviewed-on: https://chromium-review.googlesource.com/831524Reviewed-by:
Chris Pickel <sfiera@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#524681}
-
Christian Dullweber authored
This test is flaky on Windows as well. TBR=oysteine@chromium.org Bug: 723933 Change-Id: I07d581090a7d898bda7afadf298a141fb144d372 Reviewed-on: https://chromium-review.googlesource.com/831525Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#524680}
-
angle-deps-roller@chromium.org authored
https://chromium.googlesource.com/angle/angle.git/+log/647dca7672f7..a2d981418d78 $ git log 647dca767..a2d981418 --date=short --no-merges --format='%ad %ae %s' 2017-12-15 oetuaho Fix allowing non-constant ternary global initializer Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: Iec7b17bd0ff1703f8867cffe37e738fd69268452 Reviewed-on: https://chromium-review.googlesource.com/831846Reviewed-by:
angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#524679}
-
Jerome Jiang authored
This is a reland of 3d9bdee7 The reland is unmodified since it was not the root cause of the problem that motivated the initial revert. Original change's description: > Roll src/third_party/libvpx/source/libvpx/ cbe62b9c2..14dbdd95e (25 commits) > > https://chromium.googlesource.com/webm/libvpx.git/+log/cbe62b9c2d2b..14dbdd95e686 > > $ git log cbe62b9c2..14dbdd95e --date=short --no-merges --format='%ad %ae %s' > 2017-11-29 jianj Add frame width & height to frame pkt. Add test. > 2017-12-06 marpan vp9-svc: Set downsampling filter for VGA layer. > 2017-12-06 marpan vp9: Nonrd-pickmode: move some early exits up. > 2017-12-01 marpan vp9-svc: Allow for nonzero motion on spatial reference. > 2017-11-28 huisu Add max luma picture width/height constraint in VP9 level > 2017-12-01 johannkoenig filter out asm includes > 2017-12-01 johannkoenig explicitly label .text sections > 2017-12-01 johannkoenig nasm defaults to -Ox > 2017-12-01 johannkoenig pass 'win64' instead of 'x64' to the assembler > 2017-12-01 marpan vp9-svc: Set num_inter_modes in non-rd pickmode. > 2017-12-01 yinshiyou-hf vpx_dsp: [loongson] optimize variance v2. > 2017-11-30 marpan Nonrd-pickmode: avoid duplicate computation of UV predictor. > 2017-11-30 jzern decouple spatial-svc from encoder abi > 2017-11-29 marpan Fix to copy partition. > 2017-11-29 marpan vp9-svc: Don't allow encode_breakout on golden ref. > 2017-11-29 marpan vp9-svc: Clean conditon for allowing copy_partition. > 2017-11-29 kylesiefring Remove unnecessary includes of emmintrin_compat.h > 2017-11-29 yinshiyou-hf vp8: [loongson] optimize regular quantize v2. > 2017-11-29 kaustubh.raste mips msa optimize vpx_scaled_2d function > 2017-11-29 yinshiyou-hf vp8: [loongson] optimize vp8_short_fdct4x4_mmi v2. > (...) > > Created with: > roll-dep src/third_party/libvpx/source/libvpx > R=johannkoenig@google.com > > BUG=webrtc:5749 > > Change-Id: I2e26d723eaffb7fb999f4d1d77ea678519f0ef50 > Reviewed-on: https://chromium-review.googlesource.com/813088 > Reviewed-by: Johann Koenig <johannkoenig@google.com> > Commit-Queue: Jerome Jiang <jianj@google.com> > Cr-Commit-Position: refs/heads/master@{#522479} TBR=jianj@google.com, johannkoenig@google.com, holmer@chromium.org Bug: webrtc:5749 Change-Id: I8476d1d156f59a12ebc1f08c01e84fc09971dd2a Reviewed-on: https://chromium-review.googlesource.com/831587 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#524678}
-
Eric Lawrence authored
A change in Chrome 63 means that we now %-escape the ref component. Update the comments in GURL.h accordingly. Change-Id: I405e9897ebf05d5f0679184a33c6263a1928d5d9 Reviewed-on: https://chromium-review.googlesource.com/830890Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#524677}
-
Christian Dullweber authored
This test is timing out a lot. TBR=chenwilliam@chromium.org Bug: 795542 Change-Id: I8cc41394054c6ba835600ecde5eb0305e222d102 Reviewed-on: https://chromium-review.googlesource.com/831522Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#524676}
-
Mihai Sardarescu authored
As explained in https://bugs.chromium.org/p/chromium/issues/detail?id=789882#c4, on macOS clicking enter does not select the button that is currently focused. This breaks the behavior for the user menu. This CL changes the API for views::Button allowing the subclasses to customize the action for key events. It then changes the hover button to always support start a click action when the enter button is pressed. Bug: 789882 Change-Id: I2175ee765da71fcd34211f544057973f84cb0ac3 Reviewed-on: https://chromium-review.googlesource.com/824603 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#524675}
-
cm.sanchi authored
This patch mojofies the ChromeFrameMsg_GetWebApplicationInfo and ChromeFrameHostMsg_DidGetWebApplicationInfo message Bug: 789826 Change-Id: Iff07e66d41f56f85e9298fc8e2ba38ab00f3e734 Reviewed-on: https://chromium-review.googlesource.com/800130 Commit-Queue: Chandramouli Sanchi <cm.sanchi@samsung.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#524674}
-
Qiang Xu authored
changes: This is a revert of http://crrev.com/2923343004. This is speculative fix for crbug.com/776409. In m62, we introduced a way to prevent excessive chrome pull on portal detection test url. If we are behind portal, the new attempt is hopefully started when default network changed or connection state changed. Now that we have random hosts for portal detection test url, the effect of excessive test url pull is pretty alleviated. Revert it in hope of getting rid of some cases that stopped chrome side continuous portal detection. Bug: 776409, 702273 Test: None. This is a revert which shouldn't break anything. Change-Id: Ifaf30e5ed9bfcca235e356e064647c28e71fd02e Reviewed-on: https://chromium-review.googlesource.com/809851 Commit-Queue: Qiang(Joe) Xu (APAC) <warx@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#524673}
-
Hirokazu Honda authored
ProvidePictureBuffers() triggers AssignPictureBuffers() and ImportPictureBuffers() in this order. The size of an imported picture in ImportPictureBuffers() is updated in ProvidePictureBuffers(). However, ImportPictureBuffers() can be called between ProvidePictureBuffers() and ImportPictureBuffers(), when a client already queues ImportPictureBuffers() for old imported pictures. In this case, the size of an picture imported by ImportPictureBuffers is different from one updated in ProvidePictureBuffers. Therefore, verifyDmaBbuf() is failed. To resolve this problem, an imported picture size is updated in AssignPictureBuffers(), not ProvidePictureBuffers(). TEST=CtsMediaTestCases on minnie and eve BUG=b:70767025 Change-Id: I6451a0c9d86b21010fc72071f6d5a3e45dee590f Reviewed-on: https://chromium-review.googlesource.com/831324Reviewed-by:
Kuang-che Wu <kcwu@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#524672}
-
Sylvain Defresne authored
Some tests needs to create an image with a given scale, so add a function with a scale parameter. Bug: 795669 Change-Id: Ibdc6863a247c2035cbbd5fed64c5b0954cbb2327 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/831514Reviewed-by:
Elodie Banel <lod@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#524671}
-
Koji Ishii authored
As suggested by chrishtr@ at: https://groups.google.com/a/chromium.org/d/msg/layout-dev/O_D8ylaEyyE/wCiDNT8lCgAJ Bug: 714962 Change-Id: Ic53ff4c3f492e8201c4582fe2c7e497ee6b10050 Reviewed-on: https://chromium-review.googlesource.com/821393Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#524670}
-
Olivier Robin authored
CVV field in credit cards are unlikely to be the first field of a form. Allowing it result in wrong parsing in case there are two series of fields for two different kind of cards Exemple is on westelm.com. Form contains Westelm card number --------------------- Westelm verification number Credit card type Credit card number Credit card expiration --------------------- Credit card verification --------------------- is delimitation of what is considered as credit card fields at the moment. This CL forbids credit card to be the first field of the form. It preserve the exception of reattaching a verification to the previous card if it is an only field. Bug: 728845 Change-Id: Ie29b323666651e671b25246532c68407534bbb0c Reviewed-on: https://chromium-review.googlesource.com/809015Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#524669}
-
Yuta Kitamura authored
This patch only does mechanical replacements of the following: * WebTraceLocation -> base::Location * BLINK_FROM_HERE -> FROM_HERE * #include WebTraceLocation.h -> #include "base/location.h" There is no semantic change. Bug: 794845 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I6d02024027e6aad4ec20ec4d7ebfca201665b4c4 Reviewed-on: https://chromium-review.googlesource.com/831381Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Taiju Tsuiki <tzik@chromium.org> Commit-Queue: Yuta Kitamura <yutak@chromium.org> Cr-Commit-Position: refs/heads/master@{#524668}
-
Yuta Kitamura authored
This patch only does mechanical replacements of the following: * WebTraceLocation -> base::Location * BLINK_FROM_HERE -> FROM_HERE * #include WebTraceLocation.h -> #include "base/location.h" There is no semantic change. Bug: 794845 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ie5ab04332d46072a9a1b4d03d3fb4a8b952a5b25 Reviewed-on: https://chromium-review.googlesource.com/831316Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Taiju Tsuiki <tzik@chromium.org> Commit-Queue: Yuta Kitamura <yutak@chromium.org> Cr-Commit-Position: refs/heads/master@{#524667}
-
Daniel Murphy authored
Adapted from falken@'s patch here: https://chromium-review.googlesource.com/c/chromium/src/+/822019 Bug: 794104, 732750 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: If3e05ec30abb929794451c0fac7d141f416ebd2a Reviewed-on: https://chromium-review.googlesource.com/823374 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#524666}
-
Hiroki Nakagawa authored
Bug: 795658 Change-Id: Idb8f12e4d8c4fc738d425fd516231cfdcddbd8b3 TBR: dpapad@chromium.org Reviewed-on: https://chromium-review.googlesource.com/831319Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#524665}
-
chromeos-commit-bot@chromium.org authored
TBR=chrome-os-gardeners@google.com Change-Id: I32af73f1b55692f3ab81a423464553f5f4c3f167 Reviewed-on: https://chromium-review.googlesource.com/830753Reviewed-by:
ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#524664}
-
Wojciech Dzierżanowski authored
When run with the stub Widevine CDM, these tests suffer from a race between the result of a failed StubCdm::Decrypt() and a failed StubCdm::UpdateSession(). The tests expect the latter, but the former often arrives first. By allowing the stub to InitializeVideoDecoder() successfully and returning cdm::kNoKey upon DecryptAndDecodeFrame() attempt we avoid the DecryptingDemuxerStream errors altogether, so there is no race anymore. Bug: 768745 Test: 'browser_tests --gtest_filter=*MSE_Widevine*' pass when run with the stub Widevine CDM Change-Id: I35a35d006d118f8f7f9a8a64cf9334017644f4ea Reviewed-on: https://chromium-review.googlesource.com/831026Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Wojciech Dzierżanowski <wdzierzanowski@opera.com> Cr-Commit-Position: refs/heads/master@{#524663}
-
suyambu.rm authored
This CL adds customized Vulkan header for Skia. Bug: 582554 Change-Id: Iaac8127d71de3b9ffbba54b9dd68053aea9c0777 Signed-off-by:
suyambu.rm <suyambu.rm@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/816214 Commit-Queue: Chandan Padhi <c.padhi@samsung.com> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#524662}
-
Koji Ishii authored
This patch updates Unicode data in Character class: 1. UAX#50 Unicode Vertical Text[1] to rev 19 (Unicode 10). 2. IsCJKIdeographOrSymbol was not updated for a while, include ideographic characters to be in sync with UAX#50. 3. IsCJKIdeographOrSymbol includes all plane 2 rather than each block. [1] http://www.unicode.org/reports/tr50/ Change-Id: Ie8e7f3b45d340870be5d1316021b49231be9cdd2 Reviewed-on: https://chromium-review.googlesource.com/822551 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Reviewed-by:
Jungshik Shin <jshin@chromium.org> Cr-Commit-Position: refs/heads/master@{#524661}
-
Bugs Nash authored
Removing my name from all TODO's as part of ramp down off blink. This TODO is the only instance and is probably not possible. Bug: 545324 Change-Id: I85e90ef9cfe8af3ea207dcd2792849d57ef2e898 Reviewed-on: https://chromium-review.googlesource.com/831377Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#524660}
-
Hiroki Nakagawa authored
These tests are faling on the bot. Bug: 795645 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: If49997081c2034fea813724281bb8bf6fc3d81d3 TBR: fmalita@chromium.org Reviewed-on: https://chromium-review.googlesource.com/831005Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#524659}
-
depot-tools-roller@chromium.org authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/454acc12ef55..47d7464952b6 $ git log 454acc12e..47d746495 --date=short --no-merges --format='%ad %ae %s' 2017-12-18 dmurph Revert "[vpython] Bump depot_tools version of vpython." Created with: roll-dep src/third_party/depot_tools The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=phajdan.jr@chromium.org Change-Id: Ic3a791045cb00455899516a2866610a6a28246c8 Reviewed-on: https://chromium-review.googlesource.com/831162Reviewed-by:
depot-tools-roller . <depot-tools-roller@chromium.org> Commit-Queue: depot-tools-roller . <depot-tools-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#524658}
-
Naina Raisinghani authored
If a TODO was deleted it was either done/I don't understand the purpose anymore. Bug: Change-Id: I8fff96e71283f771e8d72f2c2c862115205512da Reviewed-on: https://chromium-review.googlesource.com/831315Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: nainar <nainar@chromium.org> Cr-Commit-Position: refs/heads/master@{#524657}
-
tanvir.rizvi authored
While executing insertTextCommand with text having paragraph seperator, on a unusual selection content which has a nested anchor element within same block, this crash happens. While insertion of the paragraph seperator, the |PositionAvoidingSpecialElementBoundary| algorithm inserts new A element which was making the already calculated start block parent 'null' making content to crash. The crash is avoided by doing safety checks. Bug: 792548 Change-Id: Ica9e38857edac95a7151fda993ae5ef6e7b17ca3 Reviewed-on: https://chromium-review.googlesource.com/822550Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Tanvir Rizvi <tanvir.rizvi@samsung.com> Cr-Commit-Position: refs/heads/master@{#524656}
-
Yuichiro Hanada authored
The definitions of these functions were already removed in crrev.com/1392713002. Bug: N/A Test: Build. Change-Id: Ic1ee7288776f5d6fb472057f69378303ba10ec21 Reviewed-on: https://chromium-review.googlesource.com/821973 Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Shu Chen <shuchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#524655}
-
Hiroki Nakagawa authored
This test is failing on the Linux bot. See the issue for details. Bug: 795631 Change-Id: I7fff23380fff9c4627fe88c42907ff746ec30d0c TBR: shuchen@chromium.org Reviewed-on: https://chromium-review.googlesource.com/831380Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#524654}
-
Tsuyoshi Horo authored
After this cl https://chromium-review.googlesource.com/c/v8/v8/+/806741, printTimelineRecordsWithDetails() outputs the file name of v8-cache-script.js without the port number and the directory path. So this test is continuously failing. https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_tests&tests=service-worker-v8-cache This CL doesn't completely fix the issue. But I want to update the expectation first to monitor the flakiness dashboard. Bug: 789111 Change-Id: I936f260c2bc73271cc76f67a99d691415f615103 Reviewed-on: https://chromium-review.googlesource.com/831374 Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#524653}
-
Ke He authored
Add the GeolocationControl mojo interface via which the chrome can inform the geolocation-core that user opted in to location tracking. Note that both the GeolocationServiceImpl from content and the GeolocationPermissionContext from chrome have their own mojo connections to Device Service. However, races are not an issue, as the Geolocation implementation is already equipped to handle the case where requests for geolocation come in prior to permission being granted by queuing those requests and then unblocking them on granting of permission. BUG=725044 Change-Id: I7e53f9cfd5698d09e4860ed7c869bcbd6991857a Reviewed-on: https://chromium-review.googlesource.com/760239 Commit-Queue: Ke He <ke.he@intel.com> Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#524652}
-
Kunihiko Sakamoto authored
https://crrev.com/c/826706 moved these constants to histogram_suffixes.h in, but forgot to remove them from data_reduction_proxy_metrics_observer.h. Change-Id: I52bce11ac6ba1186a3a08fc71cda3bf22b431a34 Reviewed-on: https://chromium-review.googlesource.com/831376Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#524651}
-
Hiroki Nakagawa authored
These tests are crashing on the chromium.linux/Cast Audio Linux bot. Bug: 795627 Change-Id: Ifefee9f86a15a80d5fc6a455b37482dbad264bc2 TBR: haraken@chromium.org Reviewed-on: https://chromium-review.googlesource.com/831313Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#524650}
-