- 19 Mar, 2018 40 commits
-
-
Sorin Jianu authored
Since the UpdateContext is now a ref counted type, using the iterator adds an unnecessary level of obfuscation. Also, to implement task cancellation, a mechanism is needed to relate the update task and its context, and the iterator is not appropriate for that. TBR: waffles Bug: 822990 Change-Id: I8db51b24e4ef0f9b30f434820fa6d3bd1b066e98 Reviewed-on: https://chromium-review.googlesource.com/966966 Commit-Queue: Sorin Jianu <sorin@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#544069}
-
Julia Tuttle authored
Change-Id: I8cfdb966b329d62aed531e0d22be98424e1928c4 Reviewed-on: https://chromium-review.googlesource.com/957165 Commit-Queue: Julia Tuttle <juliatuttle@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#544068}
-
https://webrtc.googlesource.com/src.git/+log/9fa35e528528..d2c8332e2b03 $ git log 9fa35e528..d2c8332e2 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ib212b904fc2c7a61b831fddb0a713b07f3f7e01f Reviewed-on: https://chromium-review.googlesource.com/968710 Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#544067}
-
jonross authored
The usage of RenderFrameSubmissionObserver in TouchActionBrowserTest is racy. This change updates the ownership of the observer to avoid that. Bug: 760181 Change-Id: I23eaab201d478a6a8948893f10158e8c9c4c4d44 Reviewed-on: https://chromium-review.googlesource.com/964241Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#544066}
-
Stephen McGruer authored
This CL aligns Chromium with the URL spec, such that we consider '#' to mark the end of the content and the start of the fragment section only. GURL::GetContent was updated to reflect this, with a special case for javascript URLs specifically (as their spec mentions including '#' in the URL content). Bug: 123004 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I49c6f4d739a2dd42eecc9947f8e75071b84e9be7 TBR: boliu@chromium.org, pfeldman@chromium.org, thakis@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I49c6f4d739a2dd42eecc9947f8e75071b84e9be7 Reviewed-on: https://chromium-review.googlesource.com/738395 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Reviewed-by:
Brett Wilson <brettw@chromium.org> Cr-Commit-Position: refs/heads/master@{#544065}
-
Jan Krcal authored
This reverts commit 2464913f. Reason for revert: crasher due to semantic changes between nano and lite and lacking unit-tests (crbug.com/822845) Original change's description: > [protobuf] Convert serialized_invalidation from nano to lite > > Bug: 782237 > Change-Id: I030322a93c71eec70fc4a53a4cb21458c63678ee > Reviewed-on: https://chromium-review.googlesource.com/856796 > Reviewed-by: Tommy Nyquist <nyquist@chromium.org> > Commit-Queue: Jan Krcal <jkrcal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#543322} TBR=nyquist@chromium.org,jkrcal@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 782237 Change-Id: Id448b779470070a5e0e2f55708f1a1a194064d02 Reviewed-on: https://chromium-review.googlesource.com/968961Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#544064}
-
Scott Violet authored
This only works for Ozone and is necessary for both UserActivityDetector and remoting. Long term we need to rewrite both of these to use something else, but for now this accomplishes what they need. BUG=822577 TEST=covered by tests Change-Id: I432cbdcce17bb199bf8bb0f00ec51de81d3c71f0 Reviewed-on: https://chromium-review.googlesource.com/967447Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#544063}
-
https://chromium.googlesource.com/angle/angle.git/+log/dfebe9b2d5d9..3761dc7bf683 $ git log dfebe9b2d..3761dc7bf --date=short --no-merges --format='%ad %ae %s' 2018-03-19 jmadill Fix infra.cq to point to new Linux configs. Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: I4ea3d545c27d0f0c81d50f9da9b548d04d1eb326 Reviewed-on: https://chromium-review.googlesource.com/968543Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#544062}
-
Ian Vollick authored
Previously, we would reposition using the backplane, but with this change, we introduce a frame around the content window that can be dragged. This change also fixes the positioning of the fullscreen toast and the close button so that they adapt to a resized window. It also removes some now-useless code for setting the center position of a gradient quad and fixes a bug in the "bounds contain children" code where we weren't updating positioning correctly for children with asymmetric padding. Bug: 799270 Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ia6d9759b3e8b6fc80bc0d1ae2f0c739cc9cd0f7f Reviewed-on: https://chromium-review.googlesource.com/967350 Commit-Queue: Ian Vollick <vollick@chromium.org> Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#544061}
-
Owen Min authored
This is a new implmentation of CloudPolicyManager. It will initialize the policy and always try to load store immediately if possible. Bug: 812641 Change-Id: I0c23fdeda4093123f7859682cd43669fefe37cfd Reviewed-on: https://chromium-review.googlesource.com/957817 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#544060}
-
Andrew Grieve authored
Reduces main dex by 4500 methods TBR=agrieve # Trivial change to DecoderService Bug: 820570 Change-Id: Ifeeb0cc768dd762c58c6a11061a17e73e12e38a1 Reviewed-on: https://chromium-review.googlesource.com/966877Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#544059}
-
Rouslan Solomakhin authored
Before this patch, Chrome would crawl for installable payment apps even when the merchant supported "basic-card" payments. This may slow down user experience unnecessarily and caused browser tests to issue network requests. This patch changes Chrome to crawl for installable payment apps only when the merchant does not support "basic-card" payments. After this patch, if merchant supports "basic-card", Chrome does not crawl for installable payment apps, so the vast majority of browser tests don't issue network requests anymore. Bug: 814740 Change-Id: I79eb156a76ef4f23b953bf399c4f616eee8ac7ad Reviewed-on: https://chromium-review.googlesource.com/963163 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#544058}
-
Jamie Madill authored
The whole set of tests seems to be flaky on Windows. Bug: 822733 Tbr: kbr@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ia99bdec79e9a3c363c10d469b134e5e076c07218 Reviewed-on: https://chromium-review.googlesource.com/968761Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#544057}
-
Dan Elphick authored
This space will be added to V8 in: https://chromium-review.googlesource.com/c/v8/v8/+/925703 TBR=ssid@chromium.org Bug: v8:7464 Change-Id: I8be023d38e717e9a55f811a4856407a09c25e403 Reviewed-on: https://chromium-review.googlesource.com/927621Reviewed-by:
Dan Elphick <delphick@chromium.org> Reviewed-by:
Primiano Tucci <primiano@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#544056}
-
Sandra Sun authored
Currently, we parse the two values in scroll-snap-align for x and y. However, according to the spec, https://drafts.csswg.org/css-scroll-snap-1/#scroll-snap-align, the two values specify the alignment in the inline axis and block axis. This patch renames the two values and handles the vertical writing mode for inline and block alignments. Bug: 821645 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I78acff0df4698b3f9c0f7443e61e3bad75379b14 Reviewed-on: https://chromium-review.googlesource.com/967890 Commit-Queue: Sandra Sun <sunyunjia@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/heads/master@{#544055}
-
David Tseng authored
This reverts commit 2f8d70bb. Reason for revert: breaks text input in ARC++ Bug: 823233 Original change's description: > Reland: Better support crosh > > Rich editables should be skipped entirely (and not fall through to output). > > Original change: > - value change events often fire on richly editable text fields. We do not really use this in the state machine for rich text, so ignore it. It often causes poor state transitions e.g. speaking "deleted" in crosh when typing. > - use the AutomationRichEditableText class in more cases. This acknowledges the usage in the wild where a page author can set role textbox on any node. When they do this it is assumed they manage a DOM selection unless they set the role on either an input or textarea where the browser does this on their behalf. > > TBR=dmazzoni@chromium.org, dtseng@chromium.org > > Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation > Change-Id: If555f157a7eeafe836929e9433891b2e7ae181df > Reviewed-on: https://chromium-review.googlesource.com/953980 > Commit-Queue: David Tseng <dtseng@chromium.org> > Reviewed-by: David Tseng <dtseng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#541684} TBR=dmazzoni@chromium.org,dtseng@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Ic585ad279e461b2b7144904180e3b1cb140e1588 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Reviewed-on: https://chromium-review.googlesource.com/968741Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#544054}
-
Eero Häkkinen authored
This also improves const correctness of FFTFrame. Bug: 822721 Change-Id: I49668b37b0ecca278ce35af293eee6e324d88f4c Reviewed-on: https://chromium-review.googlesource.com/962223Reviewed-by:
Raymond Toy <rtoy@chromium.org> Commit-Queue: Eero Häkkinen <eero.hakkinen@intel.com> Cr-Commit-Position: refs/heads/master@{#544053}
-
Stephen Chenney authored
TBR=eae@chromium.org Change-Id: Ic07dfd6318001b512e2ecf2d5ff2906234a35335 Reviewed-on: https://chromium-review.googlesource.com/968712Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#544052}
-
Anthony Berent authored
Merge the screenshot descriptions produced by the instrumentation tests into a single description. If the tests are run locally print a link to this description, if the are run remotely add a link to the description to the json file produced by test_results_presentation. Revert was https://chromium-review.googlesource.com/c/chromium/src/+/964931. The revert was because it appears that, on Android L and M, the instrumentation tests are not allowed to create, from Java, files on /data/local/tmp. This seems to be caused by an SELinux restriction. TBR=bauerb@chromium.org Bug: NONE Change-Id: Ic9352289a6eea12e95f9126d038c0fbaab295988 Reviewed-on: https://chromium-review.googlesource.com/968527Reviewed-by:
Anthony Berent <aberent@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Anthony Berent <aberent@chromium.org> Cr-Commit-Position: refs/heads/master@{#544051}
-
https://skia.googlesource.com/skia.git/+log/fe0253f8bb64..8d2ba44c9cba $ git log fe0253f8b..8d2ba44c9 --date=short --no-merges --format='%ad %ae %s' 2018-03-16 ethannicholas SPIR-V output now always includes DescriptorSet for uniforms 2018-03-19 caryclark detect deprecated methods 2018-03-19 caryclark fix fuzz 2018-03-19 borenet [recipes] Band-aid on top of a hack: pin depot_tools Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=jvanverth@chromium.org Change-Id: I2ba9613f128c75c33e4fc94b1d81eff065dd4b5f Reviewed-on: https://chromium-review.googlesource.com/968701 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#544050}
-
Hiroki Nakagawa authored
For consistency with ModuleScript, this CL renames... - WillEvaluateWorkerScript to WillEvaluateClassicScript, - DidEvaluateWorkerScript to DidEvaluateClassicScript, and - WillEvaluateImportedScript to WillEvaluateImportedClassicScript. Bug: 680046 Change-Id: I9120f1ed9d3923d901f32801d551a61bafba04ee Reviewed-on: https://chromium-review.googlesource.com/967627 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#544049}
-
Reza.Zakerinasab authored
In a few locations inside canvas code we are passing nullptr color space to SkImage::readPixels() for two purposes: - Avoid color conversion - Enforce premul / unpremul to happen in linear space This CL removes these calls and passes the correct color space. To avoid color conversion, we should always pass the color space of the source image to readPixels(). Bug: 811318 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I6be1791d2d1ce82c7c444c140a4f43e572096150 Reviewed-on: https://chromium-review.googlesource.com/946678Reviewed-by:
Justin Novosad <junov@chromium.org> Reviewed-by:
Olivia Lai <xlai@chromium.org> Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org> Cr-Commit-Position: refs/heads/master@{#544048}
-
Manuel Rego Casasnovas authored
LayoutBox::FillAvailableMeasure() was not considering the case of orthogonal elements when computing the margins. The margins ended up being properly calculated but the size of the orthogonal elements was wrong, as they considered to have more or less space than the available one. The method is modified in order to use the containing block inline size in order to resolve the percentages: https://www.w3.org/TR/css-writing-modes-3/#dimension-mapping BUG=808758 TEST=external/wpt/css/css-writing-modes/sizing-orthogonal-percentage-margin-00*.html Change-Id: Ib8c81dcd14589b3fefe806de3f8f75c000b1cac9 Reviewed-on: https://chromium-review.googlesource.com/968522 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#544047}
-
sczs authored
- Moves the New Mediator and Coordinator files to this new directory. - Also renames RecentTabsTableCoordinator to RecentTabsCoordinator. Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I7080f890e6232b796db1a3d548ee0f0624b17ec9 Reviewed-on: https://chromium-review.googlesource.com/963846Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#544046}
-
Harald Alvestrand authored
Bug: 793766 Change-Id: Ie82fc929ae81c3894f10fa0efa0867c21258f392 Reviewed-on: https://chromium-review.googlesource.com/966842Reviewed-by:
Jungshik Shin <jshin@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#544045}
-
Raphael Kubo da Costa authored
GCC is stricter than clang when it comes to class members' names and how they can change the meaning of a previously existing symbol with the same name: ../../third_party/WebKit/Source/core/layout/ScrollbarsTest.cpp:45:3: error: declaration of ‘blink::EventHandler& blink::{anonymous}::ScrollbarsTest::EventHandler()’ [-fpermissive] } ^ In file included from ../../third_party/WebKit/Source/core/layout/ScrollbarsTest.cpp:10:0: ../../third_party/WebKit/Source/core/input/EventHandler.h:79:19: error: changes meaning of ‘EventHandler’ from ‘class blink::EventHandler’ [-fpermissive] class CORE_EXPORT EventHandler final ^~~~~~~~~~~~ https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84709 contains a longer explanation, but essentially having an |EventHandler()| method can change the meaning of references to |EventHandler| in the code depending on where it is declared, which contradicts the C++ standard. Fix it by renaming the method to |GetEventHandler()|. Change-Id: Ie2fbab48e3e1f68a80f07d95ccf07bd048df1451 Reviewed-on: https://chromium-review.googlesource.com/968512 Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#544044}
-
Dominik Röttsches authored
Remove src/ from Chromium repo and retrieve HarfBuzz sources from the mirror at [1]. Cherry picks can be done by HarfBuzz OWNERS by pushing new branches to refs/heads/chromium/ of [1]. This was tested and confirmed working in:: https://chromium-review.googlesource.com/c/chromium/src/+/937502 [1] https://chromium.googlesource.com/external/github.com/harfbuzz/harfbuzz/ Bug: 814305 Change-Id: I8760f734839012b1c9c9b9b07f11fa71000e5531 Reviewed-on: https://chromium-review.googlesource.com/928761Reviewed-by:
Ben Wagner <bungeman@chromium.org> Reviewed-by:
Behdad Esfahbod <behdad@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#544043}
-
gogerald authored
This could happen when show has not been called, Bug: 721362 Change-Id: I1bae92bbf87c9ccc63326d4d1ffd7c798cb4aadc Reviewed-on: https://chromium-review.googlesource.com/968708Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#544042}
-
Raphael Kubo da Costa authored
GCC is stricter than clang when it comes to class members' names and how they can change the meaning of a previously existing symbol with the same name: Document* Document() { return &dummy_context_.GetDocument(); } ^ In file included from ../../third_party/WebKit/Source/modules/credentialmanager/CredentialsContainerTest.cpp:12:0: ../../third_party/WebKit/Source/core/dom/Document.h:248:19: error: changes meaning of ‘Document’ from ‘class blink::Document’ [-fpermissive] class CORE_EXPORT Document : public ContainerNode, ^~~~~~~~ ../../third_party/WebKit/Source/modules/credentialmanager/CredentialsContainerTest.cpp:114:72: error: declaration of ‘blink::ScriptState* blink::{anonymous}::CredentialManagerTestingContext::ScriptState()’ [-fpermissive] ScriptState* ScriptState() { return dummy_context_.GetScriptState(); } ^ In file included from ../../third_party/WebKit/Source/bindings/core/v8/ScriptValue.h:37:0, from ../../third_party/WebKit/Source/bindings/core/v8/ScriptFunction.h:34, from ../../third_party/WebKit/Source/bindings/core/v8/ScriptPromise.h:35, from ../../third_party/WebKit/Source/bindings/core/v8/ExceptionState.h:34, from ../../third_party/WebKit/Source/bindings/core/v8/V8BindingForTesting.h:8, from ../../third_party/WebKit/Source/modules/credentialmanager/CredentialsContainerTest.cpp:10: ../../third_party/WebKit/Source/platform/bindings/ScriptState.h:66:23: error: changes meaning of ‘ScriptState’ from ‘class blink::ScriptState’ [-fpermissive] class PLATFORM_EXPORT ScriptState : public RefCounted<ScriptState> { ^~~~~~~~~~~ https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84709 contains a longer explanation, but essentially having a |Document()| or |ScriptState()| method can change the meaning of references to the outside types in the code depending on where it is declared, which contradicts the C++ standard. Fix it by renaming the methods to |GetDocument()| and |GetScriptState()|. Change-Id: I037d009c52a5e44838e90d1b8ea330acf922afaa Reviewed-on: https://chromium-review.googlesource.com/968515Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#544041}
-
Raphael Kubo da Costa authored
GCC is stricter than clang when it comes to class members' names and how they can change the meaning of a previously existing symbol with the same name: ../../third_party/WebKit/Source/core/input/PointerEventManagerTest.cpp:90:3: error: declaration of ‘blink::EventHandler& blink::PointerEventManagerTest::EventHandler()’ [-fpermissive] } ^ In file included from ../../third_party/WebKit/Source/core/input/PointerEventManagerTest.cpp:8:0: ../../third_party/WebKit/Source/core/input/EventHandler.h:79:19: error: changes meaning of ‘EventHandler’ from ‘class blink::EventHandler’ [-fpermissive] class CORE_EXPORT EventHandler final ^~~~~~~~~~~~ ../../third_party/WebKit/Source/core/input/TouchEventManagerTest.cpp:21:3: error: declaration of ‘blink::EventHandler& blink::TouchEventManagerTest::EventHandler()’ [-fpermissive] } ^ In file included from ../../third_party/WebKit/Source/core/input/TouchEventManagerTest.cpp:9:0: ../../third_party/WebKit/Source/core/input/EventHandler.h:79:19: error: changes meaning of ‘EventHandler’ from ‘class blink::EventHandler’ [-fpermissive] class CORE_EXPORT EventHandler final ^~~~~~~~~~~~ https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84709 contains a longer explanation, but essentially having an |EventHandler()| method can change the meaning of references to |EventHandler| in the code dependending on where it is declared, which contradicts the C++ standard. Fix it by renaming the method to |GetEventHandler()|. Change-Id: I2d54280bb86a2af0bc9920115ba16fdb49ad7186 Reviewed-on: https://chromium-review.googlesource.com/968491Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#544040}
-
Benoit Lize authored
Allows the client to set a referrer policy for the parallel request. Bug: 816837 Change-Id: I0a7525fa90079f5dd971e3bfe5565a0fb3c3b10b Reviewed-on: https://chromium-review.googlesource.com/966443Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#544039}
-
Finnur Thorarinsson authored
Remove helper functions for posting tasks and a bit of header cleanup. Note: This was split of from review: https://chromium-review.googlesource.com/c/chromium/src/+/963685 Bug: 734095 Change-Id: If3a58f70c1ffcc63c2998adc27eb885f20f8fe46 Reviewed-on: https://chromium-review.googlesource.com/963324 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Xi Cheng <chengx@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#544038}
-
Fredrik Söderquist authored
Restructure the code so that traversing a LayoutObject's resources is shared, and rename ResourceContainsCycles to TraverseResourceContainer. Hoist the side-effects (clearing out resources with cycles) to the caller. Bug: 534817, 769774 Change-Id: Icd8200a2cd9073487479e32827a9fdeb1d8d04c4 Reviewed-on: https://chromium-review.googlesource.com/966661Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#544037}
-
xlai authored
Same as canvas.toBlob(), the OffscreenCanvas.convertToBlob() are running on idle tasks by default. When idle tasks do not begin for a long time, they force encoding on the current thread. As idle tasks are not enabled on layout tests unless "--enable-threaded-compositing" flag is turned on, we therefore do both virtual and non-virtual tests to ensure complete test coverage of both execution paths--idle-task mode and force-encoding mode. The non-virtual tests need to be marked as [Slow] as the CanvasAsyncBlobCreator is waiting for the idle tasks for a threshold time before switching to force-encoding mode. Bug: 817091 Change-Id: I2c7da9e27ee2d24e1a5e6ee1c36597b46f052aca Reviewed-on: https://chromium-review.googlesource.com/964395Reviewed-by:
Justin Novosad <junov@chromium.org> Commit-Queue: Olivia Lai <xlai@chromium.org> Cr-Commit-Position: refs/heads/master@{#544036}
-
Michael Lippautz authored
Bug: chromium:757440 Change-Id: Ibb3961a8ccf96578e4b5493714a79a0a55411025 Reviewed-on: https://chromium-review.googlesource.com/968506 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#544035}
-
Robert Kaplow authored
Currently if there is no whitelist, we record everything. We shouldn't do this since if a user has no field trial params (first run, etc.), they will record everything, avoiding the whitelist. Also changed a bitwise and to && while I was making a change. No-op but seems bad style (and apparently can be different as & doesn't shortcut). Bug: 820632 Change-Id: I3fd3b1ca6669294e61467bb0f4d0ad87fb2ff576 Reviewed-on: https://chromium-review.googlesource.com/957384 Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#544034}
-
Anthony Vallee-Dubois authored
Bug: NONE Change-Id: If299b18f98887d02f9db800effcda4ddc3e11e5a Reviewed-on: https://chromium-review.googlesource.com/968670 Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#544033}
-
Antoine Labour authored
Perhaps counterintuitively, Elf64_Word is 32 bits. Don't use it to manipulate file sizes. BUG=780860 Change-Id: I0a80e10b46400dcd0e0e43061755494267d67a06 Reviewed-on: https://chromium-review.googlesource.com/954326 Commit-Queue: Michael Moss <mmoss@chromium.org> Reviewed-by:
Michael Moss <mmoss@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#544032}
-
Raphael Kubo da Costa authored
GCC is stricter than clang when it comes to class members' names and how they can change the meaning of a previously existing symbol with the same name: ../../third_party/WebKit/Source/core/frame/LocalFrameViewTest.cpp:72:77: error: declaration of ‘blink::{anonymous}::AnimationMockChromeClient& blink::{anonymous}::LocalFrameViewTest::ChromeClient() const’ [-fpermissive] AnimationMockChromeClient& ChromeClient() const { return *chrome_client_; } ^ In file included from ../../third_party/WebKit/Source/core/loader/EmptyClients.h:39:0, from ../../third_party/WebKit/Source/core/layout/LayoutTestHelper.h:17, from ../../third_party/WebKit/Source/core/frame/LocalFrameViewTest.cpp:10: ../../third_party/WebKit/Source/core/page/ChromeClient.h:94:19: error: changes meaning of ‘ChromeClient’ from ‘class blink::ChromeClient’ [-fpermissive] class CORE_EXPORT ChromeClient : public PlatformChromeClient { ^~~~~~~~~~~~ https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84709 contains a longer explanation, but essentially having a |ChromeClient()| method can change the meaning of references to |ChromeClient| in the code dependending on where it is declared, which contradicts the C++ standard. Fix it by renaming the method to |GetAnimationMockChromeClient()|. Change-Id: I3d92e960384ba6b8d1885f7fed2618085ce19855 Reviewed-on: https://chromium-review.googlesource.com/968425Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#544031}
-
Daniel Vogelheim authored
Increases fuzzer coverage to match changes in cl 924187. Hopefully also fixes the referenced bug, because this now explicitly initializes CachedDocumentParameters::integrity_features when called from the fuzzer. Bug: 818396 Change-Id: Ica18606543bd5cb36df567a132a6fe2b1da9620f Reviewed-on: https://chromium-review.googlesource.com/968508 Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#544030}
-