GitLab

This also fixes views::TextButton so that the focus rect is drawn
with an appropriate inset.

TEST=Trigger an infobar (Translate, Save Password, etc.), type Ctrl+L to focus location bar, press Tab to focus controls in info bar.

Review URL: http://codereview.chromium.org/8439015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108202 0039d316-1c4b-4281-b951-d872f2087c98

TEST=should be enabled by default and disablable in about:flags
BUG=none
Review URL: http://codereview.chromium.org/8387060

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108200 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108199 0039d316-1c4b-4281-b951-d872f2087c98

TBR=caseq
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/8438019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108198 0039d316-1c4b-4281-b951-d872f2087c98

Cleanup: No need to dynamically allocate a couple class members in mime_util_xdg.cc. Also convert a dynamically allocated class member to a scoper.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/8372047

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108197 0039d316-1c4b-4281-b951-d872f2087c98

BUG=102584
TBR=nsylvain@chromium.org
Review URL: http://codereview.chromium.org/8351058

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108196 0039d316-1c4b-4281-b951-d872f2087c98

UnzipEvil and UnzipEvil2 check that we don't extract files containing ..
in their file names. These tests failed if we had
"levilevilevilevilevilevilevilevilevilevilevilevil" and "evil.txt" in /tmp
on Linux, as we were checking the existence of these files from a temporary
directory like /tmp/.org.chromium.Chromium.aXW1Gx.

We should create a directory one level deeper to fix the subtle issue.

TEST=touch /tmp/levilevilevilevilevilevilevilevilevilevilevilevil /tmp/evil.txt; out/Release/unit_tests --gtest_filter=ZipTest.*
BUG=chromium-os:22351


Review URL: http://codereview.chromium.org/8437016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108195 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=


Review URL: http://codereview.chromium.org/8438010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108194 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=sky
Review URL: http://codereview.chromium.org/8423025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108193 0039d316-1c4b-4281-b951-d872f2087c98

 With this CL, window is now correctly maximized/fullscreen'ed on aura desktop.

* Added OnPropertyChanged to WindowObserver
* Added Get/Set IntProperty to simplify handling int value properties.
* Remove IsOrContainsFullscreen. Added Workspace::ContainsFullscreen instead. We need this to autohide launcher.

BUG=97257,97259
TEST=new test for property change notification. existing tests are updated, except maximized/fullscreen drag test. I'll add it to new set of tests that verifies window dragging within workspace.

Review URL: http://codereview.chromium.org/8400063

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108192 0039d316-1c4b-4281-b951-d872f2087c98

BUG=92254
TEST=AudioRendererBaseTest::Underflow_EndOfStream


Review URL: http://codereview.chromium.org/8430015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108191 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8439019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108190 0039d316-1c4b-4281-b951-d872f2087c98

use of legacy callbacks and generally simplifies the implementation. Also migrate one instance
of NewRunnableMethod to base::Bind().

BUG=98478
Review URL: http://codereview.chromium.org/8390018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108189 0039d316-1c4b-4281-b951-d872f2087c98

Updated TypedUrlChangeProcessor to handle ADDs and UPDATEs in the sync DB identically.

Also removed our code that explicitly sets the title in the history DB as that
should not be necessary (it's already set by UpdateURLRow).

Finally, removed our code that was setting last_visit_time since that is also
updated automatically by the history code when we add/remove visits. We still
set it when we initially add the URL to the DB, but that's only because the
history code requires it - we technically don't need to since we always manually
add visits immediately afterward.

BUG=101633
TEST=existing tests suffice


Review URL: http://codereview.chromium.org/8414043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108188 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8440018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108187 0039d316-1c4b-4281-b951-d872f2087c98

BUG=102408
TEST=See bug

Review URL: http://codereview.chromium.org/8372036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108186 0039d316-1c4b-4281-b951-d872f2087c98

Linux: Use the existing desktop environment detection code in mime_util_xdg.cc instead of its own version. Also fix a case where we look up bad icon names.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/8431018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108185 0039d316-1c4b-4281-b951-d872f2087c98

Also adds some extra error logging.

BUG=None
TEST=Go into curtain mode on 10.7 and then disconnect the session.


Review URL: http://codereview.chromium.org/8384011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108184 0039d316-1c4b-4281-b951-d872f2087c98

notifications.NotificationsTest.testOriginPrefsNotSavedInIncognito

BUG=chromium:102549
TEST=None

Review URL: http://codereview.chromium.org/8438018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108183 0039d316-1c4b-4281-b951-d872f2087c98

BUG=100928
TEST=see bug


Review URL: http://codereview.chromium.org/8423018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108182 0039d316-1c4b-4281-b951-d872f2087c98

The NAT traversal default for all platforms is now true.


BUG=97689
TEST=None


Review URL: http://codereview.chromium.org/8423020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108181 0039d316-1c4b-4281-b951-d872f2087c98

R=groby@chromium.org
BUG=None
TEST=*Intent*.*


Review URL: http://codereview.chromium.org/8417043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108180 0039d316-1c4b-4281-b951-d872f2087c98

is needed for bubbles.

BUG=none
TEST=none
R=ben@chromium.org

Review URL: http://codereview.chromium.org/8351042

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108179 0039d316-1c4b-4281-b951-d872f2087c98

Previously callbackees had to remember to store the buffer in a scoped_refptr<>.

Review URL: http://codereview.chromium.org/8351045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108178 0039d316-1c4b-4281-b951-d872f2087c98

Specifically, catch it when MessageLoop is not running.

BUG=96847
TEST=none


Review URL: http://codereview.chromium.org/8343033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108177 0039d316-1c4b-4281-b951-d872f2087c98

my last patch r108172 uninentionally reverted r107999 (due to my own fumbilng with git). So this re-applies it.

TBR=erg

Review URL: http://codereview.chromium.org/8372046

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108176 0039d316-1c4b-4281-b951-d872f2087c98

No need, we delayload now

BUG=none
TEST=chrome runs on XP

Review URL: http://codereview.chromium.org/8386011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108175 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None


Review URL: http://codereview.chromium.org/8440008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108174 0039d316-1c4b-4281-b951-d872f2087c98

TBR=bshe@chromium.org
BUG=102546
TEST=

Review URL: http://codereview.chromium.org/8439014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108173 0039d316-1c4b-4281-b951-d872f2087c98

TopSites was returning just 8 (because that is how many MostVisited needs). However now that we can have more than one consumer of TopSites (the other being an extension), we should leave it up to the consumer to decide how many they want to use. (most_visited.js already slices off the top 8 so no change is needed there)

BUG=100394
TEST=manual

Review URL: http://codereview.chromium.org/8401026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108172 0039d316-1c4b-4281-b951-d872f2087c98

This was missing from r106538

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8437011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108171 0039d316-1c4b-4281-b951-d872f2087c98

BUG=81752
TEST=


Review URL: http://codereview.chromium.org/8343079

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108170 0039d316-1c4b-4281-b951-d872f2087c98

It allows a D3D9Ex render target texture to be drawn in one process and presented to a Window in another. Presentation is done by a pool of 4 threads so that multiple (up to 4) windows can be presented at full frame rate.

It also deals with acknowleding when it is safe for the producer to render the next frame.

There are some complications with D3D and threading. Even when a device is created with the MULTITHREAD flag, there are limitations to what can be done. Only the thread that creates the device can reset it or destroy it. Therefore each Accelerated surface keeps track of which thread that is. Any thread can present so a simple round robin scheduler assigns presents to the least recently used thread.

It'll be used by this: 
http://codereview.chromium.org/8060045/
Review URL: http://codereview.chromium.org/8395012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108169 0039d316-1c4b-4281-b951-d872f2087c98

TEST=None
BUG=None

Review URL: http://codereview.chromium.org/8440013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108168 0039d316-1c4b-4281-b951-d872f2087c98

Should allow us to fully convert all bubbles (bookmark, etc.)
Use separate border and contents widgets (like old bubble).
Supports transparency/opacity with fading, etc.
Remove BubbleView remnants; update tests.

BUG=98312
TEST=No views_examples bubble problems.

Review URL: http://codereview.chromium.org/8368006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108167 0039d316-1c4b-4281-b951-d872f2087c98

of fixed position elements.

BUG=None
TEST=Manual testing to verify the flag works.
Review URL: http://codereview.chromium.org/8404026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108166 0039d316-1c4b-4281-b951-d872f2087c98

BUG=95573
TEST=no change in functionality

Review URL: http://codereview.chromium.org/8440001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108165 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jsbell@chromium.org
R=jsbell@chromium.org
BUG=102537
TEST=

Review URL: http://codereview.chromium.org/8440012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108164 0039d316-1c4b-4281-b951-d872f2087c98

BUG=76992
TEST=Autofill continues to upload form data to the crowdsourcing server


Review URL: http://codereview.chromium.org/8387016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108162 0039d316-1c4b-4281-b951-d872f2087c98

(font-size, checkbox, radio button, adding new language page)



1. Change font size to 16px. This font size proves to be more touch 
friendly while not affecting layout.
2. Rescale the checkbox and radio button. They were too tiny to touch.
3. Use drop down menu for adding new languages overlay page in touch ui builds.

BUG=100377
TEST=None


Review URL: http://codereview.chromium.org/8417029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108161 0039d316-1c4b-4281-b951-d872f2087c98